mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-31 06:04:11 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Connected chats show safe notices when a run starts, waits, finishes, or fails. > - A recurring scan projected these notices even when no eligible work existed. > - Eligibility depends on committed run state, conversation lineage, and current authority. > - Existing database rows can reconstruct that work after restart. > - This PR wakes a scoped worker from those writes and removes lifecycle polling. > - Native progress events keep their separate existing owner until the next migration. ## Linked Issues or Issue Description **What happened?** The chat maintenance timer repeatedly scanned run lifecycle state. Empty and settled instances still queried the database. A run-status event alone cannot replace the scan: prompt receipts, continuation receipts, identity changes, and restored authority can make a run eligible later. **What did you expect?** Committed changes wake projection. Startup reconstructs eligible work. A completed pass stops until another relevant change arrives. Failed work retains recovery without scanning settled history forever. **Steps to reproduce** Configure an automatic chat endpoint. Finish its work, or leave it unused. Observe recurring lifecycle projection queries from the chat maintenance callback. Stacked on #17592. Related foundation: #15625. This PR owns lifecycle milestones only. ## What Changed - Preserve upstream coalesced Cloud membership writes together with locked membership restoration and its committed chat notification. - Signal milestone eligibility from the real Slack account-link transaction. - Register the lifecycle worker with the existing delivery coordinator. Remove lifecycle projection from the periodic chat callback. Keep native progress in a separately named lane and preserve the explicit combined API. - Reconstruct company/issue scopes from the existing selector. Drain bounded batches with company fairness. Retry failures, retain writes through drain/resume, and disarm settled work. - Signal from supported run, presentation, interaction, receipt, lineage, conversation, recovery, and authority writers. Preserve their transaction ownership, including nested savepoints and uncertain settlement. No new table is added. - Preserve provider authorization, authored-final suppression, responsible-user continuity, deduplication, the 24-hour selection window, and raw-output restrictions. Keep provider interpretation in its owner. - Preserve PostgreSQL timestamp precision in lifecycle pagination. Rejected submillisecond candidates must not repeat the same page and starve later notices. - Document producer coverage and alternate-writer dispositions in `doc/plans/2026-10-25-chat-run-milestone-sleep-audit.md`. ## Verification Published head: `1d056f68c5b1005933b9e12de8745bf1c4cbeeca`, targeting master after #17592 merged at `7d75ae0569e41786640cf09647ae8849411d2f22`. A normal merge integrates the actual landed parent. The entire 77-path milestone patch is binary-identical to the locally verified preparation across that ancestry reconciliation; both unrelated master paths are preserved. The four earlier producer/test integration conflicts retain scoped milestone and voice notices, current onboarding completion admission, and expanded identity query/read-scope coverage. - **330 distinct selected cases pass on the verified unchanged patch:** 305 across 14 complete suites (all five milestone worker suites, run identity, board claim, Cloud provisioning, auth session routes, Cloud actor authentication, stale-lock recovery, GitHub credentials, project Git authorization, and app admission wiring), plus 25 selected real chat producer cases. The remaining 1,590 chat integration cases were skipped, not passed. - The real producer cases cover saved milestone discovery, GitHub and Slack identity changes, account-link rollback/reconfirmation, ordinary ingress reactivation, post-close action/delivery receipt settlement, all ten authority-restoration paths including Cloud synchronization, and changed native review metadata. - Worker coverage verifies outer commit, rollback, uncertain-write recovery, restart, bounded batching/fairness, timestamp precision, retries, drain/resume, and settled SQL quiet. Authorization and existing publication deduplication remain with their owning services. - Server production typechecking, build, and module-boundary checks pass. The tests above were executed separately. Production typechecking excludes `src/__tests__` and does not replace those runs. Each database owner uses its own newly created and app-migrated PostgreSQL fixture. - [Current-parent acceptance and preserved failure ledger](https://github.com/paperclipai/paperclip/blob/1d056f68c5b1005933b9e12de8745bf1c4cbeeca/doc/plans/2026-10-25-chat-run-milestone-sleep-audit.md#current-parent-integration-and-acceptance-october-28) records commands, counts, producer scope, conflict dispositions, and limits. Earlier combined-stack counts and failures keep their original revision scope; local acceptance does not erase old CI failures. - No new migration, queue table, dependency, workflow, or shared scheduler contract is introduced. Parent migration 0397, bounded consent recovery, voice cleanup/retention repairs, and runner checkpoint restoration remain present. - **Exact-head Greptile is 5/5 and all 55 current checks are clean.** No Ponytail review is present, which is an explicitly authorized nonblocker; no failing review is waived. Older reviews and parent checks are not current passes. Actual failing Ponytail findings must be fixed; an absent/stopped/paused turn without a verdict is an authorized nonblocker. Active unfinished Ponytail uses its original request/start timer, with a 25-minute monitor cutoff respecting the user's 30-minute maximum. - No complete local repository matrix, live provider tenant, external alarm, physical host/database suspension, or fleet savings claim is made. Native progress remains a separate following slice. ## Risks - A future eligibility writer must notify the existing projection boundary. Independent SQL writers or another active server process are outside this process-local signal contract. - Authority and lineage remain sensitive. The worker uses the existing selectors and publication policy; it does not grant execution or disclosure authority. - Native progress and other publication maintenance still have recurring work. This PR removes one reason, not the entire chat maintenance timer. - Worker quiet does not prove database suspension, host sleep, or external alarm coverage. Cloud sleep blockers remain unchanged. - Merge eligibility requires passing current-head CI and Greptile 5/5 after this actual-master reconciliation. Subsequent stack slices retain their own gates. ## Model Used OpenAI Codex, GPT-6 family. The exact serving model ID and context-window size are not exposed. Used repository inspection, reasoning, shell execution, PostgreSQL tests, browser E2Es and GitHub tools. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details available in this session) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run the documented focused tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
145 lines
8.2 KiB
TypeScript
145 lines
8.2 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { installDatabaseWorkSignals } from "../../../packages/db/src/work-signals.js";
|
|
import { createDeliveryWorkCoordinator } from "../services/delivery-work-coordinator.js";
|
|
import { registerChatActionWork } from "../services/chat-action-work.js";
|
|
import { CHAT_ACTION_QUEUES, notifyChatActionWork, notifyChatEndpointWork, notifyChatVerificationWork } from "../services/chat-work-notifications.js";
|
|
|
|
const coordinators: ReturnType<typeof createDeliveryWorkCoordinator>[] = [];
|
|
afterEach(async () => {
|
|
for (const coordinator of coordinators.splice(0)) await coordinator.stop();
|
|
vi.useRealTimers();
|
|
});
|
|
function setup() {
|
|
vi.useFakeTimers();
|
|
const execute = vi.fn(async () => [{ xid: "42", status: "committed" }]);
|
|
const owner = installDatabaseWorkSignals({ execute, async transaction(callback: (tx: any) => Promise<any>) {
|
|
return callback({ execute });
|
|
} });
|
|
const enabled = vi.fn(() => true), onError = vi.fn();
|
|
const coordinator = createDeliveryWorkCoordinator({ owner, canRun: enabled, canReconcile: enabled, onError });
|
|
coordinators.push(coordinator);
|
|
const service = {
|
|
processFailedChatRunRetries: vi.fn(async () => {}),
|
|
processPendingTelegramActions: vi.fn(async () => {}),
|
|
processTelegramSubscriptionDiscovery: vi.fn(async () => {}),
|
|
scheduleTelegramSubscriptionDiscovery: vi.fn(),
|
|
hasPendingTelegramSubscriptionDiscovery: vi.fn(() => false),
|
|
processPendingProviderEffects: vi.fn(async () => {}),
|
|
processPendingGitHubWebhookIngress: vi.fn(async () => {}),
|
|
processPendingSlackSessionSyncs: vi.fn(async () => {}),
|
|
processPendingSlackBoardMessages: vi.fn(async () => {}),
|
|
processPendingSlackTaskStarts: vi.fn(async () => {}),
|
|
processPendingReceiptReactions: vi.fn(async () => {}),
|
|
processPendingSlackSessionStops: vi.fn(async () => {}),
|
|
processPendingVerificationMessages: vi.fn(async () => {}),
|
|
nextChatActionAt: vi.fn(async (): Promise<number | null> => null),
|
|
nextVerificationMessageAt: vi.fn(async (): Promise<number | null> => null),
|
|
};
|
|
const runs = [service.processFailedChatRunRetries, service.processPendingTelegramActions, service.processPendingProviderEffects, service.processPendingGitHubWebhookIngress, service.processPendingSlackSessionSyncs, service.processPendingSlackBoardMessages, service.processPendingSlackTaskStarts,
|
|
service.processPendingReceiptReactions, service.processPendingSlackSessionStops, service.processPendingVerificationMessages];
|
|
return { owner, service, runs, coordinator, enabled, onError, start: () => registerChatActionWork(coordinator, service, enabled) };
|
|
}
|
|
describe("chat action scheduling", () => {
|
|
it("retains configuration commits during discovery and retries discovery failures", async () => {
|
|
const s = setup();
|
|
let release!: () => void;
|
|
s.service.processTelegramSubscriptionDiscovery.mockImplementationOnce(() => new Promise<void>(resolve => { release = resolve; }));
|
|
const work = s.start();
|
|
await vi.advanceTimersByTimeAsync(1);
|
|
expect(s.service.processTelegramSubscriptionDiscovery).toHaveBeenCalledTimes(1);
|
|
await s.owner.transaction(tx => notifyChatEndpointWork(tx, "connection-fixture", "company-fixture"));
|
|
expect(s.service.scheduleTelegramSubscriptionDiscovery).toHaveBeenCalledWith("connection-fixture");
|
|
s.service.processTelegramSubscriptionDiscovery.mockRejectedValueOnce(new Error("discovery unavailable"));
|
|
release();
|
|
await work.ready;
|
|
await vi.advanceTimersByTimeAsync(1);
|
|
expect(s.service.processTelegramSubscriptionDiscovery).toHaveBeenCalledTimes(2);
|
|
expect(s.onError).toHaveBeenCalledTimes(1);
|
|
await vi.advanceTimersByTimeAsync(1000);
|
|
expect(s.service.processTelegramSubscriptionDiscovery).toHaveBeenCalledTimes(3);
|
|
await vi.advanceTimersByTimeAsync(3_600_000);
|
|
expect(s.service.processTelegramSubscriptionDiscovery).toHaveBeenCalledTimes(3);
|
|
expect(s.coordinator.nextWakeAt()).toBeNull();
|
|
});
|
|
it("does one startup scan per lane and no more SQL or timers during an idle hour", async () => {
|
|
const s = setup();
|
|
await s.start().ready;
|
|
await vi.advanceTimersByTimeAsync(3_600_000);
|
|
for (const run of s.runs) expect(run).toHaveBeenCalledTimes(1);
|
|
expect(s.service.nextChatActionAt).toHaveBeenCalledTimes(9);
|
|
expect(s.service.processTelegramSubscriptionDiscovery).toHaveBeenCalledTimes(1);
|
|
expect(s.service.scheduleTelegramSubscriptionDiscovery).not.toHaveBeenCalled();
|
|
expect(s.service.nextVerificationMessageAt).toHaveBeenCalledTimes(1);
|
|
expect(s.coordinator.nextWakeAt()).toBeNull();
|
|
expect(vi.getTimerCount()).toBe(0);
|
|
});
|
|
it("wakes each lane after its write settles and wakes parked work when an endpoint changes", async () => {
|
|
const s = setup();
|
|
await s.start().ready;
|
|
for (const kind of Object.keys(CHAT_ACTION_QUEUES) as (keyof typeof CHAT_ACTION_QUEUES)[]) {
|
|
await s.owner.transaction(async tx => {
|
|
await notifyChatActionWork(tx, kind);
|
|
expect(s.runs.every(run => run.mock.calls.length === 1)).toBe(true);
|
|
});
|
|
}
|
|
await s.owner.transaction(tx => notifyChatVerificationWork(tx));
|
|
await vi.advanceTimersByTimeAsync(1);
|
|
for (const run of s.runs) expect(run).toHaveBeenCalledTimes(2);
|
|
// Queue claims/settlements do not rediscover every configured endpoint.
|
|
expect(s.service.processTelegramSubscriptionDiscovery).toHaveBeenCalledTimes(1);
|
|
await s.owner.transaction(tx => notifyChatEndpointWork(tx, "connection-fixture", "company-fixture"));
|
|
await vi.advanceTimersByTimeAsync(1);
|
|
for (const run of s.runs) expect(run).toHaveBeenCalledTimes(3);
|
|
expect(s.service.processTelegramSubscriptionDiscovery).toHaveBeenCalledTimes(2);
|
|
expect(vi.getTimerCount()).toBe(0);
|
|
});
|
|
it("restores durable deadlines and reschedules when a foreground send moves a retry earlier", async () => {
|
|
const s = setup();
|
|
let due: number | null = Date.now() + 120_000;
|
|
s.service.nextChatActionAt.mockImplementation(async () => due);
|
|
await s.start().ready;
|
|
expect(s.coordinator.nextWakeAt()).toBe(due);
|
|
await vi.advanceTimersByTimeAsync(1000);
|
|
due = Date.now() + 30_000;
|
|
await s.owner.transaction(tx => notifyChatActionWork(tx, "receipt_reaction"));
|
|
await vi.advanceTimersByTimeAsync(1);
|
|
expect(s.coordinator.nextWakeAt()).toBe(due);
|
|
expect(s.service.processPendingReceiptReactions).toHaveBeenCalledTimes(2);
|
|
due = null;
|
|
await vi.advanceTimersByTimeAsync(30_000);
|
|
expect(s.service.processPendingReceiptReactions).toHaveBeenCalledTimes(3);
|
|
await vi.advanceTimersByTimeAsync(120_000);
|
|
expect(s.coordinator.nextWakeAt()).toBeNull();
|
|
});
|
|
it("keeps lanes independent and retains a commit received during a drain", async () => {
|
|
const s = setup();
|
|
let release!: () => void;
|
|
s.service.processPendingSlackBoardMessages.mockImplementationOnce(() => new Promise(resolve => { release = resolve; }));
|
|
const work = s.start();
|
|
await vi.advanceTimersByTimeAsync(1);
|
|
await s.owner.transaction(tx => notifyChatActionWork(tx, "slack_board_message"));
|
|
await s.owner.transaction(tx => notifyChatActionWork(tx, "slack_session_stop"));
|
|
await vi.advanceTimersByTimeAsync(1);
|
|
expect(s.service.processPendingSlackSessionStops).toHaveBeenCalledTimes(2);
|
|
release(); await work.ready;
|
|
await vi.advanceTimersByTimeAsync(1);
|
|
expect(s.service.processPendingSlackBoardMessages).toHaveBeenCalledTimes(2);
|
|
});
|
|
it("retries failed recovery and does no dispatch or deadline queries during standby", async () => {
|
|
const s = setup();
|
|
s.enabled.mockReturnValue(false);
|
|
await s.start().ready;
|
|
await vi.advanceTimersByTimeAsync(2000);
|
|
expect(s.service.nextChatActionAt).not.toHaveBeenCalled();
|
|
expect(s.service.processTelegramSubscriptionDiscovery).not.toHaveBeenCalled();
|
|
for (const run of s.runs) expect(run).not.toHaveBeenCalled();
|
|
s.enabled.mockReturnValue(true);
|
|
s.service.processPendingSlackTaskStarts.mockRejectedValueOnce(new Error("DB unavailable"));
|
|
await vi.advanceTimersByTimeAsync(1000);
|
|
expect(s.onError).toHaveBeenCalledTimes(1);
|
|
await vi.advanceTimersByTimeAsync(1000);
|
|
expect(s.service.processPendingSlackTaskStarts).toHaveBeenCalledTimes(2);
|
|
expect(vi.getTimerCount()).toBe(0);
|
|
});
|
|
});
|