mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-23 17:33:51 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Agent work often ends with a Markdown or plain-text file. > - Task attachments currently open outside the task panel. > - Users need to inspect those files while keeping the task conversation in view. > - This pull request opens text attachments in task tabs and adds rendered, raw, and download controls. > - The same controls work in the mobile task drawer. ## Linked Issues or Issue Description **What happened?** Opening a text attachment did not put its content in a task tab. Markdown files had no in-task rendered/raw toggle. **Expected behavior** Open Markdown and text attachments in one reusable task tab. Show Markdown as rendered content or raw text. Download the original file. **Steps to reproduce** 1. Upload a Markdown file and a plain-text file to a task comment. 2. Open each attachment from the task conversation or artifact list. 3. Switch Markdown between Rendered and Raw. Download both files. 4. Repeat at a mobile viewport width. Related work: #14193 controls artifact tab arrival. This change adds text attachment content tabs. ## What Changed - Route text attachment opens from conversation and artifact cards into task tabs. - Add a text attachment panel with accessible Rendered, Raw, and Download controls. - Preserve ordinary links for other file types. - Support the selected attachment in the mobile drawer. - Keep text-tab actions on the current rich artifact cards, including CSV previews. - Render attachment image references and diagram source without loading media URLs. - Add browser regression tests, component tests, Storybook examples, and usage documentation. ## Verification - Full workspace typecheck, production build, Storybook build, and UI token gates pass locally. - All 6,960 UI tests pass. The additional media regression passes against the real Markdown renderer and fails before the fix. CSV coverage verifies direct downloads and text tabs after preview. - Both desktop and mobile browser cases pass locally. They check rendered/raw Markdown, literal plain text, reusable tabs, review controls, and exact original download bytes. The local fixture used a separate database port because an existing socket occupied the default range. - The full CI test matrix passes on `82be5efbef26927b237a031725bb3d7fa79f637f`. The duplicate local `pnpm test:run` was stopped after this CI result; it did not complete locally. - Greptile is 5/5 on the final commit. All review threads are resolved, and the security scan passes. - All 54 final-head checks pass, including the canary dry run. The two optional Storybook jobs are skipped. ## Risks - Text attachment links now open in the task panel. Other content types keep their existing link behavior. - File display still depends on the existing authenticated attachment route. There are no API or database changes. - Raw text is displayed as text, including strings that look like HTML. Rendered Markdown keeps media references inert. ## Model Used OpenAI Codex, based on GPT-6, with code execution, browser testing, and subagent tool use. The runtime does not expose an exact serving model variant or context-window size. Recovered earlier implementation changes were reviewed and tested; their exact model metadata is unavailable. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
89 lines
3.5 KiB
TypeScript
89 lines
3.5 KiB
TypeScript
// @vitest-environment jsdom
|
|
import { act } from "react";
|
|
import { createRoot } from "react-dom/client";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import { IssueArtifactFile } from "./IssueArtifactCard";
|
|
import { loadArtifactCsv } from "@/lib/artifact-card-data";
|
|
import { TextAttachmentContext } from "@/context/TextAttachmentContext";
|
|
|
|
vi.mock("@/lib/artifact-card-data", async (importOriginal) => ({
|
|
...(await importOriginal<typeof import("@/lib/artifact-card-data")>()),
|
|
loadArtifactCsv: vi.fn(),
|
|
}));
|
|
|
|
describe("CSV preview consent", () => {
|
|
it("does not fetch any CSV until its preview is requested", async () => {
|
|
const load = vi
|
|
.mocked(loadArtifactCsv)
|
|
.mockResolvedValue({
|
|
columns: ["Name"],
|
|
rows: [["Actual row"]],
|
|
truncated: false,
|
|
});
|
|
const container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
const root = createRoot(container);
|
|
const client = new QueryClient({
|
|
defaultOptions: { queries: { retry: false } },
|
|
});
|
|
const openText = vi.fn();
|
|
try {
|
|
await act(async () =>
|
|
root.render(
|
|
<QueryClientProvider client={client}>
|
|
<TextAttachmentContext.Provider value={openText}>
|
|
{Array.from({ length: 20 }, (_, i) => (
|
|
<IssueArtifactFile
|
|
key={i}
|
|
id={`csv-${i}`}
|
|
attachmentId={`attachment-${i}`}
|
|
title={`Data ${i}`}
|
|
summary=""
|
|
author=""
|
|
updatedAt="Today"
|
|
filename={`report-${i}.csv`}
|
|
contentType="text/csv"
|
|
contentPath={`/api/attachments/csv-${i}/content`}
|
|
downloadPath={`/api/attachments/csv-${i}/content?download=1`}
|
|
byteSize={100}
|
|
/>
|
|
))}
|
|
</TextAttachmentContext.Provider>
|
|
</QueryClientProvider>,
|
|
),
|
|
);
|
|
expect(load).not.toHaveBeenCalled();
|
|
const open = container.querySelector<HTMLButtonElement>('button[aria-label="Open in tab: Data 0"]');
|
|
await act(async () => open!.click());
|
|
expect(openText).toHaveBeenCalledWith("attachment-0", "report-0.csv");
|
|
expect(load).not.toHaveBeenCalled();
|
|
const preview = Array.from(container.querySelectorAll("button")).find(
|
|
(button) => button.textContent === "Preview data",
|
|
);
|
|
expect(preview).toBeDefined();
|
|
await act(async () => preview!.click());
|
|
await vi.waitFor(() =>
|
|
expect(container.textContent).toContain("Actual row"),
|
|
);
|
|
expect(load).toHaveBeenCalledTimes(1);
|
|
expect(load).toHaveBeenCalledWith(
|
|
"/api/attachments/csv-0/content",
|
|
expect.any(AbortSignal),
|
|
);
|
|
expect(container.textContent).toContain("View data");
|
|
const download = container.querySelector<HTMLAnchorElement>('a[download="report-0.csv"]');
|
|
expect(download?.textContent).toBe("Download file");
|
|
expect(download?.getAttribute("href")).toBe("/api/attachments/csv-0/content?download=1");
|
|
const openAfterPreview = container.querySelector<HTMLButtonElement>('button[aria-label="Open in tab: Data 0"]');
|
|
await act(async () => openAfterPreview!.click());
|
|
expect(openText).toHaveBeenCalledTimes(2);
|
|
} finally {
|
|
await act(async () => root.unmount());
|
|
client.clear();
|
|
container.remove();
|
|
vi.clearAllMocks();
|
|
}
|
|
});
|
|
});
|