mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-14 08:26:46 +02:00
## Thinking Path > - Paperclip manages agents that use different model providers and adapters. > - Paperclip must keep agent execution rules clear and predictable. > - The cheap-model profile added a second execution mode across adapters, task recovery, APIs, and the UI. > - That mode increased configuration and recovery complexity. > - This pull request removes the cheap-model profile as a product feature. > - The benefit is one model-selection path for normal work and recovery work. ## Linked Issues or Issue Description **What existing behavior does this improve?** This change simplifies model selection across agent configuration, task execution, recovery, and adapter capabilities. **Current behavior** Paperclip exposes cheap-model profiles in adapter metadata, agent runtime configuration, task overrides, recovery rules, APIs, and the board UI. Recovery work can select a different model profile from the agent's configured model. **Proposed behavior** Paperclip uses the agent's configured model for normal work and recovery work. Status-only recovery stays limited to coordination work. The API rejects legacy model-profile configuration. A migration removes stored model-profile values from existing agent, issue, and historical revision records. **Reason and benefit** One model path reduces configuration, API, UI, and recovery complexity. It also prevents status recovery from becoming a separate product-level model-routing feature. **Breaking changes** This change removes model-profile fields and adapter capability metadata. Existing stored model-profile values are removed by an idempotent migration. The validators reject new legacy profile values with clear errors. ## What Changed - Removed model-profile types, adapter capabilities, API fields, and model selection logic. - Removed cheap-model controls from agent and task UI surfaces. - Kept status-only recovery limited to coordination context while normal continuations use the configured agent model. - Added an idempotent migration that removes stored model-profile values from agents, issues, and configuration revisions without changing issue update timestamps. - Updated tests and product documentation for the single-model behavior. ## Verification - `pnpm check:token-gates` passes. - `pnpm -r typecheck` passes. - `pnpm build` passes. - `pnpm test:run` completed with 5,607 passing tests and 8 environment-sensitive failures in unrelated fixed-port and database-deadlock suites. The same failures repeated in an isolated rerun. CI is the final clean-room result. ## Risks - This is an intentional breaking change for clients that send model-profile fields. - The migration changes legacy agent, issue, and configuration-revision JSON. It is idempotent and preserves unrelated fields and issue update timestamps. - The change is cross-cutting because the removed feature existed in adapters, shared contracts, the server, plugins, and the UI. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex with `gpt-5`. Reasoning and tool use were enabled. The runtime did not expose the context-window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [ ] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
82 lines
2.6 KiB
TypeScript
82 lines
2.6 KiB
TypeScript
import { ADAPTER_AGNOSTIC_KEYS, type Agent } from "@paperclipai/shared";
|
|
|
|
export interface AgentConfigOverlay {
|
|
identity: Record<string, unknown>;
|
|
adapterType?: string;
|
|
adapterConfig: Record<string, unknown>;
|
|
heartbeat: Record<string, unknown>;
|
|
debug: Record<string, unknown>;
|
|
runtime: Record<string, unknown>;
|
|
}
|
|
|
|
export function omitUndefinedEntries(value: Record<string, unknown>) {
|
|
return Object.fromEntries(
|
|
Object.entries(value).filter(([, entryValue]) => entryValue !== undefined),
|
|
);
|
|
}
|
|
|
|
export function buildAgentUpdatePatch(agent: Agent, overlay: AgentConfigOverlay) {
|
|
const patch: Record<string, unknown> = {};
|
|
|
|
if (Object.keys(overlay.identity).length > 0) {
|
|
Object.assign(patch, overlay.identity);
|
|
}
|
|
|
|
if (overlay.adapterType !== undefined) {
|
|
patch.adapterType = overlay.adapterType;
|
|
}
|
|
|
|
if (overlay.adapterType !== undefined || Object.keys(overlay.adapterConfig).length > 0) {
|
|
const existing = (agent.adapterConfig ?? {}) as Record<string, unknown>;
|
|
const nextAdapterConfig =
|
|
overlay.adapterType !== undefined
|
|
? {
|
|
...Object.fromEntries(
|
|
ADAPTER_AGNOSTIC_KEYS
|
|
.filter((key) => existing[key] !== undefined)
|
|
.map((key) => [key, existing[key]]),
|
|
),
|
|
...overlay.adapterConfig,
|
|
}
|
|
: {
|
|
...existing,
|
|
...overlay.adapterConfig,
|
|
};
|
|
|
|
patch.adapterConfig = omitUndefinedEntries(nextAdapterConfig);
|
|
patch.replaceAdapterConfig = true;
|
|
}
|
|
|
|
if (
|
|
Object.keys(overlay.heartbeat).length > 0
|
|
|| Object.keys(overlay.debug).length > 0
|
|
) {
|
|
const existingRc = (agent.runtimeConfig ?? {}) as Record<string, unknown>;
|
|
const nextRuntimeConfig: Record<string, unknown> = (patch.runtimeConfig as Record<string, unknown> | undefined)
|
|
?? { ...existingRc };
|
|
|
|
if (Object.keys(overlay.heartbeat).length > 0) {
|
|
const existingHb = (existingRc.heartbeat ?? {}) as Record<string, unknown>;
|
|
nextRuntimeConfig.heartbeat = { ...existingHb, ...overlay.heartbeat };
|
|
}
|
|
|
|
if (Object.keys(overlay.debug).length > 0) {
|
|
const existingDebug = (existingRc.debug ?? {}) as Record<string, unknown>;
|
|
const nextDebug = omitUndefinedEntries({ ...existingDebug, ...overlay.debug });
|
|
if (Object.keys(nextDebug).length === 0) {
|
|
delete nextRuntimeConfig.debug;
|
|
} else {
|
|
nextRuntimeConfig.debug = nextDebug;
|
|
}
|
|
}
|
|
|
|
patch.runtimeConfig = nextRuntimeConfig;
|
|
}
|
|
|
|
if (Object.keys(overlay.runtime).length > 0) {
|
|
Object.assign(patch, overlay.runtime);
|
|
}
|
|
|
|
return patch;
|
|
}
|