mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-02 16:58:52 +01:00
## Thinking Path > - Paperclip is the open-source control plane people use to manage AI agents and their work. > - Its scheduler, routines, and heartbeat services decide when agents automatically begin work. > - Experimental per-worktree execution is useful for isolated development, but enabling it previously allowed automatic services to consider an existing backlog. > - A worktree activation must therefore create a durable eligibility boundary rather than merely toggle execution on. > - This pull request records an activation cutoff and applies it consistently to automatic routine and heartbeat dispatch. > - The result is that an enabled worktree executes only work created after its own activation, while non-worktree behavior remains unchanged. ## Linked Issues or Issue Description **Problem type:** Bug / safety regression **Summary:** Enabling experimental run execution in an existing worktree could start automatic scheduler, routine, watchdog, and heartbeat activity for work created before that worktree was explicitly armed. **Expected behavior:** A worktree that has execution enabled only considers automatically dispatched work created on or after its activation timestamp. Ambiguous activation state fails closed. Non-worktree instances keep their existing behavior. **Related public work:** Refs #8275 (runtime worktree policy gating); this PR adds an activation-time boundary for automatic execution rather than changing the general runtime policy. ## What Changed - Persist a worktree execution activation timestamp and originating instance ID; stamp them only when the experimental toggle changes from disabled to enabled. - Resolve activation state fail-closed when the cutoff is missing, invalid, disabled, or belongs to another instance. - Gate automatic routine scheduling, webhooks, watchdog activity, and heartbeat selection at the activation cutoff; manual runs remain available. - Share the canonical worktree truthy-environment helper across routine dispatch and agent inbox filtering. - Add cutoff and truthy-runtime regression coverage, plus experimental-settings UI states that explain armed and suppressed execution. ## Verification - `pnpm exec vitest run server/src/__tests__/routines-service.test.ts server/src/__tests__/instance-settings-service.test.ts` — passes: 2 files, 60 tests. - `pnpm --filter @paperclipai/server typecheck` — passes. - Existing CI completed successfully before the follow-up review fixes; this branch was rebased onto the latest `origin/master` before retesting. ## Risks - **Behavioral:** Automatic worktree execution is intentionally more restrictive; pre-existing work is suppressed until newly created after activation. - **Operational:** A malformed or cross-instance activation record fails closed, requiring an operator to disable and re-enable the experimental toggle on the intended worktree. - **Compatibility:** The worktree environment now accepts all canonical truthy values (`1`, `true`, `yes`, and `on`) consistently; non-worktree instances are unaffected. - **Branch metadata:** This existing execution-workspace branch predates the current naming rule and cannot be renamed under this task's workspace contract; the code and PR title do not include internal ticket references. > `ROADMAP.md` was checked; this targeted execution-safety fix does not duplicate planned core work. ## Model Used - Anthropic Claude Code — assisted with the original implementation; exact model identifier and context window were not recorded in the repository metadata. - OpenAI Codex CLI — assisted with PR preparation and review fixes; exact model identifier and context window are not exposed in this execution environment. Used with terminal tooling, code editing, and targeted test execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [ ] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
89 lines
3.1 KiB
TypeScript
89 lines
3.1 KiB
TypeScript
import { READABLE_TEXT_LIGHT, READABLE_TEXT_DARK } from "./color-contrast";
|
|
|
|
export type WorktreeUiBranding = {
|
|
enabled: true;
|
|
name: string;
|
|
color: string;
|
|
textColor: string;
|
|
};
|
|
|
|
function readMetaContent(name: string): string | null {
|
|
if (typeof document === "undefined") return null;
|
|
const element = document.querySelector(`meta[name="${name}"]`);
|
|
const content = element?.getAttribute("content")?.trim();
|
|
return content ? content : null;
|
|
}
|
|
|
|
function normalizeHexColor(value: string | null): string | null {
|
|
if (!value) return null;
|
|
const hex = value.startsWith("#") ? value.slice(1) : value;
|
|
if (/^[0-9a-fA-F]{3}$/.test(hex)) {
|
|
return `#${hex.split("").map((char) => `${char}${char}`).join("").toLowerCase()}`;
|
|
}
|
|
if (/^[0-9a-fA-F]{6}$/.test(hex)) {
|
|
return `#${hex.toLowerCase()}`;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
function hexToRgb(color: string): { r: number; g: number; b: number } {
|
|
const normalized = normalizeHexColor(color) ?? "#000000";
|
|
return {
|
|
r: Number.parseInt(normalized.slice(1, 3), 16),
|
|
g: Number.parseInt(normalized.slice(3, 5), 16),
|
|
b: Number.parseInt(normalized.slice(5, 7), 16),
|
|
};
|
|
}
|
|
|
|
function relativeLuminanceChannel(value: number): number {
|
|
const normalized = value / 255;
|
|
return normalized <= 0.03928 ? normalized / 12.92 : ((normalized + 0.055) / 1.055) ** 2.4;
|
|
}
|
|
|
|
function pickReadableTextColor(background: string): string {
|
|
const { r, g, b } = hexToRgb(background);
|
|
const luminance =
|
|
(0.2126 * relativeLuminanceChannel(r)) +
|
|
(0.7152 * relativeLuminanceChannel(g)) +
|
|
(0.0722 * relativeLuminanceChannel(b));
|
|
const whiteContrast = 1.05 / (luminance + 0.05);
|
|
const blackContrast = (luminance + 0.05) / 0.05;
|
|
return whiteContrast >= blackContrast ? READABLE_TEXT_LIGHT : READABLE_TEXT_DARK;
|
|
}
|
|
|
|
/**
|
|
* True when the UI is served by an isolated git-worktree preview instance
|
|
* (`PAPERCLIP_IN_WORKTREE=true` on the server). Unlike {@link getWorktreeUiBranding}
|
|
* this only depends on the enabled flag, so it stays reliable even if the
|
|
* worktree name/color branding is absent.
|
|
*/
|
|
export function isWorktreeRuntime(): boolean {
|
|
return readMetaContent("paperclip-worktree-enabled") === "true";
|
|
}
|
|
|
|
/**
|
|
* Runtime instance id of the worktree preview serving this UI, injected by the
|
|
* server as a `<meta name="paperclip-instance-id">` tag. Returns null outside a
|
|
* worktree or when the server did not surface the id. Used by the experimental
|
|
* "Run tasks in this worktree" card to fail closed when a copied settings row
|
|
* was armed in a different instance.
|
|
*/
|
|
export function getWorktreeInstanceId(): string | null {
|
|
return readMetaContent("paperclip-instance-id");
|
|
}
|
|
|
|
export function getWorktreeUiBranding(): WorktreeUiBranding | null {
|
|
if (readMetaContent("paperclip-worktree-enabled") !== "true") return null;
|
|
|
|
const name = readMetaContent("paperclip-worktree-name");
|
|
const color = normalizeHexColor(readMetaContent("paperclip-worktree-color"));
|
|
if (!name || !color) return null;
|
|
|
|
return {
|
|
enabled: true,
|
|
name,
|
|
color,
|
|
textColor: normalizeHexColor(readMetaContent("paperclip-worktree-text-color")) ?? pickReadableTextColor(color),
|
|
};
|
|
}
|