mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Before an agent starts, Paperclip prepares the task workspace and runs the project's configured setup commands (for example the workspace provision command) > - When that command fails, the run fails as `setup_failed`, and the task stops with a Retry > - The task page shows only "Failed" and a generic recovery notice. The real error (the command, its exit status and output) is visible only on the run page > - The user cannot see from the task which setting is broken or what to change > - This pull request records a bounded, named cause for a failed setup command and shows it on the task page > - The benefit is that the task names the broken setting and what to change, and classification, retry and recovery stay the same ## Linked Issues or Issue Description **What happened?** The restart-chaos config fault wave CF1 sets a project `workspaceStrategy.provisionCommand` to `bash ./scripts/provision-worktree.sh`, a script that does not exist. The run fails as `setup_failed` with `Execution workspace provision command "bash ./scripts/provision-worktree.sh" failed: bash: ./scripts/provision-worktree.sh: No such file or directory`. The task page shows "Failed" and "Paperclip automatically retried continuation … still has no live execution path". The grader fails the task as `CF1/provision_command:message_only_in_run_detail`. **Expected behavior** The task page names the failed setup step, the configured command, its exit status and a short tail of its output, and says what to change. Retry behavior stays the same. **Steps to reproduce** `node cli/node_modules/tsx/dist/cli.mjs tests/restart-chaos/config-wave.ts --faults CF1 --adapters codex --tasks 2 --concurrency 2 --restarts K1,K2 --seed 204` on `master`. **Paperclip version or commit** `master` at5ab98b0(wave `w-20261110T043929-s204-cf`, tasks t01 and t03). ## What Changed - `WorkspaceCommandExitError` now carries the setup step (`workspace_provision`, `workspace_seed`, `workspace_runtime_provision`), the configured command and the command output. - New `server/src/services/workspace-setup-command-failure.ts`: it builds a bounded, redacted `setupCommandFailure` record (step, command up to 200 characters, exit code, last 300 characters of output). It also recognizes the older message format, so runs recorded before this change still get a name. - `run-completion.ts` adds `setupCommandFailure` to the setup failure `resultJson`. The error code (`setup_failed`) and all retry and recovery fields stay the same. - `TaskInterruptionPresentation.setupFailure` (shared type) is set for `setup_failed` runs. It goes through the same per-run secret redaction and user-name redaction as `workspaceFailure`. - `ExecutionBlockerNotice` shows "Couldn’t set up the task workspace. <command> failed with exit code N: <output>. Fix the command in the project’s workspace settings, then retry." A scheduled transient retry keeps its countdown and only adds the name. - The restart-chaos config wave reads `interruption.setupFailure` as a task-level text for its actionable-message check. ## Verification - Red before, green after (the tests fail with the source changes reverted): - `server/src/__tests__/workspace-runtime.test.ts` — "names a failed project provision command with its exit status and output (CF1)" runs a real git worktree with a missing provision script (exit 127). - `server/src/services/task-interruption-presentation.test.ts` — "setup command failure presentation (CF1)": names the command, keeps `state`/`canRetry`/`userAction` identical, recognizes the older message, keeps a scheduled retry, bounds output and strips credentials from the command. - `ui/src/components/ExecutionBlockerNotice.test.tsx` and `tests/restart-chaos/config-faults.test.ts` cover the notice text and the harness check. - `pnpm --filter @paperclipai/shared typecheck`, `pnpm --filter @paperclipai/server typecheck`, `pnpm --filter @paperclipai/ui typecheck` pass. - Live proof: config wave `w-20261110T083227-s204-cf` (CF1, codex, 2 tasks, K1 and K2, seed 204) on commitae9a4b7: **2/2 pass**. Both tasks show `The project's workspace provision command "bash ./scripts/provision-worktree.sh" failed with exit code 127: bash: ./scripts/provision-worktree.sh: No such file or directory` on the task, rest again after the restart, and finish after the repair and Retry. On `master` the same wave failed both tasks as `message_only_in_run_detail` (`w-20261110T043929-s204-cf`). ## Risks - Low risk. The change adds a presentation field. It does not change the error code, retry, recovery or blocking behavior. - The command and output are user-configured text. They are bounded, passed through `redactSensitiveText`, the run's secret registry and user-name redaction. If redaction fails, the field is omitted, like `workspaceFailure`. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, used through Claude Code with tool use (shell, file edits, test runs). ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude <noreply@anthropic.com>
139 lines
9.4 KiB
TypeScript
139 lines
9.4 KiB
TypeScript
import { describeError } from "../api/errors";
|
||
import type { IssueRelationIssueSummary, TaskInterruptionPresentation } from "@paperclipai/shared";
|
||
import { AlertCircle } from "lucide-react";
|
||
import { Link } from "@/lib/router";
|
||
import { createIssueDetailPath } from "../lib/issueDetailBreadcrumb";
|
||
import { Button } from "./ui/button";
|
||
import { cn } from "../lib/utils";
|
||
import { useSecondTick } from "../hooks/useSecondTick";
|
||
import { TaskProjectAccessNotice } from "./TaskProjectAccessNotice";
|
||
import { ProviderFailureNotice } from "./ProviderFailureNotice";
|
||
import { LockedIssueChip, isLockedIssueStub } from "./LockedIssueChip";
|
||
import { PreviousServerStopConfirmation } from "./WorkspaceExportRecovery";
|
||
import { issuesApi } from "../api/issues";
|
||
|
||
const recoveryStepText: Record<NonNullable<TaskInterruptionPresentation["recoveryStep"]>, string> = {
|
||
checking_previous_run: "Checking that the previous attempt stopped",
|
||
saving_previous_files: "Saving files from the previous attempt",
|
||
finishing_recovery: "Finishing recovery of saved work",
|
||
};
|
||
|
||
/** A budget hard stop holds saved work. Only a task that already ran has an
|
||
* attempt to report; a task refused before its first run just waits. */
|
||
function budgetWaitText(presentation: TaskInterruptionPresentation) {
|
||
const wait = "It is waiting for the budget to allow new work. Raise the budget in Costs.";
|
||
return presentation.observedRunId || presentation.sourceRunIds.length
|
||
? `Couldn’t finish this attempt. Your message is saved. ${wait}`
|
||
: `This task has not started. ${wait}`;
|
||
}
|
||
const isBudgetWait = (presentation: TaskInterruptionPresentation | null | undefined) =>
|
||
presentation?.state === "waiting_for_user" && presentation.userAction === "budget";
|
||
|
||
const blockerAction: Record<string, string> = {
|
||
blocked: "Blocked: open it to Retry",
|
||
cancelled: "Cancelled: remove or replace it",
|
||
done: "Saving its files",
|
||
};
|
||
|
||
/** One ordinary interruption surface. Technical records remain in diagnostics. */
|
||
export function ExecutionBlockerNotice({ presentation, canRetry, onRetry, optimistic, takingLonger, error, className, issueId, companyId, agentName, projectName, blockers }: {
|
||
presentation: TaskInterruptionPresentation | null | undefined;
|
||
companyId?: string;
|
||
blockers?: IssueRelationIssueSummary[];
|
||
canRetry: boolean;
|
||
onRetry: () => void;
|
||
optimistic?: boolean;
|
||
takingLonger?: boolean;
|
||
error?: Error | null;
|
||
className?: string;
|
||
issueId?: string;
|
||
agentName?: string;
|
||
projectName?: string;
|
||
}) {
|
||
useSecondTick(presentation?.state === "retry_scheduled");
|
||
if (presentation?.projectAccess && !optimistic && !takingLonger) return <TaskProjectAccessNotice
|
||
access={presentation.projectAccess} issueId={issueId} agentName={agentName} projectName={projectName}
|
||
canRetry={canRetry && presentation.canRetry} onRetry={onRetry} error={error} className={className} />;
|
||
if (error && !optimistic && !takingLonger) return <div role="alert" className={cn("flex items-center justify-between gap-2 text-sm text-destructive", className)}><span>{describeError(error).body}</span>{canRetry && <Button variant="outline" size="sm" onClick={onRetry} data-testid="task-execution-retry">Retry</Button>}</div>;
|
||
if (takingLonger) return <div role="status" className={cn("flex items-center justify-between gap-2 text-sm text-muted-foreground", className)}><span>Taking longer than usual…</span>{canRetry && <Button variant="outline" size="sm" onClick={onRetry} data-testid="task-execution-retry">Retry</Button>}</div>;
|
||
const step = !optimistic && presentation?.responsibility === "system" && presentation.recoveryStep
|
||
&& ["working", "retry_scheduled"].includes(presentation.state) ? recoveryStepText[presentation.recoveryStep] : null;
|
||
const seconds = Math.max(0, Math.ceil((Date.parse(presentation?.nextRetryAt ?? "") - Date.now()) / 1000));
|
||
const retryIn = `Trying again in ${seconds > 60 ? `${Math.ceil(seconds / 60)}m` : `${seconds}s`}…`;
|
||
if (!optimistic && !presentation?.retryWait && presentation?.providerFailure && ["failed", "retry_scheduled", "waiting_for_user"].includes(presentation.state)) {
|
||
// Saved-work recovery is what the task waits for, so name it over the
|
||
// generic automatic-retry line while keeping the provider explanation.
|
||
return <ProviderFailureNotice failure={presentation.providerFailure} className={className}
|
||
actions={canRetry && presentation.canRetry ? <Button variant="outline" size="sm" onClick={onRetry} data-testid="task-execution-retry">Retry</Button> : undefined}>
|
||
{presentation.state === "retry_scheduled" && <p>{step ? `${step}. ${retryIn}` : "Paperclip will retry automatically."}</p>}
|
||
{isBudgetWait(presentation) && <p data-testid="task-execution-waiting">It is waiting for the budget to allow new work. Raise the budget in Costs.</p>}
|
||
</ProviderFailureNotice>;
|
||
}
|
||
if (step && presentation?.state === "working") return <div role="status" aria-label="Task status"
|
||
className={cn("text-sm text-muted-foreground", className)}>{`${step}…`}</div>;
|
||
// A task that has not started yet names the admission hold it waits for.
|
||
if (!optimistic && presentation?.state === "working" && presentation.retryWait) {
|
||
const dependencies = presentation.retryWait.reason === "dependency_blocked" ? blockers ?? [] : [];
|
||
const unfinished = dependencies.filter(blocker => isLockedIssueStub(blocker) || blocker.status !== "done");
|
||
const waitingOn = unfinished.length ? unfinished : dependencies;
|
||
return <div role="status" aria-label="Task status" className={cn("text-sm text-muted-foreground", className)}>
|
||
<p>{presentation.retryWait.message}</p>
|
||
{waitingOn.length ? <ul className="mt-1 space-y-0.5" data-testid="retry-waiting-on">
|
||
{waitingOn.map(blocker => isLockedIssueStub(blocker)
|
||
? <li key={blocker.id} className="flex min-w-0 items-center gap-2"><LockedIssueChip identifier={blocker.identifier} /></li>
|
||
: <li key={blocker.id} className="flex min-w-0 items-center gap-2">
|
||
<Link to={createIssueDetailPath(blocker.identifier ?? blocker.id)}
|
||
className="font-mono text-xs text-foreground underline-offset-2 hover:underline">
|
||
{blocker.identifier ?? "Task"}
|
||
</Link>
|
||
<span className="min-w-0 truncate">{blocker.title}</span>
|
||
<span className="shrink-0 text-xs">{blockerAction[blocker.status] ?? blocker.status.replace(/_/g, " ")}</span>
|
||
</li>)}
|
||
</ul> : null}
|
||
</div>;
|
||
}
|
||
if (!optimistic && presentation?.userAction === "confirm_run_stopped" && presentation.observedRunId && issueId && companyId) {
|
||
const runId = presentation.observedRunId;
|
||
return <PreviousServerStopConfirmation key={`${issueId}:${runId}`} runId={runId} formId={runId} issueId={issueId} companyId={companyId}
|
||
className={className} confirmStop={stopEvidence => issuesApi.confirmRunStopped(issueId, { runId, stopEvidence })}
|
||
copy={{ waiting: presentation.retryWait?.message ?? "Paperclip can't confirm that the previous run stopped. Your message is saved.",
|
||
question: "How did you confirm that no agent is still working on this task?",
|
||
placeholder: "For example: no codex or claude process for this task is running on the server host.",
|
||
resuming: "Starting your Retry…", confirm: "Confirm it stopped" }} />;
|
||
}
|
||
// Other person-owned decisions have their own card on the task (approval,
|
||
// project access, ...). A budget hold has none, so name it here and keep the
|
||
// failure visible. The saved attempt starts by itself once the budget allows.
|
||
if (!optimistic && presentation && isBudgetWait(presentation)) return (
|
||
<div className={cn("pt-4", className)}>
|
||
<div role="status" aria-label="Task status" data-testid="task-execution-waiting"
|
||
className="flex items-center gap-3 rounded-lg bg-destructive/10 p-4 text-sm text-foreground">
|
||
<AlertCircle className="size-5 shrink-0 text-destructive" aria-hidden="true" />
|
||
<span className="min-w-0 flex-1">{budgetWaitText(presentation)}</span>
|
||
</div>
|
||
</div>
|
||
);
|
||
if (optimistic || !presentation || presentation.responsibility !== "system" ||
|
||
!["failed", "retry_scheduled"].includes(presentation.state)) return null;
|
||
return (
|
||
<div className={cn(presentation.state === "failed" && "pt-4", className)}>
|
||
<div role="status" aria-label="Task status" className={cn(
|
||
"flex items-center justify-between gap-3 text-sm",
|
||
presentation.state === "failed" ? "rounded-lg bg-destructive/10 p-4 text-foreground" : "text-muted-foreground",
|
||
)}>
|
||
{presentation.state === "failed" && <AlertCircle className="size-5 shrink-0 text-destructive" aria-hidden="true" />}
|
||
<span className="min-w-0 flex-1">{presentation.state === "retry_scheduled"
|
||
? step ? `${step}. ${retryIn}`
|
||
: presentation.setupFailure ? `${presentation.setupFailure.message}. ${retryIn}` : retryIn
|
||
: presentation.retryWait ? presentation.retryWait.message
|
||
: presentation.workspaceFailure
|
||
? <>Couldn’t prepare the task folders. {presentation.workspaceFailure.message}</>
|
||
: presentation.setupFailure
|
||
? <>Couldn’t set up the task workspace. {presentation.setupFailure.message}. Fix the command in the project’s workspace settings, then retry.</>
|
||
: "Couldn’t finish this attempt. Your message is saved."}</span>
|
||
{canRetry && presentation.canRetry && <Button variant="outline" size="sm" className="shrink-0" onClick={onRetry} data-testid="task-execution-retry">Retry</Button>}
|
||
</div>
|
||
</div>
|
||
);
|
||
}
|