mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-08 01:57:31 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Conversations must use the same tasks, controls, and execution history. > - Users need an ongoing chat with an agent without managing task properties. > - Agents should clarify and plan work, then hand execution to assigned project tasks. > - This pull request combines the reviewed Agent Chat stack for one squash merge. > - The benefit is persistent conversation with normal task governance and shared UI. ## Linked Issues or Issue Description **Subsystem affected** Task lifecycle, agent runtime tools, shared task UI, and browser/paid runner tests. **Problem or motivation** Users need one persistent conversation with each agent. A separate chat store or renderer would duplicate task behavior and bypass existing controls. **Proposed solution** Use a task-backed chat per company, user, and agent. Reuse the task composer and transcript. Clarify and plan in chat, then create assigned project tasks with the relevant plan. Keep Agent Chat behind its own disabled-by-default experimental setting. **Roadmap alignment** This implements the task-backed direction in [CEO Chat](https://github.com/paperclipai/paperclip/blob/master/ROADMAP.md#-ceo-chat). Related proposals: #2504 and #9693. Related request: #7981. The maintainer requested one squash merge of the complete stack. Consolidates the reviewed runtime [#13281](https://github.com/paperclipai/paperclip/pull/13281), backend [#13282](https://github.com/paperclipai/paperclip/pull/13282), and UI [#13283](https://github.com/paperclipai/paperclip/pull/13283) layers with this PR's E2E coverage. All four layers passed CI and received Greptile 5/5 before consolidation. This PR targets master and includes the complete feature. ## What Changed - Add personal canonical chat tasks with ordinary company visibility, immutable identity, idempotent first sends, and an idle waiting state. - Process `/new` in queue order. Preserve history, release a chat pause, and fence old provider context and delayed writes. - Keep chat lifecycle rules across recovery, finalization, assignment, task lists, and rollups. - Support research and plan revision in chat. Hand plans to ordinary assigned project tasks before execution starts. Reject new chat subtasks. - Add repository-aware project creation and discovery tools, including multiple repository IDs and GitHub URLs, authorization, idempotency, and durable project-created cards. - Reuse task UI components for chat, with starred/recent agent navigation and a separate `enableAgentChat` experimental flag. - Add deterministic browser tests and 24 paid chat cells across four Codex/Claude profiles, with validated reports and screenshots. - Integrate current master recovery, controller lease, queued-message, and task UI changes. Gate chat interruption and deferred promotion on ownership/feature policy. Guarantee lease renewal and active controls are stopped even if teardown fails. - Preserve master's migration 0273 and generate chat migration 0274 with idempotent replay for development databases. ## Verification - Prior exact heads of all four PRs passed Linux CI, including build, typecheck, general/serialized tests, and browser E2E. Each had Greptile 5/5 and no unresolved findings. - Integrated local verification passed: full repository typecheck and production build, Storybook build, token gates, 340 focused UI tests, all 20 deterministic chat browser tests, two migration replay tests, 88 focused chat/queue/native/controller tests, and provider/session regressions including real lease expiry. These include the three lifecycle regressions for the final admission/teardown fixes; server typecheck also passes. Current head `1268eda16cc2af892055917e7292f068820be135` has Greptile 5/5 with no unresolved findings and passing security scans. All final-head CI gates passed: build, full Runner verification, typecheck/release registry, canary, all general/serialized test shards, and all browser E2E shards ([CI run](https://github.com/paperclipai/paperclip/actions/runs/34696739927)). Local PostgreSQL startup contention required serialized retries; skipped fixtures do not count as passing coverage. - The earlier paid campaign passed all 24 chat cells and retained 32 screenshots: [report](https://d1p6rlowie26tp.cloudfront.net/runner-e2e/campaigns/gha-34648511170-1/index.html?report=agent-chat#suite-agent-chat). It tested `abacbdfd2f660709ec37312cdb758284c8399d04`; it is prior evidence, not a paid run of this integrated head. - Manual check: enable Agent Chat in Experimental settings, open an agent, clarify and revise a plan, then hand off to an assigned project task. Stop a reply, send `/new`, and verify fresh context with retained history. Disable the setting and verify agent shortcuts/new chat turns are blocked. ## Risks - Queue/session integration can affect retries and delayed writes. Tests cover ownership, cancellation, reset boundaries, idle recovery, and ordinary task behavior. - Migration 0274 adds conversation fields and constraints. Replay is idempotent and preserves existing development chat history. - This combines the previously reviewed stack at the maintainer's request. Agent Chat remains off by default and is separate from Conference Room. ## Model Used OpenAI Codex, GPT-6 Astra (`gpt-6-astra`), with reasoning, code execution, browser tools, and parallel review. The exact context-window size is not exposed in this session. Codex and Claude also ran as test subjects in the linked paid campaign. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
271 lines
12 KiB
TypeScript
271 lines
12 KiB
TypeScript
import type {
|
|
NativeAcpxAgent,
|
|
NativeAcpxPermissionMode,
|
|
NativeCodexApprovalPolicy,
|
|
NativeExecutionInputV4,
|
|
NativeInteractionResponseEnvelope,
|
|
NativeOpenCodePermissionMode,
|
|
NativePlanningContext,
|
|
NativeRuntimeContextSnapshot,
|
|
StrictCompletionContractInput,
|
|
} from "../../vendor/paperclip-runner/index.js";
|
|
import {
|
|
parseNativeExecutionInput,
|
|
resolveQualifiedAcpxProfile,
|
|
} from "../../vendor/paperclip-runner/index.js";
|
|
import {
|
|
isPaperclipExternalChatContractTurn,
|
|
isPaperclipExternalChatQuestionResponseTurn,
|
|
renderPaperclipWakePrompt,
|
|
} from "@paperclipai/adapter-utils/server-utils";
|
|
|
|
const NATIVE_EXTERNAL_CHAT_QUESTION_GUIDANCE = [
|
|
"## Native external-chat questions",
|
|
"A request for clickable choices, buttons, or a decision needed before continuing is not a self-contained text answer. The zero-API-call shortcut does not prohibit the structured question tool.",
|
|
'Use the available request_human_input tool with interactionKind="questions", continuationPolicy="wake_assignee", a title, prompt, and a stable idempotencyKey. Put the actual requested choices in payload.questions: each question needs an id, prompt, selectionMode="single", and options with stable id and label fields. Reuse the same key if that creation call must be retried.',
|
|
"Paperclip renders the supported question controls and authenticates the answer. Never fabricate answer URLs, query-string choice links, callback tokens, or fake Markdown buttons. Do not manually post a duplicate question card or use call_api as a substitute.",
|
|
"For one question at a time, read the current request and authoritative prior answers, then create only the next unanswered question. Wait for its real answer before asking another; do not infer a selection or answer your own interaction. Keep completion and disposition truthful while waiting, and preserve existing review or approval gates.",
|
|
"If the tool is unavailable or creation fails, report that actual limitation plainly; do not pretend interactive controls were created.",
|
|
].join("\n");
|
|
|
|
const NATIVE_GITHUB_ATTACHMENT_RECOVERY_GUIDANCE = [
|
|
"## GitHub attachment recovery navigation",
|
|
"Paperclip owns recovery navigation for unavailable GitHub attachments. It may append an authenticated task link after an accepted response, only when the current source remains authorized and a safe configured Board URL is available. The model does not select or authorize that link.",
|
|
"A task URL missing from your prompt or tool results is not evidence that no task link can be provided; do not claim that a link is unavailable merely because you cannot see its URL. Do not invent a URL or promise that a link will appear. Briefly explain the unavailable input and ask the user to attach it directly to this Paperclip task or paste the needed text. Never infer the file's contents or substitute an older file.",
|
|
].join("\n");
|
|
|
|
/** Closed constructor: callers cannot spread legacy context or environment data. */
|
|
export function buildNativeExecutionInput(input: {
|
|
companyId: string;
|
|
runId: string;
|
|
issue: {
|
|
id: string;
|
|
identifier: string | null;
|
|
title: string;
|
|
description: string | null;
|
|
workMode: string;
|
|
};
|
|
taskPrompt: string;
|
|
/**
|
|
* The already-sanitized Paperclip wake envelope for this run. Native drivers
|
|
* receive a closed execution input rather than the legacy adapter context,
|
|
* so the constructor must deliberately project the same bounded wake delta
|
|
* that legacy adapters place in their provider prompt.
|
|
*/
|
|
wakePayload?: unknown;
|
|
resumedSession?: boolean;
|
|
conversationMode?: boolean;
|
|
agentId: string;
|
|
workspace: {
|
|
id: string;
|
|
cwd: string;
|
|
repoUrl: string | null;
|
|
repoRef: string | null;
|
|
branchName: string | null;
|
|
};
|
|
normalizedSessionId: string | null;
|
|
provider?: "codex" | "opencode" | "claude_managed" | "aws_agentcore" | "acpx";
|
|
acpxAgent?: NativeAcpxAgent;
|
|
codexApprovalPolicy?: NativeCodexApprovalPolicy;
|
|
opencodePermissionMode?: NativeOpenCodePermissionMode;
|
|
acpxPermissionMode?: NativeAcpxPermissionMode;
|
|
model?: string | null;
|
|
managedProfile?: Extract<
|
|
NativeExecutionInputV4["provider"],
|
|
{ kind: "claude_managed" }
|
|
>["managedProfile"];
|
|
maxSessionListCostUsd?: number;
|
|
agentCoreProfile?: Extract<
|
|
NativeExecutionInputV4["provider"],
|
|
{ kind: "aws_agentcore" }
|
|
>["agentCoreProfile"];
|
|
maxEstimatedSessionCostUsd?: number;
|
|
invocationLimits?: Extract<
|
|
NativeExecutionInputV4["provider"],
|
|
{ kind: "aws_agentcore" }
|
|
>["invocationLimits"];
|
|
lifecyclePolicy?: NativeExecutionInputV4["session"]["lifecyclePolicy"];
|
|
executionMode?: "default" | "plan";
|
|
planningContext?: NativePlanningContext | null;
|
|
interactionResponses?: NativeInteractionResponseEnvelope[];
|
|
completionContract: {
|
|
id: string;
|
|
sha256: string;
|
|
schemaVersion: string;
|
|
contract: StrictCompletionContractInput;
|
|
};
|
|
runtimeContext: NativeRuntimeContextSnapshot;
|
|
}): NativeExecutionInputV4 {
|
|
if (input.issue.workMode !== "standard" && input.issue.workMode !== "planning" && input.issue.workMode !== "ask") {
|
|
throw new Error("native_execution_input_invalid: issue work mode must be standard, planning, or ask");
|
|
}
|
|
const executionMode = input.executionMode
|
|
?? (input.issue.workMode === "planning" ? "plan" : "default");
|
|
const acpxProfile = input.provider === "acpx"
|
|
? resolveQualifiedAcpxProfile(
|
|
input.acpxAgent ?? "codex",
|
|
input.model ?? "",
|
|
)
|
|
: null;
|
|
// Answers are materialized from the authoritative interaction only for this
|
|
// invocation; do not persist a duplicate answer in the durable wake snapshot.
|
|
const wake =
|
|
input.wakePayload &&
|
|
typeof input.wakePayload === "object" &&
|
|
!Array.isArray(input.wakePayload)
|
|
? (input.wakePayload as Record<string, unknown>)
|
|
: null;
|
|
const question = wake?.externalChatQuestionResponse
|
|
? input.interactionResponses?.find(
|
|
(response) =>
|
|
response.interactionId === wake.interactionId &&
|
|
response.kind === "ask_user_questions" &&
|
|
response.response.status === "answered",
|
|
)
|
|
: null;
|
|
const answerResult = question?.response.result as
|
|
Record<string, unknown> | undefined;
|
|
// The server supplies only the revalidated answer chain, in source order.
|
|
// Keep prior choices available even when this continuation starts a fresh
|
|
// provider session; never recover them from model prose or a transcript.
|
|
const answerChain = question
|
|
? input.interactionResponses?.filter((response) =>
|
|
response.kind === "ask_user_questions" &&
|
|
response.response.status === "answered" &&
|
|
typeof (response.response.result as Record<string, unknown> | undefined)
|
|
?.summaryMarkdown === "string")
|
|
: null;
|
|
const answerSummary =
|
|
answerChain && answerChain.length > 1 &&
|
|
answerChain.at(-1)?.interactionId === question?.interactionId
|
|
? answerChain.map((response, index) => {
|
|
const label = index === answerChain.length - 1
|
|
? "Latest answered question" : `Earlier answer ${index + 1}`;
|
|
return `${label}:\n${(response.response.result as Record<string, unknown>).summaryMarkdown}`;
|
|
}).join("\n\n")
|
|
: answerResult?.summaryMarkdown;
|
|
const wakePayload =
|
|
question && typeof answerSummary === "string"
|
|
? {
|
|
...wake,
|
|
questionResponse: {
|
|
interactionId: question.interactionId,
|
|
summaryMarkdown: answerSummary,
|
|
},
|
|
}
|
|
: input.wakePayload;
|
|
const wakePrompt = renderPaperclipWakePrompt(wakePayload, {
|
|
resumedSession: input.resumedSession === true,
|
|
conversationMode: input.conversationMode === true,
|
|
suppressIssueDescription: input.taskPrompt.trim().length > 0,
|
|
nativeWakeReaderAvailable: true,
|
|
});
|
|
const externalChatTurn =
|
|
isPaperclipExternalChatContractTurn(wakePayload) ||
|
|
isPaperclipExternalChatQuestionResponseTurn(wakePayload);
|
|
const taskPrompt = [
|
|
wakePrompt,
|
|
externalChatTurn ? NATIVE_EXTERNAL_CHAT_QUESTION_GUIDANCE : "",
|
|
externalChatTurn && wake?.externalChatProvider === "github"
|
|
? NATIVE_GITHUB_ATTACHMENT_RECOVERY_GUIDANCE
|
|
: "",
|
|
input.taskPrompt.trim(),
|
|
]
|
|
.filter((section) => section.length > 0)
|
|
.join("\n\n");
|
|
return parseNativeExecutionInput({
|
|
schema: "paperclip.native-execution-input.v4",
|
|
executionMode,
|
|
planningContext: input.planningContext ?? null,
|
|
binding: {
|
|
companyId: input.companyId,
|
|
runId: input.runId,
|
|
issueId: input.issue.id,
|
|
agentId: input.agentId,
|
|
executionWorkspaceId: input.workspace.id,
|
|
},
|
|
task: {
|
|
identifier: input.issue.identifier ?? input.issue.id,
|
|
// The issue title is durable background context and may itself contain an
|
|
// exact-output instruction from the thread's first message. Repeating it
|
|
// as the native turn title can override a newer provider message in small
|
|
// models. Keep the canonical title and description in task.prompt as
|
|
// explicitly labeled background, but give authenticated external-chat
|
|
// turns neutral structured fields.
|
|
title: externalChatTurn ? "External chat follow-up" : input.issue.title,
|
|
description: externalChatTurn ? null : input.issue.description,
|
|
prompt: taskPrompt,
|
|
workMode: input.issue.workMode,
|
|
},
|
|
workspace: {
|
|
cwd: input.workspace.cwd,
|
|
repoUrl: input.workspace.repoUrl,
|
|
repoRef: input.workspace.repoRef,
|
|
branchName: input.workspace.branchName,
|
|
},
|
|
session: {
|
|
normalizedSessionId: input.normalizedSessionId,
|
|
driverKind: input.provider === "opencode"
|
|
? "opencode_server"
|
|
: input.provider === "claude_managed"
|
|
? "claude_managed_agents_api"
|
|
: input.provider === "aws_agentcore"
|
|
? "aws_agentcore_harness_api"
|
|
: input.provider === "acpx"
|
|
? "acpx_runtime"
|
|
: "codex_app_server",
|
|
protocolVersion: 1,
|
|
lifecyclePolicy: input.lifecyclePolicy ?? { mode: "per_turn", idleTimeoutMs: null },
|
|
},
|
|
provider: input.provider === "claude_managed"
|
|
? {
|
|
kind: "claude_managed",
|
|
model: input.model,
|
|
managedProfile: input.managedProfile,
|
|
maxSessionListCostUsd: input.maxSessionListCostUsd,
|
|
}
|
|
: input.provider === "aws_agentcore"
|
|
? {
|
|
kind: "aws_agentcore",
|
|
model: input.model,
|
|
agentCoreProfile: input.agentCoreProfile,
|
|
maxEstimatedSessionCostUsd: input.maxEstimatedSessionCostUsd,
|
|
invocationLimits: input.invocationLimits,
|
|
}
|
|
: input.provider === "acpx"
|
|
? {
|
|
kind: "acpx",
|
|
agent: acpxProfile!.agent,
|
|
model: input.model,
|
|
permissionMode: input.acpxPermissionMode ?? "approve-reads",
|
|
profile: {
|
|
driverKind: acpxProfile!.driverKind,
|
|
protocolVersion: acpxProfile!.protocolVersion,
|
|
acpxVersion: acpxProfile!.acpxVersion,
|
|
agent: acpxProfile!.agent,
|
|
agentProfileVersion: acpxProfile!.agentProfileVersion,
|
|
agentServerPackage: acpxProfile!.agentServerPackage,
|
|
agentServerVersion: acpxProfile!.agentServerVersion,
|
|
agentRuntimePackage: acpxProfile!.agentRuntimePackage,
|
|
agentRuntimeVersion: acpxProfile!.agentRuntimeVersion,
|
|
commandDigest: acpxProfile!.commandDigest,
|
|
},
|
|
}
|
|
: input.provider === "opencode"
|
|
? {
|
|
kind: "opencode",
|
|
model: input.model,
|
|
permissionMode: input.opencodePermissionMode ?? "ask",
|
|
}
|
|
: {
|
|
kind: "codex",
|
|
model: input.model ?? null,
|
|
approvalPolicy: input.codexApprovalPolicy ?? "never",
|
|
},
|
|
completionContract: input.completionContract,
|
|
interactionResponses: input.interactionResponses ?? [],
|
|
credentialBindings: [],
|
|
runtimeContext: input.runtimeContext,
|
|
}) as NativeExecutionInputV4;
|
|
}
|