mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-18 05:23:39 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The task page is the main place where people guide and review agent work. > - Native runner events already project into the existing task chat on the lower stack. > - The larger task workspace must support those events without breaking direct adapters. > - Legacy questions, final replies, empty transcripts, and classic controls must keep their behavior. > - This pull request completes the provider-neutral task workspace experience. > - The benefit is one coherent task surface for native and direct execution paths. ## Linked Issues or Issue Description Refs #12639. Refs #12617. Refs #12352. **Subsystem affected** Task chat, task detail, side panels, interaction forms, and transcript presentation. **Problem or motivation** The task page does not provide one complete workspace for live activity, plans, questions, queued guidance, files, and documents. Earlier native UI work also exposed compatibility risks in legacy question and reply paths. **Proposed solution** Add the task workspace components and provider-neutral protocol presentation. Keep runner-only controls behind runtime facts. Preserve all direct-adapter composer, transcript, interaction, and finalization behavior. **Alternatives considered** A separate runner page would duplicate task behavior. Replacing legacy transcript logic would create unnecessary adapter regressions. **Roadmap alignment** This work supports the unified task experience and the Cloud and Sandbox agents milestone. ## Stack - Base PR: #12639. - Lower PR: #12638. - This PR contains only its 119-file UI delta against `runner/remote-wss-transport`. - The next stack PR adds administrator and observability controls. ## What Changed - Added a reusable task workspace side panel for files and documents. - Added provider-neutral cards for tools, plans, questions, protocol activity, and progress. - Added queued guidance and richer composer state. - Added compact and expanded interaction presentation. - Added live activity, thinking, usage, recovery, and final reply presentation. - Added document annotations and task deep links. - Added bounded question validation and response handling. - Preserved native runner event projection from master. - Preserved legacy channel-less replies and explicit final reply precedence. - Preserved direct-adapter and classic-interface controls. - Did not change server execution selection, Rust code, migrations, workflows, or `pnpm-lock.yaml`. ## Verification - GitHub Actions will run UI tests, repository tests, typecheck, build, browser tests, security, and policy gates. - Tests cover active, settled, empty-transcript, interaction, queued-message, plan, question, file, document, and classic-interface states. - Compatibility tests cover direct adapters and native runner projection together. - Local tests were not run. The requested verification policy uses GitHub Actions for this series. - `git diff --check runner/remote-wss-transport...HEAD` passes. - The delta contains 119 UI-only files. ## Risks - This is a large task-page change. - Most files are new focused components and tests. - Shared transcript code keeps the lower native projection and legacy direct-adapter fallbacks. - Runner-only controls use adapter and runtime facts. - No execution path or rollout flag changes in this PR. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex with GPT-5.6. The work used high-reasoning agent mode, repository tools, GitHub tools, and parallel code-audit agents. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with Fixes: / Closes / Refs OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal or instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal Paperclip ticket id - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
406 lines
13 KiB
TypeScript
406 lines
13 KiB
TypeScript
import type { Issue, IssueComment } from "@paperclipai/shared";
|
|
|
|
/**
|
|
* First-page size for the issue-detail comment feed. Single source of truth so
|
|
* the render path (IssueDetail's `useInfiniteQuery`) and the navigation prefetch
|
|
* (`prefetchIssueComments`) request identically-shaped pages — a mismatch would
|
|
* leave the prefetched cache entry unable to satisfy the mounted query without a
|
|
* refetch, defeating warm-navigation instant paint.
|
|
*/
|
|
export const ISSUE_COMMENT_PAGE_SIZE = 50;
|
|
|
|
export interface IssueCommentReassignment {
|
|
assigneeAgentId: string | null;
|
|
assigneeUserId: string | null;
|
|
}
|
|
|
|
export interface OptimisticIssueComment extends IssueComment {
|
|
clientId: string;
|
|
clientStatus: "pending" | "queued";
|
|
queueTargetRunId?: string | null;
|
|
}
|
|
|
|
export type IssueTimelineComment = IssueComment | OptimisticIssueComment;
|
|
export type LocallyQueuedIssueComment<T extends IssueComment> = T & {
|
|
clientStatus: "queued";
|
|
queueState: "queued";
|
|
queueTargetRunId: string;
|
|
};
|
|
|
|
function toTimestamp(value: Date | string) {
|
|
return new Date(value).getTime();
|
|
}
|
|
|
|
function createOptimisticCommentId() {
|
|
const randomUuid = globalThis.crypto?.randomUUID?.();
|
|
if (randomUuid) {
|
|
return `optimistic-${randomUuid}`;
|
|
}
|
|
return `optimistic-${Date.now()}-${Math.random().toString(36).slice(2, 10)}`;
|
|
}
|
|
|
|
export function sortIssueComments<T extends { createdAt: Date | string; id: string }>(comments: T[]) {
|
|
return [...comments].sort((a, b) => {
|
|
const createdAtDiff = toTimestamp(a.createdAt) - toTimestamp(b.createdAt);
|
|
if (createdAtDiff !== 0) return createdAtDiff;
|
|
return a.id.localeCompare(b.id);
|
|
});
|
|
}
|
|
|
|
function sortIssueCommentsDesc<T extends { createdAt: Date | string; id: string }>(comments: T[]) {
|
|
return sortIssueComments(comments).reverse();
|
|
}
|
|
|
|
export function createOptimisticIssueComment(params: {
|
|
companyId: string;
|
|
issueId: string;
|
|
body: string;
|
|
authorUserId: string | null;
|
|
clientStatus?: OptimisticIssueComment["clientStatus"];
|
|
queueTargetRunId?: string | null;
|
|
}): OptimisticIssueComment {
|
|
const now = new Date();
|
|
const clientId = createOptimisticCommentId();
|
|
return {
|
|
id: clientId,
|
|
clientId,
|
|
companyId: params.companyId,
|
|
issueId: params.issueId,
|
|
authorType: "user",
|
|
authorAgentId: null,
|
|
authorUserId: params.authorUserId,
|
|
body: params.body,
|
|
presentation: null,
|
|
metadata: null,
|
|
clientStatus: params.clientStatus ?? "pending",
|
|
queueTargetRunId: params.queueTargetRunId ?? null,
|
|
createdAt: now,
|
|
updatedAt: now,
|
|
};
|
|
}
|
|
|
|
export function isQueuedIssueComment(params: {
|
|
comment: Pick<IssueTimelineComment, "createdAt"> &
|
|
Partial<Pick<OptimisticIssueComment, "clientStatus">> & {
|
|
id?: string;
|
|
authorAgentId?: string | null;
|
|
};
|
|
activeRunStartedAt?: Date | string | null;
|
|
activeRunAgentId?: string | null;
|
|
activeRunCommentId?: string | null;
|
|
activeRunWakeCommentId?: string | null;
|
|
runId?: string | null;
|
|
interruptedRunId?: string | null;
|
|
}) {
|
|
if (params.runId) return false;
|
|
if (params.interruptedRunId) return false;
|
|
if (
|
|
params.comment.id &&
|
|
(params.comment.id === params.activeRunWakeCommentId || params.comment.id === params.activeRunCommentId)
|
|
) {
|
|
return false;
|
|
}
|
|
if (params.comment.authorAgentId && params.activeRunAgentId && params.comment.authorAgentId === params.activeRunAgentId) {
|
|
return false;
|
|
}
|
|
if (params.comment.clientStatus === "queued") return true;
|
|
if (!params.activeRunStartedAt) return false;
|
|
return toTimestamp(params.comment.createdAt) >= toTimestamp(params.activeRunStartedAt);
|
|
}
|
|
|
|
export function applyLocalQueuedIssueCommentState<T extends IssueComment>(
|
|
comment: T,
|
|
params: {
|
|
queuedTargetRunId?: string | null;
|
|
targetRunIsLive: boolean;
|
|
runningRunId?: string | null;
|
|
},
|
|
): T | LocallyQueuedIssueComment<T> {
|
|
const queuedTargetRunId = params.queuedTargetRunId ?? null;
|
|
if (!queuedTargetRunId || !params.targetRunIsLive) return comment;
|
|
if (params.runningRunId && params.runningRunId !== queuedTargetRunId) return comment;
|
|
|
|
return {
|
|
...comment,
|
|
clientStatus: "queued",
|
|
queueState: "queued",
|
|
queueTargetRunId: queuedTargetRunId,
|
|
};
|
|
}
|
|
|
|
export function mergeIssueComments(
|
|
comments: IssueComment[] | undefined,
|
|
optimisticComments: OptimisticIssueComment[],
|
|
): IssueTimelineComment[] {
|
|
const persistedComments = comments ?? [];
|
|
const merged = [...persistedComments];
|
|
const existingIds = new Set(merged.map((comment) => comment.id));
|
|
const reconciledPersistedIds = new Set<string>();
|
|
for (const comment of optimisticComments) {
|
|
if (existingIds.has(comment.id)) continue;
|
|
|
|
// The mutation response and comments feed can publish the canonical
|
|
// comment in different React Query notifications. Keep the optimistic row
|
|
// mounted through that handoff without briefly rendering both versions.
|
|
// Consume matches one-for-one so repeated identical messages remain valid.
|
|
const matchingPersistedComment = persistedComments.find((persisted) =>
|
|
!reconciledPersistedIds.has(persisted.id) &&
|
|
persisted.issueId === comment.issueId &&
|
|
persisted.authorType === comment.authorType &&
|
|
persisted.authorUserId === comment.authorUserId &&
|
|
persisted.body === comment.body &&
|
|
Math.abs(toTimestamp(persisted.createdAt) - toTimestamp(comment.createdAt)) <= 60_000
|
|
);
|
|
if (matchingPersistedComment) {
|
|
reconciledPersistedIds.add(matchingPersistedComment.id);
|
|
continue;
|
|
}
|
|
|
|
merged.push(comment);
|
|
}
|
|
return sortIssueComments(merged);
|
|
}
|
|
|
|
export function takeOptimisticIssueComment(
|
|
comments: OptimisticIssueComment[],
|
|
clientId: string,
|
|
): { comments: OptimisticIssueComment[]; comment: OptimisticIssueComment | null } {
|
|
const index = comments.findIndex((comment) => comment.clientId === clientId);
|
|
if (index === -1) {
|
|
return { comments, comment: null };
|
|
}
|
|
|
|
return {
|
|
comments: comments.filter((comment) => comment.clientId !== clientId),
|
|
comment: comments[index] ?? null,
|
|
};
|
|
}
|
|
|
|
export function flattenIssueCommentPages(
|
|
pages: ReadonlyArray<ReadonlyArray<IssueComment>> | undefined,
|
|
): IssueComment[] {
|
|
return sortIssueComments((pages ?? []).flatMap((page) => page));
|
|
}
|
|
|
|
export function getNextIssueCommentPageParam(
|
|
lastPage: ReadonlyArray<IssueComment> | undefined,
|
|
pageSize: number,
|
|
): string | undefined {
|
|
if (!lastPage || lastPage.length < pageSize) return undefined;
|
|
return lastPage[lastPage.length - 1]?.id;
|
|
}
|
|
|
|
function getNextPageCursor<T extends { id: string }>(
|
|
lastPage: ReadonlyArray<T> | undefined,
|
|
pageSize: number,
|
|
): string | undefined {
|
|
if (!lastPage || lastPage.length < pageSize) return undefined;
|
|
return lastPage[lastPage.length - 1]?.id;
|
|
}
|
|
|
|
export async function loadRemainingIssueCommentPages<T extends { id: string }>(params: {
|
|
pages: ReadonlyArray<ReadonlyArray<T>> | undefined;
|
|
pageParams: ReadonlyArray<string | null> | undefined;
|
|
pageSize: number;
|
|
maxPages?: number;
|
|
fetchPage: (afterCommentId: string) => Promise<ReadonlyArray<T>>;
|
|
}): Promise<{ pages: T[][]; pageParams: Array<string | null> }> {
|
|
const pages = (params.pages ?? []).map((page) => [...page]);
|
|
const pageParams = params.pageParams
|
|
? [...params.pageParams].slice(0, pages.length)
|
|
: pages.map(() => null);
|
|
|
|
while (pageParams.length < pages.length) {
|
|
pageParams.push(null);
|
|
}
|
|
|
|
if (params.pageSize <= 0) return { pages, pageParams };
|
|
|
|
let cursor = getNextPageCursor(pages[pages.length - 1], params.pageSize);
|
|
const maxPages = Math.max(0, params.maxPages ?? Number.POSITIVE_INFINITY);
|
|
const seenCursors = new Set<string>();
|
|
while (cursor && !seenCursors.has(cursor) && seenCursors.size < maxPages) {
|
|
seenCursors.add(cursor);
|
|
const nextPage = [...await params.fetchPage(cursor)];
|
|
pages.push(nextPage);
|
|
pageParams.push(cursor);
|
|
|
|
cursor = getNextPageCursor(nextPage, params.pageSize);
|
|
}
|
|
|
|
return { pages, pageParams };
|
|
}
|
|
|
|
export function shouldAutoloadOlderIssueComments(params: {
|
|
activeDetailTab: string;
|
|
hasOlderComments: boolean;
|
|
loadedCommentCount: number;
|
|
initialPageLoading: boolean;
|
|
olderPageLoading: boolean;
|
|
autoLoadLimit: number;
|
|
}) {
|
|
if (params.activeDetailTab !== "chat") return false;
|
|
if (!params.hasOlderComments) return false;
|
|
if (params.initialPageLoading || params.olderPageLoading) return false;
|
|
if (params.loadedCommentCount === 0) return false;
|
|
return params.loadedCommentCount < params.autoLoadLimit;
|
|
}
|
|
|
|
export function upsertIssueComment(
|
|
comments: IssueComment[] | undefined,
|
|
nextComment: IssueComment,
|
|
): IssueComment[] {
|
|
const current = comments ?? [];
|
|
const existingIndex = current.findIndex((comment) => comment.id === nextComment.id);
|
|
if (existingIndex === -1) {
|
|
return sortIssueComments([...current, nextComment]);
|
|
}
|
|
|
|
const updated = [...current];
|
|
updated[existingIndex] = nextComment;
|
|
return sortIssueComments(updated);
|
|
}
|
|
|
|
export function applyOptimisticIssueCommentUpdate(
|
|
issue: Issue | undefined,
|
|
params: {
|
|
reopen?: boolean;
|
|
reassignment?: IssueCommentReassignment;
|
|
},
|
|
) {
|
|
if (!issue) return issue;
|
|
const nextIssue: Issue = { ...issue };
|
|
|
|
if (params.reopen === true && (issue.status === "done" || issue.status === "cancelled" || issue.status === "blocked")) {
|
|
nextIssue.status = "todo";
|
|
}
|
|
|
|
if (params.reassignment) {
|
|
nextIssue.assigneeAgentId = params.reassignment.assigneeAgentId;
|
|
nextIssue.assigneeUserId = params.reassignment.assigneeUserId;
|
|
}
|
|
|
|
return nextIssue;
|
|
}
|
|
|
|
export function applyOptimisticIssueFieldUpdate(
|
|
issue: Issue | undefined,
|
|
data: Record<string, unknown>,
|
|
) {
|
|
if (!issue) return issue;
|
|
|
|
const nextIssue: Issue = {
|
|
...issue,
|
|
updatedAt: new Date(),
|
|
};
|
|
const hasOwn = (key: string) => Object.prototype.hasOwnProperty.call(data, key);
|
|
const assign = <K extends keyof Issue>(key: K) => {
|
|
if (hasOwn(key)) {
|
|
nextIssue[key] = data[key] as Issue[K];
|
|
}
|
|
};
|
|
|
|
assign("status");
|
|
assign("priority");
|
|
assign("assigneeAgentId");
|
|
assign("assigneeUserId");
|
|
assign("projectId");
|
|
assign("parentId");
|
|
assign("projectWorkspaceId");
|
|
assign("executionWorkspaceId");
|
|
assign("executionWorkspacePreference");
|
|
assign("executionWorkspaceSettings");
|
|
assign("hiddenAt");
|
|
|
|
if (hasOwn("labelIds") && Array.isArray(data.labelIds)) {
|
|
const nextLabelIds = data.labelIds.filter((value): value is string => typeof value === "string");
|
|
nextIssue.labelIds = nextLabelIds;
|
|
if (issue.labels) {
|
|
nextIssue.labels = issue.labels.filter((label) => nextLabelIds.includes(label.id));
|
|
}
|
|
}
|
|
|
|
if (hasOwn("blockedByIssueIds") && Array.isArray(data.blockedByIssueIds) && issue.blockedBy) {
|
|
const nextBlockedByIds = new Set(
|
|
data.blockedByIssueIds.filter((value): value is string => typeof value === "string"),
|
|
);
|
|
nextIssue.blockedBy = issue.blockedBy.filter((relation) => nextBlockedByIds.has(relation.id));
|
|
}
|
|
|
|
if (hasOwn("projectId")) {
|
|
nextIssue.project = issue.project?.id === nextIssue.projectId ? issue.project : null;
|
|
}
|
|
|
|
if (hasOwn("parentId")) {
|
|
nextIssue.ancestors = undefined;
|
|
}
|
|
|
|
if (hasOwn("executionWorkspaceId")) {
|
|
nextIssue.currentExecutionWorkspace =
|
|
issue.currentExecutionWorkspace?.id === nextIssue.executionWorkspaceId
|
|
? issue.currentExecutionWorkspace
|
|
: null;
|
|
}
|
|
|
|
return nextIssue;
|
|
}
|
|
|
|
export function matchesIssueRef(
|
|
issue: Pick<Issue, "id" | "identifier">,
|
|
refs: Iterable<string>,
|
|
) {
|
|
const refSet = refs instanceof Set ? refs : new Set(refs);
|
|
return refSet.has(issue.id) || (!!issue.identifier && refSet.has(issue.identifier));
|
|
}
|
|
|
|
export function applyOptimisticIssueFieldUpdateToCollection(
|
|
issues: Issue[] | undefined,
|
|
refs: Iterable<string>,
|
|
data: Record<string, unknown>,
|
|
) {
|
|
if (!issues) return issues;
|
|
|
|
let changed = false;
|
|
const nextIssues = issues.map((issue) => {
|
|
if (!matchesIssueRef(issue, refs)) return issue;
|
|
changed = true;
|
|
return applyOptimisticIssueFieldUpdate(issue, data) ?? issue;
|
|
});
|
|
|
|
return changed ? nextIssues : issues;
|
|
}
|
|
|
|
export function upsertIssueCommentInPages(
|
|
pages: ReadonlyArray<ReadonlyArray<IssueComment>> | undefined,
|
|
nextComment: IssueComment,
|
|
): IssueComment[][] {
|
|
if (!pages || pages.length === 0) {
|
|
return [[nextComment]];
|
|
}
|
|
|
|
const nextPages = pages.map((page) => [...page]);
|
|
for (let pageIndex = 0; pageIndex < nextPages.length; pageIndex += 1) {
|
|
const existingIndex = nextPages[pageIndex]!.findIndex((comment) => comment.id === nextComment.id);
|
|
if (existingIndex === -1) continue;
|
|
nextPages[pageIndex]![existingIndex] = nextComment;
|
|
nextPages[pageIndex] = sortIssueCommentsDesc(nextPages[pageIndex]!);
|
|
return nextPages;
|
|
}
|
|
|
|
nextPages[0] = sortIssueCommentsDesc([...nextPages[0]!, nextComment]);
|
|
return nextPages;
|
|
}
|
|
|
|
export function removeIssueCommentFromPages(
|
|
pages: ReadonlyArray<ReadonlyArray<IssueComment>> | undefined,
|
|
commentId: string,
|
|
): IssueComment[][] {
|
|
if (!pages || pages.length === 0) {
|
|
return [];
|
|
}
|
|
|
|
return pages
|
|
.map((page) => page.filter((comment) => comment.id !== commentId))
|
|
.filter((page) => page.length > 0);
|
|
}
|