mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-31 22:24:16 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The Claude local adapter supports subscription login through a sandbox > - The new-agent page must show login before the user creates an agent > - Test results must not expose raw sandbox diagnostics or secret values > - This pull request adds the login UI to both Test lanes and closes the diagnostic boundary > - The branch also adds durable cleanup recovery for failed sandbox teardown > - Reusable sandboxes must retain both their recorded teardown configuration and a valid lifecycle path until destruction succeeds > - The benefit is a usable login flow with fixed public checks, redacted server logs, and recoverable sandbox cleanup ## Linked Issues or Issue Description Related public work: [#9488](https://github.com/paperclipai/paperclip/pull/9488) adds first-class recognition for `CLAUDE_CODE_OAUTH_TOKEN` in headless and remote runs. Related public issue: [#2681](https://github.com/paperclipai/paperclip/issues/2681) requests Claude Code subscription support. This pull request adds the login transport and new-agent UI flow that those changes do not provide. **Subsystem affected:** Claude local adapter, server login probes, sandbox provider setup, cleanup recovery, and the new-agent UI. **Problem or motivation:** The Test lanes did not show the sandbox login panel in all supported cases. Test results also exposed raw probe diagnostics, and JSON escapes could end secret redaction early. **Proposed solution:** Surface the login capability through the bundled provider manifest. Prepare the same probe runtime in the ACP lane. Send diagnostics only to redacted server logs. Keep Test checks on fixed public messages. Normalize login URL hints to allowlisted HTTPS Claude and Anthropic hosts. Consume JSON escapes during redaction. Preserve failed sandbox cleanup state across retries and restarts, and prevent deletion from severing the lifecycle context of a live reusable sandbox. **Alternatives considered:** Keep raw diagnostics in Test checks or trust login URL text from the sandbox. Both choices increase information exposure. Keep separate probe behavior in the ACP lane. That choice would leave the two Test lanes inconsistent. ## What Changed - Surface the sandbox login panel on both Test lanes. - Reconcile the bundled Daytona plugin manifest so `supportsSetupTokenLogin` reaches the UI capability gate. - Prepare the ACP Test lane with the same probe runtime as the CLI Test lane. - Add the `claude_acp_login_probe_unavailable` warning when the ACP probe cannot run. - Send raw sandbox diagnostics only to redacted server logs. - Keep Test checks on fixed public messages in the ACP, managed-config, and CLI paths. - Normalize login URL hints to allowlisted HTTPS Claude and Anthropic hosts. - Redact JSON and escaped-JSON secret values, including escaped quotes and backslashes. - Preserve orphan cleanup records across provider failures, restarts, and unavailable plugins. - Atomically block environment deletion while a live reusable sandbox lease still depends on it. - Verify pending cleanup destroys plugin sandboxes with the provider configuration recorded on the lease, even after the current environment configuration changes. ## Verification - Head under review: `506b7fa2d83c36bfa5fd722ee9d95b0c7431c241`. - Focused environment route/service/runtime coverage passes: 196 tests across 3 files. - `pnpm -r typecheck` passes. - `pnpm build` passes. - The full Vitest run completed with 4,754 passing and 28 failing tests. All 23 source-test failures reproduce unchanged on parent head `58cfe61a33191ce03d965d65085d26064b4888ba`; the other 5 are duplicate executions from stale `server/dist` output. The failures are unrelated macOS path/listener and scheduler-fixture failures, so there is no new bad commit for bisect to localize. - All required CI checks pass for the current head, including build, typecheck/release registry, all server and workspace shards, serialized server suites, canary, and e2e. - A fresh Greptile review for `506b7fa2d83c36bfa5fd722ee9d95b0c7431c241` reports 5/5, “safe to merge,” with no blocking failure remaining. ## Risks - A probe or redaction change could hide useful server diagnostics. - An allowlist change could reject a valid Claude login URL. - Cleanup recovery changes could affect provider teardown ordering. - An environment with a live reusable sandbox can no longer be deleted until the owning issue or execution workspace completes teardown. - The implementation keeps public Test messages fixed and sends detail to redacted server logs. ## Model Used OpenAI GPT-5 via Codex — exact model ID: GPT-5; tool use and code execution enabled; extended reasoning enabled. The implementation author used AI-assisted development. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes: #` / `Refs: #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and documented the result - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation or confirmed no separate documentation change is needed - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
162 lines
5.3 KiB
JavaScript
162 lines
5.3 KiB
JavaScript
// Test worker fixture for the host-owned setup-token login pseudo-terminal route
|
|
// gate. The fixture drives the manager route state machine through
|
|
// the four typed methods (open, input, stop, close) and the output and exit
|
|
// notifications.
|
|
//
|
|
// The manager allowlists `command` to the fixed `CLAUDE_SETUP_TOKEN_COMMAND`. The
|
|
// test encodes a JSON directive in the forwarded `providerLeaseId`, so one fixture
|
|
// serves every route-gate case:
|
|
// - `mode`: "normal" | "malformed-open" | "no-open-reply" | "duplicate-open-reply"
|
|
// - `workerSessionId`: the worker session id the open reply returns (default "ws-1")
|
|
// - `outputs`: an array of `{ chunk, sid? }`. The fixture emits each as an output
|
|
// notification after the open reply. `sid` defaults to the real worker session
|
|
// id; a test sets a wrong `sid` to prove the host drops a mismatched
|
|
// notification.
|
|
// - `exitCode`: when set, the fixture emits an exit notification after the outputs.
|
|
// - `closeMode`: "ack" | "bad-ack" | "no-ack" (default "ack"). It controls the
|
|
// close reply, so a test proves the host retires the worker on an unconfirmed
|
|
// close.
|
|
const readline = require("node:readline");
|
|
|
|
function send(message) {
|
|
process.stdout.write(`${JSON.stringify(message)}\n`);
|
|
}
|
|
|
|
// The registered terminals, keyed by the host route id. Each entry records the
|
|
// bound worker session id and the close directive.
|
|
const routes = new Map();
|
|
|
|
function parseDirective(raw) {
|
|
try {
|
|
const parsed = JSON.parse(raw);
|
|
return parsed && typeof parsed === "object" ? parsed : {};
|
|
} catch {
|
|
return {};
|
|
}
|
|
}
|
|
|
|
const rl = readline.createInterface({ input: process.stdin, crlfDelay: Infinity });
|
|
|
|
rl.on("line", (line) => {
|
|
if (!line.trim()) return;
|
|
const message = JSON.parse(line);
|
|
const method = message && typeof message.method === "string" ? message.method : null;
|
|
const params = message.params ?? {};
|
|
|
|
if (method === "initialize") {
|
|
send({
|
|
jsonrpc: "2.0",
|
|
id: message.id,
|
|
result: {
|
|
ok: true,
|
|
supportedMethods: [
|
|
"setupTokenPtyOpen",
|
|
"setupTokenPtyInput",
|
|
"setupTokenPtyStop",
|
|
"setupTokenPtyClose",
|
|
],
|
|
},
|
|
});
|
|
return;
|
|
}
|
|
|
|
if (method === "setupTokenPtyOpen") {
|
|
const directive = parseDirective(params.providerLeaseId);
|
|
const mode = directive.mode ?? "normal";
|
|
const workerSessionId = directive.workerSessionId ?? "ws-1";
|
|
const closeMode = directive.closeMode ?? "ack";
|
|
routes.set(params.hostRouteId, { workerSessionId, closeMode });
|
|
|
|
if (mode === "no-open-reply") {
|
|
// Never reply, so the host open call times out.
|
|
return;
|
|
}
|
|
if (mode === "malformed-open") {
|
|
// Reply with no worker session id, so the host terminalizes the route.
|
|
send({ jsonrpc: "2.0", id: message.id, result: {} });
|
|
return;
|
|
}
|
|
|
|
const reply = () =>
|
|
send({ jsonrpc: "2.0", id: message.id, result: { workerSessionId } });
|
|
reply();
|
|
if (mode === "duplicate-open-reply") {
|
|
// Send a second open reply for the same request id. The host drops it.
|
|
reply();
|
|
}
|
|
|
|
// Emit the scripted output and the exit after the open reply, so the host
|
|
// binds the route first.
|
|
setImmediate(() => {
|
|
const outputs = Array.isArray(directive.outputs) ? directive.outputs : [];
|
|
for (const entry of outputs) {
|
|
send({
|
|
jsonrpc: "2.0",
|
|
method: "setupTokenPty.output",
|
|
params: {
|
|
workerSessionId: entry.sid ?? workerSessionId,
|
|
chunk: entry.chunk,
|
|
},
|
|
});
|
|
}
|
|
if (typeof directive.exitCode === "number") {
|
|
send({
|
|
jsonrpc: "2.0",
|
|
method: "setupTokenPty.exit",
|
|
params: { workerSessionId, exitCode: directive.exitCode },
|
|
});
|
|
}
|
|
});
|
|
return;
|
|
}
|
|
|
|
if (method === "setupTokenPtyInput") {
|
|
// Echo the input back as one output notification for the bound session, so a
|
|
// test proves the input reaches the worker and the output routes back.
|
|
for (const entry of routes.values()) {
|
|
if (entry.workerSessionId === params.workerSessionId) {
|
|
send({
|
|
jsonrpc: "2.0",
|
|
method: "setupTokenPty.output",
|
|
params: { workerSessionId: entry.workerSessionId, chunk: `echo:${params.data}` },
|
|
});
|
|
}
|
|
}
|
|
send({ jsonrpc: "2.0", id: message.id, result: null });
|
|
return;
|
|
}
|
|
|
|
if (method === "setupTokenPtyStop") {
|
|
send({ jsonrpc: "2.0", id: message.id, result: null });
|
|
return;
|
|
}
|
|
|
|
if (method === "setupTokenPtyClose") {
|
|
const entry = routes.get(params.hostRouteId);
|
|
routes.delete(params.hostRouteId);
|
|
const closeMode = entry ? entry.closeMode : "ack";
|
|
if (closeMode === "no-ack") {
|
|
// Never reply, so the host close call times out and the host retires us.
|
|
return;
|
|
}
|
|
if (closeMode === "bad-ack") {
|
|
send({ jsonrpc: "2.0", id: message.id, result: { hostRouteId: "mismatched-route" } });
|
|
return;
|
|
}
|
|
send({ jsonrpc: "2.0", id: message.id, result: { hostRouteId: params.hostRouteId } });
|
|
return;
|
|
}
|
|
|
|
if (method === "shutdown") {
|
|
send({ jsonrpc: "2.0", id: message.id, result: {} });
|
|
setImmediate(() => process.exit(0));
|
|
return;
|
|
}
|
|
|
|
send({
|
|
jsonrpc: "2.0",
|
|
id: message.id,
|
|
error: { code: -32601, message: `Unhandled method: ${method}` },
|
|
});
|
|
});
|