Files
PaperClipAI/packages
Nicky LeachandClaude Opus 5.5 fb288f5666 fix(acpx): only treat an error result as a Claude sign-in failure (#21921)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - Claude agents run through the Claude ACP bridge (`claude-agent-acp`
0.73.0), which Paperclip patches in `patches/`
> - The bridge reads Claude Code's final result for each turn. If the
result text contains "Please run /login", the bridge fails the turn as a
sign-in failure
> - That check does not look at `is_error`. A successful reply that
quotes the CLI's sign-in hint also fails the turn
> - Agents quote that hint when they report the output of a `claude`
command that they ran. The work is done, but the run fails with "ACP
agent reported a terminal access failure."
> - Upstream fixed this in
[agentclientprotocol/claude-agent-acp#1103](https://github.com/agentclientprotocol/claude-agent-acp/pull/1103)
(commit
[`6e97e07`](https://github.com/agentclientprotocol/claude-agent-acp/commit/6e97e071c581002b43d9556dbd1d1376ebf9516f),
released in 0.81.1), "fix: gate login result text on error state"
> - This pull request ports that upstream change into the 0.73.0 bridge
patch
> - The benefit is that a correct, finished run is not reported as a
failed sign-in

## Linked Issues or Issue Description

Upstream fix:
[agentclientprotocol/claude-agent-acp#1103](https://github.com/agentclientprotocol/claude-agent-acp/pull/1103)
(commit
[`6e97e07`](https://github.com/agentclientprotocol/claude-agent-acp/commit/6e97e071c581002b43d9556dbd1d1376ebf9516f),
released in 0.81.1). This pull request ports it.

Refs #14089. That pull request fixes the same class of problem in the
Claude CLI lane (`execute.ts`). This pull request fixes the ACP lane.

Related: #14093 shows the same error text, but it has a different cause.
This pull request does not fix #14093.

**What happened?**

An agent ran a script that calls the `claude` CLI without credentials.
The CLI printed "Not logged in · Please run /login". The agent finished
its task and quoted that text in its final reply. Claude Code ended the
turn with a successful result (`is_error: false`). The bridge saw
"Please run /login" in the result text and failed the turn with
`auth_required`. Paperclip then failed the run with "ACP agent reported
a terminal access failure."

**Expected behavior**

A successful result completes the turn. Only an error result with the
sign-in hint is a sign-in failure.

**Steps to reproduce**

1. Run a Claude agent on the ACP lane.
2. Make the model's final reply contain the text "Please run /login"
(for example, quote the output of `claude -p hi` without credentials).
3. See that the run fails with "ACP agent reported a terminal access
failure." The new test in this pull request does these steps against a
local API stand-in.

**Agent adapter(s) involved**

`claude_local` on the ACP engine, and the Runner's ACPX Claude profile.
Both use the same patched bridge.

## What Changed

- `patches/@agentclientprotocol__claude-agent-acp@0.73.0.patch`: port
[agentclientprotocol/claude-agent-acp#1103](https://github.com/agentclientprotocol/claude-agent-acp/pull/1103)
(commit
[`6e97e07`](https://github.com/agentclientprotocol/claude-agent-acp/commit/6e97e071c581002b43d9556dbd1d1376ebf9516f),
released in 0.81.1). It has two parts, the same as upstream:
- The `success` result check is now `message.is_error &&
message.result.includes("Please run /login")`. A successful result that
quotes the sign-in hint no longer fails the turn.
- The goal-command check also requires `message.is_error`. A `/goal`
command whose successful result quotes the sign-in hint no longer rolls
the session goal back.
- Both patch comments name the upstream change. All other patch hunks
are unchanged.
-
`packages/paperclip-runner/src/drivers/acpx/acpx-runtime-adapter.claude-login-text.test.ts`:
a new test. It runs the real bridge and the bundled Claude Code against
a local API stand-in. The model's reply quotes the sign-in hint, and the
test expects the turn to complete.

## Verification

- Red: on `master`'s patch, the new test fails with
`{"status":"failed","error":{"message":"ACP agent reported a terminal
access failure."}}`.
- Green: with this patch, the new test passes (`status: "completed"`,
`stopReason: "end_turn"`).
- I ran Claude Code 2.1.286 (the bundled version) with no credentials.
Its real sign-in failure is a result with `is_error: true` and the text
"Not logged in · Please run /login". The guard still catches it. The
separate synthetic sign-in message check is unchanged.
- The goal-command part has no new test here. The upstream change adds a
test for it. The runner's `session-goals.test.ts` passes with the new
patch.
- `node --test scripts/acpx-patch-packaging.test.mjs`: 26 passed.
- `node --test
packages/paperclip-runner/test/acpx-codex-package-contract.test.mjs`: 9
passed.
- Runner real-bridge Claude tests
(`acpx-runtime-adapter.claude-*.test.ts`,
`acpx-runtime-adapter.test.ts`,
`claude-scheduling-tools.claude-acp.test.ts`,
`runner-tool-bridge.claude-*.test.ts`): 139 passed.
- `claude-local` ACP tests (`acp.test.ts`, `acp.auth.test.ts`,
`acp.quota.test.ts`): 95 passed.
- `pnpm --filter @paperclipai/paperclip-runner run
typecheck:typescript`: passed.
- I did not commit `pnpm-lock.yaml`. The patch hash changes, and CI
resolves the lockfile for this run.

## Risks

- Low risk. The change adds one condition to each of two checks in the
bridge patch. Both match the upstream change.
- The bridge's `commandDigest` does not change, because the patch does
not touch `dist/index.js`. Saved sessions are not reset.
- A sign-in failure that Claude Code reports as a successful, non-error
result is no longer caught by this check. Claude Code 2.1.286 reports
sign-in failures as error results, and upstream uses the same rule.

## Model Used

Claude Opus 5.5 (`claude-opus-5-5`) in Claude Code, with tool use
(shell, file edits, subagents) and extended thinking.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-16 12:14:57 -08:00
..