Files
PaperClipAI/ui/src/components/task-chat/TaskChatQueuedMessages.test.tsx
T
DottaandClaude Opus 5.5 d10c6e0e8b fix(chat): hold a chat message at the agent's daily limit instead of dropping it (#20292)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - Agent Chat sends each person's message to the conversation agent
through a durable outbox (`deliverConversationComments`). The outbox
keys each wake receipt as `conversation-comment:<commentId>`.
> - The outbox treats any receipt with that key as delivered. Queue
admission writes a `skipped` receipt when the agent reached its daily
run or cost limit.
> - So a chat message sent after the agent used its daily allowance was
consumed silently. No run started, the chat showed nothing, and nothing
resumed it.
> - A person's message must never be silently dropped. The daily limit
is an operator control, so the message must wait honestly, not bypass
the limit.
> - This pull request makes the outbox hold the message at the daily
limit, like it already does for a paused agent, and resume it when the
limit resets.
> - The benefit is that a chat message at the daily limit is saved,
shown with its reason, and sent automatically at 00:00 UTC.

## Linked Issues or Issue Description

No public issue exists. Inline bug report:

**What happened**

In a chat eval, the conversation agent (CEO) had `maxDailyRuns: 3`.
After three chat turns and a separate failed-model phase on another
agent, the person sent a fourth message. The comment was saved (POST
201), but no CEO run started. The conversation stayed `active` with no
`executionRunId`. The ownership reconciler later reported
`I7_visible_next_action`. The server log shows no wake error. Queue
admission had written a `skipped` receipt (`heartbeat.daily_run_limit`)
under the outbox key, so the outbox counted the message as delivered.

**Expected behavior**

A chat message that reaches the agent's daily limit is not consumed. It
stays saved, the chat shows why it waits, and it is sent automatically
when the limit resets. The daily limit still applies: the message does
not start a run early.

**Steps to reproduce**

1. Set a conversation agent's `runtimeConfig.heartbeat.maxDailyRuns` to
N.
2. Send N chat messages and let each turn finish.
3. Send one more chat message.
4. See that no run starts, the chat shows no waiting state, and the
message is never answered (a `skipped` wake receipt with reason
`heartbeat.daily_run_limit` exists for `conversation-comment:<id>`).

## What Changed

- `server/src/services/agent-conversations.ts`: add
`conversationDeliveryHold`, which applies the same daily run/cost limit
check as queue admission. The outbox returns `deferred` at the limit and
writes no receipt, so the message stays owed. It reports the next UTC
day start through a new optional `onDeferredDeadline` option.
- `server/src/services/recovery/service.ts`: stranded-work recovery
passes its `onDeferredDeadline` to the outbox, so the held message is
retried when the limit resets.
- `server/src/services/heartbeat/queue.ts`: if the limit is reached
while an outbox wake is in admission (a race), admission throws a 409
with `reason: heartbeat.daily_*` for `conversation-comment:` keys
instead of writing a `skipped` receipt. The outbox already maps a
matching 409 to `deferred`. Other wakes keep the current skip behavior.
- `server/src/routes/issues.ts` (`GET /issues/:id/queued-comments`):
when a chat has no queue receipt but has messages held by the daily
limit, return them as a `deferred` queue with `executionWait` (reason
and message). Edit, send and discard stay off because the outbox owns
delivery.
- `ui/src/components/task-chat/TaskChatQueuedMessages.tsx`: show the
`executionWait` message for such an outbox-held queue (no queue id and
no target run). Receipt-backed queues keep the current behavior and do
not duplicate the task status.
- Tests: three real-database tests in
`agent-conversation-delivery.test.ts` (hold and resume after the limit
resets, recovery deadline, and a limit reached during real
`heartbeatService.wakeup` admission) and one UI test.

## Verification

- `cd server && pnpm exec vitest run
src/__tests__/agent-conversation-delivery.test.ts`: 10 passed. Without
the source change, the three new tests fail (`expected 'delivered' to be
'deferred'`; the real queue path writes the skipped receipt).
- `cd server && pnpm exec vitest run
src/__tests__/issue-recovery-conversations.test.ts
src/__tests__/agent-conversations.test.ts
src/__tests__/heartbeat-undispatched-execution-wait.test.ts
src/services/heartbeat/queue.test.ts
src/__tests__/agent-chat-messages.test.ts`: 215 passed.
- `cd ui && pnpm exec vitest run
src/components/task-chat/TaskChatQueuedMessages.test.tsx`: 36 passed.
- `pnpm exec tsc --noEmit -p server/tsconfig.json`: clean. `node
scripts/check-token-gates.mjs`: clean.
- Manual: give a chat agent `maxDailyRuns: 1`, send two messages. The
second message shows in the queued messages bar with "<agent> reached
its daily run limit. Your message is saved and sends automatically when
the limit resets at 00:00 UTC."

## Risks

- Behavior change for chat only: a chat message at the daily limit now
waits in the outbox instead of being consumed. It is sent after 00:00
UTC. If an operator raises the limit, the message is sent on the next
recovery pass for that chat; the UI message does not promise an earlier
send.
- Saved state from the previous release: no persisted shape changes.
Messages that an earlier release already consumed with a `skipped`
receipt stay consumed. They are not replayed later, which avoids sending
old messages without notice.
- The queued-comments read adds one agent read and one daily-limit count
for a chat with no queue receipt. This is the same query that admission
runs.
- The recovery deadline is in-process; instance-sleep scheduling does
not get a new deadline from this change.

## Model Used

- Anthropic Claude Opus 5.5 (`claude-opus-5-5`), agentic coding with
tool use (shell, file edits, test runs).

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 10:03:28 -06:00

611 lines
27 KiB
TypeScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
// @vitest-environment jsdom
import { act, type ComponentProps } from "react";
import { flushSync } from "react-dom";
import { createRoot, type Root } from "react-dom/client";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import type { IssueQueuedCommentQueue } from "@paperclipai/shared";
import {
reorderQueuedMessageEntries,
TaskChatQueuedMessages,
} from "./TaskChatQueuedMessages";
function deferred<T>() {
let resolve!: (value: T) => void;
let reject!: (error: Error) => void;
const promise = new Promise<T>((innerResolve, innerReject) => {
resolve = innerResolve;
reject = innerReject;
});
return { promise, resolve, reject };
}
const queue: IssueQueuedCommentQueue = {
issueId: "issue-1",
queueId: "wake-1",
state: "deferred",
targetRunId: "run-1",
revision: "rev-1",
protocol: "paperclip_runner_v1",
steeringDisposition: "available",
entries: ["First queued message", "Second queued message"].map(
(body, position) => ({
comment: {
id: `comment-${position + 1}`,
companyId: "company-1",
issueId: "issue-1",
authorType: "user",
authorAgentId: null,
authorUserId: "user-1",
body,
presentation: null,
metadata: null,
createdAt: new Date(),
updatedAt: new Date(),
},
position,
canEdit: true,
canDiscard: true,
}),
),
};
describe("TaskChatQueuedMessages", () => {
let container: HTMLDivElement;
let root: Root;
beforeEach(() => {
container = document.createElement("div");
document.body.appendChild(container);
root = createRoot(container);
});
afterEach(() => {
flushSync(() => root.unmount());
container.remove();
});
function render(
overrides: Partial<ComponentProps<typeof TaskChatQueuedMessages>> = {},
) {
const props = {
queue,
onEdit: vi.fn(),
onReorder: vi.fn().mockResolvedValue(undefined),
onSteer: vi.fn().mockResolvedValue(undefined),
onDiscard: vi.fn().mockResolvedValue(undefined),
...overrides,
};
flushSync(() => root.render(<TaskChatQueuedMessages {...props} />));
return props;
}
it("keeps saved input visible without duplicating the task status", () => {
const message = "Waiting for the previous environment to stop. Your message will start automatically.";
render({ queue: { ...queue, executionWait: { reason: "remote_cleanup", message } } });
expect(container.textContent).not.toContain(message);
expect(container.textContent).toContain("First queued message");
render();
expect(container.textContent).not.toContain(message);
});
it("says why a chat message held in the outbox waits, without offering queue actions", () => {
const message = "CEO reached its daily run limit. Your message is saved and sends automatically when the limit resets at 00:00 UTC.";
render({ queue: { ...queue, queueId: null, targetRunId: null, steeringDisposition: "unsupported",
executionWait: { reason: "heartbeat.daily_run_limit", message },
entries: queue.entries.slice(0, 1).map(entry => ({ ...entry, canEdit: false, canDiscard: false })) } });
expect([...container.querySelectorAll('p[role="status"]')].map(node => node.textContent)).toEqual([message]);
expect(container.textContent).toContain("First queued message");
expect(container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-interrupt-comment-1"]')?.disabled ?? true).toBe(true);
expect(container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-discard-comment-1"]')?.disabled).toBe(true);
});
it("renders each queued message once as a compact one-line row", () => {
render();
const pane = container.querySelector(
'[data-testid="task-chat-queued-messages"]',
);
expect(pane?.classList).toContain("mx-3");
expect(pane?.classList).toContain("rounded-b-none");
expect(pane?.classList).toContain("border-b-0");
expect(pane?.classList).toContain("-mb-px");
expect(
container.querySelectorAll('[data-testid^="task-chat-queued-message-"]'),
).toHaveLength(2);
expect(container.textContent).toContain("First queued message");
expect(container.textContent).toContain("Second queued message");
});
it.each(["legacy", "native", "native-plan"] as const)("shows a read-only response and sends it only on click for %s", async (runtime) => {
const entry = { ...queue.entries[0], canEdit: false, canDiscard: false,
comment: { ...queue.entries[0].comment, body: 'Accepted: Build the app\n\n{"revision": "v1"}' },
source: { kind: "interaction" as const, interactionId: "confirmation-1", interactionKind: "request_confirmation",
requiresFreshSession: runtime === "native-plan" } };
const props = render({ queue: { ...queue, entries: [entry],
protocol: runtime === "legacy" ? "legacy" : "paperclip_runner_v1" },
onInterrupt: vi.fn().mockResolvedValue(undefined) });
expect(props.onSteer).not.toHaveBeenCalled();
expect(props.onInterrupt).not.toHaveBeenCalled();
expect(container.textContent).toContain("Accepted: Build the app");
expect(container.textContent).not.toContain('"revision"');
expect(container.querySelector<HTMLButtonElement>('[aria-label^="Reorder"]')?.disabled).toBe(true);
expect(container.querySelector<HTMLButtonElement>('[data-testid^="task-chat-queued-discard-"]')?.disabled).toBe(true);
expect(reorderQueuedMessageEntries([entry, queue.entries[1]], "comment-1", "comment-2")).toBeNull();
const action = runtime === "native" ? "steer" : "interrupt";
await act(async () => { container.querySelector<HTMLButtonElement>(`[data-testid="task-chat-queued-${action}-comment-1"]`)!.click(); });
if (action === "steer") expect(props.onSteer).toHaveBeenCalledWith("comment-1", "rev-1");
else expect(props.onInterrupt).toHaveBeenCalledOnce();
});
it("shows a declined connection request as readable text, never its raw JSON receipt (BUG-08)", () => {
const receipt = JSON.stringify({ interactionId: "slack-1", kind: "connection_intent", status: "rejected",
payload: { serviceSlug: "slack", serviceName: "Slack" }, result: { outcome: "declined" } }, null, 2);
const entry = { ...queue.entries[0], canEdit: false, canDiscard: false,
comment: { ...queue.entries[0].comment, id: "slack-1", body: `Rejected: Connect Slack\n\n${receipt}` },
source: { kind: "interaction" as const, interactionId: "slack-1", interactionKind: "connection_intent",
summary: "Declined: Slack connection" } };
render({ queue: { ...queue, entries: [entry], steeringDisposition: "temporarily_unavailable" } });
const row = container.querySelector('[data-testid="task-chat-queued-message-slack-1"]')!;
const hoverAndLabels = [...row.querySelectorAll("[title], [aria-label]")]
.flatMap((element) => [element.getAttribute("title"), element.getAttribute("aria-label")])
.filter((text): text is string => Boolean(text));
expect(hoverAndLabels.length).toBeGreaterThan(0);
for (const text of hoverAndLabels) {
expect(text).not.toContain("{");
expect(text).not.toContain("interactionId");
}
expect(row.textContent).toContain("Declined: Slack connection");
expect(row.querySelector('[title="Declined: Slack connection"]')).not.toBeNull();
});
it("reorders the complete queue and rewrites contiguous positions", () => {
const next = reorderQueuedMessageEntries(
queue.entries,
"comment-2",
"comment-1",
);
expect(next?.map((entry) => entry.comment.id)).toEqual([
"comment-2",
"comment-1",
]);
expect(next?.map((entry) => entry.position)).toEqual([0, 1]);
});
it("removes the selected steering row before the provider acknowledges it", async () => {
const acknowledgement = deferred<void>();
const props = render({
onSteer: vi.fn().mockReturnValue(acknowledgement.promise),
});
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-steer-comment-1"]',
)
?.click();
await Promise.resolve();
});
expect(props.onSteer).toHaveBeenCalledWith("comment-1", "rev-1");
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-1"]',
),
).toBeNull();
expect(container.textContent).toContain("Steering queued message.");
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-2"]',
),
).not.toBeNull();
await act(async () => {
render({ ...props, queue: { ...queue, entries: [...queue.entries] } });
});
expect(container.querySelector('[data-testid="task-chat-queued-message-comment-1"]')).toBeNull();
await act(async () => {
acknowledgement.resolve();
await acknowledgement.promise;
});
});
it("clears the entire interrupt queue immediately and restores it inline on failure", async () => {
let rejectInterrupt!: (error: Error) => void;
const interrupted = new Promise<void>((_, reject) => { rejectInterrupt = reject; });
const props = render({ queue: { ...queue, protocol: "legacy", steeringDisposition: "unsupported" },
onInterrupt: vi.fn().mockReturnValue(interrupted) });
await act(async () => {
container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-interrupt-comment-1"]')!.click();
});
expect(props.onInterrupt).toHaveBeenCalledOnce();
expect(container.querySelector('[data-testid="task-chat-queued-messages"]')).toBeNull();
await act(async () => { rejectInterrupt(new Error("Connection lost")); await interrupted.catch(() => undefined); });
expect(container.querySelectorAll('[data-testid^="task-chat-queued-message-"]')).toHaveLength(2);
expect(container.textContent).toContain("Couldn’t interrupt. Message is still queued.");
});
it.each(["steer", "interrupt"] as const)("shows a delivery error even when the queue becomes empty while %s is pending", async action => {
const delivery = deferred<void>();
const props = render({ queue: { ...queue, protocol: action === "interrupt" ? "legacy" : "paperclip_runner_v1" },
onSteer: vi.fn().mockReturnValue(delivery.promise), onInterrupt: vi.fn().mockReturnValue(delivery.promise) });
await act(async () => { container.querySelector<HTMLButtonElement>(`[data-testid="task-chat-queued-${action}-comment-1"]`)!.click(); });
await act(async () => { render({ ...props, queue: { ...props.queue, revision: "empty-poll", entries: [] } }); });
await act(async () => { delivery.reject(new Error("Connection lost")); await delivery.promise.catch(() => undefined); });
const error = action === "steer" ? "Couldn’t steer." : "Couldn’t interrupt.";
expect([...container.querySelectorAll('[role="status"]')].some(status => status.textContent?.includes(error))).toBe(true);
expect(container.querySelector('[data-testid="task-chat-queued-message-comment-1"]')).toBeNull();
});
it("does not restore a message discarded elsewhere while steering was pending", async () => {
let rejectSteer!: (error: Error) => void;
const delivery = new Promise<void>((_, reject) => { rejectSteer = reject; });
const props = render({ onSteer: vi.fn().mockReturnValue(delivery) });
await act(async () => { container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-steer-comment-1"]')!.click(); });
await act(async () => { render({ ...props, queue: { ...queue, revision: "rev-2", entries: [queue.entries[1]] } }); });
await act(async () => { rejectSteer(new Error("Queue changed")); await delivery.catch(() => undefined); });
expect(container.querySelector('[data-testid="task-chat-queued-message-comment-1"]')).toBeNull();
expect(container.querySelector('[data-testid="task-chat-queued-message-comment-2"]')).not.toBeNull();
expect(container.textContent).toContain("Couldn’t steer.");
});
it("keeps a row queued when steering fails and announces the retryable state", async () => {
render({
onSteer: vi.fn().mockRejectedValue(new Error("steering_timeout")),
});
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-steer-comment-1"]',
)
?.click();
});
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-1"]',
),
).not.toBeNull();
expect(container.textContent).toContain(
"Couldn’t steer. Message is still queued.",
);
});
it("disables steering when the provider does not advertise it", () => {
render({ queue: { ...queue, steeringDisposition: "unsupported" } });
expect(
container.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-steer-comment-1"]',
)?.disabled,
).toBe(true);
});
it.each(["temporarily_unavailable", "unsupported"] as const)(
"offers an explicit interrupt fallback when native steering is %s",
async (steeringDisposition) => {
const props = render({
queue: { ...queue, steeringDisposition },
onInterrupt: vi.fn().mockResolvedValue(undefined),
});
const interrupt = container.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-interrupt-comment-1"]',
);
expect(interrupt).not.toBeNull();
expect(interrupt!.disabled).toBe(false);
expect(interrupt!.textContent).toContain("Interrupt");
await act(async () => { interrupt!.click(); });
expect(props.onInterrupt).toHaveBeenCalledOnce();
expect(props.onSteer).not.toHaveBeenCalled();
expect(container.querySelector('[data-testid="task-chat-queued-messages"]')).toBeNull();
},
);
it("keeps same-turn steering when the provider is available, even with an interrupt callback", async () => {
const props = render({ onInterrupt: vi.fn().mockResolvedValue(undefined) });
expect(container.querySelector('[data-testid="task-chat-queued-interrupt-comment-1"]')).toBeNull();
await act(async () => {
container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-steer-comment-1"]')!.click();
});
expect(props.onSteer).toHaveBeenCalledWith("comment-1", "rev-1");
expect(props.onInterrupt).not.toHaveBeenCalled();
});
it("waits for authoritative discard acknowledgement before removing the row", async () => {
const acknowledgement = deferred<void>();
render({ onDiscard: vi.fn().mockReturnValue(acknowledgement.promise) });
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-discard-comment-1"]',
)
?.click();
await Promise.resolve();
});
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-1"]',
),
).not.toBeNull();
expect(container.textContent).not.toContain("Queued message discarded.");
await act(async () => {
acknowledgement.resolve();
await acknowledgement.promise;
});
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-1"]',
),
).toBeNull();
expect(container.textContent).toContain("Queued message discarded.");
});
it("keeps a too-late discard visible with an explicit error", async () => {
render({
onDiscard: vi.fn().mockRejectedValue({
body: { details: { code: "queued_comment_already_dispatching" } },
}),
});
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-discard-comment-1"]',
)
?.click();
});
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-1"]',
),
).not.toBeNull();
expect(container.textContent).toContain(
"Too late to discard: this message is already being sent.",
);
});
it("shows stale revisions without announcing a discard", async () => {
render({
onDiscard: vi.fn().mockRejectedValue({
body: { details: { code: "queued_comment_revision_conflict" } },
}),
});
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-discard-comment-1"]',
)
?.click();
});
expect(container.textContent).toContain(
"The queue changed in another session. Review it and try again.",
);
expect(container.textContent).not.toContain("Queued message discarded.");
});
it("does not expose queue controls before a real queue id is acknowledged", () => {
const props = render({ queue: { ...queue, queueId: null, state: null } });
const discard = container.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-discard-comment-1"]',
);
expect(discard?.disabled).toBe(true);
discard?.click();
expect(props.onDiscard).not.toHaveBeenCalled();
});
it("can discard a local optimistic row before the queue id is acknowledged", async () => {
const optimisticQueue = {
...queue,
queueId: null,
state: "deferred" as const,
entries: [
{
...queue.entries[0],
comment: {
...queue.entries[0].comment,
id: "optimistic-local-1",
},
},
],
};
const props = render({ queue: optimisticQueue });
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-discard-optimistic-local-1"]',
)
?.click();
});
expect(props.onDiscard).toHaveBeenCalledWith("optimistic-local-1", "rev-1");
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-optimistic-local-1"]',
),
).toBeNull();
});
it("delivers legacy queued messages to a live target", async () => {
const targetRunId = "run-1";
const onInterrupt = vi.fn().mockResolvedValue(undefined);
render({
queue: {
...queue,
targetRunId,
protocol: "legacy",
steeringDisposition: "unsupported",
},
onInterrupt,
});
await act(async () => {
container
.querySelector<HTMLButtonElement>(
'[data-testid="task-chat-queued-interrupt-comment-1"]',
)
?.click();
});
expect(onInterrupt).toHaveBeenCalledOnce();
expect(
container.querySelector(
'[data-testid="task-chat-queued-steer-comment-1"]',
),
).toBeNull();
expect(
container.querySelector(
'[data-testid="task-chat-queued-message-comment-1"]',
),
).toBeNull();
});
it("keeps deferred sends visible and explains their current wait", async () => {
const saved = { ...queue, targetRunId: null, executionWait: { reason: "decision_pending", message: "Resolve the pending approval before sending." } };
const onInterrupt = vi.fn().mockResolvedValue(saved);
render({ queue: saved, onInterrupt });
await act(async () => { container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-interrupt-comment-1"]')!.click(); });
expect(container.textContent).toContain("First queued message");
expect(container.textContent).toContain(saved.executionWait.message);
expect(container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-interrupt-comment-1"]')?.disabled).toBe(false);
});
it("clears a deferred wait message when a refreshed queue finishes sending", async () => {
const saved = { ...queue, targetRunId: null, executionWait: { reason: "decision_pending", message: "Resolve the pending approval before sending." } };
render({ queue: saved, onInterrupt: vi.fn().mockResolvedValue(saved) });
await act(async () => { container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-interrupt-comment-1"]')!.click(); });
expect(container.textContent).toContain(saved.executionWait.message);
render({ queue: { ...saved, queueId: null, entries: [], state: null, executionWait: null } });
await act(async () => {});
expect(container.textContent).not.toContain(saved.executionWait.message);
expect(container.querySelector('[data-testid="task-chat-queued-messages"]')).toBeNull();
});
it.each(["legacy", "paperclip_runner_v1"] as const)("sends a saved %s queue explicitly after Stop", async (protocol) => {
const onInterrupt = vi.fn().mockResolvedValue(undefined);
render({ queue: { ...queue, targetRunId: null, protocol, steeringDisposition: "temporarily_unavailable" }, onInterrupt });
expect(onInterrupt).not.toHaveBeenCalled();
const send = container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-interrupt-comment-1"]');
expect(send?.textContent).toBe("Send");
expect(send?.getAttribute("aria-label")).toBe("Send queued messages");
expect(send?.disabled).toBe(false);
await act(async () => { send!.click(); });
expect(onInterrupt).toHaveBeenCalledOnce();
expect(container.querySelector('[data-testid="task-chat-queued-steer-comment-1"]')).toBeNull();
});
describe("automatic steering", () => {
const delay = 5_000;
const fresh = (overrides: Partial<IssueQueuedCommentQueue> = {}): IssueQueuedCommentQueue => {
const at = new Date(Date.now());
return { ...queue, ...overrides, entries: queue.entries.slice(0, 1).map(entry => ({
...entry, comment: { ...entry.comment, createdAt: at, updatedAt: at } })) };
};
const advance = async (ms: number) => { await act(async () => { vi.advanceTimersByTime(ms); await Promise.resolve(); }); };
const countdown = () => container.querySelector('[data-testid="task-chat-queued-auto-steer-comment-1"]');
beforeEach(() => { vi.useFakeTimers({ now: new Date("2026-11-07T12:00:00Z") }); });
afterEach(() => { vi.useRealTimers(); });
it("shows a countdown with Edit and Cancel, then steers into the live turn", async () => {
const props = render({ queue: fresh(), autoSteerDelayMs: delay });
expect(countdown()?.textContent).toContain("Sending in 5s");
expect(container.querySelector('[data-testid="task-chat-queued-steer-comment-1"]')).toBeNull();
await advance(2_100);
expect(countdown()?.textContent).toContain("Sending in 3s");
expect(props.onSteer).not.toHaveBeenCalled();
await advance(3_000);
expect(props.onSteer).toHaveBeenCalledOnce();
expect(props.onSteer).toHaveBeenCalledWith("comment-1", "rev-1");
});
it("gives a saved edit a full window while another row's countdown keeps the clock running", async () => {
const start = Date.now();
const twoRows: IssueQueuedCommentQueue = { ...queue, entries: queue.entries.slice(0, 2).map((entry, index) => {
const at = new Date(start + index * 4_000);
return { ...entry, comment: { ...entry.comment, createdAt: at, updatedAt: at } };
}) };
// comment-1 counts down first; the person opens it for editing at 1 s.
const props = render({ queue: twoRows, autoSteerDelayMs: delay });
await advance(1_000);
await act(async () => { render({ ...props, editingCommentId: "comment-1" }); });
// comment-2 counts down to start + 9 s and keeps the clock ticking past
// comment-1's old deadline.
await advance(5_000);
expect(props.onSteer).not.toHaveBeenCalled();
const saved = { ...twoRows, revision: "rev-2", entries: twoRows.entries.map((entry, index) => index === 0
? { ...entry, comment: { ...entry.comment, body: "Edited", updatedAt: new Date(Date.now()) } } : entry) };
await act(async () => { render({ ...props, queue: saved, editingCommentId: null }); });
await advance(500);
expect(props.onSteer).not.toHaveBeenCalledWith("comment-1", expect.anything());
expect(countdown()?.textContent).toContain("Sending in");
await advance(5_000);
expect(props.onSteer).toHaveBeenCalledWith("comment-1", "rev-2");
});
it("keeps a cancelled message in the queue with its explicit Steer button", async () => {
const props = render({ queue: fresh(), autoSteerDelayMs: delay });
await act(async () => {
container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-auto-steer-cancel-comment-1"]')?.click();
await Promise.resolve();
});
await advance(10_000);
expect(props.onSteer).not.toHaveBeenCalled();
expect(countdown()).toBeNull();
expect(container.querySelector('[data-testid="task-chat-queued-steer-comment-1"]')).not.toBeNull();
});
it("waits while the message is being edited and restarts from the saved revision", async () => {
const queued = fresh();
const props = render({ queue: queued, autoSteerDelayMs: delay });
await act(async () => {
container.querySelector<HTMLButtonElement>('[data-testid="task-chat-queued-auto-steer-edit-comment-1"]')?.click();
await Promise.resolve();
});
expect(props.onEdit).toHaveBeenCalledWith("comment-1");
render({ ...props, editingCommentId: "comment-1" });
await advance(10_000);
expect(props.onSteer).not.toHaveBeenCalled();
// The save changes the comment; its countdown starts again from that change.
const saved = { ...queued, revision: "rev-2", entries: queued.entries.map(entry => ({
...entry, comment: { ...entry.comment, body: "Edited", updatedAt: new Date(Date.now()) } })) };
await act(async () => { render({ ...props, queue: saved, editingCommentId: null }); });
expect(countdown()?.textContent).toContain("Sending in 5s");
await advance(5_100);
expect(props.onSteer).toHaveBeenCalledWith("comment-1", "rev-2");
});
it("keeps the ordinary queue while steering is unavailable or unsupported", async () => {
for (const steeringDisposition of ["temporarily_unavailable", "unsupported"] as const) {
const props = render({ queue: fresh({ steeringDisposition }), autoSteerDelayMs: delay });
expect(countdown()).toBeNull();
await advance(10_000);
expect(props.onSteer).not.toHaveBeenCalled();
}
});
it("tries each message revision once, then leaves it queued after a failure", async () => {
const props = render({ queue: fresh(), autoSteerDelayMs: delay, onSteer: vi.fn().mockRejectedValue(new Error("rejected")) });
await advance(5_100);
await advance(10_000);
expect(props.onSteer).toHaveBeenCalledOnce();
expect(container.textContent).toContain("Couldn’t steer. Message is still queued.");
expect(countdown()).toBeNull();
});
it("never sends someone else’s message or a saved card response automatically", async () => {
const notMine = fresh();
notMine.entries = notMine.entries.map(entry => ({ ...entry, canEdit: false }));
const card = fresh();
card.entries = card.entries.map(entry => ({ ...entry, source: { kind: "interaction", summary: "Approved" } as never }));
for (const candidate of [notMine, card]) {
const props = render({ queue: candidate, autoSteerDelayMs: delay });
await advance(10_000);
expect(props.onSteer).not.toHaveBeenCalled();
}
});
it("stays off unless the caller enables it", async () => {
const props = render({ queue: fresh() });
expect(countdown()).toBeNull();
await advance(10_000);
expect(props.onSteer).not.toHaveBeenCalled();
});
});
});