Files
PaperClipAI/packages/shared/src/humanize-connection.test.ts
T
DottaandPaperclip 1de0a3bb1e feat(mcp) [split 2/8]: add governed access contracts (#9557)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - Governed MCP access spans contracts, runtime enforcement, adapters,
UI surfaces, and operator verification
> - The parity reference PR #9534 is too large for effective automated
or human review
> - The feature therefore needs a linear stack whose individual diffs
stay below the 100-file review limit
> - This pull request is split 2/8 and focuses on database schema and
shared governance contracts
> - The benefit is a standalone, testable review boundary while
preserving byte-for-byte parity at the top of the stack

## Linked Issues or Issue Description

- Related parity reference: #9534
- Problem: The governed access model needs additive persistence and
synchronized shared types before server enforcement can compile.
- Proposed solution: Adds migrations 0148–0169, tool-access and Smoke
Lab schema, shared types/validators/gallery helpers, and the minimal
compile-required contract consumers identified by boundary testing.
- Alternatives considered: keeping #9534 as one 403-file review, or
rewriting the feature to manufacture seams; both were rejected in favor
of path extraction plus compile-driven boundary moves.
- Roadmap alignment: this advances the existing governed MCP/tool-access
work already represented by #9534; it does not introduce a separate
roadmap initiative.
- Stack position: base branch is `pap10341-split/01-demo-servers`.
- Merge policy: merge bottom-up, in order, only after the complete
eight-PR stack has been reviewed and the top-of-stack parity gate
remains empty.
- Requested review: QA for migrations/validators; Greptile on every PR.

## What Changed

- Adds migrations 0148–0169, tool-access and Smoke Lab schema, shared
types/validators/gallery helpers, and the minimal compile-required
contract consumers identified by boundary testing.
- Keeps this PR below 100 changed files and independently typecheckable.
- Preserves the final tree from #9534 when combined with the other seven
stack levels.

## Verification

- `pnpm typecheck` — passed, including migration numbering and safety
checks
- `pnpm --filter @paperclipai/db test` — passed
- `pnpm --filter @paperclipai/shared test` — passed

## Risks

- Migration or contract mistakes could affect every upper layer; all
migrations are additive/idempotent and compile consumers are included in
this boundary.
- Stack risk: merging out of order can expose incomplete layers;
mitigate by following the documented bottom-up merge policy.
- Parity risk: later edits to an intermediate branch can drift from
#9534; mitigate by re-running the empty top-of-stack diff before merge.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

- OpenAI Codex, exact model ID `gpt-5.4`; runtime-managed context
window; medium reasoning with repository, shell, Git, GitHub CLI, and
code-execution tools enabled.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] Internal references are omitted except the execution-plan link
explicitly required for this coordinated split stack
- [x] My branch name describes the change and contains no internal
Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge


## Stack Coordination

- Internal execution plan:
[PAP-13874](/PAP/issues/PAP-13874#document-plan)
- Parity reference: #9534
- Stack: #9556 → #9557 → #9558 → #9559 → #9560 → #9561 → #9562 → #9563
- Merge bottom-up only after full-stack review and an empty parity diff
at #9563.

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-07-14 12:57:20 -05:00

63 lines
2.9 KiB
TypeScript

import { describe, expect, it } from "vitest";
import {
connectionDisplaySecondaryHint,
humanizeConnectionDisplayName,
} from "./humanize-connection.js";
describe("humanizeConnectionDisplayName", () => {
it("hides raw IPs / hosts behind a generic label", () => {
expect(humanizeConnectionDisplayName("127.0.0.1")).toBe("Custom app");
expect(humanizeConnectionDisplayName("127.0.0.1:8931")).toBe("Custom app");
expect(humanizeConnectionDisplayName("localhost")).toBe("Custom app");
expect(humanizeConnectionDisplayName("example.com:8080")).toBe("Custom app");
expect(humanizeConnectionDisplayName("https://mcp.example.com/sse")).toBe("Custom app");
});
it("drops the `Plugin:` prefix and title-cases the package leaf", () => {
expect(humanizeConnectionDisplayName("Plugin: paperclipai.plugin-briefs")).toBe("Briefs");
expect(humanizeConnectionDisplayName("Plugin: acme.plugin-weekly-report")).toBe(
"Weekly Report",
);
});
it("turns `vendor:tool` ids into Title Case With Spaces", () => {
expect(humanizeConnectionDisplayName("mcp-remote-fixture:update_note")).toBe("Update Note");
expect(humanizeConnectionDisplayName("github:create_issue")).toBe("Create Issue");
});
it("title-cases a bare snake/kebab identifier", () => {
expect(humanizeConnectionDisplayName("update_note")).toBe("Update Note");
expect(humanizeConnectionDisplayName("send-email")).toBe("Send Email");
});
it("passes through normal, already-human app names", () => {
expect(humanizeConnectionDisplayName("Zapier")).toBe("Zapier");
expect(humanizeConnectionDisplayName("Notion")).toBe("Notion");
expect(humanizeConnectionDisplayName("Google Drive")).toBe("Google Drive");
});
it("prefers an explicit title when provided", () => {
expect(
humanizeConnectionDisplayName("mcp-remote-fixture:update_note", { title: "Update note" }),
).toBe("Update note");
// Blank/whitespace titles fall back to derivation.
expect(humanizeConnectionDisplayName("update_note", { title: " " })).toBe("Update Note");
});
it("accepts a connection-like object and handles empty input", () => {
expect(humanizeConnectionDisplayName({ name: "Plugin: acme.plugin-briefs" })).toBe("Briefs");
expect(humanizeConnectionDisplayName("")).toBe("Custom app");
expect(humanizeConnectionDisplayName(null)).toBe("Custom app");
});
});
describe("connectionDisplaySecondaryHint", () => {
it("surfaces `hosted at …` only for network addresses", () => {
expect(connectionDisplaySecondaryHint("127.0.0.1")).toBe("hosted at 127.0.0.1");
expect(connectionDisplaySecondaryHint("127.0.0.1:8931")).toBe("hosted at 127.0.0.1:8931");
expect(connectionDisplaySecondaryHint({ name: "Zapier" })).toBeNull();
expect(connectionDisplaySecondaryHint("Plugin: acme.plugin-briefs")).toBeNull();
expect(connectionDisplaySecondaryHint("")).toBeNull();
});
});