mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-14 08:26:46 +02:00
## Thinking Path > - Paperclip lets operators manage agent work through tasks. > - Task chat keeps responses and run history together. > - A live update rendered every historical bubble and hidden tool row again. > - New image callbacks also forced unchanged markdown to parse again. > - Long conversations saturated the browser main thread. > - This change reuses unchanged history and mounts folded tools on first inspection. > - Operators can read and reply while work continues. ## Linked Issues or Issue Description **What happened?** Chat-style tasks with substantial scrollback became almost unusable. A deterministic browser reproduction with 200 long responses and 4,000 tools consumed 97.8% of the main thread during live updates. It delivered only 8 updates during the sample. **Expected behavior** The task should remain responsive during streaming. Historical markdown and unopened run details should not repeat expensive render work. **Steps to reproduce** 1. Install dependencies with `pnpm install`. 2. Run `pnpm exec playwright test --config tests/perf/task-chat/playwright.config.ts`. 3. Compare the attached performance JSON. The new test fails against the original rendering code. **Paperclip version or commit** Reproduced at `a05b828bc`. The branch is rebased on current master. **Deployment mode** Local Chromium and Vite with deterministic fixtures. No database or agent credentials are required. Related work: #10463 reduces the issue-page bundle. This change addresses repeated rendering after the page loads. No duplicate scrollback fix was found. ## What Changed - Keep the bubble image callback stable so unchanged markdown can skip parsing. - Memoize the settled history separately from the header and streaming tail. Keep the brief renderer and default attachment array stable. - Mount folded tool history on first expansion. Keep it mounted afterward to preserve child state and closing motion. Runtime request receipts remain visible. - Add deterministic rendering tests to the normal Vitest suite and an opt-in Chromium regression fixture. - Document the reproduction, commands, scope, and local measurements. ## Verification - Browser reproduction: 97.8% main-thread utilization before; 11.6% after for tail-only updates; 31.5% after when projection recreates history objects. Both fixed cases delivered 32 updates. - Browser checks pass for scroll-position retention, typing, return to latest, tool inspection, and retained expansion state. - Focused component suite: 155 tests passed. Post-rebase thread/performance rerun: 101 tests passed. - Recursive typecheck, build, Storybook build, and token gates passed. UI typecheck passed after the final edits. - Local UI/CLI lane: 5,910 tests passed; ten files hit worker-start timeouts, then all ten passed with two workers (20 tests). Shared/adapter lane: 3,128 tests passed. - Full local `pnpm test:run` was attempted and is **not green**: its server lane recorded 10,517 passes and 11 failures plus fixture/setup errors. Queue (31 tests), Cursor/Git-load (9 tests), and missing-binary failures cleared on isolated reruns / building the runner test binaries. Two native suites still cannot initialize embedded PostgreSQL on this host. - The remaining native-session recovery assertion was reproduced in a clean worktree at base `a20ecce40` (1 failed, 67 passed across the native/queue suites). It expects a settled-session error but receives a semantic-tool-input digest error. No server or runner files changed in this PR. - All substantive CI jobs have passed, including build, typecheck, all server/workspace test shards, all three e2e shards, and the canary dry run. The unchanged Slack ordering test exhausted its one-second wait on the first run; its shard passed on rerun. Final aggregate verification passed: **31 passing checks**, no failures or pending checks; two optional Storybook deployment/visual checks were skipped. Greptile is **5/5**, with no unresolved review threads. - The supplemental local serialized route run was stopped after CI passed all five serialized shards; it had reported no failures. - The browser fixture uses the real chat rendering components with a plain textarea. It does not test the full composer or server transport. Timing results are local samples; deterministic render-count tests provide normal CI coverage. ## Risks - Closed tool content becomes available to DOM search only after first expansion. Visible run summaries and runtime request receipts remain available immediately. - Opened run history remains mounted to preserve child state. The first full markdown render still scales with conversation size. - Memo dependencies must stay current when adding render inputs. Tests check content edits and replacement gallery callbacks. - No API, database, or permission changes. ## Model Used OpenAI GPT-6 (Codex). Exact serving variant and context-window size are not exposed in this session. Used reasoning, repository tools, code execution, and browser testing. No sub-agents were used. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [ ] I have run tests locally and they pass — targeted/UI/workspace checks pass; the full local server suite has the baseline/host failures documented above - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
435 lines
16 KiB
TypeScript
435 lines
16 KiB
TypeScript
import { useCallback, useContext, useState, type ReactNode } from "react";
|
|
import type { IssueAttachment } from "@paperclipai/shared";
|
|
import { IssueGalleryContext } from "@/context/IssueGalleryContext";
|
|
import { cn } from "@/lib/utils";
|
|
import { useStreamlinedTaskChatPresentation } from "./presentation-mode";
|
|
import { MarkdownBody } from "@/components/MarkdownBody";
|
|
import {
|
|
ImageGalleryModal,
|
|
type GalleryMediaItem,
|
|
} from "@/components/ImageGalleryModal";
|
|
import { Avatar, AvatarFallback } from "@/components/ui/avatar";
|
|
import { AgentIcon } from "@/components/AgentIconPicker";
|
|
import { CommentAttributionChip } from "@/components/CommentAttributionChip";
|
|
import {
|
|
Attachment,
|
|
AttachmentContent,
|
|
AttachmentDescription,
|
|
AttachmentGroup,
|
|
AttachmentMedia,
|
|
AttachmentTitle,
|
|
AttachmentTrigger,
|
|
} from "@/components/ui/attachment";
|
|
import {
|
|
extractAttachmentRefs,
|
|
extractImageRefs,
|
|
fileKindForAttachment,
|
|
formatFileSize,
|
|
hydrateAttachmentRefs,
|
|
isImageAttachment,
|
|
stripStandaloneImageEmbeds,
|
|
type AttachmentRef,
|
|
} from "./task-chat-attachments";
|
|
import { TaskChatSystemNotice } from "./TaskChatSystemNotice";
|
|
import type { TaskChatMessageItem } from "./task-chat-model";
|
|
|
|
interface TaskChatBubbleProps {
|
|
item: TaskChatMessageItem;
|
|
/** Requeues a blocked task after a no-live-execution-path recovery notice. */
|
|
onTryAgainNoLiveExecutionPath?: () => Promise<void> | void;
|
|
tryAgainNoLiveExecutionPathPending?: boolean;
|
|
/** Disable the entrance animation when replacing an already-visible live response. */
|
|
animateEntry?: boolean;
|
|
/** Action shown beside the queued state for an interruptible message. */
|
|
queuedAction?: ReactNode;
|
|
/**
|
|
* The settled run turn rendered on this bubble's footer line (round 9):
|
|
* replaces the plain timestamp with "2:34 PM · ✓ Worked · 38s · 3 tools"
|
|
* (the timestamp leads the summary), expandable to the nested tool history.
|
|
* Supplied by TaskChatThreadView when `item.attachedTurn` is set.
|
|
*/
|
|
attachedTurn?: ReactNode;
|
|
/** New-runner Worked header, rendered above the durable final response. */
|
|
beforeTurn?: ReactNode;
|
|
/** The durable runner turn already owns the shared agent identity row. */
|
|
hideAgentIdentity?: boolean;
|
|
/**
|
|
* copy · 👍 · 👎 controls for an agent bubble's footer line (PAP-413).
|
|
* Rendered here only for a runless reply (leading the bare timestamp); when
|
|
* an attached turn is present it owns these via its `leading` slot instead,
|
|
* so this bubble skips them. Human/system bubbles pass nothing.
|
|
*/
|
|
actions?: ReactNode;
|
|
attachments?: IssueAttachment[];
|
|
}
|
|
|
|
function initialsForName(name: string) {
|
|
const parts = name.trim().split(/\s+/);
|
|
if (parts.length >= 2) {
|
|
return (parts[0][0] + parts[parts.length - 1][0]).toUpperCase();
|
|
}
|
|
return name.slice(0, 2).toUpperCase();
|
|
}
|
|
|
|
export function TaskChatAgentIdentity({
|
|
agentName,
|
|
agentIcon,
|
|
onBehalfOfUserName,
|
|
}: {
|
|
agentName: string;
|
|
agentIcon?: string | null;
|
|
onBehalfOfUserName?: string;
|
|
}) {
|
|
return (
|
|
<span
|
|
className="flex items-center gap-2 px-1"
|
|
data-testid="task-chat-agent-identity"
|
|
>
|
|
<Avatar
|
|
size="sm"
|
|
className="shrink-0"
|
|
data-testid="task-chat-agent-avatar"
|
|
>
|
|
{agentIcon ? (
|
|
<AvatarFallback>
|
|
<AgentIcon icon={agentIcon} className="h-3.5 w-3.5" />
|
|
</AvatarFallback>
|
|
) : (
|
|
<AvatarFallback>{initialsForName(agentName)}</AvatarFallback>
|
|
)}
|
|
</Avatar>
|
|
<span className="text-sm font-semibold text-foreground">{agentName}</span>
|
|
{onBehalfOfUserName ? (
|
|
<CommentAttributionChip
|
|
agentName={agentName}
|
|
userName={onBehalfOfUserName}
|
|
/>
|
|
) : null}
|
|
</span>
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Author-typed message row — the primary legibility signal. Human messages sit
|
|
* right in a solid accent bubble; agent messages sit directly on the page
|
|
* surface with an avatar author header (the agent's assigned icon + name);
|
|
* system notices are centered and recede.
|
|
*/
|
|
function galleryItemForImage(
|
|
src: string,
|
|
name?: string,
|
|
attachment?: ReturnType<typeof hydrateAttachmentRefs>[number],
|
|
): GalleryMediaItem {
|
|
return {
|
|
id: attachment?.id ?? src,
|
|
contentPath: attachment?.openPath ?? src,
|
|
openPath: attachment?.openPath,
|
|
downloadPath: attachment?.downloadPath,
|
|
contentType: attachment?.contentType ?? "",
|
|
originalFilename: name?.trim() ? name : "image",
|
|
};
|
|
}
|
|
|
|
function uniqueAttachmentRefs(refs: AttachmentRef[]): AttachmentRef[] {
|
|
return refs.filter(
|
|
(ref, index) =>
|
|
refs.findIndex(
|
|
(candidate) =>
|
|
(ref.id && candidate.id === ref.id) || candidate.url === ref.url,
|
|
) === index,
|
|
);
|
|
}
|
|
|
|
export function TaskChatBubble({
|
|
item,
|
|
animateEntry = true,
|
|
queuedAction,
|
|
attachedTurn,
|
|
beforeTurn,
|
|
hideAgentIdentity = false,
|
|
actions,
|
|
attachments = [],
|
|
onTryAgainNoLiveExecutionPath,
|
|
tryAgainNoLiveExecutionPathPending,
|
|
}: TaskChatBubbleProps) {
|
|
const streamlined = useStreamlinedTaskChatPresentation();
|
|
// Task attachments share the page gallery; standalone images retain the bubble viewer.
|
|
const openIssueGallery = useContext(IssueGalleryContext);
|
|
const [lightboxSrc, setLightboxSrc] = useState<string | null>(null);
|
|
// Keep MarkdownBody's memo boundary intact when only the live tail changes.
|
|
// A fresh callback here reparses every historical response on every update.
|
|
const openImage = useCallback((src: string) => {
|
|
if (!openIssueGallery?.(src)) setLightboxSrc(src);
|
|
}, [openIssueGallery]);
|
|
if (item.interstitial) {
|
|
// Interstitial updates are ephemeral (PAP-361): while streaming the text
|
|
// lives on the live parent row's line (TaskChatStatusItem.selfTalk), and
|
|
// once finished it renders nowhere — the run log / classic transcript
|
|
// remain the archive. Never rendered as a bubble.
|
|
return null;
|
|
}
|
|
|
|
if (item.author === "system") {
|
|
// Collapsed humanized one-liner, expandable to the full detail (PAP-443).
|
|
return (
|
|
<TaskChatSystemNotice
|
|
item={item}
|
|
onTryAgainNoLiveExecutionPath={onTryAgainNoLiveExecutionPath}
|
|
tryAgainNoLiveExecutionPathPending={tryAgainNoLiveExecutionPathPending}
|
|
/>
|
|
);
|
|
}
|
|
|
|
const isHuman = item.author === "human";
|
|
// Non-image file references ("[name](/api/attachments/…/content)") render as
|
|
// attachment chips under the bubble; link-only lines leave the body text.
|
|
const { refs: linkedRefs, text: bodyWithoutAttachmentLinks } =
|
|
extractAttachmentRefs(item.text);
|
|
const embeddedImageRefs = extractImageRefs(bodyWithoutAttachmentLinks);
|
|
const bodyText = stripStandaloneImageEmbeds(bodyWithoutAttachmentLinks);
|
|
const hydratedLinkedRefs = hydrateAttachmentRefs(linkedRefs, attachments);
|
|
const hydratedEmbeddedRefs = hydrateAttachmentRefs(
|
|
embeddedImageRefs,
|
|
attachments,
|
|
);
|
|
const boundAttachmentRefs: AttachmentRef[] = attachments
|
|
.filter((attachment) => attachment.issueCommentId === item.id)
|
|
.map((attachment) => ({
|
|
id: attachment.id,
|
|
name: attachment.originalFilename?.trim() || "attachment",
|
|
url: attachment.contentPath,
|
|
contentType: attachment.contentType,
|
|
byteSize: attachment.byteSize,
|
|
openPath: attachment.openPath,
|
|
downloadPath: attachment.downloadPath,
|
|
}));
|
|
const imageRefs = uniqueAttachmentRefs([
|
|
...hydratedEmbeddedRefs,
|
|
...hydratedLinkedRefs.filter(isImageAttachment),
|
|
...boundAttachmentRefs.filter(isImageAttachment),
|
|
]);
|
|
const attachmentRefs = uniqueAttachmentRefs([
|
|
...hydratedLinkedRefs.filter((ref) => !isImageAttachment(ref)),
|
|
...boundAttachmentRefs.filter((ref) => !isImageAttachment(ref)),
|
|
]);
|
|
const galleryItems: GalleryMediaItem[] =
|
|
lightboxSrc !== null && !imageRefs.some((ref) => ref.url === lightboxSrc)
|
|
? // A clicked image the extractor missed (e.g. inline HTML) still gets a
|
|
// single-item lightbox rather than nothing.
|
|
[galleryItemForImage(lightboxSrc)]
|
|
: imageRefs.map((ref) => galleryItemForImage(ref.url, ref.name, ref));
|
|
const lightboxIndex =
|
|
lightboxSrc === null
|
|
? -1
|
|
: Math.max(0, imageRefs.findIndex((ref) => ref.url === lightboxSrc));
|
|
return (
|
|
<div
|
|
className={cn(
|
|
"flex w-full flex-col gap-1",
|
|
animateEntry && "tc-enter-bubble",
|
|
isHuman ? "items-end" : "items-start",
|
|
)}
|
|
>
|
|
{beforeTurn ? <div className="w-full pb-1">{beforeTurn}</div> : null}
|
|
{!isHuman && item.authorName && !hideAgentIdentity ? (
|
|
<TaskChatAgentIdentity
|
|
agentName={item.authorName}
|
|
agentIcon={item.agentIcon}
|
|
onBehalfOfUserName={item.onBehalfOfUserName}
|
|
/>
|
|
) : null}
|
|
{bodyText.length > 0 ? (
|
|
<div
|
|
// Stable hook so the TaskChatLab bubble-treatment explorations
|
|
// (PAP-501) can scope background/border overrides to the agent
|
|
// bubble body without touching the live thread.
|
|
data-testid={
|
|
isHuman ? "task-chat-human-bubble" : "task-chat-agent-bubble"
|
|
}
|
|
className={cn(
|
|
"break-words py-2 text-sm",
|
|
isHuman
|
|
? "max-w-(--pct-85) rounded-2xl rounded-br-sm bg-(--liveness-blue) px-3.5 text-white"
|
|
: "w-full bg-transparent px-1 text-foreground",
|
|
)}
|
|
>
|
|
<MarkdownBody
|
|
// The human bubble sits on the solid --liveness-blue accent, so the
|
|
// prose body text must follow the bubble's `text-white` rather than
|
|
// the default light-mode prose color (which reads as black on blue).
|
|
// `paperclip-markdown-on-accent` flips prose tokens to currentColor
|
|
// (== inherited white) in both themes; dark mode was already correct
|
|
// only because `prose-invert` happened to lighten the text.
|
|
className={isHuman ? "paperclip-markdown-on-accent" : undefined}
|
|
softBreaks
|
|
linkIssueReferences
|
|
onImageClick={openImage}
|
|
>
|
|
{bodyText}
|
|
</MarkdownBody>
|
|
</div>
|
|
) : null}
|
|
{imageRefs.length > 0 ? (
|
|
<div
|
|
className="flex max-w-(--pct-85) flex-col gap-2"
|
|
data-testid="task-chat-bubble-media"
|
|
>
|
|
<span className="text-xs text-muted-foreground">
|
|
Images · {imageRefs.length}
|
|
</span>
|
|
<div className="grid grid-cols-4 gap-2">
|
|
{imageRefs
|
|
.slice(0, imageRefs.length > 4 ? 3 : 4)
|
|
.map((ref, index) => (
|
|
<button
|
|
key={ref.url}
|
|
type="button"
|
|
className="group aspect-video min-w-0 overflow-hidden rounded-md bg-muted outline-none focus-visible:ring-2 focus-visible:ring-ring"
|
|
aria-label={`Open ${ref.name || `image ${index + 1}`}`}
|
|
onClick={() => openImage(ref.url)}
|
|
>
|
|
<img
|
|
src={ref.openPath ?? ref.url}
|
|
alt={ref.name}
|
|
loading="lazy"
|
|
className="h-full w-full object-cover transition-transform group-hover:scale-(--s-1_02)"
|
|
/>
|
|
</button>
|
|
))}
|
|
{imageRefs.length > 4 ? (
|
|
<button
|
|
type="button"
|
|
className="aspect-video min-w-0 rounded-md bg-muted text-sm font-semibold text-foreground outline-none focus-visible:ring-2 focus-visible:ring-ring"
|
|
aria-label={`Open ${imageRefs.length - 3} more screenshots`}
|
|
onClick={() => openImage(imageRefs[3].url)}
|
|
>
|
|
+{imageRefs.length - 3}
|
|
</button>
|
|
) : null}
|
|
</div>
|
|
<span className="truncate text-xs text-muted-foreground">
|
|
{imageRefs.map((ref) => ref.name || "image").join(" · ")}
|
|
</span>
|
|
</div>
|
|
) : null}
|
|
{attachmentRefs.length > 0 ? (
|
|
<div className="flex max-w-(--pct-85) flex-col gap-2">
|
|
<span className="text-xs text-muted-foreground">
|
|
Files · {attachmentRefs.length}
|
|
</span>
|
|
<AttachmentGroup data-testid="task-chat-bubble-attachments">
|
|
{attachmentRefs.map((ref) => {
|
|
const kind = fileKindForAttachment(ref);
|
|
const KindIcon = kind.icon;
|
|
const size = formatFileSize(ref.byteSize);
|
|
return (
|
|
<Attachment key={ref.url} size="sm">
|
|
<AttachmentMedia>
|
|
<KindIcon aria-hidden />
|
|
</AttachmentMedia>
|
|
<AttachmentContent>
|
|
<AttachmentTitle className="max-w-48">
|
|
{ref.name}
|
|
</AttachmentTitle>
|
|
<AttachmentDescription className="max-w-48">
|
|
{size ? `${kind.label} · ${size}` : kind.label}
|
|
</AttachmentDescription>
|
|
</AttachmentContent>
|
|
<AttachmentTrigger
|
|
aria-label={`Open ${ref.name}`}
|
|
render={
|
|
<a
|
|
href={ref.openPath ?? ref.url}
|
|
target="_blank"
|
|
rel="noreferrer"
|
|
/>
|
|
}
|
|
/>
|
|
</Attachment>
|
|
);
|
|
})}
|
|
</AttachmentGroup>
|
|
</div>
|
|
) : null}
|
|
{!isHuman && item.verificationCaveats?.length ? (
|
|
<div
|
|
className="mx-1 w-(--sz-calc-7) rounded-md border border-amber-500/25 bg-amber-500/5 px-3 py-2 text-xs"
|
|
data-testid="task-chat-verification-caveats"
|
|
>
|
|
<p className="font-medium text-amber-800 dark:text-amber-200">
|
|
Verification caveat
|
|
</p>
|
|
<ul className="mt-1 space-y-1 text-muted-foreground">
|
|
{item.verificationCaveats.map((caveat, index) => (
|
|
<li key={`${caveat.commandOrCheck}:${index}`}>
|
|
<span className="font-mono text-foreground">
|
|
{caveat.commandOrCheck}
|
|
</span>
|
|
{caveat.reasonCode
|
|
? ` · ${caveat.reasonCode.replaceAll("_", " ")}`
|
|
: ""}
|
|
{caveat.detail ? (
|
|
<span className="block">{caveat.detail}</span>
|
|
) : null}
|
|
</li>
|
|
))}
|
|
</ul>
|
|
</div>
|
|
) : null}
|
|
{item.optimistic ? (
|
|
<span className="flex items-center gap-1 px-1 text-(length:--text-micro) text-muted-foreground">
|
|
<span>{item.optimistic === "queued" ? "Queued" : "Sending…"}</span>
|
|
{item.optimistic === "queued" ? queuedAction : null}
|
|
</span>
|
|
) : attachedTurn ? (
|
|
// The settled turn takes over the footer line: timestamp + "✓ Worked"
|
|
// summary, always visible; expanding stretches beneath the bubble. The
|
|
// copy/👍/👎 actions (PAP-413) ride the turn's summary row via its
|
|
// `leading` slot — not this wrapper — so they stay anchored to the
|
|
// summary line when the tool history expands beneath it.
|
|
<div
|
|
className="self-stretch"
|
|
data-testid="task-chat-bubble-attached-turn"
|
|
>
|
|
{attachedTurn}
|
|
</div>
|
|
) : actions ? (
|
|
streamlined ? (
|
|
<div className="flex w-full items-center justify-between gap-2 px-1">
|
|
{item.timestamp ? (
|
|
<span className="text-(length:--text-micro) text-muted-foreground">
|
|
{item.timestamp}
|
|
</span>
|
|
) : null}
|
|
{actions}
|
|
</div>
|
|
) : (
|
|
<div className="flex items-center gap-1">
|
|
{actions}
|
|
{item.timestamp ? (
|
|
<span className="px-1 text-(length:--text-micro) text-muted-foreground">
|
|
{item.timestamp}
|
|
</span>
|
|
) : null}
|
|
</div>
|
|
)
|
|
) : item.timestamp ? (
|
|
// Timestamps are always visible (round 9) — no longer hover-revealed.
|
|
<span className="px-1 text-(length:--text-micro) text-muted-foreground">
|
|
{item.timestamp}
|
|
</span>
|
|
) : null}
|
|
{lightboxSrc !== null && lightboxIndex >= 0 ? (
|
|
<ImageGalleryModal
|
|
items={galleryItems}
|
|
initialIndex={lightboxIndex}
|
|
open
|
|
onOpenChange={(open) => {
|
|
if (!open) setLightboxSrc(null);
|
|
}}
|
|
/>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|