mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 00:05:49 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The Runner gives agents tools to change company resources. > - Users need agents to save reusable skills during a task. > - A saved skill needs a visible result that users can inspect and edit. > - This pull request adds `create_skill` and a task feed card linked to Skill Studio. > - Users can open the saved skill from the task and edit the same resource. ## Linked Issues or Issue Description **Subsystem affected** Runner tools, company skill storage, task feed, and Skill Studio. **Problem or motivation** The Runner has no dedicated tool to create a company skill. A user cannot follow a creation result from the task feed to the saved skill. **Proposed solution** Add a company-scoped `create_skill` tool. Save the skill with the existing company policy. Add one creation card to the task. Open a named sidebar tab from that card. Let the user open the same skill in Skill Studio. **Alternatives considered** An agent can write a local file, but that file is not a company skill. A second document copy in the task would become stale after a Studio edit. The sidebar therefore reads the saved skill directly. **Roadmap alignment** This extends the shipped Skills Manager, Skill Studio, and Skills Store milestone. The maintainer requested and approved this scope. Search found no duplicate `create_skill` PR or issue. Related UI validation work: #8715. This PR does not change that validation display. ## What Changed - Add the real Runner tool, its contract, and its mock implementation. - Validate the complete SKILL.md and derive company, task, agent, and run identity from authentication. - Apply the existing company skill policy. Do not assign the skill to an agent. - Make keyed retries return one skill and one creation event. Reject conflicting retries. - Make concurrent file creation safe. Never replace an existing published skill during creation. - Add a creation card, a named sidebar tab, and an Open in Skill Studio action. - Show saved Studio edits when the user returns to the task. - Add storage, policy, mode, retry, UI, and Product E2E tests. Document the tool. - Fix deleted-name reuse, onboarding panel persistence, immediate feed refresh, and mock validation parity from review. - Serialize Studio file edits and renames with skill deletion and recreation. Reject stale editor requests before they can change a replacement skill. - Generate the standalone mock parser and validator from the production contract. Use portable UUIDs so the browser scenario bundle builds. ## Verification - All latest-head PR checks pass on `145dd76a5`, including all server shards, browser E2E, Runner verification, build, typecheck, and release dry run. Greptile: 5/5 with no open findings. An interrupted CI runner was retried successfully. - `pnpm -r typecheck`: passed. - `pnpm build`: passed. - `pnpm check:token-gates`: passed. - Review regressions: 73 storage tests, 6 real API tests, 63 UI tests, and 61 semantic runtime tests passed. Parser synchronization passed. - CI exposed existing fire-and-forget Sentry test races. Reproduced the resumption race locally, then synchronized the related sweep and finalizer assertions on the actual report; all 27 tests across the three affected files pass. - Runner scenario browser build and strict content-security-policy check: passed. - Runner suite: 2,012 tests passed; 10 skipped. - `pnpm test:run`: the general-server batch had 12,416 passes and two failures. The old tool-count assertion was fixed; all 16 authority tests then passed. The chat webhook test had a socket error; it passed four isolated reruns. - Both workspace test groups passed. The isolated route suites completed. Two socket failures in the initial route batches passed on individual reruns; all remaining 61 files passed. - Product E2E `create-skill-studio`: passed with local Codex and local ACPX Claude. - Manual browser test: submit a task, observe the real tool call and creation card, open the sidebar, edit in Studio, save, and return. The task reached Done. The saved second revision and sidebar tab survived a server restart. - The new companion headless Runner Eval passed. Companion coverage PR: https://github.com/paperclipai/paperclip-evals/pull/23. Daytona was not run because no immutable runner image was configured. ## Risks - Database writes and local file writes cannot share one transaction. Recovery accepts only an exact file-for-file retry after a database rollback. Conflicting files remain untouched. - The sidebar displays the current skill. The feed card remains the historical creation receipt. - No database migration, dependency, or workflow change is included. - Remote Daytona behavior still needs a run with a configured immutable image. ## Model Used OpenAI GPT-6 (`gpt-6-astra`) handled design, integration, review, and browser verification. OpenAI `gpt-5.6-luna` assisted with bounded implementation and eval work. Both used code execution and tool access. The host did not expose the context window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
82 lines
3.3 KiB
TypeScript
82 lines
3.3 KiB
TypeScript
import { useQuery } from "@tanstack/react-query";
|
|
import { ExternalLink, FileText, Loader2, Wrench } from "lucide-react";
|
|
import { companySkillsApi } from "@/api/companySkills";
|
|
import { ApiError } from "@/api/client";
|
|
import { MarkdownBody } from "@/components/MarkdownBody";
|
|
import { Button } from "@/components/ui/button";
|
|
import { queryKeys } from "@/lib/queryKeys";
|
|
import { useNavigate } from "@/lib/router";
|
|
import { parseFrontmatterMarkdown } from "@paperclipai/shared";
|
|
|
|
export function TaskSkillPanel({ companyId, skillId }: { companyId: string; skillId: string }) {
|
|
const navigate = useNavigate();
|
|
const query = useQuery({
|
|
queryKey: queryKeys.companySkills.detail(companyId, skillId),
|
|
queryFn: () => companySkillsApi.detail(companyId, skillId),
|
|
retry: false,
|
|
refetchOnWindowFocus: true,
|
|
refetchOnMount: "always",
|
|
});
|
|
if (query.isLoading) {
|
|
return (
|
|
<div className="flex items-center gap-2 py-8 text-sm text-muted-foreground" role="status">
|
|
<Loader2 className="size-4 animate-spin" aria-hidden />
|
|
Loading skill…
|
|
</div>
|
|
);
|
|
}
|
|
if (query.isError) {
|
|
const status = query.error instanceof ApiError ? query.error.status : null;
|
|
if (status === 404) {
|
|
return <div className="py-8 text-sm text-muted-foreground" role="status">Skill no longer available.</div>;
|
|
}
|
|
if (status === 403) {
|
|
return <div className="py-8 text-sm text-muted-foreground" role="alert">You do not have access to this skill.</div>;
|
|
}
|
|
return (
|
|
<div className="space-y-3 py-8 text-sm text-muted-foreground" role="alert">
|
|
<p>The skill could not be loaded.</p>
|
|
<Button variant="outline" size="sm" onClick={() => void query.refetch()} disabled={query.isFetching}>
|
|
{query.isFetching ? "Retrying…" : "Retry"}
|
|
</Button>
|
|
</div>
|
|
);
|
|
}
|
|
if (!query.data) {
|
|
return <div className="py-8 text-sm text-muted-foreground" role="status">Skill no longer available.</div>;
|
|
}
|
|
const skill = query.data;
|
|
const previewMarkdown = parseFrontmatterMarkdown(skill.markdown).body;
|
|
return (
|
|
<article className="space-y-4">
|
|
<header className="space-y-2">
|
|
<div className="flex items-start justify-between gap-3">
|
|
<div className="flex items-center gap-2">
|
|
<Wrench className="size-4 text-muted-foreground" aria-hidden />
|
|
<h2 className="text-lg font-semibold">{skill.name}</h2>
|
|
</div>
|
|
<Button
|
|
variant="outline"
|
|
size="sm"
|
|
onClick={() => navigate(`/skills/studio/${encodeURIComponent(skill.id)}`)}
|
|
>
|
|
<ExternalLink className="mr-1.5 size-3.5" aria-hidden />
|
|
Open in Skill Studio
|
|
</Button>
|
|
</div>
|
|
<p className="text-xs text-muted-foreground">
|
|
{skill.slug} · {skill.currentVersion ? `Revision ${skill.currentVersion.revisionNumber}` : "Current version"}
|
|
</p>
|
|
</header>
|
|
{skill.description ? <p className="text-sm text-muted-foreground">{skill.description}</p> : null}
|
|
<section className="space-y-2">
|
|
<h3 className="flex items-center gap-2 text-xs font-medium text-muted-foreground">
|
|
<FileText className="size-3.5" aria-hidden />
|
|
Skill instructions
|
|
</h3>
|
|
<MarkdownBody>{previewMarkdown || "Skill instructions are empty."}</MarkdownBody>
|
|
</section>
|
|
</article>
|
|
);
|
|
}
|