mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-06 10:48:12 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Core publishes standard images and source verification for downstream services. > - Managed services can now compose private images from the signed standard image. > - Core still builds a second public cloud image on every master push and release. > - That duplicate producer consumes build capacity and retains an obsolete readiness contract. > - This pull request retires recurring cloud publication while preserving the standard producer and rollback artifacts. ## Linked Issues or Issue Description Refs #13797 and #13789. Related: #12856 changes image dependency packaging; it does not retire this producer. **What existing behavior does this improve?** Core's recurring Docker publication and Cloud readiness workflow. **Current behavior** Master pushes call the legacy cloud publisher from Cloud readiness. Release tags and manual Docker runs call it too. Canary promotion also requires the legacy image. **Proposed behavior** Publish standard Core images and retain `Cloud source verified v1`. Let downstream services build their managed image. Keep explicit commit previews and existing images available. ## What Changed - Remove `docker-cloud.yml`, its master and release callers, and its unused cache selector. - Remove the legacy image/migrator wait and `Cloud deployable v1` job. Keep the full source verification workflow and exact source-proof name. - Make canary promotion inspect and promote the standard image only. - Preserve signed standard-image publication, direct migrator publication, and explicit `release.yml` previews. The preview path still uses the Dockerfile `cloud` target. - Update workflow, preview, build-stamp, and packaging tests. Exercise the promotion shell with mocked registry commands, including missing-image and missing-tag cases. - Document frozen legacy aliases, consumer requirements, preview compatibility, and rollback retention. ## Verification - All 377 workflow tests pass: `node --test .github/scripts/tests/*.test.mjs`. - All 129 release-registry tests pass: `pnpm test:release-registry`. - Focused source-proof, standard-image, preview, and workflow tests pass: 256 tests. - Focused image packaging/build-stamp tests pass: 16 tests. - Actionlint passes on all three changed workflow files. `git diff --check` passes. - Full local `pnpm build` and `pnpm -r typecheck` pass. - The policy follow-up updates an old assertion that required the removed readiness job. All 37 source-proof/release-workflow tests pass locally. - Full local `pnpm test:run` did not complete successfully while the Mac ran out of disk space. No full-suite pass is claimed. Removed 1.2 GiB of generated Cargo output from this isolated worktree with `cargo clean`. GitHub CI passed on the final head: 52 successful checks and 2 optional skips. - Fresh Greptile review for `4f5fe1951f0bd7f7739cf6655d395ff78f1ed944`: **5/5**, successful current-head check, zero review threads. - September 23 refresh: the unchanged PR head merges cleanly with current master `db8f8fe5b73a2697684a30261b0d306a9c631aba`. In an isolated temporary worktree, all 377 workflow tests and 29 release/preview tests pass on the combined tree. `git diff --cached --check` passes. - Refreshed Actionlint workflow validation passes with ShellCheck disabled. Full Actionlint reports the same 10 existing ShellCheck diagnostics as master, with no added diagnostics. No source changes or new PR commits were needed. - The full local build/typecheck and current-head Linux CI results above remain the verification for the unchanged PR head. They were not rerun for this metadata-only refresh. No image publication or tenant deployment was initiated for this refresh. ## Risks **Deployment prerequisite satisfied (September 23):** The combined cleanup release is deployed to staging and production, and production Support is verified. Active managed-fleet automation uses standard-image composition. Explicit immutable previews remain supported by the retained preview publisher. This PR is ready for maintainer review; keep auto-merge disabled and wait for explicit merge authorization. - A consumer still selecting `Cloud deployable v1` will stop advancing at the last legacy-ready commit. Confirm active automatic consumers use the standard-image composition contract before merge. - Legacy cloud release-channel aliases stop advancing. Standard self-hosted aliases continue. - This PR deletes no registry images, cache tags, migrators, credentials, or runner infrastructure. Existing immutable releases remain usable for rollback. - Explicit legacy previews remain for commit-specific operator deployments. Retiring that compatibility path requires a separate consumer migration. - These changes affect CI publication, not database schema or application behavior. ## Model Used OpenAI Codex, GPT-6. The runtime does not expose a more specific model identifier or context-window size. Used repository inspection, reasoning, code editing, shell tools, and test execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
104 lines
5.9 KiB
JavaScript
104 lines
5.9 KiB
JavaScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { readFileSync } from "node:fs";
|
|
import { runInNewContext } from "node:vm";
|
|
|
|
const fleet = "runs-on/fleet=paperclip-post-merge-x64/env=public-ci";
|
|
const sha = "a".repeat(40);
|
|
const base = {
|
|
repository: "paperclipai/paperclip", repository_id: "1170821064",
|
|
ref: "refs/heads/master", event_name: "push", sha,
|
|
};
|
|
const expectedJobs = {
|
|
"cloud-readiness.yml": [],
|
|
"cloud-migrator-artifacts.yml": [],
|
|
"release-verify.yml": ["typecheck", "general_tests", "serialized_tests", "runner_workflow_evals", "verify_paperclip_runner", "build"],
|
|
"runner-chaos-evals.yml": ["chaos_and_recovery"],
|
|
"release.yml": ["plan_preview", "package_preview"],
|
|
};
|
|
for (const [file, expectedNames] of Object.entries(expectedJobs)) {
|
|
const workflow = readFileSync(new URL(`../../workflows/${file}`, import.meta.url), "utf8");
|
|
const jobs = [...workflow.matchAll(/^ ([a-z_]+):\n([\s\S]*?)(?=^ [a-z_]+:\n|(?![\s\S]))/gm)];
|
|
const routed = jobs.filter(([, , body]) => body.includes(fleet));
|
|
test(`${file}: all intended jobs carry the post-merge guard`, () => {
|
|
assert.deepEqual(routed.map(([, name]) => name).sort(), [...expectedNames].sort());
|
|
});
|
|
for (const [, job, body] of routed) {
|
|
const expression = body.match(/^ runs-on: \$\{\{ (.+) \}\}$/m)?.[1];
|
|
assert.ok(expression, `${file}/${job} must use an explicit runner expression`);
|
|
const release = file === "release.yml";
|
|
const checkRef = release || file === "release-verify.yml" || file === "runner-chaos-evals.yml";
|
|
const inputs = { ref: sha, source_ref: sha, channel: "cloud-migrator" };
|
|
const defaultContext = { ...base, event_name: release ? "workflow_dispatch" : "push" };
|
|
const cases = [
|
|
{ name: "exact master source", expected: fleet },
|
|
{ name: "manual exact master source", github: { event_name: "workflow_dispatch" }, expected: fleet },
|
|
{ name: "switch disabled", enabled: "false" },
|
|
{ name: "switch absent", enabled: "" },
|
|
{ name: "malformed switch", enabled: "yes" },
|
|
{ name: "fork", github: { repository: "someone/paperclip", repository_id: "123" } },
|
|
{ name: "repository renamed or transferred", github: { repository_id: "123" } },
|
|
{ name: "unapproved PR", github: { event_name: "pull_request", ref: "refs/pull/1/merge" } },
|
|
{ name: "PR event even with master ref", github: { event_name: "pull_request" } },
|
|
{ name: "privileged PR event", github: { event_name: "pull_request_target" } },
|
|
{ name: "workflow completion event", github: { event_name: "workflow_run" } },
|
|
{ name: "repository dispatch", github: { event_name: "repository_dispatch" } },
|
|
{ name: "scheduled caller", github: { event_name: "schedule" } },
|
|
{ name: "branch workflow", github: { ref: "refs/heads/feature" } },
|
|
{ name: "release tag", github: { ref: "refs/tags/v2026.911.0" } },
|
|
];
|
|
if (checkRef) {
|
|
const key = release ? "source_ref" : "ref";
|
|
for (const value of ["b".repeat(40), "refs/pull/1/head", "master", "feature", "v1.0.0", ""]) {
|
|
cases.push({ name: `unverified source ${value || "(empty)"}`, inputs: { [key]: value } });
|
|
}
|
|
cases.push({ name: "missing source identity", github: { sha: "" }, inputs: { [key]: "" } });
|
|
}
|
|
if (release) {
|
|
cases.push({ name: "preview of master", inputs: { channel: "preview" } });
|
|
cases.push({ name: "stable release", inputs: { channel: "stable" } });
|
|
}
|
|
for (const { name, github = {}, inputs: overrides = {}, enabled = "true", expected = "ubuntu-latest" } of cases) {
|
|
test(`${file}/${job}: ${name}`, () => {
|
|
const context = { github: { ...defaultContext, ...github }, inputs: { ...inputs, ...overrides }, vars: { AWS_POST_MERGE_CI_ENABLED: enabled } };
|
|
// These canonical contexts use boolean operators and string comparisons
|
|
// whose results match GitHub's expression evaluation.
|
|
assert.equal(runInNewContext(expression, context), expected);
|
|
const timeout = body.match(/^ timeout-minutes: (.+)$/m)?.[1];
|
|
assert.ok(timeout, "AWS jobs need a timeout below the 45-minute instance lifetime");
|
|
const minutes = timeout.startsWith("${{") ? runInNewContext(timeout.slice(3, -2), context) : Number(timeout);
|
|
if (expected === fleet) assert.ok(minutes > 0 && minutes < 45);
|
|
if (release && job === "plan_preview") assert.equal(minutes, expected === fleet ? 10 : 360);
|
|
});
|
|
}
|
|
}
|
|
if (file === "release.yml") {
|
|
test("npm publisher always uses a GitHub-hosted runner", () => {
|
|
const publisher = jobs.find(([ , job]) => job === "publish_preview")?.[2];
|
|
assert.match(publisher, /^ runs-on: ubuntu-latest$/m);
|
|
assert.match(publisher, /^ environment: npm-canary$/m);
|
|
assert.match(publisher, /^ id-token: write$/m);
|
|
});
|
|
}
|
|
}
|
|
|
|
|
|
test("Cloud readiness bookkeeping never waits for the AWS verification fleet", () => {
|
|
const workflow = readFileSync(new URL("../../workflows/cloud-readiness.yml", import.meta.url), "utf8");
|
|
const bodies = new Map();
|
|
for (const [name, needs] of [
|
|
["source_verified", "[verify]"],
|
|
]) {
|
|
const body = workflow.match(new RegExp(`^ ${name}:\\n([\\s\\S]*?)(?=^ [a-z_]+:|(?![\\s\\S]))`, "m"))?.[1];
|
|
assert.ok(body, `missing ${name} job`);
|
|
bodies.set(name, body);
|
|
assert.match(body, /^ runs-on: ubuntu-latest$/m);
|
|
assert.doesNotMatch(body, /^ +continue-on-error:|^ +if:.*always\(\)/m);
|
|
assert.match(body, /^ if: github.repository == 'paperclipai\/paperclip' && github.ref == 'refs\/heads\/master'$/m);
|
|
assert.match(body, /^ +SOURCE_SHA: \$\{\{ github.sha \}\}$/m);
|
|
assert.equal(body.match(/^ needs: (.+)$/m)?.[1] ?? null, needs, `${name} prerequisites`);
|
|
}
|
|
assert.match(bodies.get("source_verified"), /^ run: node --test scripts\/cloud-source-verification.test.mjs$/m);
|
|
assert.match(bodies.get("source_verified"), /echo "Cloud source verified v1: \$SOURCE_SHA"/);
|
|
});
|