mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-08 01:57:31 +01:00
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - The agent Test action builds adapter config from the form.
> - The build-config parser kept plain and secret_ref bindings.
> - It dropped user_secret_ref bindings on the create path.
> - This PR shares one parser that keeps every binding shape.
> - The test path now sends the same env binding set that a real run
sees.
> - The benefit is one fix across every adapter build-config path.
## Linked Issues or Issue Description
**What happened?**
The agent Test action dropped a user-scoped env binding in create mode.
The same agent config worked in a real run. Related public PRs: #10115,
#9321, #9921, #8825.
**Expected behavior**
The Test action should keep user-scoped env bindings and resolve them
like a real run.
**Steps to reproduce**
1. Set a user-scoped env binding on an agent config form.
2. Run Test in create mode.
3. The probe runs without the variable.
**Paperclip version or commit**
c09d2509e3
**Deployment mode**
Local dev (pnpm dev)
**Agent adapter(s) involved**
Not adapter-specific (core bug)
**Database mode**
Embedded PGlite (default — DATABASE_URL unset)
**Additional context**
This change is not Claude-specific.
## What Changed
- Added a shared env binding parser in `@paperclipai/adapter-utils`.
- Replaced the eight adapter build-config copies with the shared helper.
- Kept `plain`, `secret_ref`, and `user_secret_ref` bindings intact in
create mode and edit mode.
- Preserved the runtime merge behavior from the earlier env merge
change.
## Verification
- Author-recorded test run:
`packages/adapter-utils/src/env-bindings.test.ts`
- Author-recorded test run:
`packages/adapters/claude-local/src/ui/build-config.test.ts`
- Author-recorded test run: six adapter build-config test files
- Author-recorded typecheck: `tsc --noEmit` for adapter-utils and the
eight adapter packages
- GitHub checks: all required PR checks pass on PR #10926.
- Greptile review: 5/5 with no open comments.
## Risks
- The change touches adapter config assembly.
- A wrong binding shape would change test-time probe input.
- Tests cover the binding types and the create-mode path.
> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.
## Model Used
OpenAI GPT-5, code execution and repo inspection.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` /
`Closes: #` / `Refs: #` OR (b) described the issue in-PR following the
relevant issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change and contains no internal
Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes or
confirmed no documentation update is needed
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
98 lines
2.7 KiB
TypeScript
98 lines
2.7 KiB
TypeScript
export type {
|
|
AdapterAgent,
|
|
AdapterRuntime,
|
|
UsageSummary,
|
|
AdapterBillingType,
|
|
AdapterRuntimeServiceReport,
|
|
AdapterExecutionResult,
|
|
AdapterInvocationMeta,
|
|
AdapterRuntimeEvent,
|
|
AdapterRuntimeMcpServer,
|
|
AdapterRuntimeMcpAccess,
|
|
AdapterExecutionContext,
|
|
AdapterEnvironmentCheckLevel,
|
|
AdapterEnvironmentCheck,
|
|
AdapterEnvironmentTestStatus,
|
|
AdapterEnvironmentTestResult,
|
|
AdapterEnvironmentTestContext,
|
|
AdapterSkillSyncMode,
|
|
AdapterSkillState,
|
|
AdapterSkillOrigin,
|
|
AdapterSkillEntry,
|
|
AdapterSkillSnapshot,
|
|
AdapterSkillContext,
|
|
AdapterSessionCodec,
|
|
AdapterModel,
|
|
AdapterModelProfileKey,
|
|
AdapterModelProfileDefinition,
|
|
HireApprovedPayload,
|
|
HireApprovedHookResult,
|
|
ConfigFieldOption,
|
|
ConfigFieldSchema,
|
|
AdapterConfigSchema,
|
|
AdapterRuntimeCommandSpec,
|
|
AcpTargetDescriptor,
|
|
ServerAdapterModule,
|
|
QuotaWindow,
|
|
ProviderQuotaResult,
|
|
TranscriptEntry,
|
|
StdoutLineParser,
|
|
CLIAdapterModule,
|
|
CreateConfigValues,
|
|
} from "./types.js";
|
|
export type {
|
|
SessionCompactionPolicy,
|
|
NativeContextManagement,
|
|
AdapterSessionManagement,
|
|
ResolvedSessionCompactionPolicy,
|
|
} from "./session-compaction.js";
|
|
export {
|
|
ADAPTER_SESSION_MANAGEMENT,
|
|
LEGACY_SESSIONED_ADAPTER_TYPES,
|
|
getAdapterSessionManagement,
|
|
readSessionCompactionOverride,
|
|
resolveSessionCompactionPolicy,
|
|
hasSessionCompactionThresholds,
|
|
} from "./session-compaction.js";
|
|
export {
|
|
REDACTED_HOME_PATH_USER,
|
|
redactHomePathUserSegments,
|
|
redactHomePathUserSegmentsInValue,
|
|
redactTranscriptEntryPaths,
|
|
} from "./log-redaction.js";
|
|
export {
|
|
REDACTED_COMMAND_TEXT_VALUE,
|
|
redactCommandText,
|
|
} from "./command-redaction.js";
|
|
export { buildSandboxNpmInstallCommand } from "./sandbox-install-command.js";
|
|
export {
|
|
buildAdapterEnvConfig,
|
|
parseEnvBindings,
|
|
parseEnvVars,
|
|
} from "./env-bindings.js";
|
|
export { createRuntimeProgressReporter } from "./runtime-progress.js";
|
|
export type {
|
|
RuntimeProgressSink,
|
|
RuntimeProgressPhase,
|
|
RuntimeProgressDirection,
|
|
RuntimeProgressTarget,
|
|
RuntimeProgressReporter,
|
|
RuntimeProgressReporterOptions,
|
|
RuntimeStatusPhase,
|
|
RuntimeStatusSink,
|
|
RuntimeStatusUpdate,
|
|
} from "./runtime-progress.js";
|
|
export { inferOpenAiCompatibleBiller } from "./billing.js";
|
|
// Keep the root adapter-utils entry browser-safe because the UI imports it.
|
|
// The sandbox callback bridge stays available via its dedicated subpath export.
|
|
export type {
|
|
SandboxCallbackBridgeRequest,
|
|
SandboxCallbackBridgeResponse,
|
|
SandboxCallbackBridgeAsset,
|
|
SandboxCallbackBridgeDirectories,
|
|
SandboxCallbackBridgeRouteRule,
|
|
SandboxCallbackBridgeQueueClient,
|
|
SandboxCallbackBridgeWorkerHandle,
|
|
StartedSandboxCallbackBridgeServer,
|
|
} from "./sandbox-callback-bridge.js";
|