Files
DottaandPaperclip 7b35de65aa feat(mcp) [split 1/8]: add fixture demo servers (#9556)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - Governed MCP access spans contracts, runtime enforcement, adapters,
UI surfaces, and operator verification
> - The parity reference PR #9534 is too large for effective automated
or human review
> - The feature therefore needs a linear stack whose individual diffs
stay below the 100-file review limit
> - This pull request is split 1/8 and focuses on fixture and demo MCP
servers
> - The benefit is a standalone, testable review boundary while
preserving byte-for-byte parity at the top of the stack

## Linked Issues or Issue Description

- Related parity reference: #9534
- Problem: Developers need deterministic local MCP fixtures and visible
demo servers without pulling in the governed production runtime.
- Proposed solution: Adds the Google Sheets and KV demo MCP packages,
fixture catalog/servers, smoke harness, guide, and the root
smoke/typecheck registration hunks.
- Alternatives considered: keeping #9534 as one 403-file review, or
rewriting the feature to manufacture seams; both were rejected in favor
of path extraction plus compile-driven boundary moves.
- Roadmap alignment: this advances the existing governed MCP/tool-access
work already represented by #9534; it does not introduce a separate
roadmap initiative.
- Stack position: base branch is `master`.
- Merge policy: merge bottom-up, in order, only after the complete
eight-PR stack has been reviewed and the top-of-stack parity gate
remains empty.
- Requested review: QA for fixture and smoke coverage; Greptile on every
PR.

## What Changed

- Adds the Google Sheets and KV demo MCP packages, fixture
catalog/servers, smoke harness, guide, and the root smoke/typecheck
registration hunks.
- Keeps this PR below 100 changed files and independently typecheckable.
- Preserves the final tree from #9534 when combined with the other seven
stack levels.

## Verification

- `pnpm typecheck`
- `pnpm --filter @paperclipai/google-sheets-mcp-server test` — 27 tests
passed
- `pnpm --filter @paperclipai/kv-demo-mcp-server test` — 12 tests passed

## Risks

- The new packages add dependencies that are intentionally not committed
to `pnpm-lock.yaml`, per repository policy.
- Stack risk: merging out of order can expose incomplete layers;
mitigate by following the documented bottom-up merge policy.
- Parity risk: later edits to an intermediate branch can drift from
#9534; mitigate by re-running the empty top-of-stack diff before merge.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

- OpenAI Codex, exact model ID `gpt-5.4`; runtime-managed context
window; medium reasoning with repository, shell, Git, GitHub CLI, and
code-execution tools enabled.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] Internal references are omitted except the execution-plan link
explicitly required for this coordinated split stack
- [x] My branch name describes the change and contains no internal
Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge


## Stack Coordination

- Internal execution plan:
[PAP-13874](/PAP/issues/PAP-13874#document-plan)
- Parity reference: #9534
- Stack: #9556 → #9557 → #9558 → #9559 → #9560 → #9561 → #9562 → #9563
- Merge bottom-up only after full-stack review and an empty parity diff
at #9563.

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-07-14 12:56:21 -05:00

249 lines
7.6 KiB
TypeScript

import type { CallToolResult, ToolAnnotations } from "@modelcontextprotocol/sdk/types.js";
import { z } from "zod";
import type { GoogleSheetsClient } from "./google-client.js";
export type ToolResult = CallToolResult;
export interface GoogleSheetsToolDefinition {
name: string;
description: string;
schema: z.AnyZodObject;
annotations: ToolAnnotations;
execute: (input: Record<string, unknown>) => Promise<ToolResult>;
}
export interface GoogleSheetsToolOptions {
client: GoogleSheetsClient;
allowedSpreadsheetIds: string[];
secretRedactions?: string[];
}
type ToolRisk = "read" | "write" | "destructive";
const spreadsheetIdSchema = z.string().trim().min(1);
const rangeSchema = z.string().trim().min(1).max(500).refine(
(range) => !/[\r\n]/.test(range),
"Range must be a single-line A1 notation range.",
);
const valuesSchema = z.array(z.array(z.union([z.string(), z.number(), z.boolean(), z.null()])));
const valueInputOptionSchema = z.enum(["RAW", "USER_ENTERED"]).default("RAW");
const spreadsheetToolSchema = z.object({
spreadsheetId: spreadsheetIdSchema,
});
const readValuesSchema = spreadsheetToolSchema.extend({
range: rangeSchema,
});
const searchRowsSchema = readValuesSchema.extend({
query: z.string().min(1),
caseSensitive: z.boolean().optional().default(false),
maxResults: z.number().int().positive().max(500).optional().default(50),
});
const appendRowsSchema = readValuesSchema.extend({
values: valuesSchema.min(1),
valueInputOption: valueInputOptionSchema,
});
const updateValuesSchema = readValuesSchema.extend({
values: valuesSchema.min(1),
valueInputOption: valueInputOptionSchema,
});
const addSheetTabSchema = spreadsheetToolSchema.extend({
title: z.string().trim().min(1).max(100),
rowCount: z.number().int().positive().max(1000000).optional(),
columnCount: z.number().int().positive().max(18278).optional(),
});
const deleteRowsSchema = spreadsheetToolSchema.extend({
sheetId: z.number().int().nonnegative(),
startIndex: z.number().int().nonnegative(),
endIndex: z.number().int().positive(),
});
function annotationsFor(title: string, risk: ToolRisk): ToolAnnotations {
if (risk === "read") {
return { title, readOnlyHint: true, openWorldHint: false };
}
if (risk === "write") {
return { title, readOnlyHint: false, destructiveHint: false, openWorldHint: false };
}
return { title, readOnlyHint: false, destructiveHint: true, openWorldHint: false };
}
function formatTextResponse(value: unknown): ToolResult {
return {
content: [{
type: "text",
text: typeof value === "string" ? value : JSON.stringify(value, null, 2),
}],
};
}
function errorMessage(error: unknown): string {
if (error instanceof z.ZodError) return error.errors.map((entry) => entry.message).join("; ");
if (error instanceof Error) return error.message;
return String(error);
}
function redact(value: string, secretRedactions: string[]): string {
let output = value;
for (const secret of secretRedactions) {
if (secret.length >= 8) output = output.split(secret).join("[REDACTED]");
}
return output.replace(/-----BEGIN PRIVATE KEY-----[\s\S]*?-----END PRIVATE KEY-----/g, "[REDACTED_PRIVATE_KEY]");
}
function formatErrorResponse(error: unknown, secretRedactions: string[]): ToolResult {
return {
isError: true,
content: [{
type: "text",
text: redact(errorMessage(error), secretRedactions),
}],
};
}
function makeTool<TSchema extends z.ZodRawShape>(
options: GoogleSheetsToolOptions,
name: string,
description: string,
risk: ToolRisk,
schema: z.ZodObject<TSchema>,
execute: (input: z.infer<typeof schema>) => Promise<unknown>,
): GoogleSheetsToolDefinition {
return {
name,
description,
schema,
annotations: annotationsFor(description, risk),
execute: async (input) => {
try {
const parsed = schema.parse(input);
return formatTextResponse(await execute(parsed));
} catch (error) {
return formatErrorResponse(error, options.secretRedactions ?? []);
}
},
};
}
function assertAllowed(allowedSpreadsheetIds: Set<string>, spreadsheetId: string) {
if (!allowedSpreadsheetIds.has(spreadsheetId)) {
throw new Error(`Spreadsheet ${spreadsheetId} is not in the configured allowlist.`);
}
}
export function createToolDefinitions(options: GoogleSheetsToolOptions): GoogleSheetsToolDefinition[] {
const allowedSpreadsheetIds = Array.from(new Set(options.allowedSpreadsheetIds.map((id) => id.trim()).filter(Boolean)));
const allowedSpreadsheetIdSet = new Set(allowedSpreadsheetIds);
if (allowedSpreadsheetIds.length === 0) {
throw new Error("At least one allowed spreadsheet ID is required.");
}
return [
makeTool(
options,
"list_spreadsheets",
"List the Google Sheets spreadsheets configured in this connection allowlist.",
"read",
z.object({}),
async () => options.client.listSpreadsheets(allowedSpreadsheetIds),
),
makeTool(
options,
"get_spreadsheet_info",
"Get spreadsheet metadata and sheet tab information for an allowlisted spreadsheet.",
"read",
spreadsheetToolSchema,
async ({ spreadsheetId }) => {
assertAllowed(allowedSpreadsheetIdSet, spreadsheetId);
return options.client.getSpreadsheetInfo(spreadsheetId);
},
),
makeTool(
options,
"read_values",
"Read cell values from an allowlisted spreadsheet range.",
"read",
readValuesSchema,
async ({ spreadsheetId, range }) => {
assertAllowed(allowedSpreadsheetIdSet, spreadsheetId);
return options.client.readValues(spreadsheetId, range);
},
),
makeTool(
options,
"search_rows",
"Search rows in an allowlisted spreadsheet range.",
"read",
searchRowsSchema,
async (input) => {
assertAllowed(allowedSpreadsheetIdSet, input.spreadsheetId);
return options.client.searchRows(input);
},
),
makeTool(
options,
"append_rows",
"Append rows to an allowlisted spreadsheet range.",
"write",
appendRowsSchema,
async (input) => {
assertAllowed(allowedSpreadsheetIdSet, input.spreadsheetId);
return options.client.appendRows(input);
},
),
makeTool(
options,
"update_values",
"Update values in an allowlisted spreadsheet range.",
"write",
updateValuesSchema,
async (input) => {
assertAllowed(allowedSpreadsheetIdSet, input.spreadsheetId);
return options.client.updateValues(input);
},
),
makeTool(
options,
"add_sheet_tab",
"Add a sheet tab to an allowlisted spreadsheet.",
"write",
addSheetTabSchema,
async (input) => {
assertAllowed(allowedSpreadsheetIdSet, input.spreadsheetId);
return options.client.addSheetTab(input);
},
),
makeTool(
options,
"clear_values",
"Clear values in an allowlisted spreadsheet range.",
"destructive",
readValuesSchema,
async ({ spreadsheetId, range }) => {
assertAllowed(allowedSpreadsheetIdSet, spreadsheetId);
return options.client.clearValues(spreadsheetId, range);
},
),
makeTool(
options,
"delete_rows",
"Delete rows from an allowlisted spreadsheet tab.",
"destructive",
deleteRowsSchema,
async (input) => {
assertAllowed(allowedSpreadsheetIdSet, input.spreadsheetId);
if (input.endIndex <= input.startIndex) {
throw new Error("endIndex must be greater than startIndex.");
}
return options.client.deleteRows(input);
},
),
];
}