mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-26 10:26:26 +01:00
## Thinking Path > - Paperclip relies on end-to-end tests to catch regressions in the operator UI > - The applications list status pill is rendered from more than one data fetch, so the visible label can lag behind the row itself > - A default Playwright assertion timeout can expire before the connections fetch finishes under CI load > - That creates a flaky failure without changing the underlying product behavior > - This pull request extends the two status-pill assertions to use the longer timeout already used elsewhere in the spec > - The benefit is the same UI coverage with fewer false negatives ## Linked Issues or Issue Description There is no public GitHub issue linked to this repo-local fix. This PR addresses a flaky Playwright assertion in `tests/e2e/applications-crud.spec.ts`, where the status pill can render after the default assertion timeout because it depends on the connections fetch as well as the applications fetch. ## What Changed - Increased the wait window for the two status-pill visibility assertions in `tests/e2e/applications-crud.spec.ts`. - Kept the assertions anchored to the exact expected labels (`Healthy` and `Not connected`) so the test still verifies the same behavior. ## Verification - The spec is still discovered cleanly by Playwright. - The diff stays limited to `tests/e2e/applications-crud.spec.ts`; there are no product, dependency, or lockfile changes. - The full browser-backed e2e signal remains CI for this change. ## Risks - Low risk. This only changes assertion timing in a test file and does not alter runtime product behavior. ## Model Used OpenAI Codex, GPT-5, tool-using coding agent. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge Co-authored-by: Paperclip <noreply@paperclip.ing>
163 lines
8.0 KiB
TypeScript
163 lines
8.0 KiB
TypeScript
import { expect, test, type APIRequestContext, type Page } from "@playwright/test";
|
|
|
|
// Current Apps lifecycle coverage. The legacy Tools -> Applications CRUD table
|
|
// was retired; old links now redirect to /apps. Keep this harness focused on
|
|
// the user-visible Connections list plus app detail setup/advanced flows.
|
|
|
|
type SeedResult = {
|
|
companyId: string;
|
|
prefix: string;
|
|
};
|
|
|
|
const SCREENSHOT_DIR = "test-results";
|
|
const APP_PREFIX = `QA 10820 ${Date.now().toString(36)}`;
|
|
|
|
async function discoverCompany(request: APIRequestContext): Promise<SeedResult> {
|
|
const res = await request.post("/api/companies", {
|
|
data: { name: `applications lifecycle ${Date.now()}` },
|
|
});
|
|
expect(res.ok(), `create company failed ${res.status()}: ${await res.text()}`).toBe(true);
|
|
const company = await res.json();
|
|
const flags = await request.patch("/api/instance/settings/experimental", { data: { enableApps: true } });
|
|
expect(flags.ok(), `enable apps failed ${flags.status()}: ${await flags.text()}`).toBe(true);
|
|
return {
|
|
companyId: company.id,
|
|
prefix: company.issuePrefix ?? company.prefix ?? company.urlKey ?? "E2E",
|
|
};
|
|
}
|
|
|
|
async function createApplication(
|
|
request: APIRequestContext,
|
|
companyId: string,
|
|
body: { name: string; description?: string; type?: string },
|
|
): Promise<{ id: string; name: string }> {
|
|
const res = await request.post(`/api/companies/${companyId}/tools/applications`, {
|
|
data: { type: "mcp_http", ...body },
|
|
});
|
|
if (!res.ok()) throw new Error(`create app failed ${res.status()}: ${await res.text()}`);
|
|
return res.json();
|
|
}
|
|
|
|
async function createConnection(
|
|
request: APIRequestContext,
|
|
companyId: string,
|
|
data: { applicationName?: string; applicationId?: string; name: string; transport?: string; config?: object },
|
|
): Promise<{ id: string; applicationId: string; name: string }> {
|
|
const res = await request.post(`/api/companies/${companyId}/tools/connections`, {
|
|
data: {
|
|
transport: "mcp_remote",
|
|
config: { url: "https://fixture.example/mcp" },
|
|
enabled: true,
|
|
status: "active",
|
|
...data,
|
|
},
|
|
});
|
|
if (!res.ok()) throw new Error(`create connection failed ${res.status()}: ${await res.text()}`);
|
|
return res.json();
|
|
}
|
|
|
|
async function gotoApps(page: Page, prefix: string) {
|
|
await page.goto(`/${prefix}/apps`);
|
|
await expect(page.getByRole("heading", { name: "Connections" })).toBeVisible({ timeout: 30_000 });
|
|
}
|
|
|
|
test.describe.serial("applications lifecycle", () => {
|
|
let seed: SeedResult;
|
|
|
|
test.beforeAll(async ({ request }) => {
|
|
seed = await discoverCompany(request);
|
|
});
|
|
|
|
test.afterAll(async ({ request }) => {
|
|
if (!seed?.companyId) return;
|
|
await request.delete(`/api/companies/${seed.companyId}`).catch(() => undefined);
|
|
});
|
|
|
|
test("Connections list surfaces connected and not-connected apps", async ({ page, request }) => {
|
|
const connectedName = `${APP_PREFIX}-connected`;
|
|
const notConnectedName = `${APP_PREFIX}-not-connected`;
|
|
const connected = await createConnection(request, seed.companyId, {
|
|
applicationName: connectedName,
|
|
name: connectedName,
|
|
});
|
|
const notConnected = await createApplication(request, seed.companyId, { name: notConnectedName });
|
|
|
|
await gotoApps(page, seed.prefix);
|
|
|
|
// The status pill ("Healthy" / "Not connected") is derived from two separate
|
|
// react-query fetches (applications + connections). A row can paint as soon as
|
|
// the applications fetch resolves, but the pill only renders once the
|
|
// connections fetch also settles. Under CI load that second fetch can land
|
|
// after Playwright's default 5s assertion timeout, so give the pill
|
|
// assertions the same generous window used by the rest of this spec — this is
|
|
// a polling wait on the real rendered label, not a fixed sleep, so coverage of
|
|
// the exact status text is preserved.
|
|
const connectedRow = page.locator("tbody tr", { hasText: connectedName });
|
|
await expect(connectedRow).toBeVisible();
|
|
await expect(connectedRow.getByText("Healthy")).toBeVisible({ timeout: 30_000 });
|
|
await expect(connectedRow.getByRole("button", { name: "Open" })).toBeVisible();
|
|
|
|
const notConnectedRow = page.locator("tbody tr", { hasText: notConnectedName });
|
|
await expect(notConnectedRow).toBeVisible();
|
|
await expect(notConnectedRow.getByText("Not connected")).toBeVisible({ timeout: 30_000 });
|
|
await expect(notConnectedRow.getByRole("button", { name: "Connect" })).toBeVisible();
|
|
await page.screenshot({ path: `${SCREENSHOT_DIR}/applications-crud-current-list.png`, fullPage: true });
|
|
|
|
await connectedRow.getByRole("button", { name: "Open" }).click();
|
|
await expect(page).toHaveURL(new RegExp(`/${seed.prefix}/apps/${connected.id}`), { timeout: 20_000 });
|
|
|
|
await gotoApps(page, seed.prefix);
|
|
await notConnectedRow.getByRole("button", { name: "Connect" }).click();
|
|
await expect(page).toHaveURL(new RegExp(`/${seed.prefix}/apps/app/${notConnected.id}`), { timeout: 20_000 });
|
|
});
|
|
|
|
test("connected app detail supports pause, rename, and removal", async ({ page, request }) => {
|
|
const appName = `${APP_PREFIX}-detail-app`;
|
|
const renamed = `${APP_PREFIX}-renamed-app`;
|
|
const connection = await createConnection(request, seed.companyId, {
|
|
applicationName: appName,
|
|
name: appName,
|
|
});
|
|
|
|
await page.goto(`/${seed.prefix}/apps/${connection.id}/setup`);
|
|
await expect(page.getByRole("heading", { name: appName })).toBeVisible({ timeout: 30_000 });
|
|
await expect(page.getByRole("heading", { name: "Agents can use this app" })).toBeVisible();
|
|
|
|
await page.getByRole("switch", { name: "Pause this app" }).click();
|
|
await expect(page.getByRole("heading", { name: "This app is paused" })).toBeVisible({ timeout: 15_000 });
|
|
await page.getByRole("switch", { name: "Resume this app" }).click();
|
|
await expect(page.getByRole("heading", { name: "Agents can use this app" })).toBeVisible({ timeout: 15_000 });
|
|
|
|
await page.getByRole("button", { name: "Rename app" }).click();
|
|
await page.getByLabel("App name").fill(renamed);
|
|
await page.getByRole("button", { name: "Save", exact: true }).click();
|
|
await expect(page.getByRole("heading", { name: renamed })).toBeVisible({ timeout: 15_000 });
|
|
await page.screenshot({ path: `${SCREENSHOT_DIR}/applications-crud-current-detail.png`, fullPage: true });
|
|
|
|
await page.goto(`/${seed.prefix}/apps/${connection.id}/advanced`);
|
|
await expect(page.getByText("Danger zone")).toBeVisible({ timeout: 15_000 });
|
|
await page.getByRole("button", { name: "Remove app", exact: true }).click();
|
|
await expect(page.getByRole("button", { name: "Yes, remove it" })).toBeVisible();
|
|
await page.screenshot({ path: `${SCREENSHOT_DIR}/applications-crud-current-remove-connected.png`, fullPage: true });
|
|
await page.getByRole("button", { name: "Yes, remove it" }).click();
|
|
await expect(page).toHaveURL(new RegExp(`/${seed.prefix}/apps$`), { timeout: 20_000 });
|
|
await expect(page.getByText("App removed").first()).toBeVisible({ timeout: 20_000 });
|
|
await expect(page.locator("tbody tr", { hasText: renamed })).toHaveCount(0);
|
|
});
|
|
|
|
test("not-connected app advanced page removes the application", async ({ page, request }) => {
|
|
const cleanAppName = `${APP_PREFIX}-clean-remove-app`;
|
|
const cleanApp = await createApplication(request, seed.companyId, { name: cleanAppName });
|
|
|
|
await page.goto(`/${seed.prefix}/apps/app/${cleanApp.id}/advanced`);
|
|
await expect(page.getByRole("heading", { name: cleanAppName })).toBeVisible({ timeout: 30_000 });
|
|
await expect(page.getByText("Danger zone")).toBeVisible();
|
|
await page.getByRole("button", { name: "Remove app", exact: true }).click();
|
|
await page.screenshot({ path: `${SCREENSHOT_DIR}/applications-crud-current-remove-not-connected.png`, fullPage: true });
|
|
await page.getByRole("button", { name: "Yes, remove it" }).click();
|
|
await expect(page).toHaveURL(new RegExp(`/${seed.prefix}/apps$`), { timeout: 20_000 });
|
|
await expect(page.getByText("App removed").first()).toBeVisible({ timeout: 20_000 });
|
|
await expect(page.locator("tbody tr", { hasText: cleanAppName })).toHaveCount(0);
|
|
});
|
|
});
|