mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-26 18:31:34 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The runner subsystem executes agent work across local and managed provider backends. > - The lower pull requests restore the task runtime, provider backends, and managed-provider control plane. > - The restored system needs repeatable full-stack checks before it can ship safely. > - Paid live checks also need clear access, cost, and secret controls. > - This pull request adds acceptance, live evaluation, chaos, and release gates for the restored runner stack. > - The benefit is measurable runner parity with safer release decisions. ## Linked Issues or Issue Description **Subsystem affected** Cross-cutting. This change covers runner tests, release workflows, server contracts, and evaluation tools. **Problem or motivation** The runner stack did not have one complete acceptance surface for native Codex, ACPX, Claude Managed, and AWS AgentCore. Release checks could miss provider drift, task-view regressions, cost-policy errors, and destructive cleanup errors. **Proposed solution** Add a 57-cell full-stack catalog, a Daytona image, and opt-in paid workflows. Add live evaluation, chaos, cost-limit, redaction, and release contract checks. Add AWS AgentCore infrastructure and guarded provisioning tools. Keep the native runner experimental flag off by default. **Alternatives considered** We considered manual smoke tests only. They do not give repeatable evidence and they do not protect release branches. We also considered one large pull request. The stacked pull requests keep each review below the Greptile file limit. **Roadmap alignment** This work supports the shipped Cloud / Sandbox agents milestone and the shipped Agent evals & feedback milestone in `ROADMAP.md`. Related stack: - #12699 adds managed provider backends and lifecycle support. - #12691 adds qualified OpenCode and ACPX provider backends. - #12685 restores task runtime rendering and steering. ## What Changed - Add the runner full-stack harness with 57 catalog cells and 60 unit tests. - Add a Daytona runner image with digest-pinned base images and base-aware image-content checks. - Add guarded live evaluation and chaos workflows with a fixed 40-execution matrix; live and full-stack paid schedules now run only on Sundays or by manual dispatch. - Add in-flight reported-usage cost stops, post-turn cost caps, exact-threshold failure classification, secret redaction, retry classification, and actor authorization. - Reattach stream and hard-budget listeners before restart-recovery continuations so restored paid sessions cannot bypass in-flight interruption. - Preserve OpenCode usage and cost across tool-loop messages and turns while exposing an explicit current-run delta to durable accounting. - Keep PNG/WebM evidence in access-controlled artifacts only, reject SVG, and publish only pruned inert structured per-attempt evidence. - Add AWS AgentCore infrastructure, provisioning checks, and smoke tools; reject unsafe model identifiers, require exact stack ownership markers, and make failed-stack replacement explicit. - Add evaluation-session contracts and capability reports. - Add release workflow checks for immutable action pins, frozen dependency installs, exact weekly cron shape, paid-run guards, provider-secret isolation, and chaos test paths. - Reauthorize the original and triggering numeric actor IDs as the first step of every provider-secret job, including partial reruns, before checkout or provider access. - Give each full-stack matrix cell only its matching provider credential, expose Daytona only to Daytona cells, and disable shared dependency caches anywhere paid credentials or OIDC write access are present. - Protect the legacy manual E2E workflow with the same default-branch, allowlist, environment, and per-job authorization boundary. - Rotate live-eval candidates by week and retain 120 days of compatible history so the seven-week trend window remains viable. - Restore the root runner-acceptance commands and reconcile reported snapshots, raw receipts, and terminal usage without double counting or losing late usage. - Mark ACPX token deltas exact only when every budget field is present, keep cumulative cost/request authority separate, reject non-USD cost labeling, and include thought tokens in output-token budgets. - Keep `enableNativeRunner` off by default. The acceptance harness enables it only in its isolated test instance. ## Verification Passed locally: - `pnpm --filter @paperclipai/paperclip-runner typecheck` - `pnpm test:runner-acceptance:typecheck` - `pnpm test:runner-acceptance` (19 tests) - focused OpenCode proxy, driver, runnerd transport, live-session, and turn-stream tests (106 tests) - `pnpm --filter @paperclipai/paperclip-runner exec vitest run src/live/clean-room-server.test.ts` (22 tests) - `pnpm test:e2e:runner:typecheck` - `pnpm test:e2e:runner:unit` (62 tests) - `node --test scripts/__tests__/release-verify-workflow.test.mjs` - `pnpm --filter @paperclipai/paperclip-runner test:runner-workflow-evals` (22 tests) - `pnpm -r typecheck` - `pnpm build` - `node --test packages/paperclip-runner/scripts/aws-agentcore-provisioning.test.mjs` (6 tests) - `git diff --check` - `cargo test --manifest-path packages/paperclip-runner/runner/Cargo.toml -p paperclip-runner-core --lib --locked` (161 tests) - focused ACPX provider-event tests (10 tests) - The rebased PR changes 92 files. `pnpm-lock.yaml` is unchanged. I did not run paid live provider jobs or provision AWS resources. Those checks need credentials and can create cost. ## Risks The paid workflows can create provider cost. They require an allowlisted original and triggering actor, the protected `runner-e2e-paid` environment, explicit opt-in variables, and cost limits. The four provider credentials exist only in that master-only environment, which requires allowlisted reviewer approval and disables administrator bypass; repository and organization Actions scopes contain no copies. Provider usage arrives after a billable request, so the live guard cannot prevent one request from crossing a threshold. It interrupts immediately on the first reported threshold hit and permits no continuation. Visual evidence can contain secrets rendered as pixels. PNG/WebM remain only in access-controlled workflow artifacts; SVG and per-attempt XML are excluded, and S3/Pages receive a pruned structured dashboard. The AWS scripts can create cloud resources. They use explicit commands, least-privilege roles, KMS encryption, saved nonsecret metadata, and explicit teardown. This pull request does not enable the experimental native runner for existing instances. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex with GPT-5. The model used extended reasoning, tool use, code execution, and parallel subagents. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
271 lines
13 KiB
TypeScript
271 lines
13 KiB
TypeScript
import { CAPABILITY_CANONICAL_OPERATIONS } from "../catalog/canonical-operations.js";
|
|
import { capabilityInventoryCounts } from "../generated/capability-contract.js";
|
|
import { RUNNER_WORKFLOW_DIMENSION_KEYS, type RunnerWorkflowDimensionKey } from "./workflow-contracts.js";
|
|
import { RUNNER_WORKFLOW_CATALOG } from "./workflow-catalog.js";
|
|
import type { RunnerWorkflowMatrixEntry } from "./workflow-harness.js";
|
|
import type { StressTraceabilitySummary } from "./workflow-traceability.js";
|
|
|
|
export const RUNNER_WORKFLOW_REPORT_SCHEMA = "paperclip.runner.workflow-eval-report.v1" as const;
|
|
|
|
export interface RunnerWorkflowReportBundle {
|
|
id: string;
|
|
runnerVersion: string;
|
|
runnerBuild?: string;
|
|
promptPolicyId: string;
|
|
providerVersions: Record<string, string>;
|
|
scheduleSeed?: string;
|
|
}
|
|
|
|
export interface RunnerWorkflowEvalReport {
|
|
schema: typeof RUNNER_WORKFLOW_REPORT_SCHEMA;
|
|
generatedAt: string;
|
|
source: "deterministic" | "live" | "chaos";
|
|
bundle: RunnerWorkflowReportBundle;
|
|
results: RunnerWorkflowMatrixEntry[];
|
|
aggregate: {
|
|
executions: number;
|
|
scoreable: number;
|
|
passed: number;
|
|
candidateFailures: number;
|
|
infrastructureFailures: number;
|
|
skipped: number;
|
|
meanOverall: number | null;
|
|
dimensionMeans: Record<RunnerWorkflowDimensionKey, number | null>;
|
|
};
|
|
coverage: {
|
|
canonicalOperations: number;
|
|
capabilityCases: number;
|
|
workflows: number;
|
|
stressFindings?: number;
|
|
stressExclusions?: number;
|
|
operations: Array<{ operationId: string; capabilityCovered: true; workflowIds: string[] }>;
|
|
composedWorkflows: Array<{ workflowId: string; providerCount: number; operationIds: string[] }>;
|
|
};
|
|
}
|
|
|
|
function round(value: number): number {
|
|
return Math.round(value * 1_000) / 1_000;
|
|
}
|
|
|
|
export function buildRunnerWorkflowEvalReport(input: {
|
|
source: RunnerWorkflowEvalReport["source"];
|
|
bundle: RunnerWorkflowReportBundle;
|
|
results: readonly RunnerWorkflowMatrixEntry[];
|
|
generatedAt?: string;
|
|
traceability?: StressTraceabilitySummary;
|
|
}): RunnerWorkflowEvalReport {
|
|
const results = [...input.results];
|
|
const scoreable = results.filter((entry) => entry.scorecard.overall.score !== null);
|
|
const dimensionMeans = {} as Record<RunnerWorkflowDimensionKey, number | null>;
|
|
for (const dimension of RUNNER_WORKFLOW_DIMENSION_KEYS) {
|
|
const values = scoreable.flatMap((entry) => {
|
|
const value = entry.scorecard.dimensions[dimension].score;
|
|
return value === null ? [] : [value];
|
|
});
|
|
dimensionMeans[dimension] = values.length === 0 ? null : round(values.reduce((sum, value) => sum + value, 0) / values.length);
|
|
}
|
|
const overallValues = scoreable.flatMap((entry) => entry.scorecard.overall.score === null ? [] : [entry.scorecard.overall.score]);
|
|
return {
|
|
schema: RUNNER_WORKFLOW_REPORT_SCHEMA,
|
|
generatedAt: input.generatedAt ?? new Date().toISOString(),
|
|
source: input.source,
|
|
bundle: input.bundle,
|
|
results,
|
|
aggregate: {
|
|
executions: results.length,
|
|
scoreable: scoreable.length,
|
|
passed: scoreable.filter((entry) => entry.scorecard.overall.passed).length,
|
|
candidateFailures: results.filter((entry) => entry.observation.classification === "candidate_failure").length,
|
|
infrastructureFailures: results.filter((entry) => entry.observation.classification === "infrastructure_failure").length,
|
|
skipped: results.filter((entry) => entry.observation.classification === "skipped").length,
|
|
meanOverall: overallValues.length === 0 ? null : round(overallValues.reduce((sum, value) => sum + value, 0) / overallValues.length),
|
|
dimensionMeans,
|
|
},
|
|
coverage: {
|
|
canonicalOperations: CAPABILITY_CANONICAL_OPERATIONS.length,
|
|
capabilityCases: capabilityInventoryCounts.evalCases,
|
|
workflows: new Set(results.map((entry) => entry.scenarioId)).size,
|
|
operations: CAPABILITY_CANONICAL_OPERATIONS.map((operation) => ({
|
|
operationId: operation.operationId,
|
|
capabilityCovered: true as const,
|
|
workflowIds: RUNNER_WORKFLOW_CATALOG.filter((evalCase) =>
|
|
evalCase.assertions.requiredOperationIds?.includes(operation.operationId))
|
|
.map((evalCase) => evalCase.id),
|
|
})),
|
|
composedWorkflows: RUNNER_WORKFLOW_CATALOG.map((evalCase) => ({
|
|
workflowId: evalCase.id,
|
|
providerCount: evalCase.providers.length,
|
|
operationIds: evalCase.assertions.requiredOperationIds ?? [],
|
|
})),
|
|
...(input.traceability === undefined ? {} : {
|
|
stressFindings: input.traceability.findings,
|
|
stressExclusions: input.traceability.exclusions,
|
|
}),
|
|
},
|
|
};
|
|
}
|
|
|
|
export function renderRunnerWorkflowMarkdown(report: RunnerWorkflowEvalReport): string {
|
|
const lines = [
|
|
`# Runner workflow evals — ${report.bundle.id}`,
|
|
"",
|
|
`- Source: ${report.source}`,
|
|
`- Executions: ${report.aggregate.executions} · scoreable ${report.aggregate.scoreable} · passed ${report.aggregate.passed}`,
|
|
`- Candidate failures: ${report.aggregate.candidateFailures} · infrastructure failures ${report.aggregate.infrastructureFailures} · skipped ${report.aggregate.skipped}`,
|
|
`- Coverage: ${report.coverage.canonicalOperations} operations · ${report.coverage.capabilityCases} capability cases · ${report.coverage.workflows} workflows${report.coverage.stressFindings === undefined ? "" : ` · ${report.coverage.stressFindings} stress findings`}`,
|
|
"",
|
|
"## Dimension means",
|
|
"",
|
|
...RUNNER_WORKFLOW_DIMENSION_KEYS.map((dimension) => `- ${dimension}: ${report.aggregate.dimensionMeans[dimension] ?? "not scored"}`),
|
|
"",
|
|
"## Combined operation and workflow coverage",
|
|
"",
|
|
"| operation | capability cases | composed workflows |",
|
|
"| --- | --- | --- |",
|
|
...report.coverage.operations.map((operation) => `| ${operation.operationId} | covered | ${operation.workflowIds.join(", ") || "—"} |`),
|
|
"",
|
|
"## Executions",
|
|
"",
|
|
"| workflow | candidate | classification | gate | score | result |",
|
|
"| --- | --- | --- | --- | --- | --- |",
|
|
...report.results.map((entry) => {
|
|
const overall = entry.scorecard.overall;
|
|
const result = overall.passed === null ? "not scored" : overall.passed ? "PASS" : "FAIL";
|
|
return `| ${entry.scenarioId} | ${entry.candidateId} | ${entry.observation.classification} | ${overall.gatePassed ?? "—"} | ${overall.score === null ? "—" : round(overall.score)} | ${result} |`;
|
|
}),
|
|
"",
|
|
];
|
|
return `${lines.join("\n")}\n`;
|
|
}
|
|
|
|
function xml(value: string): string {
|
|
return value.replaceAll("&", "&").replaceAll("<", "<").replaceAll(">", ">").replaceAll('"', """);
|
|
}
|
|
|
|
export function renderRunnerWorkflowJUnit(report: RunnerWorkflowEvalReport): string {
|
|
const failures = report.results.filter((entry) => entry.scorecard.overall.passed === false).length;
|
|
const skipped = report.results.filter((entry) => entry.scorecard.overall.passed === null).length;
|
|
const cases = report.results.map((entry) => {
|
|
const name = `${entry.scenarioId}/${entry.candidateId}`;
|
|
if (entry.scorecard.overall.passed === null) {
|
|
return ` <testcase classname="runner.workflow" name="${xml(name)}"><skipped message="${xml(entry.observation.failure?.message ?? "not scoreable")}" /></testcase>`;
|
|
}
|
|
if (entry.scorecard.overall.passed === false) {
|
|
const reasons = RUNNER_WORKFLOW_DIMENSION_KEYS.flatMap((dimension) => entry.scorecard.dimensions[dimension].reasons).join("; ");
|
|
return ` <testcase classname="runner.workflow" name="${xml(name)}"><failure message="workflow eval failed">${xml(reasons)}</failure></testcase>`;
|
|
}
|
|
return ` <testcase classname="runner.workflow" name="${xml(name)}" />`;
|
|
});
|
|
return [
|
|
"<?xml version=\"1.0\" encoding=\"UTF-8\"?>",
|
|
`<testsuite name="paperclip-runner-workflows" tests="${report.results.length}" failures="${failures}" skipped="${skipped}">`,
|
|
...cases,
|
|
"</testsuite>",
|
|
"",
|
|
].join("\n");
|
|
}
|
|
|
|
export interface RunnerWorkflowReportComparison {
|
|
compatible: boolean;
|
|
reason?: string;
|
|
currentBundleId: string;
|
|
previousBundleId: string;
|
|
passRateDelta?: number;
|
|
overallDelta?: number;
|
|
}
|
|
|
|
export function compareRunnerWorkflowReports(
|
|
current: RunnerWorkflowEvalReport,
|
|
previous: RunnerWorkflowEvalReport,
|
|
): RunnerWorkflowReportComparison {
|
|
if (current.bundle.id !== previous.bundle.id) {
|
|
return {
|
|
compatible: false,
|
|
reason: "bundle ids differ; provider fixture, runner, or prompt-policy inputs changed",
|
|
currentBundleId: current.bundle.id,
|
|
previousBundleId: previous.bundle.id,
|
|
};
|
|
}
|
|
const rate = (report: RunnerWorkflowEvalReport): number => report.aggregate.scoreable === 0 ? 0 : report.aggregate.passed / report.aggregate.scoreable;
|
|
return {
|
|
compatible: true,
|
|
currentBundleId: current.bundle.id,
|
|
previousBundleId: previous.bundle.id,
|
|
passRateDelta: round(rate(current) - rate(previous)),
|
|
overallDelta: round((current.aggregate.meanOverall ?? 0) - (previous.aggregate.meanOverall ?? 0)),
|
|
};
|
|
}
|
|
|
|
export interface RunnerWorkflowAlert {
|
|
severity: "warning" | "critical";
|
|
code: "safety_failure" | "consecutive_failures" | "success_rate_regression" | "latency_regression" | "cost_regression";
|
|
message: string;
|
|
}
|
|
|
|
function percentile95(values: number[]): number | null {
|
|
if (values.length === 0) return null;
|
|
const sorted = [...values].sort((a, b) => a - b);
|
|
return sorted[Math.ceil(sorted.length * 0.95) - 1] ?? null;
|
|
}
|
|
|
|
export function runnerWorkflowAlerts(input: {
|
|
current: RunnerWorkflowEvalReport;
|
|
history: readonly RunnerWorkflowEvalReport[];
|
|
baselineReady: boolean;
|
|
}): RunnerWorkflowAlert[] {
|
|
if (!input.baselineReady) return [];
|
|
const compatible = input.history.filter((report) => report.bundle.id === input.current.bundle.id).slice(-7);
|
|
const alerts: RunnerWorkflowAlert[] = [];
|
|
const safetyFailures = input.current.results.filter((entry) =>
|
|
entry.scorecard.dimensions.hard_invariants.passed === false
|
|
|| entry.scorecard.dimensions.lifecycle_integrity.passed === false);
|
|
if (safetyFailures.length > 0) {
|
|
alerts.push({ severity: "critical", code: "safety_failure", message: `${safetyFailures.length} execution(s) failed a hard or lifecycle invariant` });
|
|
}
|
|
for (const result of input.current.results) {
|
|
if (result.scorecard.overall.passed !== false) continue;
|
|
const priorFailures = compatible.slice(-2).every((report) => report.results.some((entry) =>
|
|
entry.scenarioId === result.scenarioId
|
|
&& entry.candidateId === result.candidateId
|
|
&& entry.scorecard.overall.passed === false));
|
|
if (compatible.length >= 2 && priorFailures) {
|
|
alerts.push({ severity: "warning", code: "consecutive_failures", message: `${result.scenarioId}/${result.candidateId} failed three consecutive reports` });
|
|
}
|
|
}
|
|
const baselineScoreable = compatible.reduce((sum, report) => sum + report.aggregate.scoreable, 0);
|
|
const baselinePassed = compatible.reduce((sum, report) => sum + report.aggregate.passed, 0);
|
|
if (baselineScoreable > 0 && input.current.aggregate.scoreable > 0) {
|
|
const baselineRate = baselinePassed / baselineScoreable;
|
|
const currentRate = input.current.aggregate.passed / input.current.aggregate.scoreable;
|
|
if (baselineRate - currentRate >= 0.20) {
|
|
alerts.push({ severity: "warning", code: "success_rate_regression", message: `success rate dropped ${Math.round((baselineRate - currentRate) * 100)} percentage points` });
|
|
}
|
|
}
|
|
const metric = (reports: readonly RunnerWorkflowEvalReport[], key: "settlementMs" | "costUsd"): number[] => reports.flatMap((report) =>
|
|
report.results.flatMap((entry) => {
|
|
const value = key === "settlementMs" ? entry.observation.metrics.settlementMs : entry.observation.metrics.costUsd;
|
|
return value === undefined ? [] : [value];
|
|
}));
|
|
const currentLatency = percentile95(metric([input.current], "settlementMs"));
|
|
const baselineLatency = percentile95(metric(compatible, "settlementMs"));
|
|
if (currentLatency !== null && baselineLatency !== null && currentLatency > baselineLatency * 1.25) {
|
|
alerts.push({ severity: "warning", code: "latency_regression", message: `p95 settlement latency rose more than 25% (${baselineLatency}ms → ${currentLatency}ms)` });
|
|
}
|
|
const currentCost = percentile95(metric([input.current], "costUsd"));
|
|
const baselineCost = percentile95(metric(compatible, "costUsd"));
|
|
if (currentCost !== null && baselineCost !== null && baselineCost > 0 && currentCost > baselineCost * 1.25) {
|
|
alerts.push({ severity: "warning", code: "cost_regression", message: `p95 cost rose more than 25% ($${baselineCost} → $${currentCost})` });
|
|
}
|
|
return alerts;
|
|
}
|
|
|
|
export function renderRunnerWorkflowGitHubSummary(
|
|
report: RunnerWorkflowEvalReport,
|
|
alerts: readonly RunnerWorkflowAlert[] = [],
|
|
): string {
|
|
const alertLines = alerts.length === 0
|
|
? ["No active workflow-eval regression alerts."]
|
|
: alerts.map((alert) => `- ${alert.severity.toUpperCase()} ${alert.code}: ${alert.message}`);
|
|
return `${renderRunnerWorkflowMarkdown(report)}\n## Alerts\n\n${alertLines.join("\n")}\n`;
|
|
}
|