Files
PaperClipAI/tests/runner-e2e/daytona-image.test.ts
Dotta af3023f1e3 fix(runner): repair paid provider startup paths (#12769)
## Thinking Path

> - Paperclip manages AI agents that perform work.
> - Paperclip Runner connects durable task runs to local provider
processes.
> - The full-stack paid matrix exposed failures after the runner
integrity repair.
> - Verified JavaScript entrypoints lost their relative module graph
when Linux executed them through descriptor paths.
> - Returned provider startup errors also remained pending and became
indeterminate after recovery.
> - Sparse Codex tool lifecycle events lost the `write_document`
identity before task transcript projection.
> - This pull request repairs those three boundaries and makes the
structured-question fixture deterministic.
> - The benefit is repeatable provider startup, exact failure replay,
and correct inline Plan placement.

## Linked Issues or Issue Description

Refs #12721 and #12700.

**What happened?**

The paid runner matrix failed ACPX and OpenCode startup before provider
session creation. The runner journal then replaced the original startup
error with an indeterminate recovery result. Native Codex saved a Plan
but rendered it only as a fallback card. A legacy Claude waiting reply
could also echo the reserved terminal marker before the answer arrived.

**Expected behavior**

Verified JavaScript providers must start from immutable
descriptor-backed artifacts. Returned startup failures must persist as
terminal failed command results. Native tool lifecycle updates must
preserve the `write_document` boundary. Pre-answer fixture output must
not contain the reserved terminal marker.

**Steps to reproduce**

1. Run the local provider cells in the Runner Full-Stack E2E workflow.
2. Observe ACPX and OpenCode fail during `session.open` before provider
execution.
3. Observe recovery report `execution_indeterminate` instead of the
original startup error.
4. Run the native Codex Plan cell and observe the fallback Plan card
after the tool activity row.
5. Run the legacy Claude structured-question resume cell and observe an
early marker echo in waiting prose.

**Paperclip version or commit**

`0f9452101740835ce0b1488a204bf48acd5bafc3`

**Deployment mode**

Local development with the paid GitHub Actions acceptance workflow.

## What Changed

- Bundle the ACPX sidecar and OpenCode proxy as self-contained Node ESM
entrypoints before hashing and verified descriptor launch.
- Anchor ACPX dynamic provider package resolution at a
controller-derived provider-pack root and keep that root out of the
provider child environment.
- Persist executor-returned startup errors as redacted durable failed
command results while retaining indeterminate recovery for true process
death.
- Coalesce sparse native tool items by stable ID so a late
`write_document` name, input, and result reach the transcript boundary
once.
- Forbid the structured-question fixture from spelling or announcing its
reserved terminal marker before the user answers.

## Verification

- Rust and TypeScript regression tests cover durable failed replay, true
crash ambiguity, bundle closure, package-root derivation, environment
filtering, exact Codex tool lifecycle coalescing, and prompt
determinism.
- Local execution is intentionally limited to formatters and static diff
checks. GitHub Actions will run tests, type checks, builds, and security
checks.
- After ordinary CI is green, scoped paid cells will validate one ACPX
launch, one OpenCode launch, native Codex Plan projection, and legacy
Claude structured resume before a complete matrix rerun.
- Prior failing matrix:
https://github.com/paperclipai/paperclip/actions/runs/33682434315

## Risks

- Bundling changes the bytes covered by provider launch hashes.
Provider-pack generation already hashes the final built files.
- ACPX still loads qualified provider packages dynamically. The
controller supplies a normalized package root, while existing version,
digest, path, and descriptor checks remain active.
- Durable `failed` is terminal. Replays return the same redacted result
and do not execute the provider effect twice.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

OpenAI Codex based on GPT-5 with agentic reasoning, repository
inspection, code editing, Git, parallel subagents, and GitHub Actions
coordination. The exact deployed snapshot and context-window size are
not exposed to this task.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either linked related public work or described the bug in
this PR
- [x] I have not referenced internal or instance-local Paperclip issues
or links
- [x] My branch name describes the change and contains no internal
ticket id
- [ ] I have run tests locally and they pass (intentionally deferred to
GitHub Actions)
- [x] I have added or updated tests where applicable
- [x] No documentation change is required for this runtime repair
- [x] I have considered and documented the risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge
2026-09-04 07:58:44 -05:00

336 lines
13 KiB
TypeScript

import { mkdtemp, mkdir, readFile, rm, writeFile } from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
import { describe, expect, it } from "vitest";
import {
computeDaytonaImageContentId,
DAYTONA_IMAGE_DOCKERFILE_PATH,
DAYTONA_IMAGE_INPUT_PATHS,
extractDaytonaBaseImages,
extractDaytonaDockerfileFrontendDigest,
} from "./daytona-image-content.js";
const repositoryRoot = path.resolve(import.meta.dirname, "../..");
describe("runner E2E Daytona image contract", () => {
it("builds runnerd and the provider pack and verifies every required transport", async () => {
const [dockerfile, dockerignore, workflow] = await Promise.all([
readFile(
path.join(repositoryRoot, "docker/daytona-runner/Dockerfile"),
"utf8",
),
readFile(path.join(repositoryRoot, ".dockerignore"), "utf8"),
readFile(
path.join(
repositoryRoot,
".github/workflows/runner-full-stack-e2e.yml",
),
"utf8",
),
]);
expect(dockerfile).toContain("--bin paperclip-runnerd");
expect(dockerfile).toContain("build-provider-pack.mjs /provider-pack");
expect(dockerfile).toContain(
"/opt/paperclip-runner/provider-pack/provider-pack.json",
);
expect(dockerfile).toContain(
"${PAPERCLIP_RUNNER_PROVIDER_PACK_ROOT}/node_modules/.bin",
);
for (const command of ["acpx", "claude-agent-acp", "codex-acp"]) {
expect(dockerfile).toContain(command);
}
for (const transport of ["dial_ws_loopback", "dial_wss", "listen_ws"]) {
expect(dockerfile).toContain(transport);
}
expect(dockerfile).toContain(
'metadata="$(paperclip-runnerd --build-metadata)"',
);
expect(dockerfile).toContain("provider-pack.json");
expect(dockerfile).toContain("io.paperclip.runner.content-id");
expect(dockerfile).toContain("org.opencontainers.image.revision");
expect(extractDaytonaDockerfileFrontendDigest(dockerfile)).toBe(
"sha256:a57df69d0ea827fb7266491f2813635de6f17269be881f696fbfdf2d83dda33e",
);
expect(extractDaytonaBaseImages(dockerfile)).toEqual([
"rust:1.97-bookworm@sha256:408fe88047cef61a2087653b0c5255fa51c0f2d6d94ddedd7a2562a9b91a46f6",
"node:24-bookworm@sha256:9137a20e25879e0b557227b57e3ee4e9af4bde29eb3db66134cd1723e84f830b",
"daytonaio/sandbox:0.8.0@sha256:eadf88e4391072b7ad4bed27d9cadfc9fe9d8ed375d9219d34c2ccb518f213e3",
]);
expect(dockerignore).toContain("**/node_modules");
expect(dockerignore).toContain("packages/paperclip-runner/dist");
expect(dockerignore).toContain("packages/paperclip-runner/runner/target");
for (const developmentOnlyInput of [
"packages/paperclip-runner/devtools",
"packages/paperclip-runner/docs",
"packages/paperclip-runner/examples",
"packages/paperclip-runner/test",
"packages/paperclip-runner/test-fixtures",
"packages/paperclip-runner/test-support",
"packages/paperclip-runner/**/*.md",
"packages/paperclip-runner/**/*.test.ts",
"packages/paperclip-runner/runner/crates/*/tests",
"packages/paperclip-runner/scripts/*-smoke.mjs",
]) {
expect(dockerignore).toContain(developmentOnlyInput);
}
expect(workflow).toContain("--platform linux/amd64");
expect(workflow).toContain(
"Compute Daytona image content ID with pinned bases",
);
expect(workflow).toContain(
"e2e-content-${{ needs.catalog.outputs.daytona_image_content_id }}",
);
expect(workflow).toContain(
'--build-arg "PAPERCLIP_RUNNER_CONTENT_ID=${IMAGE_CONTENT_ID}"',
);
expect(workflow).not.toContain("e2e-git-${{ github.sha }}");
expect(workflow).toContain("cosign sign --yes");
expect(workflow).toContain("docker logout ghcr.io");
expect(workflow).toContain(`docker buildx imagetools inspect "$immutable"`);
expect(workflow).toContain(`--format '{{json .Image}}'`);
expect(workflow).not.toContain(`docker --config "$anonymous_config" pull`);
expect(workflow).not.toContain("docker image inspect");
expect(workflow).not.toContain("docker buildx prune --all --force");
expect(workflow).not.toContain("docker system prune --all --force");
expect(workflow).toContain('.architecture == "amd64"');
expect(workflow).toContain('.os == "linux"');
expect(workflow).toContain('.config.User == "daytona"');
expect(workflow).toContain("PAPERCLIP_RUNNER_PROVIDER_PACK_ROOT=");
expect(workflow).toContain(
"node packages/paperclip-runner/scripts/build-provider-pack.mjs packages/paperclip-runner/provider-pack",
);
expect(workflow).toContain(
"PAPERCLIP_RUNNER_REMOTE_PROVIDER_PACK_PATH: ${{ github.workspace }}/packages/paperclip-runner/provider-pack",
);
expect(workflow).toContain(
"PAPERCLIP_RUNNER_SOURCE_REVISION: ${{ needs.daytona_image.outputs.source_revision }}",
);
expect(workflow.indexOf("cosign verify")).toBeLessThan(
workflow.indexOf("docker logout ghcr.io"),
);
expect(workflow.indexOf("docker logout ghcr.io")).toBeLessThan(
workflow.indexOf(`--format '{{json .Image}}'`),
);
});
it("hashes the audited image dependency closure rather than the repository revision", async () => {
for (const requiredPath of [
".dockerignore",
"docker/daytona-runner/Dockerfile",
"pnpm-lock.yaml",
"patches",
"packages/paperclip-eval-kernel",
"packages/paperclip-runner",
]) {
expect(DAYTONA_IMAGE_INPUT_PATHS).toContain(requiredPath);
}
expect(DAYTONA_IMAGE_DOCKERFILE_PATH).toBe(
"docker/daytona-runner/Dockerfile",
);
const contentId = await computeDaytonaImageContentId();
expect(contentId).toMatch(/^[0-9a-f]{64}$/);
});
it("changes only when an image input, frontend, base, or platform changes", async () => {
const root = await mkdtemp(
path.join(tmpdir(), "paperclip-daytona-image-id-"),
);
try {
await mkdir(path.join(root, "image-input"));
await writeFile(
path.join(root, "image-input", "runner.ts"),
"version one\n",
);
const baseline = await computeDaytonaImageContentId({
repositoryRoot: root,
inputPaths: ["image-input"],
baseImages: [`example.test/base:1@sha256:${"a".repeat(64)}`],
frontendDigest: `sha256:${"c".repeat(64)}`,
});
expect(
await computeDaytonaImageContentId({
repositoryRoot: root,
inputPaths: ["image-input"],
baseImages: [`example.test/base:1@sha256:${"b".repeat(64)}`],
frontendDigest: `sha256:${"c".repeat(64)}`,
}),
).not.toBe(baseline);
expect(
await computeDaytonaImageContentId({
repositoryRoot: root,
inputPaths: ["image-input"],
baseImages: [`example.test/base:1@sha256:${"a".repeat(64)}`],
frontendDigest: `sha256:${"d".repeat(64)}`,
}),
).not.toBe(baseline);
await writeFile(
path.join(root, "unrelated.txt"),
"does not enter the image\n",
);
expect(
await computeDaytonaImageContentId({
repositoryRoot: root,
inputPaths: ["image-input"],
baseImages: [`example.test/base:1@sha256:${"a".repeat(64)}`],
frontendDigest: `sha256:${"c".repeat(64)}`,
}),
).toBe(baseline);
await writeFile(
path.join(root, "image-input", "runner.ts"),
"version two\n",
);
expect(
await computeDaytonaImageContentId({
repositoryRoot: root,
inputPaths: ["image-input"],
baseImages: [`example.test/base:1@sha256:${"a".repeat(64)}`],
frontendDigest: `sha256:${"c".repeat(64)}`,
}),
).not.toBe(baseline);
expect(
await computeDaytonaImageContentId({
repositoryRoot: root,
inputPaths: ["image-input"],
platform: "linux/arm64",
baseImages: [`example.test/base:1@sha256:${"a".repeat(64)}`],
frontendDigest: `sha256:${"c".repeat(64)}`,
}),
).not.toBe(baseline);
} finally {
await rm(root, { recursive: true, force: true });
}
});
it("reuses the image for runner-only tests and documentation", async () => {
const root = await mkdtemp(
path.join(tmpdir(), "paperclip-daytona-runner-development-inputs-"),
);
const options = {
repositoryRoot: root,
inputPaths: ["packages/paperclip-runner"],
baseImages: [`example.test/base:1@sha256:${"a".repeat(64)}`],
frontendDigest: `sha256:${"c".repeat(64)}`,
} as const;
try {
const runnerRoot = path.join(root, "packages/paperclip-runner");
await mkdir(path.join(runnerRoot, "src/live"), { recursive: true });
await mkdir(path.join(runnerRoot, "docs"), { recursive: true });
await mkdir(path.join(runnerRoot, "spec"), { recursive: true });
await mkdir(path.join(runnerRoot, "scripts"), { recursive: true });
await mkdir(path.join(runnerRoot, "test-fixtures"), { recursive: true });
await mkdir(path.join(runnerRoot, "runner/crates/runner-core/src"), {
recursive: true,
});
await mkdir(path.join(runnerRoot, "runner/crates/runner-core/tests"), {
recursive: true,
});
await writeFile(
path.join(runnerRoot, "src/live/transport.ts"),
"export const runtime = 'one';\n",
);
await writeFile(
path.join(runnerRoot, "runner/crates/runner-core/src/lib.rs"),
'pub const RUNTIME: &str = "one";\n',
);
await writeFile(path.join(runnerRoot, "README.md"), "first readme\n");
await writeFile(
path.join(runnerRoot, "docs/local-runner.md"),
"first documentation\n",
);
await writeFile(
path.join(runnerRoot, "spec/architecture.md"),
"first architecture note\n",
);
await writeFile(
path.join(runnerRoot, "src/live/transport.test.ts"),
"first TypeScript test\n",
);
await writeFile(
path.join(runnerRoot, "test-fixtures/provider.json"),
'{"fixture":"one"}\n',
);
await writeFile(
path.join(runnerRoot, "scripts/capability-clean-room-smoke.mjs"),
"first smoke probe\n",
);
await writeFile(
path.join(runnerRoot, "runner/crates/runner-core/tests/recovery.rs"),
"// first Rust integration test\n",
);
const baseline = await computeDaytonaImageContentId(options);
await writeFile(path.join(runnerRoot, "README.md"), "second readme\n");
await writeFile(
path.join(runnerRoot, "docs/local-runner.md"),
"second documentation\n",
);
await writeFile(
path.join(runnerRoot, "spec/architecture.md"),
"second architecture note\n",
);
await writeFile(
path.join(runnerRoot, "src/live/transport.test.ts"),
"second TypeScript test\n",
);
await writeFile(
path.join(runnerRoot, "test-fixtures/provider.json"),
'{"fixture":"two"}\n',
);
await writeFile(
path.join(runnerRoot, "scripts/capability-clean-room-smoke.mjs"),
"second smoke probe\n",
);
await writeFile(
path.join(runnerRoot, "runner/crates/runner-core/tests/recovery.rs"),
"// second Rust integration test\n",
);
expect(await computeDaytonaImageContentId(options)).toBe(baseline);
await writeFile(
path.join(runnerRoot, "src/live/transport.ts"),
"export const runtime = 'two';\n",
);
expect(await computeDaytonaImageContentId(options)).not.toBe(baseline);
await writeFile(
path.join(runnerRoot, "src/live/transport.ts"),
"export const runtime = 'one';\n",
);
await writeFile(
path.join(runnerRoot, "runner/crates/runner-core/src/lib.rs"),
'pub const RUNTIME: &str = "two";\n',
);
expect(await computeDaytonaImageContentId(options)).not.toBe(baseline);
} finally {
await rm(root, { recursive: true, force: true });
}
});
it("rejects mutable Docker base references", () => {
expect(() => extractDaytonaBaseImages("FROM node:24-bookworm\n")).toThrow(
"must use an immutable sha256 digest",
);
});
it("rejects a mutable or missing Dockerfile syntax frontend", async () => {
expect(() =>
extractDaytonaDockerfileFrontendDigest(
"# syntax=docker/dockerfile:1.7\nFROM scratch\n",
),
).toThrow("must pin its syntax frontend");
expect(() =>
extractDaytonaDockerfileFrontendDigest("FROM scratch\n"),
).toThrow("must pin its syntax frontend");
await expect(
computeDaytonaImageContentId({
inputPaths: [],
baseImages: [`example.test/base:1@sha256:${"a".repeat(64)}`],
frontendDigest: "sha256:mutable",
}),
).rejects.toThrow("must use an immutable sha256 digest");
});
});