mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-10 03:08:10 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The runner package already provides the production protocol and execution spine. > - Contributors still need stable SDK surfaces, deterministic test tools, and local inspection tools. > - Those surfaces share generated contracts and must change as one package boundary. > - This pull request adds the package-local SDK, labs, examples, and drift checks. > - The benefit is a reviewable developer platform that does not change application execution selection. ## Linked Issues or Issue Description **Subsystem affected** `packages/paperclip-runner` — runner SDK, conformance tools, and developer tooling. **Problem or motivation** The production runner spine is present, but package consumers cannot build deterministic integrations, inspect sessions, or verify provider-neutral behavior through supported surfaces. **Proposed solution** Add browser, React, standalone, live-session, scenario, conformance, and evaluation surfaces. Add generated contract inventories and package-local verification scripts. Keep production application routing unchanged. **Alternatives considered** We considered splitting each generated catalog, SDK surface, and demo into separate pull requests. Those changes share exports, fixtures, and drift gates. Splitting them would create intermediate package states that do not build. **Roadmap alignment** No overlapping item appears in `ROADMAP.md`. This work extends the runner package that is already on `master`. ## What Changed - Add browser, React, standalone, live-session, and issue-thread SDK surfaces. - Add deterministic mock control-plane, scenario, conformance, replay, and evaluation tools. - Add bounded Codex, OpenCode, and ACPX development transports and fixtures. - Keep deferred managed-provider execution fail-closed. Persisted compatibility data remains readable. - Add generated capability inventories with their source files and drift checks. - Add examples, package documentation, browser checks, and clean-consumer checks. - Preserve the reviewed protocol bounds, replay compatibility aliases, process environment isolation, and semantic redaction limits. - Update the ACPX package patch that the existing workspace patch registry already tracks. - Do not change `pnpm-lock.yaml`, repository workflows, server runtime selection, or the application UI. ## Verification GitHub Actions is the verification authority for this pull request. The repository CI, package TypeScript and Rust checks, package tests, generated-output drift checks, browser checks, security scans, and Greptile review must pass on the exact head. Local test suites were not run because this series uses parallel GitHub Actions for verification. ## Risks This is a large greenfield package change. The main risks are public export drift, generated-output drift, and optional React consumer compatibility. Package boundary checks, clean-consumer checks, and browser tests cover those risks. Production adapter selection and server execution are outside this pull request. ## Stack 1. **This PR:** runner SDK and developer tooling. 2. [Codex production server integration](https://github.com/paperclipai/paperclip/pull/12616). 3. [Provider-neutral task-thread UI](https://github.com/paperclipai/paperclip/pull/12617). ## Model Used OpenAI Codex, GPT-5, high-reasoning mode, with tool use and code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have described the issue in-PR following the feature request template - [x] I have not referenced internal/instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal Paperclip ticket id - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
215 lines
6.8 KiB
JavaScript
215 lines
6.8 KiB
JavaScript
import { execFile, spawnSync } from "node:child_process";
|
|
import { existsSync } from "node:fs";
|
|
import { readFile } from "node:fs/promises";
|
|
import { dirname, relative, resolve } from "node:path";
|
|
import { promisify } from "node:util";
|
|
|
|
import { defaultPackageRoot, findSpecifiers } from "./forbidden-imports.mjs";
|
|
|
|
export { defaultPackageRoot };
|
|
|
|
const execFileAsync = promisify(execFile);
|
|
|
|
const SCANNED_EXTENSIONS = new Set([".cjs", ".js", ".jsx", ".mjs", ".ts", ".tsx"]);
|
|
// TypeScript resolves an ESM ".js" specifier against its ".ts" source sibling,
|
|
// so a tracked import may legitimately name a file that never exists on disk.
|
|
const JS_TO_SOURCE_EXTENSIONS = new Map([
|
|
[".js", [".ts", ".tsx", ".d.ts"]],
|
|
[".jsx", [".tsx", ".d.ts"]],
|
|
[".mjs", [".mts", ".d.mts"]],
|
|
[".cjs", [".cts", ".d.cts"]],
|
|
]);
|
|
const EXTENSIONLESS_CANDIDATES = [
|
|
".ts",
|
|
".tsx",
|
|
".mts",
|
|
".cts",
|
|
".d.ts",
|
|
".js",
|
|
".jsx",
|
|
".mjs",
|
|
".cjs",
|
|
"/index.ts",
|
|
"/index.tsx",
|
|
"/index.js",
|
|
"/index.mjs",
|
|
];
|
|
|
|
function extension(path) {
|
|
const match = path.match(/\.[^./\\]+$/);
|
|
return match?.[0] ?? "";
|
|
}
|
|
|
|
function isScannable(path) {
|
|
return SCANNED_EXTENSIONS.has(extension(path));
|
|
}
|
|
|
|
function isRelative(specifier) {
|
|
return specifier.startsWith("./") || specifier.startsWith("../");
|
|
}
|
|
|
|
/**
|
|
* Every on-disk path a bundler or `tsc` could pick for this specifier. The
|
|
* check only needs one of them to be tracked.
|
|
*/
|
|
function resolutionCandidates(file, specifier) {
|
|
const base = resolve(dirname(file), specifier);
|
|
const specifierExtension = extension(specifier);
|
|
const sourceExtensions = JS_TO_SOURCE_EXTENSIONS.get(specifierExtension);
|
|
if (sourceExtensions !== undefined) {
|
|
const withoutExtension = base.slice(0, base.length - specifierExtension.length);
|
|
return [base, ...sourceExtensions.map((suffix) => `${withoutExtension}${suffix}`)];
|
|
}
|
|
if (specifierExtension !== "") {
|
|
return [base];
|
|
}
|
|
return [base, ...EXTENSIONLESS_CANDIDATES.map((suffix) => `${base}${suffix}`)];
|
|
}
|
|
|
|
/**
|
|
* Build output is untracked on purpose, so an import that points into an
|
|
* ignored path is not evidence of a missing source file.
|
|
*/
|
|
async function listIgnoredPaths(packageRoot, paths) {
|
|
if (paths.length === 0) {
|
|
return new Set();
|
|
}
|
|
const result = spawnSync("git", ["check-ignore", "-z", "--stdin"], {
|
|
cwd: packageRoot,
|
|
input: paths.join("\0"),
|
|
encoding: "utf8",
|
|
maxBuffer: 64 * 1024 * 1024,
|
|
});
|
|
if (result.error !== undefined) {
|
|
throw result.error;
|
|
}
|
|
// `git check-ignore` exits 1 when nothing matched, which is not a failure.
|
|
if (result.status !== 0 && result.status !== 1) {
|
|
throw new Error(`git check-ignore failed: ${result.stderr}`);
|
|
}
|
|
return new Set(
|
|
result.stdout
|
|
.split("\0")
|
|
.filter((entry) => entry !== "")
|
|
.map((entry) => resolve(packageRoot, entry)),
|
|
);
|
|
}
|
|
|
|
export async function listTrackedFiles(packageRoot = defaultPackageRoot) {
|
|
const { stdout } = await execFileAsync("git", ["ls-files", "-z", "--", "."], {
|
|
cwd: packageRoot,
|
|
maxBuffer: 64 * 1024 * 1024,
|
|
});
|
|
return stdout
|
|
.split("\0")
|
|
.filter((entry) => entry !== "")
|
|
.map((entry) => resolve(packageRoot, entry));
|
|
}
|
|
|
|
function isInside(parent, candidate) {
|
|
const pathFromParent = relative(parent, candidate);
|
|
return pathFromParent !== "" && !pathFromParent.startsWith("..");
|
|
}
|
|
|
|
/**
|
|
* Reject tracked sources whose relative imports only resolve against files git
|
|
* does not carry. A shared worktree happily builds such a tree while a clean
|
|
* clone of the same commit cannot, so this guard runs on the tracked set only.
|
|
*/
|
|
export async function checkTrackedImports({
|
|
packageRoot = defaultPackageRoot,
|
|
scanRoots = ["src", "scripts", "devtools", "examples"],
|
|
trackedFiles,
|
|
} = {}) {
|
|
const tracked = trackedFiles ?? (await listTrackedFiles(packageRoot));
|
|
const trackedSet = new Set(tracked);
|
|
const roots = scanRoots.map((root) => resolve(packageRoot, root));
|
|
const files = tracked
|
|
.filter((file) => isScannable(file) && roots.some((root) => isInside(root, file)))
|
|
.sort();
|
|
|
|
const suspects = [];
|
|
for (const file of files) {
|
|
const source = await readFile(file, "utf8");
|
|
for (const { specifier, offset } of findSpecifiers(source)) {
|
|
if (!isRelative(specifier) || /[?*]|\$\{/.test(specifier)) {
|
|
continue;
|
|
}
|
|
const candidates = resolutionCandidates(file, specifier);
|
|
if (candidates.some((candidate) => trackedSet.has(candidate))) {
|
|
continue;
|
|
}
|
|
suspects.push({
|
|
file,
|
|
line: source.slice(0, offset).split("\n").length,
|
|
specifier,
|
|
candidates,
|
|
});
|
|
}
|
|
}
|
|
|
|
const ignored = await listIgnoredPaths(
|
|
packageRoot,
|
|
[...new Set(suspects.flatMap((suspect) => suspect.candidates))],
|
|
);
|
|
return suspects
|
|
.filter((suspect) => !suspect.candidates.some((candidate) => ignored.has(candidate)))
|
|
.map(({ file, line, specifier, candidates }) => ({
|
|
file,
|
|
line,
|
|
specifier,
|
|
reason: candidates.some((candidate) => existsSync(candidate))
|
|
? "resolves only to an untracked file, so a clean checkout cannot build it"
|
|
: "does not resolve to any tracked file",
|
|
}));
|
|
}
|
|
|
|
const ENTRY_POINT_TOKEN = /^[A-Za-z0-9._@/-]+\.(?:mjs|cjs|js|jsx|ts|tsx|sh|toml)$/;
|
|
|
|
/**
|
|
* `package.json` scripts are the other way a commit can depend on a file git
|
|
* does not carry: an ignored or never-added entry point runs fine locally and
|
|
* fails immediately in a clean checkout.
|
|
*/
|
|
export async function checkTrackedScriptEntryPoints({
|
|
packageRoot = defaultPackageRoot,
|
|
trackedFiles,
|
|
} = {}) {
|
|
const manifestPath = resolve(packageRoot, "package.json");
|
|
const manifest = JSON.parse(await readFile(manifestPath, "utf8"));
|
|
const trackedSet = new Set(trackedFiles ?? (await listTrackedFiles(packageRoot)));
|
|
|
|
const suspects = [];
|
|
for (const [name, body] of Object.entries(manifest.scripts ?? {})) {
|
|
for (const token of new Set(body.split(/\s+/))) {
|
|
if (!ENTRY_POINT_TOKEN.test(token) || token.startsWith("@")) {
|
|
continue;
|
|
}
|
|
const path = resolve(packageRoot, token);
|
|
if (trackedSet.has(path) || !isInside(packageRoot, path)) {
|
|
continue;
|
|
}
|
|
suspects.push({ file: manifestPath, script: name, specifier: token, candidates: [path] });
|
|
}
|
|
}
|
|
|
|
const ignored = await listIgnoredPaths(
|
|
packageRoot,
|
|
suspects.map((suspect) => suspect.candidates[0]),
|
|
);
|
|
return suspects
|
|
.filter((suspect) => !ignored.has(suspect.candidates[0]))
|
|
.map(({ file, script, specifier }) => ({
|
|
file,
|
|
line: 1,
|
|
specifier,
|
|
reason: `the "${script}" script runs a file that is not tracked, so a clean checkout cannot run it`,
|
|
}));
|
|
}
|
|
|
|
export function formatTrackedImportViolation(violation, packageRoot = defaultPackageRoot) {
|
|
return `${relative(packageRoot, violation.file)}:${violation.line} imports ${JSON.stringify(
|
|
violation.specifier,
|
|
)}: ${violation.reason}`;
|
|
}
|