mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-14 17:40:37 +02:00
## Thinking Path > - Paperclip manages AI agents and their work. > - The experimental Runner owns provider processes and durable sessions. > - Pi needs working task execution and human controls. > - The five-PR stack must preserve changes already on master. > - Each layer now carries the complete integrated source for a safe sequential fallback. > - This PR belongs to native GitHub stack #15602, ending at #14956. ## Linked Issues or Issue Description Refs #14436, #14631, #14743 and #14956. Ship Pi 1.0 through the experimental Paperclip Runner. The five PRs are #14921, #14922, #14923, #14924 and #14956. The user authorized the complete merge after checks pass. Existing `pi_local` execution is unchanged. Accounting and wider provider/platform qualification remain deferred. ## What Changed - Recover missing final replies after workspace finalization changes owners, using accepted-turn evidence without rerunning work or granting external-chat publication. - Preserve the admitted Pi instruction root across warm runs, while retaining changed-root rejection. - Give Pi a bounded 15-second default shutdown grace so stop, drain acknowledgement and durable suspension can complete. Explicit deadlines and other providers retain their existing behavior. - Integrate the Pi 1.0 runtime and master contracts. - Use Pi profile 22. Preserve explicit caller-selected models and exact native thinking levels. Keep Pi's wrapper, helper, extension and question/control behavior unchanged from the qualified profile-19 runtime. - Preserve master's Dot lifecycle and consent fields, configured task environment, status guards and current Codex/Claude dependency versions. Cursor stays qualified. Copilot stays pending; profile 17 binds the changed shared protocol validation sources. - Exclude general AWS IAM credentials from Pi static/custom provider bindings and selected task projections; preserve the provider-scoped Bedrock bearer key. Profile 21 is retained as historical provenance. Rust and cloud install probes use the current declaration. - Patch bundled brace-expansion 5.0.9 to the exact official 5.0.12 payload. Pin the patch and complete runtime closures. Include the patch in normal installed setup tooling. Keep the upstream Pi shrinkwrap as provenance and permit only this exact security correction. - Include current attestation files in the Docker build context. Keep the repository lockfile unchanged from master. CI and private image builds resolve manifest changes before their frozen installation. ## Verification - Full local `pnpm -r typecheck` passes, including Runner Rust, server and UI. Focused integration checks pass: 194 Runner admission/environment tests, 63 profile/credential tests with one expected skip, 152 Dot/UI configuration tests, and Pi transcript/notice tests. - Full local `pnpm build` passes on the final source. - Fresh final-source checks pass: all 698 Rust workspace tests (32 binaries), 156 credential/profile/controller tests with one expected skip, Runner TypeScript typecheck, and 20 package/setup/sandbox tests. - The profile-21 Pi materializer passes on the native host with the official pinned Node 24.21.0 and its npm. It verifies all 150 locked packages, the patched dependency and the exact closure. Setup/package bundle tests and UI token gates pass. - The old hashes were reproduced for all three supported targets before calculating the patched graph. New closure hashes are darwin-arm64 `282022db10150c6632b3444df421342e7d534bdf5d5fb1097a2e79d0625a2bcf`, darwin-x64 `64e251e19009f755c0b04f73ce2138246faab71a961b0f13d75ebfcc34bef12e`, and linux-x64 `713b1fdff42fb56a1518bdc084f181d70bee8ebadc3e4b1d76321ed9108c8410`. Independent native platform execution is separate from graph identity reproduction. - Historical cloud qualification remains unchanged: all seven core cases pass on shipping source `10dc43c9ec65d88c2f782d62afb296d09494f215`, harness `1a4408a48cfb5a1f094a311141c257c92cd7a893`, image `sha256:5b3a775b383591bda1b0c1889e509acc70ce7f37c53f09733c81d59037f02280`, and accepted Sonnet 4.6/low fixture. All 215 canonical files and all seven cleanup checks pass independent verification. These are profile-19 results and are not relabeled as fresh profile-22 runs. - Current Pi digest: `sha256:e92078bee3c23bec4100aa589013a44613d054cd686826534025d8019e9f39a9`. [The readiness plan](https://github.com/paperclipai/paperclip/blob/codex/pi-production-readiness/doc/plans/2026-10-02-pi-production-readiness.md) preserves campaign and failed-attempt provenance. - Merge only after every PR's current-head CI and fresh review pass. Linux CI covers the full suites, build and browser tests. The local embedded Postgres API-authority suite cannot start on this macOS/Node 26 host, so Linux CI must confirm that suite. ### Fresh profile-22 core qualification — 2026-10-08 All seven accepted core cases pass canonically on Pi profile 22, with `openrouter/anthropic/claude-sonnet-4.6` and native-confirmed low thinking. This model is a fixture; production accepts the caller's explicit Pi provider/model. Runtime/install source: `3241a992f2a7703e59e97ed0fd3e5d6405de4401`. Frozen accepted harness: `1a4408a48cfb5a1f094a311141c257c92cd7a893`. Immutable cloud image: `ghcr.io/paperclipai/paperclip-daytona-runner@sha256:506f22db7edd78f37c0c40bec1cc084af1850455026dbf467194bfbb8fcef141`. Pi digest: `sha256:e92078bee3c23bec4100aa589013a44613d054cd686826534025d8019e9f39a9`. [Hosted Linux image and clean-install verification](https://github.com/paperclipai/paperclip/actions/runs/37868328023) passes, including all 20 source-bound archives, normal CLI/Pi setup, companion import and the production pack reader. This exact installation source includes the latest master integration and the corrected Pi warm instruction-root fence. Full local typecheck/build and current-head hosted CI verify the final stack. All 13 focused real-root regressions pass. The full local executor suite passed 662 tests; 15 database tests could not start the Mac embedded PostgreSQL service. Hosted Linux CI passes the full required verification and E2E checks. These fresh results keep their own source identity; profile-19 results remain historical. | Core path | Canonical campaign | Retained archive SHA-256 | | --- | --- | --- | | File edit, validation, download and Done | `pi-core22-replyfix-0-1791511228` | 23 files; `a473e8603a3dd4737863291f8d3d1e392391f0b16d433c3e0e0e9d8baf7a97b0` | | Pending question and controller restart | `pi-core22-replyfix-1-1791511376` | 33 files; `6b829c4eb74e1f32a89c692a4ae7130dbfc1c6d3cf13915effe2103d9e242c8e` | | Three-turn session/process/workspace continuity | `pi-core22-replyfix-2-1791511587` | 23 files; `7a87021f8f9a3fdd3c58bb4467f8d82c635e3ea4795d6e75f144d9aa14818df8` | | Four typed questions and browser reconnects | `pi-core22-replyfix-3-1791511881` | 42 files; `9e31755252be1f4f9cb0626c984c142d4d1ae5f5bee3a7af08444db8d12c280a` | | Plan approval and completion | `pi-core22-replyfix-4-1791512031` | 22 files; `a0383ce1aab38e7b5a25ce0e9dd3bebea5c037ebd96ae6b29dae19015da2ae2c` | | Same-turn steering and permission denial | `pi-core22-replyfix-5-1791512261` | 39 files; `c929b8c7070f0b66aedc17e65ca46e6beab1e363926ac9f7e2a75fb250f05949` | | Stop during pending permission | `pi-core22-replyfix-6-1791512390` | 33 files; `7f0a58ae0f4d5bfc76149435f4e322537089c5bd16e7ffe9b5ad71f10a621a07` | All 215 canonical files (28714587 bytes) are independently hash-verified. All seven cleanup grades pass, with no owned runtime process or temporary root after each case. Automatic retries are zero. The owned cloud host stopped normally after retention. The prior profile-22 warm attempt remains failed and separately retained: archive SHA-256 `1e54eba5ec72b50cee1534b23d1d1d4f21a090006b8a64501ba70db972abfde5`. Its original canonical classification is preserved. Diagnosis reproduced a product bug comparing an agent-files root against an unset checkpoint-only field. The fix stores the admitted physical root separately from the adopted per-run collection capability. The real-root regression fails before the fix and passes afterward, including rejection of a changed physical root. Fixture, grader, model and all seven accepted case IDs are unchanged; this fresh campaign tests final-reply publication after file registration first. The intermediate restart attempt also remains failed and retained: archive SHA-256 `5dcaefdf1d17cf4cd54fd4cf810f45e736667392339b8ce7caf08bb4e225277f`. Its original canonical classification is preserved. Pi resumed, wrote the verified answer and completed its task; exact runner suspension was proven, but idle stop consumed about 5.2s and left under 3s for the drain acknowledgement. The Pi-only default shutdown grace is now 15s, preserving a full 5s drain round trip and a finite suspension reserve. Explicit caller deadlines, other provider defaults, literal drain receipts and exact suspension identity checks remain unchanged. The timing regression fails before this correction and passes afterward; all 18 focused settlement tests and Runner typecheck pass. The final-source file attempt is also preserved as failed (`candidate_failure`), archive SHA-256 `db6767b6773ea618997927ac77bdb005a5ac81492c7b9c0ffbc900449f829bc9`. Native edit, validation, exact downloadable artifact and Done/succeeded all passed, and the exact final reply was durably recorded. A workspace recovery owner completed before the live heartbeat reached presentation, leaving that reply absent from task chat. Recovery now materializes only a completed final reply from the accepted turn of an ordinary internal Done task, preserving issue/run/contract binding, suppression, external-chat authorization and same-run deduplication. The database regression covers the generated file-preparation receipt, suppression, unapproved external continuation and replay. Server typecheck and all 49 response-selection tests pass; hosted Linux verifies the database regression because embedded PostgreSQL cannot start on this Mac. The delayed-final-answer database regression passes on [the final root-source Linux server shard](https://github.com/paperclipai/paperclip/actions/runs/37868262553/job/113628594152), alongside 1,108 passing tests. The first root Runner shard had one unchanged durable-resume test exceed its 5-second timeout; the identical top-source shard and the isolated exact test passed. One rerun of that failed job and its required aggregate passed without source or test changes. The original failed job log and the single-rerun receipt remain retained. ### October 9 merge verification Current merge head: `5a8fe63512a7166aaef5cf50065a25008aa8b44b`. All current-head checks pass, including `ci / verify` and `ci / e2e`; exact-head Greptile review is 5/5 with no unresolved threads. Current master conflicts are resolved. The user authorized the maintainer override of the code-owner review gate after these checks. The seven retained live core cases remain bound to source `3241a992f2a7703e59e97ed0fd3e5d6405de4401` and its recorded cloud image. ## Risks - The security correction changes the dependency closure and profile identity. Old sessions must reopen on the new profile. Exact identities and credential bindings fail closed. - The runner remains experimental and requires explicit selection. Legacy Pi Local is unchanged. Caller model IDs pass through; the E2E model is a fixture. - Accounting and the broad platform/provider matrix remain deferred. This merge does not publish a release or deploy a service. ## Model Used OpenAI GPT-6 through Codex assisted with reasoning, repository inspection, editing and tool use. The exact serving ID and context window are not exposed in this session. Final live qualification uses Pi 1.0.0 with `openrouter/anthropic/claude-sonnet-4.6` and native-confirmed low thinking. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
275 lines
21 KiB
TypeScript
275 lines
21 KiB
TypeScript
import { execFile } from "node:child_process";
|
|
import { promisify } from "node:util";
|
|
import { createHash } from "node:crypto";
|
|
import { mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import { dirname, join } from "node:path";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import { collectPiFileEvidence, gradePiCopyback, gradePiFileEvidence, piFileContract, piFilePrompt, seedPiFile } from "./pi-file-evidence.js";
|
|
import { canonicalProviderEventsFromAcpxRuntimeEvent, createAcpxToolEventNormalizer } from "../../packages/paperclip-runner/src/provider-events.js";
|
|
import { safeAcpxLocations } from "../../packages/paperclip-runner/src/drivers/acpx/safe-locations.js";
|
|
import { classifyFailure } from "./failure-classifier.js";
|
|
import { runnerMatrix } from "./catalog.js";
|
|
|
|
function fixture() {
|
|
const c = piFileContract("fixture"), attachmentId = "12345678-1234-1234-1234-123456789abc";
|
|
const normalize = createAcpxToolEventNormalizer();
|
|
const tool = (seq: number, executionId: string, name: string, operation: string,
|
|
phase: "start" | "progress" | "end", target: string | null, text = "", rawOutput: unknown = undefined) => {
|
|
// Sanitized shape of the retained Pi stream: missing opening location,
|
|
// later resolved edit arguments, and stable bash name with command progress.
|
|
// This exercises TS normalization/projection, not the Rust implementation.
|
|
const event = normalize({ type: "tool_call", toolCallId: executionId,
|
|
tag: phase === "start" ? "tool_call" : "tool_call_update", title: name, kind: operation,
|
|
status: phase === "end" ? "completed" : phase === "start" ? "pending" : "in_progress",
|
|
locations: safeAcpxLocations(target ? [{ path: `/workspace/${target}` }] : [], "/workspace", operation, name),
|
|
text, rawOutput });
|
|
const canonical = canonicalProviderEventsFromAcpxRuntimeEvent(event, executionId, "turn")[0]!;
|
|
return { companyId: "company", runId: "run", seq, protocolSchemaVersion: 1, eventType: canonical.eventType,
|
|
sourceInstanceId: "runner", sourceSeq: seq, sourceEventId: `runner:run:${seq}`,
|
|
payload: { prpEvent: { schema: "paperclip.prp.event.v1", schemaVersion: 1, sourceKind: "runner", sourceInstanceId: "runner",
|
|
sourceSeq: seq, sourceEventId: `runner:run:${seq}`, runId: "run", turnId: "turn", normalizedSessionId: "session", ...canonical } } };
|
|
};
|
|
return {
|
|
environment: "local" as const, environmentId: "environment", nonce: "fixture", companyId: "company", issueId: "issue", agentId: "agent", attachmentId,
|
|
seed: { schema: "paperclip.e2e.pi-file-seed.v1", filename: c.filename,
|
|
beforeSha256: createHash("sha256").update("ready-fixture\n").digest("hex"), byteSize: Buffer.byteLength(c.before) },
|
|
workspaceBytes: Buffer.from(c.after), downloadedBytes: Buffer.from(c.after),
|
|
run: { id: "run", companyId: "company", agentId: "agent", runtimeMode: "native", nativeSessionId: "session", runnerInstanceId: "runner", status: "succeeded", resultJson: { semanticToolReceipts: {
|
|
publish: { operationId: "register_deliverable", input: { filename: c.filename, contentRef: c.filename, contentType: "text/plain", byteSize: c.byteSize, sha256: c.sha256 },
|
|
result: { disposition: "applied", commandId: `deliverable-prepared:${attachmentId}`, entityRefs: [attachmentId, "product", "comment"] } },
|
|
} } },
|
|
events: [tool(1, "edit", "edit", "edit", "start", null),
|
|
tool(2, "edit", "edit", "edit", "progress", c.filename),
|
|
tool(3, "edit", "edit", "edit", "end", c.filename),
|
|
tool(4, "validate", "bash", "execute", "start", null, "bash (pending): [terminal] validate"),
|
|
tool(5, "validate", c.validationCommand, "execute", "progress", null, `${c.validationCommand} (in_progress): ${c.validationCommand}`),
|
|
tool(6, "validate", c.validationCommand, "execute", "end", null, "", {
|
|
content: [{ type: "text", text: `${c.validationMarker}\n` }],
|
|
structuredContent: { output: `${c.validationMarker}\n`, truncated: false, exit_code: 0, wall_time_seconds: 0 },
|
|
})],
|
|
attachments: [{ id: attachmentId, companyId: "company", issueId: "issue", originatingRunId: "run", createdByAgentId: "agent",
|
|
originalFilename: c.filename, contentType: "text/plain", byteSize: c.byteSize, sha256: c.sha256 }],
|
|
activity: [{ action: "issue.attachment_added", companyId: "company", runId: "run", actorId: "agent", entityId: "issue",
|
|
details: { attachmentId, source: "paperclip_runner_protocol" } }],
|
|
};
|
|
}
|
|
function changeOutput(f: ReturnType<typeof fixture>, change: (output: any) => void) {
|
|
const p = f.events[5]!.payload.prpEvent.payload, output = JSON.parse(p.output as string);
|
|
change(output); p.output = JSON.stringify(output);
|
|
}
|
|
describe("Pi edit, validation and public artifact oracle", () => {
|
|
it("calibrates against the sanitized 44-row actual native stream without regrading the paid attempt", async () => {
|
|
const retained = JSON.parse(await readFile(new URL("./fixtures/pi-file-evidence-actual-stream.json", import.meta.url), "utf8"));
|
|
const f = fixture();
|
|
expect(retained.events).toHaveLength(44);
|
|
f.events = retained.events.map((x: any) => ({ companyId: "company", runId: "run", seq: x.seq,
|
|
protocolSchemaVersion: 1, eventType: x.eventType, sourceInstanceId: "runner", sourceSeq: x.sourceSeq,
|
|
sourceEventId: `runner:run:${x.sourceSeq}`, payload: { prpEvent: {
|
|
schema: "paperclip.prp.event.v1", schemaVersion: 1, sourceKind: "runner", sourceInstanceId: "runner",
|
|
sourceSeq: x.sourceSeq, sourceEventId: `runner:run:${x.sourceSeq}`, runId: "run", turnId: "turn",
|
|
normalizedSessionId: "session", eventType: x.eventType, payload: x.payload,
|
|
} } }));
|
|
expect(gradePiFileEvidence(f).verification).toMatchObject({ nativeStructuredExitCode: 0, typedExitCode: null });
|
|
});
|
|
it("accepts actual correlated lifecycles, independent bytes and a run-bound registered download", () => {
|
|
const result = gradePiFileEvidence(fixture());
|
|
expect(result.passed).toBe(true);
|
|
expect(result.diff.text).toContain("-ready-fixture\n+verified-fixture\n");
|
|
expect(result.limits.join(" ")).toContain("not attested");
|
|
expect(result.verification.providerExecutionStatus).toBe("completed");
|
|
expect(result.verification.command).toBe(piFileContract("fixture").validationCommand);
|
|
expect(result.verification).toMatchObject({ commandEvidence: "correlated_native_progress",
|
|
exitEvidence: "native_structured_output_receipt", nativeStructuredExitCode: 0, typedExitCode: null });
|
|
expect(fixture().events.map(e => e.payload.prpEvent.payload.target)).toEqual([null, "extended-fixture.txt", "extended-fixture.txt", null, null, null]);
|
|
expect(fixture().events.slice(3).every(e => e.payload.prpEvent.payload.name === "bash")).toBe(true);
|
|
expect(result.verification.nativeFileAttribution).toBe("workspace_relative_display_target");
|
|
});
|
|
it.each(["before", "after"])("rejects an extra metadata bash call %s validation despite correct file and download bytes", placement => {
|
|
const f = fixture();
|
|
const metadata = structuredClone(f.events.slice(3));
|
|
for (const row of metadata) row.payload.prpEvent.payload.executionId = "metadata";
|
|
metadata[1]!.payload.prpEvent.payload.progress = "wc -c extended-fixture.txt (in_progress): wc -c extended-fixture.txt";
|
|
metadata[2]!.payload.prpEvent.payload.output = JSON.stringify({
|
|
content: [{ type: "text", text: "17 extended-fixture.txt\n" }],
|
|
structuredContent: { output: "17 extended-fixture.txt\n", truncated: false, exit_code: 0 },
|
|
});
|
|
if (placement === "before") f.events.splice(3, 0, ...metadata);
|
|
else f.events.push(...metadata);
|
|
for (const [index, row] of f.events.entries()) {
|
|
row.seq = row.sourceSeq = row.payload.prpEvent.sourceSeq = index + 1;
|
|
row.sourceEventId = row.payload.prpEvent.sourceEventId = `runner:run:${index + 1}`;
|
|
}
|
|
expect(() => gradePiFileEvidence(f)).toThrow("one observed provider validation execution");
|
|
});
|
|
const mutations: Array<[string, (f: ReturnType<typeof fixture>) => void]> = [
|
|
["absent seed", f => { f.seed = {} as any; }],
|
|
["wrong final bytes", f => { f.workspaceBytes = Buffer.from("wrong\n"); }],
|
|
["final-only write", f => { f.events[0]!.payload.prpEvent.payload.name = "write"; f.events[2]!.payload.prpEvent.payload.name = "write"; }],
|
|
["missing edit", f => { f.events = f.events.slice(3); }],
|
|
["missing validation", f => { f.events = f.events.slice(0, 3); }],
|
|
["echo-only validation", f => { f.events[3]!.payload.prpEvent.payload.name = `echo ${piFileContract("fixture").validationMarker}`; f.events[5]!.payload.prpEvent.payload.name = f.events[3]!.payload.prpEvent.payload.name; }],
|
|
["failed validation", f => { f.events[5]!.payload.prpEvent.payload.status = "failed"; }],
|
|
["unfinished validation", f => { f.events.pop(); }],
|
|
["unrelated validation turn", f => { f.events[3]!.payload.prpEvent.turnId = "other"; f.events[5]!.payload.prpEvent.turnId = "other"; }],
|
|
["foreign native session", f => { f.run.nativeSessionId = "other"; }],
|
|
["foreign native producer", f => { f.run.runnerInstanceId = "other"; }],
|
|
["foreign event run", f => { f.events[2]!.payload.prpEvent.runId = "other"; }],
|
|
["duplicate event", f => { f.events.push(structuredClone(f.events[5]!)); }],
|
|
["missing tool start", f => { f.events.splice(3, 1); }],
|
|
["truncated validation output", f => { f.events[5]!.payload.prpEvent.payload.outputTruncated = true; }],
|
|
["missing native target", f => { f.events[0]!.payload.prpEvent.payload.target = null; f.events[2]!.payload.prpEvent.payload.target = null; }],
|
|
["wrong target", f => { f.events[2]!.payload.prpEvent.payload.target = "other.txt"; }],
|
|
["missing registration", f => { f.run.resultJson.semanticToolReceipts = {} as any; }],
|
|
["rejected registration", f => { f.run.resultJson.semanticToolReceipts.publish.result.disposition = "denied"; }],
|
|
["wrong registered hash", f => { f.run.resultJson.semanticToolReceipts.publish.input.sha256 = "wrong"; }],
|
|
["wrong registered entity", f => { f.run.resultJson.semanticToolReceipts.publish.result.entityRefs[0] = "other"; }],
|
|
["missing attachment", f => { f.attachments = []; }],
|
|
["foreign attachment company", f => { f.attachments[0]!.companyId = "other"; }],
|
|
["stale attachment run", f => { f.attachments[0]!.originatingRunId = "older"; }],
|
|
["wrong download bytes", f => { f.downloadedBytes = Buffer.from("wrong\n"); }],
|
|
["missing publication activity", f => { f.activity = []; }],
|
|
["foreign publication run", f => { f.activity[0]!.runId = "other"; }],
|
|
["conflicting resolved target", f => { f.events[1]!.payload.prpEvent.payload.target = "other.txt"; }],
|
|
["target regresses after resolution", f => { f.events[0]!.payload.prpEvent.payload.target = piFileContract("fixture").filename; f.events[1]!.payload.prpEvent.payload.target = null; }],
|
|
["missing terminal target", f => { f.events[2]!.payload.prpEvent.payload.target = null; }],
|
|
["absent command proof", f => { f.events[4]!.payload.prpEvent.payload.progress = null; }],
|
|
["echo-only command proof", f => { f.events[4]!.payload.prpEvent.payload.progress = "echo PI-VALIDATED-fixture (in_progress): echo PI-VALIDATED-fixture"; }],
|
|
["conflicting command before exact proof", f => { f.events[3]!.payload.prpEvent.payload.progress = "node other.js (pending): node other.js"; }],
|
|
["late command proof", f => { f.events[5]!.payload.prpEvent.payload.progress = f.events[4]!.payload.prpEvent.payload.progress; f.events[4]!.payload.prpEvent.payload.progress = null; }],
|
|
["plain echoed marker output", f => { f.events[5]!.payload.prpEvent.payload.output = piFileContract("fixture").validationMarker; }],
|
|
["nonzero native exit", f => { changeOutput(f, o => { o.structuredContent.exit_code = 1; }); }],
|
|
["missing native exit", f => { changeOutput(f, o => { delete o.structuredContent.exit_code; }); }],
|
|
["truncated native output", f => { changeOutput(f, o => { o.structuredContent.truncated = true; }); }],
|
|
["false marker substring", f => { changeOutput(f, o => { o.structuredContent.output = "failed before PI-VALIDATED-fixture\n"; }); }],
|
|
["contradictory content", f => { changeOutput(f, o => { o.content[0].text = "failed"; }); }],
|
|
["contradictory typed exit", f => { f.events[5]!.payload.prpEvent.payload.exitCode = 1; }],
|
|
["foreign command proof execution", f => { f.events[4]!.payload.prpEvent.payload.executionId = "foreign"; }],
|
|
["foreign command proof turn", f => { f.events[4]!.payload.prpEvent.turnId = "foreign"; }],
|
|
["foreign command proof session", f => { f.events[4]!.payload.prpEvent.normalizedSessionId = "foreign"; }],
|
|
["foreign command proof producer", f => {
|
|
const row = f.events[4]!, e = row.payload.prpEvent;
|
|
e.sourceInstanceId = row.sourceInstanceId = "foreign"; e.sourceEventId = row.sourceEventId = `foreign:run:${e.sourceSeq}`;
|
|
}],
|
|
["durable source differs from envelope", f => { f.events[4]!.sourceInstanceId = "foreign"; }],
|
|
["durable event identity differs from envelope", f => { f.events[4]!.sourceEventId = "runner:run:999"; }],
|
|
["durable source sequence differs from envelope", f => { f.events[4]!.sourceSeq = 999; }],
|
|
["command proof after terminal", f => {
|
|
const e = f.events[4]!; f.events.splice(4, 1); e.seq = 7; e.payload.prpEvent.sourceSeq = 7;
|
|
e.sourceSeq = 7; e.sourceEventId = e.payload.prpEvent.sourceEventId = "runner:run:7"; f.events.push(e);
|
|
}],
|
|
];
|
|
it.each(mutations)("rejects %s even when the model claims completion", (_name, change) => {
|
|
const f = fixture(); change(f); expect(() => gradePiFileEvidence(f)).toThrow("Pi file evidence:");
|
|
try { gradePiFileEvidence(f); } catch (error) { expect(classifyFailure(error)).toBe("candidate_failure"); }
|
|
});
|
|
it("keeps real nonce commands within the Rust 240-character name contract", () => {
|
|
const c = piFileContract("0123456789ab-1");
|
|
expect([...c.validationCommand].length).toBeLessThanOrEqual(240);
|
|
expect(safeAcpxLocations([{ path: `/workspace/${c.filename}` }], "/workspace", "edit", "edit")[0]).toMatchObject({
|
|
path: c.filename, pathBoundary: "paperclip.workspace_relative_display.v2",
|
|
});
|
|
expect(() => piFileContract("a".repeat(100))).toThrow("native Rust tool-name bound");
|
|
});
|
|
it("runs the exact fixture validation command and rejects plausible wrong bytes", async () => {
|
|
const root = await mkdtemp(join(tmpdir(), "pi-validation-command-"));
|
|
const c = piFileContract("0123456789ab-1");
|
|
const validate = () => promisify(execFile)("/bin/sh", ["-c", c.validationCommand], {
|
|
cwd: root, timeout: 3_000, maxBuffer: 4096, env: { PATH: dirname(process.execPath) },
|
|
});
|
|
try {
|
|
await writeFile(join(root, c.filename), c.after);
|
|
expect((await validate()).stdout).toBe(`${c.validationMarker}\n`);
|
|
await writeFile(join(root, c.filename), c.after.trimEnd());
|
|
await expect(validate()).rejects.toMatchObject({ code: 1 });
|
|
await rm(join(root, c.filename));
|
|
await expect(validate()).rejects.toMatchObject({ code: 1 });
|
|
} finally { await rm(root, { recursive: true, force: true }); }
|
|
});
|
|
it("pastes the literal validation command as Markdown code instead of escaped paragraph text", () => {
|
|
const command = piFileContract("0123456789ab-1").validationCommand;
|
|
const fenced = piFilePrompt("0123456789ab-1").match(/\n```bash\n([^\n]+)\n```\n/u);
|
|
expect(fenced?.[1]).toBe(command);
|
|
expect(fenced?.[1]).toContain("!==");
|
|
expect(fenced?.[1]).not.toContain("!\\=\\=");
|
|
});
|
|
it("changes only Pi file prompts and keeps all four question methods", () => {
|
|
const cells = runnerMatrix.filter(c => c.suite.id === "extended-harnesses" && c.task.id === "file-edit-validate");
|
|
expect(cells).toHaveLength(6);
|
|
for (const cell of cells) {
|
|
const prompt = cell.task.buildPrompt("fixture");
|
|
expect(prompt.includes("register_deliverable")).toBe(cell.profile.qualificationCandidate === "pi");
|
|
if (cell.profile.qualificationCandidate === "pi") {
|
|
const artifact = cell.task.buildMatchers("fixture", cell).find(matcher => matcher.kind === "artifact_exact");
|
|
if (!artifact || artifact.kind !== "artifact_exact") throw new Error("Pi file task must require a registered artifact");
|
|
expect(artifact.name).toBe(piFileContract("fixture").filename);
|
|
expect(prompt).toContain(`title ${artifact.name},`);
|
|
}
|
|
}
|
|
expect(runnerMatrix.filter(c => c.profile.qualificationCandidate === "pi")).toHaveLength(26);
|
|
});
|
|
it.each(["local", "daytona"] as const)("seeds once and collects public %s evidence", async environment => {
|
|
const root = await mkdtemp(join(tmpdir(), "pi-file-evidence-"));
|
|
try {
|
|
const seed = await seedPiFile(root, "fixture"), f = environment === "daytona" ? copyback() : fixture(), c = piFileContract("fixture");
|
|
expect(await readFile(join(root, c.filename), "utf8")).toBe(c.before);
|
|
await expect(seedPiFile(root, "fixture")).rejects.toThrow();
|
|
await writeFile(join(root, c.filename), c.after);
|
|
const get = vi.fn(async (path: string) => {
|
|
if (path === "/api/heartbeat-runs/run") return f.run;
|
|
if (path === "/api/environment-leases/lease" && "lease" in f) return f.lease;
|
|
if (path.endsWith("/attachments")) return f.attachments;
|
|
if (path.endsWith("/activity")) return f.activity;
|
|
throw new Error("Unexpected route");
|
|
});
|
|
const download = vi.fn(async () => ({ ok: () => true, body: async () => f.downloadedBytes }));
|
|
const visible = vi.fn(async () => {}), evidence = vi.fn(async () => {});
|
|
const proof = await collectPiFileEvidence({ ...f, seed, workspace: root, evidence,
|
|
api: { get, request: { get: download } } as any,
|
|
page: { locator: () => ({ first: () => ({ waitFor: visible }) }) } as any });
|
|
expect(proof.passed).toBe(true);
|
|
if (environment === "daytona") {
|
|
expect(get).toHaveBeenCalledWith("/api/heartbeat-runs/run");
|
|
expect(get).toHaveBeenCalledWith("/api/environment-leases/lease");
|
|
expect(proof.workspaceProvenance.kind).toBe("product_copyback");
|
|
}
|
|
expect(visible).toHaveBeenCalledOnce();
|
|
expect(evidence).toHaveBeenCalledWith(expect.objectContaining({ workspaceBytes: f.workspaceBytes.toString("base64"), downloadedBytes: f.downloadedBytes.toString("base64") }));
|
|
expect(download).toHaveBeenCalledWith(`/api/attachments/${f.attachmentId}/content`);
|
|
} finally { await rm(root, { recursive: true, force: true }); }
|
|
});
|
|
});
|
|
|
|
function copyback() {
|
|
const f = fixture();
|
|
const reference = { schema: "paperclip.native-workspace-sync/v2", state: "finalized", baselineSha256: "a".repeat(64),
|
|
descriptorSha256: "b".repeat(64), finalHostSha256: "c".repeat(64), workspaceId: "workspace", leaseId: "lease",
|
|
providerLeaseId: "sandbox", remoteCwd: "/workspace" };
|
|
const run = { ...f.run, contextSnapshot: { executionWorkspaceId: "workspace", paperclipEnvironment: { id: "environment", driver: "sandbox", leaseId: "lease" } },
|
|
runnerProfileJson: { nativeWorkspaceSync: reference, nativeExecutionInput: { binding: { executionWorkspaceId: "workspace" } } } };
|
|
const lease = { id: "lease", companyId: "company", environmentId: "environment", heartbeatRunId: "run", provider: "daytona", providerLeaseId: "sandbox", metadata: { remoteCwd: "/workspace" } };
|
|
return { ...f, run, lease, environment: "daytona" as const };
|
|
}
|
|
it("accepts public finalized same-run copy-back attribution without claiming guest observation", () => {
|
|
const f = copyback();
|
|
expect(gradePiFileEvidence(f).workspaceProvenance).toMatchObject({ kind: "product_copyback", guestObservation: false, hostSnapshotRecomputed: false });
|
|
});
|
|
it.each([
|
|
["missing reference", f => { f.run.runnerProfileJson.nativeWorkspaceSync = {} as any; }],
|
|
["prepared only", f => { f.run.runnerProfileJson.nativeWorkspaceSync.state = "prepared"; }],
|
|
["missing baseline", f => { f.run.runnerProfileJson.nativeWorkspaceSync.baselineSha256 = ""; }],
|
|
["invalid final hash", f => { f.run.runnerProfileJson.nativeWorkspaceSync.finalHostSha256 = "wrong"; }],
|
|
["foreign workspace", f => { f.run.contextSnapshot.executionWorkspaceId = "other"; }],
|
|
["contradictory native binding", f => { f.run.runnerProfileJson.nativeExecutionInput.binding.executionWorkspaceId = "other"; }],
|
|
["foreign lease", f => { f.lease.id = "other"; }],
|
|
["foreign run", f => { f.lease.heartbeatRunId = "other"; }],
|
|
["foreign company", f => { f.lease.companyId = "other"; }],
|
|
["foreign environment", f => { f.lease.environmentId = "other"; }],
|
|
["foreign provider lease", f => { f.lease.providerLeaseId = "other"; }],
|
|
["wrong remote root", f => { f.lease.metadata.remoteCwd = "/other"; }],
|
|
["wrong provider", f => { f.lease.provider = "other"; }],
|
|
] satisfies Array<[string, (f: ReturnType<typeof copyback>) => void]>)("rejects %s copy-back provenance", (_label, change) => {
|
|
const f = copyback(); change(f);
|
|
expect(() => gradePiCopyback(f.run, f.lease, f.companyId, f.environmentId)).toThrow("Pi file evidence:");
|
|
});
|