mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-26 18:31:34 +01:00
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - Managed deployments provision a platform-managed default environment
for agent runs; the UI shows this environment in selectors, the agent
form, run details, and the environments page
> - Those surfaces append the raw driver key to the environment name, so
users see labels like "Paperclip Computer (sandbox)", "Paperclip
Computer · sandbox", and fallback copy such as "Managed sandbox" and
"The sandbox has no ready authentication"
> - "sandbox" is infrastructure vocabulary, not the product name of the
environment; showing it next to the managed environment's name is
confusing and off-brand
> - This pull request renders platform-managed environments by name
alone and rewords the sandbox-phrased copy, while user-created
environments keep the driver suffix so mixed lists stay distinguishable
> - The benefit is that the default environment reads as one clear
product name everywhere, and self-hosted users lose nothing: their own
environments still show the driver
## Linked Issues or Issue Description
**What existing behavior does this improve?**
Display of the platform-managed default environment across the UI.
**Subsystem affected**
UI (environment selectors, agent config form, environments page, agents
page, run details) and the claude-local/codex-local adapter auth checks.
**Current behavior**
The agent form labels the inherited default environment as "Name
(sandbox)". Environment selectors and the environments list render "Name
· sandbox". The agents page describes the environment as "<provider>
sandbox provider". The agent form's fallback label is "Managed sandbox".
Adapter auth checks say "The sandbox has no ready authentication for
this adapter."
**Proposed behavior**
Platform-managed environment rows (`metadata.managedByPaperclip`) render
their name alone. The fallback label is "Paperclip Computer". The agents
page describes managed environments as "Managed by Paperclip". Run
details omit the driver suffix for sandbox-driver environments (the
adjacent Provider entry already identifies the mechanism). Adapter auth
checks say "This environment has no ready authentication for this
adapter."
**Reason and benefit**
The managed environment carries a product name. Appending the raw driver
key ("sandbox") to it is noise and contradicts the product naming.
User-created environments keep the driver suffix, so mixed lists stay
distinguishable.
**Breaking changes**
None. Message text of the auth check is not read programmatically; the
UI keys off `ADAPTER_AUTH_MISSING_CHECK_CODE`. Rows without the managed
marker render exactly as before.
## What Changed
- New `environmentDisplayLabel` helper in
`ui/src/lib/managed-sandbox-environment.ts`: managed rows → name alone;
other rows → "Name · driver".
- `AgentConfigForm`: inherited-default label uses the helper; fallback
copy "Managed sandbox" → "Paperclip Computer"; environment options use
the helper.
- `ProjectProperties`, `CompanyEnvironments`: environment selector
options use the helper; the environments-list row hides the driver
suffix on managed rows; the managed detail page's fallback description
no longer says "sandbox".
- `Agents` page: managed environments are described as "Managed by
Paperclip" instead of "<provider> sandbox provider".
- `CommentThread` run details: the driver suffix is omitted for
sandbox-driver environments.
- claude-local and codex-local adapters: auth-missing check message/hint
reworded from "sandbox" to "environment" (ACP and environment-test
paths); claude-local probe/effort/login hints reworded the same way.
- Run status lines: "Syncing workspace to sandbox", "Exporting git
changes from sandbox", "Starting adapter in sandbox", and friends now
say "environment"; "Finalizing sandbox workspace" → "Finalizing
workspace". Templated transfer-progress lines map the `sandbox`
transport key to "environment" for display (`runtime-progress.ts`).
- Agent form sign-in panel: "Sign in to the sandbox" → "Sign in to the
environment"; "Authenticated. The sandbox has credentials now." → "…The
environment has credentials now."
- Feature catalog + instance settings card: "Managed Sandbox Only" →
"Managed Environment Only" (setting key unchanged; the card keeps its
alphabetical slot).
- Server agents routes: execution-target failure and test-identity copy
no longer say "sandbox"; workspace-mode label "Cloud sandbox" → "Cloud
environment".
- Tests: new `environmentDisplayLabel` unit cases; new `AgentConfigForm`
render case asserting the managed default renders without "(sandbox)" or
"· sandbox"; status-line assertions updated across adapter-utils, server
heartbeat/live-run, and UI chat suites.
## Verification
- `pnpm --filter @paperclipai/ui typecheck` — clean.
- `pnpm --filter @paperclipai/adapter-claude-local typecheck` and
`--filter @paperclipai/adapter-codex-local typecheck` — clean.
- `vitest run` for `managed-sandbox-environment.test.ts`,
`AgentConfigForm.render.test.tsx`, `CompanyEnvironments.test.tsx`,
`Agents.test.tsx`, `CommentThread.test.tsx`, `NewAgent.test.tsx` — all
green (118 tests across the two runs).
## Risks
Low risk. Cosmetic label changes only; no data or API changes. Rows
without `metadata.managedByPaperclip` render exactly as before, so
self-hosted deployments with their own environments see no change. The
only self-hosted-visible wording changes are the adapter auth-check
message and the driver suffix omission on sandbox-driver rows in run
details.
## Model Used
- Claude (Anthropic) — claude-fable-5 (Claude Fable 5), Claude Code CLI,
extended thinking, tool use.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes (no
docs reference these labels)
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge
282 lines
8.4 KiB
TypeScript
282 lines
8.4 KiB
TypeScript
import { randomUUID } from "node:crypto";
|
|
import { afterAll, afterEach, beforeAll, describe, expect, it, vi } from "vitest";
|
|
import { eq } from "drizzle-orm";
|
|
import {
|
|
agents,
|
|
agentRuntimeState,
|
|
agentWakeupRequests,
|
|
companies,
|
|
createDb,
|
|
heartbeatRunEvents,
|
|
heartbeatRuns,
|
|
} from "@paperclipai/db";
|
|
import {
|
|
getEmbeddedPostgresTestSupport,
|
|
startEmbeddedPostgresTestDatabase,
|
|
} from "./helpers/embedded-postgres.js";
|
|
import { subscribeCompanyLiveEvents } from "../services/live-events.ts";
|
|
import {
|
|
clearAllHeartbeatRunRuntimeStatuses,
|
|
getHeartbeatRunRuntimeStatus,
|
|
} from "../services/heartbeat-run-runtime-status.ts";
|
|
|
|
vi.doMock("../adapters/index.js", () => ({
|
|
getServerAdapter: vi.fn(() => ({
|
|
type: "process",
|
|
execute: vi.fn(),
|
|
testEnvironment: vi.fn(),
|
|
})),
|
|
listAdapterModelProfiles: vi.fn(() => []),
|
|
runningProcesses: new Map(),
|
|
}));
|
|
|
|
const { heartbeatService } = await import("../services/heartbeat.ts");
|
|
|
|
const embeddedPostgresSupport = await getEmbeddedPostgresTestSupport();
|
|
const describeEmbeddedPostgres = embeddedPostgresSupport.supported ? describe : describe.skip;
|
|
|
|
if (!embeddedPostgresSupport.supported) {
|
|
console.warn(
|
|
`Skipping embedded Postgres heartbeat runtime-state tests on this host: ${embeddedPostgresSupport.reason ?? "unsupported environment"}`,
|
|
);
|
|
}
|
|
|
|
describeEmbeddedPostgres("heartbeat runtime state deduplication", () => {
|
|
let db!: ReturnType<typeof createDb>;
|
|
let tempDb: Awaited<ReturnType<typeof startEmbeddedPostgresTestDatabase>> | null = null;
|
|
|
|
beforeAll(async () => {
|
|
tempDb = await startEmbeddedPostgresTestDatabase("heartbeat-runtime-state-");
|
|
db = createDb(tempDb.connectionString);
|
|
}, 20_000);
|
|
|
|
afterEach(async () => {
|
|
clearAllHeartbeatRunRuntimeStatuses();
|
|
await db.delete(heartbeatRunEvents);
|
|
await db.delete(heartbeatRuns);
|
|
await db.delete(agentWakeupRequests);
|
|
await db.delete(agentRuntimeState);
|
|
await db.delete(agents);
|
|
await db.delete(companies);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await tempDb?.cleanup();
|
|
});
|
|
|
|
it("deduplicates concurrent runtime-state creation", async () => {
|
|
const companyId = randomUUID();
|
|
const agentId = randomUUID();
|
|
const issuePrefix = `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`;
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Paperclip",
|
|
issuePrefix,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await db.insert(agents).values({
|
|
id: agentId,
|
|
companyId,
|
|
name: "CodexCoder",
|
|
role: "engineer",
|
|
status: "idle",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
});
|
|
|
|
const heartbeat = heartbeatService(db);
|
|
const results = await Promise.all(Array.from({ length: 12 }, () => heartbeat.getRuntimeState(agentId)));
|
|
|
|
expect(results.every((row) => row?.agentId === agentId)).toBe(true);
|
|
|
|
const rows = await db.select().from(agentRuntimeState).where(eq(agentRuntimeState.agentId, agentId));
|
|
expect(rows).toHaveLength(1);
|
|
expect(rows[0]).toMatchObject({
|
|
agentId,
|
|
companyId,
|
|
adapterType: "codex_local",
|
|
stateJson: {},
|
|
});
|
|
});
|
|
|
|
it("publishes runtime progress without persisting heartbeat run events", async () => {
|
|
const companyId = randomUUID();
|
|
const agentId = randomUUID();
|
|
const runId = randomUUID();
|
|
const issueId = randomUUID();
|
|
const issuePrefix = `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`;
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Paperclip",
|
|
issuePrefix,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await db.insert(agents).values({
|
|
id: agentId,
|
|
companyId,
|
|
name: "CodexCoder",
|
|
role: "engineer",
|
|
status: "running",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
});
|
|
|
|
const [insertedRun] = await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId,
|
|
agentId,
|
|
invocationSource: "assignment",
|
|
status: "running",
|
|
contextSnapshot: { issueId },
|
|
}).returning();
|
|
const run = insertedRun!;
|
|
|
|
const liveEvents: unknown[] = [];
|
|
const unsubscribe = subscribeCompanyLiveEvents(companyId, (event) => {
|
|
liveEvents.push(event);
|
|
});
|
|
try {
|
|
const heartbeat = heartbeatService(db);
|
|
const status = await heartbeat.recordRuntimeProgress(run, {
|
|
phase: "config_sync",
|
|
message: "Syncing workspace to environment",
|
|
currentToolName: "bash",
|
|
lastAssistantSnippet: "Inspecting the repository",
|
|
lastEventAt: "2026-06-24T00:00:05.000Z",
|
|
}, issueId);
|
|
|
|
expect(status).toMatchObject({
|
|
companyId,
|
|
issueId,
|
|
agentId,
|
|
runId,
|
|
phase: "config_sync",
|
|
message: "Syncing workspace to environment",
|
|
currentToolName: "bash",
|
|
lastAssistantSnippet: "Inspecting the repository",
|
|
lastEventAt: new Date("2026-06-24T00:00:05.000Z"),
|
|
});
|
|
expect(heartbeat.decorateActiveRunStatus({
|
|
id: runId,
|
|
companyId,
|
|
agentId,
|
|
issueId,
|
|
status: "running",
|
|
})).toMatchObject({
|
|
currentStatusMessage: "Syncing workspace to environment",
|
|
currentToolName: "bash",
|
|
lastAssistantSnippet: "Inspecting the repository",
|
|
lastEventAt: new Date("2026-06-24T00:00:05.000Z"),
|
|
});
|
|
expect(liveEvents).toContainEqual(expect.objectContaining({
|
|
companyId,
|
|
type: "heartbeat.run.progress",
|
|
payload: expect.objectContaining({
|
|
runId,
|
|
agentId,
|
|
issueId,
|
|
phase: "config_sync",
|
|
message: "Syncing workspace to environment",
|
|
currentToolName: "bash",
|
|
lastAssistantSnippet: "Inspecting the repository",
|
|
lastEventAt: "2026-06-24T00:00:05.000Z",
|
|
}),
|
|
}));
|
|
|
|
const persistedEvents = await db.select().from(heartbeatRunEvents);
|
|
expect(persistedEvents).toHaveLength(0);
|
|
|
|
await heartbeat.cancelRun(runId, "test cleanup");
|
|
expect(getHeartbeatRunRuntimeStatus(runId)).toBeNull();
|
|
} finally {
|
|
unsubscribe();
|
|
}
|
|
});
|
|
|
|
it("ignores late runtime progress after the persisted run is terminal", async () => {
|
|
const companyId = randomUUID();
|
|
const agentId = randomUUID();
|
|
const runId = randomUUID();
|
|
const issueId = randomUUID();
|
|
const issuePrefix = `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`;
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Paperclip",
|
|
issuePrefix,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await db.insert(agents).values({
|
|
id: agentId,
|
|
companyId,
|
|
name: "CodexCoder",
|
|
role: "engineer",
|
|
status: "running",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
});
|
|
|
|
const [insertedRun] = await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId,
|
|
agentId,
|
|
invocationSource: "assignment",
|
|
status: "running",
|
|
contextSnapshot: { issueId },
|
|
}).returning();
|
|
const staleRunningRun = insertedRun!;
|
|
|
|
const liveEvents: unknown[] = [];
|
|
const unsubscribe = subscribeCompanyLiveEvents(companyId, (event) => {
|
|
liveEvents.push(event);
|
|
});
|
|
try {
|
|
const heartbeat = heartbeatService(db);
|
|
await heartbeat.recordRuntimeProgress(staleRunningRun, {
|
|
phase: "config_sync",
|
|
message: "Syncing workspace to environment",
|
|
}, issueId);
|
|
|
|
expect(getHeartbeatRunRuntimeStatus(runId)).toMatchObject({
|
|
runId,
|
|
phase: "config_sync",
|
|
});
|
|
|
|
liveEvents.length = 0;
|
|
await db
|
|
.update(heartbeatRuns)
|
|
.set({
|
|
status: "succeeded",
|
|
finishedAt: new Date("2026-06-24T00:01:00.000Z"),
|
|
updatedAt: new Date("2026-06-24T00:01:00.000Z"),
|
|
})
|
|
.where(eq(heartbeatRuns.id, runId));
|
|
|
|
const lateStatus = await heartbeat.recordRuntimeProgress(staleRunningRun, {
|
|
phase: "finalize",
|
|
message: "Finalizing workspace",
|
|
}, issueId);
|
|
|
|
expect(lateStatus).toBeNull();
|
|
expect(getHeartbeatRunRuntimeStatus(runId)).toBeNull();
|
|
expect(liveEvents).not.toContainEqual(expect.objectContaining({
|
|
type: "heartbeat.run.progress",
|
|
}));
|
|
expect(await db.select().from(heartbeatRunEvents)).toHaveLength(0);
|
|
} finally {
|
|
unsubscribe();
|
|
}
|
|
});
|
|
});
|