// @vitest-environment jsdom import { readFileSync } from "node:fs"; import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"; import { APP_ROUTE_ROOTS, collectConversationLinks, collectConversationLinksWithDiagnostics, conversationLinkBindings, unservedLinkReason, mislabeledIssueLinks, readConversationDomLinks, readLatestConversationReplyRender, waitForLatestConversationReplyRender, waitForSavedTurnReplyRender, waitForSavedTurnReplyRenderReloadingOnce, type ConversationLinkInput } from "./chat-rendered-links.js"; const card = '

Project created

Launch
'; const thread = (content = card) => `
Create a project called Launch for the new website.
${content}
Created the Launch project. No repositories are connected yet.
`; function input(): ConversationLinkInput { return { origin: "https://fixture.test", companyId: "company", companyPrefix: "RUN", sourceId: "source", leadId: "ceo", comments: [{ id: "human", issueId: "source", companyId: "company" }, { id: "reply", issueId: "source", companyId: "company", authorAgentId: "ceo", createdByRunId: "run" }], runs: [{ id: "run", companyId: "company", agentId: "ceo", status: "succeeded", contextSnapshot: { issueId: "source" } }], projects: [{ id: "project", companyId: "company", name: "Launch" }], activity: [{ id: "created", companyId: "company", action: "project.created", entityType: "project", entityId: "project", actorType: "agent", actorId: "ceo", agentId: "ceo", runId: "run" }] }; } const collect = (value = input()) => readConversationDomLinks(conversationLinkBindings(value)); beforeEach(() => { document.body.innerHTML = thread(); vi.spyOn(Element.prototype, "getClientRects").mockReturnValue([{ width: 20, height: 20 }] as unknown as DOMRectList); }); afterEach(() => vi.restoreAllMocks()); it("collects the real supported sibling project-card structure when reply-only collection has no link", () => { expect(document.querySelectorAll('#comment-reply a[href]')).toHaveLength(0); expect(collect()).toEqual([{ threadTestId: "task-chat-thread", href: "/RUN/projects/project", source: "project-created-card", conversationId: "source", anchorCommentId: "human", resourceId: "project", cardLabel: "Project created: Launch", createdByRunId: "run" }]); }); it("keeps the original creation card usable on an idempotent retry without requiring another card", () => { const value = input(); value.comments.push({ id: "retry", issueId: "source", companyId: "company", authorAgentId: "ceo", createdByRunId: "retry-run" }); value.runs.push({ id: "retry-run", companyId: "company", agentId: "ceo", status: "succeeded", contextSnapshot: { issueId: "source" } }); document.querySelector('[data-testid="task-chat-scroller"]')!.insertAdjacentHTML('beforeend', '
The project already exists.
'); expect(collect(value).map(row => row.href)).toEqual(["/RUN/projects/project"]); }); it("retains visible ordinary reply links including task, goal and artifact links", () => { document.querySelector('#comment-reply')!.innerHTML = 'TaskGoalArtifactExternal issue'; expect(collect().filter(row => row.source === 'reply').map(row => row.href)).toEqual(['/RUN/issues/task','/RUN/goals/goal','/api/attachments/file/content','https://github.com/owner/repository/issues/12']); }); it.each([ ['wrong saved company', (v:ConversationLinkInput) => { v.projects[0]!.companyId='other'; }], ['wrong saved resource', (v:ConversationLinkInput) => { v.projects[0]!.id='other'; }], ['wrong saved name', (v:ConversationLinkInput) => { v.projects[0]!.name='Other'; }], ['missing creation audit', (v:ConversationLinkInput) => { v.activity=[]; }], ['wrong audit company', (v:ConversationLinkInput) => { v.activity[0]!.companyId='other'; }], ['wrong audit actor type', (v:ConversationLinkInput) => { v.activity[0]!.actorType='user'; }], ['wrong audit actor', (v:ConversationLinkInput) => { v.activity[0]!.actorId='other'; }], ['wrong audit agent', (v:ConversationLinkInput) => { v.activity[0]!.agentId='other'; }], ['wrong audit entity type', (v:ConversationLinkInput) => { v.activity[0]!.entityType='issue'; }], ['wrong audit resource', (v:ConversationLinkInput) => { v.activity[0]!.entityId='other'; }], ['unrelated historical run', (v:ConversationLinkInput) => { v.activity[0]!.runId='old'; }], ['run in another company', (v:ConversationLinkInput) => { v.runs[0]!.companyId='other'; }], ['run for another conversation', (v:ConversationLinkInput) => { v.runs[0]!.contextSnapshot={issueId:'other'}; }], ['wrong reply author', (v:ConversationLinkInput) => { v.comments[1]!.authorAgentId='other'; }], ['reply from another conversation', (v:ConversationLinkInput) => { v.comments[1]!.issueId='other'; }], ['comments from another company', (v:ConversationLinkInput) => { v.comments.forEach(row=>row.companyId='other'); }], ] as const)('rejects %s instead of treating any matching project link as evidence', (_label, mutate) => { const value=input(); mutate(value); expect(collect(value)).toEqual([]); }); it.each([ ['sidebar only', () => { document.body.innerHTML=thread('')+``; }], ['unrelated conversation', () => { document.body.innerHTML=thread('')+thread().replaceAll('comment-human','comment-other-human').replaceAll('comment-reply','comment-other-reply'); }], ['hidden sibling', () => { document.querySelector('article')!.setAttribute('hidden',''); }], ['hidden ancestor', () => { document.querySelector('[data-testid="task-chat-history-content"]')!.setAttribute('style','visibility:hidden'); }], ['inert ancestor', () => { document.querySelector('[data-testid="task-chat-history-content"]')!.setAttribute('inert',''); }], ['aria-hidden ancestor', () => { document.querySelector('[data-testid="task-chat-history-content"]')!.setAttribute('aria-hidden','true'); }], ['display:none', () => { document.querySelector('article')!.setAttribute('style','display:none'); }], ['transparent card', () => { document.querySelector('article')!.setAttribute('style','opacity:0'); }], ['missing layout box', () => { vi.mocked(Element.prototype.getClientRects).mockReturnValue([] as unknown as DOMRectList); }], ['missing supported card wrapper', () => { document.querySelector('[data-thread-item-kind="project_created"]')!.removeAttribute('data-thread-item-kind'); }], ['wrong item resource', () => { document.querySelector('[data-thread-item-kind="project_created"]')!.setAttribute('data-thread-anchor','project-created:other'); }], ['wrong card kind', () => { document.querySelector('article')!.setAttribute('aria-label','Goal created: Launch'); }], ['wrong card resource', () => { document.querySelector('article a')!.setAttribute('href','/RUN/projects/other'); }], ['wrong company route', () => { document.querySelector('article a')!.setAttribute('href','/OTHER/projects/project'); }], ['other origin', () => { document.querySelector('article a')!.setAttribute('href','https://other.test/RUN/projects/project'); }], ['wrong resource kind', () => { document.querySelector('article a')!.setAttribute('href','/RUN/goals/project'); }], ['extra destination path', () => { document.querySelector('article a')!.setAttribute('href','/RUN/projects/project/other'); }], ['duplicate visible source conversation', () => { document.body.insertAdjacentHTML('beforeend',thread()); }], ] as const)('rejects %s in actual DOM scope', (_label, mutate) => { mutate(); expect(collect()).toEqual([]); }); it("excludes hidden, wrong-company and unrelated inline anchors while keeping the current reply", () => { document.querySelector('#comment-reply')!.innerHTML='TaskOther company'; document.body.insertAdjacentHTML('beforeend',''); expect(collect().filter(row=>row.source==='reply').map(row=>row.href)).toEqual(['/RUN/issues/task']); }); it("treats a link inside an authenticated reply as an ordinary inline link, not a sibling creation receipt", () => { document.querySelector('#comment-reply')!.append(document.querySelector('article')!); expect(collect().map(row=>row.source)).toEqual(['reply']); }); it("recognizes the minimized authentic retained DOM and server identities without changing the original measurement", () => { const fixture = JSON.parse(readFileSync(`${import.meta.dirname}/chat-rendered-links.retained-project.json`, "utf8")); document.body.innerHTML = fixture.html; const reply = fixture.input.comments.find((row: { authorAgentId?: string }) => row.authorAgentId); expect(document.getElementById(`comment-${reply.id}`)!.querySelectorAll("a[href]")).toHaveLength(0); expect(collect(fixture.input).map(row => row.href)).toEqual([fixture.expectedHref]); }); it("retains ordinary inline links in the supported classic issue-chat root", () => { document.body.innerHTML=thread('').replace('task-chat-thread','thread-root'); document.querySelector('#comment-reply')!.innerHTML='Task'; expect(collect().map(row=>[row.threadTestId,row.source,row.href])).toEqual([['thread-root','reply','/RUN/issues/task']]); }); // Full cohort on 9296c74e8d (choose-primary, case-history, set-budget): the API saw the saved reply ~2s before // the open conversation rendered it, so links read in between were empty although the reply linked correctly. describe("waits for the latest saved reply to render before reading links", () => { const page = () => ({ evaluate: async (read: (arg: A) => T, arg: A) => read(arg) }) as unknown as Parameters[0]; it("reads the reply's links once the reply renders after the API saw it", async () => { document.querySelector('#comment-reply')!.remove(); setTimeout(() => document.querySelector('[data-testid="task-chat-scroller"]')!.insertAdjacentHTML("beforeend", ''), 600); const value = input(); value.projects = []; value.activity = []; expect((await collectConversationLinks(page(), value)).map(row => row.href)).toEqual(["/RUN/issues/task"]); }); it("does not wait when the conversation is not open, and waits at most once for a reply that never renders", async () => { const bindings = conversationLinkBindings(input()); document.body.innerHTML = "
Other page
"; expect(readLatestConversationReplyRender({ anchors: bindings.anchors, latest: "reply" })).toBe("closed"); document.body.innerHTML = thread(); document.querySelector('#comment-reply')!.remove(); const p = page(); expect(await waitForLatestConversationReplyRender(p, bindings, 300, 50)).toBe("pending"); const started = Date.now(); expect(await waitForLatestConversationReplyRender(p, bindings, 5_000, 50)).toBe("pending"); expect(Date.now() - started).toBeLessThan(1_000); }); // Cohort 3 on dfd2a6efca (access.other-company, teams.install-team and six more): the final evidence read // ran on a freshly loaded conversation whose wait had expired in an earlier document, so it read instantly // and saved no links although the reply rendered them. A new document gets its own bounded wait. it("waits again in a newly loaded document after an earlier document's wait expired", async () => { const bindings = conversationLinkBindings(input()); document.body.innerHTML = thread(); document.querySelector('#comment-reply')!.remove(); const p = page(); expect(await waitForLatestConversationReplyRender(p, bindings, 200, 50)).toBe("pending"); delete (window as typeof window & { __paperclipConversationLinkDocument?: string }).__paperclipConversationLinkDocument; setTimeout(() => document.querySelector('[data-testid="task-chat-scroller"]')!.insertAdjacentHTML("beforeend", ''), 300); expect(await waitForLatestConversationReplyRender(p, bindings, 5_000, 50)).toBe("rendered"); }); }); // Full cohort 3 (fast-responses, choose-primary, set-budget): the run was recorded finished 0.2-1.3s before its // reply comment was saved, so a link read right after the run finished saw no reply at all. describe("waits for a finished run's reply to be saved, then rendered, before its links are read", () => { const page = () => ({ evaluate: async (read: (arg: A) => T, arg: A) => read(arg) }) as unknown as Parameters[0]; it("waits for the reply saved after the run finished and for its render", async () => { const saved = input().comments, before = saved.filter(row => row.id !== "reply"); document.querySelector('#comment-reply')!.remove(); let reads = 0; const comments = async () => (reads++ < 3 ? before : saved); setTimeout(() => document.querySelector('[data-testid="task-chat-scroller"]')!.insertAdjacentHTML("beforeend", ''), 400); expect(await waitForSavedTurnReplyRender(page(), { comments, leadId: "ceo", runIds: ["run"] }, 3_000, 50)).toBe("rendered"); expect(reads).toBeGreaterThan(3); }); it("reports a run that saved no reply in time, without waiting past its bound", async () => { const before = input().comments.filter(row => row.id !== "reply"); const started = Date.now(); expect(await waitForSavedTurnReplyRender(page(), { comments: async () => before, leadId: "ceo", runIds: ["run"] }, 300, 50)).toBe("unsaved"); expect(Date.now() - started).toBeLessThan(1_500); }); }); // Full cohort 5 on 98c18784c6 (cases.case-history, tasks.ambiguous-task): the final reply was saved by run // finalization after the run's terminal status and logged no comment_added, so the open conversation never // fetched it; the thread kept only the person's message. One reload reads the saved conversation. describe("reloads once when a saved reply never renders in the open conversation", () => { beforeEach(() => { vi.useFakeTimers(); }); afterEach(() => { vi.useRealTimers(); }); const settle = async (waiting: Promise) => { await vi.runAllTimersAsync(); return waiting; }; const reloading = (onReload: () => void) => { let reloads = 0; const page = { evaluate: async (read: (arg: A) => T, arg: A) => read(arg), reload: async () => { reloads++; delete (window as typeof window & { __paperclipConversationLinkDocument?: string }).__paperclipConversationLinkDocument; onReload(); } }; return { page: page as unknown as Parameters[0], reloads: () => reloads }; }; it("renders after the reload and records both waits", async () => { const comments = async () => input().comments; document.querySelector('#comment-reply')!.remove(); const p = reloading(() => document.querySelector('[data-testid="task-chat-scroller"]')!.insertAdjacentHTML("beforeend", '')); const wait = await settle(waitForSavedTurnReplyRenderReloadingOnce(p.page, { comments, leadId: "ceo", runIds: ["run"] }, 300, 50)); expect(wait.result).toBe("rendered"); expect(p.reloads()).toBe(1); expect(wait.attempts.map(row => [row.phase, row.result])).toEqual([["open-document", "pending"], ["after-reload", "rendered"]]); }); it("waits for the reloaded app to mount the conversation before the second wait", async () => { const comments = async () => input().comments; document.querySelector('#comment-reply')!.remove(); const saved = document.body.innerHTML; const p = reloading(() => { document.body.innerHTML = "
Loading
"; setTimeout(() => { document.body.innerHTML = saved; document.querySelector('[data-testid="task-chat-scroller"]')!.insertAdjacentHTML("beforeend", ''); }, 300); }); const wait = await settle(waitForSavedTurnReplyRenderReloadingOnce(p.page, { comments, leadId: "ceo", runIds: ["run"] }, 1_000, 50)); expect(wait.attempts.map(row => [row.phase, row.result])).toEqual([["open-document", "pending"], ["after-reload", "rendered"]]); }); it("does not reload a reply that rendered live, and still reports a reply that never renders", async () => { const comments = async () => input().comments; const live = reloading(() => undefined); expect((await settle(waitForSavedTurnReplyRenderReloadingOnce(live.page, { comments, leadId: "ceo", runIds: ["run"] }, 300, 50))).result).toBe("rendered"); expect(live.reloads()).toBe(0); document.querySelector('#comment-reply')!.remove(); const never = reloading(() => undefined); const wait = await settle(waitForSavedTurnReplyRenderReloadingOnce(never.page, { comments, leadId: "ceo", runIds: ["run"] }, 200, 50)); expect(wait.result).toBe("pending"); expect(never.reloads()).toBe(1); expect(wait.attempts).toHaveLength(2); }); }); describe("task links whose visible identifier names another task", () => { it("accepts links whose label names the task they open, or names no task", () => { expect(mislabeledIssueLinks("Open [COM-1](/COM/issues/COM-1) in [Launch](/COM/projects/launch).")).toEqual([]); expect(mislabeledIssueLinks("The [open COM-1 task](/COM/issues/com-1#document-plan) and [this one](/COM/issues/COM-2).")).toEqual([]); expect(mislabeledIssueLinks("[COM-1 Launch open website](/COM/issues/task-uuid)", id => id === "task-uuid" ? "COM-1" : undefined)).toEqual([]); expect(mislabeledIssueLinks("[SHA-256 notes for COM-1](/COM/issues/COM-1)")).toEqual([]); }); it("rejects a link whose label names a different task than it opens", () => { expect(mislabeledIssueLinks("Open tasks: [COM-2 Launch open website](/COM/issues/COM-1)... correction:")).toEqual(["[COM-2 Launch open website](/COM/issues/COM-1)"]); expect(mislabeledIssueLinks("[COM-2](/COM/issues/task-uuid)", id => id === "task-uuid" ? "COM-1" : undefined)).toHaveLength(1); }); }); // Full cohort 4 (case-history, goals.explain-purpose, preview-service): a phase capture that saved no links could // not say whether the thread was closed, showed another conversation, or rendered the reply without anchors. describe("records thread and anchor diagnostics when a saved reply yields no rendered links", () => { const page = () => ({ evaluate: async (read: (arg: A) => T, arg: A) => read(arg) }) as unknown as Parameters[0]; it("reports the rendered thread, its saved comment anchors and the reply's anchor count", async () => { const value = input(); value.projects = []; value.activity = []; vi.spyOn(console, "info").mockImplementation(() => undefined); const result = await collectConversationLinksWithDiagnostics(page(), value); expect(result.links).toEqual([]); expect(result.diagnostics).toEqual({ render: "rendered", expectedReplyIds: ["reply"], savedCommentCount: 2, threads: [{ testId: "task-chat-thread", visible: true, renderedCommentIds: ["human", "reply"], foreignCommentIds: [], replyAnchorCounts: { reply: 0 } }] }); }); it("adds no diagnostics when links were read", async () => { document.querySelector('#comment-reply')!.innerHTML = 'Task'; const value = input(); value.projects = []; value.activity = []; const result = await collectConversationLinksWithDiagnostics(page(), value); expect(result.links.map(row => row.href)).toEqual(["/RUN/issues/task"]); expect(result.diagnostics).toBeUndefined(); }); }); // Full cohort 9 (documents-artifacts.produce-download, agents.edit-instructions): a reply's download link was written as // /COM/api/attachments/.../content?download=1, which the server does not serve (its API is only at /api), and a reply's // Morgan link was saved as //COM/agents/..., which the board repairs but notifications and chat channels deliver as a // link to a host named COM. Both counted as valid links. describe("only links that open a served app page or API route count", () => { const origin = "https://fixture.test"; it("accepts company pages, unprefixed board pages, global pages and served API downloads", () => { for (const href of ["/RUN/issues/RUN-1", "/run/agents/morgan/overview", "/RUN/company/settings/connections", "/RUN/routines/routine", "/RUN", "/issues/RUN-1", "/instance/settings", "/api/attachments/file/content?download=1", "/api/attachments/file/content", "https://github.com/owner/repository"]) expect(unservedLinkReason(href, origin), href).toBeUndefined(); }); it("rejects a company-prefixed API path, a doubled prefix and other paths the app does not route", () => { for (const href of ["/RUN/api/attachments/file/content?download=1", "/RUN/RUN/issues/RUN-1", "/RUN/attachments/file/content", "/attachments/file/content"]) expect(unservedLinkReason(href, origin), href).toBe("not-a-served-route"); }); it("rejects a protocol-relative company link, rendered raw or repaired by the board, but not the same page saved correctly", () => { expect(unservedLinkReason("//RUN/agents/morgan", origin)).toBe("protocol-relative"); expect(unservedLinkReason("/RUN/agents/morgan", origin, ["//RUN/agents/morgan"])).toBe("protocol-relative"); expect(unservedLinkReason("/RUN/agents/morgan", origin, ["/RUN/agents/morgan"])).toBeUndefined(); expect(unservedLinkReason("/RUN/agents/morgan", origin, ["//RUN/agents/morgan", "/RUN/agents/morgan"])).toBeUndefined(); }); it("lists exactly the first path segments that the board router declares", () => { const app = readFileSync(`${import.meta.dirname}/../../ui/src/App.tsx`, "utf8"); const roots = new Set([...app.matchAll(/path="\/?([^"/]+)/g)].map(match => match[1]!).filter(root => !root.startsWith(":") && root !== "*")); expect([...APP_ROUTE_ROOTS].sort()).toEqual([...roots].sort()); expect(APP_ROUTE_ROOTS).not.toContain("api"); }); it("drops unserved reply links from collection, keeps them as rejected evidence and keeps served ones", async () => { const page = { evaluate: async (read: (arg: A) => T, arg: A) => read(arg) } as unknown as Parameters[0]; vi.spyOn(console, "info").mockImplementation(() => undefined); document.querySelector('#comment-reply')!.innerHTML = 'website.htmlDownloadMorgan'; const value = input(); value.projects = []; value.activity = []; value.comments[1]!.body = "Prepared [website.html](/api/attachments/file/content). [Download](/RUN/api/attachments/file/content?download=1) from [Morgan](//RUN/agents/morgan)."; const result = await collectConversationLinksWithDiagnostics(page, value); expect(result.links.map(row => row.href)).toEqual(["/api/attachments/file/content"]); expect(result.rejected?.map(row => [row.href, row.reason])).toEqual([["/RUN/api/attachments/file/content?download=1", "not-a-served-route"], ["/RUN/agents/morgan", "protocol-relative"]]); }); });