import { describe, it, expect } from "vitest"; import { deflateRawSync } from "node:zlib"; import { gradeQueuedFollowup, historyReadRevisions, keyboardMoveQueuedMessageUp, promptCarriesComment, queuedFollowUpBrief, readCurrentRevision, resultCitedCommentIds, zipEntryTexts } from "./runtime-queue.js"; /** A minimal zip with one deflated and one stored entry, laid out as zip tools write it. */ function zip(entries: Array<{ name: string; text: string; deflate: boolean }>) { const locals: Buffer[] = [], centrals: Buffer[] = []; let offset = 0; for (const entry of entries) { const name = Buffer.from(entry.name), raw = Buffer.from(entry.text), data = entry.deflate ? deflateRawSync(raw) : raw; const local = Buffer.alloc(30); local.writeUInt32LE(0x04034b50, 0); local.writeUInt16LE(entry.deflate ? 8 : 0, 8); local.writeUInt32LE(data.length, 18); local.writeUInt32LE(raw.length, 22); local.writeUInt16LE(name.length, 26); const central = Buffer.alloc(46); central.writeUInt32LE(0x02014b50, 0); central.writeUInt16LE(entry.deflate ? 8 : 0, 10); central.writeUInt32LE(data.length, 20); central.writeUInt32LE(raw.length, 24); central.writeUInt16LE(name.length, 28); central.writeUInt32LE(offset, 42); locals.push(local, name, data); centrals.push(central, name); offset += 30 + name.length + data.length; } const directory = Buffer.concat(centrals), end = Buffer.alloc(22); end.writeUInt32LE(0x06054b50, 0); end.writeUInt16LE(entries.length, 8); end.writeUInt16LE(entries.length, 10); end.writeUInt32LE(directory.length, 12); end.writeUInt32LE(offset, 16); return Buffer.concat([...locals, directory, end]); } function valid() { return { scenarioId: "steering.queue-follow-up", origin: "http://fixture.invalid", companyId: "company", leadId: "ceo", state: { task: { id: "website", identifier: "PAP-7" }, worker: { id: "morgan" }, workerStatusAtReply: "running", canonicalRunId: "controller", queuedAtReply: { issueId: "website", state: "queued", entries: [{ position: 0, comment: { id: "contact", body: "Add a contact section", authorAgentId: "ceo", createdByRunId: "controller" } }] }, queryReply: "I saved the contact request on [PAP-7](/PAP/issues/PAP-7) for Morgan's next turn.", consumedCommentId: "contact", deliveryNativeInputBound: true, consumingRunCount: 1, queueEmptyAfterDelivery: true, initialBriefRevisionRetained: true, contactResultRevision: true }, agents: [], tasks: [{ id: "website", assigneeAgentId: "morgan", status: "done" }], links: [], activity: [], reply: "", humanQueries: [], runs: [{ id: "prior", agentId: "morgan", status: "succeeded" }, { id: "controller", agentId: "ceo", status: "succeeded" }, { id: "successor", agentId: "morgan", status: "succeeded" }] }; } it("accepts actual ordered queue admission and one later consuming native turn", () => expect(gradeQueuedFollowup(valid()).passed).toBe(true)); it("accepts a reworded reply that names the task without queue vocabulary", () => { const o = valid(); o.state.queryReply = "Morgan is mid-turn on PAP-7. Your contact section will reach him once he finishes."; expect(gradeQueuedFollowup(o).passed).toBe(true); }); it("accepts a requirement worded without the word contact", () => { const o = valid(); o.state.queuedAtReply.entries[0]!.comment.body = "Please add a way for visitors to reach us."; expect(gradeQueuedFollowup(o).passed).toBe(true); }); it("rejects absent queue evidence", () => expect(gradeQueuedFollowup(undefined).passed).toBe(false)); it("rejects forwarding to a similarly named task", () => { const o = valid(); o.state.queuedAtReply.issueId = "other"; expect(gradeQueuedFollowup(o).passed).toBe(false); }); it("rejects a reply that does not identify the affected task", () => { const o = valid(); o.state.queryReply = "Done, I passed it along."; expect(gradeQueuedFollowup(o).passed).toBe(false); }); it("rejects a different identifier that shares the prefix", () => { const o = valid(); o.state.queryReply = "Saved on PAP-70."; expect(gradeQueuedFollowup(o).passed).toBe(false); }); it("rejects a requirement written by someone other than the canonical controller turn", () => { const o = valid(); o.state.queuedAtReply.entries[0]!.comment.createdByRunId = "other-run"; expect(gradeQueuedFollowup(o).passed).toBe(false); }); it("rejects a successor without the actual saved comment in its native input", () => { const o = valid(); o.state.deliveryNativeInputBound = false; expect(gradeQueuedFollowup(o).passed).toBe(false); }); it("rejects duplicate requirement admission", () => { const o = valid(); o.state.queuedAtReply.entries.push({ ...o.state.queuedAtReply.entries[0]!, position: 1 }); expect(gradeQueuedFollowup(o).passed).toBe(false); }); it("rejects losing the original worker's saved work", () => { const o = valid(); o.state.initialBriefRevisionRetained = false; expect(gradeQueuedFollowup(o).passed).toBe(false); }); it("rejects output attributed to the wrong native revision", () => { const o = valid(); o.state.contactResultRevision = false; expect(gradeQueuedFollowup(o).passed).toBe(false); }); it("accepts the contact section delivered as the successor's registered build instead of a document", () => { const o = valid(); o.state.contactResultRevision = false; Object.assign(o.state, { contactResultDeliverable: true }); expect(gradeQueuedFollowup(o).passed).toBe(true); }); it("rejects a successor deliverable without the contact section", () => { const o = valid(); o.state.contactResultRevision = false; Object.assign(o.state, { contactResultDeliverable: false }); expect(gradeQueuedFollowup(o).passed).toBe(false); }); it("reads stored and deflated zip entries and treats other bytes as no entries", () => { const bytes = zip([{ name: "site/index.html", text: '

Contact

', deflate: true }, { name: "site/styles.css", text: "body{margin:0}", deflate: false }]); expect(zipEntryTexts(bytes)).toEqual(['

Contact

', "body{margin:0}"]); expect(zipEntryTexts(Buffer.from("Contact"))).toEqual([]); expect(zipEntryTexts(bytes.subarray(0, bytes.length - 30))).toEqual([]); }); it("finds the saved comment in a native prompt raw or JSON-escaped, and only with its id and body", () => { const comment = { id: "c-1", body: "Add a \"Contact us\" section\nwith email." }; const prompt = `{"newComments":[{"id":"c-1","body":${JSON.stringify(comment.body)}}]}`; expect(promptCarriesComment(prompt, comment)).toBe(true); expect(promptCarriesComment(`plain c-1\n${comment.body}`, comment)).toBe(true); expect(promptCarriesComment(prompt.replace("c-1", "c-2"), comment)).toBe(false); expect(promptCarriesComment("continue the website task c-1", comment)).toBe(false); expect(promptCarriesComment(undefined, comment)).toBe(false); }); it("finds the saved comment when a continuation envelope nests the events JSON as a string", () => { const comment = { id: "c-1", body: "Add a \"Contact\" section.\n\n- nav link" }; const prompt = JSON.stringify({ schema: "paperclip.native-continuation.v1", events: JSON.stringify({ messages: [{ id: "c-1", body: comment.body }, { id: "c-2", body: "Done." }] }) }); expect(prompt.includes(comment.body) || prompt.includes(JSON.stringify(comment.body).slice(1, -1))).toBe(false); expect(promptCarriesComment(prompt, comment)).toBe(true); expect(promptCarriesComment(JSON.stringify({ events: JSON.stringify({ messages: [{ id: "c-1", body: "Add a section." }] }) }), comment)).toBe(false); expect(promptCarriesComment(JSON.stringify({ events: JSON.stringify({ messages: [{ id: "c-2", body: comment.body }], note: "c-1" }) }), comment)).toBe(false); }); // Full cohort 5 on 98c18784c6 (steering.approval-delivery, steering.edit-queued-message): the gesture was pressed // right after Save while the handle was still disabled, so no PUT /queued-comments/order was sent. function reorderPage(enableAfterMs: number) { const enabledAt = Date.now() + enableAfterMs, pressed: Array<{ key: string; enabled: boolean }> = []; let resolveResponse!: (value: unknown) => void; let dragging = false; const page = { waitForResponse: (match: (response: unknown) => boolean, options: { timeout: number }) => new Promise((resolve, reject) => { resolveResponse = value => { if (match(value)) resolve(value); }; setTimeout(() => reject(new Error("timeout")), options.timeout); }), evaluate: async () => undefined }; const handle = { isEnabled: async () => Date.now() >= enabledAt, focus: async () => undefined, getAttribute: async (name: string) => name === "aria-pressed" && dragging ? "true" : null, press: async (key: string) => { const enabled = Date.now() >= enabledAt; pressed.push({ key, enabled }); if (enabled && key === "Space") dragging = !dragging; if (enabled && key === "Space" && pressed.filter(row => row.key === "Space").length === 2) resolveResponse({ request: () => ({ method: () => "PUT" }), url: () => "http://127.0.0.1/api/issues/t/queued-comments/order", status: () => 200 }); } }; return { page: page as never, handle: handle as never, pressed }; } it("waits for the reorder handle to be enabled before the keyboard gesture, and returns the order request's status", async () => { const fake = reorderPage(300); const result = await keyboardMoveQueuedMessageUp(fake.page, fake.handle, 3_000, 20); expect(result.status).toBe(200); expect(result.waitedForEnabledMs).toBeGreaterThanOrEqual(250); expect(fake.pressed.every(row => row.enabled)).toBe(true); }); it("fails when the handle never enables or the gesture sends no order request", async () => { await expect(keyboardMoveQueuedMessageUp(reorderPage(10_000).page, reorderPage(10_000).handle, 200, 20)).rejects.toThrow(/stayed disabled/); const silent = reorderPage(0); const handle = { ...(silent.handle as object), press: async () => undefined }; await expect(keyboardMoveQueuedMessageUp(silent.page, handle as never, 200, 20)).rejects.toThrow(/sent no queue order request/); }); // Full cohort 9 (master b1ef1f3022, steering.edit-queued-message): the person's edit saved (PATCH 200), the handle was // enabled, but the keyboard gesture sent no PUT /queued-comments/order within 15 s. it("refetches and presses the gesture again when the first gesture sends no order request, and still fails when none does", async () => { const fake = reorderPage(0); let reloads = 0, sends = false; const handle = { ...(fake.handle as object), press: async (key: string) => { if (sends) await (fake.handle as { press: (k: string) => Promise }).press(key); } }; const result = await keyboardMoveQueuedMessageUp(fake.page, handle as never, 200, 20, { attempts: 2, beforeRetry: async () => { reloads++; sends = true; } }); expect(result).toMatchObject({ status: 200, gestures: 2 }); expect(reloads).toBe(1); const first = reorderPage(0); const once = await keyboardMoveQueuedMessageUp(first.page, first.handle, 3_000, 20, { attempts: 2, beforeRetry: async () => { reloads++; } }); expect(once.gestures).toBe(1); expect(reloads).toBe(1); const silent = reorderPage(0); let retried = 0; await expect(keyboardMoveQueuedMessageUp(silent.page, { ...(silent.handle as object), press: async () => undefined } as never, 200, 20, { attempts: 2, beforeRetry: async () => { retried++; } })).rejects.toThrow(/sent no queue order request after 2 gesture/); expect(retried).toBe(1); }); describe("task history reads", () => { const event = (comments: unknown, eventType = "task_history.read") => ({ eventType, payload: { comments } }); it("keeps the newest revision each comment was read at, from history-read events only", () => { expect(historyReadRevisions([event({ a: "2026-11-12T21:50:00.000Z" }), event({ a: "2026-11-12T21:52:30.494Z", b: "2026-11-12T21:50:24.404Z" }), event({ a: "2026-11-12T21:49:00.000Z" }), event({ c: "2026-11-12T21:59:00.000Z" }, "tool.execution.completed"), event(["a"]), event({ d: "not a date" })])) .toEqual({ a: "2026-11-12T21:52:30.494Z", b: "2026-11-12T21:50:24.404Z" }); }); it("counts a read only at or after the comment's current revision", () => { const reads = { a: "2026-11-12T21:52:30.494Z" }; expect(readCurrentRevision(reads, { id: "a", updatedAt: "2026-11-12T21:52:30.494Z" })).toBe(true); expect(readCurrentRevision(reads, { id: "a", updatedAt: "2026-11-12T21:52:31.000Z" })).toBe(false); expect(readCurrentRevision(reads, { id: "b", updatedAt: "2026-11-12T21:50:00.000Z" })).toBe(false); expect(readCurrentRevision(reads, undefined)).toBe(false); }); }); it("reads comment citations only from the run's accepted result", () => { const id = "3047528e-3c1d-41ee-94e9-122ee17f3032", other = "b9e3ab32-934e-4d07-a5cf-e06fc28d574a"; const accepted = (result: unknown) => ({ eventType: "run.result.accepted", payload: { prpEvent: { payload: { result } } } }); expect(resultCitedCommentIds([accepted({ evidence: [{ ref: `comment:${id} (applied)` }, { ref: "document:plan" }] })])).toEqual([id]); expect(resultCitedCommentIds([accepted({ evidence: [], completionClaim: { criteria: [{ evidenceRefs: [`comment:${other}`] }] } })])).toEqual([other]); expect(resultCitedCommentIds([accepted({ evidence: [{ ref: `comment:${other.toUpperCase()}` }, { ref: `Comment:${other}` }] })])).toEqual([]); expect(resultCitedCommentIds([{ eventType: "run.result.proposed", payload: { prpEvent: { payload: { result: { evidence: [{ ref: `comment:${id}` }] } } } } }])).toEqual([]); expect(resultCitedCommentIds([accepted({ evidence: [{ ref: `document:comment:${id}` }, { ref: "comment:not-a-comment" }] })])).toEqual([]); }); describe("queued follow-up brief", () => { const brief = queuedFollowUpBrief("Original website brief n1"); it("gives the worker a complete website brief bound to its reference", () => { expect(brief).toContain("reference Original website brief n1"); for (const part of ["Acorn Notes", "website.html", "Research notes your whole team can find", "Request early access", "Free for teams", "hello@acornnotes.example"]) expect(brief).toContain(part); }); it("does not pre-complete the queued contact requirement", () => expect(brief).not.toMatch(/contact/i)); }); // Full cohort 12 (steering.edit-queued-message, as in cohort 9): the edit saved, but Space, ArrowUp, Space pressed // back to back sent no PUT /queued-comments/order in 2 gestures. dnd-kit starts a keyboard drag on Space, listens // for later keys only after a timer, and moves only after measuring the rows on a later render, so a key pressed // before then is dropped and the closing Space drops the item where it started. function asyncDragPage() { let resolveResponse!: (value: unknown) => void, dragging = false, activatedAt = 0, moved = false; const page = { waitForResponse: (match: (response: unknown) => boolean, options: { timeout: number }) => new Promise((resolve, reject) => { resolveResponse = value => { if (match(value)) resolve(value); }; setTimeout(() => reject(new Error("timeout")), options.timeout); }), evaluate: () => new Promise(resolve => setTimeout(resolve, 20)) }; const ready = () => dragging && Date.now() - activatedAt >= 15; const handle = { isEnabled: async () => true, focus: async () => undefined, getAttribute: async (name: string) => name === "aria-pressed" && Date.now() >= activatedAt && dragging ? "true" : null, press: async (key: string) => { if (key === "Space" && !dragging) { dragging = true; activatedAt = Date.now() + 10; moved = false; return; } if (!ready()) return; if (key === "ArrowUp") moved = true; if (key === "Space") { dragging = false; if (moved) resolveResponse({ request: () => ({ method: () => "PUT" }), url: () => "http://127.0.0.1/api/issues/t/queued-comments/order", status: () => 200 }); } } }; return { page: page as never, handle: handle as never }; } it("waits for the keyboard drag to start and the page to settle between keys", async () => { const fake = asyncDragPage(); await expect(keyboardMoveQueuedMessageUp(fake.page, fake.handle, 500, 5)).resolves.toMatchObject({ status: 200, gestures: 1, dragStarted: [true] }); }); it("reports a gesture whose drag never starts instead of pressing keys blind", async () => { const fake = asyncDragPage(); const handle = { ...(fake.handle as object), getAttribute: async () => null }; await expect(keyboardMoveQueuedMessageUp(fake.page, handle as never, 200, 5)).rejects.toThrow(/drag started: false/); });