mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-20 00:53:46 +01:00
ffcd49f6aaf707fa0902e7d19bf1acfaa94bddef
2
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
bf55063567 |
fix(server): keep chat titles current and space verification retries (#22102)
## Thinking Path > - Paperclip manages AI agents and their work. > - Agent chats use persistent tasks, and remote runs verify their provider files before execution. > - A chat keeps the name that its agent had when the chat was created. > - A fast gateway failure can consume both verification attempts before the gateway recovers. > - This change updates generated chat titles on an agent rename and waits before a verification retry. > - Chats show the current name, and a short gateway fault has time to clear. ## Linked Issues or Issue Description **What happened?** Renaming an agent leaves existing generated chat titles unchanged. Remote provider verification also retries a transport failure immediately. Two fast HTTP 502 responses can fail startup before the model starts. **Expected behavior** Generated chat titles follow an agent rename. A read-only verification retry gives the remote gateway time to recover. Verification still rejects incompatible files and stops after two attempts. **Steps to reproduce** 1. Open a chat with an agent, then rename that agent. Inspect the task linked from a run: its title still has the old agent name. 2. Make the remote verification transport return HTTP 502 for one second. Start verification. Both immediate attempts fail before the transport recovers. Related: #22087 covers a provider connection failure during lease acquisition. This change covers a later provider-file verification request. ## What Changed - Update matching generated chat titles in the agent configuration transaction. Preserve custom chat titles, ordinary task titles, and other agents' chats. - Record each changed chat as `issue.updated` and publish its event after commit so open pages refresh. Roll back the rename and queued events if audit persistence fails. - Derive new chat titles from the current agent name under the existing company transaction lock. Both user-opened and proactive chats use this path, including a create that read the old name before a rename committed. - Acquire that company lock before proactive chat delivery takes chat or agent row locks, so delivery and renames use a consistent lock order. - Wait one second before the second remote verification attempt. Keep the existing attempt limit, transport timeouts, artifact checks, and failure codes. - Add route and startup-verification regressions. Document the retry delay. - Wait for the connection-review E2E fixture to save its Ask first permission before it creates a task or navigates away. ## Verification - Final acceptance on `3fb74ffaf6fa0ee2ecbe5dba3d01d252cb0c986f`: [full CI run](https://github.com/paperclipai/paperclip/actions/runs/44208144377) is green, all 61 reported checks are complete with no failures, Greptile is 5/5 on this exact commit, all review threads are resolved, and GitHub reports the branch clean and mergeable. - Red/green: the rename test retained the old titles before the fix. The gateway recovery test consumed both attempts before the one-second recovery point. Both pass with the changes. - The live-update and concurrent-create tests failed on the first PR revision: no title events were published, and a paused chat creation retained the old name. The fixes queue events for publication after commit and re-read the agent name under the company lock. Both reproductions now pass. - `pnpm exec vitest run server/src/__tests__/agent-configuration-save.test.ts server/src/__tests__/agent-chat-messages.test.ts server/src/__tests__/agent-conversations.test.ts server/src/services/native-runtime/remote-provider-pack.test.ts server/src/services/native-runtime/remote-provider-pack-verification.test.ts`: 191 passed on macOS, including the concurrent rename/message regression. - `pnpm --filter @paperclipai/server typecheck`: passed, including source and test layers. - Earlier CI on `de2a0a4` failed in the release-registry watchdog self-test ([job log](https://github.com/paperclipai/paperclip/actions/runs/44202511888/job/134460224014)). Its 1.5-second watchdog fired during `starting the file's tests`; the assertion expected `test "waits forever"`. Both reporter files are unchanged from the base and current head. `node --test scripts/ci/stalled-file-reporter.test.mjs` passed all 7 tests on macOS with Node v25.6.1. The current revision also passed the Linux Typecheck + Release Registry CI check; no reporter code was changed. - CI on `c83fcd9` failed the connection-review failure journey ([shard log](https://github.com/paperclipai/paperclip/actions/runs/44204043415/job/134465938135)). Navigation aborted the pending permission save, so the fixture tool ran without creating the expected approval card. A temporary two-second delay on that save reproduced the failure locally. With the response wait, the same delayed-save reproduction passed. The temporary delay is removed from the diff. - `node scripts/typecheck-test-projects.mjs --reuse-declarations tests/e2e`: passed using the server declarations from the same application source revision. - Before the rebase, the complete connection-review spec passed 4 journeys and skipped the controlled-restart journey under the default configuration. On `95fb2aa`, rebased onto `9032f55d83e`, the provider-failure journey, all 190 focused tests, server typecheck, and E2E test-project typecheck passed again. The dedicated controlled-restart suite was not run. - A concurrent rename/message regression reproduced PostgreSQL `40P01: deadlock detected` on `95fb2aa`. Delivery now takes the shared company lock before the chat and agent locks. The regression uses observed PostgreSQL blockers to stage the collision, and both operations commit with the fix. Concurrent creation also waits behind the same lock and retains the renamed title. - The application tree for `3fb74ff` passed all 191 focused tests and server typecheck. The subsequent rebase onto `96907f5518c` changed only `.github/CODEOWNERS` compared with that tested tree. The full CI run for this revision is now green. - CI jobs on `95fb2aa` were interrupted after their runners received shutdown signals: [server shard](https://github.com/paperclipai/paperclip/actions/runs/44206614135/job/134474311777), [workspace shard](https://github.com/paperclipai/paperclip/actions/runs/44206614135/job/134474311921), [typecheck/release registry](https://github.com/paperclipai/paperclip/actions/runs/44206614135/job/134474310521), and [serialized server shard](https://github.com/paperclipai/paperclip/actions/runs/44206614135/job/134474311690). The typecheck job is labelled failed, but its active step was cancelled. These interruptions did not supply passing test evidence. The fresh CI run on `3fb74ff` completed without failures. - `pnpm verify --explain`: exit 2. The changed recovery document requires broad CI coverage. Required CI supplies the full test and build coverage; no full local suite or build was run. - `git diff --check` and a Gitleaks scan of the diff passed. The diff was also checked for personal data and private identifiers. ## Risks - An inconclusive verification takes one extra second before its last attempt. A persistent outage still fails with the existing named error. No provider turn or artifact mutation is replayed by this retry. - Only chat titles that match the previous generated title change. Earlier stale titles and custom titles need an explicit correction. - Proactive chat delivery now shares the existing company writer lock with agent configuration. Concurrent writes in that company wait for the active transaction to finish. - No schema, session, checkpoint, launch identity, or pack identity changes. State saved by the previous release carries forward with the same verification checks and attempt limit. - Revert this commit to restore the previous behavior. Existing title updates are metadata and need no schema rollback. ## Model Used - OpenAI Codex, `gpt-6.1-sol`, xhigh reasoning, with source inspection, browser investigation, and local code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> |
||
|
|
dcc0878b32 |
perf(agents): save healthy account settings without a runtime probe (#18690)
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The agent runtime page saves account, model, and environment settings. > - The save handler starts a computer and runs a live account test before it writes the edit. > - A slow computer or provider can make a healthy account save take tens of seconds. > - Saved account health, access, installation, and compatibility can be checked without a runtime test. > - This pull request uses those checks for ordinary configuration saves. > - Legacy adoption, task adoption, and Copilot model checks keep live verification. > - The benefit is a fast save while Test and execution retain runtime checks. ## Linked Issues or Issue Description **What happened?** Saving a new AI account selection on an existing agent can take 20–30 seconds. Model edits can take the same path. The configuration PATCH acquires a computer, prepares account credentials, runs a provider/runtime probe, and releases the computer before it saves. **Expected behavior** A healthy installed account can be saved after current access and compatibility checks. A save confirms persistence. Test verifies the runtime. An unverified legacy account must still pass live adoption checks. **Steps to reproduce** Run the PostgreSQL regression with a 20-second controlled delay at computer allocation. On the original route, a successful save takes 20,191 ms and calls allocation and the runtime probe once. With the first patch, the same fixture takes 51 ms; with the environment-guard correction, it takes 37 ms and calls neither operation. Each timing has one sample. This is a local fault experiment with real HTTP and PostgreSQL. It is not a hosted latency measurement. Related: #17760 addresses binding comparison and prospective probe environment resolution. This change deliberately removes the live probe from ordinary healthy-account saves. It keeps live checks for legacy and task adoption. #17965 fixes the result of an explicit managed Runner test. Neither change removes this save-time wait. #18687 optimizes a different Apps configuration read. ## What Changed - Replace the internal probe boolean with explicit none, legacy, and always modes. - Use legacy mode for ordinary configuration saves. Keep current account health, access, installation, compatibility, environment, audit, and revision checks. - Keep the environment company check before the live-probe branch. Keep the live task-adoption transaction and Copilot model checks. - Add twelve real PostgreSQL save-route regressions, including company-bound environment checks. Keep the existing inherited-sandbox adoption fixture for legacy and task adoption. - Cover healthy and legacy settings changes separately. Keep provider rejection and reconnect tests on the legacy save path. - Update the specification and feature/access maps to distinguish saving from runtime verification. The configuration route owns this policy. The account service still owns account access and health. The existing environment test service still owns live probes. No new endpoint, migration, dependency, background job, or provider protocol is added. ## Verification Base: `3f8ebfff8aa9febd0733c6f65b07485dcadfd0e2`. - Original route with initial regressions: three failures and two passes. Healthy saves reached computer allocation. The controlled 20-second baseline saved successfully but failed the no-allocation assertion. - Initial save/adoption/Copilot selection: 21 passed. The name filter excluded 141 unrelated tests. The seven new cases cover persistence, revision and activity records, model edits, roster edits and stale retries, missing installation, revoked grants, legacy verification, and controlled allocation latency. - Explicit Test-route suite: 55 passed. The first attempt reached the 30-second import hook limit. The same suite passed with a 90-second hook limit. - Saved harness preflight suite: six passed. Account revocation, compatibility, probe failure and target release checks remain. - `node scripts/check-maps.mjs` and `git diff --check`: passed. - Review revision: both full save/account suites passed, 96 tests total. The controlled save took 37.08 ms with zero computer allocations and zero provider probes. The five new environment checks passed after the three foreign-environment cases failed against the first patch. - Local full `pnpm -r typecheck`: unavailable because cargo is missing. - Local full `pnpm build`: unavailable at the verified Copilot runtime prerequisite. Server typecheck preparation also reaches missing cargo. - Local full `pnpm test:run`: stopped after concurrent broad checks exceeded the container memory limit. No full-suite pass is claimed. Direct server TypeScript checking and its bounded retry were also killed by the container memory limit. The first remote Typecheck + Release Registry check passed; the next head still requires fresh CI. Reproduce the controlled timing: ```sh cd server PAPERCLIP_CONFIG_SAVE_PROFILE_DELAY_MS=20000 pnpm exec vitest run src/__tests__/agent-configuration-save.test.ts --hookTimeout 90000 ``` The fixture keeps real Express, authorization, account selection, PostgreSQL persistence, revisions and audit writes. Only remote allocation and the provider probe are controlled. The default tests do not contact a provider. Successful configuration saves no longer depend on either controlled operation. A later explicit Test or task must still verify the actual runtime. Review follow-up: the first Greptile review found that the new healthy-account path skipped the environment company guard. The corrected route checks the effective environment before it decides whether to probe. Five real PostgreSQL cases cover foreign, same-company and global environments, inherited defaults, and an existing account binding. Against the first patch, the three foreign-environment cases returned 200 and failed their expected 403 assertions; the two allowed cases passed. Initial fixture attempts hit unique environment constraints; the fixture now uses distinct sandbox rows and names. The first CI server shard found 11 tests that required a live probe for every save. Those expectations are changed to the documented healthy/legacy split, with additional healthy-selection cases. The build and Runner jobs were cancelled after this test failure. Their logs show no separate compile or test verdict. No cancelled check is counted as a pass. Latest commit `6257e9e67f289e1c650a8b4c2b818fcca37e2800`: [CI run 41542980091](https://github.com/paperclipai/paperclip/actions/runs/41542980091) passed typecheck, build, all test shards, Runner checks, and E2E. All 55 check runs are complete: 52 passed and 3 were skipped by their workflow conditions. The commit status check also passed. [Greptile review](https://github.com/paperclipai/paperclip/pull/18690#issuecomment-6590555746) is 5/5 for this commit with no new findings. The earlier environment ownership thread is resolved. These remote results complete the checks that the local tool and memory limits prevented. The earlier local failures remain recorded above. ## Risks A healthy saved account can become invalid at the provider before the next runtime use. Ordinary saves no longer detect that through a live test. They still reject unhealthy, revoked, incompatible, or uninstalled accounts in current storage. Explicit Test and execution retain provider authentication and project-authentication checks. Legacy-account adoption, task connection adoption, and Copilot account-specific model checks keep their existing live validation. There is no migration. Reverting the route change restores the earlier synchronous probe behavior. ## Model Used OpenAI Codex, GPT-6 family, with repository tools and code execution. This runtime does not expose the exact model ID, context-window size, or reasoning setting. Those values are not inferred. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass (focused suites; full-suite limits are above) - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> |