2 Commits

Include renames

Author	SHA1	Message	Date
DottaandPaperclip	f46c8071fb	fix(ui): make the Coordinator composer footer opaque (#18455) ... ## Thinking Path > - Paperclip helps people manage AI agents and their work. > - The Coordinator workspace shows a task transcript and a message composer. > - The composer footer can cover part of the transcript on desktop. > - The footer has a transparent background, so text shows through accessory panels and gaps. > - This pull request gives the footer a solid background from the active theme. > - Users can read the composer controls without text from the transcript behind them. ## Linked Issues or Issue Description **What happened?** The Coordinator composer footer lets transcript text show through the area above the message field. **Expected behavior** The full footer has a solid surface in light and dark themes. **Steps to reproduce** 1. Enable the Coordinator workspace. 2. Open a task with enough messages to scroll. 3. Show a composer accessory, such as queued messages or a pending question. 4. Scroll the transcript behind the footer on desktop. **Paperclip version or commit** Base commit: f2db909393. **Deployment mode** Built from source. The change affects the Coordinator workspace. Related work: https://github.com/paperclipai/paperclip/pull/17983 added the workspace. Searches for an opaque or transparent composer fix found no duplicate. ## What Changed - Use `var(--background)` for the full Coordinator composer footer. - Keep the outer footer square so transcript text cannot show at its corners. - Block clicks through the footer gaps. Forward wheel input from these gaps to the transcript. - Keep editor scrolling, zoom input, and the classic workspace behavior. - Add regression tests for the footer surface, wheel input, and canceled forwarded events. - Keep wheel modifier keys. Use the font size to calculate horizontal distance for line-mode input. - Remove the old comment that describes a transparent footer. ## Verification - Passed: 173 tests in `TaskChatComposerDock`, `TaskChatComposerStyles`, `TaskChatComposer`, `TaskChatQueuedMessages`, and `TaskMessageScroller`. - The surface and wheel tests fail on the previous implementation and pass with this change. - The latest wheel tests reproduce lost modifier keys and excessive horizontal distance on the prior commit. The cancellation test fails when the cancellation guard is removed. - Passed: `pnpm check:token-gates` and `git diff --check`. - Passed: local Chromium checks with the production dock and built UI CSS in light and dark themes at desktop and mobile sizes. The checks cover solid corners, blocked clicks in footer gaps, wheel input, message entry, and horizontal overflow. - The browser fixture reproduces the hidden-control click when the old pointer rules are restored. These are local fixture checks, not a deployed acceptance result. - Passed: `pnpm --filter @paperclipai/ui typecheck` and `pnpm --filter @paperclipai/ui build`. - Full local `pnpm -r typecheck` and `pnpm build` could not finish because Cargo is absent from this environment. The full local test run was stopped without a complete result after these missing prerequisites were confirmed. Full CI now passes on the current commit. - Passed: [full CI](https://github.com/paperclipai/paperclip/actions/runs/41205893876) on commit `37feaef28`. Greptile and Paperclip both gave this commit 5/5. Both review threads are resolved. - Paperclip review found hidden clicks through footer gaps and exposed corners. This change addresses both findings. The first CI quality review required a regression test. This change adds those tests. The later review requested a cancellation test and better horizontal wheel handling. This change addresses both items. ## Risks - Low risk. The CSS selector applies only inside the Coordinator workspace. - The footer now captures clicks across its full area. Wheel input in empty footer space still scrolls the transcript. - The dock forwards wheel input to the transcript handler so earlier-history loading still receives that input. - No API, data, or migration changes. ## Model Used - OpenAI Codex, based on GPT-6 (`gpt-6`), with reasoning, tool use, and code execution. The runtime does not expose its context window. The model ID for the original saved CSS patch is not retained in the task evidence. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>	2026-10-31 08:59:41 -05:00
DottaandPaperclip	d2665ff6b4	fix(ui): align the mobile task chat composer with the thread (#11296) ... ## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The task thread is where people read work and guide agents. > - The mobile composer should use the same content width as the thread. > - The composer kept the desktop 80% width on mobile, so its edges did not align with the thread. > - Long assignee-aware placeholder text could also clip inside the mobile editor. > - Some extracted style tokens used legacy HSL wrappers around complete semantic colors, which made those declarations invalid. > - This pull request makes the composer full width on mobile, preserves the narrower desktop layout, wraps the placeholder, and repairs the invalid color compositions. > - The benefit is a stable mobile composer that aligns with the task thread and keeps its intended visual styles. ## Linked Issues or Issue Description Related work: Refs #11263. **What happened?** At mobile widths, the task chat composer used the same 80% width as the desktop composer. Its horizontal edges did not align with the full task thread. A long assignee-aware placeholder could clip on one line. The composer's extracted shadow also used a legacy `hsl(var(...))` wrapper around complete semantic color values, so the browser could reject the declaration. **Expected behavior** The composer must match the task thread width on mobile. It must stay narrower on larger screens. Long placeholder text must wrap inside the editor. Semantic color tokens must form valid shadows and gradients. **Steps to reproduce** 1. Open a task with the chat-style thread on a mobile viewport. 2. Compare the composer edges with the task thread edges. 3. Select an assignee whose placeholder text wraps to two lines. 4. Inspect the computed composer shadow and the extracted semantic color styles. **Paperclip version or commit** The change is based on `dc6fcd1ff1` from `master`. **Deployment mode** Local build from source. The behavior also applies to packaged web builds. ## What Changed - Made the task chat composer full width below the medium breakpoint and kept the 80% desktop width. - Matched the composer dock padding to the task thread padding. - Allowed long composer placeholders to wrap and reserved enough mobile editor height for two lines. - Replaced invalid legacy HSL wrappers around full semantic colors in extracted shadows, gradients, and approval styles. - Added a token gate that prevents legacy `hsl(var(--token))` wrappers from returning. - Added focused regression tests for responsive width, padding, placeholder wrapping, mobile height, and semantic shadow validity. ## Verification - `pnpm check:token-gates` — all four gates pass. - `pnpm --filter @paperclipai/ui exec vitest run src/components/TaskChatThread.test.tsx src/components/task-chat/TaskChatComposer.test.tsx src/components/task-chat/TaskChatComposerStyles.test.ts` — 37 tests pass. - `pnpm --filter @paperclipai/ui typecheck` — passes. - `pnpm --filter @paperclipai/ui build` — passes. The build prints existing CSS optimizer and bundle-size warnings. ## Risks - Low risk. The width change is limited to the mobile breakpoint. The desktop 80% layout remains in place. - The semantic token fixes can affect shadows and gradients that were previously invalid. The new gate prevents the invalid wrapper pattern from returning. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex with `gpt-5.6-sol`. The context-window size is not exposed in this environment. The model used reasoning, repository tools, code execution, and GitHub tools. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>	2026-08-14 12:53:11 -04:00