2 Commits

Include renames

Author	SHA1	Message	Date
DottaandPaperclip	5282cabde8	fix(ui): make every agent reachable from Chats (#13420) ... ## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Experimental Agent Chat gives each person a persistent conversation with each agent. > - The sidebar only showed starred or previously visited agents. > - A person could not start a conversation with an agent absent from that list. > - This pull request adds a searchable agent picker and a default sidebar entry. > - People can now reach every company agent while keeping their frequent conversations close. ## Linked Issues or Issue Description Refs #13283, which introduced the existing task-backed agent chat surface. This change adds discovery to that surface after maintainer review of the Storybook design. **What happened?** With Agent Chat enabled, a person with no starred or recent agents had no agent shortcut. The sidebar also lacked a direct way to start a chat with another agent. **Expected behavior** Show the first-created company agent by default. Let the person search all company agents and open a persistent conversation. **Steps to reproduce** 1. Enable Agent Chat in a company with agents. 2. Use an account with no starred agents or recent chats. 3. Look for a chat entry in the sidebar, or try to chat with an agent absent from its shortcuts. **Paperclip version or commit** The existing behavior is present on master at 728f7185f. ## What Changed - Add a compact picker that searches every company agent by name or role. Include loading, retry, empty, and no-match states. - Keep the first-created agent in Chats alongside stars and up to four other recent conversations. - Align the compose button with stars. Show it on hover or keyboard focus, and keep it visible on touch devices. - Use the existing company-aware chat route. Close the mobile sidebar on selection and reset the picker when the company or user changes. - Connect the approved Storybook scenarios to the production sidebar and picker. Update product and design-guide documentation. ## Verification - Ten focused tests pass for ordering, duplicate names, role search, keyboard selection, search reset, retry states, full-roster navigation, mobile dismissal, and company/user changes. - The agent-chat sidebar end-to-end test passes against an isolated PostgreSQL container. It verifies the first-use default, picker navigation, lazy creation, stars, draft preservation, and reopening existing history. The old four-row and See all link expectations now match the approved behavior. - Browser review of the production components in Storybook: open the sidebar picker, search for an agent absent from the shortcuts, select with Enter, and send a message through the existing composer. - `pnpm build`, `pnpm -r typecheck`, `pnpm check:token-gates`, and `pnpm build-storybook` pass on the rebased branch. The full local test run reached 12,020 passing server tests, then stopped because an unrelated environment-custom-images suite could not allocate PostgreSQL shared memory on this Mac. All corresponding CI test shards pass on isolated hosts. - All CI checks pass on commit `c324568324a6a8b65adfc6447ef19bcc710c61df`. Greptile reviewed that commit at 5/5 with no open findings. - Reviewer path: enable Agent Chat, open the Chats compose button, search by name or role, and select an agent. Existing conversation history must remain available. ## Risks - Sidebar ordering changes: the earliest-created agent remains visible even without a visit or star. - The hover control remains available to keyboard and touch users. - This change uses the existing feature gate, APIs, membership preferences, and persistent conversation behavior. It adds no migration or server contract. - Storybook uses fixture responses. Its first-use landing page is a review fixture and is not added as a product route. ## Model Used OpenAI GPT-6 Astra (`gpt-6-astra`) through Codex, with reasoning, code execution, and browser tools. The session does not expose its context window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>	2026-09-14 13:19:13 -05:00
DottaandPaperclip	ab15aff390	feat: add experimental persistent agent chat (#13284) ... ## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Conversations must use the same tasks, controls, and execution history. > - Users need an ongoing chat with an agent without managing task properties. > - Agents should clarify and plan work, then hand execution to assigned project tasks. > - This pull request combines the reviewed Agent Chat stack for one squash merge. > - The benefit is persistent conversation with normal task governance and shared UI. ## Linked Issues or Issue Description **Subsystem affected** Task lifecycle, agent runtime tools, shared task UI, and browser/paid runner tests. **Problem or motivation** Users need one persistent conversation with each agent. A separate chat store or renderer would duplicate task behavior and bypass existing controls. **Proposed solution** Use a task-backed chat per company, user, and agent. Reuse the task composer and transcript. Clarify and plan in chat, then create assigned project tasks with the relevant plan. Keep Agent Chat behind its own disabled-by-default experimental setting. **Roadmap alignment** This implements the task-backed direction in [CEO Chat](https://github.com/paperclipai/paperclip/blob/master/ROADMAP.md#-ceo-chat). Related proposals: #2504 and #9693. Related request: #7981. The maintainer requested one squash merge of the complete stack. Consolidates the reviewed runtime [#13281](https://github.com/paperclipai/paperclip/pull/13281), backend [#13282](https://github.com/paperclipai/paperclip/pull/13282), and UI [#13283](https://github.com/paperclipai/paperclip/pull/13283) layers with this PR's E2E coverage. All four layers passed CI and received Greptile 5/5 before consolidation. This PR targets master and includes the complete feature. ## What Changed - Add personal canonical chat tasks with ordinary company visibility, immutable identity, idempotent first sends, and an idle waiting state. - Process `/new` in queue order. Preserve history, release a chat pause, and fence old provider context and delayed writes. - Keep chat lifecycle rules across recovery, finalization, assignment, task lists, and rollups. - Support research and plan revision in chat. Hand plans to ordinary assigned project tasks before execution starts. Reject new chat subtasks. - Add repository-aware project creation and discovery tools, including multiple repository IDs and GitHub URLs, authorization, idempotency, and durable project-created cards. - Reuse task UI components for chat, with starred/recent agent navigation and a separate `enableAgentChat` experimental flag. - Add deterministic browser tests and 24 paid chat cells across four Codex/Claude profiles, with validated reports and screenshots. - Integrate current master recovery, controller lease, queued-message, and task UI changes. Gate chat interruption and deferred promotion on ownership/feature policy. Guarantee lease renewal and active controls are stopped even if teardown fails. - Preserve master's migration 0273 and generate chat migration 0274 with idempotent replay for development databases. ## Verification - Prior exact heads of all four PRs passed Linux CI, including build, typecheck, general/serialized tests, and browser E2E. Each had Greptile 5/5 and no unresolved findings. - Integrated local verification passed: full repository typecheck and production build, Storybook build, token gates, 340 focused UI tests, all 20 deterministic chat browser tests, two migration replay tests, 88 focused chat/queue/native/controller tests, and provider/session regressions including real lease expiry. These include the three lifecycle regressions for the final admission/teardown fixes; server typecheck also passes. Current head `1268eda16cc2af892055917e7292f068820be135` has Greptile 5/5 with no unresolved findings and passing security scans. All final-head CI gates passed: build, full Runner verification, typecheck/release registry, canary, all general/serialized test shards, and all browser E2E shards ([CI run](https://github.com/paperclipai/paperclip/actions/runs/34696739927)). Local PostgreSQL startup contention required serialized retries; skipped fixtures do not count as passing coverage. - The earlier paid campaign passed all 24 chat cells and retained 32 screenshots: [report](https://d1p6rlowie26tp.cloudfront.net/runner-e2e/campaigns/gha-34648511170-1/index.html?report=agent-chat#suite-agent-chat). It tested `abacbdfd2f660709ec37312cdb758284c8399d04`; it is prior evidence, not a paid run of this integrated head. - Manual check: enable Agent Chat in Experimental settings, open an agent, clarify and revise a plan, then hand off to an assigned project task. Stop a reply, send `/new`, and verify fresh context with retained history. Disable the setting and verify agent shortcuts/new chat turns are blocked. ## Risks - Queue/session integration can affect retries and delayed writes. Tests cover ownership, cancellation, reset boundaries, idle recovery, and ordinary task behavior. - Migration 0274 adds conversation fields and constraints. Replay is idempotent and preserves existing development chat history. - This combines the previously reviewed stack at the maintainer's request. Agent Chat remains off by default and is separate from Conference Room. ## Model Used OpenAI Codex, GPT-6 Astra (`gpt-6-astra`), with reasoning, code execution, browser tools, and parallel review. The exact context-window size is not exposed in this session. Codex and Claude also ran as test subjects in the linked paid campaign. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>	2026-09-12 08:56:04 -05:00