Addresses UX review feedback on PAP-1963:
- Fix denial-body leak for too_large/size codes (describeDenial no longer
echoes fallback for known codes; the call site passes empty fallback so
unknown codes show a generic message).
- Sticky line-number gutter with solid code-bg fill; highlight border
moves from absolute-positioned sibling onto the sticky gutter so the
amber marker stays pinned when users scroll long lines horizontally.
- Swap FileSearch copy-link icon for Link2.
- WorkspaceFileLink now sets a real deep-link href so modifier-click
opens the file viewer in a new tab instead of scrolling to the top.
- Collapse duplicate title/description in the sheet header when the
basename equals the full path (e.g. .env.production).
- Drop the duplicate title/helper block from OpenFilePrompt (sheet
header already carries the title + description).
- Replace ArrowLeft with Cloud for the remote-workspace state.
- Retire arbitrary text-[12.5px]/[11px]/[0.78em] sizes in favor of text-xs.
- Unify 404 copy on "active workspace" everywhere.
- Raise chip-row contrast by using bg-muted instead of bg-background.
Also commits previously untracked visual-regression infra:
- Storybook stories for 12 file viewer states
- screenshot-file-viewer.mjs / screenshot-one.mjs
- describeDenial unit tests
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Adds the Phase 3 UI for the workspace file viewer:
- FileViewerProvider/FileViewerSheet pair, URL-addressable via
?file=/?line=/?column=/?workspace= so browser back closes or
walks back through sheet history.
- Remark plugin + parser that only auto-link path refs inside
inline code spans (requires a slash or a line anchor to avoid
prose matches like README.md).
- Shared WorkspaceFileLink primitive used by markdown output; same
primitive will be reusable for run output and work-product chips.
- Issue toolbar "Open file" action, Command Palette entry
"Open file in this issue...", and the `g f` keyboard route.
- Designed state views for not found / outside workspace / denied /
too large / binary / remote-only / workspace-archived / loading
progressive states, with polite live-region announcements and a
keyboard-scrollable code viewport.
Tests cover the parser, the remark plugin, URL state reading/writing,
the keyboard shortcut, and markdown-body workspace link rendering.
Co-Authored-By: Paperclip <noreply@paperclip.ing>
