1 Commits

Include renames

Author	SHA1	Message	Date
DottaandClaude Opus 5.5	ba3fe09954	fix(evals): name why a private evidence transfer refused, without its text (#19908) ... ## Thinking Path - Paid chat evals retain their evidence through a trusted transfer (`tests/runner-e2e/manual-private-transfer.ts`) that runs from master, separate from the target checkout. - When the transfer refuses an attempt, it prints one fixed line, "Restricted manual evidence operation failed; no public fallback", and keeps nothing. The closed diagnostic on the target side cannot see this step either. - So a refused attempt leaves no evidence and no reason. `runs-adapters.inspect-failed-run` lost three attempts in a row this way, and `goals.create-goal-tree` lost one; nobody could tell which check refused. - This change keeps the privacy rule (no message text in public logs) but names the refusal with a closed code. ## Linked Issues or Issue Description **What happened** A paid chat-eval attempt whose private evidence the trusted transfer refused printed only "Restricted manual evidence operation failed; no public fallback". The receipt showed `attemptedSourceBytes: 0` and `transfer.status: failed_or_unknown`, and no evidence was kept, so the reason was unknowable. `runs-adapters.inspect-failed-run` lost three consecutive attempts this way. **Expected behavior** A refused transfer still keeps message text private, but names which check refused it with a closed code, so the attempt can be diagnosed. **Steps to reproduce** 1. Dispatch `runner-full-stack-e2e.yml` manually for a chat cell whose private evidence fails transfer validation. 2. Open the "Retain complete approved manual originals" step log: it shows the single fixed failure line with no reason. ## What Changed - New `tests/runner-e2e/private-refusal-code.ts`: `privateRefusalCode(error)` returns a slug of the message only when it is a fixed literal `new Error("...")` in the trusted evidence modules (transfer, handoff, retention, report assets, history, framework report, history budget, evidence, redaction). Otherwise it returns `fs-<code>` for Node error codes, `error-type-<Name>` for typed errors, `non-error-thrown`, or `dynamic`. Message text is never returned. - `manual-private-transfer.ts`: the failure line now includes `(refusal: <code>)`. - Tests: fixed literals are named; dynamic, filesystem, typed and non-error throws never leak their text. ## Verification - `pnpm exec vitest run --config tests/runner-e2e/vitest.config.ts tests/runner-e2e/private-refusal-code.test.ts tests/runner-e2e/manual-private-transfer.test.ts`: 15 passed. - `npx tsc --noEmit -p tests/runner-e2e`: clean. - The three files the transfer requires to match between trusted and target checkouts (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are unchanged. ## Risks - The public log line gains a code. Codes are either fixed literal messages (already public in this repository's source), Node error codes, or error type names. Dynamic messages, which can contain paths, are reported only as `dynamic`. - Reading the module sources once at failure time adds a small file read on the error path only. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), via Claude Code, with tool use (shell, file editing). ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-07 16:28:03 -06:00