mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-15 18:56:05 +01:00
test(evals): land the chat catalog eval harness on master (#19614)
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
854 files changed
+103923
-429
No files matched your search
@@ -2,6 +2,14 @@ import { isRollingWebDeployment } from "./controller-rolling-deployment.js";
|
||||
import { superviseRollingDeployment } from "./rolling-deployment-supervisor.js";
|
||||
import { isLegacyWorkspaceMigration } from "./legacy-workspace-migration.js";
|
||||
import { superviseLegacyWorkspaceMigration } from "./legacy-workspace-migration-supervisor.js";
|
||||
import { teamRuntimeCatalogServerEnvironment } from "./chat-catalog-domains/external-team-runtime-fixture.js";
|
||||
import { stopSetupHealthIfRequested } from "./chat-setup-health.js";
|
||||
import { publishInvitationSourceProof, invitationSourceProofPath } from "./chat-catalog-domains/identity-invite-source-proof.js";
|
||||
import { readSelectedVaultServerEnvironment } from "./chat-vault-private-server.js";
|
||||
import { readValidatedPublicOriginReceipt, publicOriginServerOverrides, PUBLIC_ORIGIN_RECEIPT_ENV, PUBLIC_ORIGIN_CONTROL_ENV } from "./chat-public-origin.js";
|
||||
import { dockerDatabaseSupervisorEnvironment } from "./docker-postgres.js";
|
||||
import { CHAT_INSTALL_PLAN, refreshInstalledChatPins, publishInstalledChatReceipt } from "./chat-installed-lane.js";
|
||||
import { resolveRunnerE2ESource } from "./source.js";
|
||||
import { readRestartRequest, type RestartRequest } from "./server-restart-request.js";
|
||||
import { startCursorCloudCallbackProxy } from "./cursor-cloud-callback-proxy.js";
|
||||
import { prepareControllerDatabase } from "./controller-database.js";
|
||||
@@ -22,9 +30,9 @@ import { qualifyLegacyClaudeCli } from "./legacy-claude-cli.js";
|
||||
import { prepareSourceServerDependencies } from "./source-startup.js";
|
||||
import { spawn, type ChildProcess } from "node:child_process";
|
||||
import { createWriteStream } from "node:fs";
|
||||
import { mkdir, readFile, rename, writeFile } from "node:fs/promises";
|
||||
import { mkdir, readFile, rename, rm, writeFile } from "node:fs/promises";
|
||||
import path from "node:path";
|
||||
import { prepareRunnerE2EServerConfig } from "./server-config.js";
|
||||
import { prepareSupervisorServerConfig } from "./server-config.js";
|
||||
import { installedReleaseEnvironment, installedReleaseLaunch } from "./installed-release.js";
|
||||
import {
|
||||
assertIsolatedServerEnvironment,
|
||||
@@ -68,9 +76,16 @@ const workspaceStorage = remoteWorkspaceStorageServerEnvironment({
|
||||
env: process.env, instanceId: required("PAPERCLIP_INSTANCE_ID"),
|
||||
});
|
||||
const servingArtifacts = new WeakMap<ChildProcess, ServingArtifact>();
|
||||
const dockerEnvironment = await dockerDatabaseSupervisorEnvironment({ temporaryRoot, env: process.env });
|
||||
const sourceEnvironment = { ...dockerEnvironment.source };
|
||||
const publicOriginReceipt = process.env[PUBLIC_ORIGIN_RECEIPT_ENV] ? await readValidatedPublicOriginReceipt({ receiptPath: required(PUBLIC_ORIGIN_RECEIPT_ENV), executionId: executionIds.length === 1 ? executionIds[0]! : "", attemptId: required("PAPERCLIP_E2E_ACCOUNTING_ATTEMPT_ID"), backendOrigin: `http://127.0.0.1:${port}` }) : undefined;
|
||||
if (publicOriginReceipt && process.env.PAPERCLIP_RUNNER_E2E_PUBLIC_MCP !== "1") throw new Error("Owned public origin requires the exact authenticated selected case");
|
||||
for (const key of [PUBLIC_ORIGIN_RECEIPT_ENV, PUBLIC_ORIGIN_CONTROL_ENV, "PAPERCLIP_PUBLIC_URL", "PAPERCLIP_AUTH_PUBLIC_BASE_URL", "PAPERCLIP_MANAGED_RUNTIME_PUBLIC_URL", "PAPERCLIP_ALLOWED_HOSTNAMES"]) delete sourceEnvironment[key];
|
||||
const vaultEnvironment = await readSelectedVaultServerEnvironment({ executionIds, temporaryRoot, backendOrigin: `http://127.0.0.1:${port}`, env: process.env });
|
||||
const teamCatalogEnvironment = await teamRuntimeCatalogServerEnvironment({ executionIds, temporaryRoot, repositoryRoot });
|
||||
const serverEnvironment = buildPaperclipServerEnvironment(installedRelease
|
||||
? installedReleaseEnvironment(process.env, repositoryRoot, path.join(temporaryRoot, "provider-bin"))
|
||||
: process.env, {
|
||||
? installedReleaseEnvironment(sourceEnvironment, repositoryRoot, path.join(temporaryRoot, "provider-bin"))
|
||||
: sourceEnvironment, {
|
||||
NODE_ENV: "test",
|
||||
PORT: port,
|
||||
// Keep provider caches attempt-private without changing Playwright's browser
|
||||
@@ -94,6 +109,7 @@ const serverEnvironment = buildPaperclipServerEnvironment(installedRelease
|
||||
PAPERCLIP_PUBLIC_URL: `http://127.0.0.1:${port}`,
|
||||
PAPERCLIP_AUTH_PUBLIC_BASE_URL: `http://127.0.0.1:${port}`,
|
||||
PAPERCLIP_AUTH_BASE_URL_MODE: "explicit",
|
||||
...publicOriginServerOverrides(publicOriginReceipt),
|
||||
// Use empty provider configuration as the managed homes' seed. A local
|
||||
// operator's installed plugins, MCP connections and auth are not fixtures.
|
||||
CODEX_HOME: path.join(temporaryRoot, "provider-config", "codex"),
|
||||
@@ -110,6 +126,8 @@ const serverEnvironment = buildPaperclipServerEnvironment(installedRelease
|
||||
// Onboarding normally opens the app after listen. Browser ownership belongs
|
||||
// to Playwright in this harness, so never create a developer desktop tab.
|
||||
PAPERCLIP_OPEN_ON_LISTEN: "false",
|
||||
...vaultEnvironment,
|
||||
...teamCatalogEnvironment,
|
||||
...workspaceStorage,
|
||||
});
|
||||
assertIsolatedServerEnvironment(serverEnvironment, {
|
||||
@@ -124,7 +142,9 @@ const definedServerEnvironment = Object.fromEntries(
|
||||
),
|
||||
);
|
||||
|
||||
await prepareSourceServerDependencies(repositoryRoot, definedServerEnvironment, Boolean(installedRelease));
|
||||
await prepareSourceServerDependencies(repositoryRoot, definedServerEnvironment, usesInstalledCli(process.env), {
|
||||
temporaryRoot, executionIds, sourceRevision: resolveRunnerE2ESource().sha,
|
||||
});
|
||||
|
||||
await Promise.all([
|
||||
mkdir(path.dirname(logPath), { recursive: true }),
|
||||
@@ -199,10 +219,12 @@ function describeChildExit(candidate: ChildProcess) {
|
||||
return `server exited code=${String(candidate.exitCode)} signal=${String(candidate.signalCode)}`;
|
||||
}
|
||||
|
||||
let invitationSourceGeneration: string | undefined;
|
||||
async function startServer() {
|
||||
if (shutdownRequested()) {
|
||||
throw new Error("Refusing to start Paperclip after wrapper shutdown");
|
||||
}
|
||||
if (process.env[CHAT_INSTALL_PLAN]) refreshInstalledChatPins(process.env, selectedExecutions[0]!.id);
|
||||
// Recheck bytes and dependency resolution on every controller restart.
|
||||
const selected = upgradeArtifacts?.sequence[artifactIndex];
|
||||
if (upgradeArtifacts && !selected) throw new Error("Upgrade artifact sequence exhausted");
|
||||
@@ -217,9 +239,13 @@ async function startServer() {
|
||||
delete environment[upgradeArtifactKey];
|
||||
environment.GIT_CEILING_DIRECTORIES = upgradeArtifacts.artifacts[selected!].root;
|
||||
}
|
||||
invitationSourceGeneration = undefined;
|
||||
await rm(invitationSourceProofPath(temporaryRoot), { force: true });
|
||||
const sourceArgs = runnerE2ETypeScriptProcessArgs(repositoryRoot, paperclipCli, ["onboard", "--yes", "--run"]);
|
||||
const sourceSpawnedAt = new Date().toISOString();
|
||||
const candidate = spawn(
|
||||
process.execPath,
|
||||
installed ? [installed.entry, "onboard", "--yes", "--run"] : runnerE2ETypeScriptProcessArgs(repositoryRoot, paperclipCli, ["onboard", "--yes", "--run"]),
|
||||
installed ? [installed.entry, "onboard", "--yes", "--run"] : sourceArgs,
|
||||
{
|
||||
cwd: launch?.cwd ?? repositoryRoot,
|
||||
env: environment,
|
||||
@@ -231,6 +257,7 @@ async function startServer() {
|
||||
);
|
||||
child = candidate;
|
||||
if (verified) servingArtifacts.set(candidate, verified.receipt);
|
||||
if (process.env[CHAT_INSTALL_PLAN] && candidate.pid) publishInstalledChatReceipt(process.env, selectedExecutions[0]!.id, candidate.pid);
|
||||
|
||||
candidate.stdout?.on("data", (chunk) => {
|
||||
process.stdout.write(chunk);
|
||||
@@ -264,6 +291,11 @@ async function startServer() {
|
||||
void stopWithFeedback(candidate, shutdownSignal).catch(() => {});
|
||||
}
|
||||
await stopServer.watch(candidate);
|
||||
const invitationAttemptId = process.env.PAPERCLIP_E2E_ACCOUNTING_ATTEMPT_ID;
|
||||
if (!installed && candidate.pid && invitationAttemptId) {
|
||||
invitationSourceGeneration = await publishInvitationSourceProof({ temporaryRoot, sourceRoot: repositoryRoot, apiOrigin: `http://127.0.0.1:${port}`,
|
||||
attemptId: invitationAttemptId, executionIds, pid: candidate.pid, argv: sourceArgs, spawnedAt: sourceSpawnedAt });
|
||||
}
|
||||
return candidate;
|
||||
}
|
||||
|
||||
@@ -347,6 +379,7 @@ async function writeRestartAck(
|
||||
status,
|
||||
controllerCacheDiscarded,
|
||||
completedAt: new Date().toISOString(),
|
||||
...(invitationSourceGeneration ? { invitationSourceGeneration } : {}),
|
||||
...(message ? { message } : {}),
|
||||
...(crashBoundary ? { crashBoundary } : {}),
|
||||
...(controllerOutage ? { controllerOutage } : {}),
|
||||
@@ -444,10 +477,11 @@ async function supervise() {
|
||||
if (executionIds.some(id => id.includes(".legacy-claude.local.") || /\.assistant-claude-(?:haiku|sonnet)\.local\./.test(id))) {
|
||||
definedServerEnvironment.PATH = await qualifyLegacyClaudeCli(temporaryRoot, definedServerEnvironment);
|
||||
}
|
||||
const databaseReservation = await prepareRunnerE2EServerConfig({
|
||||
const databaseReservation = await prepareSupervisorServerConfig({
|
||||
temporaryRoot,
|
||||
configPath,
|
||||
serverPort: Number(port),
|
||||
database: dockerEnvironment,
|
||||
});
|
||||
// Postgres needs the socket itself; release immediately before child spawn.
|
||||
await databaseReservation?.close();
|
||||
@@ -474,6 +508,7 @@ async function supervise() {
|
||||
let lastRestartRequestId: string | null = null;
|
||||
while (!shutdownRequested()) {
|
||||
if (unexpectedChildFailure) throw unexpectedChildFailure;
|
||||
if (await stopSetupHealthIfRequested({ executionIds, temporaryRoot, stop: () => stopServer.stopAll("SIGTERM") })) { shutdownSignal ??= "SIGTERM"; continue; }
|
||||
const request = await readRestartRequest(restartRequestPath, executionIds);
|
||||
if (request && request.requestId !== lastRestartRequestId) {
|
||||
lastRestartRequestId = request.requestId;
|
||||
|
||||
Reference in new issue
Block a user