From ed5452863cd904777d5728ea506e771453de661b Mon Sep 17 00:00:00 2001 From: Dotta Date: Wed, 21 Oct 2026 07:48:56 -0500 Subject: [PATCH] style: keep combined setup rationale in review documentation Co-Authored-By: Paperclip --- server/src/__tests__/task-workspace-repositories-trust.test.ts | 1 - server/src/services/task-repository-acquisition.ts | 1 - tests/runner-e2e/automatic-repository-flow.ts | 2 -- tests/runner-e2e/source-startup.ts | 1 - 4 files changed, 5 deletions(-) diff --git a/server/src/__tests__/task-workspace-repositories-trust.test.ts b/server/src/__tests__/task-workspace-repositories-trust.test.ts index 00e5587f823..dc026f81b81 100644 --- a/server/src/__tests__/task-workspace-repositories-trust.test.ts +++ b/server/src/__tests__/task-workspace-repositories-trust.test.ts @@ -340,7 +340,6 @@ const support = await getEmbeddedPostgresTestSupport(); const localBoard = principal === "local_board" || principal === "local_board_jwt"; if (localBoard) await db.update(heartbeatRuns).set({ responsibleUserId: "local-board" }).where(eq(heartbeatRuns.id, f.runId)); if (principal === "local_board_jwt") { - // The production local-trusted company route records this owner membership. await db.insert(authUsers).values({ id: "local-board", name: "Local Board", email: "local-board@example.invalid", emailVerified: true, createdAt: new Date(), updatedAt: new Date() }).onConflictDoNothing(); await db.insert(companyMemberships).values({ companyId: f.companyId, principalType: "user", principalId: "local-board", membershipRole: "owner", status: "active" }); diff --git a/server/src/services/task-repository-acquisition.ts b/server/src/services/task-repository-acquisition.ts index 68dce79c325..b39f2fcbbe2 100644 --- a/server/src/services/task-repository-acquisition.ts +++ b/server/src/services/task-repository-acquisition.ts @@ -19,7 +19,6 @@ export const taskRepositoryRunColumns = { }; type TaskRepositoryRunIdentity = Pick; -/** Native JWTs retain the local-board marker; older controller actors omit it. */ export function taskRepositoryResponsibleUserMatches(actorUserId: string | null | undefined, runUserId: string | null) { return (actorUserId ?? null) === runUserId || (runUserId === "local-board" && actorUserId == null); } diff --git a/tests/runner-e2e/automatic-repository-flow.ts b/tests/runner-e2e/automatic-repository-flow.ts index ba31809b88d..44952b05611 100644 --- a/tests/runner-e2e/automatic-repository-flow.ts +++ b/tests/runner-e2e/automatic-repository-flow.ts @@ -45,8 +45,6 @@ export async function runAutomaticRepositoryFlow(input: { observation.successorSource = runs[1]?.contextSnapshot?.source ?? null; observation.successorStartedAt = runs[1]?.startedAt ? Date.parse(runs[1].startedAt) : null; if (runs.length === 1 && runs[0]?.status === "running" && observation.firstContextObservedAt === null) { - // Observe the source artifact while its admission is still running. A - // successor-created file must never become the baseline for retention. const original = await readRegisteredArtifacts(api, issue.id, runs[0].id, [files.context]).catch(() => null); if (original?.[0]) { observation.firstSavedContext = original[0].content; diff --git a/tests/runner-e2e/source-startup.ts b/tests/runner-e2e/source-startup.ts index 88fdefcbbc7..6c6aafdcf1f 100644 --- a/tests/runner-e2e/source-startup.ts +++ b/tests/runner-e2e/source-startup.ts @@ -2,7 +2,6 @@ import { execFile } from "node:child_process"; import path from "node:path"; import { promisify } from "node:util"; -/** The source entry imports tool authority before the CLI can prepare these packages. */ export async function prepareSourceServerDependencies( repositoryRoot: string, environment: NodeJS.ProcessEnv,