From ec1e665d5975401500ce16dcebde09494424b9e6 Mon Sep 17 00:00:00 2001 From: Devin Foley Date: Sun, 3 May 2026 20:08:12 -0700 Subject: [PATCH] Fail on uncovered build-gap packages --- scripts/run-typecheck-build-gaps.mjs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/run-typecheck-build-gaps.mjs b/scripts/run-typecheck-build-gaps.mjs index 94ea5622ad3..6210ab2a17e 100644 --- a/scripts/run-typecheck-build-gaps.mjs +++ b/scripts/run-typecheck-build-gaps.mjs @@ -68,9 +68,10 @@ const buildGapCandidates = workspacePackages const packagesMissingTypecheck = buildGapCandidates.filter( ({ pkg }) => typeof pkg.scripts?.typecheck !== "string", ); -for (const workspacePkg of packagesMissingTypecheck) { - console.warn( - `[typecheck:build-gaps] warning: ${workspacePkg.name} has a build script without tsc but no explicit typecheck script.`, +if (packagesMissingTypecheck.length > 0) { + const missingNames = packagesMissingTypecheck.map((workspacePkg) => workspacePkg.name).join(", "); + fail( + `Workspace packages with build scripts that skip tsc must define a typecheck script. Missing: ${missingNames}`, ); } const buildGapPackages = buildGapCandidates.filter(