refactor: remove code comments added by recent PRs (#16681)

CONTRIBUTING.md says PRs add no code comments, but #16485, #16586, #16621 and #16672 added some. This removes the 215 comment-only lines git blame on master attributes to those merge commits, across 12 code files, plus one blank line the removal left doubled. Rewritten (not added) comments in scripts/assert-cloud-image-sentry.mjs and comments in .github workflows are left alone. No code changes.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Devin FoleyandPaperclip authored and GitHub committed 2026-10-17 18:55:39 -07:00
1 parent bebeb389f1
commit e30550ef39
12 files changed
-216

No files matched your search

-68
View File
@@ -1,36 +1,3 @@
// Bundle the built server into `dist-runtime/` for production startup.
//
// The server's tsc output imports the workspace packages as TypeScript source
// (their package exports point at `src/*.ts`), so production used to start
// Node with the tsx loader. Every boot then resolved and transpiled thousands
// of modules through tsx's hooks: about 8-10 s warm and over 20 s on a cold
// container, all before the server could listen. This script runs after the
// server `build` and bundles `dist/index.js`, with the workspace packages
// compiled in, so production starts with plain `node` in a few seconds.
//
// The bundle keeps runtime behavior the same as running `dist/index.js`:
//
// - Third-party packages stay external. A package the server package itself
// resolves to the same file stays a bare specifier, so Node resolves it at
// runtime from server/node_modules exactly as before (the cloud image adds
// optional peers such as @sentry/node there after the build). Only a
// dependency that pnpm's strict layout hides from the server package, one
// that only a workspace package can see, is emitted as an absolute path.
// Resolution follows Node's rules (the `main` field and `node` condition),
// not bundler-only `module` builds.
// - Every bundled module keeps its own location: `import.meta.url`,
// `import.meta.dirname` and `import.meta.filename` are replaced with the
// module's original path, so code that finds files next to its source
// (scripts, assets, worker entry files) keeps finding them.
// - Code splitting keeps dynamic imports as separate chunks. Bundled into a
// single file, the server's top-level await never settled (observed on the
// production build); split chunks keep the module evaluation order Node
// uses for the unbundled output.
// - A `require` built from the chunk's location is provided for the few
// modules that call `require` from ESM.
// - The bundle's entry sets `process.argv[1]` to the original entry file
// before loading it, so the server's main-module check (and anything else
// that reads argv[1]) sees exactly what it saw when started unbundled.
import { readFile, rm } from "node:fs/promises";
import { dirname, join } from "node:path";
@@ -42,14 +9,6 @@ const serverDir = join(scriptDir, "..");
const REQUIRE_SHIM = "import { createRequire as __paperclipCreateRequire } from 'node:module'; const require = __paperclipCreateRequire(import.meta.url);";
/**
* Replace a module's `import.meta` location properties with its original
* path, so bundling does not move where the module looks for nearby files.
*
* @param {string} source Module source.
* @param {string} file Absolute path of the module's original file.
* @returns {string}
*/
export function preserveModuleLocation(source, file) {
return source
.replace(/\bimport\.meta\.url\b/g, JSON.stringify(pathToFileURL(file).href))
@@ -57,13 +16,6 @@ export function preserveModuleLocation(source, file) {
.replace(/\bimport\.meta\.filename\b/g, JSON.stringify(file));
}
/**
* The bundle's entry: present the original entry file as the main module,
* then load it.
*
* @param {string} entry Absolute path of the original entry file.
* @returns {import("esbuild").Plugin}
*/
function runtimeEntry(entry) {
return {
name: "runtime-entry",
@@ -78,7 +30,6 @@ function runtimeEntry(entry) {
};
}
/** @type {import("esbuild").Plugin} */
const keepModuleLocations = {
name: "keep-module-locations",
setup(builder) {
@@ -95,13 +46,6 @@ const keepModuleLocations = {
},
};
/**
* @param {(specifier: string) => boolean} isBundled Whether a bare specifier is
* bundled (workspace packages) rather than kept external.
* @param {string} runtimeDir A directory inside the server package, from which
* bare specifiers resolve at runtime.
* @returns {import("esbuild").Plugin}
*/
function externalizeThirdParty(isBundled, runtimeDir) {
return {
name: "externalize-third-party",
@@ -114,8 +58,6 @@ function externalizeThirdParty(isBundled, runtimeDir) {
importer: args.importer,
pluginData: { externalizeThirdParty: true },
});
// Builtins and anything esbuild cannot resolve stay as written;
// Node resolves them at runtime exactly as before.
if (resolved.errors.length > 0 || resolved.external) return { path: args.path, external: true };
const fromServer = await builder.resolve(args.path, {
kind: args.kind,
@@ -129,16 +71,6 @@ function externalizeThirdParty(isBundled, runtimeDir) {
};
}
/**
* Bundle a built entry point and everything it imports from the workspace.
*
* @param {{
* entry: string,
* outdir: string,
* isBundled?: (specifier: string) => boolean,
* }} options
* @returns {Promise<{ outfile: string, inputs: number, chunks: number }>}
*/
export async function bundleRuntime({ entry, outdir, isBundled = (specifier) => specifier.startsWith("@paperclipai/") }) {
await rm(outdir, { recursive: true, force: true });
const result = await build({