diff --git a/ui/src/components/BreadcrumbBar.test.tsx b/ui/src/components/BreadcrumbBar.test.tsx index fbbec3d59d5..8ba15e379e5 100644 --- a/ui/src/components/BreadcrumbBar.test.tsx +++ b/ui/src/components/BreadcrumbBar.test.tsx @@ -131,6 +131,8 @@ describe("BreadcrumbBar", () => { await act(async () => root.render()); const label = container.querySelector('[data-slot="breadcrumb-page"]'); expect(label?.textContent).toBe("CCCodexCoder"); + expect(label?.classList.contains("items-center")).toBe(true); + expect(label?.classList.contains("items-baseline")).toBe(false); expect(container.querySelector("h1")).toBeNull(); const settings = container.querySelector('button[aria-label="Configure CodexCoder"]'); expect(settings?.closest('[data-slot="breadcrumb-item"]')).toBe(label?.closest('[data-slot="breadcrumb-item"]')); diff --git a/ui/src/components/BreadcrumbBar.tsx b/ui/src/components/BreadcrumbBar.tsx index e67958336ce..9684c360b44 100644 --- a/ui/src/components/BreadcrumbBar.tsx +++ b/ui/src/components/BreadcrumbBar.tsx @@ -137,7 +137,7 @@ export function BreadcrumbBar({ taskDetailLayout = false }: { taskDetailLayout?: {isLast || !crumb.href ? ( crumb.leading || crumb.identifier ? ( - + {crumb.leading && ( {crumb.leading} )} diff --git a/ui/src/pages/IssueDetail.test.tsx b/ui/src/pages/IssueDetail.test.tsx index a45a721f358..057c8570fb6 100644 --- a/ui/src/pages/IssueDetail.test.tsx +++ b/ui/src/pages/IssueDetail.test.tsx @@ -1,3 +1,4 @@ +import { AgentAvatar } from "../components/AgentAvatar"; import { TaskChatPausedTakeover, type TaskComposerPause } from "../components/task-chat/TaskChatPausedTakeover"; // @vitest-environment jsdom @@ -1437,6 +1438,19 @@ describe("IssueDetail", () => { await flushReact(); expect(mockNavigate).not.toHaveBeenCalled(); expect(mockIssuesApi.markRead).toHaveBeenCalledWith(canonical.id); + const [breadcrumbs] = mockSetBreadcrumbs.mock.calls.at(-1)!; + expect(breadcrumbs[0].leading.type).toBe(AgentAvatar); + expect(breadcrumbs[0].leading.props).toMatchObject({ agent, size: 24 }); + expect(breadcrumbs[0].leadingKey).toBe(`agent:${agent.id}:${JSON.stringify(agent.appearance)}`); + const updatedAgent = { ...agent, appearance: { schemaVersion: 1, characterVersion: "cap-v1", paletteId: "deep-tide" } } as Agent; + await act(async () => { + root.render( canonical }} />); + }); + await flushReact(); + const [updatedBreadcrumbs] = mockSetBreadcrumbs.mock.calls.at(-1)!; + expect(updatedBreadcrumbs[0].leading.props.agent).toEqual(updatedAgent); + expect(updatedBreadcrumbs[0].leadingKey).not.toBe(breadcrumbs[0].leadingKey); + }); it.each(["message", "attachment"])("creates an unused conversation only for the first %s and updates its canonical cache", async (kind) => { diff --git a/ui/src/pages/IssueDetail.tsx b/ui/src/pages/IssueDetail.tsx index dd56db1f287..dff1a70b223 100644 --- a/ui/src/pages/IssueDetail.tsx +++ b/ui/src/pages/IssueDetail.tsx @@ -9,7 +9,6 @@ import { clearLegacyChatMessageRequests } from "@/lib/chat-message-request"; import { agentChatDraft } from "@/lib/agent-chat-draft"; import { Settings as ChatSettings } from "lucide-react"; import { agentDetailHref } from "./agent-detail-navigation"; -import { deriveInitials } from "@/components/Identity"; import { ExecutionBlockerNotice } from "../components/ExecutionBlockerNotice"; import type { TaskComposerPause } from "../components/task-chat/TaskChatPausedTakeover"; import { TaskDetailTasksPanel } from "@/components/task-detail/TaskDetailTasksPanel"; @@ -5437,8 +5436,8 @@ export function TaskDetailSurface({ conversation, tasksTab }: { tasksTab?: TaskS if (conversationAgent) { setBreadcrumbs([{ label: conversationAgent.name, - leading: {deriveInitials(conversationAgent.name)}, - leadingKey: `agent:${conversationAgent.id}`, + leading: , + leadingKey: `agent:${conversationAgent.id}:${JSON.stringify(conversationAgent.appearance)}`, trailing: , trailingKey: `configure:${conversationAgent.id}`, }]);