From cc8e31c05ad1e15d4332735bd7f5876836ed2900 Mon Sep 17 00:00:00 2001 From: Dotta Date: Tue, 28 Apr 2026 15:26:42 -0500 Subject: [PATCH] Address UI split review findings Co-Authored-By: Paperclip --- server/src/routes/issues.ts | 36 +++++++++--------------------------- ui/src/App.tsx | 1 - 2 files changed, 9 insertions(+), 28 deletions(-) diff --git a/server/src/routes/issues.ts b/server/src/routes/issues.ts index 5b9bb6410f8..bed951913fd 100644 --- a/server/src/routes/issues.ts +++ b/server/src/routes/issues.ts @@ -603,39 +603,23 @@ export function issueRoutes( res.status(403).json({ error: "Agent authentication required" }); return false; } - if (issue.assigneeAgentId === null) { + if (issue.status !== "in_progress" || issue.assigneeAgentId === null) { return true; } if (issue.assigneeAgentId !== actorAgentId) { if (await hasActiveCheckoutManagementOverride(actorAgentId, issue.companyId, issue.assigneeAgentId)) { return true; } - if (issue.status === "in_progress") { - res.status(409).json({ - error: "Issue is checked out by another agent", - details: { - issueId: issue.id, - assigneeAgentId: issue.assigneeAgentId, - actorAgentId, - }, - }); - } else { - res.status(403).json({ - error: "Agent cannot mutate another agent's issue", - details: { - issueId: issue.id, - assigneeAgentId: issue.assigneeAgentId, - actorAgentId, - status: issue.status, - securityPrinciples: ["Least Privilege", "Complete Mediation", "Fail Securely"], - }, - }); - } + res.status(409).json({ + error: "Issue is checked out by another agent", + details: { + issueId: issue.id, + assigneeAgentId: issue.assigneeAgentId, + actorAgentId, + }, + }); return false; } - if (issue.status !== "in_progress") { - return true; - } const runId = requireAgentRunId(req, res); if (!runId) return false; const ownership = await svc.assertCheckoutOwner(issue.id, actorAgentId, runId); @@ -671,7 +655,6 @@ export function issueRoutes( details: { issueId: issue.id, status: issue.status, - securityPrinciples: ["Complete Mediation", "Fail Securely"], }, }); return false; @@ -694,7 +677,6 @@ export function issueRoutes( holdId: activePauseHold.holdId, rootIssueId: activePauseHold.rootIssueId, mode: activePauseHold.mode, - securityPrinciples: ["Complete Mediation", "Fail Securely", "Secure Defaults"], }, }); return false; diff --git a/ui/src/App.tsx b/ui/src/App.tsx index b85acb5f2de..008799bef70 100644 --- a/ui/src/App.tsx +++ b/ui/src/App.tsx @@ -258,7 +258,6 @@ export function App() { } /> } /> } /> - } /> }> } />