mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-22 20:29:18 +01:00
fix(daytona-duplex): chunk host-to-sandbox writes and make a transport close legible (#11986)
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Paperclip runs agent work through adapters and sandbox providers > - The Daytona duplex path sends host input through a provider pseudo-terminal WebSocket > - Large messages exceed the provider limit, and a transport close can look like a process exit > - This pull request chunks UTF-8 input and carries transport-close state through the duplex path > - The benefit is reliable large input and accurate loss reporting ## Linked Issues or Issue Description **What happened?** The Daytona duplex path sent a full input payload as one WebSocket message. A payload above the provider limit closed the channel. The wait path also mapped a non-numeric exit result to a process exit without exit data. **Expected behavior** The provider must receive large input as ordered UTF-8 chunks. A transport close without exit data must record `transport_closed`, while a numeric exit must record `provider_exit`. **Steps to reproduce** 1. Start a Daytona duplex session. 2. Send an input payload larger than 65536 bytes. 3. Observe that one message closes the provider channel. 4. End a session without a numeric exit code. 5. Observe that the loss reason reports a process exit. **Paperclip version or commit** Commit `1761e79ec9097c65d94f90a8ba20416f8ab718a6`. **Deployment mode** Built from source with the Daytona sandbox provider. ## What Changed - Add a shared UTF-8 byte chunker with a 32768-byte cap. - Route both Daytona pseudo-terminal write paths through the chunker. - Preserve multi-byte UTF-8 sequences across read-side chunks. - Carry an explicit `transportClosed` state through the worker and host wait paths. - Record `transport_closed` for a reason-less transport close and `provider_exit` for a numeric exit. - Keep orderly completion suppression for both exit paths. ## Verification - The Daytona plugin suite passes 194 tests. - The adapter-utils broker, codec, and telemetry suites pass 73 tests. - The plugin SDK duplex and worker RPC host suites pass 37 tests. - The server plugin worker manager duplex suite passes 78 tests. - The execution target sandbox and ACPX execute suites pass 257 tests. - TypeScript checks pass for adapter-utils, plugin SDK, server, and the standalone Daytona plugin. ## Risks The chunk size adds a loop for large input payloads. The 32768-byte cap stays below the provider limit. The optional loss field preserves compatibility for other providers. ## Model Used OpenAI Codex, GPT-5, extended reasoning, tool use, and code execution. The runtime does not expose a separate context-window value. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes: #` / `Refs: #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
1 parent
141b815294
commit
c5050396c7
18 files changed
+641
-44
No files matched your search
@@ -14,6 +14,8 @@
|
||||
// `sid` or `rid` to prove the host drops a mismatched-pair notification and
|
||||
// counts a protocol error.
|
||||
// - `exitCode`: when set, the fixture emits an exit notification after the data.
|
||||
// - `transportClosed`: when true, the exit notification marks a reason-less
|
||||
// transport close and carries no exit code.
|
||||
// - `dataAfterExit`: an array of `{ chunk, sid? }`, same shape as `data`. The
|
||||
// fixture emits these as data notifications after the exit notification, so a
|
||||
// test can script a batch where a data frame arrives after the exit in the
|
||||
@@ -52,11 +54,19 @@ function scriptedFrameLines(directive, hostRouteId, workerSessionId) {
|
||||
},
|
||||
})}\n`;
|
||||
}
|
||||
if (typeof directive.exitCode === "number") {
|
||||
if (typeof directive.exitCode === "number" || directive.transportClosed === true) {
|
||||
const exitParams = {
|
||||
hostRouteId,
|
||||
workerSessionId,
|
||||
exitCode: typeof directive.exitCode === "number" ? directive.exitCode : null,
|
||||
};
|
||||
// A transport-close directive marks a reason-less transport close, so the
|
||||
// fixture carries the discriminator the same way a real worker does.
|
||||
if (directive.transportClosed === true) exitParams.transportClosed = true;
|
||||
lines += `${JSON.stringify({
|
||||
jsonrpc: "2.0",
|
||||
method: "duplexChannel.exit",
|
||||
params: { hostRouteId, workerSessionId, exitCode: directive.exitCode },
|
||||
params: exitParams,
|
||||
})}\n`;
|
||||
}
|
||||
const dataAfterExit = Array.isArray(directive.dataAfterExit) ? directive.dataAfterExit : [];
|
||||
|
||||
@@ -163,6 +163,30 @@ describe("plugin worker manager duplex channel route", () => {
|
||||
}
|
||||
});
|
||||
|
||||
it("carries a transport-close exit through to the wait result", async () => {
|
||||
const handle = makeDuplexHandle();
|
||||
try {
|
||||
await handle.start();
|
||||
const session = await handle.openDuplexChannel(
|
||||
duplexOpenInput({
|
||||
workerSessionId: "ws-A",
|
||||
data: [{ chunk: "one" }],
|
||||
// The worker reports a reason-less transport close with no exit code.
|
||||
transportClosed: true,
|
||||
}),
|
||||
);
|
||||
const chunks: string[] = [];
|
||||
session.onData((chunk) => chunks.push(chunk));
|
||||
// The discriminator survives the worker exit notification, so the host wait
|
||||
// resolves with the transport-close mark and no exit code.
|
||||
await expect(session.wait()).resolves.toEqual({ exitCode: null, transportClosed: true });
|
||||
expect(chunks).toEqual(["one"]);
|
||||
await session.close();
|
||||
} finally {
|
||||
await handle.stop().catch(() => undefined);
|
||||
}
|
||||
});
|
||||
|
||||
it("isolates a throwing listener during the buffered replay so every buffered chunk routes", async () => {
|
||||
const handle = makeDuplexHandle();
|
||||
try {
|
||||
|
||||
@@ -1080,9 +1080,10 @@ function adaptDuplexChannelHostSession(
|
||||
onData(listener: (chunk: string) => void): void {
|
||||
session.onData(listener);
|
||||
},
|
||||
onExit(listener: (exit: { exitCode: number | null }) => void): void {
|
||||
onExit(listener: (exit: { exitCode: number | null; transportClosed?: boolean }) => void): void {
|
||||
// `wait()` resolves one time with the exit and never rejects, so a single
|
||||
// `then` bridges it to the one-time exit listener.
|
||||
// `then` bridges it to the one-time exit listener. The exit carries
|
||||
// `transportClosed`, so the broker tells a real exit from a transport close.
|
||||
void session.wait().then((exit) => {
|
||||
listener(exit);
|
||||
});
|
||||
|
||||
@@ -572,8 +572,13 @@ export interface DuplexChannelHostSession {
|
||||
onData(listener: (chunk: string) => void): void;
|
||||
/** Writes raw input bytes to the channel. */
|
||||
write(data: string): void;
|
||||
/** Resolves with the child exit code when the command ends or the route ends. */
|
||||
wait(): Promise<{ exitCode: number | null }>;
|
||||
/**
|
||||
* Resolves when the command ends or the route ends. A numeric `exitCode` is a
|
||||
* real process exit. `transportClosed` is true when the provider transport
|
||||
* closed with no exit data, so the broker can tell a real process exit from a
|
||||
* reason-less transport close.
|
||||
*/
|
||||
wait(): Promise<{ exitCode: number | null; transportClosed?: boolean }>;
|
||||
/** Stops the child process. Safe to call more than one time. */
|
||||
kill(): void;
|
||||
/** Closes the route and releases the channel. Safe to call more than one time. */
|
||||
@@ -1280,8 +1285,8 @@ export function createPluginWorkerHandle(
|
||||
// Settle the route wait exactly once. Replace the settler with a no-op, so a
|
||||
// later exit or terminalize never settles the wait a second time.
|
||||
function settleRouteWait(
|
||||
route: { settleWait: (value: { exitCode: number | null }) => void },
|
||||
value: { exitCode: number | null },
|
||||
route: { settleWait: (value: { exitCode: number | null; transportClosed?: boolean }) => void },
|
||||
value: { exitCode: number | null; transportClosed?: boolean },
|
||||
): void {
|
||||
const settle = route.settleWait;
|
||||
route.settleWait = () => {};
|
||||
@@ -1557,7 +1562,7 @@ export function createPluginWorkerHandle(
|
||||
totalDataBytes: number;
|
||||
lifetimeTimer: ReturnType<typeof setTimeout> | null;
|
||||
terminalized: boolean;
|
||||
settleWait: (value: { exitCode: number | null }) => void;
|
||||
settleWait: (value: { exitCode: number | null; transportClosed?: boolean }) => void;
|
||||
// The data frames that arrived before the bind, held in order. The bind
|
||||
// replays them through the exact-pair routing, so an early frame is never
|
||||
// lost and a frame whose pair does not match the bound pair still fails
|
||||
@@ -1869,6 +1874,14 @@ export function createPluginWorkerHandle(
|
||||
return;
|
||||
}
|
||||
const exitCode = typeof params.exitCode === "number" ? params.exitCode : null;
|
||||
// A reason-less transport close carries `transportClosed`; a real process exit
|
||||
// does not. Carry the discriminator to the wait only when it is a transport
|
||||
// close, so a real exit keeps the plain `{ exitCode }` result and the broker
|
||||
// still keeps the two apart in the loss taxonomy.
|
||||
if (params.transportClosed === true) {
|
||||
settleRouteWait(resolved, { exitCode, transportClosed: true });
|
||||
return;
|
||||
}
|
||||
settleRouteWait(resolved, { exitCode });
|
||||
}
|
||||
|
||||
@@ -1953,10 +1966,13 @@ export function createPluginWorkerHandle(
|
||||
input: DuplexChannelOpenInput,
|
||||
): Promise<DuplexChannelHostSession> {
|
||||
const hostRouteId = nextDuplexHostRouteId();
|
||||
let settleWait: (value: { exitCode: number | null }) => void = () => {};
|
||||
const waitPromise = new Promise<{ exitCode: number | null }>((resolve) => {
|
||||
settleWait = resolve;
|
||||
});
|
||||
let settleWait: (value: { exitCode: number | null; transportClosed?: boolean }) => void =
|
||||
() => {};
|
||||
const waitPromise = new Promise<{ exitCode: number | null; transportClosed?: boolean }>(
|
||||
(resolve) => {
|
||||
settleWait = resolve;
|
||||
},
|
||||
);
|
||||
const route: DuplexChannelRoute = {
|
||||
hostRouteId,
|
||||
state: "reserved",
|
||||
|
||||
Reference in new issue
Block a user