From bf237e424f1d58ee13663b4dc9810ef678bad9a6 Mon Sep 17 00:00:00 2001 From: scotttong Date: Wed, 30 Sep 2026 11:10:57 -0700 Subject: [PATCH] test(connections): follow Asana onto the direct-OAuth path Left red by the step-4 commit and pushed that way: once live discovery began outranking Asana's pinned customer-only ownership mode it became a direct OAuth connect slug, but this assertion still said otherwise. Co-Authored-By: Claude Opus 5 --- ui/src/pages/apps/app-connect-policy.test.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ui/src/pages/apps/app-connect-policy.test.ts b/ui/src/pages/apps/app-connect-policy.test.ts index 64c73f3e4c0..e4a5fa1b7e6 100644 --- a/ui/src/pages/apps/app-connect-policy.test.ts +++ b/ui/src/pages/apps/app-connect-policy.test.ts @@ -15,7 +15,13 @@ describe("app connect policy", () => { expect(MCP_DIRECT_OAUTH_CONNECT_SLUGS).toEqual(expect.arrayContaining(["jira", "notion", "sentry"])); expect(isMcpDirectOAuthConnectSlug("notion")).toBe(true); expect(isMcpDirectOAuthConnectSlug("jira")).toBe(true); - expect(isMcpDirectOAuthConnectSlug("asana")).toBe(false); + // PAP-659 step 4: Asana's own OAuth metadata advertises registration, and + // live discovery now outranks its pinned customer-only ownership mode, so + // it reaches the provider directly instead of the client-ID form. + expect(isMcpDirectOAuthConnectSlug("asana")).toBe(true); + // Still false, and for two different reasons worth keeping apart: GitHub's + // one-click path is Paperclip-managed rather than direct, and Slack really + // does require a customer-registered OAuth client. expect(isMcpDirectOAuthConnectSlug("github")).toBe(false); expect(isMcpDirectOAuthConnectSlug("slack")).toBe(false); expect(isMcpDirectOAuthConnectSlug(null)).toBe(false);