mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-21 19:02:37 +01:00
feat(routines): let agents list and change their person's routines in plain terms (#22274)
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Routines are recurring work that an agent runs on a schedule, webhook or request. People file them under their responsibilities. > - #22253 and #22261 let agents read and change areas and responsibilities. Agents still have no dedicated routine tools, and they can change only routines assigned to themselves. > - When a person says "move my weekly digest to Monday mornings" or "map my routines to my responsibilities", the agent must use the generic API, write cron, and it is refused for the person's routines. > - This pull request adds `list_routines` and `update_routine`. It also lets an agent change routines that the person its run works for is responsible for. > - The benefit is that an agent can find routines under no responsibility, file them, and change their schedule in plain terms. Each change is a routine revision the person can restore. ## Linked Issues or Issue Description Refs #22261 (phase 2; this pull request is stacked on it), #22253 (phase 1). **Subsystem affected** Server (routine routes, native runner tool authority), the native runner tool catalog, and the `paperclip` skill. **Problem or motivation** An agent can list and change only its own routines through the generic API. It cannot change the schedule of a routine its person is responsible for. It must write cron expressions, and it cannot find the routines that are filed under no responsibility. **Proposed solution** Make the existing scenario operation `list_routines` live, with filters for words, status, agent, project, responsible person, a responsibility and "unfiled". Add `update_routine` for the title, instructions, agent, project, status, priority, a plain `schedule`, and filing under a responsibility. Let an agent manage a routine when the person its run works for is responsible for it. Handing the routine to another agent needs that person to have `tasks:assign`. **Alternatives considered** A new `routines` permission grant would add a setting with no current need. Routine revisions already give an undo path, so this change adds no new history. ## What Changed - `list_routines` is now live (it was a scenario-only mock) and keeps its scenario mock. - Add `update_routine`. A `schedule` such as `{ frequency: "weekly", dayOfWeek: "monday", time: "09:00", timezone }` maps to the routine's schedule trigger through the existing routine-offer cadence helpers. `schedule: null` turns the schedule off. `fileUnder` files the routine under a responsibility. - Add `server/src/services/routine-tools.ts`. It calls the routine routes with the run token. Fields and schedule go in one `PATCH /routines/:id` (one transaction and revision, guarded by `baseRevisionId`); filing follows, and if it fails after the routine changed the tool reports what was saved. Each part reports its own undo: the routine revision, or the Dashboard history for filing. - `PATCH /routines/:id` takes `schedule` (`{ cronExpression, timezone? }` or `null`) and replaces the schedule under the routine row lock, so racing changes leave one schedule. Without a zone it keeps the current schedule's, else uses the person's saved time zone, else answers 422. - `GET /companies/:companyId/routines` filters `q`, `status`, `assigneeAgentId`, `responsibleUserId`, `responsibilityId` and `unfiled=true` in SQL. - In `routes/routines.ts`, an agent may manage routines assigned to itself or routines its person is responsible for. On a routine the agent does not run, taking it from another agent (or handing it on), turning it on, changing its schedule (also through the trigger routes), starting a run, or restoring a revision requires that person's `tasks:assign`, as for a person. The person must have directed the run (see #22261). `routine.updated` activity records `onBehalfOfUserId`. - The routine and responsibility routes share one rule, `agentPersonInCompany` in `routes/agent-person-authz.ts`. - The catalog keeps each live action's `requiredClaims` (`list_routines` is `routines:read`). - The routine tools stay visible when Responsibilities is off. Only `responsibilityId`, `unfiled` and `fileUnder` need it. - Update `search_api` tool pointers, the routines reference, the skill section, the chat directive, the operation-groups spec and the pinned counts. ## Verification - Server: `routine-tools.test.ts` (new), `routines-routes.test.ts` (new: an agent changes its person's routine, hands it off only with `tasks:assign`, and is refused for another person's routine), the `responsibilit*` tests, `paperclip-runner-tool-authority` and `runner-api`: all pass. The first test in `routines-routes.test.ts` (Fireflies) times out at 15 s in my sandbox on a cold import, with or without this change. It passes with `--testTimeout=60000`. - Server `node scripts/typecheck-layers.mjs`: passed. - Runner: catalog, semantic-tool, eval, scenario and permission-policy tests (316) pass. All generator checks pass. ## Risks - Medium-low. Agents get write access to their person's routines. The route still checks the company, the routine revision guard and `tasks:assign` for a hand-off. The person can restore any earlier routine revision. - `list_routines` changes from a scenario-only mock to a live tool, so the reconciled catalog counts change. ## Model Used Claude Opus 5.5 (`claude-opus-5-5`) in Claude Code, with tool use and code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
40 files changed
+1386
-337
No files matched your search
@@ -0,0 +1,130 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { callRoutineTool } from "../services/routine-tools.js";
|
||||
|
||||
const COMPANY = "11111111-1111-4111-8111-111111111111";
|
||||
const ROUTINE = "44444444-4444-4444-8444-444444444444";
|
||||
const OTHER = "55555555-5555-4555-8555-555555555555";
|
||||
const RESPONSIBILITY = "33333333-3333-4333-8333-333333333333";
|
||||
const TRIGGER = "66666666-6666-4666-8666-666666666666";
|
||||
|
||||
function routine(overrides: Record<string, unknown> = {}) {
|
||||
return {
|
||||
id: ROUTINE, companyId: COMPANY, projectId: null, title: "Weekly pipeline", description: "Review the pipeline",
|
||||
assigneeAgentId: "agent-1", priority: "medium", status: "active", responsibleUserId: "person-1",
|
||||
latestRevisionId: "rev-1", latestRevisionNumber: 3, triggers: [], lastRun: null, ...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
/** A response with a status or headers; plain values answer 200. */
|
||||
class Reply {
|
||||
constructor(readonly body: unknown, readonly status = 200, readonly headers: Record<string, string> = {}) {}
|
||||
}
|
||||
|
||||
/** Answers by "METHOD path" or path, and records each request. */
|
||||
function fakeApi(routes: Record<string, unknown | (() => unknown)>) {
|
||||
const calls: Array<{ method: string; path: string; body?: unknown }> = [];
|
||||
const fetcher = (async (url: string | URL, init?: RequestInit) => {
|
||||
const method = init?.method ?? "GET";
|
||||
const path = String(url).replace("http://paperclip.test/api", "");
|
||||
calls.push({ method, path, ...(init?.body ? { body: JSON.parse(String(init.body)) } : {}) });
|
||||
const route = routes[`${method} ${path}`] ?? routes[path];
|
||||
if (route === undefined) throw new Error(`unexpected request ${method} ${path}`);
|
||||
const value = typeof route === "function" ? (route as () => unknown)() : route;
|
||||
const reply = value instanceof Reply ? value : new Reply(value);
|
||||
return new Response(JSON.stringify(reply.body), { status: reply.status, headers: { "content-type": "application/json", ...reply.headers } });
|
||||
}) as typeof fetch;
|
||||
return { calls, fetcher };
|
||||
}
|
||||
|
||||
const base = { apiUrl: "http://paperclip.test/api", token: "agent-token", companyId: COMPANY, companyPrefix: "PAP" };
|
||||
|
||||
describe("routine tools", () => {
|
||||
it("passes every filter to the routine list, so they apply before the limit", async () => {
|
||||
const query = new URLSearchParams({ q: "pipeline", status: "paused", responsibleUserId: "person-1", responsibilityId: RESPONSIBILITY, unfiled: "true" });
|
||||
const api = fakeApi({
|
||||
[`/companies/${COMPANY}/routines?${query}`]: [
|
||||
routine({ status: "paused", triggers: [{ id: TRIGGER, kind: "schedule", enabled: true, cronExpression: "0 9 * * 1", timezone: "Europe/Berlin", nextRunAt: null }] }),
|
||||
routine({ id: OTHER, status: "paused" }),
|
||||
],
|
||||
});
|
||||
const result = await callRoutineTool({ ...base, name: "list_routines", arguments: {
|
||||
query: "pipeline", status: "paused", responsibleUserId: "person-1", responsibilityId: RESPONSIBILITY, unfiled: true, limit: 1,
|
||||
} }, api.fetcher);
|
||||
expect(result).toMatchObject({
|
||||
total: 2,
|
||||
routines: [{ id: ROUTINE, title: "Weekly pipeline", triggers: [{ triggerId: TRIGGER, cronExpression: "0 9 * * 1", timezone: "Europe/Berlin" }], href: `/PAP/routines/${ROUTINE}` }],
|
||||
truncated: true,
|
||||
});
|
||||
});
|
||||
|
||||
it("changes a routine and its schedule in one call, files it, and reports each undo", async () => {
|
||||
let reads = 0;
|
||||
const scheduled = [{ id: TRIGGER, kind: "schedule", enabled: true, cronExpression: "30 9 * * 1", timezone: "Europe/Berlin", nextRunAt: null }];
|
||||
const api = fakeApi({
|
||||
[`GET /routines/${ROUTINE}`]: () => (reads++ === 0 ? routine() : routine({ title: "Pipeline review", latestRevisionNumber: 4, triggers: scheduled })),
|
||||
[`PATCH /routines/${ROUTINE}`]: routine({ title: "Pipeline review" }),
|
||||
[`POST /responsibilities/${RESPONSIBILITY}/file`]: new Reply({ filed: [], unfiled: [] }, 200,
|
||||
{ "x-paperclip-dashboard-version": "version-7", "x-paperclip-dashboard-owner": "person-1" }),
|
||||
});
|
||||
const result = await callRoutineTool({ ...base, name: "update_routine", arguments: {
|
||||
routineId: ROUTINE, title: "Pipeline review", instructions: "Review the pipeline and flag stalled deals",
|
||||
schedule: { frequency: "weekly", dayOfWeek: "monday", time: "09:30", timezone: "Europe/Berlin" }, fileUnder: RESPONSIBILITY,
|
||||
} }, api.fetcher);
|
||||
expect(api.calls.filter((call) => call.method !== "GET")).toEqual([
|
||||
{ method: "PATCH", path: `/routines/${ROUTINE}`, body: {
|
||||
title: "Pipeline review", description: "Review the pipeline and flag stalled deals",
|
||||
schedule: { cronExpression: "30 9 * * 1", timezone: "Europe/Berlin" }, baseRevisionId: "rev-1",
|
||||
} },
|
||||
{ method: "POST", path: `/responsibilities/${RESPONSIBILITY}/file`, body: { items: [{ kind: "routine", id: ROUTINE }] } },
|
||||
]);
|
||||
expect(result).toMatchObject({
|
||||
routine: { title: "Pipeline review", revision: 4 },
|
||||
schedule: { label: "Every Monday at 9:30 AM", cronExpression: "30 9 * * 1", timezone: "Europe/Berlin" },
|
||||
filedUnder: { responsibilityId: RESPONSIBILITY, dashboardVersionId: "version-7", dashboardOwnerUserId: "person-1", undo: expect.stringContaining("Dashboard history") },
|
||||
undo: expect.stringMatching(/restoring revision 3 .*not the filing/),
|
||||
});
|
||||
});
|
||||
|
||||
it("says what was saved when filing fails after the routine changed", async () => {
|
||||
let reads = 0;
|
||||
const api = fakeApi({
|
||||
[`GET /routines/${ROUTINE}`]: () => (reads++ === 0 ? routine() : routine({ title: "Pipeline review", latestRevisionNumber: 4 })),
|
||||
[`PATCH /routines/${ROUTINE}`]: routine({ title: "Pipeline review" }),
|
||||
[`POST /responsibilities/${RESPONSIBILITY}/file`]: new Reply({ error: "Responsibilities are not enabled", code: "responsibilities_disabled" }, 404),
|
||||
});
|
||||
const result = await callRoutineTool({ ...base, name: "update_routine", arguments: { routineId: ROUTINE, title: "Pipeline review", fileUnder: RESPONSIBILITY } }, api.fetcher);
|
||||
expect(result).toMatchObject({
|
||||
routine: { title: "Pipeline review", revision: 4 },
|
||||
filedUnder: { responsibilityId: RESPONSIBILITY, failed: true, error: "Responsibilities are not enabled", note: expect.stringContaining("was saved") },
|
||||
undo: expect.stringContaining("restoring revision 3"),
|
||||
});
|
||||
|
||||
// A filing on its own still fails loudly: nothing else was saved.
|
||||
await expect(callRoutineTool({ ...base, name: "update_routine", arguments: { routineId: ROUTINE, fileUnder: RESPONSIBILITY } }, api.fetcher))
|
||||
.rejects.toMatchObject({ status: 404 });
|
||||
});
|
||||
|
||||
it("leaves the zone to the server when none is given, and turns schedules off with null", async () => {
|
||||
const add = fakeApi({
|
||||
[`GET /routines/${ROUTINE}`]: routine(),
|
||||
[`PATCH /routines/${ROUTINE}`]: routine(),
|
||||
});
|
||||
await callRoutineTool({ ...base, name: "update_routine", arguments: { routineId: ROUTINE, schedule: { frequency: "weekdays", time: "08:00" } } }, add.fetcher);
|
||||
expect(add.calls.find((call) => call.method === "PATCH")?.body).toEqual({ schedule: { cronExpression: "0 8 * * 1-5" }, baseRevisionId: "rev-1" });
|
||||
|
||||
const off = fakeApi({
|
||||
[`GET /routines/${ROUTINE}`]: routine({ triggers: [{ id: TRIGGER, kind: "schedule", enabled: true, cronExpression: "0 9 * * 1", timezone: "UTC", nextRunAt: null }] }),
|
||||
[`PATCH /routines/${ROUTINE}`]: routine(),
|
||||
});
|
||||
const result = await callRoutineTool({ ...base, name: "update_routine", arguments: { routineId: ROUTINE, schedule: null } }, off.fetcher);
|
||||
expect(off.calls.find((call) => call.method === "PATCH")?.body).toEqual({ schedule: null, baseRevisionId: "rev-1" });
|
||||
expect(result).toMatchObject({ schedule: { turnedOff: 1 } });
|
||||
});
|
||||
|
||||
it("refuses an empty change and a weekly schedule without its day", async () => {
|
||||
const api = fakeApi({ [`GET /routines/${ROUTINE}`]: routine() });
|
||||
await expect(callRoutineTool({ ...base, name: "update_routine", arguments: { routineId: ROUTINE } }, api.fetcher)).rejects.toMatchObject({ status: 422 });
|
||||
await expect(callRoutineTool({ ...base, name: "update_routine", arguments: { routineId: ROUTINE, schedule: { frequency: "weekly", time: "09:00" } } }, api.fetcher))
|
||||
.rejects.toThrow(/dayOfWeek/);
|
||||
});
|
||||
});
|
||||
@@ -27,10 +27,14 @@ import {
|
||||
principalPermissionGrants,
|
||||
projectWorkspaces,
|
||||
projects,
|
||||
responsibilities,
|
||||
responsibilityLinks,
|
||||
routineDocuments,
|
||||
routineRevisions,
|
||||
routineRuns,
|
||||
routines,
|
||||
routineTriggers,
|
||||
userWorkspacePreferences,
|
||||
} from "@paperclipai/db";
|
||||
import {
|
||||
getEmbeddedPostgresTestSupport,
|
||||
@@ -115,6 +119,9 @@ describeEmbeddedPostgres("routine routes end-to-end", () => {
|
||||
await db.delete(documentAnnotationAnchorSnapshots);
|
||||
await db.delete(documentAnnotationComments);
|
||||
await db.delete(documentAnnotationThreads);
|
||||
await db.delete(responsibilityLinks);
|
||||
await db.delete(responsibilities);
|
||||
await db.delete(userWorkspacePreferences);
|
||||
await db.delete(routineRuns);
|
||||
await db.delete(routineTriggers);
|
||||
await db.delete(heartbeatRunEvents);
|
||||
@@ -1057,4 +1064,148 @@ describeEmbeddedPostgres("routine routes end-to-end", () => {
|
||||
executionWorkspaceSettings: { mode: "isolated_workspace" },
|
||||
});
|
||||
});
|
||||
|
||||
describe("an agent acting for the routine's person", () => {
|
||||
/** A second agent, working in the person's own chat, so it acts for them. */
|
||||
async function helperFor(companyId: string, personUserId: string) {
|
||||
const [helper] = await db.insert(agents).values({
|
||||
companyId, name: "Helper", role: "general", status: "active", adapterType: "codex_local", adapterConfig: {}, runtimeConfig: {}, permissions: {},
|
||||
}).returning();
|
||||
const [chat] = await db.insert(issues).values({ companyId, title: "Chat", createdByUserId: personUserId, responsibleUserId: personUserId }).returning();
|
||||
const [run] = await db.insert(heartbeatRuns).values({ companyId, agentId: helper!.id, issueId: chat!.id, scopeKind: "issue", status: "running", contextSnapshot: { issueId: chat!.id } }).returning();
|
||||
const app = await createApp({
|
||||
type: "agent", agentId: helper!.id, companyId, runId: run!.id, source: "agent_jwt",
|
||||
onBehalfOfUserId: personUserId, onBehalfOfMemberships: [{ companyId, membershipRole: "owner", status: "active" }],
|
||||
});
|
||||
return { app, helperId: helper!.id };
|
||||
}
|
||||
|
||||
async function personRoutine(companyId: string, agentId: string, userId: string, values: Record<string, unknown> = {}) {
|
||||
const board = await createApp({ type: "board", source: "local_implicit", userId, isInstanceAdmin: true });
|
||||
const created = await request(board).post(`/api/companies/${companyId}/routines`).send({ assigneeAgentId: agentId, title: "Weekly pipeline", ...values });
|
||||
expect(created.status, JSON.stringify(created.body)).toBe(201);
|
||||
return created.body.id as string;
|
||||
}
|
||||
|
||||
it("reschedules its person's routine run by another agent in one revision, with one schedule however often it races", async () => {
|
||||
const { companyId, agentId, userId } = await seedFixture();
|
||||
const routineId = await personRoutine(companyId, agentId, userId);
|
||||
const { app } = await helperFor(companyId, userId);
|
||||
const revisions = async () => db.select().from(routineRevisions).where(eq(routineRevisions.routineId, routineId));
|
||||
const before = (await revisions()).length;
|
||||
|
||||
// No zone given, none on the routine and none saved for the person: the agent must name one.
|
||||
const unnamed = await request(app).patch(`/api/routines/${routineId}`).send({ title: "Pipeline review", schedule: { cronExpression: "30 9 * * 1" } });
|
||||
expect(unnamed.status).toBe(422);
|
||||
expect((await revisions()).length).toBe(before);
|
||||
|
||||
await db.insert(userWorkspacePreferences).values({ userId, timeZone: "Europe/Berlin" });
|
||||
const changed = await request(app).patch(`/api/routines/${routineId}`).send({ title: "Pipeline review", schedule: { cronExpression: "30 9 * * 1" } });
|
||||
expect(changed.status, JSON.stringify(changed.body)).toBe(200);
|
||||
const after = await revisions();
|
||||
expect(after.length).toBe(before + 1);
|
||||
expect(after.find((revision) => revision.revisionNumber === Math.max(...after.map((r) => r.revisionNumber)))?.changeSummary).toBe("Updated routine and schedule");
|
||||
const schedules = async () => db.select().from(routineTriggers).where(eq(routineTriggers.routineId, routineId));
|
||||
expect(await schedules()).toMatchObject([{ kind: "schedule", enabled: true, cronExpression: "30 9 * * 1", timezone: "Europe/Berlin" }]);
|
||||
|
||||
// Two changes at once: the routine lock keeps one enabled schedule.
|
||||
await db.delete(routineTriggers).where(eq(routineTriggers.routineId, routineId));
|
||||
const raced = await Promise.all([
|
||||
request(app).patch(`/api/routines/${routineId}`).send({ schedule: { cronExpression: "0 8 * * *", timezone: "UTC" } }),
|
||||
request(app).patch(`/api/routines/${routineId}`).send({ schedule: { cronExpression: "0 18 * * *", timezone: "UTC" } }),
|
||||
]);
|
||||
expect(raced.map((res) => res.status)).toEqual([200, 200]);
|
||||
expect((await schedules()).filter((trigger) => trigger.enabled)).toHaveLength(1);
|
||||
|
||||
const off = await request(app).patch(`/api/routines/${routineId}`).send({ schedule: null });
|
||||
expect(off.status).toBe(200);
|
||||
expect((await schedules()).every((trigger) => !trigger.enabled)).toBe(true);
|
||||
|
||||
// Handing the routine to another person with a new time: the time is in the new person's zone.
|
||||
const nextPerson = randomUUID();
|
||||
await accessService(db).ensureMembership(companyId, "user", nextPerson, "operator", "active");
|
||||
await db.insert(userWorkspacePreferences).values({ userId: nextPerson, timeZone: "Asia/Tokyo" });
|
||||
await db.delete(routineTriggers).where(eq(routineTriggers.routineId, routineId));
|
||||
const board = await createApp({ type: "board", source: "local_implicit", userId, isInstanceAdmin: true });
|
||||
const handed = await request(board).patch(`/api/routines/${routineId}`).send({ responsibleUserId: nextPerson, schedule: { cronExpression: "0 9 * * *" } });
|
||||
expect(handed.status, JSON.stringify(handed.body)).toBe(200);
|
||||
expect(await schedules()).toMatchObject([{ enabled: true, timezone: "Asia/Tokyo" }]);
|
||||
});
|
||||
|
||||
it("refuses another person's routine, and needs the person's tasks:assign to take, turn on or reschedule one it does not run", async () => {
|
||||
const { companyId, agentId, userId } = await seedFixture();
|
||||
const memberId = randomUUID();
|
||||
await accessService(db).ensureMembership(companyId, "user", memberId, "operator", "active");
|
||||
// A member who may not assign tasks, as under a restricted assignment policy.
|
||||
vi.doMock("../services/index.js", async () => {
|
||||
const [{ accessService: realAccess }, { documentAnnotationService }, { logActivity }, { routineService }] = await Promise.all([
|
||||
import("../services/access.js"), import("../services/document-annotations.js"),
|
||||
import("../services/activity-log.js"), import("../services/routines.js"),
|
||||
]);
|
||||
const accessService = (database: typeof db) => {
|
||||
const access = realAccess(database);
|
||||
return { ...access, canUser: async (...args: Parameters<typeof access.canUser>) =>
|
||||
(args[1] === memberId && args[2] === "tasks:assign" ? false : access.canUser(...args)) };
|
||||
};
|
||||
return { accessService, documentAnnotationService, logActivity, routineService };
|
||||
});
|
||||
const ownersRoutine = await personRoutine(companyId, agentId, userId);
|
||||
const membersRoutine = await personRoutine(companyId, agentId, userId, { status: "paused" });
|
||||
await db.update(routines).set({ responsibleUserId: memberId }).where(eq(routines.id, membersRoutine));
|
||||
|
||||
const { app: forMember, helperId } = await helperFor(companyId, memberId);
|
||||
// Not the member's routine: no change at all.
|
||||
expect((await request(forMember).patch(`/api/routines/${ownersRoutine}`).send({ title: "x" })).status).toBe(403);
|
||||
// The member's routine: an ordinary change is fine, but the member may not assign tasks.
|
||||
expect((await request(forMember).patch(`/api/routines/${membersRoutine}`).send({ title: "Member pipeline" })).status).toBe(200);
|
||||
expect((await request(forMember).patch(`/api/routines/${membersRoutine}`).send({ assigneeAgentId: helperId })).status).toBe(403);
|
||||
expect((await request(forMember).patch(`/api/routines/${membersRoutine}`).send({ status: "active" })).status).toBe(403);
|
||||
expect((await request(forMember).patch(`/api/routines/${membersRoutine}`).send({ schedule: { cronExpression: "0 9 * * 1", timezone: "UTC" } })).status).toBe(403);
|
||||
expect((await request(forMember).post(`/api/routines/${membersRoutine}/triggers`).send({ kind: "schedule", cronExpression: "0 9 * * 1", timezone: "UTC" })).status).toBe(403);
|
||||
// Nor change an existing trigger, start the routine, or restore a revision of it.
|
||||
const board = await createApp({ type: "board", source: "local_implicit", userId, isInstanceAdmin: true });
|
||||
const trigger = await request(board).post(`/api/routines/${membersRoutine}/triggers`).send({ kind: "schedule", cronExpression: "0 9 * * 1", timezone: "UTC", enabled: false });
|
||||
expect(trigger.status, JSON.stringify(trigger.body)).toBe(201);
|
||||
expect((await request(forMember).patch(`/api/routine-triggers/${trigger.body.trigger.id}`).send({ enabled: true })).status).toBe(403);
|
||||
expect((await request(forMember).delete(`/api/routine-triggers/${trigger.body.trigger.id}`)).status).toBe(403);
|
||||
expect((await request(forMember).post(`/api/routines/${membersRoutine}/run`).send({})).status).toBe(403);
|
||||
const [revision] = await db.select().from(routineRevisions).where(eq(routineRevisions.routineId, membersRoutine)).limit(1);
|
||||
expect((await request(forMember).post(`/api/routines/${membersRoutine}/revisions/${revision!.id}/restore`).send({})).status).toBe(403);
|
||||
|
||||
// The owner may assign tasks, so an agent acting for them may take the routine.
|
||||
const { app: forOwner, helperId: ownersHelper } = await helperFor(companyId, userId);
|
||||
const taken = await request(forOwner).patch(`/api/routines/${ownersRoutine}`).send({ assigneeAgentId: ownersHelper });
|
||||
expect(taken.status, JSON.stringify(taken.body)).toBe(200);
|
||||
// The agent that runs a routine still reschedules its own, also through its trigger.
|
||||
const runner = await createApp({ type: "agent", agentId, companyId });
|
||||
expect((await request(runner).patch(`/api/routines/${membersRoutine}`).send({ schedule: { cronExpression: "0 9 * * 1", timezone: "UTC" } })).status).toBe(200);
|
||||
expect((await request(runner).patch(`/api/routine-triggers/${trigger.body.trigger.id}`).send({ cronExpression: "0 10 * * 1" })).status).toBe(200);
|
||||
});
|
||||
|
||||
it("filters the list in the query: words, status and routines filed under no responsibility", async () => {
|
||||
const { companyId, agentId, userId } = await seedFixture();
|
||||
await db.delete(instanceSettings);
|
||||
await db.insert(instanceSettings).values({ experimental: { enableResponsibilities: true } });
|
||||
const filed = await personRoutine(companyId, agentId, userId, { title: "Pipeline filed" });
|
||||
const loose = await personRoutine(companyId, agentId, userId, { title: "Pipeline loose", status: "paused" });
|
||||
await personRoutine(companyId, agentId, userId, { title: "Standup" });
|
||||
const [hiring] = await db.insert(responsibilities).values({ companyId, ownerUserId: userId, title: "Hiring", status: "active" }).returning();
|
||||
await db.insert(responsibilityLinks).values({ companyId, responsibilityId: hiring!.id, routineId: filed });
|
||||
const board = await createApp({ type: "board", source: "local_implicit", userId, isInstanceAdmin: true });
|
||||
const list = async (query: string) => (await request(board).get(`/api/companies/${companyId}/routines?${query}`)).body.map((routine: { id: string }) => routine.id);
|
||||
|
||||
expect(await list("q=PIPELINE")).toEqual(expect.arrayContaining([filed, loose]));
|
||||
expect(await list("q=PIPELINE")).toHaveLength(2);
|
||||
expect(await list("q=pipeline&unfiled=true&status=paused")).toEqual([loose]);
|
||||
expect(await list(`responsibilityId=${hiring!.id}`)).toEqual([filed]);
|
||||
|
||||
// The responsibility filters are part of the Responsibilities experiment; plain searches are not.
|
||||
await db.update(instanceSettings).set({ experimental: { enableResponsibilities: false } });
|
||||
(await import("../services/instance-settings-cache.js")).invalidateInstanceSettingsCache();
|
||||
const off = await request(board).get(`/api/companies/${companyId}/routines?unfiled=true`);
|
||||
expect(off.status).toBe(404);
|
||||
expect(off.body.code).toBe("responsibilities_disabled");
|
||||
expect(await list("q=standup")).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -135,6 +135,15 @@ const mockGetTelemetryClient = vi.hoisted(() => vi.fn());
|
||||
|
||||
function registerModuleMocks() {
|
||||
vi.doMock("../routes/authz.js", async () => vi.importActual("../routes/authz.js"));
|
||||
// Whether the person directed the run reads the database these tests mock away; routines-e2e covers it.
|
||||
// Here every run with a person was directed by them.
|
||||
vi.doMock("../routes/agent-person-authz.js", () => ({
|
||||
agentPersonInCompany: async (_db: unknown, req: { actor: { type: string; onBehalfOfUserId?: string; onBehalfOfMemberships?: Array<{ companyId: string; status?: string; membershipRole?: string | null }> } }, companyId: string) => {
|
||||
if (req.actor.type !== "agent" || !req.actor.onBehalfOfUserId) return null;
|
||||
const membership = req.actor.onBehalfOfMemberships?.find((item) => item.companyId === companyId && item.status === "active");
|
||||
return membership ? { userId: req.actor.onBehalfOfUserId, role: membership.membershipRole ?? null } : null;
|
||||
},
|
||||
}));
|
||||
|
||||
vi.doMock("@paperclipai/shared/telemetry", () => ({
|
||||
trackRoutineCreated: mockTrackRoutineCreated,
|
||||
@@ -568,6 +577,35 @@ describe("routine routes", () => {
|
||||
expect(res.body).not.toHaveProperty("previousResponsibleUserId");
|
||||
});
|
||||
|
||||
it("lets an agent change a routine the person it works for is responsible for", async () => {
|
||||
const personsRoutine = { ...routine, assigneeAgentId: otherAgentId, responsibleUserId: "person-1" };
|
||||
mockRoutineService.get.mockResolvedValue(personsRoutine);
|
||||
mockRoutineService.update.mockResolvedValue({ ...personsRoutine, title: "Weekly digest" });
|
||||
const forPerson = await createApp({
|
||||
type: "agent", agentId, companyId, onBehalfOfUserId: "person-1",
|
||||
onBehalfOfMemberships: [{ companyId, membershipRole: "member", status: "active" }],
|
||||
});
|
||||
const res = await request(forPerson).patch(`/api/routines/${routineId}`).send({ title: "Weekly digest" });
|
||||
expect(res.status).toBe(200);
|
||||
expect(mockLogActivity).toHaveBeenCalledWith(expect.anything(), expect.objectContaining({
|
||||
action: "routine.updated", details: expect.objectContaining({ onBehalfOfUserId: "person-1" }),
|
||||
}));
|
||||
|
||||
// Handing it to another agent is an assignment the person must be allowed to make.
|
||||
const handOff = await request(forPerson).patch(`/api/routines/${routineId}`).send({ assigneeAgentId: projectId });
|
||||
expect(handOff.status).toBe(403);
|
||||
mockAccessService.canUser.mockResolvedValue(true);
|
||||
expect((await request(forPerson).patch(`/api/routines/${routineId}`).send({ assigneeAgentId: projectId })).status).toBe(200);
|
||||
expect(mockAccessService.canUser).toHaveBeenCalledWith(companyId, "person-1", "tasks:assign");
|
||||
|
||||
// An agent working for someone else may not.
|
||||
const forOther = await createApp({
|
||||
type: "agent", agentId, companyId, onBehalfOfUserId: "person-2",
|
||||
onBehalfOfMemberships: [{ companyId, membershipRole: "owner", status: "active" }],
|
||||
});
|
||||
expect((await request(forOther).patch(`/api/routines/${routineId}`).send({ title: "x" })).status).toBe(403);
|
||||
});
|
||||
|
||||
it("prevents even the assigned agent from transferring routine responsibility", async () => {
|
||||
const app = await createApp({ type: "agent", agentId, companyId });
|
||||
mockRoutineService.getDetail.mockResolvedValue(routine);
|
||||
|
||||
Reference in new issue
Block a user