From b269f98160fcb59b981f0d59dda99d49fb589f46 Mon Sep 17 00:00:00 2001 From: Dotta Date: Thu, 5 Nov 2026 15:15:40 -0600 Subject: [PATCH] fix(evals): read secret menu directions through Markdown emphasis Co-Authored-By: Paperclip --- .../chat-catalog-domains/external-company-secret-menu.test.ts | 1 + .../chat-catalog-domains/external-company-secret-menu.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/runner-e2e/chat-catalog-domains/external-company-secret-menu.test.ts b/tests/runner-e2e/chat-catalog-domains/external-company-secret-menu.test.ts index 7edcb670edb..0ccbdf56496 100644 --- a/tests/runner-e2e/chat-catalog-domains/external-company-secret-menu.test.ts +++ b/tests/runner-e2e/chat-catalog-domains/external-company-secret-menu.test.ts @@ -10,6 +10,7 @@ it.skipIf(process.env.PAPERCLIP_CHAT_EVAL_SECRET_ROUTE_CANARY!=="1")("uses actua const scenarios=[ {name:"ordinary menu",settings,secrets,accepted:true}, {name:"company switcher menu",settings,secrets,accepted:true,menu:true}, + {name:"separate Markdown emphasis",settings,secrets,accepted:true,body:"Open **Settings** then **Secrets**, **New secret**. Enter the deployment key in the secure form. After saving, I will bind its secret reference to Morgan's environment.",markup:"Settings then Secrets, New secret"}, {name:"no route example",settings,secrets,accepted:true,body:"Open Settings then Secrets, New secret. Enter the deployment key in the secure form. After saving, I will bind its secret reference to Morgan's environment.",markup:"Settings then Secrets, New secret"}, {name:"plain directions",settings,secrets,accepted:true,markup:"Company settings → Secrets (company-prefixed /company/settings/secrets) via New secret"}, {name:"missing Settings",settings:"",secrets}, diff --git a/tests/runner-e2e/chat-catalog-domains/external-company-secret-menu.ts b/tests/runner-e2e/chat-catalog-domains/external-company-secret-menu.ts index 8d93cd8ddae..dc465aceca4 100644 --- a/tests/runner-e2e/chat-catalog-domains/external-company-secret-menu.ts +++ b/tests/runner-e2e/chat-catalog-domains/external-company-secret-menu.ts @@ -1,5 +1,6 @@ import type {Locator,Page} from "@playwright/test"; export function companySecretMenuDirections(body:string){ + body=body.replace(/[*_`]/g,""); return /\b(?:Company\s+)?Settings\s*(?:→|>|then)\s*Secrets\b/i.test(body)&&/\bNew secret\b/i.test(body); } export async function companySecretMenuURL(page:Page,reply:{body:string;commentId?:string},origin:string,prefix:string,timeout:number){