Address workspace diff review findings

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
DottaandPaperclip committed 2026-05-15 13:28:59 -05:00
1 parent 4c98a35b8c
commit af5f646e51
12 files changed
+68 -39

No files matched your search

+31 -20
View File
@@ -62,6 +62,13 @@ jobs:
pnpm install --lockfile-only --ignore-scripts --no-frozen-lockfile
fi
- name: Upload resolved lockfile
uses: actions/upload-artifact@v4
with:
name: pr-pnpm-lock-${{ github.run_id }}
path: pnpm-lock.yaml
retention-days: 1
verify:
needs: [policy]
runs-on: ubuntu-latest
@@ -82,12 +89,13 @@ jobs:
node-version: 24
cache: pnpm
- name: Use policy-resolved lockfile
uses: actions/download-artifact@v4
with:
name: pr-pnpm-lock-${{ github.run_id }}
- name: Install dependencies
run: |
pnpm install --frozen-lockfile || {
echo "Frozen lockfile install failed; retrying without frozen lockfile because PRs do not commit pnpm-lock.yaml."
pnpm install --no-frozen-lockfile
}
run: pnpm install --frozen-lockfile
- name: Typecheck workspaces whose build scripts skip TypeScript
run: pnpm run typecheck:build-gaps
@@ -138,12 +146,13 @@ jobs:
node-version: 24
cache: pnpm
- name: Use policy-resolved lockfile
uses: actions/download-artifact@v4
with:
name: pr-pnpm-lock-${{ github.run_id }}
- name: Install dependencies
run: |
pnpm install --frozen-lockfile || {
echo "Frozen lockfile install failed; retrying without frozen lockfile because PRs do not commit pnpm-lock.yaml."
pnpm install --no-frozen-lockfile
}
run: pnpm install --frozen-lockfile
- name: Run serialized server test shard
run: pnpm test:run:serialized -- --shard-index ${{ matrix.shard_index }} --shard-count ${{ matrix.shard_count }}
@@ -169,12 +178,13 @@ jobs:
node-version: 24
cache: pnpm
- name: Use policy-resolved lockfile
uses: actions/download-artifact@v4
with:
name: pr-pnpm-lock-${{ github.run_id }}
- name: Install dependencies
run: |
pnpm install --frozen-lockfile || {
echo "Frozen lockfile install failed; retrying without frozen lockfile because PRs do not commit pnpm-lock.yaml."
pnpm install --no-frozen-lockfile
}
run: pnpm install --frozen-lockfile
# `release.sh` always executes its Step 2/7 workspace build, even when
# `--skip-verify` bypasses the initial verification gate.
@@ -204,12 +214,13 @@ jobs:
node-version: 24
cache: pnpm
- name: Use policy-resolved lockfile
uses: actions/download-artifact@v4
with:
name: pr-pnpm-lock-${{ github.run_id }}
- name: Install dependencies
run: |
pnpm install --frozen-lockfile || {
echo "Frozen lockfile install failed; retrying without frozen lockfile because PRs do not commit pnpm-lock.yaml."
pnpm install --no-frozen-lockfile
}
run: pnpm install --frozen-lockfile
- name: Install Playwright
run: npx playwright install --with-deps chromium