From 2eb5187e43b0a06361ae2489664fb5ac5f7c9977 Mon Sep 17 00:00:00 2001 From: Dotta <34892728+cryppadotta@users.noreply.github.com> Date: Fri, 9 Oct 2026 10:19:13 -0500 Subject: [PATCH 1/4] Runner/Pi 2/5: document setup and fix CI fixtures (#14922) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Thinking Path > - Paperclip manages AI agents and their work. > - The experimental Runner owns provider processes and durable sessions. > - Pi needs working task execution and human controls. > - The five-PR stack must preserve changes already on master. > - The runtime implementation has merged in #14921; this layer carries setup documentation and a narrowly scoped CI fixture repair. > - This PR belongs to native GitHub stack #15602, ending at #14956. ## Linked Issues or Issue Description Refs #14436, #14631, #14743 and #14956. Ship Pi 1.0 through the experimental Paperclip Runner. The five PRs are #14921, #14922, #14923, #14924 and #14956. The user authorized the complete merge after checks pass. Existing `pi_local` execution is unchanged. Accounting and wider provider/platform qualification remain deferred. ## What Changed - Create the warm Pi fake sidecar and its directory with explicit private modes, independent of the runner umask. Preserve the qualified-asset permission guard and every warm-admission timing assertion. - Document explicit public Pi host setup and verified Linux companion import for Daytona. - Preserve historical installation and qualification checkpoints with their original source identities. - Use the repository's existing `EMBEDDED_POSTGRES_TEST_TIMEOUT_MS` for the backup error fixture, which starts a real PostgreSQL cluster. Preserve all error, archive, and retention assertions. ## Verification - Full local `pnpm -r typecheck` passes, including Runner Rust, server and UI. Focused integration checks pass: 194 Runner admission/environment tests, 63 profile/credential tests with one expected skip, 152 Dot/UI configuration tests, and Pi transcript/notice tests. - Full local `pnpm build` passes on the final source. - Fresh final-source checks pass: all 698 Rust workspace tests (32 binaries), 156 credential/profile/controller tests with one expected skip, Runner TypeScript typecheck, and 20 package/setup/sandbox tests. - The profile-21 Pi materializer passes on the native host with the official pinned Node 24.21.0 and its npm. It verifies all 150 locked packages, the patched dependency and the exact closure. Setup/package bundle tests and UI token gates pass. - The old hashes were reproduced for all three supported targets before calculating the patched graph. New closure hashes are darwin-arm64 `282022db10150c6632b3444df421342e7d534bdf5d5fb1097a2e79d0625a2bcf`, darwin-x64 `64e251e19009f755c0b04f73ce2138246faab71a961b0f13d75ebfcc34bef12e`, and linux-x64 `713b1fdff42fb56a1518bdc084f181d70bee8ebadc3e4b1d76321ed9108c8410`. Independent native platform execution is separate from graph identity reproduction. - Historical cloud qualification remains unchanged: all seven core cases pass on shipping source `10dc43c9ec65d88c2f782d62afb296d09494f215`, harness `1a4408a48cfb5a1f094a311141c257c92cd7a893`, image `sha256:5b3a775b383591bda1b0c1889e509acc70ce7f37c53f09733c81d59037f02280`, and accepted Sonnet 4.6/low fixture. All 215 canonical files and all seven cleanup checks pass independent verification. These are profile-19 results and are not relabeled as fresh profile-22 runs. - Current Pi digest: `sha256:e92078bee3c23bec4100aa589013a44613d054cd686826534025d8019e9f39a9`. [The readiness plan](https://github.com/paperclipai/paperclip/blob/codex/pi-production-readiness/doc/plans/2026-10-02-pi-production-readiness.md) preserves campaign and failed-attempt provenance. - Merge only after every PR's current-head CI and fresh review pass. Linux CI covers the full suites, build and browser tests. The local embedded Postgres API-authority suite cannot start on this macOS/Node 26 host, so Linux CI must confirm that suite. ### Fresh profile-22 core qualification — 2026-10-08 All seven accepted core cases pass canonically on Pi profile 22, with `openrouter/anthropic/claude-sonnet-4.6` and native-confirmed low thinking. This model is a fixture; production accepts the caller's explicit Pi provider/model. Runtime/install source: `3241a992f2a7703e59e97ed0fd3e5d6405de4401`. Frozen accepted harness: `1a4408a48cfb5a1f094a311141c257c92cd7a893`. Immutable cloud image: `ghcr.io/paperclipai/paperclip-daytona-runner@sha256:506f22db7edd78f37c0c40bec1cc084af1850455026dbf467194bfbb8fcef141`. Pi digest: `sha256:e92078bee3c23bec4100aa589013a44613d054cd686826534025d8019e9f39a9`. [Hosted Linux image and clean-install verification](https://github.com/paperclipai/paperclip/actions/runs/37868328023) passes, including all 20 source-bound archives, normal CLI/Pi setup, companion import and the production pack reader. This exact installation source includes the latest master integration and the corrected Pi warm instruction-root fence. Full local typecheck/build and current-head hosted CI verify the final stack. All 13 focused real-root regressions pass. The full local executor suite passed 662 tests; 15 database tests could not start the Mac embedded PostgreSQL service. Hosted Linux CI passes the full required verification and E2E checks. These fresh results keep their own source identity; profile-19 results remain historical. | Core path | Canonical campaign | Retained archive SHA-256 | | --- | --- | --- | | File edit, validation, download and Done | `pi-core22-replyfix-0-1791511228` | 23 files; `a473e8603a3dd4737863291f8d3d1e392391f0b16d433c3e0e0e9d8baf7a97b0` | | Pending question and controller restart | `pi-core22-replyfix-1-1791511376` | 33 files; `6b829c4eb74e1f32a89c692a4ae7130dbfc1c6d3cf13915effe2103d9e242c8e` | | Three-turn session/process/workspace continuity | `pi-core22-replyfix-2-1791511587` | 23 files; `7a87021f8f9a3fdd3c58bb4467f8d82c635e3ea4795d6e75f144d9aa14818df8` | | Four typed questions and browser reconnects | `pi-core22-replyfix-3-1791511881` | 42 files; `9e31755252be1f4f9cb0626c984c142d4d1ae5f5bee3a7af08444db8d12c280a` | | Plan approval and completion | `pi-core22-replyfix-4-1791512031` | 22 files; `a0383ce1aab38e7b5a25ce0e9dd3bebea5c037ebd96ae6b29dae19015da2ae2c` | | Same-turn steering and permission denial | `pi-core22-replyfix-5-1791512261` | 39 files; `c929b8c7070f0b66aedc17e65ca46e6beab1e363926ac9f7e2a75fb250f05949` | | Stop during pending permission | `pi-core22-replyfix-6-1791512390` | 33 files; `7f0a58ae0f4d5bfc76149435f4e322537089c5bd16e7ffe9b5ad71f10a621a07` | All 215 canonical files (28714587 bytes) are independently hash-verified. All seven cleanup grades pass, with no owned runtime process or temporary root after each case. Automatic retries are zero. The owned cloud host stopped normally after retention. The prior profile-22 warm attempt remains failed and separately retained: archive SHA-256 `1e54eba5ec72b50cee1534b23d1d1d4f21a090006b8a64501ba70db972abfde5`. Its original canonical classification is preserved. Diagnosis reproduced a product bug comparing an agent-files root against an unset checkpoint-only field. The fix stores the admitted physical root separately from the adopted per-run collection capability. The real-root regression fails before the fix and passes afterward, including rejection of a changed physical root. Fixture, grader, model and all seven accepted case IDs are unchanged; this fresh campaign tests final-reply publication after file registration first. The intermediate restart attempt also remains failed and retained: archive SHA-256 `5dcaefdf1d17cf4cd54fd4cf810f45e736667392339b8ce7caf08bb4e225277f`. Its original canonical classification is preserved. Pi resumed, wrote the verified answer and completed its task; exact runner suspension was proven, but idle stop consumed about 5.2s and left under 3s for the drain acknowledgement. The Pi-only default shutdown grace is now 15s, preserving a full 5s drain round trip and a finite suspension reserve. Explicit caller deadlines, other provider defaults, literal drain receipts and exact suspension identity checks remain unchanged. The timing regression fails before this correction and passes afterward; all 18 focused settlement tests and Runner typecheck pass. The final-source file attempt is also preserved as failed (`candidate_failure`), archive SHA-256 `db6767b6773ea618997927ac77bdb005a5ac81492c7b9c0ffbc900449f829bc9`. Native edit, validation, exact downloadable artifact and Done/succeeded all passed, and the exact final reply was durably recorded. A workspace recovery owner completed before the live heartbeat reached presentation, leaving that reply absent from task chat. Recovery now materializes only a completed final reply from the accepted turn of an ordinary internal Done task, preserving issue/run/contract binding, suppression, external-chat authorization and same-run deduplication. The database regression covers the generated file-preparation receipt, suppression, unapproved external continuation and replay. Server typecheck and all 49 response-selection tests pass; hosted Linux verifies the database regression because embedded PostgreSQL cannot start on this Mac. The delayed-final-answer database regression passes on [the final root-source Linux server shard](https://github.com/paperclipai/paperclip/actions/runs/37868262553/job/113628594152), alongside 1,108 passing tests. The first root Runner shard had one unchanged durable-resume test exceed its 5-second timeout; the identical top-source shard and the isolated exact test passed. One rerun of that failed job and its required aggregate passed without source or test changes. The original failed job log and the single-rerun receipt remain retained. ### October 9 merge verification Current merge head: `18744bf27490d6f064f9d5bac2c2af202c590a99`. All current-head checks pass, including `ci / verify` and `ci / e2e`; exact-head Greptile review is 5/5 with no unresolved threads. Current master conflicts are resolved. The user authorized the maintainer override of the code-owner review gate after these checks. The seven retained live core cases remain bound to source `3241a992f2a7703e59e97ed0fd3e5d6405de4401` and its recorded cloud image. ## Risks - The security correction changes the dependency closure and profile identity. Old sessions must reopen on the new profile. Exact identities and credential bindings fail closed. - The runner remains experimental and requires explicit selection. Legacy Pi Local is unchanged. Caller model IDs pass through; the E2E model is a fixture. - Accounting and the broad platform/provider matrix remain deferred. This merge does not publish a release or deploy a service. ## Model Used OpenAI GPT-6 through Codex assisted with reasoning, repository inspection, editing and tool use. The exact serving ID and context window are not exposed in this session. Final live qualification uses Pi 1.0.0 with `openrouter/anthropic/claude-sonnet-4.6` and native-confirmed low thinking. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --- doc/architecture/runner-pi-capabilities.md | 108 +++++++++++++++++- .../runner-rich-acp-capabilities.md | 65 ++++++++++- packages/db/src/backup-lib.test.ts | 3 +- .../src/live/runnerd-codex-transport.test.ts | 4 +- 4 files changed, 173 insertions(+), 7 deletions(-) diff --git a/doc/architecture/runner-pi-capabilities.md b/doc/architecture/runner-pi-capabilities.md index 7876c5cba45..044fd4e195f 100644 --- a/doc/architecture/runner-pi-capabilities.md +++ b/doc/architecture/runner-pi-capabilities.md @@ -97,6 +97,76 @@ Pi's published CLI mode union is `text | json | rpc`; no native ACP mode is present in this release. The reviewed `pi-acp` wrapper remains necessary. +## Explicit Linux companion setup for a Mac controller + +A Mac controller needs independently verified Linux runner bytes for Daytona. +Its host Pi installation is not a Linux provider pack. The operator imports a +release companion once, before launching agents: + +```sh +paperclipai runtime import-remote /path/to/release/linux-x64 --sha256 MANIFEST_SHA256 +``` + +Obtain `MANIFEST_SHA256` from the trusted release channel, separately from the +copied directory. The directory contains `companion.json`, +`bin/paperclip-runnerd`, and the complete `provider-pack/`. Import verifies the +installed server's exact build commit, qualified Pi profile, Linux x64 ELF, +manifest digest, and every file, mode, directory and contained symbolic link. +External hardlinks, escaping links, extra or modified files, and unsafe modes +are rejected. This command performs no network requests or model calls and does +not run the Linux executable on the Mac. + +The destination is the private `remote-companions/linux-x64` directory beneath +the actual installed `@paperclipai/server` package. It must be writable by the +operator, outside the task workspace, and protected with the same host access +controls as the server installation. It is not an agent workspace or a remote +image's self-reported authority. An existing different or damaged installation +is never replaced automatically. Stop all runs before an operator removes or +upgrades that cache. Verification and copying use asynchronous 1 MiB chunks, +yield between chunks, and enforce the same full inventory and ten-minute bound. +Directory entries must retain owner read/write/search permissions so failed imports +can drain their owned cleanup. SIGINT/SIGTERM are deferred through owned filesystem +phases and drain cleanup; +an uncatchable kill or host failure leaves the import unadmitted until the +operator resolves its retained lock or incomplete directory. Do not move the +cache into a task workspace to work around permissions. + +Normal remote Pi resolves this authority without binary or pack environment +overrides. The controller re-verifies its complete inventory and uses the exact +Linux daemon identity. Existing remote verification compares image bytes against +that local authority; a mismatch takes the existing verified upload path. +Controller restart and warm-session recovery retain the original Runner artifact +identity checks. Cursor, Copilot and explicit operator overrides keep their +existing admission rules. + +For release maintainers, assemble the Linux daemon and default provider pack +for the **same final commit** as the public server/CLI packages. A reused daemon +requires complete native source/config/protocol input equality and retains its +original compiler/build provenance; the manifest does not claim recompilation. In a fresh +release directory place those outputs at `bin/paperclip-runnerd` and +`provider-pack/`, preserving the pack's relative links and modes. Then run the +source-owned manifest generator after building the matching server: + +```sh +node scripts/create-runner-remote-companion.mjs /path/to/release/linux-x64 FINAL_SOURCE_SHA +``` + +Publish the complete companion directory (or distribute it through the normal +trusted release channel) together with the printed manifest SHA256 and the +source/profile/platform provenance. The import command accepts an already +extracted directory, not an archive or URL. The release companion must remain +available with that release; a short-lived qualification artifact is not a +release distribution. No release publication is implied by the tests here. + +Build/publish the Daytona image from those same daemon/pack outputs and configure +its immutable OCI digest through the ordinary Daytona environment `image` field. +The image digest and companion manifest are output metadata, not new source +constants, so publication does not require another source commit. The final live +proof must use the installed public CLI, this import command, and ordinary image +configuration without E2E remote binary/provider-pack overrides. That installed +and paid proof remains pending. + + Historical v10 qualification checkpoint (2026-09-30): **Pi profile v10 remains unqualified.** The capped-key/login prerequisite remains blocked. Native USD is unknown. The optional private budget helper is not integrated; Cursor's account-cycle cap does not establish Pi's provider spending bound. V10 keeps the native wrapper and closures unchanged, binds the shared ACPX patch under a new digest, and rejects v9 sessions. Fresh exact-runtime admission and final controller verification remain pending. Historical v9 checkpoint (2026-09-30): **Pi profile v9 remains unqualified**. Current runtime source is `5b8e4454ef0bf12d0bb068c2e41d8c9df9356a1c`; controller/Product harness source is `40064d28522de25fea85c1297f35b41bb8a8897a`. Runtime builds for macOS ARM64/x64 and Linux x64 are complete. No paid profile-v9 pass is claimed. A credential with a verifiable spend limit is still needed for the remaining paid qualification. The optional transport-budget candidate is frozen on a separate branch and is not integrated or a live spending guarantee. See the [comparative capability report](runner-rich-acp-capabilities.md) for current qualification gates and the field audit. The dated observations below retain their original profile identities. @@ -209,8 +279,8 @@ addressed by v4. Version 2 hello completion and every failure remain retained. The wider local and Linux x64 Daytona matrix remains pending; this document does not promote the candidate to a qualified production runtime. -The runner pins `pi-acp@0.0.33` and -`@earendil-works/pi-coding-agent@0.84.2`. The candidate model is +At this historical pre-1.0 checkpoint, the runner pinned `pi-acp@0.0.33` and +`@earendil-works/pi-coding-agent@0.84.2`. The candidate model was `openrouter/deepseek/deepseek-v4-flash-0731`; only an explicitly bound OpenRouter credential may reach this profile. `patches/pi-acp@0.0.33.patch` repairs the ACP wrapper. `pi-runtime-extension.ts` supplies the runner-owned semantic bridge and @@ -985,3 +1055,37 @@ that ID unchanged into the shared MCP dedupe boundary. This is a further integration defect. The shared dedupe guard and canonical grader remain intact. Both runs lack terminal usage; measured billing is $0.002440082 and cleanup passes. Restart and refreshed hello are held until this defect is repaired. + +## Explicit host installation + +For a published local Paperclip installation, run `paperclipai runtime setup pi` +with the same installed CLI and account that owns the server package. This is an +explicit download and verification step; npm installation and agent launch never +perform it automatically. It installs only this host's supported platform +(macOS ARM64, macOS x64, or Linux x64), using the source-pinned Node archive, npm +lock, wrapper patch and complete Pi closure. Node 24, npm, git, tar and the normal +platform dependency inspector (`otool` or `ldd`) must be available. The server +package must be writable by the installing account. Explicit setup preserves +`HTTP_PROXY`, `HTTPS_PROXY`, `NO_PROXY`, their lowercase equivalents, +`SSL_CERT_FILE`, `SSL_CERT_DIR` and +`NODE_EXTRA_CA_CERTS` for public downloads, and enables Node's environment proxy +handling. The provisioner keeps the same closed allowlist. Instance settings, +provider credentials, user npm configuration, `HOME`, `NODE_OPTIONS` and +`NODE_PATH` are excluded; TLS certificate validation stays enabled. + +The public server carries a self-contained setup tool and small pinned inputs in +`dist/vendor/paperclip-runner/cli`; the installed host closure lives in that +server package's `provider-assets/pi/`. Setup validates an existing +closure again before accepting it. A corrupt existing installation is left +untouched and rejected; reinstall the same Paperclip release into a clean package +location and repeat setup. Concurrent setup is rejected. Cancellation drains the +current bounded download/build command before removing its private staging tree; +allow that cleanup to complete before trying again. + +Then select Pi with an explicit provider/model ID and bind its provider credential +through the normal agent environment configuration. Setup itself makes no model request. +A missing host closure produces explicit setup guidance. Daytona uses the +separately built and verified Linux provider pack in its runner image; running +local setup does not install or qualify a remote image. Published-tar local and +Daytona startup evidence must bind the final installation candidate, with no +candidate qualification flags, before a production-readiness claim. diff --git a/doc/architecture/runner-rich-acp-capabilities.md b/doc/architecture/runner-rich-acp-capabilities.md index c1334de585b..1232e16ceca 100644 --- a/doc/architecture/runner-rich-acp-capabilities.md +++ b/doc/architecture/runner-rich-acp-capabilities.md @@ -22,6 +22,67 @@ for the exact source/image evidence and merge status. All dated checkpoints below describe historical qualification attempts. Their failures and profile numbers are retained; they are not current release gates. +## Historical Pi 1.0 qualification checkpoint — October 2, 2026 + +Pi now uses `@earendil-works/pi-coding-agent@1.0.0`, `pi-acp@0.0.33`, +ACPX `0.13.1`, and profile **12**. Its exact model remains +`openrouter/deepseek/deepseek-v4-flash-0731`. Cursor v10 and Copilot v12 +remain gated while Pi qualification is completed. The held Pi admission branch +is preparation for testing normal installation; it is not production qualification. + +The first paid Pi 1.0 local hello on profile 11 failed: Pi's serialized RPC +message updates no longer carry the old SDK-shaped partial message. That failure +is retained, with $0.000142518 observed on the dedicated OpenRouter key and +complete owned-process cleanup. Profile 12 repairs the actual RPC boundary; +its local-only tests exercise the real Pi CLI, wrapper and owned extension. +They do not replace authenticated product tests. + +At runtime source `b9e5d6ecdb05ab7244c90976e07c950f8d09b15b`, the fresh +macOS ARM64 daemon and verified pack pass the original no-key startup test +(6.741 seconds to settlement) and all 48 native/ACP contract tests without skips. +The original evidence collector rejected Node 24's summary format after the +runtime checks had passed. Its failure is preserved; independently reviewed +offline finalization verifies those same logs and full asset inventories without +rerunning the tests. The fresh native Intel build also passed all 48 contract +tests, but its canonical startup failed at the unchanged 30-second deadline +(35.032 seconds to settlement). A later instrumented run passed at 22.959 seconds; +it used a read-verified, warmed filesystem state and does not erase the original +failure. A four-run I/O-pool comparison was inconclusive, so no production +thread-pool change was adopted. Intel startup and the final installed-package +local/Daytona tests remain separate gates. + +Testing the actual public package installation exposed a packaging defect: +ambient npm 10 pruned 84 files from the pinned Pi dependency closure. Setup now +uses npm 11.19.0 bundled in the independently verified Node archive. The repaired +provisioner reproduces the original profile-12 closure with ambient npm disabled; +fresh public-package installation proof remains required. + +Normal Daytona setup now has an explicit operator command to import a verified +Linux companion into the installed server. It binds the trusted manifest to the +installed source, Pi profile, daemon and complete provider-pack inventory, then +uses the ordinary remote execution path without test-only binary or pack +overrides. Its 31 focused tests cover asynchronous bounded verification, +cancellation, existing-cache validation, contained paths and owned cleanup. +These tests do not establish live Daytona qualification or release publication. + +Full repository typecheck, tests, token gates, Product E2E typecheck/unit checks, +and build passed on the earlier source `efe019a79f50440d7bd6c3bc6c75fb8f18953093`. +Its Runner verification also passed. These results are historical prerequisites; +profile 12 and the final installation changes still need their own verification. + +The dedicated Pi test key has a $5 lifetime OpenRouter-credit limit. Its BYOK +charges are not included in that provider-enforced limit. Qualification therefore +also requires the reviewed operational policy verifying no configured BYOK +credentials, fresh account/key evidence, one paid case at a time, and usage +monitoring. The key's $5 reservation is counted once within the combined $100 +campaign budget. Native price estimates are never substituted for provider bills. + +The [Pi capability inventory](runner-pi-capabilities.md#historical-pi-10-candidate-2026-10-02-profile-v12) +records Pi 1.0's native interfaces, wrapper changes, and unused capabilities. +The comparison below remains the supported-surface map; older paid observations +retain their named historical profiles. Current Pi 1.0 paid Product, Runner +protocol, native controls, and Daytona qualification are still pending. + Historical source checkpoint (2026-10-01): **Cursor v10, Copilot v12 and Pi v10 remain unqualified**. Copilot receipt v2 distinguishes original provider arguments from the validated outgoing completion input. The sidecar commits @@ -73,7 +134,7 @@ as `25303cf84953985b961b95f89aff0bdb864b2d65`, from head unchanged; this adds no paid proof. Those definitions remain the historical Cursor v8 checkpoint and require a separate reviewed Cursor v9 update. -Current checkpoint (2026-09-30): **Cursor v9, Copilot v8 and Pi v10 remain unqualified.** The frozen runtime is `5c69b69ef2aeab8d8a367b25a8d894cc5308befa`; controller candidate is `a8df2064d68f40fbf4dec670c4b8478c4b1b1b3f`. All profiles bind shared ACPX patch SHA-256 `bd5393058a218040d217fa85449d59a6f30507de54cd645bf0ef21422823f85e`. No profile is promoted and no prior grade is changed. +Historical checkpoint (2026-09-30): **Cursor v9, Copilot v8 and Pi v10 remain unqualified.** The frozen runtime is `5c69b69ef2aeab8d8a367b25a8d894cc5308befa`; controller candidate is `a8df2064d68f40fbf4dec670c4b8478c4b1b1b3f`. All profiles bind shared ACPX patch SHA-256 `bd5393058a218040d217fa85449d59a6f30507de54cd645bf0ef21422823f85e`. No profile is promoted and no prior grade is changed. Current-profile protocol eval definitions merged in [paperclip-evals #36](https://github.com/paperclipai/paperclip-evals/pull/36) as `d987357461933baca0d4c10cc081f40e7eae5c1b`: 136 deterministic tests and 21 validated cells. These definitions do not supply paid qualification evidence. @@ -808,7 +869,7 @@ qualification gates, not claims that a JavaScript path check confines a shell. | P1 | User attachments and image prompting | `AcpxRuntimeTurnInput` and the common runtime adapter currently forward text only, despite underlying image-input support. Implement validated attachment-to-ACP content conversion and model-specific capability admission, then qualify real local/Daytona image prompts. This is an implementation gap as well as a live-verification gap. | | P1 | Copilot native session event attribution | `_session_event` omits an originating turn. Preserve bounded event fields as session-scoped notices with `turnAttribution: unknown`; typed delegation, artifacts and compaction need an explicit native correlation contract before turn-owned projection. Standard correlated ACP events remain separate. | | P1 | Copilot session-store files and export/artifact URIs | Provider paths are not task-workspace paths. Add a separately authorized export flow with validated bytes and provenance; do not resolve arbitrary URLs or auto-register. | -| P1 | Pi native fork/history/export interfaces | Pinned Pi 0.84.2 native RPC exposes `fork(entryId)`, `clone`, `get_fork_messages` and `export_html`. The wrapper does not map them to runner controls. Add durable branch lineage for fork/clone and an authorized, contained artifact flow for HTML export before exposing them; do not label these native capabilities absent. | +| P1 | Pi native fork/history/export interfaces | Pi native RPC exposes `fork(entryId)`, `clone`, `get_fork_messages` and `export_html`; these remain available in the pinned 1.0.0 release. The wrapper does not map them to runner controls. Add durable branch lineage for fork/clone and an authorized, contained artifact flow for HTML export before exposing them; do not label these native capabilities absent. | | P1 | Complete usage/billing provenance | Missing cache fields remain unknown. Pi price estimates are displayed separately. Budget qualification requires actual spend coverage, not an estimate presented as a bill. | | P1 | Fork/history and richer configuration controls | Cursor session mode now has explicit admission-bound setup. Arbitrary session discovery/forking, mid-turn configuration changes and the parameterized model picker still need company-scoped controls and durable lineage. | | P1 | Exact pending-request restoration after process death | Session transcript restoration does not restore callbacks. Expire unresolved requests unless a provider proves exact restoration. | diff --git a/packages/db/src/backup-lib.test.ts b/packages/db/src/backup-lib.test.ts index de3166714cc..c625208eacc 100644 --- a/packages/db/src/backup-lib.test.ts +++ b/packages/db/src/backup-lib.test.ts @@ -7,6 +7,7 @@ import postgres from "postgres"; import { createBufferedTextFileWriter, runDatabaseBackup, runDatabaseRestore } from "./backup-lib.js"; import { ensurePostgresDatabase } from "./client.js"; import { + EMBEDDED_POSTGRES_TEST_TIMEOUT_MS, getEmbeddedPostgresTestSupport, startEmbeddedPostgresTestDatabase, } from "./test-embedded-postgres.js"; @@ -105,7 +106,7 @@ describeEmbeddedPostgres("runDatabaseBackup", () => { if (previous === undefined) delete process.env.PAPERCLIP_PG_DUMP_PATH; else process.env.PAPERCLIP_PG_DUMP_PATH = previous; } - }); + }, EMBEDDED_POSTGRES_TEST_TIMEOUT_MS); it("preserves identity generation, sequence options and progress in JavaScript backups", async () => { const source = await createTempDatabase(); diff --git a/packages/paperclip-runner/src/live/runnerd-codex-transport.test.ts b/packages/paperclip-runner/src/live/runnerd-codex-transport.test.ts index 857109376d3..9f3a8b92cd3 100644 --- a/packages/paperclip-runner/src/live/runnerd-codex-transport.test.ts +++ b/packages/paperclip-runner/src/live/runnerd-codex-transport.test.ts @@ -6450,11 +6450,11 @@ it("rotates PRP authority in place for a warm cross-run attachment", async () => it("reopens Pi after a completed turn within its cold admission budget during warm attachment", async () => { const root = await mkdtemp(join(tmpdir(), "runnerd-pi-warm-admission-")); const cliRoot = join(root, "dist/cli"); - await mkdir(cliRoot, { recursive: true }); + await mkdir(cliRoot, { recursive: true, mode: 0o700 }); const sidecarPath = join(cliRoot, "acpx-runtime-sidecar.cjs"); const journal = join(root, "commands.ndjson"); const fixture = await readFile(fileURLToPath(new URL("./fixtures/fake-pi-warm-sidecar.cjs", import.meta.url)), "utf8"); - await writeFile(sidecarPath, fixture.replace("/* fixture-config */ null", JSON.stringify({ journal, resumeDelayMs: 32_000, commandDigest: QUALIFIED_ACPX_PROFILES.pi.commandDigest }))); + await writeFile(sidecarPath, fixture.replace("/* fixture-config */ null", JSON.stringify({ journal, resumeDelayMs: 32_000, commandDigest: QUALIFIED_ACPX_PROFILES.pi.commandDigest })), { mode: 0o600 }); const digest = (path: string) => `sha256:${createHash("sha256").update(readFileSync(path)).digest("hex")}`; const bundle = createCapabilityRunnerdCodexTransport({ provider: "acpx", acpxAgent: "pi", piThinkingLevel: "low", acpxPermissionMode: "deny-all", From e265f944432e53742619e0132afa79a66bd2a038 Mon Sep 17 00:00:00 2001 From: Dotta <34892728+cryppadotta@users.noreply.github.com> Date: Fri, 9 Oct 2026 10:34:07 -0500 Subject: [PATCH 2/4] docs: Pi reasoning and profile provenance (3/5) (#14923) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Thinking Path > - Paperclip manages AI agents and their work. > - The experimental Runner owns provider processes and durable sessions. > - Pi needs working task execution and human controls. > - The five-PR stack must preserve changes already on master. > - The runtime implementation has merged in #14921; this layer carries the next documentation changes. > - This PR belongs to native GitHub stack #15602, ending at #14956. ## Linked Issues or Issue Description Refs #14436, #14631, #14743 and #14956. Ship Pi 1.0 through the experimental Paperclip Runner. The five PRs are #14921, #14922, #14923, #14924 and #14956. The user authorized the complete merge after checks pass. Existing `pi_local` execution is unchanged. Accounting and wider provider/platform qualification remain deferred. ## What Changed - Document explicit Pi reasoning selection and native acknowledgement. - Preserve historical Pi and shared Copilot profile provenance and qualification outcomes. ## Verification - Full local `pnpm -r typecheck` passes, including Runner Rust, server and UI. Focused integration checks pass: 194 Runner admission/environment tests, 63 profile/credential tests with one expected skip, 152 Dot/UI configuration tests, and Pi transcript/notice tests. - Full local `pnpm build` passes on the final source. - Fresh final-source checks pass: all 698 Rust workspace tests (32 binaries), 156 credential/profile/controller tests with one expected skip, Runner TypeScript typecheck, and 20 package/setup/sandbox tests. - The profile-21 Pi materializer passes on the native host with the official pinned Node 24.21.0 and its npm. It verifies all 150 locked packages, the patched dependency and the exact closure. Setup/package bundle tests and UI token gates pass. - The old hashes were reproduced for all three supported targets before calculating the patched graph. New closure hashes are darwin-arm64 `282022db10150c6632b3444df421342e7d534bdf5d5fb1097a2e79d0625a2bcf`, darwin-x64 `64e251e19009f755c0b04f73ce2138246faab71a961b0f13d75ebfcc34bef12e`, and linux-x64 `713b1fdff42fb56a1518bdc084f181d70bee8ebadc3e4b1d76321ed9108c8410`. Independent native platform execution is separate from graph identity reproduction. - Historical cloud qualification remains unchanged: all seven core cases pass on shipping source `10dc43c9ec65d88c2f782d62afb296d09494f215`, harness `1a4408a48cfb5a1f094a311141c257c92cd7a893`, image `sha256:5b3a775b383591bda1b0c1889e509acc70ce7f37c53f09733c81d59037f02280`, and accepted Sonnet 4.6/low fixture. All 215 canonical files and all seven cleanup checks pass independent verification. These are profile-19 results and are not relabeled as fresh profile-22 runs. - Current Pi digest: `sha256:e92078bee3c23bec4100aa589013a44613d054cd686826534025d8019e9f39a9`. [The readiness plan](https://github.com/paperclipai/paperclip/blob/codex/pi-production-readiness/doc/plans/2026-10-02-pi-production-readiness.md) preserves campaign and failed-attempt provenance. - Merge only after every PR's current-head CI and fresh review pass. Linux CI covers the full suites, build and browser tests. The local embedded Postgres API-authority suite cannot start on this macOS/Node 26 host, so Linux CI must confirm that suite. ### Fresh profile-22 core qualification — 2026-10-08 All seven accepted core cases pass canonically on Pi profile 22, with `openrouter/anthropic/claude-sonnet-4.6` and native-confirmed low thinking. This model is a fixture; production accepts the caller's explicit Pi provider/model. Runtime/install source: `3241a992f2a7703e59e97ed0fd3e5d6405de4401`. Frozen accepted harness: `1a4408a48cfb5a1f094a311141c257c92cd7a893`. Immutable cloud image: `ghcr.io/paperclipai/paperclip-daytona-runner@sha256:506f22db7edd78f37c0c40bec1cc084af1850455026dbf467194bfbb8fcef141`. Pi digest: `sha256:e92078bee3c23bec4100aa589013a44613d054cd686826534025d8019e9f39a9`. [Hosted Linux image and clean-install verification](https://github.com/paperclipai/paperclip/actions/runs/37868328023) passes, including all 20 source-bound archives, normal CLI/Pi setup, companion import and the production pack reader. This exact installation source includes the latest master integration and the corrected Pi warm instruction-root fence. Full local typecheck/build and current-head hosted CI verify the final stack. All 13 focused real-root regressions pass. The full local executor suite passed 662 tests; 15 database tests could not start the Mac embedded PostgreSQL service. Hosted Linux CI passes the full required verification and E2E checks. These fresh results keep their own source identity; profile-19 results remain historical. | Core path | Canonical campaign | Retained archive SHA-256 | | --- | --- | --- | | File edit, validation, download and Done | `pi-core22-replyfix-0-1791511228` | 23 files; `a473e8603a3dd4737863291f8d3d1e392391f0b16d433c3e0e0e9d8baf7a97b0` | | Pending question and controller restart | `pi-core22-replyfix-1-1791511376` | 33 files; `6b829c4eb74e1f32a89c692a4ae7130dbfc1c6d3cf13915effe2103d9e242c8e` | | Three-turn session/process/workspace continuity | `pi-core22-replyfix-2-1791511587` | 23 files; `7a87021f8f9a3fdd3c58bb4467f8d82c635e3ea4795d6e75f144d9aa14818df8` | | Four typed questions and browser reconnects | `pi-core22-replyfix-3-1791511881` | 42 files; `9e31755252be1f4f9cb0626c984c142d4d1ae5f5bee3a7af08444db8d12c280a` | | Plan approval and completion | `pi-core22-replyfix-4-1791512031` | 22 files; `a0383ce1aab38e7b5a25ce0e9dd3bebea5c037ebd96ae6b29dae19015da2ae2c` | | Same-turn steering and permission denial | `pi-core22-replyfix-5-1791512261` | 39 files; `c929b8c7070f0b66aedc17e65ca46e6beab1e363926ac9f7e2a75fb250f05949` | | Stop during pending permission | `pi-core22-replyfix-6-1791512390` | 33 files; `7f0a58ae0f4d5bfc76149435f4e322537089c5bd16e7ffe9b5ad71f10a621a07` | All 215 canonical files (28714587 bytes) are independently hash-verified. All seven cleanup grades pass, with no owned runtime process or temporary root after each case. Automatic retries are zero. The owned cloud host stopped normally after retention. The prior profile-22 warm attempt remains failed and separately retained: archive SHA-256 `1e54eba5ec72b50cee1534b23d1d1d4f21a090006b8a64501ba70db972abfde5`. Its original canonical classification is preserved. Diagnosis reproduced a product bug comparing an agent-files root against an unset checkpoint-only field. The fix stores the admitted physical root separately from the adopted per-run collection capability. The real-root regression fails before the fix and passes afterward, including rejection of a changed physical root. Fixture, grader, model and all seven accepted case IDs are unchanged; this fresh campaign tests final-reply publication after file registration first. The intermediate restart attempt also remains failed and retained: archive SHA-256 `5dcaefdf1d17cf4cd54fd4cf810f45e736667392339b8ce7caf08bb4e225277f`. Its original canonical classification is preserved. Pi resumed, wrote the verified answer and completed its task; exact runner suspension was proven, but idle stop consumed about 5.2s and left under 3s for the drain acknowledgement. The Pi-only default shutdown grace is now 15s, preserving a full 5s drain round trip and a finite suspension reserve. Explicit caller deadlines, other provider defaults, literal drain receipts and exact suspension identity checks remain unchanged. The timing regression fails before this correction and passes afterward; all 18 focused settlement tests and Runner typecheck pass. The final-source file attempt is also preserved as failed (`candidate_failure`), archive SHA-256 `db6767b6773ea618997927ac77bdb005a5ac81492c7b9c0ffbc900449f829bc9`. Native edit, validation, exact downloadable artifact and Done/succeeded all passed, and the exact final reply was durably recorded. A workspace recovery owner completed before the live heartbeat reached presentation, leaving that reply absent from task chat. Recovery now materializes only a completed final reply from the accepted turn of an ordinary internal Done task, preserving issue/run/contract binding, suppression, external-chat authorization and same-run deduplication. The database regression covers the generated file-preparation receipt, suppression, unapproved external continuation and replay. Server typecheck and all 49 response-selection tests pass; hosted Linux verifies the database regression because embedded PostgreSQL cannot start on this Mac. The delayed-final-answer database regression passes on [the final root-source Linux server shard](https://github.com/paperclipai/paperclip/actions/runs/37868262553/job/113628594152), alongside 1,108 passing tests. The first root Runner shard had one unchanged durable-resume test exceed its 5-second timeout; the identical top-source shard and the isolated exact test passed. One rerun of that failed job and its required aggregate passed without source or test changes. The original failed job log and the single-rerun receipt remain retained. ### October 9 merge verification Current merge head: `1b4d7acf38fb8a7ded0d5efe76ef1f2d744e6ea0`. All current-head checks pass, including `ci / verify` and `ci / e2e`; exact-head Greptile review is 5/5 with no unresolved threads. Current master conflicts are resolved. The user authorized the maintainer override of the code-owner review gate after these checks. The seven retained live core cases remain bound to source `3241a992f2a7703e59e97ed0fd3e5d6405de4401` and its recorded cloud image. ## Risks - The security correction changes the dependency closure and profile identity. Old sessions must reopen on the new profile. Exact identities and credential bindings fail closed. - The runner remains experimental and requires explicit selection. Legacy Pi Local is unchanged. Caller model IDs pass through; the E2E model is a fixture. - Accounting and the broad platform/provider matrix remain deferred. This merge does not publish a release or deploy a service. ## Model Used OpenAI GPT-6 through Codex assisted with reasoning, repository inspection, editing and tool use. The exact serving ID and context window are not exposed in this session. Final live qualification uses Pi 1.0.0 with `openrouter/anthropic/claude-sonnet-4.6` and native-confirmed low thinking. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --- .../runner-copilot-capabilities.md | 12 +- doc/architecture/runner-pi-capabilities.md | 53 +++++++- .../runner-rich-acp-capabilities.md | 122 +++++++++++------- 3 files changed, 135 insertions(+), 52 deletions(-) diff --git a/doc/architecture/runner-copilot-capabilities.md b/doc/architecture/runner-copilot-capabilities.md index ceddfb1b7d8..f9d97b997aa 100644 --- a/doc/architecture/runner-copilot-capabilities.md +++ b/doc/architecture/runner-copilot-capabilities.md @@ -6,7 +6,17 @@ It binds master's shared protocol-validation sources without changing the executable or supplying new paid qualification. Historical checkpoints below retain their original identities and outcomes. -Historical source candidate (2026-10-01): **Copilot profile v12 is unqualified**. +Historical source candidate (2026-10-02): **Copilot profile v13 is unqualified**. +Pi's explicit reasoning-mode support changed four shared transport and schema +source files included in Copilot's execution identity. Version 13 records those +source hashes with digest +`sha256:3ff08fbe76fe4549c9eb01e8794428d8909c65c151d775220f2ec111d9e6f7c1`. +The Copilot executable closure, model and provider behavior are unchanged. The +historical v12 declaration is preserved; v12 warm sessions are rejected by the +current candidate. This identity update supplies no new paid qualification. +Fresh runtime packages and local/Daytona qualification remain required. + +Historical source candidate (2026-10-01): **Copilot profile v12 was unqualified**. Receipt v2 preserves the original `inputSha256` and separately captures `normalizedInputSha256` from the same invocation's validated outgoing body. For the native sidecar, only a successful, correlated `tool.resolve` commits diff --git a/doc/architecture/runner-pi-capabilities.md b/doc/architecture/runner-pi-capabilities.md index 044fd4e195f..a392c160338 100644 --- a/doc/architecture/runner-pi-capabilities.md +++ b/doc/architecture/runner-pi-capabilities.md @@ -22,7 +22,58 @@ for the exact source/image evidence and merge status. All dated checkpoints below describe historical qualification attempts. Their failures and profile numbers are retained; they are not current release gates. -## Historical Pi 1.0 candidate (2026-10-02, profile v12) +## Historical Pi 1.0 candidate (2026-10-02, profile v13) + +Pi remains pinned to **`@earendil-works/pi-coding-agent@1.0.0`**, with +`pi-acp@0.0.33`, ACPX `0.13.1`, and Node `24.21.0`. Profile 13 adds explicit +reasoning-mode selection and rejects previous profile identities. It is a new +qualification candidate; profile-12 results below remain historical evidence. + +Pi's new field also changes four shared files covered by Copilot's source +identity. Copilot therefore advances to a still-unqualified profile v13 without +changing its executable or model. Pi's profile-13 identity and native closure +remain unchanged. Final artifacts must bind the corrected source; the initial +ARM startup and 61 contract passes alone do not establish production readiness. + +The normal Pi configuration records `piThinkingLevel` as `off`, `low`, `high`, +or `max`. New configurations and qualification cases explicitly select `low`. +The runner binds that setting to the session identity and requires native +confirmation of the effective level before sending the prompt, including after +session restoration. An unsupported level, absent acknowledgement, or effective +level different from the requested value must fail admission. Changing the +level requires a new compatible session; a warm session cannot silently retain +its previous setting. + +The wrapper obtains available levels from Pi's native +`get_available_thinking_levels` RPC, exposes them through ACP session modes and +the `thought_level` configuration option, and confirms changes with native +`get_state`. This avoids advertising the static `minimal`, `medium`, or `xhigh` +aliases when the selected model does not support them. For the pinned DeepSeek +model, Pi 1.0 supports `off`, `low`, `high`, and `max`. Pi's implicit `medium` +default resolves to `high`; Pi 0.84.2 also resolved that default to `high`, so +this is a configuration gap rather than evidence of a new Pi 1.0 default. + +The [provider-free wire proof](../../packages/paperclip-runner/test-fixtures/pi-acp/thinking-modes.v13.darwin-arm64.json) +records actual Pi 1.0 request bodies changing from `high` to `low` through ACP, +truthful `max` restoration, blocked non-loopback connections, and owned-process +retirement. Synthetic responses establish propagation, not paid qualification. + +The paid profile-12 hello passed in the actual installed application. Its first +question continuation failed at the unchanged 120-second native deadline after +1,019 reasoning deltas and no emitted tool call or question. The required tool +was present with its exact schema. This establishes model activity without the +required interaction; it does not prove the reasoning setting caused the timeout. +The test remains failed. Profile-13 deterministic, local paid, Runner, native +control, and Daytona results must be established independently. + +| Capability | Native / ACP surface | Paperclip surface | Remaining boundary | +| --- | --- | --- | --- | +| Supported thinking levels | `get_available_thinking_levels`; ACP available session modes and `thought_level` choices | Pi reasoning-level configuration | Model selection is explicit and unrestricted; historical qualification used the recorded model and level. | +| Set and verify thinking level | Native `set_thinking_level`, then `get_state`; ACP `session/set_mode` / config option | Saved agent setting, typed runner input, effective-mode admission | Live setting changes during an active turn are not exposed; a new compatible session is required. | +| Recover selected level | Native restored state plus explicit effective-level verification | Mode-bound durable session identity | Old profiles and missing or mismatched mode identity cannot reuse a warm session. | +| Provider notice severity and pricing provenance | `paperclip/pi_notice` and canonical `provider.notice.recorded` | Retained run event and usage metadata | The activity row currently renders a generic provider-update label and warning icon even for informational pricing estimates. P2: render the safe summary and severity; do not imply an estimated price is a bill. | + +## Historical Pi 1.0 profile-v12 checkpoint (2026-10-02) The candidate now pins **`@earendil-works/pi-coding-agent@1.0.0`** with `pi-acp@0.0.33`, ACPX `0.13.1`, and portable Node `24.21.0`. Pi v11 and older diff --git a/doc/architecture/runner-rich-acp-capabilities.md b/doc/architecture/runner-rich-acp-capabilities.md index 1232e16ceca..c377bafc1ac 100644 --- a/doc/architecture/runner-rich-acp-capabilities.md +++ b/doc/architecture/runner-rich-acp-capabilities.md @@ -24,64 +24,86 @@ failures and profile numbers are retained; they are not current release gates. ## Historical Pi 1.0 qualification checkpoint — October 2, 2026 -Pi now uses `@earendil-works/pi-coding-agent@1.0.0`, `pi-acp@0.0.33`, -ACPX `0.13.1`, and profile **12**. Its exact model remains -`openrouter/deepseek/deepseek-v4-flash-0731`. Cursor v10 and Copilot v12 -remain gated while Pi qualification is completed. The held Pi admission branch -is preparation for testing normal installation; it is not production qualification. +Pi uses `@earendil-works/pi-coding-agent@1.0.0`, `pi-acp@0.0.33`, and ACPX +`0.13.1`. Profile **13** adds explicit, native-acknowledged reasoning selection +for the exact model `openrouter/deepseek/deepseek-v4-flash-0731`. New Pi +configuration and qualification cases select `low`. This candidate is not yet +production qualified. Cursor v10 and Copilot v13 remain gated. -The first paid Pi 1.0 local hello on profile 11 failed: Pi's serialized RPC -message updates no longer carry the old SDK-shaped partial message. That failure -is retained, with $0.000142518 observed on the dedicated OpenRouter key and -complete owned-process cleanup. Profile 12 repairs the actual RPC boundary; -its local-only tests exercise the real Pi CLI, wrapper and owned extension. -They do not replace authenticated product tests. +Copilot's declaration hashes the shared sidecar, sidecar protocol, direct driver, +and generated schema bundle. Pi's reasoning field changed those four files, so +Copilot's pending declaration advances to v13 with digest +`sha256:3ff08fbe76fe4549c9eb01e8794428d8909c65c151d775220f2ec111d9e6f7c1`. +Its executable, distribution closure, model, permissions, and qualification +status are unchanged. The v12 declaration remains historical, and v12 warm +sessions are rejected. This source-identity repair supplies no Copilot paid proof. -At runtime source `b9e5d6ecdb05ab7244c90976e07c950f8d09b15b`, the fresh -macOS ARM64 daemon and verified pack pass the original no-key startup test -(6.741 seconds to settlement) and all 48 native/ACP contract tests without skips. -The original evidence collector rejected Node 24's summary format after the -runtime checks had passed. Its failure is preserved; independently reviewed -offline finalization verifies those same logs and full asset inventories without -rerunning the tests. The fresh native Intel build also passed all 48 contract -tests, but its canonical startup failed at the unchanged 30-second deadline -(35.032 seconds to settlement). A later instrumented run passed at 22.959 seconds; -it used a read-verified, warmed filesystem state and does not erase the original -failure. A four-run I/O-pool comparison was inconclusive, so no production -thread-pool change was adopted. Intel startup and the final installed-package -local/Daytona tests remain separate gates. +The first profile-13 source (`f5c5fde38`) built a fresh ARM daemon and Pi pack, +then passed original startup and all 61 native/ACP contract tests without model +calls. Its full Runner suite found three missing-mode test fixtures and the +stale Copilot declaration. Those failures are retained. The corrected final +source still requires fresh platform builds, complete checks, and paid tests. -Testing the actual public package installation exposed a packaging defect: -ambient npm 10 pruned 84 files from the pinned Pi dependency closure. Setup now -uses npm 11.19.0 bundled in the independently verified Node archive. The repaired -provisioner reproduces the original profile-12 closure with ambient npm disabled; -fresh public-package installation proof remains required. +Profile 12 passed one paid local hello through the actual installed public +CLI/server and normal runtime setup. The next question-continuation case failed +at the unchanged 120-second native deadline: Pi emitted 1,019 reasoning deltas, +but no tool call or question. The tool and schema were present. One native turn +was submitted; the two visible start rows were canonical and mirrored activity, +not evidence of two provider requests. Both attempts completed owned-process, +IPC, temporary-root, installed-inventory, and post-run accounting checks. -Normal Daytona setup now has an explicit operator command to import a verified +The dedicated key recorded $0.000510742 for the hello and $0.004995065 for the +failed question. Including the earlier profile-11 failure ($0.000142518), its +observed total was $0.005648325 at that reconciliation. These are observed key +usage changes, not native per-request bills. No failed result has been regraded. + +Diagnosis found that the runner did not select the ACP reasoning mode. The +pinned model's implicit Pi `medium` setting resolves to `high`; this behavior +also existed in Pi 0.84.2. Pi 1.0 exposes a genuine `low` level. Profile 13 carries +an explicit setting through configuration, transport, and durable identity, +and requires the native effective level to match before a prompt is sent. +It does not increase the timeout. The timed-out HTTP body was not captured, +so source-derived default mapping does not establish the cause of that failure. +Fresh qualification must use the new profile and exact final build. + +Historical source `4c58da84fd86a0cd7bc1d952987b031786fc6b2b` passed full Runner +verification and normal Intel startup at 28.295 seconds under the original +30-second limit, plus all 48 native/ACP contract tests. The Intel result has +only 1.705 seconds of margin and does not establish broad cold-start reliability. +Its fresh Linux daemon, Pi pack, and image were built and inventoried; live +Daytona qualification remained pending. The public Mac installation reproduced +the complete Pi dependency closure using npm 11.19.0 from the verified Node +archive. None of these artifacts qualifies profile 13. + +The same source's full repository check failed six stale test assertions and +an `ETXTBSY` binary-staging error; the downstream Grok check then lacked built +server output. Typecheck, token gates, and Product E2E typecheck/unit checks +passed. The stale assertions have targeted repairs. A Linux process owner was +not captured for `ETXTBSY`; two exact native fixtures later passed on ARM with +all owned daemon handles closed, which does not resolve the Linux failure. +The next complete source run retains bounded executable-holder evidence around +check boundaries. A later run on obsolete harness source was canceled by the +lead and is retained as incomplete, not successful verification. + +Normal Daytona setup has an explicit operator command to import a verified Linux companion into the installed server. It binds the trusted manifest to the -installed source, Pi profile, daemon and complete provider-pack inventory, then -uses the ordinary remote execution path without test-only binary or pack -overrides. Its 31 focused tests cover asynchronous bounded verification, -cancellation, existing-cache validation, contained paths and owned cleanup. -These tests do not establish live Daytona qualification or release publication. - -Full repository typecheck, tests, token gates, Product E2E typecheck/unit checks, -and build passed on the earlier source `efe019a79f50440d7bd6c3bc6c75fb8f18953093`. -Its Runner verification also passed. These results are historical prerequisites; -profile 12 and the final installation changes still need their own verification. +installed source, Pi profile, daemon, and complete provider-pack inventory, then +uses ordinary remote execution without test-only binary or pack overrides. +The final installed import, image publication, and paid proof remain required. The dedicated Pi test key has a $5 lifetime OpenRouter-credit limit. Its BYOK -charges are not included in that provider-enforced limit. Qualification therefore -also requires the reviewed operational policy verifying no configured BYOK -credentials, fresh account/key evidence, one paid case at a time, and usage -monitoring. The key's $5 reservation is counted once within the combined $100 -campaign budget. Native price estimates are never substituted for provider bills. +charges are outside that provider-enforced limit, so qualification additionally +uses the reviewed no-BYOK operational policy, fresh account/key evidence, one +paid case at a time, and usage monitoring. The $5 reservation is counted once +within the combined $100 campaign budget. Native price estimates are never +substituted for provider bills. -The [Pi capability inventory](runner-pi-capabilities.md#historical-pi-10-candidate-2026-10-02-profile-v12) -records Pi 1.0's native interfaces, wrapper changes, and unused capabilities. -The comparison below remains the supported-surface map; older paid observations -retain their named historical profiles. Current Pi 1.0 paid Product, Runner -protocol, native controls, and Daytona qualification are still pending. +The [Pi capability inventory](runner-pi-capabilities.md#historical-pi-10-candidate-2026-10-02-profile-v13) +records native interfaces, ACP mappings, user surfaces, and explicit gaps. +The comparison below remains the supported-surface map; old observations retain +their exact historical profile identities. Final source checks and profile-13 +local Product, Runner protocol, native-control, and Daytona qualification remain +pending. Historical source checkpoint (2026-10-01): **Cursor v10, Copilot v12 and Pi v10 remain unqualified**. Copilot receipt v2 distinguishes original provider From ab8dcab80964e11f3d08420f36123f3122c12f4e Mon Sep 17 00:00:00 2001 From: Dotta <34892728+cryppadotta@users.noreply.github.com> Date: Fri, 9 Oct 2026 10:50:15 -0500 Subject: [PATCH 3/4] docs: Pi launch repairs and qualification history (4/5) (#14924) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Thinking Path > - Paperclip manages AI agents and their work. > - The experimental Runner owns provider processes and durable sessions. > - Pi needs working task execution and human controls. > - The five-PR stack must preserve changes already on master. > - The runtime implementation has merged in #14921; this layer carries the next documentation changes. > - This PR belongs to native GitHub stack #15602, ending at #14956. ## Linked Issues or Issue Description Refs #14436, #14631, #14743 and #14956. Ship Pi 1.0 through the experimental Paperclip Runner. The five PRs are #14921, #14922, #14923, #14924 and #14956. The user authorized the complete merge after checks pass. Existing `pi_local` execution is unchanged. Accounting and wider provider/platform qualification remain deferred. ## What Changed - Document Pi launch repairs and their original qualification checkpoints. - Preserve the comparative capability ledger and remaining optional coverage. ## Verification - Full local `pnpm -r typecheck` passes, including Runner Rust, server and UI. Focused integration checks pass: 194 Runner admission/environment tests, 63 profile/credential tests with one expected skip, 152 Dot/UI configuration tests, and Pi transcript/notice tests. - Full local `pnpm build` passes on the final source. - Fresh final-source checks pass: all 698 Rust workspace tests (32 binaries), 156 credential/profile/controller tests with one expected skip, Runner TypeScript typecheck, and 20 package/setup/sandbox tests. - The profile-21 Pi materializer passes on the native host with the official pinned Node 24.21.0 and its npm. It verifies all 150 locked packages, the patched dependency and the exact closure. Setup/package bundle tests and UI token gates pass. - The old hashes were reproduced for all three supported targets before calculating the patched graph. New closure hashes are darwin-arm64 `282022db10150c6632b3444df421342e7d534bdf5d5fb1097a2e79d0625a2bcf`, darwin-x64 `64e251e19009f755c0b04f73ce2138246faab71a961b0f13d75ebfcc34bef12e`, and linux-x64 `713b1fdff42fb56a1518bdc084f181d70bee8ebadc3e4b1d76321ed9108c8410`. Independent native platform execution is separate from graph identity reproduction. - Historical cloud qualification remains unchanged: all seven core cases pass on shipping source `10dc43c9ec65d88c2f782d62afb296d09494f215`, harness `1a4408a48cfb5a1f094a311141c257c92cd7a893`, image `sha256:5b3a775b383591bda1b0c1889e509acc70ce7f37c53f09733c81d59037f02280`, and accepted Sonnet 4.6/low fixture. All 215 canonical files and all seven cleanup checks pass independent verification. These are profile-19 results and are not relabeled as fresh profile-22 runs. - Current Pi digest: `sha256:e92078bee3c23bec4100aa589013a44613d054cd686826534025d8019e9f39a9`. [The readiness plan](https://github.com/paperclipai/paperclip/blob/codex/pi-production-readiness/doc/plans/2026-10-02-pi-production-readiness.md) preserves campaign and failed-attempt provenance. - Merge only after every PR's current-head CI and fresh review pass. Linux CI covers the full suites, build and browser tests. The local embedded Postgres API-authority suite cannot start on this macOS/Node 26 host, so Linux CI must confirm that suite. ### Fresh profile-22 core qualification — 2026-10-08 All seven accepted core cases pass canonically on Pi profile 22, with `openrouter/anthropic/claude-sonnet-4.6` and native-confirmed low thinking. This model is a fixture; production accepts the caller's explicit Pi provider/model. Runtime/install source: `3241a992f2a7703e59e97ed0fd3e5d6405de4401`. Frozen accepted harness: `1a4408a48cfb5a1f094a311141c257c92cd7a893`. Immutable cloud image: `ghcr.io/paperclipai/paperclip-daytona-runner@sha256:506f22db7edd78f37c0c40bec1cc084af1850455026dbf467194bfbb8fcef141`. Pi digest: `sha256:e92078bee3c23bec4100aa589013a44613d054cd686826534025d8019e9f39a9`. [Hosted Linux image and clean-install verification](https://github.com/paperclipai/paperclip/actions/runs/37868328023) passes, including all 20 source-bound archives, normal CLI/Pi setup, companion import and the production pack reader. This exact installation source includes the latest master integration and the corrected Pi warm instruction-root fence. Full local typecheck/build and current-head hosted CI verify the final stack. All 13 focused real-root regressions pass. The full local executor suite passed 662 tests; 15 database tests could not start the Mac embedded PostgreSQL service. Hosted Linux CI passes the full required verification and E2E checks. These fresh results keep their own source identity; profile-19 results remain historical. | Core path | Canonical campaign | Retained archive SHA-256 | | --- | --- | --- | | File edit, validation, download and Done | `pi-core22-replyfix-0-1791511228` | 23 files; `a473e8603a3dd4737863291f8d3d1e392391f0b16d433c3e0e0e9d8baf7a97b0` | | Pending question and controller restart | `pi-core22-replyfix-1-1791511376` | 33 files; `6b829c4eb74e1f32a89c692a4ae7130dbfc1c6d3cf13915effe2103d9e242c8e` | | Three-turn session/process/workspace continuity | `pi-core22-replyfix-2-1791511587` | 23 files; `7a87021f8f9a3fdd3c58bb4467f8d82c635e3ea4795d6e75f144d9aa14818df8` | | Four typed questions and browser reconnects | `pi-core22-replyfix-3-1791511881` | 42 files; `9e31755252be1f4f9cb0626c984c142d4d1ae5f5bee3a7af08444db8d12c280a` | | Plan approval and completion | `pi-core22-replyfix-4-1791512031` | 22 files; `a0383ce1aab38e7b5a25ce0e9dd3bebea5c037ebd96ae6b29dae19015da2ae2c` | | Same-turn steering and permission denial | `pi-core22-replyfix-5-1791512261` | 39 files; `c929b8c7070f0b66aedc17e65ca46e6beab1e363926ac9f7e2a75fb250f05949` | | Stop during pending permission | `pi-core22-replyfix-6-1791512390` | 33 files; `7f0a58ae0f4d5bfc76149435f4e322537089c5bd16e7ffe9b5ad71f10a621a07` | All 215 canonical files (28714587 bytes) are independently hash-verified. All seven cleanup grades pass, with no owned runtime process or temporary root after each case. Automatic retries are zero. The owned cloud host stopped normally after retention. The prior profile-22 warm attempt remains failed and separately retained: archive SHA-256 `1e54eba5ec72b50cee1534b23d1d1d4f21a090006b8a64501ba70db972abfde5`. Its original canonical classification is preserved. Diagnosis reproduced a product bug comparing an agent-files root against an unset checkpoint-only field. The fix stores the admitted physical root separately from the adopted per-run collection capability. The real-root regression fails before the fix and passes afterward, including rejection of a changed physical root. Fixture, grader, model and all seven accepted case IDs are unchanged; this fresh campaign tests final-reply publication after file registration first. The intermediate restart attempt also remains failed and retained: archive SHA-256 `5dcaefdf1d17cf4cd54fd4cf810f45e736667392339b8ce7caf08bb4e225277f`. Its original canonical classification is preserved. Pi resumed, wrote the verified answer and completed its task; exact runner suspension was proven, but idle stop consumed about 5.2s and left under 3s for the drain acknowledgement. The Pi-only default shutdown grace is now 15s, preserving a full 5s drain round trip and a finite suspension reserve. Explicit caller deadlines, other provider defaults, literal drain receipts and exact suspension identity checks remain unchanged. The timing regression fails before this correction and passes afterward; all 18 focused settlement tests and Runner typecheck pass. The final-source file attempt is also preserved as failed (`candidate_failure`), archive SHA-256 `db6767b6773ea618997927ac77bdb005a5ac81492c7b9c0ffbc900449f829bc9`. Native edit, validation, exact downloadable artifact and Done/succeeded all passed, and the exact final reply was durably recorded. A workspace recovery owner completed before the live heartbeat reached presentation, leaving that reply absent from task chat. Recovery now materializes only a completed final reply from the accepted turn of an ordinary internal Done task, preserving issue/run/contract binding, suppression, external-chat authorization and same-run deduplication. The database regression covers the generated file-preparation receipt, suppression, unapproved external continuation and replay. Server typecheck and all 49 response-selection tests pass; hosted Linux verifies the database regression because embedded PostgreSQL cannot start on this Mac. The delayed-final-answer database regression passes on [the final root-source Linux server shard](https://github.com/paperclipai/paperclip/actions/runs/37868262553/job/113628594152), alongside 1,108 passing tests. The first root Runner shard had one unchanged durable-resume test exceed its 5-second timeout; the identical top-source shard and the isolated exact test passed. One rerun of that failed job and its required aggregate passed without source or test changes. The original failed job log and the single-rerun receipt remain retained. ### October 9 merge verification Current merge head: `da68c3130a078905483821771fec7f9e27b439ac`. All current-head checks pass, including `ci / verify` and `ci / e2e`; exact-head Greptile review is 5/5 with no unresolved threads. Current master conflicts are resolved. The user authorized the maintainer override of the code-owner review gate after these checks. The seven retained live core cases remain bound to source `3241a992f2a7703e59e97ed0fd3e5d6405de4401` and its recorded cloud image. ## Risks - The security correction changes the dependency closure and profile identity. Old sessions must reopen on the new profile. Exact identities and credential bindings fail closed. - The runner remains experimental and requires explicit selection. Legacy Pi Local is unchanged. Caller model IDs pass through; the E2E model is a fixture. - Accounting and the broad platform/provider matrix remain deferred. This merge does not publish a release or deploy a service. ## Model Used OpenAI GPT-6 through Codex assisted with reasoning, repository inspection, editing and tool use. The exact serving ID and context window are not exposed in this session. Final live qualification uses Pi 1.0.0 with `openrouter/anthropic/claude-sonnet-4.6` and native-confirmed low thinking. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --- doc/architecture/runner-pi-capabilities.md | 36 ++++++++++++++++++- .../runner-rich-acp-capabilities.md | 29 ++++++++++----- 2 files changed, 55 insertions(+), 10 deletions(-) diff --git a/doc/architecture/runner-pi-capabilities.md b/doc/architecture/runner-pi-capabilities.md index a392c160338..0172c726fbc 100644 --- a/doc/architecture/runner-pi-capabilities.md +++ b/doc/architecture/runner-pi-capabilities.md @@ -71,7 +71,41 @@ control, and Daytona results must be established independently. | Supported thinking levels | `get_available_thinking_levels`; ACP available session modes and `thought_level` choices | Pi reasoning-level configuration | Model selection is explicit and unrestricted; historical qualification used the recorded model and level. | | Set and verify thinking level | Native `set_thinking_level`, then `get_state`; ACP `session/set_mode` / config option | Saved agent setting, typed runner input, effective-mode admission | Live setting changes during an active turn are not exposed; a new compatible session is required. | | Recover selected level | Native restored state plus explicit effective-level verification | Mode-bound durable session identity | Old profiles and missing or mismatched mode identity cannot reuse a warm session. | -| Provider notice severity and pricing provenance | `paperclip/pi_notice` and canonical `provider.notice.recorded` | Retained run event and usage metadata | The activity row currently renders a generic provider-update label and warning icon even for informational pricing estimates. P2: render the safe summary and severity; do not imply an estimated price is a bill. | +| Provider notice severity and pricing provenance | `paperclip/pi_notice` and canonical `provider.notice.recorded` | Retained run event, usage metadata, and safe summary with severity in the activity row | Summary/severity rendering has deterministic coverage; paid visual verification of the rebuilt UI remains pending. Pricing estimates remain distinct from provider billing receipts. | + +## Historical profile-13 qualification checkpoint (2026-10-02) + +The installed candidate from source `eac50643213d0902a93a5384bae2f1d6c065c9f2` +uses Pi 1.0.0, the explicit OpenRouter DeepSeek model above, and verified `low` +reasoning. Paid local Product E2E passes cover hello, semantic question/answer +continuation, all four native question forms, and human permission denial with +no file side effect. The paid extended Runner `get-task-context` case also +passes through the packaged runner against its authenticated, seeded test +control plane. Runner protocol evidence does not qualify the Product UI. + +Three local attempts remain failed: file-edit validation, pending-input +controller restart, and three-turn warm continuation. The first two exposed +assertion gaps: streamed command output supplies the exit receipt, and a +pre-start submission may precede assignment of the native turn ID. Narrow +fixture repairs have positive and negative coverage; neither failed attempt +has been regraded and both require fresh live runs. + +The warm attempt completed its first turn and edited files on its second, but +its final semantic tool stayed pending until the existing deadline. OpenRouter +metadata joins the exact native session and records the final response as +cancelled with no finish reason. This supports an unfinished upstream response +at cancellation; it does not establish why the response stopped progressing. +A real pinned SDK/wrapper replay proves both restored-session completion with +the new agent home and completion contract, and safe cancellation when complete +tool JSON arrives without the provider's stream finish marker. The latter +executes no semantic mutation. No timeout or runtime policy was changed to make +that replay pass. + +Fresh builds must incorporate the subsequent launch, UI, and fixture fixes. +macOS Intel startup, the remaining local and Runner cases, Linux/Daytona, and +final source-wide checks remain qualification gates. The provider remains +unqualified until that evidence is complete. API-key usage observations cover +the capped qualification campaign; native pricing estimates are not bills. ## Historical Pi 1.0 profile-v12 checkpoint (2026-10-02) diff --git a/doc/architecture/runner-rich-acp-capabilities.md b/doc/architecture/runner-rich-acp-capabilities.md index c377bafc1ac..c1e6e612602 100644 --- a/doc/architecture/runner-rich-acp-capabilities.md +++ b/doc/architecture/runner-rich-acp-capabilities.md @@ -30,6 +30,17 @@ for the exact model `openrouter/deepseek/deepseek-v4-flash-0731`. New Pi configuration and qualification cases select `low`. This candidate is not yet production qualified. Cursor v10 and Copilot v13 remain gated. +The installed profile-13 candidate at `eac50643213d0902a93a5384bae2f1d6c065c9f2` +has paid local passes for hello, semantic question continuation, all four native +question forms, and human permission denial without a file side effect. Its +paid extended Runner `get-task-context` case passes against the authenticated +seeded test control plane. That protocol case does not qualify the Product UI. +File validation, pending-input controller restart, and three-turn warm +continuation remain failed and unregraded. Assertion repairs and an actual +SDK/wrapper replay now cover the identified boundaries; fresh live proof is +still required. See the [historical Pi checkpoint](runner-pi-capabilities.md#historical-profile-13-qualification-checkpoint-2026-10-02) +for the request-stream diagnosis and remaining platform gates. + Copilot's declaration hashes the shared sidecar, sidecar protocol, direct driver, and generated schema bundle. Pi's reasoning field changed those four files, so Copilot's pending declaration advances to v13 with digest @@ -766,22 +777,22 @@ deterministic evidence are mapped separately after the comparison. | Capability | Codex app-server benchmark | Cursor ACP candidate | Copilot ACP candidate | Pi ACP candidate | | --- | --- | --- | --- | --- | -| Exact model | Selected and reported model | Explicit ID required; exact echo, paid semantic protocol and five local semantic product cases passed | Explicit ID required; exact `gpt-5.6-luna` echo, paid semantic protocol and local completion/file/plan/restart passed | Exact `openrouter/deepseek/deepseek-v4-flash-0731`; model echo and v2/v3 paid Product completion/file/question cases passed; v5 native controls passed | +| Exact model | Selected and reported model | Explicit ID required; exact echo, paid semantic protocol and five local semantic product cases passed | Explicit ID required; exact `gpt-5.6-luna` echo, paid semantic protocol and local completion/file/plan/restart passed | Exact `openrouter/deepseek/deepseek-v4-flash-0731`, native-verified `low`; profile-13 paid hello, semantic continuation, native questions and human denial pass; file/restart/warm failures remain open | | Text and tools | Typed thread/turn/item events | Standard ACP updates; child activity kept separate | Standard ACP plus opt-in native session events | Wrapper text/tool updates and owned tool gates | -| Active steering | Dedicated `turn/steer` | Concurrent prompt replaces/cancels, so it is not steering | Concurrent prompt replaces/cancels, so it is not steering | Owned `pi/steer` requires handshake, exact active turn and acknowledgment; real active-turn probe passed | -| Queued follow-up | Product continuation controls | Controller can schedule a later prompt; native queue not established | Native pending-message activity exists; no qualified ACP queue responder | Owned `pi/follow_up`, separately named and ordered; real queued marker followed the steered current response | +| Active steering | Dedicated `turn/steer` | Concurrent prompt replaces/cancels, so it is not steering | Concurrent prompt replaces/cancels, so it is not steering | Owned `pi/steer` requires handshake, exact active turn and acknowledgment; historical probe passed, profile-13 paid proof pending | +| Queued follow-up | Product continuation controls | Controller can schedule a later prompt; native queue not established | Native pending-message activity exists; no qualified ACP queue responder | Owned `pi/follow_up`, separately named and ordered; historical marker-order proof, profile-13 paid proof pending | | Cancellation | Typed interrupt and process lifecycle | ACP cancel; paid command cleanup pending | ACP cancel; attached async native settlement passes offline. Explicit detached work is rejected before side effects; it is not supported background settlement | Native abort; wrapper waits for `agent_settled` and treats provider errors as failure | | Session continuity | Read/load/history/fork and durable identity | Session load/list observed; paid semantic warm continuation passed; native history replay unverified and fork absent in tested methods | Session load plus native history events; semantic pending-question controller recovery passed | Private Pi JSONL mapping/load; native RPC `fork`, `clone`, `get_fork_messages` are not mapped through this ACP wrapper; unresolved UI promises cannot survive provider death | | Questions | Typed input requests and response correlation | `cursor/ask_question`, option identity and multiple selection preserved | Native ask-user capability exists, but pinned ACP does not wire its responder; do not display a false answerable form | `select`, `confirm`, `input`, `editor` through typed form elicitation | | Permissions | Durable typed approvals | Standard ACP permission options; denied shell write had no observed side effects; separately labeled exact-correlation assessment | Standard ACP; real native reject_once prevented marker creation; session decision scope inspected | Native pre-tool gate; allow once, exact-operation session grant, deny; paths rechecked after wait | | Plans | Typed plan and collaboration mode | `cursor/create_plan` includes full plan and revision-bound accept/reject/cancel; todo activity separate | Native plan events displayed; native plan-decision callback not exposed in ACP | No native structured plan event; authenticated Paperclip planning tools available | -| Authenticated tools | Runner bridge and governed operations | ACP HTTP MCP binding; paid context/history reads passed | ACP HTTP MCP binding; paid context read passed | Owned extension registers exact bound MCP tools; four authenticated semantic reads succeeded in a paid partial run; no ambient servers | +| Authenticated tools | Runner bridge and governed operations | ACP HTTP MCP binding; paid context/history reads passed | ACP HTTP MCP binding; paid context read passed | Owned extension registers exact bound MCP tools; profile-13 paid Product completion/questions and seeded Runner context pass; no ambient servers | | Delegation | Typed agent roles and lifecycle | Opt-in subagent lifecycle, nested ownership and bounded child activity; never parent transcript flattening | Native session details retain agent/model fields with unknown originating turn; typed turn-owned delegation is not inferred | No built-in ACP delegation protocol; arbitrary extensions are excluded | | Files/diffs | Typed file changes and artifact references | Standard tool changes plus validated image references | Correlated ACP tool events remain available; native session file/workspace details are session notices, not attributed task file changes | Wrapper-retained read/write/edit diffs; common typed/UI projection remains partial; semantic artifact tools | | Images/artifacts | Typed references and registered work products | Existing contained files only, provenance, `registered:false` | Native session artifact details are bounded notices with no inferred turn ownership or automatic registration | Image/resource tool blocks preserved by wrapper; dedicated artifact channel absent | | Image/attachment input | Typed input conversion | ACP advertises images, but the runner turn converter currently forwards text only | ACP advertises images/embedded context, but the runner turn converter currently forwards text only | Native Pi/ACP image input exists, but the runner turn converter currently forwards text only | | Usage | Per-request receipt and model context | Pinned ACP omitted receipts on denied and successful turns; account UI confirms included usage separately | ACP/native tokens retained; account UI confirms included credits separately, without a per-run USD receipt | Assistant-message and compaction token receipts; dollar cost is a catalog pricing estimate, never authoritative billing | -| Config/model changes | Typed configurable controls | Agent/Plan/Ask setup is bound to native configuration acknowledgements and recovery; unsolicited mode drift fails admission. Rich parameterized model picker remains unused | Model/reasoning/mode options exist; runtime policy remains authoritative | Exact pinned candidate model; arbitrary slash commands/config/extensions disabled | +| Config/model changes | Typed configurable controls | Agent/Plan/Ask setup is bound to native configuration acknowledgements and recovery; unsolicited mode drift fails admission. Rich parameterized model picker remains unused | Model/reasoning/mode options exist; runtime policy remains authoritative | Exact model; native available levels and set/get-state confirmation map through ACP mode/config to typed `piThinkingLevel`, recovery identity and UI setup. Active-turn mode changes and arbitrary slash commands/extensions remain disabled | | Reconnect/restart | Durable controller replay and qualified provider restoration | Semantic pending question survived a real controller restart; exact native callback restoration remains unverified | Semantic pending question survived controller restart with the same interaction and provider session; native callback restoration remains unverified | Wrapper explicitly advertises live-process-only pending-input recovery | | Shared capability | User-visible surface | Inspectable implementation / deterministic evidence | @@ -846,7 +857,7 @@ configuration defaults to full auto; it never overrides read-only task policy. ## Distribution and isolation Cursor pins `2026.09.26-dd393fe`; Copilot pins `1.0.88`; Pi pins wrapper `0.0.33`, -runtime `1.0.0` (Pi profile v12), portable Node and its full npm lock. Native distribution hashes +runtime `1.0.0` (Pi profile v13), portable Node and its full npm lock. Native distribution hashes cover macOS ARM64, macOS x64 and Linux x64. Source-owned closure pins remain separate from profile declaration digests. Native admission reads held files, verifies every admitted byte, creates a private immutable snapshot and retains @@ -875,8 +886,8 @@ qualification gates, not claims that a JavaScript path check confines a shell. | Priority | Exposed but unused, partial, or unverified | Reason and next proof | | --- | --- | --- | -| P0 | Remaining paid product cases on local and Daytona | Current Cursor7/Copilot7/Pi9 require authenticated local and Daytona evidence on the exact current runtime. Historical Cursor4 passed hello/question/plan/restart but its latest file marker failed despite correct bytes. Copilot4 passed all five basic local journeys and Daytona hello. Pi7 passed native questions but continuation exposed the final-message bug repaired in8. The semaphore blocker is resolved and Cursor's approved on-demand cap is $25. Native interaction, denial, settlement, platform and complete cost/cleanup gates remain open; no old profile pass qualifies new bytes. | -| P0 | Pi fresh-profile Product verification | Historical v4 plan startup failed with unavailable Postgres semaphores. Historical v6 attempts exposed profile admission and verified-runtime startup faults, repaired without raising deadlines. Preserve every failed attempt and run unchanged canonical cases against the final build; do not remove unrelated IPC objects. | +| P0 | Remaining paid product cases on local and Daytona | Current Cursor10/Copilot13/Pi13 require authenticated local and Daytona evidence on the exact current runtime. The current Pi checkpoint above supersedes older profile coverage. Historical Cursor4 passed hello/question/plan/restart but its latest file marker failed despite correct bytes. Copilot4 passed all five basic local journeys and Daytona hello. Pi7 passed native questions but continuation exposed the final-message bug repaired in8. The semaphore blocker is resolved and Cursor's approved on-demand cap is $25. Native interaction, denial, settlement, platform and complete cost/cleanup gates remain open; no old profile pass qualifies new bytes. | +| P0 | Pi profile-13 Product and platform verification | Four paid local cases and one seeded Runner case pass. File validation, pending-input restart and warm continuation remain failed; assertion repairs do not regrade them. Finish the remaining local, Runner/native-control, Intel startup and Linux/Daytona cases on fresh final builds. Earlier semaphore and v6 startup faults remain historical evidence; never remove unrelated IPC objects. | | P0 | Copilot native ask-user and plan-decision callbacks | Pinned ACP does not install native responders. Prove no blocking request is exposed, or add a qualified responder/wrapper; never swallow the request. | | P0 | Broader Copilot denial and background settlement qualification | Pinned 1.0.88 and isolated 1.0.89 settle attached async commands, but deliberately detached work can finish after end_turn. The earlier paid detached success depended on that model waiting and is not general settlement evidence. Profiles v3/v4 reject explicit detached admission before effects; governed long-lived background work remains unsupported. Denial and process-death recovery pass offline; paid local/Daytona proof remains required. | | P0 | Cursor native question availability | Explicit Luna and Composer native-only Plan-mode probes admitted the selected model and trusted instructions but emitted no question callback. The vendor-patch reversal and actual MCP-context constructor proof identify no local native-tool removal. Effective native tool selection is beyond the remote AgentService boundary; seek upstream catalog/availability evidence. No further blind model grid or semantic-question substitution qualifies this feature. | @@ -899,7 +910,7 @@ qualification gates, not claims that a JavaScript path check confines a shell. | P2 | Remaining Copilot native diagnostic/config/account events | The provider inventory records every event and field, its projection or reason for omission. Preserve bounded useful context; avoid credentials, raw environment or unbounded blobs. | | P2 | Pi empty or whitespace-only submitted input/editor text | Canonical required text rejects blank responses; optional blank responses are omitted. Defaults can be empty and nonblank text preserves boundary whitespace. Add explicit empty-text semantics across TypeScript, Rust and UI before claiming complete native empty-answer parity. | | P2 | Pi native extension surfaces and unsupported slash commands | Arbitrary extensions/templates/themes may execute ambient code. Only reviewed runner-owned capabilities are admitted; structured native plan/goals are not fabricated. Native fork/clone/export are separate unmapped capabilities above. | -| P2 | Pi status/widget/title/editor and session/configuration notifications | `setStatus`, `setWidget`, `setTitle` and `set_editor_text` have no UI projection and are unused by the owned extension. Native session-name and thinking-level events also lack a dedicated projection. Add reviewed bounded notice schemas and governed configuration controls before exposing these fields; `notify` and interactive input already have separate bridges. | +| P2 | Pi status/widget/title/editor and session/configuration notifications | `setStatus`, `setWidget`, `setTitle` and `set_editor_text` have no UI projection and are unused by the owned extension. Native session-name and thinking-level notifications also lack a dedicated projection, although selected thinking level is now handled through ACP mode/config and native confirmation. Provider notice summary/severity has deterministic UI coverage, with rebuilt paid visual proof pending. Add bounded schemas for the remaining fields; `notify` and interactive input already have separate bridges. | | P2 | Pi invocation and history provenance metadata | The v4 wrapper retains `nativeToolCallId`, `modelIteration`, `historyMessageIndex` and `identityScope` in private ACP-wire metadata. Closed common tool and permission projections omit them from the UI. Normalized IDs still correlate live tool, MCP and permission events. Add bounded, redacted display-only provenance fields and parity tests before surfacing the native metadata. | | P2 | Conditional native-plan follow-up fields | Cursor's optional rejection-reason field also appears for accept/cancel. The current question renderer has no conditional fields; add conditional presentation without changing the revision-bound decision receipt. | | P2 | Cursor command exit code projection | The paid file case preserved native `exitCode: 0` inside output text, while the canonical command field remained null. Normalize a typed, correlated exit code without parsing arbitrary prose; current independent file assertions do not prove this field. | From 2dd9811e8be1dab59cccd86cdb25e8953b02fe07 Mon Sep 17 00:00:00 2001 From: Nicky Leach Date: Fri, 9 Oct 2026 09:05:12 -0700 Subject: [PATCH 4/4] Own agent hiring and termination in a lifecycle module (#15631) ## Thinking Path > - Paperclip manages AI agents and their work. > - Agent creation, approval, pause, and termination change whether an agent can work. > - These changes currently use separate service and database paths. > - Some agents need setup after their record exists and before their harness can run. > - This PR adds one module that owns those state changes and their transactions. > - The module records progress and retries incomplete work after a server restart. ## Linked Issues or Issue Description **Problem or motivation** A hire can become active before its execution environment is ready. Direct agent state writes also bypass one common lifecycle boundary. Termination does not have a durable step for resource cleanup. **Proposed solution** Use agent lifecycle commands for hiring, approval, pause, resume, and termination. Keep proposed hires pending until approval. Prepare each approved hire, test its saved harness configuration, and then permit work. Wait for required plugin work before completing a step. **Alternatives considered** A general database commit hook would expose transaction details to callers. A timer alone would delay each new hire. This module owns each command transaction and starts its worker after commit. A periodic scan recovers work after a process stops. **Roadmap alignment** This change adds the lifecycle boundary for the existing agent and plugin systems. It does not add a user interface or a provider implementation. It replaces the lifecycle delivery approach in #15391. Related proposals include #11475 and #13099; this change does not add their external executor protocols. ## What Changed - Add durable approval, preparation, verification, pause, resume, stop, and cleanup states. - Keep agent creation, lifecycle state, configuration writes, and agent record deletion behind `modules/agent-lifecycle`. Keep validation, credential rules, reads, onboarding, invitations, general approvals, and company data deletion in their services. - Commit a hire before the remaining onboarding or invitation work. Serialize requests with the existing dedicated database connection helper. Reuse the hire after a failed attempt. - Keep accepted work in the run queue during setup. Require execution and cleanup evidence before completing pause or termination. - Retain the original credential owner when approving migrated hires. - Start lifecycle work after each command commits. Use database leases and revision checks for retries and late results. - Add a generic required plugin method and capability. Store the required plugin IDs for each agent. Track host and plugin completion separately. - Keep harness verification and credential rules in services. Supply their results to lifecycle through explicit ports. Reject failed logins and incomplete probes. - Remove reverse imports from lifecycle adapters into services. Share record queries and validation below both layers. - Use one hire decision path for agent IDs and approval IDs. Resolve the approval and agent change in one transaction. Expose policy reconciliation on the command object. - Save configuration and verification invalidation through one module operation. Ordinary commands own their transaction. Restrict the shared transaction integration to its listed callers. Reject identity, company, accounting, timestamp, and unknown fields. - Require completed termination before deleting agent records. The company deletion service calls the module through a separate deletion interface. - Save an approved secret before applying its agent binding. A failed binding leaves the secret approved. A retry reuses it. - Remove old permission and metadata export files. Move hire configuration rules out of lifecycle persistence. - Report failed worker steps and scans with operation context and known error codes. Omit provider messages, stacks, and configuration values. Document ordinary application use and extension rules. - Recover expired native owners only after execution stops. Retry cleanup of failed retained leases. Wait for setup in the live smoke script. - Keep manual, budget, and company pause reasons separate. Guard execution status writes with the ready state. - Add a migration, boundary checks, regression tests, and a lifecycle guide. Keep the current UI. - Limit periodic policy checks to 100 eligible agents per minute. Continue from the last agent ID. Exclude pending hires and agents in termination or a final state. Keep explicit company and budget updates immediate. ## Verification - Latest head `ccc3c86b0` aligns the shared status update schema with the PATCH route. All 15 shared tests, 104 server route/OpenAPI tests, 2 CLI tests, and shared/server/CLI TypeScript checks pass. The Greptile comment is fixed. CI is running; no new Apex review was requested for this small fix. - Rebase `75708ac94` rebases onto master at `2eb5187e4`. The backup test uses the shared 90-second timeout from master; the older timeout commit was removed. The affected backup test passes. - Agent budget edits now pass the target agent ID through enforcement. All 50 affected tests, server TypeScript, and 11 boundary tests pass. Both configuration update paths have regression coverage. CI is running on the latest head. No new Apex review was requested for these small fixes. - Rebase `9b568666a` preserves the run-control extraction and delivery-work startup changes from master. All 559 affected tests, server TypeScript, and 11 boundary tests pass. CI and Apex review are running on the final head. - The policy scan fix passes 56 lifecycle and diagnostic tests, 24 policy and caller tests, and 11 boundary tests. A regression test checks the page limit, interval, excluded states, and cursor wraparound. - Rebase `fd4698750` passes all 611 tests in eight affected lifecycle, route, and heartbeat suites. Server TypeScript and all 11 module boundary tests pass. The company deletion rollback and concurrent hire tests are included. - Follow-up `00aac7646` fixes the failed decision deletion test and the public update schema. All 126 affected server tests, 8 shared tests, 2 CLI tests, and 11 boundary tests pass. Shared, server, CLI, and UI TypeScript checks pass. - Server TypeScript passes: `pnpm --filter @paperclipai/server exec tsc --noEmit`. - All 11 boundary tests pass: `node --test scripts/check-module-boundaries.test.mjs`. The repository boundary scan also passes. - All 68 lifecycle, failure diagnostic, and harness verification tests pass. Tests reject forbidden fields through the root command, combined transition command, and restricted transaction integration. They also check invalid fields returned by configuration preparation. - Failure tests cover host work, plugin work, claims, renewals, deferrals, and scans. Log tests check known error codes and exclusion of private error contents. - All 355 tests in 10 existing caller suites pass. These tests cover secret approval, pairing, pending hires, credentials, company import, built-in agents, managed agents, instructions, and skills. - The branch is rebased onto `origin/master` at `2eb5187e4`. The queue guards and cancellation lock fix use the extracted heartbeat queue. Agent cancellation uses the extracted run-control file. The source diff scan found no secrets or private URLs. - Earlier checks cover approval retries, rollback, late verification results, policy holds, deletion rollback, concurrent company deletion, and queue admission during setup. - Before the rebase, CI passed on `00aac7646` and Greptile Apex rated it 5/5 with no open comments. CI and a new Apex review are pending for the rebased commit. The branch has no merge conflicts. - The full local build and native Dot suite were not run. The host has no Cargo. No live provider test was run. ## Risks - Background policy recovery takes more than one minute when more than 100 agents are eligible. Explicit company and budget updates still reconcile immediately. - The restricted configuration integration keeps an agent reference and its dependent records in one transaction. It cannot change a budget or invoke a lifecycle transition. A periodic scan starts pending setup after that transaction commits. - Secret approval and binding use separate transactions. A failed binding can leave an approved secret with no agent binding. - New approved hires remain unavailable until setup and verification complete. Existing clients see `paused` during these steps. This PR does not change the UI. - Migration `0320_daily_onslaught.sql` maps existing statuses and pause reasons. It does not create external resources or claim that an existing harness passed verification. - Use a coordinated server update for this migration. Older server versions can write legacy status without the new lifecycle checks. - A failed onboarding or invitation request can leave a committed hire. A retry reuses that hire and completes the remaining records. - Deletion requires completed termination. Company deletion can require another request while cleanup is pending. - Required plugins must make repeated calls safe and reject older revisions. A disabled or removed required plugin blocks completion until it is restored. - A new hire can run a second harness test after the existing UI test. Some adapters can charge for this test. - No live provider test was run. Provider implementation and resource backfill remain separate work. ## Model Used OpenAI GPT-6 through Codex, with reasoning, code tools, and local test execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have described the issue in this PR with the feature request field labels - [x] I have not referenced internal or instance-local issues or links - [x] My branch name describes the change - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation - [x] I have considered and documented risks - [x] Targeted local tests pass - [x] All Paperclip CI gates are green on the new commit - [x] Greptile Apex is 5/5 with no open comments on the new commit - [x] I will address review comments before requesting merge --------- Co-authored-by: Paperclip --- cli/src/commands/worktree.ts | 3 +- doc/AGENT-LIFECYCLE.md | 264 +++ docs/built-in-agents.md | 2 +- .../claude-local/src/server/acp.auth.test.ts | 14 +- .../adapters/claude-local/src/server/acp.ts | 5 +- packages/db/package.json | 2 +- .../src/migrations/0320_daily_onslaught.sql | 16 + ...{0315_snapshot.json => 0320_snapshot.json} | 1416 ++++++++++++++++- packages/db/src/migrations/meta/_journal.json | 7 + packages/db/src/schema/agents.ts | 9 +- packages/plugins/sdk/src/define-plugin.ts | 3 + packages/plugins/sdk/src/index.ts | 2 + packages/plugins/sdk/src/protocol.ts | 3 + packages/plugins/sdk/src/worker-rpc-host.ts | 5 + packages/shared/src/constants.ts | 1 + packages/shared/src/index.ts | 4 + packages/shared/src/types/agent-lifecycle.ts | 31 + packages/shared/src/types/agent.ts | 4 + packages/shared/src/types/index.ts | 2 + packages/shared/src/types/plugin.ts | 2 + packages/shared/src/validators/agent.test.ts | 25 + packages/shared/src/validators/agent.ts | 5 +- packages/shared/src/validators/plugin.test.ts | 6 + packages/shared/src/validators/plugin.ts | 5 + scripts/check-agent-lifecycle-boundaries.mjs | 50 + .../check-agent-lifecycle-boundaries.test.mjs | 31 + scripts/check-module-boundaries.mjs | 27 +- scripts/check-module-boundaries.test.mjs | 55 + {packages/db/src => server/scripts}/seed.ts | 26 +- server/scripts/smoke-native-task-monitor.ts | 18 +- .../scripts/verify-agent-commentary-live.ts | 3 +- .../adapter-auth-signal-routes.test.ts | 6 + .../agent-adapter-validation-routes.test.ts | 7 + .../agent-commentary.integration.test.ts | 5 +- .../agent-cross-tenant-authz-routes.test.ts | 10 + .../agent-default-configure-grants.test.ts | 10 +- .../agent-device-login-routes.test.ts | 7 + .../agent-harness-verification.test.ts | 27 + .../agent-hire-ai-connections.test.ts | 10 +- server/src/__tests__/agent-identity.test.ts | 5 +- .../agent-instructions-routes.test.ts | 7 + .../__tests__/agent-live-run-routes.test.ts | 6 + .../agent-permissions-routes.test.ts | 91 +- .../agent-permissions-service.test.ts | 2 +- .../agent-persona-persistence.test.ts | 9 +- .../src/__tests__/agent-skills-routes.test.ts | 13 +- .../agent-test-environment-routes.test.ts | 11 +- .../agents-adapter-config-user-secret.test.ts | 6 + .../agents-claude-oauth-binding.test.ts | 84 +- .../agents-pending-approval-config.test.ts | 7 +- .../agents-service-secret-bindings.test.ts | 22 +- .../src/__tests__/approvals-service.test.ts | 12 +- .../src/__tests__/attention-service.test.ts | 7 +- server/src/__tests__/built-in-agents.test.ts | 83 +- .../__tests__/cleanup-removal-service.test.ts | 3 + .../src/__tests__/companies-service.test.ts | 34 +- .../src/__tests__/company-portability.test.ts | 7 + server/src/__tests__/decision-models.test.ts | 6 +- server/src/__tests__/dot-invitations.test.ts | 30 +- .../__tests__/dot-oauth-onboarding.test.ts | 49 +- .../src/__tests__/environment-runtime.test.ts | 17 + .../heartbeat-process-recovery.test.ts | 2 +- ...heartbeat-stale-queue-invalidation.test.ts | 20 + .../src/__tests__/invite-create-route.test.ts | 4 + .../src/__tests__/invite-join-grants.test.ts | 2 +- .../issue-thread-interactions-service.test.ts | 1 + .../__tests__/onboarding-seed-route.test.ts | 25 +- server/src/__tests__/openapi-routes.test.ts | 9 + server/src/__tests__/plugin-idle-rpc.test.ts | 12 + .../__tests__/plugin-managed-agents.test.ts | 9 +- server/src/__tests__/primary-agent.test.ts | 18 +- .../resource-lifecycle-events.test.ts | 63 +- .../__tests__/secret-proposals-routes.test.ts | 56 +- server/src/__tests__/status-cards.test.ts | 2 +- server/src/__tests__/summary-slots.test.ts | 2 +- server/src/app.ts | 6 + .../{services => lib}/agent-permissions.ts | 0 server/src/lib/agent-records.ts | 473 ++++++ server/src/lib/approval-records.ts | 68 + .../built-in-agent-metadata.ts | 0 server/src/lib/company-deletion.ts | 9 + server/src/middleware/error-handler.ts | 2 + server/src/modules/README.md | 33 +- .../active-run-watchdog/adapters/postgres.ts | 1 + .../__tests__/diagnostics.test.ts | 68 + .../__tests__/lifecycle.test.ts | 673 ++++++++ .../__tests__/policy-sweep.test.ts | 63 + .../agent-lifecycle/adapters/approvals.ts | 96 ++ .../adapters/company-deletion.ts | 19 + .../agent-lifecycle/adapters/configuration.ts | 32 + .../agent-lifecycle/adapters/deletion.ts | 27 + .../agent-lifecycle/adapters/effects.ts | 24 + .../agent-lifecycle/adapters/postgres.ts | 151 ++ .../agent-lifecycle/adapters/records.ts | 118 ++ .../agent-lifecycle/application/ports.ts | 41 + .../agent-lifecycle/application/worker.ts | 96 ++ .../agent-lifecycle/company-deletion.ts | 1 + .../modules/agent-lifecycle/configuration.ts | 1 + .../modules/agent-lifecycle/domain/policy.ts | 63 + server/src/modules/agent-lifecycle/index.ts | 144 ++ server/src/routes/access.ts | 4 +- server/src/routes/agents.ts | 613 +------ server/src/routes/ai-connections.ts | 37 +- server/src/routes/environment-selection.ts | 53 +- server/src/routes/openapi.ts | 11 +- server/src/services/activity-log.ts | 7 +- .../agent-configuration-transaction.ts | 12 + server/src/services/agent-configuration.ts | 150 ++ server/src/services/agent-credentials.ts | 197 +++ server/src/services/agent-deletion.ts | 41 + server/src/services/agent-environment-test.ts | 533 +++++++ server/src/services/agent-execution-stop.ts | 74 + .../services/agent-harness-verification.ts | 76 + server/src/services/agent-hiring.ts | 135 ++ .../services/agent-instruction-revisions.ts | 23 +- server/src/services/agent-lifecycle-driver.ts | 47 + server/src/services/agent-lifecycle.ts | 61 + server/src/services/agent-profile-avatar.ts | 4 +- server/src/services/agents.ts | 1250 +-------------- server/src/services/ai-api-key-test.ts | 38 + server/src/services/approvals.ts | 227 +-- server/src/services/authorization.ts | 2 +- server/src/services/budgets.ts | 41 +- server/src/services/built-in-agents.ts | 14 +- server/src/services/companies.ts | 122 +- server/src/services/company-deletion.ts | 110 ++ .../company-portability-agent-selection.ts | 2 +- server/src/services/company-portability.ts | 6 +- server/src/services/company-skills.ts | 23 +- server/src/services/connection-intents.ts | 3 +- server/src/services/dot-invitations.ts | 76 +- server/src/services/dot-runner-broker.ts | 22 +- server/src/services/environment-runtime.ts | 5 +- server/src/services/environment-selection.ts | 52 + .../execution-control-reconciliation.ts | 1 + server/src/services/heartbeat.ts | 35 +- server/src/services/heartbeat/queue.ts | 17 +- .../services/heartbeat/run-control.test.ts | 1 - server/src/services/heartbeat/run-control.ts | 61 +- server/src/services/invite-grants.ts | 2 +- server/src/services/onboarding-seed.ts | 191 +-- server/src/services/plugin-host-services.ts | 6 +- server/src/services/plugin-managed-agents.ts | 21 +- server/src/services/public-mcp/oauth.ts | 7 +- server/src/services/recovery/service.ts | 5 + server/src/services/secret-proposals.ts | 25 +- server/src/services/status-cards.ts | 2 +- server/src/services/summary-slots.ts | 2 +- server/src/types/activity-publication.ts | 7 + tests/e2e/acp-stop-continuation.spec.ts | 5 +- .../ai-personal-connection-recovery.spec.ts | 11 +- tests/e2e/legacy-failure-continuation.spec.ts | 5 +- 152 files changed, 6790 insertions(+), 2758 deletions(-) create mode 100644 doc/AGENT-LIFECYCLE.md create mode 100644 packages/db/src/migrations/0320_daily_onslaught.sql rename packages/db/src/migrations/meta/{0315_snapshot.json => 0320_snapshot.json} (97%) create mode 100644 packages/shared/src/types/agent-lifecycle.ts create mode 100644 packages/shared/src/validators/agent.test.ts create mode 100644 scripts/check-agent-lifecycle-boundaries.mjs create mode 100644 scripts/check-agent-lifecycle-boundaries.test.mjs rename {packages/db/src => server/scripts}/seed.ts (85%) create mode 100644 server/src/__tests__/agent-harness-verification.test.ts rename server/src/{services => lib}/agent-permissions.ts (100%) create mode 100644 server/src/lib/agent-records.ts create mode 100644 server/src/lib/approval-records.ts rename server/src/{services => lib}/built-in-agent-metadata.ts (100%) create mode 100644 server/src/lib/company-deletion.ts create mode 100644 server/src/modules/agent-lifecycle/__tests__/diagnostics.test.ts create mode 100644 server/src/modules/agent-lifecycle/__tests__/lifecycle.test.ts create mode 100644 server/src/modules/agent-lifecycle/__tests__/policy-sweep.test.ts create mode 100644 server/src/modules/agent-lifecycle/adapters/approvals.ts create mode 100644 server/src/modules/agent-lifecycle/adapters/company-deletion.ts create mode 100644 server/src/modules/agent-lifecycle/adapters/configuration.ts create mode 100644 server/src/modules/agent-lifecycle/adapters/deletion.ts create mode 100644 server/src/modules/agent-lifecycle/adapters/effects.ts create mode 100644 server/src/modules/agent-lifecycle/adapters/postgres.ts create mode 100644 server/src/modules/agent-lifecycle/adapters/records.ts create mode 100644 server/src/modules/agent-lifecycle/application/ports.ts create mode 100644 server/src/modules/agent-lifecycle/application/worker.ts create mode 100644 server/src/modules/agent-lifecycle/company-deletion.ts create mode 100644 server/src/modules/agent-lifecycle/configuration.ts create mode 100644 server/src/modules/agent-lifecycle/domain/policy.ts create mode 100644 server/src/modules/agent-lifecycle/index.ts create mode 100644 server/src/services/agent-configuration-transaction.ts create mode 100644 server/src/services/agent-configuration.ts create mode 100644 server/src/services/agent-credentials.ts create mode 100644 server/src/services/agent-deletion.ts create mode 100644 server/src/services/agent-environment-test.ts create mode 100644 server/src/services/agent-execution-stop.ts create mode 100644 server/src/services/agent-harness-verification.ts create mode 100644 server/src/services/agent-hiring.ts create mode 100644 server/src/services/agent-lifecycle-driver.ts create mode 100644 server/src/services/agent-lifecycle.ts create mode 100644 server/src/services/ai-api-key-test.ts create mode 100644 server/src/services/company-deletion.ts create mode 100644 server/src/services/environment-selection.ts create mode 100644 server/src/types/activity-publication.ts diff --git a/cli/src/commands/worktree.ts b/cli/src/commands/worktree.ts index 69f4c570e41..cae94dd6ba4 100644 --- a/cli/src/commands/worktree.ts +++ b/cli/src/commands/worktree.ts @@ -1308,10 +1308,11 @@ export async function quarantineSeededWorktreeExecutionState( .update(agents) .set({ runtimeConfig: normalized.runtimeConfig, - status: nextStatus, updatedAt: new Date(), }) .where(eq(agents.id, agent.id)); + if (nextStatus !== agent.status) await tx.update(agents).set({ status: "idle", updatedAt: new Date() }) + .where(and(eq(agents.id, agent.id), eq(agents.lifecycleState, "ready"))); } } diff --git a/doc/AGENT-LIFECYCLE.md b/doc/AGENT-LIFECYCLE.md new file mode 100644 index 00000000000..87033f8d56c --- /dev/null +++ b/doc/AGENT-LIFECYCLE.md @@ -0,0 +1,264 @@ +# Agent lifecycle + +The agent lifecycle module controls hiring, pause, resume, and termination. +Its public entry point is `server/src/modules/agent-lifecycle/index.ts`. +Use its commands to create an agent or change its lifecycle state. +Do not pass a database transaction to a command. +Each hire or transition command owns its transaction. + +## Application use + +Application code imports the configured factory from `services/agent-lifecycle.ts`. +This service supplies the module dependencies. Use the root database connection. +Apply the existing caller authorization checks before you call a command. + +```ts +import { createAgentLifecycle } from "../services/agent-lifecycle.js"; + +const lifecycle = createAgentLifecycle(db); +await lifecycle.updateConfiguration(agentId, { title: "Engineer" }); +await lifecycle.pauseAgent(agentId); +const state = await lifecycle.get(agentId); +``` + +The pause command records the request. The worker completes the external steps. +Read `lifecycleState` to check progress. +Configuration updates accept only the fields in `AGENT_CONFIGURATION_FIELDS`. +They reject identity, company, accounting totals, timestamp, and lifecycle fields. +The public update schema also rejects spend totals. Budget limit changes remain +permitted through `budgetMonthlyCents`. + +Do not import module adapters or construct module dependencies in a caller. +The company deletion service uses the separate deletion entry point. +The listed configuration workflows use the restricted transaction service. +These are the only transaction integrations. They are described below. + +## States + +| State | Meaning | Next state | +| --- | --- | --- | +| `pending_approval` | The hire needs board approval. | `preparing` or `rejected` | +| `preparing` | Required plugins prepare the agent. | `verifying` | +| `verifying` | The host tests the saved harness configuration. | `ready` | +| `ready` | The lifecycle permits work. | `pausing` or `terminating` | +| `pausing` | The host stops work. Required plugins stop their resources. | `paused` | +| `paused` | A pause hold prevents work. | `resuming` or `terminating` | +| `resuming` | Required plugins start their resources. | The state saved before pause | +| `terminating` | The host revokes keys and stops work. | `cleaning_up` | +| `cleaning_up` | Required plugins remove their resources. | `terminated` | +| `terminated` | Termination is complete. | None | +| `rejected` | The board rejected the hire. | None | + +Termination can start before preparation or verification completes. +An old result cannot complete a newer operation. +Deletion requires completed termination or a rejected hire. +The existing restrictions for built-in agents and accounting still apply. + +## Commands and transactions + +`requestHire` writes the agent record before preparation starts. +An approved hire starts preparation after the transaction commits. +A proposed hire waits for `approveHire`. +`approveHire` and `rejectHire` accept an agent ID or `{ approvalId }`. +Both forms use the same hire decision path. An agent ID also resolves its open +hire approval. The approval and the agent change commit together. +The existing company approval rules still apply. + +`pauseAgent`, `resumeAgent`, and `terminateAgent` record the requested change. +They do not wait for external resource operations. +`retry` makes a failed step available for another attempt. +`reconcilePolicyHolds` updates budget and company holds for the specified company. +The background policy check processes at most 100 eligible agents each minute. +It continues from the last agent ID and returns to the start after the last page. +Pending hires and agents in termination or a final state are excluded. +An explicit company or budget change still updates all affected agents immediately. +`updateAndTransition` applies a configuration change and a lifecycle command +in one transaction. A failed command does not save the configuration change. + +The onboarding and invitation services own their feature workflows. +They commit the hire through `requestHire` before they save the other records. +A separate database transaction holds only the workflow lock. +It prevents concurrent requests for the same workflow. +The hire command commits through its own connection and transaction. +A failure in the lock transaction cannot undo a committed hire. +If a later step fails, a retry uses the existing agent. +The onboarding revision is saved only after its content and audit record commit. + +The approval service owns comments, revisions, and general approval records. +The lifecycle module resolves a hire approval and changes the agent in one +transaction. It retains the original credential owner when it approves a hire. + +The company deletion service owns the company data cascade. +It requests agent termination before it starts that cascade. +It locks the company in the deletion transaction and removes dependent records. +It then calls `agentLifecycleCompanyDeletion.deleteCompanyData(tx, companyId)` +through the module's separate `company-deletion.ts` entry point. +This operation implements the shared `CompanyDeletionParticipant` interface. +It locks the agent rows, checks their states, and deletes them. +All agents must be terminated or rejected. Otherwise, it throws an error. +The error rolls back all database changes in the deletion transaction. +A concurrent hire makes deletion fail or waits until deletion ends. +The module's delete statement also restricts removal to terminated or rejected agents. +`purgeAgent` deletes a single agent. It owns the transaction and checks the agent +state before it calls the service to remove dependent records. +The service checks accounting holds. The module then deletes the agent record. +An error rolls back both operations. Neither path permits incomplete termination. + +The ordinary agent service owns reads, permissions, and keys. +The configuration service owns validation and configuration revisions. +The lifecycle module owns the agent configuration write. +Credential checks remain in the agent credential service. +Secret proposal approval saves the secret before it applies the agent binding. +If the binding fails, the secret remains approved and the binding remains pending. +A retry uses the approved secret. It does not create another secret. +The binding transaction checks authorization, expiry, and the current reporting +structure again before it changes the agent. +The hire service owns names, appearance, permissions, credential binding, +connection installs, identity setup, and primary-agent selection. +The module calls the hire service before and after the agent record write. +These operations use the lifecycle transaction. A failed operation rolls back +the hire and its dependent records. +The module owns the initial state, approval transition, and lifecycle events. +The service in `services/agent-lifecycle.ts` supplies these integrations to the +module. The module does not import services or routes. Shared record queries +and validation functions are in `lib/`. They do not call lifecycle commands. +The application supplies the worker driver at startup. +`updateConfiguration` owns the transaction for an ordinary configuration update. +The module locks the agent. The configuration service validates and prepares the +patch. The module saves it and invalidates an old verification result when +execution configuration changes during setup. The service then updates dependent +records and saves the configuration revision in the same transaction. +There is no separate invalidation operation for callers. +Configuration writes reject caller-supplied lifecycle fields. +For `updateAndTransition`, lifecycle owns the transaction and calls the +same configuration operation. Both changes commit together. + +Some workflows must save an agent reference and their own records together. +The module exposes `configuration.ts` for these transactions. Only +`services/agent-configuration-transaction.ts` can import it. +This service supplies the module integrations. It cannot save a configuration +without the module's invalidation check. +Its permitted callers are secret binding approval, Connection adoption, runner +pairing, avatar updates, instruction revisions, and skill reassignment. +The boundary check lists these callers. Ordinary callers use the root command. +Budget changes always use a root command so enforcement follows the commit. +The transaction integration cannot approve, pause, resume, or terminate an agent. +It does not start a worker before the caller commits. The periodic scan recovers +pending setup work after the commit. + +Manual, budget, and company pause holds are independent. +A manual resume does not remove a budget or company hold. +Restoring a company does not remove a manual hold. +Budget and company policy still prevent admission while the pause work runs. + +The legacy `status` field remains available to existing clients. +It shows `paused` during preparation, verification, pause, and resume. +It shows `terminated` as soon as termination starts. +Execution code can change this field only when the lifecycle is `ready`. +Use `lifecycleState` to distinguish the steps. +This change does not change the user interface. + +## Required plugin work + +A plugin can declare `agentLifecycle: true` in its manifest. +It must also request `agents.lifecycle.manage`. +The plugin implements `onAgentLifecycle` in the SDK. +This method is separate from event delivery and event acknowledgment. + +The host selects the required plugins before the first lifecycle step. +`setRequiredPlugins` stores their IDs on the agent. +The host is not a plugin ID. Each operation records host completion and +completed plugin IDs separately. The host step must finish before plugin calls. +A disabled or removed plugin cannot silently release an existing requirement. +Restore that plugin to complete the operation. +A later plugin installation does not change an existing selection. + +Each request contains these fields: + +- `companyId` and `agentId` identify the agent. +- `phase` identifies the lifecycle step. +- `operationId` identifies the operation. +- `version` identifies the state revision. + +Return the same `operationId` and `version` with `status: "complete"` or +`status: "pending"`. +Return `complete` only after the requested effect is complete. +Return `pending` while external work continues. +Throw an error when the step fails. +The host stores a fixed error message. It does not store the provider error text. +Server logs identify the failed step, phase, operation, and plugin when available. +They include only known error codes. Unknown codes become `unclassified`. +They do not include provider messages, stacks, or configuration values. +A failure before the agent is read can have only a step and agent ID. +A scan failure has no agent ID. + +Calls can repeat after a timeout or a server restart. +A plugin must make repeated calls safe. +It must retain the highest version for each company and agent. +It must reject an older request after it accepts a newer version. +It must also prevent an older operation from creating resources after cleanup. +Serialize external effects or remove resources from a late completion. +Do not treat a host timeout as cancellation of the external effect. + +## Verification and recovery + +The harness verification service uses the existing environment-test code. +It owns test configuration, credential selection, and test result checks. +It tests the saved agent configuration and the selected environment. +A failed login or an incomplete probe cannot complete verification. +The lifecycle module receives completion, pending work, or failure through its +driver. It owns the state transition and has no harness test rules. +The current UI can also run a test before the hire. +Some adapters can charge for these tests. +It uses the saved responsible user for managed credentials. +The host does not grant new credential access for this test. +A connection pool selects an account for a separate lifecycle test operation. +An external controller must complete its existing readiness test. + +Task requests can enter the durable run queue during preparation, verification, +and resume. Execution waits for readiness. Queue recovery does not require +periodic agent heartbeats to be enabled. + +A cancelled run record does not prove that execution stopped. +The host also checks process ownership, controller leases, and environment cleanup. +Required plugin cleanup cannot start while these checks are incomplete. + +The worker starts after a committed command. +A periodic scan recovers work after a process stops. +A database lease permits one active attempt for each agent. +The worker renews that lease during external calls. +Each result must match the current revision and lease owner. +Shutdown waits for active work. + +The agent API returns `lifecycleState`, `lifecycleVersion`, and `lifecycleError`. +A board user can retry through `POST /api/agents/:id/lifecycle/retry`. +The route applies the existing company access checks. + +## Existing installations + +Migration `0320_daily_onslaught.sql` maps the current status of each agent. +Active execution states become `ready`. +Paused, pending, and terminated agents retain their current meaning. +The migration retains each existing pause reason as a hold. +It does not provision external resources or record a successful harness test. +Resource backfill is a separate task. + +Run the normal database migration process before starting the new server. +Stop older server processes during the change. +An older process can write the legacy status without the new lifecycle checks. + +`pnpm check:module-boundaries` checks the module imports and agent writes. +Tests and migration fixtures can write records directly. +Production creation and lifecycle state writes must use the lifecycle module. +Production record deletion must also use the lifecycle module. +Execution configuration writes must use the module. The offline worktree seed +command can disable timers in a copied database before the server starts. + +## Extension rules + +Add a lifecycle command to the module entry point. Put state transition rules in +`domain/policy.ts`. Put database operations in the module adapters. +Keep harness and provider rules in services. Supply external work through the +worker driver. Report completion only after that work is complete. +Add a test for a failed or repeated operation. Run `pnpm check:module-boundaries` +to check the import and write boundaries. diff --git a/docs/built-in-agents.md b/docs/built-in-agents.md index 90acac315fa..2c563d12465 100644 --- a/docs/built-in-agents.md +++ b/docs/built-in-agents.md @@ -9,7 +9,7 @@ The first built-ins are `briefs` and `learning`. Operators can provision them fr The subsystem has four layers: - Registry: `server/src/services/built-in-agents.ts` defines the static `BuiltInAgentDefinition` list. -- Marker: `server/src/services/built-in-agent-metadata.ts` reads and writes `metadata.paperclipBuiltInAgent`. +- Marker: `server/src/lib/built-in-agent-metadata.ts` reads and writes `metadata.paperclipBuiltInAgent`. - Provisioning service: `builtInAgentService(db)` finds, creates, updates, resets, and requires built-ins per company. - Routes: `server/src/routes/built-in-agents.ts` exposes list, provision, and reset APIs. diff --git a/packages/adapters/claude-local/src/server/acp.auth.test.ts b/packages/adapters/claude-local/src/server/acp.auth.test.ts index 0e6b31f57b5..0d1c96cd56b 100644 --- a/packages/adapters/claude-local/src/server/acp.auth.test.ts +++ b/packages/adapters/claude-local/src/server/acp.auth.test.ts @@ -197,7 +197,7 @@ describe("probeClaudeAcpSandboxLogin", () => { // The parsed result is a success, so no login gate and no probe-unavailable // check appears. - expect(checks).toEqual([]); + expect(checks).toEqual([expect.objectContaining({ code: "claude_hello_probe_passed", level: "info" })]); }); it("keeps a non-auth failed probe with a token phrase on the probe-unavailable path", async () => { @@ -256,7 +256,7 @@ describe("probeClaudeAcpSandboxLogin", () => { expect(authRequired?.hint).toBe("Run `claude login` in this environment, then retry the probe."); }); - it("emits no checks when the sandbox probe reports a healthy login", async () => { + it("records a successful probe when the sandbox reports a healthy login", async () => { probeResult.value = { exitCode: 0, stdout: helloStdout, stderr: "", timedOut: false }; const checks = await probeClaudeAcpSandboxLogin({ @@ -264,7 +264,13 @@ describe("probeClaudeAcpSandboxLogin", () => { target: sandboxTarget, }); - expect(checks).toEqual([]); + expect(checks).toEqual([expect.objectContaining({ code: "claude_hello_probe_passed", level: "info" })]); + }); + + it("does not record success for an empty probe result", async () => { + probeResult.value = { exitCode: 0, stdout: "", stderr: "", timedOut: false }; + const checks = await probeClaudeAcpSandboxLogin({ config: { engine: "acp" }, target: sandboxTarget }); + expect(checks).toEqual([expect.objectContaining({ code: "claude_acp_login_probe_unavailable", level: "warn" })]); }); it("emits a distinct warn check, not a silent pass, when the probe cannot run", async () => { @@ -552,6 +558,8 @@ describe("Claude ACP hello probe on local and SSH targets", () => { expect(result.checks).toContainEqual(expect.objectContaining({ code: "claude_acp_anthropic_api_key_detected", level: "warn", })); + expect(result.status).toBe("warn"); + expect(result.checks).toContainEqual(expect.objectContaining({ code: "claude_hello_probe_passed", level: "info" })); // The host key value never enters a check. expect(JSON.stringify(result.checks)).not.toContain("sk-ant-host-key"); }); diff --git a/packages/adapters/claude-local/src/server/acp.ts b/packages/adapters/claude-local/src/server/acp.ts index 1ba468e42dc..1a800e2c3aa 100644 --- a/packages/adapters/claude-local/src/server/acp.ts +++ b/packages/adapters/claude-local/src/server/acp.ts @@ -721,7 +721,10 @@ export async function probeClaudeAcpSandboxLogin(input: { }); return [buildAcpLoginProbeUnavailableCheck("The Claude login probe did not complete.", targetIsSandbox)]; } - return []; + if (!/\bhello\b/i.test(parsedStream.summary)) { + return [buildAcpLoginProbeUnavailableCheck("The Claude login probe did not return hello.", targetIsSandbox)]; + } + return [{ code: "claude_hello_probe_passed", level: "info", message: "Claude login probe succeeded." }]; } export async function testClaudeAcpEnvironment( diff --git a/packages/db/package.json b/packages/db/package.json index b942944cb42..6e9ece4a394 100644 --- a/packages/db/package.json +++ b/packages/db/package.json @@ -45,7 +45,7 @@ "generate": "pnpm run check:migrations && pnpm run clean && tsc -p tsconfig.json && drizzle-kit generate && pnpm run prune:snapshots", "prune:snapshots": "ls src/migrations/meta/*_snapshot.json | sort -r | tail -n +6 | xargs rm -f", "migrate": "pnpm run check:migrations && tsx src/migrate.ts", - "seed": "tsx src/seed.ts" + "seed": "pnpm --filter @paperclipai/server exec tsx scripts/seed.ts" }, "dependencies": { "@paperclipai/shared": "workspace:*", diff --git a/packages/db/src/migrations/0320_daily_onslaught.sql b/packages/db/src/migrations/0320_daily_onslaught.sql new file mode 100644 index 00000000000..7e2fa9d8042 --- /dev/null +++ b/packages/db/src/migrations/0320_daily_onslaught.sql @@ -0,0 +1,16 @@ +ALTER TABLE "agents" ADD COLUMN "lifecycle_state" text DEFAULT 'ready' NOT NULL;--> statement-breakpoint +ALTER TABLE "agents" ADD COLUMN "lifecycle_required_plugin_ids" jsonb;--> statement-breakpoint +ALTER TABLE "agents" ADD COLUMN "lifecycle_holds" jsonb DEFAULT '[]'::jsonb NOT NULL;--> statement-breakpoint +ALTER TABLE "agents" ADD COLUMN "lifecycle_version" integer DEFAULT 0 NOT NULL;--> statement-breakpoint +ALTER TABLE "agents" ADD COLUMN "lifecycle_error" text;--> statement-breakpoint +ALTER TABLE "agents" ADD COLUMN "lifecycle_operation" jsonb;--> statement-breakpoint +CREATE INDEX "agents_lifecycle_work_idx" ON "agents" USING btree ("lifecycle_state","updated_at","id"); +--> statement-breakpoint +UPDATE "agents" SET + "lifecycle_state" = CASE "status" + WHEN 'pending_approval' THEN 'pending_approval' + WHEN 'paused' THEN 'paused' + WHEN 'terminated' THEN 'terminated' + ELSE 'ready' END, + "lifecycle_holds" = CASE WHEN "status" = 'paused' + THEN jsonb_build_array(coalesce("pause_reason", 'manual')) ELSE '[]'::jsonb END; diff --git a/packages/db/src/migrations/meta/0315_snapshot.json b/packages/db/src/migrations/meta/0320_snapshot.json similarity index 97% rename from packages/db/src/migrations/meta/0315_snapshot.json rename to packages/db/src/migrations/meta/0320_snapshot.json index 69131296242..4282ad6c084 100644 --- a/packages/db/src/migrations/meta/0315_snapshot.json +++ b/packages/db/src/migrations/meta/0320_snapshot.json @@ -1,6 +1,6 @@ { - "id": "26691ae0-39a8-42ac-868d-e36ab7219073", - "prevId": "a1aefefe-8911-4583-9c52-7c658e46e9b4", + "id": "d6277736-9c05-4304-8d16-52dc0d2fbaef", + "prevId": "af0b2d33-956b-4b12-8d68-8b4e14c991b2", "version": "7", "dialect": "postgresql", "tables": { @@ -408,13 +408,19 @@ "name": "run_id", "type": "uuid", "primaryKey": false, - "notNull": true + "notNull": false + }, + "decision_invocation_id": { + "name": "decision_invocation_id", + "type": "uuid", + "primaryKey": false, + "notNull": false }, "agent_id": { "name": "agent_id", "type": "uuid", "primaryKey": false, - "notNull": true + "notNull": false }, "project_id": { "name": "project_id", @@ -456,6 +462,27 @@ } }, "indexes": { + "budget_reservations_decision_idx": { + "name": "budget_reservations_decision_idx", + "columns": [ + { + "expression": "company_id", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "decision_invocation_id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": true, + "concurrently": false, + "method": "btree", + "with": {} + }, "budget_reservations_run_idx": { "name": "budget_reservations_run_idx", "columns": [ @@ -551,6 +578,10 @@ "uniqueConstraints": {}, "policies": {}, "checkConstraints": { + "budget_reservations_source_check": { + "name": "budget_reservations_source_check", + "value": "(\"budget_reservations\".\"run_id\" is not null)::int + (\"budget_reservations\".\"decision_invocation_id\" is not null)::int = 1" + }, "budget_reservations_state_check": { "name": "budget_reservations_state_check", "value": "\"budget_reservations\".\"state\" in ('held', 'settled', 'released')" @@ -3883,6 +3914,45 @@ "notNull": true, "default": "'idle'" }, + "lifecycle_state": { + "name": "lifecycle_state", + "type": "text", + "primaryKey": false, + "notNull": true, + "default": "'ready'" + }, + "lifecycle_required_plugin_ids": { + "name": "lifecycle_required_plugin_ids", + "type": "jsonb", + "primaryKey": false, + "notNull": false + }, + "lifecycle_holds": { + "name": "lifecycle_holds", + "type": "jsonb", + "primaryKey": false, + "notNull": true, + "default": "'[]'::jsonb" + }, + "lifecycle_version": { + "name": "lifecycle_version", + "type": "integer", + "primaryKey": false, + "notNull": true, + "default": 0 + }, + "lifecycle_error": { + "name": "lifecycle_error", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "lifecycle_operation": { + "name": "lifecycle_operation", + "type": "jsonb", + "primaryKey": false, + "notNull": false + }, "reports_to": { "name": "reports_to", "type": "uuid", @@ -3995,6 +4065,33 @@ } }, "indexes": { + "agents_lifecycle_work_idx": { + "name": "agents_lifecycle_work_idx", + "columns": [ + { + "expression": "lifecycle_state", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "updated_at", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": false, + "concurrently": false, + "method": "btree", + "with": {} + }, "agents_company_status_idx": { "name": "agents_company_status_idx", "columns": [ @@ -11745,6 +11842,139 @@ }, "isRLSEnabled": false }, + "public.chat_slack_registrations": { + "name": "chat_slack_registrations", + "schema": "", + "columns": { + "endpoint_id": { + "name": "endpoint_id", + "type": "uuid", + "primaryKey": true, + "notNull": true + }, + "company_id": { + "name": "company_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "request_id": { + "name": "request_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "status": { + "name": "status", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "manifest": { + "name": "manifest", + "type": "jsonb", + "primaryKey": false, + "notNull": true + }, + "manifest_hash": { + "name": "manifest_hash", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "callback_uri": { + "name": "callback_uri", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "app_id": { + "name": "app_id", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "client_id": { + "name": "client_id", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "secret_ids": { + "name": "secret_ids", + "type": "jsonb", + "primaryKey": false, + "notNull": true, + "default": "'{}'::jsonb" + }, + "workspace_id": { + "name": "workspace_id", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "bot_user_id": { + "name": "bot_user_id", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "error_code": { + "name": "error_code", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "created_by_user_id": { + "name": "created_by_user_id", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "created_at": { + "name": "created_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true, + "default": "now()" + }, + "updated_at": { + "name": "updated_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true, + "default": "now()" + } + }, + "indexes": {}, + "foreignKeys": { + "chat_slack_registrations_company_id_endpoint_id_chat_endpoints_company_id_id_fk": { + "name": "chat_slack_registrations_company_id_endpoint_id_chat_endpoints_company_id_id_fk", + "tableFrom": "chat_slack_registrations", + "tableTo": "chat_endpoints", + "columnsFrom": [ + "company_id", + "endpoint_id" + ], + "columnsTo": [ + "company_id", + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + } + }, + "compositePrimaryKeys": {}, + "uniqueConstraints": {}, + "policies": {}, + "checkConstraints": { + "chat_slack_registration_status_check": { + "name": "chat_slack_registration_status_check", + "value": "\"chat_slack_registrations\".\"status\" in ('creating', 'uncertain', 'failed', 'install', 'credentials_saved', 'configured', 'removed')" + } + }, + "isRLSEnabled": false + }, "public.chat_teams_file_transfers": { "name": "chat_teams_file_transfers", "schema": "", @@ -17284,7 +17514,20 @@ "name": "agent_id", "type": "uuid", "primaryKey": false, - "notNull": true + "notNull": false + }, + "usage_kind": { + "name": "usage_kind", + "type": "text", + "primaryKey": false, + "notNull": true, + "default": "'agent'" + }, + "responsible_user_id": { + "name": "responsible_user_id", + "type": "text", + "primaryKey": false, + "notNull": false }, "issue_id": { "name": "issue_id", @@ -17732,6 +17975,10 @@ "uniqueConstraints": {}, "policies": {}, "checkConstraints": { + "cost_events_usage_kind_check": { + "name": "cost_events_usage_kind_check", + "value": "\"cost_events\".\"usage_kind\" = 'decision' or (\"cost_events\".\"usage_kind\" = 'agent' and \"cost_events\".\"agent_id\" is not null)" + }, "cost_events_nonnegative_amounts": { "name": "cost_events_nonnegative_amounts", "value": "\"cost_events\".\"cost_cents\" >= 0 and \"cost_events\".\"input_tokens\" >= 0 and \"cost_events\".\"cached_input_tokens\" >= 0 and \"cost_events\".\"output_tokens\" >= 0" @@ -17739,6 +17986,346 @@ }, "isRLSEnabled": false }, + "public.company_decision_models": { + "name": "company_decision_models", + "schema": "", + "columns": { + "company_id": { + "name": "company_id", + "type": "uuid", + "primaryKey": true, + "notNull": true + }, + "connection_id": { + "name": "connection_id", + "type": "uuid", + "primaryKey": false, + "notNull": false + }, + "grant_id": { + "name": "grant_id", + "type": "uuid", + "primaryKey": false, + "notNull": false + }, + "enabled": { + "name": "enabled", + "type": "boolean", + "primaryKey": false, + "notNull": true, + "default": false + }, + "allow_background": { + "name": "allow_background", + "type": "boolean", + "primaryKey": false, + "notNull": true, + "default": true + }, + "provider": { + "name": "provider", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "model": { + "name": "model", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "updated_at": { + "name": "updated_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true, + "default": "now()" + } + }, + "indexes": {}, + "foreignKeys": { + "company_decision_models_company_id_companies_id_fk": { + "name": "company_decision_models_company_id_companies_id_fk", + "tableFrom": "company_decision_models", + "tableTo": "companies", + "columnsFrom": [ + "company_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + } + }, + "compositePrimaryKeys": {}, + "uniqueConstraints": {}, + "policies": {}, + "checkConstraints": { + "company_decisions_configured": { + "name": "company_decisions_configured", + "value": "(\"company_decision_models\".\"connection_id\" is null) = (\"company_decision_models\".\"grant_id\" is null) and (not \"company_decision_models\".\"enabled\" or (\"company_decision_models\".\"connection_id\" is not null and \"company_decision_models\".\"provider\" is not null and \"company_decision_models\".\"model\" is not null))" + } + }, + "isRLSEnabled": false + }, + "public.decision_invocations": { + "name": "decision_invocations", + "schema": "", + "columns": { + "id": { + "name": "id", + "type": "uuid", + "primaryKey": true, + "notNull": true, + "default": "gen_random_uuid()" + }, + "company_id": { + "name": "company_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "feature": { + "name": "feature", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "actor_type": { + "name": "actor_type", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "actor_id": { + "name": "actor_id", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "responsible_user_id": { + "name": "responsible_user_id", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "agent_id": { + "name": "agent_id", + "type": "uuid", + "primaryKey": false, + "notNull": false + }, + "issue_id": { + "name": "issue_id", + "type": "uuid", + "primaryKey": false, + "notNull": false + }, + "project_id": { + "name": "project_id", + "type": "uuid", + "primaryKey": false, + "notNull": false + }, + "run_id": { + "name": "run_id", + "type": "uuid", + "primaryKey": false, + "notNull": false + }, + "identity_context_id": { + "name": "identity_context_id", + "type": "uuid", + "primaryKey": false, + "notNull": false + }, + "connection_id": { + "name": "connection_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "grant_id": { + "name": "grant_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "provider": { + "name": "provider", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "model": { + "name": "model", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "question_types": { + "name": "question_types", + "type": "jsonb", + "primaryKey": false, + "notNull": true + }, + "status": { + "name": "status", + "type": "text", + "primaryKey": false, + "notNull": true, + "default": "'running'" + }, + "error_code": { + "name": "error_code", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "provider_request_id": { + "name": "provider_request_id", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "cost_event_id": { + "name": "cost_event_id", + "type": "uuid", + "primaryKey": false, + "notNull": false + }, + "started_at": { + "name": "started_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true, + "default": "now()" + }, + "finished_at": { + "name": "finished_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": false + }, + "duration_ms": { + "name": "duration_ms", + "type": "integer", + "primaryKey": false, + "notNull": false + }, + "input_tokens": { + "name": "input_tokens", + "type": "integer", + "primaryKey": false, + "notNull": false + }, + "output_tokens": { + "name": "output_tokens", + "type": "integer", + "primaryKey": false, + "notNull": false + } + }, + "indexes": { + "decision_invocations_company_started_idx": { + "name": "decision_invocations_company_started_idx", + "columns": [ + { + "expression": "company_id", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "started_at", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": false, + "concurrently": false, + "method": "btree", + "with": {} + }, + "decision_invocations_pending_idx": { + "name": "decision_invocations_pending_idx", + "columns": [ + { + "expression": "started_at", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": false, + "where": "\"decision_invocations\".\"status\" = 'running'", + "concurrently": false, + "method": "btree", + "with": {} + }, + "decision_invocations_cost_idx": { + "name": "decision_invocations_cost_idx", + "columns": [ + { + "expression": "cost_event_id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": false, + "concurrently": false, + "method": "btree", + "with": {} + } + }, + "foreignKeys": { + "decision_invocations_company_id_companies_id_fk": { + "name": "decision_invocations_company_id_companies_id_fk", + "tableFrom": "decision_invocations", + "tableTo": "companies", + "columnsFrom": [ + "company_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + }, + "decision_invocations_cost_event_id_cost_events_id_fk": { + "name": "decision_invocations_cost_event_id_cost_events_id_fk", + "tableFrom": "decision_invocations", + "tableTo": "cost_events", + "columnsFrom": [ + "cost_event_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "no action", + "onUpdate": "no action" + } + }, + "compositePrimaryKeys": {}, + "uniqueConstraints": {}, + "policies": {}, + "checkConstraints": { + "decision_invocations_status_check": { + "name": "decision_invocations_status_check", + "value": "\"decision_invocations\".\"status\" in ('running', 'succeeded', 'failed', 'unknown')" + } + }, + "isRLSEnabled": false + }, "public.decision_archive_notification_outbox": { "name": "decision_archive_notification_outbox", "schema": "", @@ -21614,6 +22201,746 @@ "checkConstraints": {}, "isRLSEnabled": false }, + "public.dot_agent_bindings": { + "name": "dot_agent_bindings", + "schema": "", + "columns": { + "id": { + "name": "id", + "type": "uuid", + "primaryKey": true, + "notNull": true, + "default": "gen_random_uuid()" + }, + "company_id": { + "name": "company_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "agent_id": { + "name": "agent_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "operator_id": { + "name": "operator_id", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "grant_id": { + "name": "grant_id", + "type": "uuid", + "primaryKey": false, + "notNull": false + }, + "generation": { + "name": "generation", + "type": "integer", + "primaryKey": false, + "notNull": true, + "default": 1 + }, + "status": { + "name": "status", + "type": "text", + "primaryKey": false, + "notNull": true, + "default": "'pairing'" + }, + "pairing_code_hash": { + "name": "pairing_code_hash", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "pairing_expires_at": { + "name": "pairing_expires_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": false + }, + "dot_url": { + "name": "dot_url", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "challenge_hash": { + "name": "challenge_hash", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "challenge_expires_at": { + "name": "challenge_expires_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": false + }, + "ready_at": { + "name": "ready_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": false + }, + "revoked_at": { + "name": "revoked_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": false + }, + "created_at": { + "name": "created_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true, + "default": "now()" + }, + "updated_at": { + "name": "updated_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true, + "default": "now()" + } + }, + "indexes": { + "dot_bindings_active_agent_uq": { + "name": "dot_bindings_active_agent_uq", + "columns": [ + { + "expression": "company_id", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "agent_id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": true, + "where": "\"dot_agent_bindings\".\"revoked_at\" IS NULL", + "concurrently": false, + "method": "btree", + "with": {} + }, + "dot_bindings_active_grant_uq": { + "name": "dot_bindings_active_grant_uq", + "columns": [ + { + "expression": "grant_id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": true, + "where": "\"dot_agent_bindings\".\"revoked_at\" IS NULL AND \"dot_agent_bindings\".\"grant_id\" IS NOT NULL", + "concurrently": false, + "method": "btree", + "with": {} + }, + "dot_bindings_pairing_code_uq": { + "name": "dot_bindings_pairing_code_uq", + "columns": [ + { + "expression": "pairing_code_hash", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": true, + "concurrently": false, + "method": "btree", + "with": {} + } + }, + "foreignKeys": { + "dot_agent_bindings_company_id_companies_id_fk": { + "name": "dot_agent_bindings_company_id_companies_id_fk", + "tableFrom": "dot_agent_bindings", + "tableTo": "companies", + "columnsFrom": [ + "company_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + }, + "dot_agent_bindings_agent_id_agents_id_fk": { + "name": "dot_agent_bindings_agent_id_agents_id_fk", + "tableFrom": "dot_agent_bindings", + "tableTo": "agents", + "columnsFrom": [ + "agent_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + }, + "dot_agent_bindings_grant_id_mcp_oauth_grants_id_fk": { + "name": "dot_agent_bindings_grant_id_mcp_oauth_grants_id_fk", + "tableFrom": "dot_agent_bindings", + "tableTo": "mcp_oauth_grants", + "columnsFrom": [ + "grant_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "set null", + "onUpdate": "no action" + } + }, + "compositePrimaryKeys": {}, + "uniqueConstraints": {}, + "policies": {}, + "checkConstraints": {}, + "isRLSEnabled": false + }, + "public.dot_mailbox_items": { + "name": "dot_mailbox_items", + "schema": "", + "columns": { + "id": { + "name": "id", + "type": "bigserial", + "primaryKey": true, + "notNull": true + }, + "company_id": { + "name": "company_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "binding_id": { + "name": "binding_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "binding_generation": { + "name": "binding_generation", + "type": "integer", + "primaryKey": false, + "notNull": true + }, + "assignment_id": { + "name": "assignment_id", + "type": "uuid", + "primaryKey": false, + "notNull": false + }, + "kind": { + "name": "kind", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "source_event_id": { + "name": "source_event_id", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "references": { + "name": "references", + "type": "jsonb", + "primaryKey": false, + "notNull": true + }, + "created_at": { + "name": "created_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true, + "default": "now()" + } + }, + "indexes": { + "dot_mailbox_event_uq": { + "name": "dot_mailbox_event_uq", + "columns": [ + { + "expression": "binding_id", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "binding_generation", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "source_event_id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": true, + "concurrently": false, + "method": "btree", + "with": {} + }, + "dot_mailbox_binding_cursor_idx": { + "name": "dot_mailbox_binding_cursor_idx", + "columns": [ + { + "expression": "binding_id", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "binding_generation", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": false, + "concurrently": false, + "method": "btree", + "with": {} + } + }, + "foreignKeys": { + "dot_mailbox_items_company_id_companies_id_fk": { + "name": "dot_mailbox_items_company_id_companies_id_fk", + "tableFrom": "dot_mailbox_items", + "tableTo": "companies", + "columnsFrom": [ + "company_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + }, + "dot_mailbox_items_binding_id_dot_agent_bindings_id_fk": { + "name": "dot_mailbox_items_binding_id_dot_agent_bindings_id_fk", + "tableFrom": "dot_mailbox_items", + "tableTo": "dot_agent_bindings", + "columnsFrom": [ + "binding_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + }, + "dot_mailbox_items_assignment_id_dot_runner_assignments_id_fk": { + "name": "dot_mailbox_items_assignment_id_dot_runner_assignments_id_fk", + "tableFrom": "dot_mailbox_items", + "tableTo": "dot_runner_assignments", + "columnsFrom": [ + "assignment_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + } + }, + "compositePrimaryKeys": {}, + "uniqueConstraints": {}, + "policies": {}, + "checkConstraints": {}, + "isRLSEnabled": false + }, + "public.dot_runner_assignments": { + "name": "dot_runner_assignments", + "schema": "", + "columns": { + "id": { + "name": "id", + "type": "uuid", + "primaryKey": true, + "notNull": true, + "default": "gen_random_uuid()" + }, + "company_id": { + "name": "company_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "binding_id": { + "name": "binding_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "binding_generation": { + "name": "binding_generation", + "type": "integer", + "primaryKey": false, + "notNull": true + }, + "run_id": { + "name": "run_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "agent_id": { + "name": "agent_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "normalized_session_id": { + "name": "normalized_session_id", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "turn_id": { + "name": "turn_id", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "revision": { + "name": "revision", + "type": "integer", + "primaryKey": false, + "notNull": true, + "default": 1 + }, + "controller_generation": { + "name": "controller_generation", + "type": "integer", + "primaryKey": false, + "notNull": true + }, + "catalog_digest": { + "name": "catalog_digest", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "status": { + "name": "status", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "projection": { + "name": "projection", + "type": "jsonb", + "primaryKey": false, + "notNull": true + }, + "accept_by": { + "name": "accept_by", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true + }, + "expires_at": { + "name": "expires_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true + }, + "accepted_at": { + "name": "accepted_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": false + }, + "settled_at": { + "name": "settled_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": false + }, + "last_activity_at": { + "name": "last_activity_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true, + "default": "now()" + }, + "created_at": { + "name": "created_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true, + "default": "now()" + } + }, + "indexes": { + "dot_assignments_turn_uq": { + "name": "dot_assignments_turn_uq", + "columns": [ + { + "expression": "run_id", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "turn_id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": true, + "concurrently": false, + "method": "btree", + "with": {} + }, + "dot_assignments_active_binding_uq": { + "name": "dot_assignments_active_binding_uq", + "columns": [ + { + "expression": "binding_id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": true, + "where": "\"dot_runner_assignments\".\"status\" IN ('offered', 'accepted')", + "concurrently": false, + "method": "btree", + "with": {} + }, + "dot_assignments_company_idx": { + "name": "dot_assignments_company_idx", + "columns": [ + { + "expression": "company_id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": false, + "concurrently": false, + "method": "btree", + "with": {} + } + }, + "foreignKeys": { + "dot_runner_assignments_company_id_companies_id_fk": { + "name": "dot_runner_assignments_company_id_companies_id_fk", + "tableFrom": "dot_runner_assignments", + "tableTo": "companies", + "columnsFrom": [ + "company_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + }, + "dot_runner_assignments_binding_id_dot_agent_bindings_id_fk": { + "name": "dot_runner_assignments_binding_id_dot_agent_bindings_id_fk", + "tableFrom": "dot_runner_assignments", + "tableTo": "dot_agent_bindings", + "columnsFrom": [ + "binding_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + }, + "dot_runner_assignments_run_id_heartbeat_runs_id_fk": { + "name": "dot_runner_assignments_run_id_heartbeat_runs_id_fk", + "tableFrom": "dot_runner_assignments", + "tableTo": "heartbeat_runs", + "columnsFrom": [ + "run_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + }, + "dot_runner_assignments_agent_id_agents_id_fk": { + "name": "dot_runner_assignments_agent_id_agents_id_fk", + "tableFrom": "dot_runner_assignments", + "tableTo": "agents", + "columnsFrom": [ + "agent_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + } + }, + "compositePrimaryKeys": {}, + "uniqueConstraints": {}, + "policies": {}, + "checkConstraints": {}, + "isRLSEnabled": false + }, + "public.dot_runner_operations": { + "name": "dot_runner_operations", + "schema": "", + "columns": { + "id": { + "name": "id", + "type": "uuid", + "primaryKey": true, + "notNull": true, + "default": "gen_random_uuid()" + }, + "company_id": { + "name": "company_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "assignment_id": { + "name": "assignment_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "request_id": { + "name": "request_id", + "type": "uuid", + "primaryKey": false, + "notNull": true + }, + "digest": { + "name": "digest", + "type": "text", + "primaryKey": false, + "notNull": true + }, + "command": { + "name": "command", + "type": "jsonb", + "primaryKey": false, + "notNull": true + }, + "status": { + "name": "status", + "type": "text", + "primaryKey": false, + "notNull": true, + "default": "'reserved'" + }, + "outcome": { + "name": "outcome", + "type": "jsonb", + "primaryKey": false, + "notNull": false + }, + "source_event_id": { + "name": "source_event_id", + "type": "text", + "primaryKey": false, + "notNull": false + }, + "created_at": { + "name": "created_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true, + "default": "now()" + }, + "updated_at": { + "name": "updated_at", + "type": "timestamp with time zone", + "primaryKey": false, + "notNull": true, + "default": "now()" + } + }, + "indexes": { + "dot_operations_request_uq": { + "name": "dot_operations_request_uq", + "columns": [ + { + "expression": "assignment_id", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "request_id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": true, + "concurrently": false, + "method": "btree", + "with": {} + } + }, + "foreignKeys": { + "dot_runner_operations_company_id_companies_id_fk": { + "name": "dot_runner_operations_company_id_companies_id_fk", + "tableFrom": "dot_runner_operations", + "tableTo": "companies", + "columnsFrom": [ + "company_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + }, + "dot_runner_operations_assignment_id_dot_runner_assignments_id_fk": { + "name": "dot_runner_operations_assignment_id_dot_runner_assignments_id_fk", + "tableFrom": "dot_runner_operations", + "tableTo": "dot_runner_assignments", + "columnsFrom": [ + "assignment_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" + } + }, + "compositePrimaryKeys": {}, + "uniqueConstraints": {}, + "policies": {}, + "checkConstraints": {}, + "isRLSEnabled": false + }, "public.email_endpoints": { "name": "email_endpoints", "schema": "", @@ -53799,7 +55126,13 @@ "name": "activity_id", "type": "uuid", "primaryKey": false, - "notNull": true + "notNull": false + }, + "mailbox_item_id": { + "name": "mailbox_item_id", + "type": "integer", + "primaryKey": false, + "notNull": false }, "event": { "name": "event", @@ -53835,6 +55168,27 @@ } }, "indexes": { + "mcp_event_deliveries_mailbox_uq": { + "name": "mcp_event_deliveries_mailbox_uq", + "columns": [ + { + "expression": "subscription_id", + "isExpression": false, + "asc": true, + "nulls": "last" + }, + { + "expression": "mailbox_item_id", + "isExpression": false, + "asc": true, + "nulls": "last" + } + ], + "isUnique": true, + "concurrently": false, + "method": "btree", + "with": {} + }, "mcp_event_deliveries_activity_uq": { "name": "mcp_event_deliveries_activity_uq", "columns": [ @@ -53890,7 +55244,12 @@ "compositePrimaryKeys": {}, "uniqueConstraints": {}, "policies": {}, - "checkConstraints": {}, + "checkConstraints": { + "mcp_delivery_source_check": { + "name": "mcp_delivery_source_check", + "value": "(\"mcp_event_deliveries\".\"activity_id\" IS NOT NULL AND \"mcp_event_deliveries\".\"mailbox_item_id\" IS NULL) OR (\"mcp_event_deliveries\".\"activity_id\" IS NULL AND \"mcp_event_deliveries\".\"mailbox_item_id\" IS NOT NULL)" + } + }, "isRLSEnabled": false }, "public.mcp_event_subscriptions": { @@ -53925,7 +55284,13 @@ "name": "task_id", "type": "uuid", "primaryKey": false, - "notNull": true + "notNull": false + }, + "binding_id": { + "name": "binding_id", + "type": "uuid", + "primaryKey": false, + "notNull": false }, "arguments": { "name": "arguments", @@ -54035,7 +55400,12 @@ "compositePrimaryKeys": {}, "uniqueConstraints": {}, "policies": {}, - "checkConstraints": {}, + "checkConstraints": { + "mcp_subscription_resource_check": { + "name": "mcp_subscription_resource_check", + "value": "(\"mcp_event_subscriptions\".\"task_id\" IS NOT NULL AND \"mcp_event_subscriptions\".\"binding_id\" IS NULL) OR (\"mcp_event_subscriptions\".\"task_id\" IS NULL AND \"mcp_event_subscriptions\".\"binding_id\" IS NOT NULL)" + } + }, "isRLSEnabled": false }, "public.mcp_file_tickets": { @@ -54591,6 +55961,19 @@ "primaryKey": false, "notNull": true }, + "purpose": { + "name": "purpose", + "type": "text", + "primaryKey": false, + "notNull": true, + "default": "'personal'" + }, + "agent_id": { + "name": "agent_id", + "type": "uuid", + "primaryKey": false, + "notNull": false + }, "scopes": { "name": "scopes", "type": "jsonb", @@ -54673,6 +56056,19 @@ ], "onDelete": "cascade", "onUpdate": "no action" + }, + "mcp_oauth_grants_agent_id_agents_id_fk": { + "name": "mcp_oauth_grants_agent_id_agents_id_fk", + "tableFrom": "mcp_oauth_grants", + "tableTo": "agents", + "columnsFrom": [ + "agent_id" + ], + "columnsTo": [ + "id" + ], + "onDelete": "cascade", + "onUpdate": "no action" } }, "compositePrimaryKeys": {}, @@ -54924,7 +56320,7 @@ "name": "expires_at", "type": "timestamp with time zone", "primaryKey": false, - "notNull": true + "notNull": false }, "created_at": { "name": "created_at", diff --git a/packages/db/src/migrations/meta/_journal.json b/packages/db/src/migrations/meta/_journal.json index ce7a0e57d4b..ea08e98553b 100644 --- a/packages/db/src/migrations/meta/_journal.json +++ b/packages/db/src/migrations/meta/_journal.json @@ -2227,6 +2227,13 @@ "when": 1791490887468, "tag": "0319_heavy_captain_midlands", "breakpoints": true + }, + { + "idx": 320, + "version": "7", + "when": 1791497222457, + "tag": "0320_daily_onslaught", + "breakpoints": true } ] } \ No newline at end of file diff --git a/packages/db/src/schema/agents.ts b/packages/db/src/schema/agents.ts index 88d0f50dc9a..04e781f568f 100644 --- a/packages/db/src/schema/agents.ts +++ b/packages/db/src/schema/agents.ts @@ -1,4 +1,4 @@ -import type { AgentAppearance } from "@paperclipai/shared"; +import type { AgentAppearance, AgentLifecycleState, AgentLifecycleOperation } from "@paperclipai/shared"; import { type AnyPgColumn, pgTable, @@ -25,6 +25,12 @@ export const agents = pgTable( icon: text("icon"), appearance: jsonb("appearance").$type(), status: text("status").notNull().default("idle"), + lifecycleState: text("lifecycle_state").$type().notNull().default("ready"), + lifecycleRequiredPluginIds: jsonb("lifecycle_required_plugin_ids").$type(), + lifecycleHolds: jsonb("lifecycle_holds").$type().notNull().default([]), + lifecycleVersion: integer("lifecycle_version").notNull().default(0), + lifecycleError: text("lifecycle_error"), + lifecycleOperation: jsonb("lifecycle_operation").$type(), reportsTo: uuid("reports_to").references((): AnyPgColumn => agents.id), capabilities: text("capabilities"), adapterType: text("adapter_type").notNull().default("process"), @@ -45,6 +51,7 @@ export const agents = pgTable( }, (table) => ({ companyIdUq: unique("agents_company_id_uq").on(table.companyId, table.id), + lifecycleWorkIdx: index("agents_lifecycle_work_idx").on(table.lifecycleState, table.updatedAt, table.id), companyStatusIdx: index("agents_company_status_idx").on(table.companyId, table.status), companyReportsToIdx: index("agents_company_reports_to_idx").on(table.companyId, table.reportsTo), companyDefaultEnvironmentIdx: index("agents_company_default_environment_idx").on(table.companyId, table.defaultEnvironmentId), diff --git a/packages/plugins/sdk/src/define-plugin.ts b/packages/plugins/sdk/src/define-plugin.ts index 12b763957c8..43a29912295 100644 --- a/packages/plugins/sdk/src/define-plugin.ts +++ b/packages/plugins/sdk/src/define-plugin.ts @@ -1,3 +1,4 @@ +import type { AgentLifecycleRequest, AgentLifecycleResult } from "@paperclipai/shared"; import type { AiConnectionRouterRequest, AiConnectionRouterResult } from "@paperclipai/shared"; /** * `definePlugin` — the top-level helper for authoring a Paperclip plugin. @@ -358,6 +359,8 @@ export interface PluginDefinition { * Requires `external.objects.read`. */ /** Propose a member from host-authorized candidates. Requires ai.connections.route. */ + onAgentLifecycle?(params: AgentLifecycleRequest): Promise; + onRouteAiConnection?(params: AiConnectionRouterRequest): Promise; onResolveExternalObject?( diff --git a/packages/plugins/sdk/src/index.ts b/packages/plugins/sdk/src/index.ts index 50430912516..7c2c944b63c 100644 --- a/packages/plugins/sdk/src/index.ts +++ b/packages/plugins/sdk/src/index.ts @@ -456,3 +456,5 @@ export { preserveEnvironmentSyncErrorDiagnostic, environmentSyncErrorData, readE export type { PluginEnvironmentSyncErrorDiagnostic } from "./environment-sync-error.js"; export type { AiConnectionPool, AiConnectionPoolConfig, AiConnectionPoolMember, AiConnectionRouterRequest, AiConnectionRouterResult, AiConnectionRouterSelection } from "@paperclipai/shared"; + +export type { AgentLifecycleRequest, AgentLifecycleResult } from "@paperclipai/shared"; diff --git a/packages/plugins/sdk/src/protocol.ts b/packages/plugins/sdk/src/protocol.ts index 7b2af372750..8f2ad9ce351 100644 --- a/packages/plugins/sdk/src/protocol.ts +++ b/packages/plugins/sdk/src/protocol.ts @@ -1,3 +1,4 @@ +import type { AgentLifecycleRequest, AgentLifecycleResult } from "@paperclipai/shared"; import type { AiConnectionRouterRequest, AiConnectionRouterResult } from "@paperclipai/shared"; /** * JSON-RPC 2.0 message types and protocol helpers for the host ↔ worker IPC @@ -1345,6 +1346,7 @@ export interface HostToWorkerMethods { /** Scoped plugin API route dispatch. */ handleApiRequest: [params: PluginApiRequestInput, result: PluginApiResponse]; /** @see PLUGIN_SPEC.md §13.8 */ + agentLifecycle: [params: AgentLifecycleRequest, result: AgentLifecycleResult]; getData: [params: GetDataParams, result: unknown]; /** @see PLUGIN_SPEC.md §13.9 */ performAction: [params: PerformActionParams, result: unknown]; @@ -1481,6 +1483,7 @@ export const HOST_TO_WORKER_OPTIONAL_METHODS: readonly HostToWorkerMethodName[] "runJob", "handleWebhook", "handleApiRequest", + "agentLifecycle", "getData", "performAction", "executeTool", diff --git a/packages/plugins/sdk/src/worker-rpc-host.ts b/packages/plugins/sdk/src/worker-rpc-host.ts index a374e31922d..ef8de899f63 100644 --- a/packages/plugins/sdk/src/worker-rpc-host.ts +++ b/packages/plugins/sdk/src/worker-rpc-host.ts @@ -1,3 +1,4 @@ +import type { AgentLifecycleRequest, AgentLifecycleResult } from "@paperclipai/shared"; import type { AiConnectionRouterRequest, AiConnectionRouterResult } from "@paperclipai/shared"; import { environmentCreationCleanupErrorData } from "./environment-creation-cleanup.js"; import { environmentSyncErrorData, withEnvironmentSyncErrorCapture } from "./environment-sync-error.js"; @@ -1659,6 +1660,9 @@ export function startWorkerRpcHost(options: WorkerRpcHostOptions): WorkerRpcHost return handleExecuteTool(params as ExecuteToolParams); case "detectExternalObjects": return handleDetectExternalObjects(params as DetectExternalObjectsParams); + case "agentLifecycle": + if (!plugin.definition.onAgentLifecycle) throw methodNotImplemented("agentLifecycle"); + return plugin.definition.onAgentLifecycle(params as AgentLifecycleRequest); case "routeAiConnection": if (!plugin.definition.onRouteAiConnection) throw methodNotImplemented("routeAiConnection"); return plugin.definition.onRouteAiConnection(params as AiConnectionRouterRequest); @@ -1779,6 +1783,7 @@ export function startWorkerRpcHost(options: WorkerRpcHostOptions): WorkerRpcHost if (plugin.definition.onIdleDrain) supportedMethods.push("prepareIdleSleep", "releaseIdleSleep"); if (plugin.definition.onApiRequest) supportedMethods.push("handleApiRequest"); if (plugin.definition.onDetectExternalObjects) supportedMethods.push("detectExternalObjects"); + if (plugin.definition.onAgentLifecycle) supportedMethods.push("agentLifecycle"); if (plugin.definition.onRouteAiConnection) supportedMethods.push("routeAiConnection"); if (plugin.definition.onResolveExternalObject) supportedMethods.push("resolveExternalObject"); if (plugin.definition.onRefreshExternalObjects) supportedMethods.push("refreshExternalObjects"); diff --git a/packages/shared/src/constants.ts b/packages/shared/src/constants.ts index fed78724740..70840a8fd64 100644 --- a/packages/shared/src/constants.ts +++ b/packages/shared/src/constants.ts @@ -1340,6 +1340,7 @@ export const PLUGIN_CAPABILITIES = [ "approvals.read", "issue.documents.read", "agents.read", + "agents.lifecycle.manage", "goals.read", "goals.create", "goals.update", diff --git a/packages/shared/src/index.ts b/packages/shared/src/index.ts index a94a156b7fe..9e7dfd5da9e 100644 --- a/packages/shared/src/index.ts +++ b/packages/shared/src/index.ts @@ -2858,3 +2858,7 @@ export { updatePrimaryAgentSchema, type UpdatePrimaryAgent, type PrimaryAgentPre export * from "./agent-avatar-upload.js"; export type { DotBinding, DotInvitation, DotConnection, DotPairing } from "./dot-invitations.js"; + +export { AGENT_LIFECYCLE_STATES, type AgentLifecycleState, type AgentLifecycleOperation } from "./types/agent-lifecycle.js"; + +export type { AgentLifecycleRequest, AgentLifecycleResult } from "./types/agent-lifecycle.js"; diff --git a/packages/shared/src/types/agent-lifecycle.ts b/packages/shared/src/types/agent-lifecycle.ts new file mode 100644 index 00000000000..a1b03e88e39 --- /dev/null +++ b/packages/shared/src/types/agent-lifecycle.ts @@ -0,0 +1,31 @@ +/** The lifecycle controls admission. Execution status describes current work. */ +export const AGENT_LIFECYCLE_STATES = [ + "pending_approval", "preparing", "verifying", "ready", "pausing", "paused", + "resuming", "terminating", "cleaning_up", "terminated", "rejected", +] as const; +export type AgentLifecycleState = typeof AGENT_LIFECYCLE_STATES[number]; + +export interface AgentLifecycleOperation { + id: string; + resumeState?: "preparing" | "verifying" | "ready"; + hostComplete: boolean; + completedPluginIds: string[]; + leaseOwner?: string; + leaseUntil?: string; + retryAt?: string; + attempts: number; + responsibleUserId?: string | null; +} + +export interface AgentLifecycleRequest { + companyId: string; + agentId: string; + operationId: string; + version: number; + phase: AgentLifecycleState; +} +export interface AgentLifecycleResult { + operationId: string; + version: number; + status: "complete" | "pending"; +} diff --git a/packages/shared/src/types/agent.ts b/packages/shared/src/types/agent.ts index 2908981ccd8..2e0f121664e 100644 --- a/packages/shared/src/types/agent.ts +++ b/packages/shared/src/types/agent.ts @@ -1,3 +1,4 @@ +import type { AgentLifecycleState } from "./agent-lifecycle.js"; import type { AgentAppearance } from "../agent-appearance.js"; import type { AiConnectionLoginIntent } from "../ai-connections.js"; import type { @@ -90,6 +91,9 @@ export interface Agent { appearance?: AgentAppearance | null; avatarUrl?: string; status: AgentStatus; + lifecycleState?: AgentLifecycleState; + lifecycleVersion?: number; + lifecycleError?: string | null; reportsTo: string | null; capabilities: string | null; adapterType: AgentAdapterType; diff --git a/packages/shared/src/types/index.ts b/packages/shared/src/types/index.ts index f149b2a8425..ec590e8e140 100644 --- a/packages/shared/src/types/index.ts +++ b/packages/shared/src/types/index.ts @@ -1098,3 +1098,5 @@ export type { AgentInstructionErrorCode, AgentInstructionErrorDetails, AgentInst export type { AgentInstructionCandidate } from "./agent.js"; export * from "./skill-source.js"; + +export * from "./agent-lifecycle.js"; diff --git a/packages/shared/src/types/plugin.ts b/packages/shared/src/types/plugin.ts index 42643d3b00e..8bf53cb7131 100644 --- a/packages/shared/src/types/plugin.ts +++ b/packages/shared/src/types/plugin.ts @@ -688,6 +688,8 @@ export interface PaperclipPluginManifestV1 { /** Capabilities this plugin requires from the host. Enforced at runtime. */ capabilities: PluginCapability[]; /** Opt into the native pooled-connection catalog, setup, and management UI. */ + /** Required participant in agent preparation, stop, resume, and cleanup. */ + agentLifecycle?: true; aiConnectionRouter?: { name: string; description: string }; /** Entrypoint paths relative to the package root. */ entrypoints: { diff --git a/packages/shared/src/validators/agent.test.ts b/packages/shared/src/validators/agent.test.ts new file mode 100644 index 00000000000..d38767b0c1f --- /dev/null +++ b/packages/shared/src/validators/agent.test.ts @@ -0,0 +1,25 @@ +import { describe, expect, it } from "vitest"; +import { updateAgentSchema } from "./agent.js"; + +describe("agent update schema", () => { + it.each(["paused", "idle", "terminated"])("accepts lifecycle status request %s", status => { + expect(updateAgentSchema.parse({ status })).toEqual({ status }); + }); + it.each(["active", "running", "error", "pending_approval"])("rejects direct status write %s", status => { + const result = updateAgentSchema.safeParse({ name: "Renamed", status }); + expect(result.success).toBe(false); + if (!result.success) expect(result.error.issues).toEqual(expect.arrayContaining([ + expect.objectContaining({ path: ["status"] }), + ])); + }); + it.each([{ spentMonthlyCents: 0 }, { name: "Renamed", spentMonthlyCents: 10 }])("rejects spend totals: %j", payload => { + const result = updateAgentSchema.safeParse(payload); + expect(result.success).toBe(false); + if (!result.success) expect(result.error.issues).toEqual(expect.arrayContaining([ + expect.objectContaining({ path: ["spentMonthlyCents"] }), + ])); + }); + it("accepts profile and budget limit changes", () => { + expect(updateAgentSchema.parse({ name: "Renamed", budgetMonthlyCents: 100 })).toEqual({ name: "Renamed", budgetMonthlyCents: 100 }); + }); +}); diff --git a/packages/shared/src/validators/agent.ts b/packages/shared/src/validators/agent.ts index 9f023c2b598..415bce05c1d 100644 --- a/packages/shared/src/validators/agent.ts +++ b/packages/shared/src/validators/agent.ts @@ -4,7 +4,6 @@ import { z } from "zod"; import { AGENT_ICON_NAMES, AGENT_ROLES, - AGENT_STATUSES, INBOX_MINE_ISSUE_STATUS_FILTER, } from "../constants.js"; import { agentAdapterTypeSchema } from "../adapter-type.js"; @@ -155,8 +154,8 @@ export const updateAgentSchema = objectWithoutDefaults( .extend({ permissions: z.never().optional(), replaceAdapterConfig: z.boolean().optional(), - status: z.enum(AGENT_STATUSES).optional(), - spentMonthlyCents: z.number().int().nonnegative().optional(), + status: z.enum(["paused", "idle", "terminated"]).optional(), + spentMonthlyCents: z.never().optional(), }); export type UpdateAgent = z.infer; diff --git a/packages/shared/src/validators/plugin.test.ts b/packages/shared/src/validators/plugin.test.ts index 3c3b46cc9bf..683272d130f 100644 --- a/packages/shared/src/validators/plugin.test.ts +++ b/packages/shared/src/validators/plugin.test.ts @@ -33,6 +33,12 @@ describe("plugin capability constants", () => { }); describe("plugin manifest validators", () => { + it("requires authority for required agent lifecycle participants", () => { + const manifest = { id: "example.lifecycle", apiVersion: 1, version: "0.1.0", displayName: "Lifecycle", description: "Lifecycle tests", author: "Tests", categories: ["automation"], entrypoints: { worker: "worker.js" }, agentLifecycle: true }; + expect(pluginManifestV1Schema.safeParse({ ...manifest, capabilities: ["agents.read"] }).success).toBe(false); + expect(pluginManifestV1Schema.parse({ ...manifest, capabilities: ["agents.lifecycle.manage"] }).agentLifecycle).toBe(true); + }); + it("requires routing authority for native pooled connector declarations without a custom UI bundle", () => { const manifest = { id: "example.pool", apiVersion: 1, version: "0.1.0", displayName: "Pool", description: "Pool", author: "Tests", categories: ["connector"], entrypoints: { worker: "worker.js" }, aiConnectionRouter: { name: "AI connection pool", description: "Use saved connections" } }; expect(pluginManifestV1Schema.safeParse({ ...manifest, capabilities: ["ui.page.register"] }).success).toBe(false); diff --git a/packages/shared/src/validators/plugin.ts b/packages/shared/src/validators/plugin.ts index 00249771642..8f67466da56 100644 --- a/packages/shared/src/validators/plugin.ts +++ b/packages/shared/src/validators/plugin.ts @@ -782,6 +782,7 @@ export const pluginManifestV1Schema = z.object({ "minimumPaperclipVersion must follow semver (e.g. 1.0.0)", ).optional(), capabilities: z.array(z.enum(PLUGIN_CAPABILITIES)).min(1), + agentLifecycle: z.literal(true).optional(), aiConnectionRouter: z.object({ name: z.string().trim().min(1).max(100), description: z.string().trim().min(1).max(500) }).strict().optional(), entrypoints: z.object({ worker: z.string().min(1), @@ -806,6 +807,10 @@ export const pluginManifestV1Schema = z.object({ launchers: z.array(pluginLauncherDeclarationSchema).optional(), }).optional(), }).superRefine((manifest, ctx) => { + if (manifest.agentLifecycle && !manifest.capabilities.includes("agents.lifecycle.manage")) { + ctx.addIssue({ code: z.ZodIssueCode.custom, message: "Agent lifecycle participation requires agents.lifecycle.manage", path: ["capabilities"] }); + } + // ── Entrypoint ↔ UI slot consistency ────────────────────────────────── // Plugins that declare UI slots must also declare a UI entrypoint so the // host knows where to load the bundle from (PLUGIN_SPEC.md §10.1). diff --git a/scripts/check-agent-lifecycle-boundaries.mjs b/scripts/check-agent-lifecycle-boundaries.mjs new file mode 100644 index 00000000000..f3b85a88735 --- /dev/null +++ b/scripts/check-agent-lifecycle-boundaries.mjs @@ -0,0 +1,50 @@ +import { readdirSync, readFileSync } from "node:fs"; +import { resolve, relative } from "node:path"; +import { fileURLToPath } from "node:url"; + +const protectedFields = new Set(["pauseReason", "pausedAt", "lifecycleState", "lifecycleVersion", "lifecycleError", "lifecycleOperation", "lifecycleRequiredPluginIds", "lifecycleHolds", "adapterType", "adapterConfig", "runtimeConfig", "defaultEnvironmentId"]); +export function agentLifecycleWriteViolations(source, file = "") { + const aliases = [...source.matchAll(/\bagents(?:\s+as\s+(\w+))?\s*[,}]/g)].map(match => match[1] ?? "agents"); + const violations = []; + const text = source.replace(/\/\*[\s\S]*?\*\//g, "").replace(/^[ \t]*\/\/.*$/gm, ""); + for (const alias of new Set(aliases)) { + for (const match of text.matchAll(new RegExp(`\\.(insert|delete|update)\\(\\s*${alias}\\s*\\)([^;]*)`, "g"))) { + const [, operation, chain] = match; + if (operation !== "update") { violations.push(operation === "delete" + ? "Use the agent lifecycle module to delete an agent" + : "Use the agent lifecycle module to insert an agent"); continue; } + for (const field of protectedFields) { + // The offline seed copy disables timers before any server can verify or run an agent. + if (field === "runtimeConfig" && file === "cli/src/commands/worktree.ts") continue; + if (new RegExp(`(? `import { agents as records } from "@paperclipai/db"; ${body}`; +test("finds inserts, deletes, and lifecycle writes through an import alias", () => { + for (const body of ["db.insert(records).values(input)", "db.delete(records)", "db.update(records).set({ lifecycleState: 'ready' })", "db.update(records).set({ pauseReason })"]) { + assert.equal(agentLifecycleWriteViolations(source(body)).length, 1); + } +}); +test("permits configuration writes and guards execution status writes", () => { + assert.deepEqual(agentLifecycleWriteViolations(source("db.update(records).set({ name })")), []); + assert.equal(agentLifecycleWriteViolations(source("db.update(records).set({ status: 'idle' })")).length, 1); + assert.deepEqual(agentLifecycleWriteViolations(source('db.update(records).set({ status: "idle" }).where(eq(records.lifecycleState, "ready"))')), []); +}); + +test("execution configuration writes must use lifecycle invalidation", () => { + for (const field of ["adapterType", "adapterConfig", "runtimeConfig", "defaultEnvironmentId"]) { + assert.equal(agentLifecycleWriteViolations(source(`db.update(records).set({ ${field}: value })`)).length, 1); + } +}); + +test("offline seed quarantine can disable timers but cannot change lifecycle state", () => { + const file = "cli/src/commands/worktree.ts"; + assert.deepEqual(agentLifecycleWriteViolations(source("db.update(records).set({ runtimeConfig })"), file), []); + assert.equal(agentLifecycleWriteViolations(source("db.update(records).set({ lifecycleState: 'ready' })"), file).length, 1); +}); + +test("rejects agent deletion outside the module even with a terminal state guard", () => { + assert.equal(agentLifecycleWriteViolations(source('db.delete(records).where(and(eq(records.id, id), inArray(records.lifecycleState, ["terminated", "rejected"])))')).length, 1); + assert.equal(agentLifecycleWriteViolations(source('db.delete(records).where(inArray(records.lifecycleState, ["ready", "terminated"]))')).length, 1); +}); diff --git a/scripts/check-module-boundaries.mjs b/scripts/check-module-boundaries.mjs index eed66df002e..21f8f48d0e6 100644 --- a/scripts/check-module-boundaries.mjs +++ b/scripts/check-module-boundaries.mjs @@ -1,5 +1,6 @@ #!/usr/bin/env node +import { scanAgentLifecycleBoundaries } from "./check-agent-lifecycle-boundaries.mjs"; import { readdirSync, readFileSync } from "node:fs"; import { dirname, relative, resolve, sep } from "node:path"; import { fileURLToPath } from "node:url"; @@ -9,6 +10,10 @@ const defaultServerSrc = resolve(repoRoot, "server/src"); const defaultModulesRoot = resolve(defaultServerSrc, "modules"); const layerNames = new Set(["domain", "application", "adapters"]); const databasePackages = ["@paperclipai/db", "drizzle-orm", "embedded-postgres", "postgres"]; +const configurationTransactionCallers = new Set([ + "services/secret-proposals.ts", "services/connection-intents.ts", "services/dot-runner-broker.ts", + "services/public-mcp/oauth.ts", "services/agent-profile-avatar.ts", "services/agent-instruction-revisions.ts", "services/company-skills.ts", +]); function normalizedRelative(from, to) { return relative(from, to).split(sep).join("/"); @@ -99,6 +104,18 @@ export function scanModuleBoundaries({ const targetSegments = targetServerSegments(serverSrc, target); const targetLocation = target ? moduleLocation(modulesRoot, target) : null; + if (/^services\/agent-configuration-transaction\.(?:js|ts)$/.test(targetSegments.join("/")) && + !configurationTransactionCallers.has(normalizedRelative(serverSrc, sourceFile))) { + addViolation(violations, sourceLabel, sourceLocation?.layer ?? null, specifier, + "configuration transaction integration is limited to its explicit workflow callers"); + } + + if (sourceLocation?.moduleName === "agent-lifecycle" && + (targetSegments.includes("services") || targetSegments.includes("routes"))) { + addViolation(violations, sourceLabel, sourceLocation.layer, specifier, + "agent lifecycle must receive service integrations through its ports"); + } + if (sourceLocation?.layer === "domain") { if (isDatabasePackage(specifier)) { addViolation(violations, sourceLabel, "domain", specifier, "domain cannot import database packages"); @@ -135,7 +152,11 @@ export function scanModuleBoundaries({ if (targetLocation && sourceLocation?.moduleName !== targetLocation.moduleName) { const targetRelative = normalizedRelative(resolve(modulesRoot, targetLocation.moduleName), target); - if (targetRelative !== "index.js" && targetRelative !== "index.ts") { + const configurationIntegration = /^configuration\.(?:js|ts)$/.test(targetRelative) && + normalizedRelative(serverSrc, sourceFile) === "services/agent-configuration-transaction.ts"; + const companyDeletionIntegration = /^company-deletion\.(?:js|ts)$/.test(targetRelative) && + normalizedRelative(serverSrc, sourceFile) === "services/company-deletion.ts"; + if (targetRelative !== "index.js" && targetRelative !== "index.ts" && !companyDeletionIntegration && !configurationIntegration) { addViolation( violations, sourceLabel, @@ -158,13 +179,15 @@ export function formatViolation(violation) { function main() { const violations = scanModuleBoundaries(); + const lifecycleViolations = scanAgentLifecycleBoundaries(); + if (lifecycleViolations.length) { console.error(lifecycleViolations.join("\n")); process.exitCode = 1; } if (violations.length > 0) { console.error("Feature module boundary check failed:"); for (const violation of violations) console.error(`- ${formatViolation(violation)}`); process.exitCode = 1; return; } - console.log("Feature module boundary check passed."); + if (!lifecycleViolations.length) console.log("Feature module boundary check passed."); } if (resolve(process.argv[1] ?? "") === fileURLToPath(import.meta.url)) main(); diff --git a/scripts/check-module-boundaries.test.mjs b/scripts/check-module-boundaries.test.mjs index 671025cec38..94f7eeb452f 100644 --- a/scripts/check-module-boundaries.test.mjs +++ b/scripts/check-module-boundaries.test.mjs @@ -1,3 +1,4 @@ +import "./check-agent-lifecycle-boundaries.test.mjs"; import assert from "node:assert/strict"; import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs"; import { tmpdir } from "node:os"; @@ -88,3 +89,57 @@ test("scanModuleBoundaries rejects outward dependencies and module-internal impo test("the repository's feature modules satisfy their import boundaries", () => { assert.deepEqual(scanModuleBoundaries(), []); }); + +test("only the company deletion coordinator can import module deletion entry points", () => { + const serverSrc = mkdtempSync(join(tmpdir(), "paperclip-company-deletion-boundaries-")); + const modulesRoot = join(serverSrc, "modules"); + try { + mkdirSync(join(serverSrc, "services")); + mkdirSync(join(serverSrc, "routes")); + const integration = 'import { deletion } from "../modules/example/company-deletion.js";'; + writeFileSync(join(serverSrc, "services", "company-deletion.ts"), integration); + writeFileSync(join(serverSrc, "services", "other.ts"), integration); + writeFileSync(join(serverSrc, "routes", "companies.ts"), integration); + const violations = scanModuleBoundaries({ serverSrc, modulesRoot }); + assert.equal(violations.length, 2); + assert(violations.some(({ file }) => file.endsWith("services/other.ts"))); + assert(violations.some(({ file }) => file.endsWith("routes/companies.ts"))); + } finally { + rmSync(serverSrc, { recursive: true, force: true }); + } +}); + +test("configuration integration is limited to its composition and workflow callers", () => { + const serverSrc = mkdtempSync(join(tmpdir(), "paperclip-configuration-boundaries-")); + const modulesRoot = join(serverSrc, "modules"); + try { + mkdirSync(join(serverSrc, "services")); + mkdirSync(join(serverSrc, "routes")); + const integration = 'import { update } from "../modules/agent-lifecycle/configuration.js";'; + const workflow = 'import { update } from "./agent-configuration-transaction.js";'; + writeFileSync(join(serverSrc, "services", "agent-configuration-transaction.ts"), integration); + writeFileSync(join(serverSrc, "services", "secret-proposals.ts"), workflow); + writeFileSync(join(serverSrc, "services", "other.ts"), workflow); + writeFileSync(join(serverSrc, "routes", "agents.ts"), integration); + const violations = scanModuleBoundaries({ serverSrc, modulesRoot }); + assert.equal(violations.length, 2); + assert(violations.some(({ file }) => file.endsWith("services/other.ts"))); + assert(violations.some(({ file }) => file.endsWith("routes/agents.ts"))); + } finally { + rmSync(serverSrc, { recursive: true, force: true }); + } +}); + +test("agent lifecycle adapters and entry point cannot depend on services", () => { + const serverSrc = mkdtempSync(join(tmpdir(), "paperclip-lifecycle-boundaries-")); + const modulesRoot = join(serverSrc, "modules"); + try { + mkdirSync(join(modulesRoot, "agent-lifecycle", "adapters"), { recursive: true }); + writeFileSync(join(modulesRoot, "agent-lifecycle", "index.ts"), 'import "../../services/example.js";'); + writeFileSync(join(modulesRoot, "agent-lifecycle", "adapters", "records.ts"), 'import "../../../services/example.js";'); + assert.equal(scanModuleBoundaries({ serverSrc, modulesRoot }).filter(item => + item.reason === "agent lifecycle must receive service integrations through its ports").length, 2); + } finally { + rmSync(serverSrc, { recursive: true, force: true }); + } +}); diff --git a/packages/db/src/seed.ts b/server/scripts/seed.ts similarity index 85% rename from packages/db/src/seed.ts rename to server/scripts/seed.ts index ff6e4f63d32..452ad348e65 100644 --- a/packages/db/src/seed.ts +++ b/server/scripts/seed.ts @@ -1,5 +1,11 @@ -import { createDb } from "./client.js"; -import { companies, agents, goals, projects, issues } from "./schema/index.js"; +import { createDb } from "@paperclipai/db"; +import { createAgentLifecycle } from "../src/services/agent-lifecycle.js"; +import { + companies, + goals, + projects, + issues, +} from "@paperclipai/db"; const url = process.env.DATABASE_URL; if (!url) throw new Error("DATABASE_URL is required"); @@ -18,10 +24,7 @@ const [company] = await db }) .returning(); -const [ceo] = await db - .insert(agents) - .values({ - companyId: company!.id, +const ceo = await createAgentLifecycle(db).requestHire(company!.id, { name: "CEO Agent", role: "ceo", title: "Chief Executive Officer", @@ -29,13 +32,9 @@ const [ceo] = await db adapterType: "process", adapterConfig: { command: "echo", args: ["hello from ceo"] }, budgetMonthlyCents: 15000, - }) - .returning(); + }); -const [engineer] = await db - .insert(agents) - .values({ - companyId: company!.id, +const engineer = await createAgentLifecycle(db).requestHire(company!.id, { name: "Engineer Agent", role: "engineer", title: "Software Engineer", @@ -44,8 +43,7 @@ const [engineer] = await db adapterType: "process", adapterConfig: { command: "echo", args: ["hello from engineer"] }, budgetMonthlyCents: 10000, - }) - .returning(); + }); const [goal] = await db .insert(goals) diff --git a/server/scripts/smoke-native-task-monitor.ts b/server/scripts/smoke-native-task-monitor.ts index 76d327bd939..0231bdba098 100644 --- a/server/scripts/smoke-native-task-monitor.ts +++ b/server/scripts/smoke-native-task-monitor.ts @@ -1,4 +1,4 @@ -/** Opt-in live qualification: creates an isolated database/workspace and spends two Codex turns. +/** Opt-in live qualification: creates an isolated database/workspace and runs a harness test and two Codex turns. * PATH=::$PATH node --import tsx server/scripts/smoke-native-task-monitor.ts --run */ import assert from "node:assert/strict"; @@ -17,6 +17,9 @@ process.env.PAPERCLIP_INSTANCE_ID = "monitor-smoke"; process.env.PAPERCLIP_TELEMETRY_ENABLED = "false"; const { createDb, companies, agents, authUsers, companyMemberships, issues, heartbeatRuns, agentWakeupRequests, nativeRunResults, statusDecisions } = await import("@paperclipai/db"); const { startEmbeddedPostgresTestDatabase } = await import("../src/__tests__/helpers/embedded-postgres.js"); +const { createAgentLifecycle, startAgentLifecycle } = await import("../src/services/agent-lifecycle.js"); +const { createLifecycleDriver } = await import("../src/services/agent-lifecycle-driver.js"); +const { createPluginWorkerManager } = await import("../src/services/plugin-worker-manager.js"); const { heartbeatService } = await import("../src/services/heartbeat.js"); const { setupRunnerPrpWebSocketServer, runnerPrpWebSocketInternals } = await import("../src/realtime/runner-prp-ws.js"); const { closeIdleWarmNativeSessionsForRestart } = await import("../src/services/native-runtime/native-session-executor.js"); @@ -30,6 +33,7 @@ process.env.PAPERCLIP_API_URL = `http://127.0.0.1:${address.port}`; setupRunnerPrpWebSocketServer(server, { apiUrl: process.env.PAPERCLIP_API_URL }); const companyId = randomUUID(), agentId = randomUUID(), issueId = randomUUID(); const heartbeat = heartbeatService(db); +const lifecycle = startAgentLifecycle(db, createLifecycleDriver(db, createPluginWorkerManager()), () => true); const readRuns = () => db.select().from(heartbeatRuns).where(eq(heartbeatRuns.companyId, companyId)).orderBy(heartbeatRuns.createdAt); console.log(JSON.stringify({ root, companyId, agentId, issueId })); try { @@ -38,9 +42,18 @@ try { await db.insert(companies).values({ id: companyId, name: "Isolated monitor smoke", issuePrefix: "MON", defaultResponsibleUserId: "monitor-smoke", requireBoardApprovalForNewAgents: false }); await db.insert(authUsers).values({ id: "monitor-smoke", name: "Monitor smoke", email: "monitor-smoke@example.test", createdAt: new Date(), updatedAt: new Date() }); await db.insert(companyMemberships).values({ companyId, principalType: "user", principalId: "monitor-smoke", status: "active", membershipRole: "owner" }); - await db.insert(agents).values({ id: agentId, companyId, name: "Monitor verifier", status: "active", adapterType: "paperclip_runner", + await createAgentLifecycle(db).requestHire(companyId, { id: agentId, name: "Monitor verifier", status: "active", adapterType: "paperclip_runner", adapterConfig: { provider: "codex", cwd, lifecycleMode: "warm", idleTimeoutMs: 300_000, timeoutSeconds: 180 }, runtimeConfig: { heartbeat: { enabled: false, wakeOnDemand: true } } }); + const setupDeadline = Date.now() + 3 * 60_000; + while (true) { + const agent = await createAgentLifecycle(db).get(agentId); + assert.ok(agent, "the hired agent must exist"); + assert.equal(agent.lifecycleError, null, "agent setup failed"); + if (agent.lifecycleState === "ready") break; + assert.ok(Date.now() < setupDeadline, "agent setup timed out"); + await delay(250); + } await db.insert(issues).values({ id: issueId, companyId, title: "Verify a one-shot native task monitor", identifier: "MON-1", status: "in_progress", assigneeAgentId: agentId, description: "This is an isolated two-run integration test. First run: use set_task_monitor on this task with a fresh nextCheckAt about 45 seconds in the future (compute the current UTC time if needed), notes saying to verify issue_monitor_due, and idempotencyKey monitor-live-first. Confirm the receipt. Then call paperclip_finish with yielded and continuation.kind monitor, accurately retaining the second run as blocking remaining work. End immediately after acceptance. Do not sleep or poll. Second run: if the wake reason is issue_monitor_due, the requested check succeeded. Report that reason and finish done using the current completion contract. Do not schedule another monitor or request human review. No files or other deliverables are required." }); await heartbeat.wakeup(agentId, { source: "on_demand", triggerDetail: "manual", reason: "monitor_smoke", @@ -90,6 +103,7 @@ try { await writeFile(join(root, "evidence.json"), JSON.stringify(evidence, null, 2)); console.log(JSON.stringify({ passed: true, evidence: join(root, "evidence.json"), warmReuse: evidence.warmReuse })); } finally { + await lifecycle.stop(); await writeFile(join(root, "run-records.json"), JSON.stringify(await readRuns(), null, 2)); await closeIdleWarmNativeSessionsForRestart(); runnerPrpWebSocketInternals.resetForTests(); diff --git a/server/scripts/verify-agent-commentary-live.ts b/server/scripts/verify-agent-commentary-live.ts index 78423b18491..d408ecf9514 100644 --- a/server/scripts/verify-agent-commentary-live.ts +++ b/server/scripts/verify-agent-commentary-live.ts @@ -2,6 +2,7 @@ * Uses real Codex, disposable database/workspaces, and a private copy of login credentials. * Writes only content-free evidence to stdout; never runs as part of the unit suite. */ +import { createAgentLifecycle } from "../src/services/agent-lifecycle.js"; import assert from "node:assert/strict"; import { randomUUID } from "node:crypto"; import { chmod, copyFile, lstat, mkdir, mkdtemp, readdir, readFile, rm, writeFile } from "node:fs/promises"; @@ -63,7 +64,7 @@ try { let result; if (mode === "legacy") { await server.db.update(heartbeatRuns).set({ runtimeMode: "legacy", nativeIssueId: null }).where(eq(heartbeatRuns.id, f.runId)); - await server.db.update(agents).set({ adapterType: "codex_local" }).where(eq(agents.id, f.agentId)); + await createAgentLifecycle(server.db).updateConfiguration(f.agentId, { adapterType: "codex_local" }); result = await executeLegacy({ runId: f.runId, agent: { id: f.agentId, companyId: f.companyId, name: "Feedback smoke", adapterType: "codex_local", adapterConfig: {} }, diff --git a/server/src/__tests__/adapter-auth-signal-routes.test.ts b/server/src/__tests__/adapter-auth-signal-routes.test.ts index 3a8fc01b97d..8360e3e133a 100644 --- a/server/src/__tests__/adapter-auth-signal-routes.test.ts +++ b/server/src/__tests__/adapter-auth-signal-routes.test.ts @@ -413,3 +413,9 @@ describe("adapter auth-signal route", () => { expect(mockResolveEnvironmentExecutionTarget).not.toHaveBeenCalled(); }); }); + +vi.mock("../services/agent-lifecycle.js", async (importOriginal) => { + const actual = await importOriginal(); + return { ...actual, createAgentLifecycle: () => ({ + }) }; +}); diff --git a/server/src/__tests__/agent-adapter-validation-routes.test.ts b/server/src/__tests__/agent-adapter-validation-routes.test.ts index 1aa12179772..335381d98b5 100644 --- a/server/src/__tests__/agent-adapter-validation-routes.test.ts +++ b/server/src/__tests__/agent-adapter-validation-routes.test.ts @@ -1199,3 +1199,10 @@ describe("agent routes adapter validation", () => { expect(mockAgentService.update).toHaveBeenCalledOnce(); }); }); + +vi.mock("../services/agent-lifecycle.js", async (importOriginal) => { + const actual = await importOriginal(); + return { ...actual, createAgentLifecycle: () => ({ + requestHire: (...args: unknown[]) => mockAgentService.create(...args), + }) }; +}); diff --git a/server/src/__tests__/agent-commentary.integration.test.ts b/server/src/__tests__/agent-commentary.integration.test.ts index 3fce4e97a3e..bc0655633d6 100644 --- a/server/src/__tests__/agent-commentary.integration.test.ts +++ b/server/src/__tests__/agent-commentary.integration.test.ts @@ -212,7 +212,10 @@ describe("internal agent commentary through both transports", () => { await server.db.insert(heartbeatRuns).values({ id: runId, companyId: f.companyId, agentId, status: "running", invocationSource: "on_demand" }); await submitAgentCommentary(server.db, { companyId: f.companyId, agentId, runId }, { ...input, kind: "complaint" }); expect((await rows({ ...f, runId }))[0].issueId).toBeNull(); - if (owner === "agent") await agentService(server.db).remove(agentId); + if (owner === "agent") { + await server.db.update(agents).set({ lifecycleState: "terminated", status: "terminated" }).where(eq(agents.id, agentId)); + await agentService(server.db).remove(agentId); + } else await companyService(server.db).remove(f.companyId); expect(await rows({ ...f, runId })).toHaveLength(0); }); diff --git a/server/src/__tests__/agent-cross-tenant-authz-routes.test.ts b/server/src/__tests__/agent-cross-tenant-authz-routes.test.ts index c7c1af49314..6884957481f 100644 --- a/server/src/__tests__/agent-cross-tenant-authz-routes.test.ts +++ b/server/src/__tests__/agent-cross-tenant-authz-routes.test.ts @@ -755,3 +755,13 @@ describe("agent cross-tenant route authorization", () => { expect(mockLogActivity).not.toHaveBeenCalled(); }); }); + +vi.mock("../services/agent-lifecycle.js", async (importOriginal) => { + const actual = await importOriginal(); + return { ...actual, createAgentLifecycle: () => ({ + requestHire: (...args: unknown[]) => mockAgentService.create(...args), + pauseAgent: (...args: unknown[]) => mockAgentService.pause(...args), + resumeAgent: (...args: unknown[]) => mockAgentService.resume(...args), + terminateAgent: (...args: unknown[]) => mockAgentService.terminate(...args), + }) }; +}); diff --git a/server/src/__tests__/agent-default-configure-grants.test.ts b/server/src/__tests__/agent-default-configure-grants.test.ts index 3094e12f700..b1bfa96d519 100644 --- a/server/src/__tests__/agent-default-configure-grants.test.ts +++ b/server/src/__tests__/agent-default-configure-grants.test.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "../services/agent-lifecycle.js"; import { randomUUID } from "node:crypto"; import { afterAll, beforeAll, describe, expect, it } from "vitest"; import { eq } from "drizzle-orm"; @@ -50,7 +51,7 @@ describeDatabase("new agent configuration defaults", () => { issuePrefix: `PD${companyId.slice(0, 6).toUpperCase()}`, }); const create = (name: string, permissions: Record = {}, metadata?: Record) => - agentService(db).create(companyId, { + createAgentLifecycle(db).requestHire(companyId, { name, role: "engineer", adapterType: "process", @@ -130,6 +131,7 @@ describeDatabase("new agent configuration defaults", () => { expect(await db.select().from(principalPermissionGrants) .where(eq(principalPermissionGrants.principalId, standard.id))).toEqual([]); + await db.update(agents).set({ status: "terminated", lifecycleState: "terminated" }).where(eq(agents.id, peer.id)); await agentService(db).remove(peer.id); expect(await db.select().from(principalPermissionGrants) .where(eq(principalPermissionGrants.principalId, peer.id))).toEqual([]); @@ -190,7 +192,7 @@ describeDatabase("new agent configuration defaults", () => { name: "Pending permission default", issuePrefix: `PP${companyId.slice(0, 6).toUpperCase()}`, }); - const pending = await agentService(db).create(companyId, { + const pending = await createAgentLifecycle(db).requestHire(companyId, { name: "Pending hire", status: "pending_approval", role: "engineer", @@ -201,7 +203,7 @@ describeDatabase("new agent configuration defaults", () => { expect(await db.select().from(principalPermissionGrants) .where(eq(principalPermissionGrants.companyId, companyId))).toEqual([]); - const result = await agentService(db).activatePendingApproval(pending.id); + const result = await createAgentLifecycle(db).approveHire(pending.id); expect(result?.activated).toBe(true); expect((await db.select().from(principalPermissionGrants) .where(eq(principalPermissionGrants.companyId, companyId))) @@ -220,7 +222,7 @@ describeDatabase("new agent configuration defaults", () => { name: "Invited permission default", issuePrefix: `PI${companyId.slice(0, 6).toUpperCase()}`, }); - const invited = await agentService(db).create(companyId, { + const invited = await createAgentLifecycle(db).requestHire(companyId, { name: "Invited agent", role: "engineer", adapterType: "process", diff --git a/server/src/__tests__/agent-device-login-routes.test.ts b/server/src/__tests__/agent-device-login-routes.test.ts index 32488c60956..61b617d2127 100644 --- a/server/src/__tests__/agent-device-login-routes.test.ts +++ b/server/src/__tests__/agent-device-login-routes.test.ts @@ -1709,3 +1709,10 @@ describe("adapter device-login routes", () => { expect(loggedText).not.toContain("provider-lease-"); }); }); + +vi.mock("../services/agent-lifecycle.js", async (importOriginal) => { + const actual = await importOriginal(); + return { ...actual, createAgentLifecycle: () => ({ + requestHire: (...args: unknown[]) => mockAgentService.create(...args), + }) }; +}); diff --git a/server/src/__tests__/agent-harness-verification.test.ts b/server/src/__tests__/agent-harness-verification.test.ts new file mode 100644 index 00000000000..4728cdabd18 --- /dev/null +++ b/server/src/__tests__/agent-harness-verification.test.ts @@ -0,0 +1,27 @@ +import { describe, expect, it } from "vitest"; +import type { AdapterEnvironmentTestResult } from "@paperclipai/adapter-utils"; +import { ADAPTER_AUTH_MISSING_CHECK_CODE } from "@paperclipai/shared"; +import { assertHarnessTestPassed } from "../services/agent-harness-verification.js"; + +describe("saved harness verification", () => { + const result = (status: AdapterEnvironmentTestResult["status"], codes: string[]): AdapterEnvironmentTestResult => ({ + adapterType: "test", status, testedAt: new Date().toISOString(), + checks: codes.map(code => ({ code, level: "info", message: code })), + }); + it.each([ + ["fail", []], ["warn", ["claude_hello_probe_auth_required"]], + ["warn", ["gemini_hello_probe_timed_out"]], ["pass", ["claude_hello_probe_skipped_custom_command"]], + ["warn", ["claude_acp_anthropic_api_key_detected", "claude_acp_login_probe_unavailable"]], + ["warn", ["cli_version_probe_mismatch"]], ["pass", [ADAPTER_AUTH_MISSING_CHECK_CODE]], + ["warn", ["claude_hello_probe_passed", "claude_hello_probe_auth_required"]], + ] as const)("rejects %s with %j", (status, codes) => { + expect(() => assertHarnessTestPassed(result(status, [...codes]))).toThrow("The harness test failed"); + }); + it.each([ + ["pass", ["process_command_available"]], ["warn", ["claude_hello_probe_passed", "optional_environment_warning"]], + ["warn", ["claude_acp_anthropic_api_key_detected", "claude_hello_probe_passed"]], + ["pass", ["codex_hello_probe_succeeded"]], ["warn", ["ai_connection_api_key_reverified"]], + ] as const)("accepts %s with %j", (status, codes) => { + expect(() => assertHarnessTestPassed(result(status, [...codes]))).not.toThrow(); + }); +}); diff --git a/server/src/__tests__/agent-hire-ai-connections.test.ts b/server/src/__tests__/agent-hire-ai-connections.test.ts index e1be98a92b0..86ca31b72f6 100644 --- a/server/src/__tests__/agent-hire-ai-connections.test.ts +++ b/server/src/__tests__/agent-hire-ai-connections.test.ts @@ -22,6 +22,7 @@ import { aiConnectionRouterService } from "../services/ai-connection-router.js"; import { instanceSettingsService } from "../services/instance-settings.js"; import { toolAccessService } from "../services/tool-access.js"; import { waitForPendingRunFailureReports } from "../services/run-failure-report.js"; +import { configureAgentLifecycle } from "../services/agent-lifecycle.js"; const captureRunFailure = vi.hoisted(() => vi.fn()); vi.mock("../sentry.js", async (importOriginal) => ({ @@ -374,7 +375,7 @@ describe("agent-created hires use managed AI connections", () => { const agent = hired(await request(f.app).post(`/api/companies/${f.companyId}/agent-hires`).send({ name: "Other provider", role: "engineer", adapterType })); expect(agent.runtimeConfig.aiConnection).toMatchObject({ provider: otherProvider, mode: "responsible_user" }); await expect(prepareManagedAiRuntime(db, { companyId: f.companyId, agentId: agent.id, responsibleUserId: f.userId, adapterType, binding: agent.runtimeConfig.aiConnection, config: agent.adapterConfig })).rejects.toMatchObject({ details: { code: "ai_connection_default_missing" } }); - expect(agent.status).toBe("idle"); + expect(agent).toMatchObject({ status: "paused", lifecycleState: "preparing" }); }); for (const endpoint of ["agent-hires", "agents"]) { @@ -486,11 +487,17 @@ describe("agent-created hires use managed AI connections", () => { }); describe("hired agents sharing a subscription", () => { + async function finishSetup(agentId: string) { + // These tests cover task credentials after setup; lifecycle tests cover verification. + const worker = configureAgentLifecycle(db, { requiredPluginIds: async () => [], runPlugin: async () => "complete", runHost: async () => "complete" }); + try { await worker.process(agentId); } finally { await worker.stop(); } + } it("keeps a credential-lock timeout on automatic retry without blocking the task or starting a provider", async () => { const f = await fixture("openai", "subscription"); const agent = hired(await request(f.app).post(`/api/companies/${f.companyId}/agent-hires`).send({ name: "Waiting teammate", role: "engineer", adapterType: f.adapterType, reportsTo: f.agentId, adapterConfig: { engine: "cli" }, runtimeConfig: { heartbeat: { enabled: false } } })); // Only an operator may set host execution paths after the agent is hired. await db.update(agents).set({ adapterConfig: { ...agent.adapterConfig, cwd: home } }).where(eq(agents.id, agent.id)); + await finishSetup(agent.id); const [issue] = await db.insert(issues).values({ companyId: f.companyId, title: "Wait for credential rotation", status: "todo", assigneeAgentId: agent.id, responsibleUserId: f.userId, createdByUserId: f.userId }).returning(); const execute = vi.fn(async () => ({ exitCode: 0, signal: null, timedOut: false, resultJson: {} })); registerServerAdapter({ ...getServerAdapter(f.adapterType), execute }); @@ -534,6 +541,7 @@ describe("hired agents sharing a subscription", () => { const agent = hired(await request(f.app).post(`/api/companies/${f.companyId}/agent-hires`).send({ name: "Concurrent teammate", role: "engineer", adapterType: f.adapterType, reportsTo: f.agentId, adapterConfig: { engine: "cli" }, runtimeConfig: { heartbeat: { enabled: false } } })); // Host working directories are configured by an operator, not an agent key. await db.update(agents).set({ adapterConfig: { ...agent.adapterConfig, cwd: home } }).where(eq(agents.id, agent.id)); + await finishSetup(agent.id); const [issue] = await db.insert(issues).values({ companyId: f.companyId, title: "Subscription child task", status: "todo", assigneeAgentId: agent.id, responsibleUserId: f.userId, createdByUserId: f.userId }).returning(); const parentRuntime = await prepareManagedAiRuntime(db, { companyId: f.companyId, agentId: f.agentId, responsibleUserId: f.userId, adapterType: f.adapterType, binding: f.binding, config: { cwd: home } }); const execute = vi.fn(async () => { diff --git a/server/src/__tests__/agent-identity.test.ts b/server/src/__tests__/agent-identity.test.ts index dcdbf1189b2..d0e7dcbe246 100644 --- a/server/src/__tests__/agent-identity.test.ts +++ b/server/src/__tests__/agent-identity.test.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "../services/agent-lifecycle.js"; import { randomBytes, randomUUID, verify, generateKeyPairSync } from "node:crypto"; import { mkdtemp, rm } from "node:fs/promises"; import { tmpdir } from "node:os"; @@ -74,7 +75,7 @@ describe("agent cryptographic identity", () => { }); it("creates identities in the agent creation transaction and rolls both writes back on failure", async () => { - const created = await agentService(db).create(companyId, { name: "New identity", role: "engineer", status: "pending_approval" }); + const created = await createAgentLifecycle(db).requestHire(companyId, { name: "New identity", role: "engineer", status: "pending_approval" }); expect(await agentIdentityService(db).getPublicIdentity(companyId, created.id)).toMatchObject({ algorithm: "Ed25519" }); const id = randomUUID(); await expect(db.transaction(async tx => { @@ -85,7 +86,7 @@ describe("agent cryptographic identity", () => { expect(await db.select().from(agents).where(eq(agents.id, id))).toHaveLength(0); expect(await agentIdentityService(db).getPublicIdentity(companyId, id)).toBeNull(); const fail = vi.spyOn(localEncryptedProvider, "createSecret").mockRejectedValueOnce(new Error("encryption unavailable")); - await expect(agentService(db).create(companyId, { name: "Must roll back", role: "engineer", status: "pending_approval" })).rejects.toThrow("encryption unavailable"); + await expect(createAgentLifecycle(db).requestHire(companyId, { name: "Must roll back", role: "engineer", status: "pending_approval" })).rejects.toThrow("encryption unavailable"); fail.mockRestore(); expect(await db.select().from(agents).where(eq(agents.name, "Must roll back"))).toHaveLength(0); }); diff --git a/server/src/__tests__/agent-instructions-routes.test.ts b/server/src/__tests__/agent-instructions-routes.test.ts index a16333701a4..4f7a65449b3 100644 --- a/server/src/__tests__/agent-instructions-routes.test.ts +++ b/server/src/__tests__/agent-instructions-routes.test.ts @@ -844,3 +844,10 @@ describe("agent instructions bundle routes", () => { expect(res.body.adapterConfig.instructionsFilePath).toBeUndefined(); }); }); + +vi.mock("../services/agent-lifecycle.js", async (importOriginal) => { + const actual = await importOriginal(); + return { ...actual, createAgentLifecycle: () => ({ + requestHire: (...args: unknown[]) => mockAgentService.create(...args), + }) }; +}); diff --git a/server/src/__tests__/agent-live-run-routes.test.ts b/server/src/__tests__/agent-live-run-routes.test.ts index 6210ac99470..60605adf327 100644 --- a/server/src/__tests__/agent-live-run-routes.test.ts +++ b/server/src/__tests__/agent-live-run-routes.test.ts @@ -1940,3 +1940,9 @@ describe("agent live run routes", () => { expect(mockWorkspaceDiffReprojection.persist).not.toHaveBeenCalled(); }); }); + +vi.mock("../services/agent-lifecycle.js", async (importOriginal) => { + const actual = await importOriginal(); + return { ...actual, createAgentLifecycle: () => ({ + }) }; +}); diff --git a/server/src/__tests__/agent-permissions-routes.test.ts b/server/src/__tests__/agent-permissions-routes.test.ts index 72570a9e9dc..0ad2e679095 100644 --- a/server/src/__tests__/agent-permissions-routes.test.ts +++ b/server/src/__tests__/agent-permissions-routes.test.ts @@ -73,8 +73,8 @@ const mockApprovalService = vi.hoisted(() => ({ create: vi.fn(), getById: vi.fn(), findOpenHireApprovalForAgent: vi.fn(), - approve: vi.fn(), - reject: vi.fn(), + approveHire: vi.fn(), + rejectHire: vi.fn(), })); const mockBudgetService = vi.hoisted(() => ({ @@ -317,8 +317,8 @@ describe("agent permission routes", () => { mockApprovalService.create.mockReset(); mockApprovalService.getById.mockReset(); mockApprovalService.findOpenHireApprovalForAgent.mockReset(); - mockApprovalService.approve.mockReset(); - mockApprovalService.reject.mockReset(); + mockApprovalService.approveHire.mockReset(); + mockApprovalService.rejectHire.mockReset(); mockBudgetService.upsertPolicy.mockReset(); mockHeartbeatService.listTaskSessions.mockReset(); mockHeartbeatService.resetRuntimeSession.mockReset(); @@ -679,6 +679,16 @@ describe("agent permission routes", () => { ]); }); + it.each([{ spentMonthlyCents: 0 }, { name: "Renamed", spentMonthlyCents: 0 }])( + "rejects accounting fields before applying an agent update: %j", async payload => { + const app = await createApp({ type: "board", userId: "board-user", source: "session", isInstanceAdmin: true, companyIds: [companyId] }); + const res = await requestApp(app, baseUrl => request(baseUrl).patch(`/api/agents/${agentId}`).send(payload)); + expect(res.status).toBe(400); + expect(res.body.details).toEqual(expect.arrayContaining([expect.objectContaining({ path: ["spentMonthlyCents"] })])); + expect(mockAgentService.update).not.toHaveBeenCalled(); + }, + ); + it("blocks agent updates for authenticated company members without agent admin permission", async () => { mockAccessService.canUser.mockResolvedValue(false); @@ -1251,7 +1261,7 @@ describe("agent permission routes", () => { expect.objectContaining({ status: "idle", }), - { createdByUserId: "agent-admin-user", claudeLogin: { storedSessionId: null, ownerUserId: "agent-admin-user", applyExistingWithoutClaim: false } }, + { createdByUserId: "agent-admin-user", responsibleUserId: "agent-admin-user", claudeLogin: { storedSessionId: null, ownerUserId: "agent-admin-user", applyExistingWithoutClaim: false } }, ); expect(mockAccessService.setPrincipalPermission).toHaveBeenCalledWith( companyId, @@ -1381,7 +1391,7 @@ describe("agent permission routes", () => { }, }, }), - { createdByUserId: "board-user", claudeLogin: { storedSessionId: null, ownerUserId: "board-user", applyExistingWithoutClaim: false } }, + { createdByUserId: "board-user", responsibleUserId: "board-user", claudeLogin: { storedSessionId: null, ownerUserId: "board-user", applyExistingWithoutClaim: false } }, ); }); @@ -1417,7 +1427,7 @@ describe("agent permission routes", () => { model: DEFAULT_OPENCODE_LOCAL_MODEL, }), }), - { createdByUserId: "board-user", claudeLogin: { storedSessionId: null, ownerUserId: "board-user", applyExistingWithoutClaim: false } }, + { createdByUserId: "board-user", responsibleUserId: "board-user", claudeLogin: { storedSessionId: null, ownerUserId: "board-user", applyExistingWithoutClaim: false } }, ); }); @@ -1455,7 +1465,7 @@ describe("agent permission routes", () => { model: "anthropic/claude-sonnet-4-5", }), }), - { createdByUserId: "board-user", claudeLogin: { storedSessionId: null, ownerUserId: "board-user", applyExistingWithoutClaim: false } }, + { createdByUserId: "board-user", responsibleUserId: "board-user", claudeLogin: { storedSessionId: null, ownerUserId: "board-user", applyExistingWithoutClaim: false } }, ); }); @@ -1495,7 +1505,7 @@ describe("agent permission routes", () => { }, }), { - createdByUserId: "board-user", + createdByUserId: "board-user", responsibleUserId: "board-user", claudeLogin: { storedSessionId: null, ownerUserId: "board-user", @@ -1516,9 +1526,10 @@ describe("agent permission routes", () => { status: "idle", }; mockAgentService.getById.mockResolvedValue(pendingAgent); - mockAgentService.activatePendingApproval.mockResolvedValue({ + mockApprovalService.approveHire.mockResolvedValue({ agent: approvedAgent, - activated: true, + applied: true, + approval: null, }); const app = await createApp({ @@ -1534,8 +1545,7 @@ describe("agent permission routes", () => { .send({})); expect(res.status).toBe(200); - expect(mockAgentService.activatePendingApproval).toHaveBeenCalledWith(agentId); - expect(mockApprovalService.approve).not.toHaveBeenCalled(); + expect(mockApprovalService.approveHire).toHaveBeenCalledWith(agentId, "board-user"); expect(mockLogActivity).toHaveBeenCalledWith(expect.anything(), expect.objectContaining({ companyId, actorType: "user", @@ -1556,19 +1566,9 @@ describe("agent permission routes", () => { ...baseAgent, status: "idle", }; - // First getById (getAccessibleAgent) sees the pending agent; the second - // (after the approval resolves) sees the activated agent. - mockAgentService.getById - .mockResolvedValueOnce(pendingAgent) - .mockResolvedValue(approvedAgent); - mockApprovalService.findOpenHireApprovalForAgent.mockResolvedValue({ - id: "approval-1", - companyId, - type: "hire_agent", - status: "pending", - payload: { agentId }, - }); - mockApprovalService.approve.mockResolvedValue({ + mockAgentService.getById.mockResolvedValue(pendingAgent); + mockApprovalService.approveHire.mockResolvedValue({ + agent: approvedAgent, approval: { id: "approval-1", status: "approved" }, applied: true, }); @@ -1587,7 +1587,7 @@ describe("agent permission routes", () => { expect(res.status).toBe(200); // The shared approval flow handles activation; we must not double-activate. - expect(mockApprovalService.approve).toHaveBeenCalledWith("approval-1", "board-user"); + expect(mockApprovalService.approveHire).toHaveBeenCalledWith(agentId, "board-user"); expect(mockAgentService.activatePendingApproval).not.toHaveBeenCalled(); expect(mockLogActivity).toHaveBeenCalledWith(expect.anything(), expect.objectContaining({ action: "agent.approved", @@ -1604,19 +1604,9 @@ describe("agent permission routes", () => { ...baseAgent, status: "terminated", }; - // getAccessibleAgent sees the pending agent; after the rejection resolves - // (which terminates internally) the route re-reads the terminated agent. - mockAgentService.getById - .mockResolvedValueOnce(pendingAgent) - .mockResolvedValue(terminatedAgent); - mockApprovalService.findOpenHireApprovalForAgent.mockResolvedValue({ - id: "approval-1", - companyId, - type: "hire_agent", - status: "pending", - payload: { agentId }, - }); - mockApprovalService.reject.mockResolvedValue({ + mockAgentService.getById.mockResolvedValue(pendingAgent); + mockApprovalService.rejectHire.mockResolvedValue({ + agent: terminatedAgent, approval: { id: "approval-1", status: "rejected" }, applied: true, }); @@ -1639,8 +1629,8 @@ describe("agent permission routes", () => { .send({})); expect(res.status).toBe(200); - expect(mockApprovalService.reject).toHaveBeenCalledWith("approval-1", "board-user"); - // reject() terminates the agent internally; the route must not terminate again. + expect(mockApprovalService.rejectHire).toHaveBeenCalledWith(agentId, "board-user"); + // The hire decision rejects the pending agent; the route must not terminate again. expect(mockAgentService.terminate).not.toHaveBeenCalled(); }); @@ -1670,7 +1660,7 @@ describe("agent permission routes", () => { expect(res.status).toBe(200); expect(mockAgentService.terminate).toHaveBeenCalledWith(agentId); expect(mockApprovalService.findOpenHireApprovalForAgent).not.toHaveBeenCalled(); - expect(mockApprovalService.reject).not.toHaveBeenCalled(); + expect(mockApprovalService.rejectHire).not.toHaveBeenCalled(); }); it("rejects direct approval for agents that are not pending approval", async () => { @@ -1687,7 +1677,7 @@ describe("agent permission routes", () => { .send({})); expect(res.status).toBe(409); - expect(mockAgentService.activatePendingApproval).not.toHaveBeenCalled(); + expect(mockApprovalService.approveHire).not.toHaveBeenCalled(); expect(mockLogActivity).not.toHaveBeenCalledWith(expect.anything(), expect.objectContaining({ action: "agent.approved", })); @@ -1726,7 +1716,7 @@ describe("agent permission routes", () => { expect.objectContaining({ defaultEnvironmentId: environmentId, }), - { createdByUserId: "board-user", claudeLogin: { storedSessionId: null, ownerUserId: "board-user", applyExistingWithoutClaim: false } }, + { createdByUserId: "board-user", responsibleUserId: "board-user", claudeLogin: { storedSessionId: null, ownerUserId: "board-user", applyExistingWithoutClaim: false } }, ); }); @@ -1812,7 +1802,7 @@ describe("agent permission routes", () => { adapterType: adapterCase.adapterType, defaultEnvironmentId: environmentId, }), - { createdByUserId: "board-user", claudeLogin: { storedSessionId: null, ownerUserId: "board-user", applyExistingWithoutClaim: false } }, + { createdByUserId: "board-user", responsibleUserId: "board-user", claudeLogin: { storedSessionId: null, ownerUserId: "board-user", applyExistingWithoutClaim: false } }, ); }); } @@ -2291,3 +2281,12 @@ describe("agent permission routes", () => { expect(mockHeartbeatService.cancelRun).not.toHaveBeenCalled(); }); }); + +vi.mock("../services/agent-lifecycle.js", async (importOriginal) => { + const actual = await importOriginal(); + return { ...actual, createAgentLifecycle: () => ({ + requestHire: (...args: unknown[]) => mockAgentService.create(...args), + approveHire: (...args: unknown[]) => mockAgentService.activatePendingApproval(...args), + terminateAgent: (...args: unknown[]) => mockAgentService.terminate(...args), + }) }; +}); diff --git a/server/src/__tests__/agent-permissions-service.test.ts b/server/src/__tests__/agent-permissions-service.test.ts index 6f8e37e3006..e45ecb944a3 100644 --- a/server/src/__tests__/agent-permissions-service.test.ts +++ b/server/src/__tests__/agent-permissions-service.test.ts @@ -8,7 +8,7 @@ import { defaultAgentPermissions, normalizeAgentPermissions, permissionsImplyLowTrust, -} from "../services/agent-permissions.js"; +} from "../lib/agent-permissions.js"; describe("agent permissions service", () => { it("grants agent-creation authority to new agents by default", () => { diff --git a/server/src/__tests__/agent-persona-persistence.test.ts b/server/src/__tests__/agent-persona-persistence.test.ts index fb39304ddbd..3b1ca4e4c20 100644 --- a/server/src/__tests__/agent-persona-persistence.test.ts +++ b/server/src/__tests__/agent-persona-persistence.test.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "../services/agent-lifecycle.js"; import { randomUUID } from "node:crypto"; import { readFile } from "node:fs/promises"; import { afterAll, beforeAll, describe, expect, it } from "vitest"; @@ -20,15 +21,17 @@ describe("persisted agent personas", () => { afterAll(async () => { await database?.cleanup(); }); it("randomizes once, accepts a saved draft and preserves identity across edits and revision rollback", async () => { const service = agentService(db); - const random = await service.create(companyId, { name: "Random", role: "engineer", adapterType: "process" }); + const serviceLifecycle = createAgentLifecycle(db); + const random = await serviceLifecycle.requestHire(companyId, { name: "Random", role: "engineer", adapterType: "process" }); expect(agentAppearanceSchema.safeParse(random.appearance).success).toBe(true); const appearance = appearanceForPalette("arctic-blue"); - const original = await service.create(companyId, { name: "Draft", role: "engineer", adapterType: "process", appearance }); + const original = await serviceLifecycle.requestHire(companyId, { name: "Draft", role: "engineer", adapterType: "process", appearance }); expect(original.appearance).toEqual(appearance); const updated = await service.update(original.id, { name: "Renamed" }, { recordRevision: { source: "test" } }); expect(updated?.appearance).toEqual(appearance); const [revision] = await service.listConfigRevisions(original.id); - await service.update(original.id, { name: "Changed again", status: "paused" }); + await service.update(original.id, { name: "Changed again" }); + await serviceLifecycle.pauseAgent(original.id); const restored = await service.rollbackConfigRevision(original.id, revision.id, {}); expect(restored?.appearance).toEqual(appearance); expect((await agentService(db).getById(original.id))?.avatarUrl).toContain("/arctic-blue/rest.png?size=512"); diff --git a/server/src/__tests__/agent-skills-routes.test.ts b/server/src/__tests__/agent-skills-routes.test.ts index ae267e9fd43..9f0848f2d52 100644 --- a/server/src/__tests__/agent-skills-routes.test.ts +++ b/server/src/__tests__/agent-skills-routes.test.ts @@ -1005,7 +1005,7 @@ describe("agent skill routes", () => { }), }), }), - { createdByUserId: "local-board", claudeLogin: { storedSessionId: null, ownerUserId: "local-board", applyExistingWithoutClaim: false } }, + { createdByUserId: "local-board", responsibleUserId: "local-board", claudeLogin: { storedSessionId: null, ownerUserId: "local-board", applyExistingWithoutClaim: false } }, ); expect(mockTrackAgentCreated).toHaveBeenCalledWith( expect.anything(), @@ -1055,7 +1055,7 @@ describe("agent skill routes", () => { expect.objectContaining({ role: "security", }), - { createdByUserId: "local-board", claudeLogin: { storedSessionId: null, ownerUserId: "local-board", applyExistingWithoutClaim: false } }, + { createdByUserId: "local-board", responsibleUserId: "local-board", claudeLogin: { storedSessionId: null, ownerUserId: "local-board", applyExistingWithoutClaim: false } }, ); expect(mockTrackAgentCreated).toHaveBeenCalledWith( expect.anything(), @@ -1491,7 +1491,7 @@ describe("agent skill routes", () => { }), }), { - createdByUserId: "local-board", + createdByUserId: "local-board", responsibleUserId: "local-board", claudeLogin: { storedSessionId: null, ownerUserId: "local-board", @@ -1575,3 +1575,10 @@ describe("agent skill routes", () => { expect(mockAgentInstructionsService.materializeManagedBundle).not.toHaveBeenCalled(); }); }); + +vi.mock("../services/agent-lifecycle.js", async (importOriginal) => { + const actual = await importOriginal(); + return { ...actual, createAgentLifecycle: () => ({ + requestHire: (...args: unknown[]) => mockAgentService.create(...args), + }) }; +}); diff --git a/server/src/__tests__/agent-test-environment-routes.test.ts b/server/src/__tests__/agent-test-environment-routes.test.ts index 2c2499e4f34..d78375724ad 100644 --- a/server/src/__tests__/agent-test-environment-routes.test.ts +++ b/server/src/__tests__/agent-test-environment-routes.test.ts @@ -116,10 +116,7 @@ vi.mock("../services/ai-connection-runtime.js", async (importOriginal) => ({ }, })); const mockValidateAiApiKey = vi.hoisted(() => vi.fn(async () => undefined)); -vi.mock("../routes/ai-connections.js", async (importOriginal) => ({ - ...(await importOriginal()), - validateAiApiKey: mockValidateAiApiKey, -})); +vi.mock("../services/ai-api-key-test.js", () => ({ validateAiApiKey: mockValidateAiApiKey })); const mockMarkAuthenticationFailed = vi.hoisted(() => vi.fn(async () => undefined)); vi.mock("../services/ai-connections.js", async (importOriginal) => ({ ...(await importOriginal()), @@ -1030,3 +1027,9 @@ describe("agent test-environment route", () => { }); }); }); + +vi.mock("../services/agent-lifecycle.js", async (importOriginal) => { + const actual = await importOriginal(); + return { ...actual, createAgentLifecycle: () => ({ + }) }; +}); diff --git a/server/src/__tests__/agents-adapter-config-user-secret.test.ts b/server/src/__tests__/agents-adapter-config-user-secret.test.ts index 57a0f8dc06c..e91be3a11ab 100644 --- a/server/src/__tests__/agents-adapter-config-user-secret.test.ts +++ b/server/src/__tests__/agents-adapter-config-user-secret.test.ts @@ -416,3 +416,9 @@ describeEmbeddedPostgres("agents adapter-config user-secret resolution routes", function beforeEachActor(actor: TestActor) { currentActor = actor; } + +vi.mock("../services/agent-lifecycle.js", async (importOriginal) => { + const actual = await importOriginal(); + return { ...actual, createAgentLifecycle: () => ({ + }) }; +}); diff --git a/server/src/__tests__/agents-claude-oauth-binding.test.ts b/server/src/__tests__/agents-claude-oauth-binding.test.ts index 1a133380da3..4d645e6388e 100644 --- a/server/src/__tests__/agents-claude-oauth-binding.test.ts +++ b/server/src/__tests__/agents-claude-oauth-binding.test.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "../services/agent-lifecycle.js"; import { randomUUID } from "node:crypto"; import { mkdirSync, rmSync } from "node:fs"; import os from "node:os"; @@ -362,7 +363,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const scope = await seedScope(); const sessionId = await seedStoredClaim(scope, Date.now() + 60_000); - const created = await agentService(db).create(scope.companyId, createInput(scope), { + const created = await createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: sessionId, ownerUserId: scope.ownerUserId }, }); @@ -376,7 +377,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { // A replay of the same claim inserts no second agent. await expect( - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: sessionId, ownerUserId: scope.ownerUserId }, }), ).rejects.toMatchObject({ message: CLAUDE_OAUTH_CLAIM_REJECTED }); @@ -386,7 +387,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { it("rejects a missing claim and inserts no binding", async () => { const scope = await seedScope(); await expect( - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: undefined, ownerUserId: scope.ownerUserId }, }), ).rejects.toMatchObject({ message: CLAUDE_OAUTH_CLAIM_REJECTED }); @@ -397,7 +398,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const scope = await seedScope(); const sessionId = await seedStoredClaim(scope, Date.now() + 60_000); await expect( - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: sessionId, ownerUserId: "intruder" }, }), ).rejects.toMatchObject({ message: CLAUDE_OAUTH_CLAIM_REJECTED }); @@ -409,7 +410,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const scope = await seedScope(); const sessionId = await seedStoredClaim(scope, Date.now() - 1_000); await expect( - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: sessionId, ownerUserId: scope.ownerUserId }, }), ).rejects.toMatchObject({ message: CLAUDE_OAUTH_CLAIM_REJECTED }); @@ -420,7 +421,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const scope = await seedScope(); const sessionId = await seedStoredClaim(scope, Date.now() + 60_000, "awaiting_code"); await expect( - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: sessionId, ownerUserId: scope.ownerUserId }, }), ).rejects.toMatchObject({ message: CLAUDE_OAUTH_CLAIM_REJECTED }); @@ -432,8 +433,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { // Missing claim. const missingScope = await seedScope(); messages.push( - await agentService(db) - .create(missingScope.companyId, createInput(missingScope), { + await createAgentLifecycle(db).requestHire(missingScope.companyId, createInput(missingScope), { claudeLogin: { storedSessionId: undefined, ownerUserId: missingScope.ownerUserId }, }) .then(() => "no-error") @@ -443,8 +443,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const foreignScope = await seedScope(); const foreignSession = await seedStoredClaim(foreignScope, Date.now() + 60_000); messages.push( - await agentService(db) - .create(foreignScope.companyId, createInput(foreignScope), { + await createAgentLifecycle(db).requestHire(foreignScope.companyId, createInput(foreignScope), { claudeLogin: { storedSessionId: foreignSession, ownerUserId: "intruder" }, }) .then(() => "no-error") @@ -454,8 +453,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const expiredScope = await seedScope(); const expiredSession = await seedStoredClaim(expiredScope, Date.now() - 1_000); messages.push( - await agentService(db) - .create(expiredScope.companyId, createInput(expiredScope), { + await createAgentLifecycle(db).requestHire(expiredScope.companyId, createInput(expiredScope), { claudeLogin: { storedSessionId: expiredSession, ownerUserId: expiredScope.ownerUserId }, }) .then(() => "no-error") @@ -465,8 +463,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const nonStoredScope = await seedScope(); const nonStoredSession = await seedStoredClaim(nonStoredScope, Date.now() + 60_000, "submitting"); messages.push( - await agentService(db) - .create(nonStoredScope.companyId, createInput(nonStoredScope), { + await createAgentLifecycle(db).requestHire(nonStoredScope.companyId, createInput(nonStoredScope), { claudeLogin: { storedSessionId: nonStoredSession, ownerUserId: nonStoredScope.ownerUserId }, }) .then(() => "no-error") @@ -475,12 +472,11 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { // Already consumed. const consumedScope = await seedScope(); const consumedSession = await seedStoredClaim(consumedScope, Date.now() + 60_000); - await agentService(db).create(consumedScope.companyId, createInput(consumedScope), { + await createAgentLifecycle(db).requestHire(consumedScope.companyId, createInput(consumedScope), { claudeLogin: { storedSessionId: consumedSession, ownerUserId: consumedScope.ownerUserId }, }); messages.push( - await agentService(db) - .create(consumedScope.companyId, createInput(consumedScope), { + await createAgentLifecycle(db).requestHire(consumedScope.companyId, createInput(consumedScope), { claudeLogin: { storedSessionId: consumedSession, ownerUserId: consumedScope.ownerUserId }, }) .then(() => "no-error") @@ -495,10 +491,10 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const sessionId = await seedStoredClaim(scope, Date.now() + 60_000); const results = await Promise.allSettled([ - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: sessionId, ownerUserId: scope.ownerUserId }, }), - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: sessionId, ownerUserId: scope.ownerUserId }, }), ]); @@ -536,8 +532,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { }); await locked; - const createPromise = agentService(db) - .create(scope.companyId, createInput(scope), { + const createPromise = createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: sessionId, ownerUserId: scope.ownerUserId }, }) .then(() => "created") @@ -555,7 +550,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { it("removes the fixed binding on a normal update", async () => { const scope = await seedScope(); const sessionId = await seedStoredClaim(scope, Date.now() + 60_000); - const created = await agentService(db).create(scope.companyId, createInput(scope), { + const created = await createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: sessionId, ownerUserId: scope.ownerUserId }, }); @@ -568,7 +563,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { it("re-points the binding to a plain value on a normal update", async () => { const scope = await seedScope(); const sessionId = await seedStoredClaim(scope, Date.now() + 60_000); - const created = await agentService(db).create(scope.companyId, createInput(scope), { + const created = await createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: sessionId, ownerUserId: scope.ownerUserId }, }); @@ -583,7 +578,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { it("removes the binding by a move to another adapter type on a normal update", async () => { const scope = await seedScope(); const sessionId = await seedStoredClaim(scope, Date.now() + 60_000); - const created = await agentService(db).create(scope.companyId, createInput(scope), { + const created = await createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: sessionId, ownerUserId: scope.ownerUserId }, }); @@ -603,7 +598,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { it("keeps an existing binding when the update changes another field", async () => { const scope = await seedScope(); const sessionId = await seedStoredClaim(scope, Date.now() + 60_000); - const created = await agentService(db).create(scope.companyId, createInput(scope), { + const created = await createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { storedSessionId: sessionId, ownerUserId: scope.ownerUserId }, }); @@ -616,7 +611,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { it("rejects a newly introduced binding on update, because it carries no claim", async () => { const scope = await seedScope(); - const created = await agentService(db).create(scope.companyId, { + const created = await createAgentLifecycle(db).requestHire(scope.companyId, { name: "Api Key Agent", role: "engineer", status: "idle", @@ -645,7 +640,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const scope = await seedScope(); await seedStoredOwnerValue(scope); - const created = await agentService(db).create(scope.companyId, createInput(scope), { + const created = await createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { ownerUserId: scope.ownerUserId, applyExistingWithoutClaim: true }, }); @@ -666,9 +661,9 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const scope = await seedScope(); await seedStoredOwnerValue(scope); - const created = await agentService( + const created = await createAgentLifecycle( db, - ).create(scope.companyId, { ...createInput(scope), status: "pending_approval" }, { + ).requestHire(scope.companyId, { ...createInput(scope), status: "pending_approval" }, { claudeLogin: { ownerUserId: scope.ownerUserId, applyExistingWithoutClaim: true }, }); @@ -680,7 +675,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { it("binds the fixed reference on an update from a stored owner value with no claim", async () => { const scope = await seedScope(); await seedStoredOwnerValue(scope); - const created = await agentService(db).create(scope.companyId, { + const created = await createAgentLifecycle(db).requestHire(scope.companyId, { name: "Claude Agent", role: "engineer", status: "idle", @@ -706,7 +701,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const scope = await seedScope(); await expect( - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { ownerUserId: scope.ownerUserId, applyExistingWithoutClaim: true }, }), ).rejects.toMatchObject({ message: CLAUDE_OAUTH_CLAIM_REJECTED }); @@ -723,7 +718,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { // The route sets no owner for an agent actor. The gate rejects the no-claim // bind, so an agent actor never binds the fixed reference. await expect( - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { ownerUserId: null, applyExistingWithoutClaim: true }, }), ).rejects.toMatchObject({ message: CLAUDE_OAUTH_CLAIM_REJECTED }); @@ -739,7 +734,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { foreignScope.ownerUserId = ownerScope.ownerUserId; await expect( - agentService(db).create(foreignScope.companyId, createInput(foreignScope), { + createAgentLifecycle(db).requestHire(foreignScope.companyId, createInput(foreignScope), { claudeLogin: { ownerUserId: foreignScope.ownerUserId, applyExistingWithoutClaim: true }, }), ).rejects.toMatchObject({ message: CLAUDE_OAUTH_CLAIM_REJECTED }); @@ -753,7 +748,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { // The apply-existing flag is set, but the config carries no fixed binding. The // gate mints the fixed reference only when the client presents the exact fixed // binding, so the flag alone binds nothing and creates no fixed definition. - const created = await agentService(db).create( + const created = await createAgentLifecycle(db).requestHire( scope.companyId, { name: "Plain Agent", @@ -781,7 +776,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { // A client adds a secret id and a foreign owner to the binding. The persist // normalization keeps only the fixed reference fields, so the extra selectors // never reach the stored binding. The runtime derives the owner from context. - const created = await agentService(db).create( + const created = await createAgentLifecycle(db).requestHire( scope.companyId, createInput(scope, { CLAUDE_CODE_OAUTH_TOKEN: { @@ -804,7 +799,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { it("resolves the bound reference to the stored value without leaking it in a log", async () => { const scope = await seedScope(); await seedStoredOwnerValue(scope, "sk-secret-resolve"); - const created = await agentService(db).create(scope.companyId, createInput(scope), { + const created = await createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { ownerUserId: scope.ownerUserId, applyExistingWithoutClaim: true }, }); @@ -858,7 +853,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const scope = await seedScope(); const parent = await seedParentAgent(scope); - const created = await agentService(db).create(scope.companyId, createInput(scope), { + const created = await createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { inheritedFromAgentId: parent.id }, }); @@ -871,7 +866,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const scope = await seedScope(); const parent = await seedParentAgent(scope, { version: 5 }); - const created = await agentService(db).create( + const created = await createAgentLifecycle(db).requestHire( scope.companyId, createInput(scope, { CLAUDE_CODE_OAUTH_TOKEN: { ...FIXED_BINDING, version: 5 } }), { claudeLogin: { inheritedFromAgentId: parent.id } }, @@ -890,7 +885,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const parent = await seedParentAgent(scope, { version: 5 }); await expect( - agentService(db).create( + createAgentLifecycle(db).requestHire( scope.companyId, createInput(scope, { CLAUDE_CODE_OAUTH_TOKEN: { ...FIXED_BINDING, version: 2 } }), { claudeLogin: { inheritedFromAgentId: parent.id } }, @@ -906,7 +901,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const parent = await seedParentAgent(scope, { holdsFixedBinding: false }); await expect( - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { inheritedFromAgentId: parent.id }, }), ).rejects.toMatchObject({ message: CLAUDE_OAUTH_CLAIM_REJECTED }); @@ -921,7 +916,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const parent = await seedParentAgent(foreignScope); await expect( - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { inheritedFromAgentId: parent.id }, }), ).rejects.toMatchObject({ message: CLAUDE_OAUTH_CLAIM_REJECTED }); @@ -934,7 +929,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const scope = await seedScope(); await expect( - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { inheritedFromAgentId: randomUUID() }, }), ).rejects.toMatchObject({ message: CLAUDE_OAUTH_CLAIM_REJECTED }); @@ -950,7 +945,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { const parent = await seedParentAgent(scope, { adapterType: "codex_local" }); await expect( - agentService(db).create(scope.companyId, createInput(scope), { + createAgentLifecycle(db).requestHire(scope.companyId, createInput(scope), { claudeLogin: { inheritedFromAgentId: parent.id }, }), ).rejects.toMatchObject({ message: CLAUDE_OAUTH_CLAIM_REJECTED }); @@ -988,8 +983,7 @@ describeEmbeddedPostgres("agent service Claude OAuth binding claim", () => { // The child's copied reference still names version 5, the version the // route read before the rotation started. The create call must wait for // the parent row lock, so it can only proceed once the rotation commits. - const createPromise = agentService(db) - .create( + const createPromise = createAgentLifecycle(db).requestHire( scope.companyId, createInput(scope, { CLAUDE_CODE_OAUTH_TOKEN: { ...FIXED_BINDING, version: 5 } }), { claudeLogin: { inheritedFromAgentId: parent.id } }, diff --git a/server/src/__tests__/agents-pending-approval-config.test.ts b/server/src/__tests__/agents-pending-approval-config.test.ts index 7c02a10da11..28d27e6e66c 100644 --- a/server/src/__tests__/agents-pending-approval-config.test.ts +++ b/server/src/__tests__/agents-pending-approval-config.test.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "../services/agent-lifecycle.js"; import { randomUUID } from "node:crypto"; import { afterAll, afterEach, beforeAll, describe, expect, it } from "vitest"; import { eq } from "drizzle-orm"; @@ -66,8 +67,9 @@ describeEmbeddedPostgres("pending approval agent config integrity", () => { it("freezes generic pending hire config and reapplies the approval snapshot on activation", async () => { const companyId = await seedCompany(); const agentSvc = agentService(db); + const agentSvcLifecycle = createAgentLifecycle(db); const approvalSvc = approvalService(db); - const pending = await agentSvc.create(companyId, { + const pending = await agentSvcLifecycle.requestHire(companyId, { name: "Pending Coder", role: "engineer", title: "Software Engineer", @@ -145,7 +147,8 @@ describeEmbeddedPostgres("pending approval agent config integrity", () => { await approvalSvc.approve(approval.id, "board-user", "Approved generic hire"); await expect(agentSvc.getById(pending.id)).resolves.toMatchObject({ - status: "idle", + status: "paused", + lifecycleState: "preparing", appearance: pending.appearance, name: "Pending Coder", role: "engineer", diff --git a/server/src/__tests__/agents-service-secret-bindings.test.ts b/server/src/__tests__/agents-service-secret-bindings.test.ts index a155bb72ab3..23f24ebaaa5 100644 --- a/server/src/__tests__/agents-service-secret-bindings.test.ts +++ b/server/src/__tests__/agents-service-secret-bindings.test.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "../services/agent-lifecycle.js"; import { randomUUID } from "node:crypto"; import { mkdirSync, rmSync } from "node:fs"; import os from "node:os"; @@ -86,7 +87,7 @@ describeEmbeddedPostgres("agent service secret binding sync", () => { value: "sk-ant-123", }); - const created = await agentService(db).create(companyId, { + const created = await createAgentLifecycle(db).requestHire(companyId, { name: "Claude Novita", role: "engineer", status: "pending_approval", @@ -137,7 +138,7 @@ describeEmbeddedPostgres("agent service secret binding sync", () => { value: "slack-test-token", }); - const created = await agentService(db).create(companyId, { + const created = await createAgentLifecycle(db).requestHire(companyId, { name: "Slack Briefing", role: "briefing", adapterType: "codex_local", @@ -185,7 +186,7 @@ describeEmbeddedPostgres("agent service secret binding sync", () => { }); await expect( - agentService(db).create(companyId, { + createAgentLifecycle(db).requestHire(companyId, { name: "Unlisted Static Lease", role: "engineer", adapterType: "codex_local", @@ -220,7 +221,7 @@ describeEmbeddedPostgres("agent service secret binding sync", () => { const companyId = await seedCompany(); const literalApiKey = `hermes-key-${randomUUID()}`; - const created = await agentService(db).create(companyId, { + const created = await createAgentLifecycle(db).requestHire(companyId, { name: "Hermes Gateway", role: "engineer", status: "idle", @@ -289,7 +290,7 @@ describeEmbeddedPostgres("agent service secret binding sync", () => { value: "next-value", }); - const created = await agentService(db).create(companyId, { + const created = await createAgentLifecycle(db).requestHire(companyId, { name: "Binding Swapper", role: "engineer", adapterType: "codex_local", @@ -359,13 +360,14 @@ describeEmbeddedPostgres("agent service secret binding sync", () => { .where(eq(companySecretBindings.targetId, agentId)); expect(beforeBindings).toHaveLength(0); - const approved = await agentService(db).activatePendingApproval(agentId); + const approved = await createAgentLifecycle(db).approveHire(agentId); expect(approved).toMatchObject({ activated: true, agent: { id: agentId, - status: "idle", + status: "paused", + lifecycleState: "preparing", }, }); @@ -390,7 +392,7 @@ describeEmbeddedPostgres("agent service secret binding sync", () => { const missingSecretId = randomUUID(); await expect( - agentService(db).create(companyId, { + createAgentLifecycle(db).requestHire(companyId, { name: "Broken Create", role: "engineer", adapterType: "claude_local", @@ -420,7 +422,7 @@ describeEmbeddedPostgres("agent service secret binding sync", () => { provider: "local_encrypted", value: "valid-value", }); - const created = await agentService(db).create(companyId, { + const created = await createAgentLifecycle(db).requestHire(companyId, { name: "Transactional Update", role: "engineer", adapterType: "codex_local", @@ -483,7 +485,7 @@ describeEmbeddedPostgres("agent service secret binding sync", () => { permissions: {}, }); - await expect(agentService(db).activatePendingApproval(agentId)).rejects.toBeTruthy(); + await expect(createAgentLifecycle(db).approveHire(agentId)).rejects.toBeTruthy(); const reloaded = await agentService(db).getById(agentId); expect(reloaded?.status).toBe("pending_approval"); diff --git a/server/src/__tests__/approvals-service.test.ts b/server/src/__tests__/approvals-service.test.ts index 47aedf91695..1a4cbfe22d5 100644 --- a/server/src/__tests__/approvals-service.test.ts +++ b/server/src/__tests__/approvals-service.test.ts @@ -2,21 +2,23 @@ import { beforeEach, describe, expect, it, vi } from "vitest"; import { approvalService } from "../services/approvals.ts"; import { companies } from "@paperclipai/db"; -vi.mock("../services/budgets.js", () => ({ +vi.mock("../services/budgets.js", async importOriginal => ({ + ...await importOriginal(), budgetService: () => ({ deliverPendingEnforcement: vi.fn(async () => {}) }), budgetServiceInTransaction: () => ({ upsertPolicy: vi.fn(async () => {}) }), })); const mockAgentService = vi.hoisted(() => ({ activatePendingApproval: vi.fn(), + getById: vi.fn(async () => ({ id: "agent-1" })), create: vi.fn(), terminate: vi.fn(), })); const mockNotifyHireApproved = vi.hoisted(() => vi.fn()); -vi.mock("../services/agents.js", () => ({ - agentService: vi.fn(() => mockAgentService), +vi.mock("../modules/agent-lifecycle/adapters/records.js", () => ({ + agentRecords: vi.fn(() => ({ ...mockAgentService, rejectPendingHire: mockAgentService.terminate })), })); vi.mock("../services/hire-hook.js", () => ({ @@ -114,7 +116,7 @@ describe("approvalService resolution idempotency", () => { const result = await svc.approve("approval-1", "board", "ship it"); expect(result.applied).toBe(true); - expect(mockAgentService.activatePendingApproval).toHaveBeenCalledWith("agent-1", approved.payload); + expect(mockAgentService.activatePendingApproval).toHaveBeenCalledWith("agent-1", approved.payload, approved.requestedByUserId); expect(mockNotifyHireApproved).toHaveBeenCalledTimes(1); }); @@ -161,7 +163,7 @@ describe("approvalService resolution idempotency", () => { expect.objectContaining({ adapterConfig: approved.payload.adapterConfig, }), - { createdByUserId: expectedCreator }, + { createdByUserId: expectedCreator, responsibleUserId: requestedByUserId }, ); }); }); diff --git a/server/src/__tests__/attention-service.test.ts b/server/src/__tests__/attention-service.test.ts index d9d43e4c191..26934470fbd 100644 --- a/server/src/__tests__/attention-service.test.ts +++ b/server/src/__tests__/attention-service.test.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "../services/agent-lifecycle.js"; import { randomUUID } from "node:crypto"; import express from "express"; import request from "supertest"; @@ -795,8 +796,8 @@ describeEmbeddedPostgres("attention service", () => { }, ]); - await agentService(db).pause(pausedReviewerId); - await agentService(db).terminate(terminatedReviewerId); + await createAgentLifecycle(db).pauseAgent(pausedReviewerId); + await createAgentLifecycle(db).terminateAgent(terminatedReviewerId); const feed = await attentionService(db).list(companyId, { userId: "board-user" }); const interactionTitles = feed.items @@ -886,7 +887,7 @@ describeEmbeddedPostgres("attention service", () => { effectiveResolverPolicy: "human_only", payload: { version: 1, questions: [] }, }); - await agentService(db).pause(reviewerId); + await createAgentLifecycle(db).pauseAgent(reviewerId); const feed = await attentionService(db).list(companyId, { userId: "board-user" }); const otherUserFeed = await attentionService(db).list(companyId, { userId: "other-user" }); diff --git a/server/src/__tests__/built-in-agents.test.ts b/server/src/__tests__/built-in-agents.test.ts index 7a90b5b5ecd..920a1c9537c 100644 --- a/server/src/__tests__/built-in-agents.test.ts +++ b/server/src/__tests__/built-in-agents.test.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle, configureAgentLifecycle } from "../services/agent-lifecycle.js"; import fs from "node:fs/promises"; import { fileHash } from "../services/agent-file-store.js"; import { stockHash } from "../services/managed-resource-drift.js"; @@ -9,6 +10,9 @@ import { afterAll, afterEach, beforeAll, describe, expect, it, vi } from "vitest import { and, eq, sql } from "drizzle-orm"; import { activityLog, + heartbeatRuns, + agentWakeupRequests, + routineRuns, agentConfigRevisions, agents, approvals, @@ -35,14 +39,14 @@ import { agentInstructionsService } from "../services/agent-instructions.ts"; import { agentService } from "../services/agents.ts"; import { approvalService } from "../services/approvals.ts"; import { - builtInAgentService, + builtInAgentService as createBuiltInAgentService, deriveBuiltInAgentStatus, listBuiltInAgentDefinitions, readBuiltInTextWithFallback, reconcileBuiltInAgentsOnStartup, validateBuiltInAgentDefinitions, } from "../services/built-in-agents.ts"; -import { readBuiltInAgentMarker, withBuiltInAgentMarker } from "../services/built-in-agent-metadata.ts"; +import { readBuiltInAgentMarker, withBuiltInAgentMarker } from "../lib/built-in-agent-metadata.ts"; import { issueThreadInteractionService } from "../services/issue-thread-interactions.ts"; const embeddedPostgresSupport = await getEmbeddedPostgresTestSupport(); @@ -119,6 +123,22 @@ describe("built-in agent asset loading", () => { describeEmbeddedPostgres("built-in agents", () => { let db!: ReturnType; + let lifecycleWorker: ReturnType; + function builtInAgentService(database: typeof db) { + const service = createBuiltInAgentService(database); + return { ...service, + async ensure(...args: Parameters) { + const result = await service.ensure(...args); + if (result.agentId) await lifecycleWorker.process(result.agentId); + return service.get(args[0], args[1]); + }, + async get(...args: Parameters) { + const result = await service.get(...args); + if (result.agentId) await lifecycleWorker.process(result.agentId); + return service.get(...args); + }, + }; + } let tempDb: Awaited> | null = null; const instructionOperator = { type: "board", userId: "local-board", source: "local_implicit" } as const; async function writeInstructionEntry(agent: { id: string; companyId: string }, entryFile: string, content: string) { @@ -134,9 +154,11 @@ describeEmbeddedPostgres("built-in agents", () => { beforeAll(async () => { tempDb = await startEmbeddedPostgresTestDatabase("paperclip-built-in-agents-"); db = createDb(tempDb.connectionString); + lifecycleWorker = configureAgentLifecycle(db, { requiredPluginIds: async () => [], runPlugin: async () => "complete", runHost: async () => "complete" }); }, 20_000); afterEach(async () => { + await lifecycleWorker.sweep(); await db.delete(routineTriggers); await db.delete(routines); await db.delete(issueThreadInteractions); @@ -158,6 +180,7 @@ describeEmbeddedPostgres("built-in agents", () => { }); afterAll(async () => { + await lifecycleWorker.stop(); await tempDb?.cleanup(); }); @@ -498,7 +521,7 @@ describeEmbeddedPostgres("built-in agents", () => { }); expect(ready.status).toBe("ready"); - await agentService(db).pause(ready.agentId!, "manual"); + await createAgentLifecycle(db).pauseAgent(ready.agentId!, "manual"); await expect(builtIns.get(companyId, "learning")).resolves.toMatchObject({ status: "paused", agentId: ready.agentId, @@ -540,7 +563,7 @@ describeEmbeddedPostgres("built-in agents", () => { warning: null, }); - await agentService(db).pause(ready.agentId!, "maintenance"); + await createAgentLifecycle(db).pauseAgent(ready.agentId!, "maintenance"); await expect(builtIns.requireBuiltInAgent(companyId, "briefs")).resolves.toMatchObject({ agent: { id: ready.agentId }, warning: { @@ -585,7 +608,7 @@ describeEmbeddedPostgres("built-in agents", () => { it("reconciles an enabled Reflection Coach bundle with skill sync and a disabled routine", async () => { const companyId = await seedCompany({ requireApproval: false }); - const root = await agentService(db).create(companyId, { + const root = await createAgentLifecycle(db).requestHire(companyId, { name: "CEO", role: "ceo", status: "idle", @@ -677,7 +700,7 @@ describeEmbeddedPostgres("built-in agents", () => { it("recreates missing managed resource bindings idempotently during concurrent reconcile", async () => { const companyId = await seedCompany({ requireApproval: false }); - await agentService(db).create(companyId, { + await createAgentLifecycle(db).requestHire(companyId, { name: "CEO", role: "ceo", status: "idle", @@ -715,7 +738,7 @@ describeEmbeddedPostgres("built-in agents", () => { it("preserves new-agent approval gates during on-demand Reflection Coach provisioning", async () => { const companyId = await seedCompany({ requireApproval: true }); - const root = await agentService(db).create(companyId, { + const root = await createAgentLifecycle(db).requestHire(companyId, { name: "CEO", role: "ceo", status: "idle", @@ -959,7 +982,7 @@ describeEmbeddedPostgres("built-in agents", () => { it("prevents direct marker add, remove, or mutation", async () => { const companyId = await seedCompany(); const builtIn = await builtInAgentService(db).ensure(companyId, "briefs"); - const normal = await agentService(db).create(companyId, { + const normal = await createAgentLifecycle(db).requestHire(companyId, { name: "Normal", role: "engineer", status: "idle", @@ -969,7 +992,7 @@ describeEmbeddedPostgres("built-in agents", () => { permissions: {}, }); - await expect(agentService(db).create(companyId, { + await expect(createAgentLifecycle(db).requestHire(companyId, { name: "Spoof", role: "engineer", status: "idle", @@ -1222,7 +1245,7 @@ describeEmbeddedPostgres("built-in agents", () => { it("automatically materializes the Reflection Coach bundle without enabling background work", async () => { const companyId = await seedCompany(); - const root = await agentService(db).create(companyId, { + const root = await createAgentLifecycle(db).requestHire(companyId, { name: "CEO", role: "ceo", status: "idle", @@ -1297,7 +1320,7 @@ describeEmbeddedPostgres("built-in agents", () => { it("materializes the Summarizer bundle paused on Claude Haiku with a disabled routine", async () => { const companyId = await seedCompany(); - const root = await agentService(db).create(companyId, { + const root = await createAgentLifecycle(db).requestHire(companyId, { name: "CEO", role: "ceo", status: "idle", @@ -1409,9 +1432,35 @@ describeEmbeddedPostgres("built-in agents", () => { expect(resetFile.content).not.toContain("Operator edit."); }); + it("keeps a built-in routine task while the agent prepares", async () => { + const companyId = await seedCompany({ requireApproval: false }); + const builtIns = createBuiltInAgentService(db); + const created = await builtIns.ensure(companyId, "reflection-coach"); + await lifecycleWorker.stop(); + lifecycleWorker = configureAgentLifecycle(db, { requiredPluginIds: async () => [], runPlugin: async () => "complete", runHost: async () => "pending" }); + try { + const result = await builtIns.runRoutine(companyId, "reflection-coach", "recent-agent-reflection", { userId: "responsible-user" }); + expect(result.status).toBe("issue_created"); + const tasks = await db.select().from(issues).where(eq(issues.companyId, companyId)); + expect(tasks).toHaveLength(1); + expect(tasks[0]!.assigneeAgentId).toBe(created.agentId); + expect(await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.companyId, companyId))) + .toEqual([expect.objectContaining({ status: "queued", agentId: created.agentId })]); + // A second request during setup must not try to resume an already preparing agent. + await expect(builtIns.runRoutine(companyId, "reflection-coach", "recent-agent-reflection", { userId: "responsible-user" })) + .resolves.toHaveProperty("id"); + } finally { + await lifecycleWorker.stop(); + await db.delete(routineRuns).where(eq(routineRuns.companyId, companyId)); + await db.delete(heartbeatRuns).where(eq(heartbeatRuns.companyId, companyId)); + await db.delete(agentWakeupRequests).where(eq(agentWakeupRequests.companyId, companyId)); + lifecycleWorker = configureAgentLifecycle(db, { requiredPluginIds: async () => [], runPlugin: async () => "complete", runHost: async () => "complete" }); + } + }); + it("controls the Reflection Coach routine schedule without enabling it by default", async () => { const companyId = await seedCompany(); - await agentService(db).create(companyId, { + await createAgentLifecycle(db).requestHire(companyId, { name: "CEO", role: "ceo", status: "idle", @@ -1434,7 +1483,8 @@ describeEmbeddedPostgres("built-in agents", () => { "recent-agent-reflection", { userId: "board-user" }, ); - expect(enabled.status).toBe("needs_setup"); + await lifecycleWorker.process(enabled.agentId!); + expect((await builtIns.get(companyId, "reflection-coach")).status).toBe("needs_setup"); expect(enabled.resources.find((resource) => resource.resourceKind === "routine")).toMatchObject({ stockStatus: "stock_current", scheduleEnabled: true, @@ -1462,7 +1512,7 @@ describeEmbeddedPostgres("built-in agents", () => { it("surfaces pending Reflection Coach proposal interactions on the routine resource", async () => { const companyId = await seedCompany(); - await agentService(db).create(companyId, { + await createAgentLifecycle(db).requestHire(companyId, { name: "CEO", role: "ceo", status: "idle", @@ -1515,7 +1565,8 @@ describeEmbeddedPostgres("built-in agents", () => { it("gates Reflection Coach proposal mutations until an accepted follow-up apply step", async () => { const companyId = await seedCompany(); const agentsSvc = agentService(db); - await agentsSvc.create(companyId, { + const agentsSvcLifecycle = createAgentLifecycle(db); + await agentsSvcLifecycle.requestHire(companyId, { name: "CEO", role: "ceo", status: "idle", @@ -1524,7 +1575,7 @@ describeEmbeddedPostgres("built-in agents", () => { runtimeConfig: {}, permissions: {}, }); - const target = await agentsSvc.create(companyId, { + const target = await agentsSvcLifecycle.requestHire(companyId, { name: "Target Coder", role: "engineer", status: "idle", diff --git a/server/src/__tests__/cleanup-removal-service.test.ts b/server/src/__tests__/cleanup-removal-service.test.ts index 68bf1ce2c17..6c7761e2b56 100644 --- a/server/src/__tests__/cleanup-removal-service.test.ts +++ b/server/src/__tests__/cleanup-removal-service.test.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle, configureAgentLifecycle } from "../services/agent-lifecycle.js"; import { randomUUID } from "node:crypto"; import { eq } from "drizzle-orm"; import { afterAll, afterEach, beforeAll, describe, expect, it } from "vitest"; @@ -41,6 +42,7 @@ describeEmbeddedPostgres("cleanup removal services", () => { beforeAll(async () => { tempDb = await startEmbeddedPostgresTestDatabase("paperclip-cleanup-removal-"); db = createDb(tempDb.connectionString); + configureAgentLifecycle(db, { requiredPluginIds: async () => [], runPlugin: async () => "complete", runHost: async () => "complete" }); }, 20_000); afterEach(async () => { @@ -146,6 +148,7 @@ describeEmbeddedPostgres("cleanup removal services", () => { createdByRunId: runId, }); + await db.update(agents).set({ status: "terminated", lifecycleState: "terminated" }).where(eq(agents.id, agentId)); const removed = await agentService(db).remove(agentId); expect(removed?.id).toBe(agentId); diff --git a/server/src/__tests__/companies-service.test.ts b/server/src/__tests__/companies-service.test.ts index aa79a5b93a6..1b7e6fe8b0e 100644 --- a/server/src/__tests__/companies-service.test.ts +++ b/server/src/__tests__/companies-service.test.ts @@ -33,9 +33,10 @@ vi.mock("../services/cloud-lifecycle-sync.js", () => ({ notifyCloudOfPrimaryCompanyLifecycleChange: notifyCloudSpy, })); +import { configureAgentLifecycle } from "../services/agent-lifecycle.js"; import { companyService } from "../services/companies.js"; import { deriveIssuePrefixBase } from "../services/issue-prefix.js"; -import { readBuiltInAgentMarker } from "../services/built-in-agent-metadata.js"; +import { readBuiltInAgentMarker } from "../lib/built-in-agent-metadata.js"; import { builtInAgentService, reconcileBuiltInAgentsOnStartup } from "../services/built-in-agents.js"; const embeddedPostgresSupport = await getEmbeddedPostgresTestSupport(); @@ -49,6 +50,16 @@ if (!embeddedPostgresSupport.supported) { describeEmbeddedPostgres("companyService", () => { let db!: ReturnType; + let lifecycleWorker: ReturnType; + beforeEach(() => { lifecycleWorker = configureAgentLifecycle(db, { requiredPluginIds: async () => [], runPlugin: async () => "complete", runHost: async () => "complete" }); }); + async function insertAgents(input: typeof agents.$inferInsert | Array) { + const rows = Array.isArray(input) ? input : [input]; + await db.insert(agents).values(rows.map(row => ({ ...row, + lifecycleState: ["paused", "pending_approval", "terminated"].includes(row.status ?? "") ? row.status! : "ready", + lifecycleHolds: row.status === "paused" ? [row.pauseReason ?? "manual"] : [], + }))); + } + let tempDb: Awaited> | null = null; beforeAll(async () => { @@ -57,6 +68,7 @@ describeEmbeddedPostgres("companyService", () => { }, 20_000); afterEach(async () => { + await lifecycleWorker.stop(); await db.delete(routineTriggers); await db.delete(routines); await db.delete(builtInManagedResources); @@ -165,7 +177,7 @@ describeEmbeddedPostgres("companyService", () => { requireBoardApprovalForNewAgents: false, }); - await db.insert(agents).values([ + await insertAgents([ { id: runningAgentId, companyId, @@ -335,7 +347,7 @@ describeEmbeddedPostgres("companyService", () => { requireBoardApprovalForNewAgents: false, }); - await db.insert(agents).values([ + await insertAgents([ { id: archivedPausedAgentId, companyId, @@ -382,6 +394,7 @@ describeEmbeddedPostgres("companyService", () => { ); expect(reactivated?.status).toBe("active"); + await lifecycleWorker.process(archivedPausedAgentId); const reactivateActivity = await db .select({ @@ -441,7 +454,7 @@ describeEmbeddedPostgres("companyService", () => { requireBoardApprovalForNewAgents: false, }); - await db.insert(agents).values([ + await insertAgents([ { id: runningAgentId, companyId, @@ -551,7 +564,7 @@ describeEmbeddedPostgres("companyService", () => { requireBoardApprovalForNewAgents: false, }); - await db.insert(agents).values([ + await insertAgents([ { id: archivedPausedAgentId, companyId, @@ -587,6 +600,7 @@ describeEmbeddedPostgres("companyService", () => { ); expect(reactivated?.status).toBe("active"); + await lifecycleWorker.process(archivedPausedAgentId); const rows = await db .select({ id: agents.id, status: agents.status, pauseReason: agents.pauseReason }) @@ -618,7 +632,7 @@ describeEmbeddedPostgres("companyService", () => { requireBoardApprovalForNewAgents: false, }); - await db.insert(agents).values({ + await insertAgents({ id: terminatedAgentId, companyId, name: "Terminated Agent", @@ -661,7 +675,7 @@ describeEmbeddedPostgres("companyService", () => { requireBoardApprovalForNewAgents: false, }); - await db.insert(agents).values({ + await insertAgents({ id: manualPausedAgentId, companyId, name: "Manual Paused Agent", @@ -713,7 +727,7 @@ describeEmbeddedPostgres("companyService", () => { requireBoardApprovalForNewAgents: false, }); - await db.insert(agents).values({ + await insertAgents({ id: agentId, companyId, name: "Idle Agent", @@ -788,7 +802,7 @@ describeEmbeddedPostgres("companyService", () => { requireBoardApprovalForNewAgents: false, }); - await db.insert(agents).values({ + await insertAgents({ id: agentId, companyId, name: "Idle Agent", @@ -863,7 +877,7 @@ describeEmbeddedPostgres("companyService", () => { requireBoardApprovalForNewAgents: false, }); - await db.insert(agents).values({ + await insertAgents({ id: idleAgentId, companyId, name: "Idle Agent", diff --git a/server/src/__tests__/company-portability.test.ts b/server/src/__tests__/company-portability.test.ts index 461da04f268..b5c265a2a96 100644 --- a/server/src/__tests__/company-portability.test.ts +++ b/server/src/__tests__/company-portability.test.ts @@ -122,6 +122,13 @@ vi.mock("../services/agents.js", () => ({ agentService: () => agentSvc, })); +vi.mock("../services/agent-lifecycle.js", () => ({ + createAgentLifecycle: () => ({ + requestHire: (...args: unknown[]) => agentSvc.create(...args), + pauseAgent: vi.fn(), + }), +})); + vi.mock("../services/access.js", () => ({ accessService: () => accessSvc, })); diff --git a/server/src/__tests__/decision-models.test.ts b/server/src/__tests__/decision-models.test.ts index aa3bfbdb4bd..b106157c814 100644 --- a/server/src/__tests__/decision-models.test.ts +++ b/server/src/__tests__/decision-models.test.ts @@ -189,12 +189,16 @@ describe("company decision service", () => { const context: DecisionContext = { companyId: f.companyId, feature: settingsDecisionTest, actor: { type: "agent", agentId: f.agentId, runId, companyId: f.companyId, source: "agent_jwt" } }; const remove = () => agentService(db).remove(f.agentId); + let inFlightDeletionError: unknown; f.provider.mockImplementationOnce(async () => { - await expect(remove()).rejects.toMatchObject({ status: 409, details: { code: "agent_decision_accounting_pending" } }); + // Exercise the accounting guard after lifecycle termination. + await db.update(agents).set({ status: "terminated", lifecycleState: "terminated" }).where(eq(agents.id, f.agentId)); + inFlightDeletionError = await remove().catch(error => error); expect(await f.service.decide(f.context, DECISION_TEST_REQUEST)).toMatchObject({ status: "unavailable", reason: "budget_blocked" }); return { errorCode: "timeout", receipt: decisionReceipt("openai", null) }; }); expect((await f.service.decide(context, DECISION_TEST_REQUEST)).status).toBe("failed"); + expect(inFlightDeletionError).toMatchObject({ status: 409, details: { code: "agent_decision_accounting_pending" } }); await expect(remove()).rejects.toMatchObject({ status: 409, details: { code: "agent_decision_accounting_pending" } }); expect((await db.select().from(budgetReservations).where(eq(budgetReservations.companyId, f.companyId)))[0]).toMatchObject({ state: "held", amountCents: "1.0000000" }); }); diff --git a/server/src/__tests__/dot-invitations.test.ts b/server/src/__tests__/dot-invitations.test.ts index 0a31da0f2fd..84fd5d102c2 100644 --- a/server/src/__tests__/dot-invitations.test.ts +++ b/server/src/__tests__/dot-invitations.test.ts @@ -1,3 +1,8 @@ +import { logActivity } from "../services/activity-log.js"; +vi.mock("../services/activity-log.js", async importOriginal => { + const actual = await importOriginal(); + return { ...actual, logActivity: vi.fn(actual.logActivity) }; +}); import { randomBytes, randomUUID } from "node:crypto"; import { mkdtemp, rm } from "node:fs/promises"; import { tmpdir } from "node:os"; @@ -38,7 +43,8 @@ it("atomically resumes one pending invite across retries and never persists a pa const service = dotInvitationService(db); const [a, b] = await Promise.all([service.create(f.companyId, f.userId), service.create(f.companyId, f.userId)]); expect(a.agent.id).toBe(b.agent.id); - expect(a.agent.status).toBe("idle"); + expect(a.agent.status).toBe("paused"); + expect((await db.select().from(agents).where(eq(agents.id, a.agent.id)))[0]!.lifecycleState).toBe("preparing"); expect(await service.resume(f.companyId, f.userId)).toMatchObject({ agent: { id: a.agent.id } }); expect(await service.resume(f.companyId, randomUUID())).toBeNull(); expect(await db.select().from(agents).where(eq(agents.companyId, f.companyId))).toHaveLength(1); @@ -47,6 +53,26 @@ it("atomically resumes one pending invite across retries and never persists a pa expect(JSON.stringify(logs)).not.toContain(code.pairingCode); expect(JSON.stringify(await service.resume(f.companyId, f.userId))).not.toContain(code.pairingCode); }); +it("reuses a committed hire when invitation completion must retry", async () => { + const f = await fixture(true); + const actual = await vi.importActual("../services/activity-log.js"); + vi.mocked(logActivity).mockImplementation(async (...args) => { + if (args[1].action === "agent.hire_created") { + vi.mocked(logActivity).mockImplementation(actual.logActivity); + throw new Error("Invitation audit unavailable"); + } + return actual.logActivity(...args); + }); + const service = dotInvitationService(db); + await expect(service.create(f.companyId, f.userId)).rejects.toThrow("Invitation audit unavailable"); + const before = await db.select().from(agents).where(eq(agents.companyId, f.companyId)); + expect(before).toHaveLength(1); + expect(await service.resume(f.companyId, f.userId)).toBeNull(); + const retried = await service.create(f.companyId, f.userId); + expect(retried.agent.id).toBe(before[0]!.id); + expect(await db.select().from(approvals).where(eq(approvals.companyId, f.companyId))).toHaveLength(1); + expect(await db.select().from(agents).where(eq(agents.companyId, f.companyId))).toHaveLength(1); +}); it("honors hiring approval before issuing a pairing capability", async () => { const f = await fixture(true); const invite = await dotInvitationService(db).create(f.companyId, f.userId); @@ -91,7 +117,7 @@ it("keeps invite routes company-scoped and denies viewers and agent actors", asy expect(result.status, JSON.stringify(result.body)).toBe(200); expect(result.body.agent.id).toBeTruthy(); expect((await request(app).get(path)).body.agent.id).toBe(result.body.agent.id); - expect(await db.select().from(agents).where(and(eq(agents.companyId, f.companyId), eq(agents.status, "idle")))).toHaveLength(1); + expect(await db.select().from(agents).where(and(eq(agents.companyId, f.companyId), eq(agents.lifecycleState, "preparing")))).toHaveLength(1); }); it("does not trust editable agent metadata as an invitation ownership receipt", async () => { diff --git a/server/src/__tests__/dot-oauth-onboarding.test.ts b/server/src/__tests__/dot-oauth-onboarding.test.ts index 2f88ebeda2d..53e24b56067 100644 --- a/server/src/__tests__/dot-oauth-onboarding.test.ts +++ b/server/src/__tests__/dot-oauth-onboarding.test.ts @@ -4,7 +4,7 @@ import express from "express"; import request from "supertest"; import { and, eq, sql } from "drizzle-orm"; import { afterAll, beforeAll, beforeEach, describe, expect, it, vi } from "vitest"; -import { createDb, authUsers, companies, companyMemberships, agents, dotAgentBindings, mcpOauthGrants, mcpOauthRequests, mcpOauthTokens } from "@paperclipai/db"; +import { createDb, authUsers, companies, companyMemberships, agents, dotAgentBindings, dotMailboxItems, mcpEventSubscriptions, mcpOauthGrants, mcpOauthRequests, mcpOauthTokens } from "@paperclipai/db"; import { startEmbeddedPostgresTestDatabase } from "./helpers/embedded-postgres.js"; import { createPublicMcpOAuth, publicMcpConfig, hashMcpSecret, DEVICE_GRANT } from "../services/public-mcp/oauth.js"; import { instanceSettingsService } from "../services/instance-settings.js"; @@ -22,12 +22,12 @@ describe("Dot onboarding with an operator-issued pairing capability", () => { }, 120000); beforeEach(async () => { await instanceSettingsService(db).updateExperimental({ enablePublicMcp: true, enableOpenAiDot: true, enableNativeRunner: false }); }); afterAll(async () => { await temp?.cleanup(); }); - async function fixture(authorizationOrigin?: string) { + async function fixture(authorizationOrigin?: string, lifecycleState = "ready") { const userId = randomUUID(); await db.insert(authUsers).values({ id: userId, name: "Operator", email: userId + "@example.test", createdAt: new Date(), updatedAt: new Date() }); const [company] = await db.insert(companies).values({ name: "Dot onboarding", issuePrefix: "DO" + randomBytes(3).toString("hex") }).returning(); await db.insert(companyMemberships).values({ companyId: company!.id, principalType: "user", principalId: userId, membershipRole: "owner", status: "active" }); - const [agent] = await db.insert(agents).values({ companyId: company!.id, name: "Dot", adapterType: "paperclip_runner", adapterConfig: { provider: "openai_dot" }, status: "active" }).returning(); + const [agent] = await db.insert(agents).values({ companyId: company!.id, name: "Dot", adapterType: "paperclip_runner", adapterConfig: { provider: "openai_dot" }, lifecycleState, status: lifecycleState === "ready" ? "active" : "paused" }).returning(); const oauth = createPublicMcpOAuth(db, { ...config, ...(authorizationOrigin ? { authorizationOrigin } : {}) }); const client = await oauth.register({ client_name: "Dot", redirect_uris: [callback], grant_types: ["authorization_code", "refresh_token", DEVICE_GRANT] }, randomUUID()); const verifier = randomBytes(32).toString("base64url"); @@ -43,6 +43,49 @@ describe("Dot onboarding with an operator-issued pairing capability", () => { return f.oauth.token({ grant_type: "authorization_code", client_id: f.client.client_id, redirect_uri: callback, resource: config.resource, code: new URL(consent.redirectUrl).searchParams.get("code"), code_verifier: f.verifier }); } + + it("invalidates setup when a broker pairing is applied or revoked", async () => { + const f = await fixture(undefined, "preparing"); + const consent = await f.oauth.consent(f.id, { type: "board", source: "session", userId: f.userId }, + { decision: "approve", companyId: f.company.id, allowWrites: false }); + const tokens = await f.oauth.token({ grant_type: "authorization_code", client_id: f.client.client_id, + redirect_uri: callback, resource: config.resource, code: new URL(consent.redirectUrl).searchParams.get("code"), code_verifier: f.verifier }); + const principal = await f.oauth.authenticate(tokens.access_token); + const broker = dotRunnerBroker(db); + await broker.pair(principal, f.pairing.pairingCode); + const [paired] = await db.select().from(agents).where(eq(agents.id, f.agent.id)); + expect(paired.adapterConfig.dotBindingId).toBe(f.pairing.bindingId); + expect(paired.lifecycleVersion).toBe(f.agent.lifecycleVersion + 1); + await expect(broker.pair(principal, f.pairing.pairingCode)).rejects.toThrow("Pairing code expired or was consumed"); + + await broker.revoke(f.company.id, f.agent.id, f.userId); + const [revoked] = await db.select().from(agents).where(eq(agents.id, f.agent.id)); + expect(revoked.adapterConfig).not.toHaveProperty("dotBindingId"); + expect(revoked.lifecycleVersion).toBe(paired.lifecycleVersion + 1); + await expect(f.oauth.authenticate(tokens.access_token)).rejects.toThrow(); + }); + it.each(["preparing", "verifying"])("allows Dot setup during %s without allowing task access", async (state) => { + const f = await fixture(undefined, state); + const tokens = await connect(f); + const principal = await f.oauth.authenticate(tokens.access_token); + const broker = dotRunnerBroker(db); + await db.insert(mcpEventSubscriptions).values({ id: randomUUID(), companyId: f.company.id, + grantId: principal.grant.id, name: "paperclip.dot.mailbox_updated", bindingId: f.pairing.bindingId, + arguments: {}, deliveryMaterial: {}, verifiedAt: new Date(), expiresAt: new Date(Date.now() + 60_000) }); + await db.insert(dotMailboxItems).values({ companyId: f.company.id, bindingId: f.pairing.bindingId, + bindingGeneration: 1, kind: "assignment", sourceEventId: randomUUID(), references: { task: "hidden" } }); + await broker.challenge(f.company.id, f.agent.id); + const inbox = await broker.mailbox(principal); + expect(inbox.items.map(item => item.kind)).toEqual(["readiness_challenge"]); + expect(inbox.nextCursor).toBe(0); + await expect(broker.confirmChallenge(principal, String(inbox.items[0]!.references.challenge))).resolves.toEqual({ status: "ready" }); + expect(await broker.capabilities(principal)).toMatchObject({ ready: false }); + await expect(broker.tasks(principal)).rejects.toThrow("authority"); + await expect(broker.snapshot(f.company.id, f.agent.id, f.pairing.bindingId)).rejects.toThrow("authority"); + await db.update(agents).set({ lifecycleState: "paused" }).where(eq(agents.id, f.agent.id)); + expect((await broker.mailbox(principal)).items).toEqual([]); + await expect(broker.confirmChallenge(principal, "already-used")).rejects.toThrow("authority"); + }); it("refreshes a Dot connection after years of inactivity, still rotates and revokes on replay", async () => { const f = await fixture(); const tokens = await connect(f); diff --git a/server/src/__tests__/environment-runtime.test.ts b/server/src/__tests__/environment-runtime.test.ts index b683491a828..0d3a2a76ddc 100644 --- a/server/src/__tests__/environment-runtime.test.ts +++ b/server/src/__tests__/environment-runtime.test.ts @@ -12,6 +12,7 @@ import { stopSshEnvLabFixture, } from "@paperclipai/adapter-utils/ssh"; import { + activityLog, costEvents, agents, builtInManagedResources, @@ -219,6 +220,7 @@ describeEmbeddedPostgres("environmentRuntimeService", () => { await stopSshEnvLabFixture(path.join(root, "state.json")).catch(() => undefined); await rm(root, { recursive: true, force: true }).catch(() => undefined); } + await db.delete(activityLog); await db.delete(environmentLeases); await db.delete(issues); await db.delete(costEvents); @@ -5780,6 +5782,21 @@ describeEmbeddedPostgres("environmentRuntimeService", () => { }); }); + it("destroys a failed retained lease when the agent stops", async () => { + const { lease, workerManager, runtimeWithPlugin, runId } = await seedStaleLifecycleReusableLease("retain_on_failure"); + await db.update(heartbeatRuns).set({ status: "failed", finishedAt: new Date() }).where(eq(heartbeatRuns.id, runId)); + await runtimeWithPlugin.releaseRunLeases(runId, "failed"); + await expect(environmentService(db).getLeaseById(lease.id)).resolves.toMatchObject({ status: "retained", cleanupStatus: "failed" }); + vi.mocked(workerManager.getWorker).mockReturnValue({ supportedMethods: ["environmentDestroyLease"] } as never); + vi.mocked(workerManager.call).mockResolvedValue({ providerLeaseId: lease.providerLeaseId, state: "destroyed" }); + const { heartbeatService } = await import("../services/heartbeat.js"); + const stopped = await heartbeatService(db, { pluginWorkerManager: workerManager }) + .stopInvocationsForAgents([lease.metadata!.agentId as string], "Agent lifecycle stop requested"); + expect(stopped).toBe(true); + expect(workerManager.call).toHaveBeenCalledWith(expect.any(String), "environmentDestroyLease", expect.objectContaining({ providerLeaseId: lease.providerLeaseId }), expect.any(Number)); + await expect(environmentService(db).getLeaseById(lease.id)).resolves.toMatchObject({ status: "expired", cleanupStatus: "success" }); + }); + it("fails closed on expiry destruction when the worker no longer advertises the destroy lifecycle method", async () => { const { pluginId, lease, workerManager, runtimeWithPlugin } = await seedStaleLifecycleReusableLease(); diff --git a/server/src/__tests__/heartbeat-process-recovery.test.ts b/server/src/__tests__/heartbeat-process-recovery.test.ts index f02983143ee..a4bde74c6ce 100644 --- a/server/src/__tests__/heartbeat-process-recovery.test.ts +++ b/server/src/__tests__/heartbeat-process-recovery.test.ts @@ -9046,7 +9046,7 @@ describeEmbeddedPostgres("heartbeat orphaned process recovery", () => { expect(mockTerminateLocalService).toHaveBeenCalledWith( expect.objectContaining({ pid: 81_501, processGroupId: 81_502 }), - { forceAfterMs: 3000 }, + { forceAfterMs: 3000, signal: "SIGINT" }, ); expect(runningProcesses.has(runId)).toBe(false); }); diff --git a/server/src/__tests__/heartbeat-stale-queue-invalidation.test.ts b/server/src/__tests__/heartbeat-stale-queue-invalidation.test.ts index 4711ad72c29..a8c7882c71b 100644 --- a/server/src/__tests__/heartbeat-stale-queue-invalidation.test.ts +++ b/server/src/__tests__/heartbeat-stale-queue-invalidation.test.ts @@ -216,6 +216,26 @@ describeEmbeddedPostgres("heartbeat stale queued-run invalidation", () => { return { companyId, agentId }; } + it.each(["preparing", "verifying", "resuming"] as const)("keeps assigned work queued through %s, including recovery with timers disabled", async lifecycleState => { + const { companyId, agentId } = await seedCompanyAndAgent({ heartbeatConfig: { enabled: false } }); + await db.update(agents).set({ status: "paused", lifecycleState }).where(eq(agents.id, agentId)); + const [issue] = await db.insert(issues).values({ companyId, title: "Work accepted during setup", status: "todo", assigneeAgentId: agentId }).returning(); + const run = await heartbeat.wakeup(agentId, { source: "assignment", triggerDetail: "system", reason: "issue_assigned", + requestedByActorType: "system", payload: { issueId: issue.id } }); + expect(run?.status).toBe("queued"); + await heartbeat.resumeQueuedRuns(); + expect((await heartbeat.getRun(run!.id))?.status).toBe("queued"); + expect(countExecuteCallsForRun(run!.id)).toBe(0); + expect((await heartbeat.reconcileStrandedAssignedIssues()).escalated).toBe(0); + expect((await db.select().from(issues).where(eq(issues.id, issue.id)))[0]).toMatchObject({ status: "todo", assigneeAgentId: agentId }); + await db.update(agents).set({ status: "idle", lifecycleState: "ready" }).where(eq(agents.id, agentId)); + const recovered = heartbeatService(db, { runtimeEnv: { ...process.env, PAPERCLIP_IN_WORKTREE: "false" } }); + await recovered.resumeQueuedRuns(); + expect(await waitForCondition(async () => countExecuteCallsForRun(run!.id) === 1)).toBe(true); + await recovered.waitForRunExecutionDrain(run!.id); + expect(countExecuteCallsForRun(run!.id)).toBe(1); + }); + async function seedQueuedRun(input: { companyId: string; agentId: string; diff --git a/server/src/__tests__/invite-create-route.test.ts b/server/src/__tests__/invite-create-route.test.ts index 27372692df2..e6241153fc9 100644 --- a/server/src/__tests__/invite-create-route.test.ts +++ b/server/src/__tests__/invite-create-route.test.ts @@ -7,6 +7,10 @@ const canUserMock = vi.fn(); const insertMock = vi.fn(); function registerModuleMocks() { + vi.doMock("../services/agent-lifecycle.js", () => ({ + createAgentLifecycle: () => ({}), + AgentLifecycleConflict: class extends Error {}, + })); vi.doMock("../services/index.js", () => ({ accessService: () => ({ isInstanceAdmin: vi.fn(), diff --git a/server/src/__tests__/invite-join-grants.test.ts b/server/src/__tests__/invite-join-grants.test.ts index 63c614e66d2..c514e5d9184 100644 --- a/server/src/__tests__/invite-join-grants.test.ts +++ b/server/src/__tests__/invite-join-grants.test.ts @@ -8,7 +8,7 @@ import { normalizeHumanRole, resolveHumanInviteRole, } from "../services/company-member-roles.js"; -import { NEW_STANDARD_AGENT_DEFAULT_GRANT_KEYS, newStandardAgentGrantScope } from "../services/agent-permissions.js"; +import { NEW_STANDARD_AGENT_DEFAULT_GRANT_KEYS, newStandardAgentGrantScope } from "../lib/agent-permissions.js"; const invitedAgentId = "agent-1"; const defaultAgentGrants = NEW_STANDARD_AGENT_DEFAULT_GRANT_KEYS.map((permissionKey) => ({ diff --git a/server/src/__tests__/issue-thread-interactions-service.test.ts b/server/src/__tests__/issue-thread-interactions-service.test.ts index 887b0ea711d..c6c0b072540 100644 --- a/server/src/__tests__/issue-thread-interactions-service.test.ts +++ b/server/src/__tests__/issue-thread-interactions-service.test.ts @@ -1031,6 +1031,7 @@ describeEmbeddedPostgres("issueThreadInteractionService", () => { { agentId: creatorAgentId }, ); + await db.update(agents).set({ lifecycleState: "terminated", status: "terminated" }).where(eq(agents.id, addresseeAgentId)); await agentService(db).remove(addresseeAgentId); const cancelled = await interactionsSvc.getById(created.id); diff --git a/server/src/__tests__/onboarding-seed-route.test.ts b/server/src/__tests__/onboarding-seed-route.test.ts index 766d8c9668f..a7d75aa3c49 100644 --- a/server/src/__tests__/onboarding-seed-route.test.ts +++ b/server/src/__tests__/onboarding-seed-route.test.ts @@ -208,7 +208,9 @@ describeEmbeddedPostgres("POST /api/companies/:companyId/onboarding-seed", () => expect(companyGoals[0]?.title).toBe("Make robotics boring"); expect(companyGoals[0]?.description).toBe("Boring enough that hospitals buy it."); // No agent and no task were sent, so none were invented. - expect(await ctx.db.select().from(agents).where(eq(agents.companyId, companyId))).toHaveLength(0); + const committedAgents = await ctx.db.select().from(agents).where(eq(agents.companyId, companyId)); + expect(committedAgents).toHaveLength(0); + expect(await ctx.db.select().from(projects).where(eq(projects.companyId, companyId))).toHaveLength(0); expect(await ctx.db.select().from(issues).where(eq(issues.companyId, companyId))).toHaveLength(0); expect(response.body.agentId).toBeNull(); expect(response.body.issueId).toBeNull(); @@ -245,12 +247,7 @@ describeEmbeddedPostgres("POST /api/companies/:companyId/onboarding-seed", () => expect(entries).toHaveLength(1); }); - it("rolls the whole seed back when the audit entry cannot be written", async () => { - // The audit entry shares the seed's transaction, so a failure to write it - // must leave nothing behind. The alternative — commit the seed and lose the - // entry — is unrecoverable: Cloud stops retrying on a 2xx, and a later - // replay reports `changed: false` and never logs, so the entry would be - // permanently absent. + it("reuses the committed hire after the content transaction fails", async () => { const { companyId, app } = await seedCompany(); // Injected at the module boundary, not on `ctx.db`: the audit write goes @@ -261,18 +258,20 @@ describeEmbeddedPostgres("POST /api/companies/:companyId/onboarding-seed", () => const failed = await post(app, companyId, SEED); expect(failed.status).toBeGreaterThanOrEqual(500); - // Nothing committed: no seed record, so Cloud has no acknowledged revision - // and keeps retrying, and no orphaned agent from the rolled-back attempt. + // The failed content transaction must not acknowledge the revision. expect( await ctx.db .select() .from(companyOnboardingSeeds) .where(eq(companyOnboardingSeeds.companyId, companyId)), ).toHaveLength(0); - expect(await ctx.db.select().from(agents).where(eq(agents.companyId, companyId))).toHaveLength(0); + const committedAgents = await ctx.db.select().from(agents).where(eq(agents.companyId, companyId)); + expect(committedAgents).toHaveLength(1); + expect(await ctx.db.select().from(projects).where(eq(projects.companyId, companyId))).toHaveLength(0); - // And the retry recovers completely — seed applied, entry present. await post(app, companyId, SEED).expect(200); + expect((await ctx.db.select().from(agents).where(eq(agents.companyId, companyId))).map(agent => agent.id)) + .toEqual(committedAgents.map(agent => agent.id)); expect( await ctx.db .select() @@ -299,7 +298,9 @@ describeEmbeddedPostgres("POST /api/companies/:companyId/onboarding-seed", () => const response = await post(strangerApp, companyId, SEED); expect(response.status).toBe(403); - expect(await ctx.db.select().from(agents).where(eq(agents.companyId, companyId))).toHaveLength(0); + const committedAgents = await ctx.db.select().from(agents).where(eq(agents.companyId, companyId)); + expect(committedAgents).toHaveLength(0); + expect(await ctx.db.select().from(projects).where(eq(projects.companyId, companyId))).toHaveLength(0); expect(await ctx.db.select().from(companyOnboardingSeeds)).toHaveLength(0); }); diff --git a/server/src/__tests__/openapi-routes.test.ts b/server/src/__tests__/openapi-routes.test.ts index cd8cdded1bb..ed79f9537f1 100644 --- a/server/src/__tests__/openapi-routes.test.ts +++ b/server/src/__tests__/openapi-routes.test.ts @@ -279,6 +279,15 @@ function loadSpecRoutes() { } describe("openapi routes", () => { + it("documents only writable agent update fields and lifecycle status requests", () => { + const document = buildOpenApiSpec() as any; + const properties = document.paths["/api/agents/{id}"].patch.requestBody.content["application/json"].schema.properties; + expect(properties).not.toHaveProperty("spentMonthlyCents"); + expect(properties.status.enum).toEqual(["paused", "idle", "terminated"]); + expect(properties).toHaveProperty("name"); + expect(properties).toHaveProperty("budgetMonthlyCents"); + }); + it("documents manager-only task privacy hints without protected scope identity", () => { const spec = buildOpenApiSpec() as any; const operation = spec.paths["/api/issues/{id}/privacy-constraints"].get; diff --git a/server/src/__tests__/plugin-idle-rpc.test.ts b/server/src/__tests__/plugin-idle-rpc.test.ts index c1e626c1b88..a60365612ea 100644 --- a/server/src/__tests__/plugin-idle-rpc.test.ts +++ b/server/src/__tests__/plugin-idle-rpc.test.ts @@ -21,6 +21,18 @@ function fixture(definition: PluginDefinition, rpcTimeoutMs = 30_000) { } describe("plugin idle RPC", () => { + it("advertises and dispatches the agent lifecycle method", async () => { + const request = { companyId: "company", agentId: "agent", operationId: "operation", version: 7, phase: "preparing" }; + const f = fixture({ async setup() {}, async onAgentLifecycle(input) { + expect(input).toEqual(request); + return { operationId: input.operationId, version: input.version, status: "pending" }; + } }); + try { + expect((await f.initialize()).result.supportedMethods).toContain("agentLifecycle"); + expect((await f.call("agentLifecycle", request)).result).toEqual({ operationId: "operation", version: 7, status: "pending" }); + } finally { f.close(); } + }); + const hold = () => ({ ownerId: "idle-owner", expiresAt: Date.now() + 30_000 }); it("seals an idle worker, fences stale releases, and restores normal calls", async () => { diff --git a/server/src/__tests__/plugin-managed-agents.test.ts b/server/src/__tests__/plugin-managed-agents.test.ts index 95abe9db66d..a1661fef5e4 100644 --- a/server/src/__tests__/plugin-managed-agents.test.ts +++ b/server/src/__tests__/plugin-managed-agents.test.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle, configureAgentLifecycle } from "../services/agent-lifecycle.js"; import { randomUUID } from "node:crypto"; import { promises as fs } from "node:fs"; import os from "node:os"; @@ -256,11 +257,15 @@ describeEmbeddedPostgres("plugin-managed agents", () => { it("keeps an explicit resume durable across managed-agent reconcile", async () => { const { companyId, services } = await seedCompanyAndPlugin({ manifest: pausedManifest() }); const created = await services.agents.managedReconcile({ companyId, agentKey: "wiki-maintainer" }); - await agentService(db).resume(created.agentId!); + await createAgentLifecycle(db).resumeAgent(created.agentId!); const reconciled = await services.agents.managedReconcile({ companyId, agentKey: "wiki-maintainer" }); - expect(reconciled.agent).toMatchObject({ + expect(reconciled.agent).toMatchObject({ lifecycleState: "resuming", pauseReason: null }); + const worker = configureAgentLifecycle(db, { requiredPluginIds: async () => [], runPlugin: async () => "complete", runHost: async () => "complete" }); + await worker.process(created.agentId!); + await worker.stop(); + expect((await services.agents.managedReconcile({ companyId, agentKey: "wiki-maintainer" })).agent).toMatchObject({ status: "idle", pauseReason: null, pausedAt: null, diff --git a/server/src/__tests__/primary-agent.test.ts b/server/src/__tests__/primary-agent.test.ts index 1f4f6f6a514..a8adb69a2dd 100644 --- a/server/src/__tests__/primary-agent.test.ts +++ b/server/src/__tests__/primary-agent.test.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "../services/agent-lifecycle.js"; import { randomUUID } from "node:crypto"; import { readFile } from "node:fs/promises"; import express from "express"; @@ -42,7 +43,7 @@ if (!support.supported) console.warn(`Primary agent database tests unavailable: await db.insert(companyMemberships).values(["user-a", "user-b", "explicit"].map(principalId => ({ companyId: id, principalType: "user", principalId, status: "active", membershipRole: "admin" }))); return id; } - const create = (companyId: string, name: string, userId?: string) => agentService(db).create(companyId, { + const create = (companyId: string, name: string, userId?: string) => createAgentLifecycle(db).requestHire(companyId, { name, adapterType: "process", status: "idle", }, { createdByUserId: userId }); const get = (companyId: string, userId = "user-a") => primaryAgentService(db).get(companyId, userId); @@ -123,9 +124,9 @@ if (!support.supported) console.warn(`Primary agent database tests unavailable: it("retains paused/error primaries, clears on leave, rejoins when chosen, and preserves stars", async () => { const c = await company(); const a = await create(c, "Maia", "user-a"); - await agentService(db).pause(a.id); + await createAgentLifecycle(db).pauseAgent(a.id); expect((await get(c)).primaryAgentId).toBe(a.id); - await agentService(db).update(a.id, { status: "error" }); + await db.update(agents).set({ status: "error", lifecycleState: "ready", lifecycleHolds: [] }).where(eq(agents.id, a.id)); expect((await get(c)).primaryAgentId).toBe(a.id); const memberships = resourceMembershipService(db); await memberships.updateAgent({ companyId: c, userId: "user-a", agentId: a.id, state: "left", actor: actor(c) }); @@ -153,23 +154,24 @@ if (!support.supported) console.warn(`Primary agent database tests unavailable: it("clears terminated/deleted primaries and rejects terminated targets and explicit removal", async () => { const c = await company(); const a = await create(c, "Maia", "user-a"); - await agentService(db).terminate(a.id); + await createAgentLifecycle(db).terminateAgent(a.id); expect(await get(c)).toMatchObject({ primaryAgentId: null, initialized: true }); await request(app(actor(c))).put(url(c)).send({ primaryAgentId: a.id }).expect(422); await request(app(actor(c))).put(url(c)).send({ primaryAgentId: null }).expect(400); const b = await create(c, "Alex", "user-a"); expect((await get(c)).primaryAgentId).toBeNull(); await request(app(actor(c))).put(url(c)).send({ primaryAgentId: b.id }).expect(200); + await db.update(agents).set({ status: "terminated", lifecycleState: "terminated" }).where(eq(agents.id, b.id)); await agentService(db).remove(b.id); expect(await get(c)).toMatchObject({ primaryAgentId: null, initialized: true }); }); - it("rolls creation and initialization back together", async () => { + it("rejects creation inside a caller transaction", async () => { const c = await company(); await expect(db.transaction(async tx => { - await agentService(tx as unknown as typeof db).create(c, { name: "Rolled back", adapterType: "process" }, { createdByUserId: "user-a" }); + await createAgentLifecycle(tx as unknown as typeof db).requestHire(c, { name: "Rolled back", adapterType: "process" }, { createdByUserId: "user-a" }); throw new Error("rollback"); - })).rejects.toThrow("rollback"); + })).rejects.toThrow("root database"); expect(await get(c)).toMatchObject({ primaryAgentId: null, initialized: false }); expect(await db.select().from(agents).where(eq(agents.companyId, c))).toHaveLength(0); }); @@ -177,7 +179,7 @@ if (!support.supported) console.warn(`Primary agent database tests unavailable: it("backfills the earliest human event, leaves gone/terminated originals empty, and preserves explicit preferences", async () => { const c = await company(); const first = await create(c, "First"), later = await create(c, "Later"); const terminated = await create(c, "Terminated"); - await agentService(db).terminate(terminated.id); + await createAgentLifecycle(db).terminateAgent(terminated.id); const events = [ ["human", first.id, "user", 1], ["human", later.id, "user", 2], ["gone", randomUUID(), "user", 1], ["gone", later.id, "user", 2], diff --git a/server/src/__tests__/resource-lifecycle-events.test.ts b/server/src/__tests__/resource-lifecycle-events.test.ts index 95aae83d32b..dd54856dfd1 100644 --- a/server/src/__tests__/resource-lifecycle-events.test.ts +++ b/server/src/__tests__/resource-lifecycle-events.test.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle, configureAgentLifecycle } from "../services/agent-lifecycle.js"; import { randomUUID } from "node:crypto"; import { readFileSync } from "node:fs"; import { eq, sql } from "drizzle-orm"; @@ -22,23 +23,29 @@ describePostgres("Resource lifecycle events", () => { let database: Awaited>; let db: Db; let companyId: string; + let worker: ReturnType; beforeAll(async () => { database = await startEmbeddedPostgresTestDatabase("paperclip-resource-events-"); db = createDb(database.connectionString); }, 90_000); - afterAll(async () => { await database?.cleanup(); }); + afterAll(async () => { await worker?.stop(); await database?.cleanup(); }); beforeEach(async () => { vi.stubEnv("PAPERCLIP_MANAGED_CONFIG", undefined); vi.stubEnv("PAPERCLIP_CLOUD_TENANT_SERVER_TOKEN", undefined); + await worker?.stop(); + worker = configureAgentLifecycle(db, { requiredPluginIds: async () => [], runPlugin: async () => "complete", runHost: async () => "complete" }); companyId = randomUUID(); await db.insert(companies).values({ id: companyId, name: "Lifecycle fixture", issuePrefix: `L${companyId.replaceAll("-", "").slice(0, 6)}` }); }); afterEach(() => { vi.unstubAllEnvs(); }); const events = () => db.select().from(resourceLifecycleEvents).where(eq(resourceLifecycleEvents.companyId, companyId)); - const createAgent = (status: "idle" | "pending_approval" | "terminated" = "idle", database: Db = db) => - agentService(database).create(companyId, { name: "Lifecycle agent", adapterType: "process", adapterConfig: {}, status }); + const createAgent = async (status: "idle" | "pending_approval" | "terminated" = "idle", database: Db = db) => { + const agent = await createAgentLifecycle(database).requestHire(companyId, { name: "Lifecycle agent", adapterType: "process", adapterConfig: {}, status }); + await worker.process(agent.id); + return (await agentService(db).getById(agent.id))!; + }; const createPlugin = async () => { const [plugin] = await db.insert(plugins).values({ pluginKey: randomUUID(), packageName: "lifecycle-fixture", version: "1.0.0", status: "ready", manifestJson: {} as never }).returning(); return plugin; @@ -56,7 +63,7 @@ describePostgres("Resource lifecycle events", () => { const approval = await approvalService(db).create(companyId, { type: "hire_agent", status: "pending", payload: { agentId: agent.id } }); await approvalService(db).approve(approval.id, "fixture-board"); await approvalService(db).approve(approval.id, "fixture-board"); - await agentService(db).activatePendingApproval(agent.id); + await createAgentLifecycle(db).approveHire(agent.id); expect(await events()).toEqual([expect.objectContaining({ resourceType: "agent", resourceId: agent.id })]); }); @@ -64,6 +71,7 @@ describePostgres("Resource lifecycle events", () => { const approval = await approvalService(db).create(companyId, { type: "hire_agent", status: "pending", payload: { name: "Legacy hire", adapterType: "process" } }); await approvalService(db).approve(approval.id, "fixture-board"); const [intent] = await events(); + if (intent) await worker.process(intent.resourceId); expect(intent?.resourceType).toBe("agent"); expect(await agentService(db).getById(intent!.resourceId)).toMatchObject({ status: "idle", companyId }); }); @@ -111,25 +119,32 @@ describePostgres("Resource lifecycle events", () => { it("records every pause/resume cycle and termination in resource order, without duplicate hooks", async () => { const agent = await createAgent(); const service = agentService(db); + const serviceLifecycle = createAgentLifecycle(db); await db.insert(agentApiKeys).values({ agentId: agent.id, companyId, name: "Lifecycle key", keyHash: "fixture-hash" }); - await Promise.all(Array.from({ length: 4 }, () => service.pause(agent.id))); - await Promise.all(Array.from({ length: 4 }, () => service.resume(agent.id))); - await service.update(agent.id, { status: "paused" }); - await service.update(agent.id, { status: "idle" }); - await Promise.all(Array.from({ length: 4 }, () => service.terminate(agent.id))); + await Promise.all(Array.from({ length: 4 }, () => serviceLifecycle.pauseAgent(agent.id))); + await worker.process(agent.id); + await Promise.all(Array.from({ length: 4 }, () => serviceLifecycle.resumeAgent(agent.id))); + await worker.process(agent.id); + await serviceLifecycle.pauseAgent(agent.id); + await worker.process(agent.id); + await worker.process(agent.id); + await serviceLifecycle.resumeAgent(agent.id); + await worker.process(agent.id); + await worker.process(agent.id); + await Promise.all(Array.from({ length: 4 }, () => serviceLifecycle.terminateAgent(agent.id))); const rows = (await events()).sort((a, b) => a.id - b.id); expect(rows.map(row => row.action)).toEqual(["create", "pause", "resume", "pause", "resume", "terminate"]); expect(rows.every(row => row.resourceId === agent.id)).toBe(true); const [key] = await db.select().from(agentApiKeys).where(eq(agentApiKeys.agentId, agent.id)); expect(key.revokedAt).not.toBeNull(); - await expect(service.pause(agent.id)).rejects.toMatchObject({ status: 409 }); - await expect(service.resume(agent.id)).rejects.toMatchObject({ status: 409 }); + await expect(serviceLifecycle.pauseAgent(agent.id)).rejects.toMatchObject({ name: "AgentLifecycleConflict" }); + await expect(serviceLifecycle.resumeAgent(agent.id)).rejects.toMatchObject({ name: "AgentLifecycleConflict" }); }); it("does not bypass pending hire approval with pause or resume", async () => { const agent = await createAgent("pending_approval"); - await expect(agentService(db).pause(agent.id)).rejects.toMatchObject({ status: 409 }); - await expect(agentService(db).resume(agent.id)).rejects.toMatchObject({ status: 409 }); + await expect(createAgentLifecycle(db).pauseAgent(agent.id)).rejects.toMatchObject({ name: "AgentLifecycleConflict" }); + await expect(createAgentLifecycle(db).resumeAgent(agent.id)).rejects.toMatchObject({ name: "AgentLifecycleConflict" }); expect(await events()).toEqual([]); }); @@ -142,6 +157,7 @@ describePostgres("Resource lifecycle events", () => { await service.evaluateCostEvent(event); expect(await agentService(db).getById(agent.id)).toMatchObject({ status: "paused", pauseReason: "budget" }); await service.upsertPolicy(companyId, { scopeType: "agent", scopeId: agent.id, amount: 200 }, "fixture-board"); + await worker.process(agent.id); expect(await agentService(db).getById(agent.id)).toMatchObject({ status: "idle", pauseReason: null }); expect((await events()).sort((a, b) => a.id - b.id).map(row => row.action)).toEqual(["create", "pause", "resume"]); }); @@ -149,14 +165,15 @@ describePostgres("Resource lifecycle events", () => { it("rolls back pause, resume, termination, and key revocation if a hook write fails", async () => { const agent = await createAgent(); const paused = await createAgent(); - await agentService(db).pause(paused.id); + await createAgentLifecycle(db).pauseAgent(paused.id); + await worker.process(paused.id); await db.insert(agentApiKeys).values({ agentId: agent.id, companyId, name: "Retained key", keyHash: "fixture-retained-hash" }); const before = await events(); await db.execute(sql`ALTER TABLE resource_lifecycle_events ADD CONSTRAINT fixture_reject_hook CHECK (false) NOT VALID`); try { - await expect(agentService(db).pause(agent.id)).rejects.toThrow(); - await expect(agentService(db).resume(paused.id)).rejects.toThrow(); - await expect(agentService(db).terminate(agent.id)).rejects.toThrow(); + await expect(createAgentLifecycle(db).pauseAgent(agent.id)).rejects.toThrow(); + await expect(createAgentLifecycle(db).resumeAgent(paused.id)).rejects.toThrow(); + await expect(createAgentLifecycle(db).terminateAgent(agent.id)).rejects.toThrow(); expect(await agentService(db).getById(agent.id)).toMatchObject({ status: "idle" }); expect(await agentService(db).getById(paused.id)).toMatchObject({ status: "paused" }); const [key] = await db.select().from(agentApiKeys).where(eq(agentApiKeys.agentId, agent.id)); @@ -172,7 +189,8 @@ describePostgres("Resource lifecycle events", () => { const projectId = randomUUID(); await expect(db.transaction(async tx => { const txDb = tx as unknown as Db; - await agentService(txDb).create(companyId, { id: agentId, name: "Rolled back agent" }); + await tx.insert(agents).values({ id: agentId, companyId, name: "Rolled back agent" }); + await recordResourceCreationEvent(txDb, companyId, "agent", agentId); await projectService(txDb).createWithRepositories(companyId, { id: projectId, name: "Rolled back project" }, []); throw new Error("rollback fixture"); })).rejects.toThrow("rollback fixture"); @@ -387,8 +405,10 @@ describePostgres("Resource lifecycle events", () => { const first = await createPlugin(); const second = await createPlugin(); const agent = await createAgent(); - await agentService(db).pause(agent.id); - await agentService(db).resume(agent.id); + await createAgentLifecycle(db).pauseAgent(agent.id); + await worker.process(agent.id); + await createAgentLifecycle(db).resumeAgent(agent.id); + await worker.process(agent.id); const journal = (await events()).sort((a, b) => a.id - b.id); const inbox = pluginLifecycleInbox(db, first.id); const [event] = await inbox.list(companyId); @@ -426,7 +446,8 @@ describePostgres("Resource lifecycle events", () => { const plugin = await createPlugin(); const inbox = pluginLifecycleInbox(db, plugin.id); await db.transaction(async tx => { - const low = await agentService(tx as unknown as Db).create(companyId, { name: "Delayed commit" }); + const [low] = await tx.insert(agents).values({ companyId, name: "Delayed commit" }).returning(); + await recordResourceCreationEvent(tx as unknown as Db, companyId, "agent", low.id); const high = await createAgent(); const [visible] = await inbox.list(companyId); expect(visible.resourceId).toBe(high.id); diff --git a/server/src/__tests__/secret-proposals-routes.test.ts b/server/src/__tests__/secret-proposals-routes.test.ts index 124c8fcabc6..3354345e4f4 100644 --- a/server/src/__tests__/secret-proposals-routes.test.ts +++ b/server/src/__tests__/secret-proposals-routes.test.ts @@ -335,7 +335,7 @@ describeEmbeddedPostgres("secret proposal routes", () => { ]); }); - it("requires agent JWT and atomically cascade-approves a secret plus binding with dual audits", async () => { + it("requires agent JWT and approves a secret before its binding with dual audits", async () => { const fixture = await seedRun(); const denied = await request(createAgentApp(fixture, "agent_key")) .post("/api/agents/me/secret-proposals") @@ -475,6 +475,46 @@ describeEmbeddedPostgres("secret proposal routes", () => { ]); }); + it("keeps an approved secret after binding fails and reuses it on retry", async () => { + const fixture = await seedRun(); + const agentApp = createAgentApp(fixture); + const boardApp = createBoardApp(fixture); + const secret = await request(agentApp).post("/api/agents/me/secret-proposals").send({ + kind: "secret", name: "dev/retry/token", value: "retry-fixture", justification: "Needed by task", + }); + const binding = await request(agentApp).post("/api/agents/me/secret-proposals").send({ + kind: "binding", secretProposalId: secret.body.id, configPath: "env.RETRY_TOKEN", justification: "Use saved secret", + }); + expect(secret.status).toBe(201); + expect(binding.status).toBe(201); + await db.update(agents).set({ adapterConfig: { env: { RETRY_TOKEN: "existing-value" } } }) + .where(eq(agents.id, fixture.agentId)); + const approve = () => request(boardApp) + .post(`/api/companies/${fixture.companyId}/secret-proposals/${binding.body.id}/approve`).send({ cascade: true }); + + expect((await approve()).status).toBe(409); + const [saved] = await db.select().from(companySecrets); + expect(saved).toMatchObject({ name: "dev/retry/token", status: "active" }); + expect(await db.select().from(companySecretProposals)).toEqual(expect.arrayContaining([ + expect.objectContaining({ id: secret.body.id, status: "approved", createdSecretId: saved.id, valueCiphertext: null }), + expect.objectContaining({ id: binding.body.id, status: "pending" }), + ])); + expect(await db.select().from(companySecretBindings)).toHaveLength(0); + expect((await db.select().from(agents))[0].adapterConfig).toEqual({ env: { RETRY_TOKEN: "existing-value" } }); + expect((await db.select().from(issueThreadInteractions))[0].status).toBe("pending"); + + await db.update(agents).set({ adapterConfig: {} }).where(eq(agents.id, fixture.agentId)); + expect((await approve()).status).toBe(200); + expect(await db.select().from(companySecrets)).toHaveLength(1); + expect(await db.select().from(companySecretVersions)).toHaveLength(1); + expect(await db.select().from(companySecretBindings)).toEqual([ + expect.objectContaining({ secretId: saved.id, targetId: fixture.agentId, configPath: "env.RETRY_TOKEN" }), + ]); + const history = await db.select().from(activityLog); + expect(history.filter(row => row.action === "secret.created")).toHaveLength(1); + expect(history.filter(row => row.action === "secret.proposal.approved")).toHaveLength(2); + }); + it("approves a binding without cascade after its secret proposal was approved separately", async () => { const fixture = await seedRun(); const agentApp = createAgentApp(fixture); @@ -1446,7 +1486,7 @@ describeEmbeddedPostgres("secret proposal routes", () => { ])); }); - it("holds the org graph stable until binding approval commits", async () => { + it("rechecks the org graph after secret approval commits", async () => { const fixture = await seedRun(); const targetAgentId = randomUUID(); await db.insert(agents).values({ @@ -1532,8 +1572,9 @@ describeEmbeddedPostgres("secret proposal routes", () => { expect(reorgFinished).toBe(false); const approval = await approvalPromise; - expect(approval.status).toBe(200); await reorgPromise; + expect(approval.status).toBe(409); + expect(approval.body.error).toContain("chain-of-command policy"); } finally { await db.execute(sql.raw(` DROP TRIGGER IF EXISTS paperclip_test_pause_secret_approval ON company_secrets; @@ -1541,9 +1582,12 @@ describeEmbeddedPostgres("secret proposal routes", () => { `)); } - expect(await db.select().from(companySecretBindings)).toEqual([ - expect.objectContaining({ targetId: targetAgentId, configPath: "access.CONCURRENT_REORG_TOKEN" }), - ]); + expect(await db.select().from(companySecretBindings)).toHaveLength(0); + expect(await db.select().from(companySecrets)).toHaveLength(1); + expect(await db.select().from(companySecretProposals)).toEqual(expect.arrayContaining([ + expect.objectContaining({ id: secretProposal.body.id, status: "approved", valueCiphertext: null }), + expect.objectContaining({ id: bindingProposal.body.id, status: "pending" }), + ])); expect(await db.select({ reportsTo: agents.reportsTo }).from(agents).where(eq(agents.id, targetAgentId))) .toEqual([{ reportsTo: null }]); }); diff --git a/server/src/__tests__/status-cards.test.ts b/server/src/__tests__/status-cards.test.ts index f0aef9e6da8..e1436666316 100644 --- a/server/src/__tests__/status-cards.test.ts +++ b/server/src/__tests__/status-cards.test.ts @@ -27,7 +27,7 @@ import { } from "@paperclipai/shared"; import { errorHandler } from "../middleware/index.js"; import { statusCardRoutes } from "../routes/status-cards.js"; -import { withBuiltInAgentMarker } from "../services/built-in-agent-metadata.js"; +import { withBuiltInAgentMarker } from "../lib/built-in-agent-metadata.js"; import { instanceSettingsService } from "../services/instance-settings.js"; import type { IssueAssignmentWakeupDeps } from "../services/issue-assignment-wakeup.js"; import { issueService } from "../services/issues.js"; diff --git a/server/src/__tests__/summary-slots.test.ts b/server/src/__tests__/summary-slots.test.ts index ac9fba3bff5..77f32cc0827 100644 --- a/server/src/__tests__/summary-slots.test.ts +++ b/server/src/__tests__/summary-slots.test.ts @@ -20,7 +20,7 @@ import { startEmbeddedPostgresTestDatabase, } from "./helpers/embedded-postgres.js"; import { summarySlotService } from "../services/summary-slots.ts"; -import { withBuiltInAgentMarker } from "../services/built-in-agent-metadata.ts"; +import { withBuiltInAgentMarker } from "../lib/built-in-agent-metadata.ts"; import { issueService } from "../services/issues.ts"; const embeddedPostgresSupport = await getEmbeddedPostgresTestSupport(); diff --git a/server/src/app.ts b/server/src/app.ts index 1697f311303..fdf1d385dee 100644 --- a/server/src/app.ts +++ b/server/src/app.ts @@ -1,5 +1,7 @@ import { createDeliveryWorkCoordinator } from "./services/delivery-work-coordinator.js"; import { DELIVERY_QUEUES } from "./services/delivery-work-notifications.js"; +import { createLifecycleDriver } from "./services/agent-lifecycle-driver.js"; +import { startAgentLifecycle } from "./services/agent-lifecycle.js"; import { idleAdmissionMiddleware, trackIdleRequestHandlers } from "./middleware/idle-admission.js"; import { isIdleTaskDrainActive, trackIdleWork } from "./services/task-admission.js"; import { customerSuccessRoutes } from "./routes/customer-success.js"; @@ -622,6 +624,8 @@ export async function createApp( const hostServicesDisposers = new Map void>(); const workerManager = opts.pluginWorkerManager ?? createPluginWorkerManager(); + let lifecyclePluginsReady = false; + const agentLifecycle = startAgentLifecycle(db, createLifecycleDriver(db, workerManager), () => lifecyclePluginsReady && !isWarmStandby() && !isIdleTaskDrainActive()); const connectionIntentHeartbeat = heartbeatService(db, { pluginWorkerManager: workerManager, }); @@ -1358,6 +1362,7 @@ export async function createApp( logger.error({ err }, "Failed to load ready plugins on startup"); }); app.locals.bundledPluginsStartup = trackIdleWork(bundledPluginsStartup); + void bundledPluginsStartup.then(() => { lifecyclePluginsReady = true; return agentLifecycle.sweep(); }).catch(() => logger.warn("Agent lifecycle recovery failed; retrying.")); // The shutdown hook runs at most once. It caches the in-flight promise, so a // second caller (for example the `exit` handler) awaits the same completion // instead of starting a second teardown. @@ -1368,6 +1373,7 @@ export async function createApp( // The scheduler tick queries the database. Stop it here, inside the // awaited teardown, so no tick runs after the caller ends the pool. scheduler.stop(); + await agentLifecycle.stop(); await publicMcpEvents?.stop(); await dotMcpEvents?.stop(); jobCoordinator.stop(); diff --git a/server/src/services/agent-permissions.ts b/server/src/lib/agent-permissions.ts similarity index 100% rename from server/src/services/agent-permissions.ts rename to server/src/lib/agent-permissions.ts diff --git a/server/src/lib/agent-records.ts b/server/src/lib/agent-records.ts new file mode 100644 index 00000000000..da1702f5955 --- /dev/null +++ b/server/src/lib/agent-records.ts @@ -0,0 +1,473 @@ +import { createHash, randomBytes } from "node:crypto"; +import { and, eq, gte, inArray, lt, sql } from "drizzle-orm"; +import { agents, costEvents, type Db } from "@paperclipai/db"; +import { + agentAppearanceSchema, resolveAgentAppearance, agentAvatarUrl, + AGENT_DEFAULT_MAX_CONCURRENT_RUNS, agentRuntimeConfigSchema, getAgentWorkEligibility, + normalizeAgentUrlKey, type AgentEligibilityAgent, +} from "@paperclipai/shared"; +import { conflict, notFound, unprocessable } from "../errors.js"; +import { REDACTED_EVENT_VALUE, sanitizeRecord } from "../redaction.js"; +import { normalizeAgentPermissions } from "./agent-permissions.js"; +import { builtInAgentMarkersEqual, readBuiltInAgentMarker } from "./built-in-agent-metadata.js"; + +export function hashToken(token: string) { + return createHash("sha256").update(token).digest("hex"); +} + +export function createToken() { + return `pcp_${randomBytes(24).toString("hex")}`; +} + +const CONFIG_REVISION_FIELDS = [ + "name", + "role", + "title", + "icon", + "appearance", + "reportsTo", + "capabilities", + "adapterType", + "adapterConfig", + "runtimeConfig", + "defaultEnvironmentId", + "budgetMonthlyCents", + "metadata", +] as const; + +type ConfigRevisionField = (typeof CONFIG_REVISION_FIELDS)[number]; +type AgentConfigSnapshot = Pick; + +export interface RevisionMetadata { + createdByAgentId?: string | null; + createdByUserId?: string | null; + source?: string; + rolledBackFromRevisionId?: string | null; +} + +/** + * The Claude login context for an agent write. The route derives the owner user + * from the authenticated actor, not from the request body, and forwards the + * non-secret `storedSessionId` claim from a completed Claude login session. A + * controlled internal override permits a migration or an administrator repair to + * bind or unbind the fixed OAuth token without a claim. + * + * The `applyExistingWithoutClaim` field is the user-actor apply-existing path. + * The route sets it only for an authenticated user actor and derives the owner + * from that actor. The path binds the fixed reference to the owner stored value + * with no login round trip. It is distinct from `allowInternalBindingOverride`, + * which does no ownership check. + * + * The `inheritedFromAgentId` field is the hire-inheritance path. The route + * sets it only for an authenticated agent actor whose hire request inherited + * the fixed reference from that named parent. The service re-reads the parent + * agent inside the write transaction and binds the fixed reference only when + * the parent exists, is in the same company, is a `claude_local` agent, and + * already holds the exact fixed binding. + */ +export interface ClaudeLoginContext { + storedSessionId?: string | null; + ownerUserId?: string | null; + allowInternalBindingOverride?: boolean; + applyExistingWithoutClaim?: boolean; + inheritedFromAgentId?: string | null; +} + +export interface UpdateAgentOptions { + recordRevision?: RevisionMetadata; + allowBuiltInAgentMetadata?: boolean; + allowPendingApprovalConfigUpdate?: boolean; + claudeLogin?: ClaudeLoginContext; +} + +export type CreateAgentData = Omit; +export type AgentConfigurationRecord = typeof agents.$inferSelect; +export const AGENT_CONFIGURATION_FIELDS = [...CONFIG_REVISION_FIELDS, "permissions"] as const; +export type AgentConfigurationPatch = Partial>; +export type AgentHireRecord = Pick; + +export interface CreateAgentOptions { + responsibleUserId?: string | null; + createdByUserId?: string | null; + aiConnectionInstall?: { connectionId: string; memberConnectionIds?: string[]; createdByUserId: string | null }; + allowBuiltInAgentMetadata?: boolean; + claudeLogin?: ClaudeLoginContext; +} + +interface AgentShortnameRow { + id: string; + name: string; + status: string; +} + +interface AgentShortnameCollisionOptions { + excludeAgentId?: string | null; +} + +export function isPlainRecord(value: unknown): value is Record { + return typeof value === "object" && value !== null && !Array.isArray(value); +} + +export function jsonEqual(left: unknown, right: unknown): boolean { + return JSON.stringify(left) === JSON.stringify(right); +} + +export function buildConfigSnapshot( + row: Pick, +): AgentConfigSnapshot { + const adapterConfig = + typeof row.adapterConfig === "object" && row.adapterConfig !== null && !Array.isArray(row.adapterConfig) + ? sanitizeRecord(row.adapterConfig as Record) + : {}; + const runtimeConfig = + typeof row.runtimeConfig === "object" && row.runtimeConfig !== null && !Array.isArray(row.runtimeConfig) + ? sanitizeRecord(row.runtimeConfig as Record) + : {}; + const metadata = + typeof row.metadata === "object" && row.metadata !== null && !Array.isArray(row.metadata) + ? sanitizeRecord(row.metadata as Record) + : row.metadata ?? null; + return { + name: row.name, + role: row.role, + title: row.title, + icon: row.icon, + appearance: row.appearance, + reportsTo: row.reportsTo, + capabilities: row.capabilities, + adapterType: row.adapterType, + adapterConfig, + runtimeConfig, + defaultEnvironmentId: row.defaultEnvironmentId, + budgetMonthlyCents: row.budgetMonthlyCents, + metadata, + }; +} + +export function containsRedactedMarker(value: unknown): boolean { + if (value === REDACTED_EVENT_VALUE) return true; + if (Array.isArray(value)) return value.some((item) => containsRedactedMarker(item)); + if (typeof value !== "object" || value === null) return false; + return Object.values(value as Record).some((entry) => containsRedactedMarker(entry)); +} + +export function hasConfigPatchFields(data: Partial) { + return CONFIG_REVISION_FIELDS.some((field) => Object.prototype.hasOwnProperty.call(data, field)); +} + +export function changedPendingApprovalConfigFields( + existing: Omit, + data: Partial, +) { + return CONFIG_REVISION_FIELDS.filter((field) => + Object.prototype.hasOwnProperty.call(data, field) && !jsonEqual(data[field], existing[field]), + ); +} + +export function configPatchFromApprovalPayload(payload: Record) { + const patch: Partial = {}; + if (typeof payload.name === "string") patch.name = payload.name; + if (typeof payload.role === "string") patch.role = payload.role; + if (payload.appearance != null) patch.appearance = agentAppearanceSchema.parse(payload.appearance); + if (Object.prototype.hasOwnProperty.call(payload, "title")) { + patch.title = typeof payload.title === "string" ? payload.title : null; + } + if (Object.prototype.hasOwnProperty.call(payload, "icon")) { + patch.icon = typeof payload.icon === "string" ? payload.icon : null; + } + if (Object.prototype.hasOwnProperty.call(payload, "reportsTo")) { + patch.reportsTo = typeof payload.reportsTo === "string" ? payload.reportsTo : null; + } + if (Object.prototype.hasOwnProperty.call(payload, "capabilities")) { + patch.capabilities = typeof payload.capabilities === "string" ? payload.capabilities : null; + } + if (typeof payload.adapterType === "string") patch.adapterType = payload.adapterType; + if (isPlainRecord(payload.adapterConfig)) patch.adapterConfig = payload.adapterConfig; + if (isPlainRecord(payload.runtimeConfig)) patch.runtimeConfig = payload.runtimeConfig; + if (Object.prototype.hasOwnProperty.call(payload, "defaultEnvironmentId")) { + patch.defaultEnvironmentId = + typeof payload.defaultEnvironmentId === "string" ? payload.defaultEnvironmentId : null; + } + if (typeof payload.budgetMonthlyCents === "number") { + patch.budgetMonthlyCents = payload.budgetMonthlyCents; + } + if (Object.prototype.hasOwnProperty.call(payload, "metadata")) { + patch.metadata = isPlainRecord(payload.metadata) ? payload.metadata : null; + } + if (isPlainRecord(payload.permissions)) { + patch.permissions = payload.permissions; + } + return patch; +} + +function parseFiniteNumberLike(value: unknown): number | null { + if (typeof value === "number" && Number.isFinite(value)) return value; + if (typeof value !== "string") return null; + const parsed = Number(value.trim()); + return Number.isFinite(parsed) ? parsed : null; +} + +export function normalizeRuntimeConfigForNewAgent(runtimeConfig: unknown): Record { + const normalizedRuntimeConfig = isPlainRecord(runtimeConfig) ? { ...runtimeConfig } : {}; + const heartbeat = isPlainRecord(normalizedRuntimeConfig.heartbeat) + ? { ...normalizedRuntimeConfig.heartbeat } + : {}; + if (parseFiniteNumberLike(heartbeat.maxConcurrentRuns) == null) { + heartbeat.maxConcurrentRuns = AGENT_DEFAULT_MAX_CONCURRENT_RUNS; + } + normalizedRuntimeConfig.heartbeat = heartbeat; + return normalizedRuntimeConfig; +} + +export function diffConfigSnapshot( + before: AgentConfigSnapshot, + after: AgentConfigSnapshot, +): string[] { + return CONFIG_REVISION_FIELDS.filter((field) => !jsonEqual(before[field], after[field])); +} + +export function configPatchFromSnapshot(snapshot: unknown): Partial { + if (!isPlainRecord(snapshot)) throw unprocessable("Invalid revision snapshot"); + + if (typeof snapshot.name !== "string" || snapshot.name.length === 0) { + throw unprocessable("Invalid revision snapshot: name"); + } + if (typeof snapshot.role !== "string" || snapshot.role.length === 0) { + throw unprocessable("Invalid revision snapshot: role"); + } + if (typeof snapshot.adapterType !== "string" || snapshot.adapterType.length === 0) { + throw unprocessable("Invalid revision snapshot: adapterType"); + } + if (typeof snapshot.budgetMonthlyCents !== "number" || !Number.isFinite(snapshot.budgetMonthlyCents)) { + throw unprocessable("Invalid revision snapshot: budgetMonthlyCents"); + } + const runtimeConfig = agentRuntimeConfigSchema.safeParse( + isPlainRecord(snapshot.runtimeConfig) ? snapshot.runtimeConfig : {}, + ); + if (!runtimeConfig.success) { + throw unprocessable("Invalid revision snapshot: runtimeConfig"); + } + + return { + name: snapshot.name, + role: snapshot.role, + title: typeof snapshot.title === "string" || snapshot.title === null ? snapshot.title : null, + reportsTo: + typeof snapshot.reportsTo === "string" || snapshot.reportsTo === null ? snapshot.reportsTo : null, + capabilities: + typeof snapshot.capabilities === "string" || snapshot.capabilities === null + ? snapshot.capabilities + : null, + adapterType: snapshot.adapterType, + adapterConfig: isPlainRecord(snapshot.adapterConfig) ? snapshot.adapterConfig : {}, + runtimeConfig: runtimeConfig.data, + defaultEnvironmentId: + typeof snapshot.defaultEnvironmentId === "string" || snapshot.defaultEnvironmentId === null + ? snapshot.defaultEnvironmentId + : null, + budgetMonthlyCents: Math.max(0, Math.floor(snapshot.budgetMonthlyCents)), + metadata: isPlainRecord(snapshot.metadata) || snapshot.metadata === null ? snapshot.metadata : null, + }; +} + +export function hasAgentShortnameCollision( + candidateName: string, + existingAgents: AgentShortnameRow[], + options?: AgentShortnameCollisionOptions, +): boolean { + const candidateShortname = normalizeAgentUrlKey(candidateName); + if (!candidateShortname) return false; + + return existingAgents.some((agent) => { + if (agent.status === "terminated") return false; + if (options?.excludeAgentId && agent.id === options.excludeAgentId) return false; + return normalizeAgentUrlKey(agent.name) === candidateShortname; + }); +} + +export function deduplicateAgentName( + candidateName: string, + existingAgents: AgentShortnameRow[], +): string { + if (!hasAgentShortnameCollision(candidateName, existingAgents)) { + return candidateName; + } + for (let i = 2; i <= 100; i++) { + const suffixed = `${candidateName} ${i}`; + if (!hasAgentShortnameCollision(suffixed, existingAgents)) { + return suffixed; + } + } + return `${candidateName} ${Date.now()}`; +} + +export function agentRecordQueries(db: Db) { + function currentUtcMonthWindow(now = new Date()) { + const year = now.getUTCFullYear(); + const month = now.getUTCMonth(); + return { + start: new Date(Date.UTC(year, month, 1, 0, 0, 0, 0)), + end: new Date(Date.UTC(year, month + 1, 1, 0, 0, 0, 0)), + }; + } + + function withUrlKey(row: T) { + return { + ...row, + urlKey: normalizeAgentUrlKey(row.name) ?? row.id, + }; + } + + function normalizeAgentBaseRow(row: typeof agents.$inferSelect) { + const { lifecycleOperation, lifecycleRequiredPluginIds, ...publicRow } = row; + return withUrlKey({ + ...publicRow, + permissions: normalizeAgentPermissions(row.permissions), + }); + } + + function toEligibilityAgent(row: Pick): AgentEligibilityAgent { + return { + id: row.id, + companyId: row.companyId, + name: row.name, + status: row.status, + reportsTo: row.reportsTo, + }; + } + + function normalizeAgentRows(rows: (typeof agents.$inferSelect)[], allCompanyRows = rows) { + const eligibilityAgents = allCompanyRows.map(toEligibilityAgent); + return rows.map((row) => { + const base = normalizeAgentBaseRow(row); + const appearance = resolveAgentAppearance(row.appearance, row.id); + return { + ...base, + appearance, + avatarUrl: agentAvatarUrl(appearance), + orgChainHealth: getAgentWorkEligibility({ + agent: toEligibilityAgent(row), + agents: eligibilityAgents, + }).orgChainHealth, + }; + }); + } + + function normalizeAgentRow(row: typeof agents.$inferSelect, allCompanyRows?: (typeof agents.$inferSelect)[]) { + return normalizeAgentRows([row], allCompanyRows)[0]!; + } + + async function listCompanyAgentRows(companyId: string) { + return db.select().from(agents).where(eq(agents.companyId, companyId)); + } + + async function getMonthlySpendByAgentIds(companyId: string, agentIds: string[]) { + if (agentIds.length === 0) return new Map(); + const { start, end } = currentUtcMonthWindow(); + const rows = await db + .select({ + agentId: costEvents.agentId, + spentMonthlyCents: sql`coalesce(sum(${costEvents.costCents}), 0)::double precision`, + }) + .from(costEvents) + .where( + and( + eq(costEvents.companyId, companyId), + inArray(costEvents.agentId, agentIds), + gte(costEvents.occurredAt, start), + lt(costEvents.occurredAt, end), + ), + ) + .groupBy(costEvents.agentId); + return new Map(rows.map((row) => [row.agentId, Number(row.spentMonthlyCents ?? 0)])); + } + + async function hydrateAgentSpend(rows: T[]) { + const agentIds = rows.map((row) => row.id); + const companyId = rows[0]?.companyId; + if (!companyId || agentIds.length === 0) return rows; + const spendByAgentId = await getMonthlySpendByAgentIds(companyId, agentIds); + return rows.map((row) => ({ + ...row, + spentMonthlyCents: spendByAgentId.get(row.id) ?? 0, + })); + } + + async function getById(id: string) { + const row = await db + .select() + .from(agents) + .where(eq(agents.id, id)) + .then((rows) => rows[0] ?? null); + if (!row) return null; + const [companyRows, hydrated] = await Promise.all([ + listCompanyAgentRows(row.companyId), + hydrateAgentSpend([row]).then((rows) => rows[0]!), + ]); + return normalizeAgentRow(hydrated, companyRows); + } + + async function ensureManager(companyId: string, managerId: string) { + const manager = await getById(managerId); + if (!manager) throw notFound("Manager not found"); + if (manager.companyId !== companyId) { + throw unprocessable("Manager must belong to same company"); + } + return manager; + } + + async function assertNoCycle(agentId: string, reportsTo: string | null | undefined) { + if (!reportsTo) return; + if (reportsTo === agentId) throw unprocessable("Agent cannot report to itself"); + + let cursor: string | null = reportsTo; + while (cursor) { + if (cursor === agentId) throw unprocessable("Reporting relationship would create cycle"); + const next = await getById(cursor); + cursor = next?.reportsTo ?? null; + } + } + + async function assertCompanyShortnameAvailable( + companyId: string, + candidateName: string, + options?: AgentShortnameCollisionOptions, + ) { + const candidateShortname = normalizeAgentUrlKey(candidateName); + if (!candidateShortname) return; + + const existingAgents = await db + .select({ + id: agents.id, + name: agents.name, + status: agents.status, + }) + .from(agents) + .where(eq(agents.companyId, companyId)); + + const hasCollision = hasAgentShortnameCollision(candidateName, existingAgents, options); + if (hasCollision) { + throw conflict( + `Agent shortname '${candidateShortname}' is already in use in this company`, + ); + } + } + + function assertBuiltInAgentMetadataMutationAllowed( + beforeMetadata: unknown, + afterMetadata: unknown, + options?: { allowBuiltInAgentMetadata?: boolean }, + ) { + if (options?.allowBuiltInAgentMetadata) return; + const beforeMarker = readBuiltInAgentMarker(beforeMetadata); + const afterMarker = readBuiltInAgentMarker(afterMetadata); + if (builtInAgentMarkersEqual(beforeMarker, afterMarker)) return; + throw conflict("Built-in agent marker is managed by Paperclip and cannot be edited directly", { + code: "built_in_agent_marker_readonly", + key: beforeMarker?.key ?? afterMarker?.key ?? null, + }); + } + + return { normalizeAgentRows, normalizeAgentRow, listCompanyAgentRows, hydrateAgentSpend, + getById, ensureManager, assertNoCycle, assertCompanyShortnameAvailable, assertBuiltInAgentMetadataMutationAllowed }; +} diff --git a/server/src/lib/approval-records.ts b/server/src/lib/approval-records.ts new file mode 100644 index 00000000000..957dfac03ec --- /dev/null +++ b/server/src/lib/approval-records.ts @@ -0,0 +1,68 @@ +import { and, eq, inArray } from "drizzle-orm"; +import { approvals, type Db } from "@paperclipai/db"; +import { notFound, unprocessable } from "../errors.js"; + +export const resolvableApprovalStatuses = ["pending", "revision_requested"]; + +export function approvalResolutionRecords(db: Db) { + const canResolveStatuses = new Set(resolvableApprovalStatuses); + const resolvableStatuses = resolvableApprovalStatuses; + type ApprovalRecord = typeof approvals.$inferSelect; + type ResolutionResult = { approval: ApprovalRecord; applied: boolean }; + async function getExistingApproval(id: string, database: Db = db) { + const existing = await database + .select() + .from(approvals) + .where(eq(approvals.id, id)) + .then((rows) => rows[0] ?? null); + if (!existing) throw notFound("Approval not found"); + return existing; + } + + async function resolveApproval( + id: string, + targetStatus: "approved" | "rejected", + decidedByUserId: string, + decisionNote: string | null | undefined, + database: Db = db, + ): Promise { + const existing = await getExistingApproval(id, database); + if (!canResolveStatuses.has(existing.status)) { + if (existing.status === targetStatus) { + return { approval: existing, applied: false }; + } + throw unprocessable( + `Only pending or revision requested approvals can be ${targetStatus === "approved" ? "approved" : "rejected"}`, + ); + } + + const now = new Date(); + const updated = await database + .update(approvals) + .set({ + status: targetStatus, + decidedByUserId, + decisionNote: decisionNote ?? null, + decidedAt: now, + updatedAt: now, + }) + .where(and(eq(approvals.id, id), inArray(approvals.status, resolvableStatuses))) + .returning() + .then((rows) => rows[0] ?? null); + + if (updated) { + return { approval: updated, applied: true }; + } + + const latest = await getExistingApproval(id, database); + if (latest.status === targetStatus) { + return { approval: latest, applied: false }; + } + + throw unprocessable( + `Only pending or revision requested approvals can be ${targetStatus === "approved" ? "approved" : "rejected"}`, + ); + } + + return { getExistingApproval, resolveApproval }; +} diff --git a/server/src/services/built-in-agent-metadata.ts b/server/src/lib/built-in-agent-metadata.ts similarity index 100% rename from server/src/services/built-in-agent-metadata.ts rename to server/src/lib/built-in-agent-metadata.ts diff --git a/server/src/lib/company-deletion.ts b/server/src/lib/company-deletion.ts new file mode 100644 index 00000000000..c6caae40455 --- /dev/null +++ b/server/src/lib/company-deletion.ts @@ -0,0 +1,9 @@ +import type { Db } from "@paperclipai/db"; + +type CompanyDeletionTransaction = Parameters[0]>[0]; + +export interface CompanyDeletionParticipant { + // The caller holds the company lock and removes dependent records first. + // Use this transaction only. Throw on failure. Do not call external systems. + deleteCompanyData(tx: CompanyDeletionTransaction, companyId: string): Promise; +} diff --git a/server/src/middleware/error-handler.ts b/server/src/middleware/error-handler.ts index 23103185c79..f138c06e4d6 100644 --- a/server/src/middleware/error-handler.ts +++ b/server/src/middleware/error-handler.ts @@ -1,3 +1,4 @@ +import { AgentLifecycleConflict } from "../modules/agent-lifecycle/index.js"; import type { Request, Response, NextFunction } from "express"; import type { Db } from "@paperclipai/db"; import { ZodError } from "zod"; @@ -129,6 +130,7 @@ export function errorHandler( res: Response, _next: NextFunction, ) { + if (err instanceof AgentLifecycleConflict) { res.status(409).json({ error: err.message }); return; } if (err instanceof HttpError) { const details = err.details && diff --git a/server/src/modules/README.md b/server/src/modules/README.md index 05ff555034a..6c3bb456c49 100644 --- a/server/src/modules/README.md +++ b/server/src/modules/README.md @@ -22,10 +22,37 @@ adapters → application → domain Postgres queries, transactions, and process control. An adapter file may import `drizzle-orm`, `@paperclipai/db`, and Node.js I/O modules. -A module exposes one entry point, `index.ts`, which composes the adapters +A module exposes its commands through `index.ts`, which composes the adapters and the use cases behind a factory function. Code outside the module imports -only that entry point, never a file inside `domain/`, `application/`, or +that entry point, never a file inside `domain/`, `application/`, or `adapters/` directly. `pnpm check:module-boundaries` enforces these rules for production source -files. It also rejects imports that bypass another module's `index.ts`. +files. It also checks access to the company deletion entry point below. + +## Company deletion + +The existing company deletion service owns the database transaction and deletion +order. A module can expose a separate `company-deletion.ts` entry point. +Only `services/company-deletion.ts` can import this entry point. +The entry point exports an implementation of `CompanyDeletionParticipant` from +`lib/company-deletion.ts`. Do not export it through the normal module index. + +The service must complete external cleanup before it starts the transaction. +It must lock the company before it deletes dependent records or calls a module. +Creation commands must use the same company lock. +The service removes dependent records before it calls the module. +The module checks its deletion conditions and deletes the records it owns. +Use the supplied transaction. Do not start another transaction or call external +systems. Throw an error if deletion cannot proceed. +An error must roll back all database changes in the deletion transaction. + +Call each module explicitly in dependency order. No module registry is required. + +The agent lifecycle module also has a restricted `configuration.ts` entry point. +It saves configuration and invalidates verification in the caller's transaction. +The [lifecycle guide](../../../doc/AGENT-LIFECYCLE.md) lists its permitted callers. +Ordinary configuration updates use the root lifecycle command. + +The [agent lifecycle module](../../../doc/AGENT-LIFECYCLE.md) owns agent creation, +pause, resume, and termination. Use its commands for these changes. diff --git a/server/src/modules/active-run-watchdog/adapters/postgres.ts b/server/src/modules/active-run-watchdog/adapters/postgres.ts index ac46b6c0954..356ef375c2f 100644 --- a/server/src/modules/active-run-watchdog/adapters/postgres.ts +++ b/server/src/modules/active-run-watchdog/adapters/postgres.ts @@ -456,6 +456,7 @@ export function createPostgresWatchdogAdapter(db: Db): WatchdogRunReader & Watch eq(agents.id, input.run.agentId), eq(agents.companyId, companyId), notInArray(agents.status, ["paused", "terminated"]), + eq(agents.lifecycleState, "ready"), )); return updatedRun; diff --git a/server/src/modules/agent-lifecycle/__tests__/diagnostics.test.ts b/server/src/modules/agent-lifecycle/__tests__/diagnostics.test.ts new file mode 100644 index 00000000000..4f7a8db7214 --- /dev/null +++ b/server/src/modules/agent-lifecycle/__tests__/diagnostics.test.ts @@ -0,0 +1,68 @@ +import { afterEach, describe, expect, it, vi } from "vitest"; +import type { Db } from "@paperclipai/db"; +import { createLifecycleWorker } from "../application/worker.js"; +import type { LifecycleAgent, LifecycleStore, LifecycleDriver } from "../application/ports.js"; +import { startAgentLifecycle } from "../index.js"; +import { createAgentLifecycleEffects } from "../../../services/agent-lifecycle.js"; +import { logger } from "../../../middleware/logger.js"; + +const agent: LifecycleAgent = { id: "agent", companyId: "company", lifecycleState: "verifying", lifecycleVersion: 3, + lifecycleRequiredPluginIds: null, lifecycleError: null, + lifecycleOperation: { id: "operation", hostComplete: false, completedPluginIds: [], attempts: 1 } }; +function fixture() { + const store = { get: vi.fn(), claim: vi.fn().mockResolvedValue(agent), renew: vi.fn().mockResolvedValue(true), + setRequiredPlugins: vi.fn().mockResolvedValue(true), completeHost: vi.fn().mockResolvedValue(true), + completePlugin: vi.fn().mockResolvedValue(true), defer: vi.fn().mockResolvedValue(true), + change: vi.fn().mockResolvedValue({ ...agent, lifecycleState: "ready" }), pending: vi.fn().mockResolvedValue([agent.id]) } satisfies LifecycleStore; + const driver = { requiredPluginIds: vi.fn().mockResolvedValue(["plugin"]), runHost: vi.fn().mockResolvedValue("complete"), + runPlugin: vi.fn().mockResolvedValue("complete") } satisfies LifecycleDriver; + const report = vi.fn(); + return { store, driver, report, worker: createLifecycleWorker(store, driver, report) }; +} +afterEach(() => { vi.restoreAllMocks(); vi.useRealTimers(); }); + +describe("lifecycle failure diagnostics", () => { + it.each(["host", "plugin", "claim", "renew", "scan", "defer"] as const)("reports %s failures with the available context", async stage => { + const { store, driver, report, worker } = fixture(); + const error = new Error("private provider detail"); + if (stage === "host") driver.runHost.mockRejectedValue(error); + else if (stage === "plugin") driver.runPlugin.mockRejectedValue(error); + else if (stage === "scan") store.pending.mockRejectedValue(error); + else if (stage === "defer") { driver.runHost.mockResolvedValue("pending"); store.defer.mockRejectedValue(error); } + else store[stage].mockRejectedValue(error); + const work = stage === "scan" ? worker.sweep() : worker.process(agent.id); + if (["claim", "scan", "defer"].includes(stage)) await expect(work).rejects.toThrow(error); + else await work; + expect(report).toHaveBeenCalledWith(expect.objectContaining({ stage }), error); + if (!["claim", "scan"].includes(stage)) expect(report).toHaveBeenCalledWith(expect.objectContaining({ + agentId: agent.id, companyId: agent.companyId, phase: "verifying", operationId: "operation", version: 3, + ...(stage === "plugin" ? { pluginId: "plugin" } : {}), + }), error); + await worker.stop(); + }); + + it("reports periodic policy scan failures", async () => { + vi.useFakeTimers(); + const error = new Error("private database detail"); + const db = { select: () => { throw error; } } as unknown as Db; + const effects = { ...createAgentLifecycleEffects(), reportFailure: vi.fn() }; + const work = startAgentLifecycle(db, effects, fixture().driver, () => true); + try { + await vi.advanceTimersByTimeAsync(5_000); + expect(effects.reportFailure).toHaveBeenCalledWith({ stage: "policy_scan" }, error); + } finally { await work.stop(); } + }); + + it.each([ + [{ code: "required_plugin_unavailable" }, "required_plugin_unavailable"], + [{ code: "harness_test_failed" }, "harness_test_failed"], + [{ cause: { code: "40P01", message: "private query" } }, "40P01"], + [{ code: "private credential value" }, "unclassified"], + ])("logs known codes without provider error contents", (details, failureCode) => { + const log = vi.spyOn(logger, "warn").mockImplementation(() => {}); + const context = { stage: "host" as const, agentId: "agent", phase: "verifying" as const, operationId: "operation", version: 3 }; + createAgentLifecycleEffects().reportFailure(context, Object.assign(new Error("private provider detail"), details)); + expect(log).toHaveBeenCalledExactlyOnceWith({ ...context, failureCode }, "Agent lifecycle operation failed"); + expect(JSON.stringify(log.mock.calls)).not.toContain("private"); + }); +}); diff --git a/server/src/modules/agent-lifecycle/__tests__/lifecycle.test.ts b/server/src/modules/agent-lifecycle/__tests__/lifecycle.test.ts new file mode 100644 index 00000000000..b2110f065fd --- /dev/null +++ b/server/src/modules/agent-lifecycle/__tests__/lifecycle.test.ts @@ -0,0 +1,673 @@ +import { createAgentLifecycle as createLifecycleCommands } from "../index.js"; +import { createAgentLifecycleEffects } from "../../../services/agent-lifecycle.js"; +import { deleteCompany } from "../../../services/company-deletion.js"; +import { agentLifecycleCompanyDeletion } from "../company-deletion.js"; +import { requireServerAdapter } from "../../../adapters/index.js"; +import { agentExecutionsHaveStopped } from "../../../services/agent-execution-stop.js"; +import { remoteTerminationReceipt } from "../../../services/remote-execution-termination.js"; +import { approvalService } from "../../../services/approvals.js"; +import { updateAgentConfigurationInTransaction } from "../../../services/agent-configuration-transaction.js"; +import { agentService as agentConfiguration } from "../../../services/agents.js"; +import { readFileSync } from "node:fs"; +import express from "express"; +import request from "supertest"; +import { agentRoutes } from "../../../routes/agents.js"; +import { errorHandler } from "../../../middleware/error-handler.js"; +import { createLifecycleDriver } from "../../../services/agent-lifecycle-driver.js"; +import { randomUUID } from "node:crypto"; +import { and, eq, sql } from "drizzle-orm"; +import { agents, approvals, projects, issues, heartbeatRuns, nativeRunFinalizations, budgetPolicies, environmentLeases, agentApiKeys, activityLog, agentConfigRevisions, userCompanyPreferences, companies, companyMemberships, principalPermissionGrants, plugins, pluginCompanySettings, createDb, type Db } from "@paperclipai/db"; +import { afterAll, beforeAll, beforeEach, describe, expect, it, vi } from "vitest"; +import { getEmbeddedPostgresTestSupport, startEmbeddedPostgresTestDatabase } from "../../../__tests__/helpers/embedded-postgres.js"; +import { createAgentLifecycle, configureAgentLifecycle } from "../../../services/agent-lifecycle.js"; +import { createLifecycleStore as createStore } from "../adapters/postgres.js"; +import { transition } from "../domain/policy.js"; +import type { LifecycleAgent } from "../application/ports.js"; +import { budgetService } from "../../../services/budgets.js"; + +const createLifecycleStore = (db: Db) => createStore(db, createAgentLifecycleEffects()); + +const support = await getEmbeddedPostgresTestSupport(); +(support.supported ? describe : describe.skip)("agent lifecycle commands", () => { + let database: Awaited>; + let db: Db; + let companyId: string; + const workers: ReturnType[] = []; + beforeAll(async () => { database = await startEmbeddedPostgresTestDatabase("paperclip-agent-lifecycle-"); db = createDb(database.connectionString); }, 90_000); + afterAll(async () => { for (const worker of workers) await worker.stop(); await database?.cleanup(); }); + beforeEach(async () => { + for (const work of workers) await work.stop(); + companyId = randomUUID(); + await db.insert(companies).values({ id: companyId, name: "Lifecycle test", issuePrefix: `L${companyId.slice(0, 7)}` }); + }); + function worker(runHost: (agent: LifecycleAgent) => Promise<"complete" | "pending"> = async () => "complete") { + const value = configureAgentLifecycle(db, { requiredPluginIds: async () => [], runPlugin: async () => "complete", runHost }); + workers.push(value); return value; + } + async function hire(status = "idle") { return createAgentLifecycle(db).requestHire(companyId, { name: "Agent", status, adapterType: "process" }); } + async function current(id: string) { return (await db.select().from(agents).where(eq(agents.id, id)))[0]!; } + + it("maps existing states without starting setup or clearing pause reasons", async () => { + const rows = await db.insert(agents).values(["idle", "running", "error", "paused", "pending_approval", "terminated"].map(status => ({ + companyId, name: status, status, pauseReason: status === "paused" ? "budget" : null, + }))).returning(); + const migration = readFileSync(new URL("../../../../../packages/db/src/migrations/0320_daily_onslaught.sql", import.meta.url), "utf8"); + await db.execute(sql.raw(migration.slice(migration.indexOf('UPDATE "agents"')))); + for (const row of rows) { + const mapped = await current(row.id); + expect(mapped.lifecycleState).toBe(["paused", "pending_approval", "terminated"].includes(row.status) ? row.status : "ready"); + expect(mapped.lifecycleOperation).toBeNull(); + expect(mapped.lifecycleRequiredPluginIds).toBeNull(); + expect(mapped.lifecycleHolds).toEqual(row.status === "paused" ? ["budget"] : []); + } + }); + + it("commits the record before preparation and verifies before admission", async () => { + const observed: string[] = []; + const work = worker(async agent => { + expect((await current(agent.id)).lifecycleState).toBe(agent.lifecycleState); + observed.push(agent.lifecycleState); return "complete"; + }); + const agent = await hire(); + expect(agent).toMatchObject({ lifecycleState: "preparing", status: "paused" }); + await work.process(agent.id); + expect(observed).toEqual(["preparing", "verifying"]); + expect(await current(agent.id)).toMatchObject({ lifecycleState: "ready", status: "idle" }); + expect(agent).not.toHaveProperty("lifecycleOperation"); + }); + + it("rolls back a hire and its grants when hire initialization fails", async () => { + const effects = createAgentLifecycleEffects(); + const lifecycle = createLifecycleCommands(db, { ...effects, + initializeHire: async (tx, agent, options) => { + await effects.initializeHire(tx, agent, options); + throw new Error("Hire initialization failed"); + }, + }); + await expect(lifecycle.requestHire(companyId, { name: "Rollback hire", adapterType: "process" })) + .rejects.toThrow("Hire initialization failed"); + expect(await db.select().from(agents).where(eq(agents.companyId, companyId))).toHaveLength(0); + expect(await db.select().from(principalPermissionGrants).where(eq(principalPermissionGrants.companyId, companyId))).toHaveLength(0); + }); + + it("runs the saved harness test and keeps a failed configuration out of ready", async () => { + const driver = createLifecycleDriver(db, {} as never); + const work = worker(driver.runHost); + const agent = await hire(); + await work.process(agent.id); + expect(await current(agent.id)).toMatchObject({ lifecycleState: "verifying", status: "paused" }); + await agentConfiguration(db).update(agent.id, { adapterConfig: { command: process.execPath } }); + await work.process(agent.id); + expect(await current(agent.id)).toMatchObject({ lifecycleState: "ready", status: "idle", lifecycleError: null }); + }); + + it.each(["claude_local", "gemini_local"])("keeps %s authentication warnings out of ready", async adapterType => { + const adapter = requireServerAdapter(adapterType); + const probe = vi.spyOn(adapter, "testEnvironment").mockResolvedValue({ adapterType, status: "warn", + testedAt: new Date().toISOString(), checks: [{ code: `${adapterType.split("_")[0]}_hello_probe_auth_required`, level: "warn", message: "Login required" }] }); + try { + const agent = await createAgentLifecycle(db).requestHire(companyId, { name: "Login test", adapterType }); + const work = worker(createLifecycleDriver(db, {} as never).runHost); + await work.process(agent.id); + expect(probe).toHaveBeenCalled(); + expect(await current(agent.id)).toMatchObject({ lifecycleState: "verifying", lifecycleError: "The lifecycle step failed. Retry the operation." }); + } finally { probe.mockRestore(); } + }); + + it("recovers an expired native owner only after the cancelled run and controller stop", async () => { + const agent = await hire(); + const [issue] = await db.insert(issues).values({ companyId, title: "Cancelled native run" }).returning(); + const [run] = await db.insert(heartbeatRuns).values({ companyId, agentId: agent.id, nativeIssueId: issue.id, + status: "cancelled", invocationSource: "on_demand", runtimeMode: "native", + startedAt: new Date(), finishedAt: new Date(), processPid: process.pid }).returning(); + await db.insert(nativeRunFinalizations).values({ companyId, issueId: issue.id, runId: run.id, + phase: "executing", leaseOwner: "stopped-server", leaseExpiresAt: new Date(0), controllerPid: process.pid }); + expect(await agentExecutionsHaveStopped(db, [agent.id])).toBe(false); + await db.update(nativeRunFinalizations).set({ controllerPid: null }).where(eq(nativeRunFinalizations.runId, run.id)); + expect(await agentExecutionsHaveStopped(db, [agent.id])).toBe(false); + await db.update(heartbeatRuns).set({ processPid: 2_000_000_000 }).where(eq(heartbeatRuns.id, run.id)); + await db.update(nativeRunFinalizations).set({ leaseExpiresAt: new Date(Date.now() + 60_000) }).where(eq(nativeRunFinalizations.runId, run.id)); + expect(await agentExecutionsHaveStopped(db, [agent.id])).toBe(false); + await db.update(nativeRunFinalizations).set({ leaseExpiresAt: new Date(0) }).where(eq(nativeRunFinalizations.runId, run.id)); + expect(await agentExecutionsHaveStopped(db, [agent.id])).toBe(true); + expect((await db.select().from(nativeRunFinalizations).where(eq(nativeRunFinalizations.runId, run.id)))[0]).toMatchObject({ leaseOwner: null, leaseExpiresAt: null }); + }); + + it("does not advance termination while a cancelled process still runs", async () => { + const agent = await hire(); + const [run] = await db.insert(heartbeatRuns).values({ companyId, agentId: agent.id, + status: "cancelled", invocationSource: "on_demand", runtimeMode: "legacy", + startedAt: new Date(), finishedAt: new Date(), processPid: process.pid }).returning(); + const driver = createLifecycleDriver(db, {} as never); + const work = worker(driver.runHost); + await createAgentLifecycle(db).terminateAgent(agent.id); + await work.process(agent.id); + expect((await current(agent.id)).lifecycleState).toBe("terminating"); + await db.update(heartbeatRuns).set({ processPid: null, + resultJson: { executionCancellation: { state: "acknowledged" } } }).where(eq(heartbeatRuns.id, run.id)); + await createAgentLifecycle(db).retry(agent.id); + await work.process(agent.id); + expect((await current(agent.id)).lifecycleState).toBe("terminated"); + }); + + it("does not cancel a reporting agent when its manager pauses", async () => { + const parent = await hire(); + const [child] = await db.insert(agents).values({ companyId, name: "Report", reportsTo: parent.id, + status: "idle", lifecycleState: "ready" }).returning(); + const [run] = await db.insert(heartbeatRuns).values({ companyId, agentId: child.id, + status: "queued", invocationSource: "on_demand" }).returning(); + const work = worker(createLifecycleDriver(db, {} as never).runHost); + await createAgentLifecycle(db).pauseAgent(parent.id); + await work.process(parent.id); + expect((await current(parent.id)).lifecycleState).toBe("paused"); + expect((await db.select().from(heartbeatRuns).where(eq(heartbeatRuns.id, run.id)))[0]!.status).toBe("queued"); + }); + + it("retains company data until every agent finishes termination", async () => { + const agent = await hire(); + const [project] = await db.insert(projects).values({ companyId, name: "Keep until cleanup", leadAgentId: agent.id }).returning(); + await db.insert(issues).values({ companyId, projectId: project.id, title: "Keep this task", assigneeAgentId: agent.id }); + const pending = worker(async () => "pending"); + await expect(deleteCompany(db, companyId)).rejects.toThrow("Complete termination"); + expect(await db.select().from(projects).where(eq(projects.id, project.id))).toHaveLength(1); + expect(await db.select().from(issues).where(eq(issues.companyId, companyId))).toHaveLength(1); + await pending.stop(); + const complete = worker(); + await createAgentLifecycle(db).retry(agent.id); + await complete.process(agent.id); + await deleteCompany(db, companyId); + expect(await db.select().from(agents).where(eq(agents.companyId, companyId))).toHaveLength(0); + expect(await db.select().from(companies).where(eq(companies.id, companyId))).toHaveLength(0); + }); + + it("requires a transaction for the company deletion integration", async () => { + await expect(agentLifecycleCompanyDeletion.deleteCompanyData(db as never, companyId)) + .rejects.toThrow("Company deletion requires a database transaction"); + }); + + it("rejects individual deletion before cleanup and rolls back failed cleanup", async () => { + const agent = await hire(); + const effects = createAgentLifecycleEffects(); + const cleanup = vi.fn(effects.deleteDependencies); + const lifecycle = createLifecycleCommands(db, { ...effects, deleteDependencies: cleanup }); + await expect(lifecycle.purgeAgent(agent.id)).rejects.toThrow("Complete termination"); + expect(cleanup).not.toHaveBeenCalled(); + + await db.update(agents).set({ lifecycleState: "terminated", status: "terminated" }).where(eq(agents.id, agent.id)); + const [key] = await db.insert(agentApiKeys).values({ companyId, agentId: agent.id, name: "Keep on rollback", keyHash: randomUUID() }).returning(); + cleanup.mockImplementation(async (tx, companyId, id) => { + await effects.deleteDependencies(tx, companyId, id); + throw new Error("Dependency cleanup failed"); + }); + await expect(lifecycle.purgeAgent(agent.id)).rejects.toThrow("Dependency cleanup failed"); + expect(await current(agent.id)).toMatchObject({ lifecycleState: "terminated" }); + expect(await db.select().from(agentApiKeys).where(eq(agentApiKeys.id, key.id))).toHaveLength(1); + }); + + it("deletes terminated and rejected agents only in the requested company", async () => { + await db.insert(agents).values((["terminated", "rejected"] as const).map(lifecycleState => ({ + companyId, name: lifecycleState, status: "terminated", lifecycleState, + }))); + const [otherCompany] = await db.insert(companies).values({ name: "Keep this company", issuePrefix: `K${companyId.slice(0, 7)}` }).returning(); + const [otherAgent] = await db.insert(agents).values({ companyId: otherCompany.id, name: "Keep this agent", + status: "terminated", lifecycleState: "terminated" }).returning(); + + await deleteCompany(db, companyId); + + expect(await db.select().from(agents).where(eq(agents.companyId, companyId))).toHaveLength(0); + expect(await current(otherAgent.id)).toMatchObject({ companyId: otherCompany.id }); + expect(await db.select().from(companies).where(eq(companies.id, otherCompany.id))).toHaveLength(1); + }); + + it("rolls back agent and company data deletion when a later operation fails", async () => { + const agent = await hire("terminated"); + const [project] = await db.insert(projects).values({ companyId, name: "Keep on rollback" }).returning(); + const removeAgents = agentLifecycleCompanyDeletion.deleteCompanyData; + const failure = vi.spyOn(agentLifecycleCompanyDeletion, "deleteCompanyData").mockImplementation(async (tx, id) => { + await removeAgents(tx, id); + expect(await tx.select().from(agents).where(eq(agents.companyId, id))).toHaveLength(0); + throw new Error("Later deletion failed"); + }); + try { + await expect(deleteCompany(db, companyId)).rejects.toThrow("Later deletion failed"); + expect(await current(agent.id)).toMatchObject({ lifecycleState: "terminated" }); + expect(await db.select().from(projects).where(eq(projects.id, project.id))).toHaveLength(1); + expect(await db.select().from(companies).where(eq(companies.id, companyId))).toHaveLength(1); + } finally { failure.mockRestore(); } + }); + + it("blocks a concurrent hire until company deletion commits", async () => { + let reportLock!: (pid: number) => void; + let rejectLock!: (error: unknown) => void; + const locked = new Promise((resolve, reject) => { reportLock = resolve; rejectLock = reject; }); + let release!: () => void; + const released = new Promise(resolve => { release = resolve; }); + const removeAgents = agentLifecycleCompanyDeletion.deleteCompanyData; + const pause = vi.spyOn(agentLifecycleCompanyDeletion, "deleteCompanyData").mockImplementation(async (tx, id) => { + const [backend] = await tx.execute<{ pid: number }>(sql`select pg_backend_pid() as pid`); + reportLock(backend!.pid); + await released; + await removeAgents(tx, id); + }); + const deletion = deleteCompany(db, companyId); + void deletion.catch(rejectLock); + let hiring: Promise | undefined; + try { + const pid = await locked; + hiring = hire().then(() => "created", error => error.message); + await vi.waitFor(async () => { + const blocked = await db.execute(sql`select 1 from pg_stat_activity + where datname = current_database() and ${pid} = any(pg_blocking_pids(pid))`); + expect(blocked).toHaveLength(1); + }); + release(); + await deletion; + expect(await hiring).toBe("Company not found"); + expect(await db.select().from(agents).where(eq(agents.companyId, companyId))).toHaveLength(0); + } finally { + release(); + await Promise.allSettled([deletion, hiring]); + pause.mockRestore(); + } + }); + + it("requires cleanup proof after a remote run is already cancelled", async () => { + const agent = await hire(); + const [run] = await db.insert(heartbeatRuns).values({ companyId, agentId: agent.id, + status: "cancelled", invocationSource: "on_demand", runtimeMode: "native", + startedAt: new Date(), finishedAt: new Date() }).returning(); + const [lease] = await db.insert(environmentLeases).values({ companyId, heartbeatRunId: run.id, + provider: "test", providerLeaseId: "test-lease", status: "pending_cleanup", + cleanupStatus: "failed", releasedAt: new Date() }).returning(); + expect(await agentExecutionsHaveStopped(db, [agent.id])).toBe(false); + await db.update(environmentLeases).set({ status: "released", cleanupStatus: "success" }) + .where(eq(environmentLeases.id, lease.id)); + expect(await agentExecutionsHaveStopped(db, [agent.id])).toBe(false); + await db.update(environmentLeases).set({ metadata: { + remoteExecutionTermination: remoteTerminationReceipt(lease, { providerLeaseId: lease.providerLeaseId, state: "destroyed" }), + } }).where(eq(environmentLeases.id, lease.id)); + expect(await agentExecutionsHaveStopped(db, [agent.id])).toBe(true); + }); + + it("does not prepare a proposed hire until approval", async () => { + const observed: string[] = []; + const work = worker(async agent => { observed.push(agent.lifecycleState); return "complete"; }); + const agent = await hire("pending_approval"); + await work.process(agent.id); + expect(observed).toEqual([]); + const approval = await approvalService(db).create(companyId, { type: "hire_agent", payload: { agentId: agent.id }, status: "pending" }); + await approvalService(db).approve(approval.id, "board"); + await vi.waitFor(async () => expect((await current(agent.id)).lifecycleState).toBe("ready")); + expect(observed).toEqual(["preparing", "verifying"]); + }); + + it.each(["approved", "rejected"] as const)("uses the same %s hire decision for an agent and its approval", async decision => { + const agent = await hire("pending_approval"); + const approval = await approvalService(db).create(companyId, { type: "hire_agent", + requestedByUserId: "requester", payload: { agentId: agent.id }, status: "pending" }); + const lifecycle = createAgentLifecycle(db); + const decide = decision === "approved" ? lifecycle.approveHire : lifecycle.rejectHire; + const first = await decide(agent.id, "board"); + expect(first).toMatchObject({ applied: true, approval: { id: approval.id, status: decision }, + agent: { lifecycleState: decision === "approved" ? "preparing" : "rejected" } }); + const version = (await current(agent.id)).lifecycleVersion; + expect(await decide({ approvalId: approval.id }, "board")).toMatchObject({ applied: false, hireApprovedAgentId: null }); + expect((await current(agent.id)).lifecycleVersion).toBe(version); + }); + + it("rolls back the approval and agent together when activation fails", async () => { + const agent = await hire("pending_approval"); + const approval = await approvalService(db).create(companyId, { type: "hire_agent", + payload: { agentId: agent.id }, status: "pending" }); + const lifecycle = createLifecycleCommands(db, { ...createAgentLifecycleEffects(), + recordCreation: async () => { throw new Error("Creation event failed"); } }); + await expect(lifecycle.approveHire(agent.id, "board")).rejects.toThrow("Creation event failed"); + expect((await current(agent.id)).lifecycleState).toBe("pending_approval"); + expect((await db.select().from(approvals).where(eq(approvals.id, approval.id)))[0].status).toBe("pending"); + }); + + it("keeps the hire credential owner and recovers it for migrated approvals", async () => { + for (const savedOwner of [null, "original-owner"]) { + const [agent] = await db.insert(agents).values({ companyId, name: "Migrated hire", status: "pending_approval", + lifecycleState: "pending_approval", lifecycleOperation: savedOwner ? { + id: randomUUID(), hostComplete: false, completedPluginIds: [], attempts: 0, responsibleUserId: savedOwner, + } : null }).returning(); + const approval = await approvalService(db).create(companyId, { type: "hire_agent", + requestedByUserId: "requesting-member", payload: { agentId: agent.id }, status: "pending" }); + await approvalService(db).approve(approval.id, "approving-member"); + expect((await current(agent.id)).lifecycleOperation?.responsibleUserId).toBe(savedOwner ?? "requesting-member"); + } + }); + + it("rejects transaction injection and generic state writes", async () => { + const agent = await hire("pending_approval"); + await expect(db.transaction(async tx => createAgentLifecycle(tx as unknown as Db))).rejects.toThrow("root database"); + await expect(agentConfiguration(db).update(agent.id, { status: "idle" } as never)).rejects.toThrow("lifecycle command"); + await expect(createAgentLifecycle(db).requestHire(companyId, { name: "Bypass", lifecycleRequiredPluginIds: [] } as never)).rejects.toThrow("Lifecycle fields"); + }); + + it("clears a rejected hire from the user's primary selection", async () => { + const agent = await createAgentLifecycle(db).requestHire(companyId, { name: "Proposed", status: "pending_approval" }, { createdByUserId: "board" }); + const preference = () => db.select().from(userCompanyPreferences).where(eq(userCompanyPreferences.companyId, companyId)); + expect((await preference())[0]!.primaryAgentId).toBe(agent.id); + const approval = await approvalService(db).create(companyId, { type: "hire_agent", payload: { agentId: agent.id }, status: "pending" }); + await approvalService(db).reject(approval.id, "board"); + expect((await preference())[0]!.primaryAgentId).toBeNull(); + expect((await current(agent.id)).lifecycleState).toBe("rejected"); + }); + + it("rolls back configuration and its revision when the requested transition fails", async () => { + const lifecycle = createAgentLifecycle(db); + const agent = await hire("terminated"); + await expect(lifecycle.updateAndTransition(agent.id, "resume", { name: "Must not persist" }, + { recordRevision: { createdByUserId: "board", source: "patch" } })).rejects.toThrow("Cannot resume"); + expect((await current(agent.id)).name).toBe("Agent"); + expect(await db.select().from(agentConfigRevisions).where(eq(agentConfigRevisions.agentId, agent.id))).toEqual([]); + const active = await hire(); + expect(await lifecycle.updateAndTransition(active.id, "pause", { name: "Paused agent" })).toMatchObject({ name: "Paused agent", lifecycleState: "pausing" }); + }); + + it("preserves a disabled positive budget at approval and applies explicit configuration changes", async () => { + const agent = await hire("pending_approval"); + const budgets = budgetService(db); + await budgets.upsertPolicy(companyId, { scopeType: "agent", scopeId: agent.id, amount: 1000, isActive: false }, null); + const approval = await approvalService(db).create(companyId, { type: "hire_agent", + payload: { agentId: agent.id, budgetMonthlyCents: 1000 }, status: "pending" }); + const policy = async () => (await db.select().from(budgetPolicies).where(eq(budgetPolicies.scopeId, agent.id)))[0]!; + await approvalService(db).approve(approval.id, "board"); + expect(await policy()).toMatchObject({ amount: 1000, isActive: false }); + await agentConfiguration(db).update(agent.id, { budgetMonthlyCents: 2000 }); + expect(await policy()).toMatchObject({ amount: 2000, isActive: true }); + await agentConfiguration(db).update(agent.id, { budgetMonthlyCents: 0 }); + expect(await policy()).toMatchObject({ amount: 0, isActive: false }); + }); + + it.each(["updateConfiguration", "updateAndTransition"] as const)("limits %s budget reconciliation to the edited agent", async command => { + const lifecycle = createAgentLifecycle(db); + const one = await hire(); + const two = await lifecycle.requestHire(companyId, { name: "Other budget target" }); + await db.update(companies).set({ status: "paused" }).where(eq(companies.id, companyId)); + if (command === "updateConfiguration") await lifecycle.updateConfiguration(one.id, { budgetMonthlyCents: 1000 }); + else await lifecycle.updateAndTransition(one.id, "pause", { budgetMonthlyCents: 1000 }); + expect((await current(one.id)).lifecycleHolds).toContain("company_paused"); + expect((await current(two.id)).lifecycleHolds).toEqual([]); + }); + + it("limits invocation policy checks to the requested agent", async () => { + const one = await hire(); + const two = await createAgentLifecycle(db).requestHire(companyId, { name: "Another agent" }); + await db.update(companies).set({ status: "paused" }).where(eq(companies.id, companyId)); + await budgetService(db).getInvocationBlock(companyId, one.id); + expect((await current(one.id)).lifecycleHolds).toContain("company_paused"); + expect((await current(two.id)).lifecycleHolds).toEqual([]); + }); + + it("keeps a manual hold when company policy changes", async () => { + const work = worker(); const lifecycle = createAgentLifecycle(db); const agent = await hire(); await work.process(agent.id); + await lifecycle.pauseAgent(agent.id); await work.process(agent.id); + await db.update(companies).set({ status: "archived" }).where(eq(companies.id, companyId)); + await createAgentLifecycle(db).reconcilePolicyHolds(companyId); await work.process(agent.id); + await db.update(companies).set({ status: "active" }).where(eq(companies.id, companyId)); + await createAgentLifecycle(db).reconcilePolicyHolds(companyId); await work.process(agent.id); + expect(await current(agent.id)).toMatchObject({ lifecycleState: "paused", lifecycleHolds: ["manual"] }); + await lifecycle.resumeAgent(agent.id); await work.process(agent.id); + expect((await current(agent.id)).lifecycleState).toBe("ready"); + }); + + it("defers automatic policy changes while a task holds the agent lock", async () => { + const agent = await hire("paused"); + await db.transaction(async tx => { + await tx.select().from(agents).where(eq(agents.id, agent.id)).for("update"); + expect(await createLifecycleStore(db).change(agent.id, "reconcile")).toBeNull(); + }); + expect(await createLifecycleStore(db).change(agent.id, "reconcile")).not.toBeNull(); + }); + + it("retains the failed phase and the same operation for retry", async () => { + let fail = true; + const work = worker(async agent => { if (agent.lifecycleState === "verifying" && fail) throw new Error("private detail"); return "complete"; }); + const agent = await hire(); await work.process(agent.id); + const failed = await current(agent.id); + expect(failed.lifecycleState).toBe("verifying"); + expect(failed.lifecycleError).not.toContain("private detail"); + fail = false; + await createAgentLifecycle(db).retry(agent.id); await work.process(agent.id); + expect((await current(agent.id)).lifecycleState).toBe("ready"); + }); + + it("fences a late completion when termination replaces preparation", async () => { + const agent = await hire("paused"); + const store = createLifecycleStore(db); + await createAgentLifecycle(db).resumeAgent(agent.id); + const claimed = await store.claim(agent.id, "old", new Date()); + expect(claimed).not.toBeNull(); + await store.setRequiredPlugins(claimed!, "old", []); + await createAgentLifecycle(db).terminateAgent(agent.id); + expect(await store.completeHost(claimed!, "old")).toBe(false); + expect(await store.change(agent.id, "complete", { owner: "old", version: claimed!.lifecycleVersion })).toBeNull(); + expect((await current(agent.id)).lifecycleState).toBe("terminating"); + }); + + it("revokes keys at termination and waits for cleanup before deletion", async () => { + let pending = true; + const phases: string[] = []; + const work = worker(async agent => { phases.push(agent.lifecycleState); return agent.lifecycleState === "cleaning_up" && pending ? "pending" : "complete"; }); + const lifecycle = createAgentLifecycle(db); const agent = await hire(); await work.process(agent.id); + await db.insert(agentApiKeys).values({ agentId: agent.id, companyId, name: "Test", keyHash: randomUUID() }); + await lifecycle.terminateAgent(agent.id); await work.process(agent.id); + expect((await current(agent.id)).lifecycleState).toBe("cleaning_up"); + expect((await db.select().from(agentApiKeys).where(eq(agentApiKeys.agentId, agent.id)))[0].revokedAt).not.toBeNull(); + await expect(agentConfiguration(db).remove(agent.id)).rejects.toThrow("Complete termination"); + pending = false; await lifecycle.retry(agent.id); await work.process(agent.id); + expect(phases).toContain("terminating"); + expect((await current(agent.id)).lifecycleState).toBe("terminated"); + await agentConfiguration(db).remove(agent.id); + expect(await current(agent.id)).toBeUndefined(); + }); + + it("retains required plugin IDs and checks the operation and company on each reply", async () => { + const agent = await hire("paused"); + const pluginId = randomUUID(); + await db.insert(plugins).values({ id: pluginId, pluginKey: pluginId, packageName: "lifecycle-test", version: "1.0.0", status: "ready", + manifestJson: { agentLifecycle: true, capabilities: ["agents.lifecycle.manage"] } as never }); + const call = vi.fn(async (_id, _method, input) => ({ operationId: input.operationId, version: input.version, status: "complete" })); + const driver = createLifecycleDriver(db, { call } as never); + const snapshot = (await createLifecycleStore(db).get(agent.id))!; + expect(await driver.requiredPluginIds(snapshot)).toContain(pluginId); + await db.insert(pluginCompanySettings).values({ companyId, pluginId, enabled: false }); + expect(await driver.requiredPluginIds(snapshot)).not.toContain(pluginId); + expect(await driver.requiredPluginIds({ ...snapshot, lifecycleRequiredPluginIds: [pluginId] })).toContain(pluginId); + await expect(driver.runPlugin(snapshot, pluginId)).rejects.toThrow("unavailable"); + await db.update(pluginCompanySettings).set({ enabled: true }).where(eq(pluginCompanySettings.pluginId, pluginId)); + expect(await driver.runPlugin(snapshot, pluginId)).toBe("complete"); + expect(call).toHaveBeenCalledWith(pluginId, "agentLifecycle", { companyId, agentId: agent.id, + operationId: snapshot.lifecycleOperation!.id, version: snapshot.lifecycleVersion, phase: "paused" }, 30_000); + call.mockResolvedValueOnce({ operationId: "stale", version: snapshot.lifecycleVersion, status: "complete" }); + await expect(driver.runPlugin(snapshot, pluginId)).rejects.toThrow("Invalid lifecycle result"); + }); + + it("keeps host completion and required plugin results across a worker restart", async () => { + const pluginIds = [randomUUID(), randomUUID()]; + const runHost = vi.fn(async () => "complete" as const); + const firstPlugin = vi.fn(async (_agent: LifecycleAgent, pluginId: string) => + pluginId === pluginIds[0] ? "complete" as const : "pending" as const); + const first = configureAgentLifecycle(db, { requiredPluginIds: async () => pluginIds, runHost, runPlugin: firstPlugin }); + workers.push(first); + const agent = await hire(); + await first.process(agent.id); + expect(await current(agent.id)).toMatchObject({ lifecycleState: "preparing", lifecycleRequiredPluginIds: pluginIds, + lifecycleOperation: { hostComplete: true, completedPluginIds: [pluginIds[0]] } }); + await first.stop(); + + const discover = vi.fn(async () => []); + const resumedPlugin = vi.fn(async (_agent: LifecycleAgent, _pluginId: string) => "complete" as const); + const resumed = configureAgentLifecycle(db, { requiredPluginIds: discover, runHost, runPlugin: resumedPlugin }); + workers.push(resumed); + await createAgentLifecycle(db).retry(agent.id); + await resumed.process(agent.id); + expect((await current(agent.id)).lifecycleState).toBe("ready"); + expect(discover).not.toHaveBeenCalled(); + expect(runHost).toHaveBeenCalledTimes(2); + expect(resumedPlugin.mock.calls.map(call => call[1])).toEqual([pluginIds[1], ...pluginIds]); + }); + + it("requires host and plugin completion and freezes the selected plugin IDs", async () => { + const agent = await hire(); + const store = createLifecycleStore(db); + const claimed = (await store.claim(agent.id, "test", new Date()))!; + const pluginId = randomUUID(); + expect(await store.setRequiredPlugins(claimed, "test", [pluginId])).toBe(true); + expect(await store.setRequiredPlugins(claimed, "test", [])).toBe(false); + expect(await store.completePlugin(claimed, "test", randomUUID())).toBe(false); + const complete = () => store.change(agent.id, "complete", { owner: "test", version: claimed.lifecycleVersion }); + expect(await complete()).toBeNull(); + expect(await store.completePlugin(claimed, "test", pluginId)).toBe(true); + expect(await complete()).toBeNull(); + expect(await store.completeHost(claimed, "test")).toBe(true); + expect(await complete()).toMatchObject({ lifecycleState: "verifying" }); + expect(await store.completePlugin(claimed, "test", pluginId)).toBe(false); + }); + + it("fences verification when the saved configuration changes", async () => { + const lifecycle = createAgentLifecycle(db); const store = createLifecycleStore(db); + const agent = await hire(); + const claimed = (await store.claim(agent.id, "configuration-test", new Date()))!; + await store.setRequiredPlugins(claimed, "configuration-test", []); + await agentConfiguration(db).update(agent.id, { adapterConfig: { command: "echo" } }); + expect(await store.completeHost(claimed, "configuration-test")).toBe(false); + expect((await lifecycle.get(agent.id))!.lifecycleVersion).toBeGreaterThan(claimed.lifecycleVersion); + }); + + it("invalidates only changed execution configuration during setup", async () => { + const lifecycle = createAgentLifecycle(db); + const agent = await hire(); + const before = await current(agent.id); + await lifecycle.updateConfiguration(agent.id, { name: "Profile only" }); + await lifecycle.updateConfiguration(agent.id, { adapterConfig: before.adapterConfig }); + expect((await current(agent.id)).lifecycleVersion).toBe(before.lifecycleVersion); + await lifecycle.updateConfiguration(agent.id, { runtimeConfig: { heartbeat: { enabled: false } } }); + expect((await current(agent.id)).lifecycleVersion).toBe(before.lifecycleVersion + 1); + const work = worker(); + await work.process(agent.id); + const ready = await current(agent.id); + expect(ready.lifecycleState).toBe("ready"); + await lifecycle.updateConfiguration(agent.id, { adapterConfig: { command: "echo" } }); + expect(await current(agent.id)).toMatchObject({ lifecycleState: "ready", lifecycleVersion: ready.lifecycleVersion }); + }); + + it("rejects identity, accounting, and unknown fields through every configuration entry point", async () => { + const agent = await hire(); + const lifecycle = createAgentLifecycle(db); + const before = await current(agent.id); + for (const patch of [{ id: randomUUID() }, { companyId: randomUUID() }, { spentMonthlyCents: 0 }, + { spendMonthUtc: "2099-01" }, { lastHeartbeatAt: new Date() }, { errorReason: null }, + { createdAt: new Date() }, { updatedAt: new Date() }, { lifecycleState: "ready" }, { futureColumn: true }]) { + await expect(lifecycle.updateConfiguration(agent.id, patch as never)).rejects.toThrow("Unsupported configuration field"); + await expect(lifecycle.updateAndTransition(agent.id, "pause", patch as never)).rejects.toThrow("Unsupported configuration field"); + await expect(db.transaction(tx => updateAgentConfigurationInTransaction(tx as unknown as Db, agent.id, patch as never))) + .rejects.toThrow("Unsupported configuration field"); + } + expect(await current(agent.id)).toEqual(before); + const effects = createAgentLifecycleEffects(); + const malformed = createLifecycleCommands(db, { ...effects, prepareConfiguration: async () => ({ id: randomUUID() }) as never }); + await expect(malformed.updateConfiguration(agent.id, { name: "Changed" })).rejects.toThrow("Unsupported configuration field"); + expect(await current(agent.id)).toEqual(before); + }); + + it("records only the changed configuration fields for a legacy appearance", async () => { + const [agent] = await db.insert(agents).values({ companyId, name: "Legacy", appearance: null }).returning(); + await createAgentLifecycle(db).updateConfiguration(agent.id, { name: "Renamed" }, + { recordRevision: { source: "test", createdByUserId: "board" } }); + const revisions = await db.select().from(agentConfigRevisions).where(eq(agentConfigRevisions.agentId, agent.id)); + expect(revisions).toHaveLength(1); + expect(revisions[0].changedKeys).toEqual(["name"]); + expect(revisions[0].beforeConfig.appearance).toEqual(revisions[0].afterConfig.appearance); + }); + + it("accepts the unchanged resolved appearance of a pending hire", async () => { + const [agent] = await db.insert(agents).values({ companyId, name: "Pending legacy", status: "pending_approval", appearance: null }).returning(); + const resolved = await agentConfiguration(db).getById(agent.id); + await expect(createAgentLifecycle(db).updateConfiguration(agent.id, { appearance: resolved!.appearance })) + .resolves.toMatchObject({ id: agent.id }); + await expect(createAgentLifecycle(db).updateConfiguration(agent.id, { name: "Changed" })) + .rejects.toThrow("Pending approval agent configuration cannot be changed"); + }); + + it("rolls back a root configuration command when dependent records fail", async () => { + const agent = await hire(); + const before = await current(agent.id); + const effects = createAgentLifecycleEffects(); + const lifecycle = createLifecycleCommands(db, { ...effects, completeConfiguration: async (...args) => { + await effects.completeConfiguration(...args); + throw new Error("Configuration completion failed"); + } }); + await expect(lifecycle.updateConfiguration(agent.id, { adapterConfig: { command: "echo" } }, + { recordRevision: { source: "test", createdByUserId: "board" } })).rejects.toThrow("Configuration completion failed"); + expect(await current(agent.id)).toMatchObject({ adapterConfig: before.adapterConfig, + lifecycleVersion: before.lifecycleVersion, lifecycleOperation: before.lifecycleOperation }); + expect(await db.select().from(agentConfigRevisions).where(eq(agentConfigRevisions.agentId, agent.id))).toHaveLength(0); + }); + + it("rolls back configuration and verification invalidation in the binding transaction", async () => { + const agent = await hire(); + const before = await current(agent.id); + await expect(updateAgentConfigurationInTransaction(db, agent.id, { name: "Uncommitted" })) + .rejects.toThrow("requires a database transaction"); + expect(() => updateAgentConfigurationInTransaction(db, agent.id, { budgetMonthlyCents: 100 } as never)) + .toThrow("Budget changes require a root lifecycle command"); + await expect(db.transaction(async tx => agentConfiguration(tx as unknown as Db).update(agent.id, { name: "Uncommitted" }))) + .rejects.toThrow("root database"); + await expect(db.transaction(async tx => { + await updateAgentConfigurationInTransaction(tx as unknown as Db, agent.id, { adapterConfig: { command: "echo" } }); + expect((await tx.select().from(agents).where(eq(agents.id, agent.id)))[0].lifecycleVersion).toBe(before.lifecycleVersion + 1); + throw new Error("Binding change failed"); + })).rejects.toThrow("Binding change failed"); + expect(await current(agent.id)).toMatchObject({ adapterConfig: before.adapterConfig, + lifecycleVersion: before.lifecycleVersion, lifecycleOperation: before.lifecycleOperation }); + }); + + it("permits a board retry and rejects an agent or a different company", async () => { + const agent = await hire(); + function app(actor: Express.Request["actor"]) { + const app = express(); app.use(express.json()); + app.use((req, _res, next) => { req.actor = actor; next(); }); + app.use("/api", agentRoutes(db)); app.use(errorHandler); return app; + } + const board: Express.Request["actor"] = { type: "board", source: "session", userId: "board", companyIds: [companyId], + memberships: [{ companyId, membershipRole: "admin", status: "active" }] }; + await db.insert(companyMemberships).values({ companyId, principalType: "user", principalId: "board", membershipRole: "admin" }); + await db.insert(principalPermissionGrants).values(["agents:create", "agents:configure"].map(permissionKey => ({ companyId, principalType: "user", principalId: "board", permissionKey }))); + const url = `/api/agents/${agent.id}/lifecycle/retry`; + const response = await request(app(board)).post(url).send({}); + expect(response.status, JSON.stringify(response.body)).toBe(200); + expect(response.body.lifecycleState).toBe("preparing"); + expect(response.body).not.toHaveProperty("lifecycleOperation"); + expect(await db.select().from(activityLog).where(and(eq(activityLog.entityId, agent.id), eq(activityLog.action, "agent.lifecycle_retried")))) + .toEqual([expect.objectContaining({ actorType: "user", actorId: "board" })]); + await request(app({ type: "agent", source: "agent_key", companyId, agentId: agent.id })).post(url).send({}).expect(403); + const denied = await request(app({ ...board, companyIds: [], memberships: [] })).post(url).send({}); + expect([403, 404]).toContain(denied.status); + }); + + it("recovers an expired lease and never accepts an expired completion", async () => { + const agent = await hire("paused"); const store = createLifecycleStore(db); + await createAgentLifecycle(db).resumeAgent(agent.id); + const claim = await store.claim(agent.id, "first", new Date(Date.now() - 180_000)); + expect(claim).not.toBeNull(); + await store.setRequiredPlugins(claim!, "first", []); + await store.completeHost(claim!, "first"); + expect(await store.change(agent.id, "complete", { owner: "first", version: claim!.lifecycleVersion })).toBeNull(); + expect(await store.claim(agent.id, "second", new Date())).not.toBeNull(); + }); +}); + +describe("lifecycle transition rules", () => { + it("does not bypass authorization, verification, or cleanup", () => { + expect(() => transition("pending_approval", "resume")).toThrow(); + expect(transition("preparing", "complete")).toBe("verifying"); + expect(transition("terminating", "complete")).toBe("cleaning_up"); + expect(transition("cleaning_up", "complete")).toBe("terminated"); + expect(() => transition("terminated", "resume")).toThrow(); + expect(transition("terminating", "terminate")).toBe("terminating"); + }); +}); diff --git a/server/src/modules/agent-lifecycle/__tests__/policy-sweep.test.ts b/server/src/modules/agent-lifecycle/__tests__/policy-sweep.test.ts new file mode 100644 index 00000000000..0358e9e4a74 --- /dev/null +++ b/server/src/modules/agent-lifecycle/__tests__/policy-sweep.test.ts @@ -0,0 +1,63 @@ +import { agents, companies, createDb, type Db } from "@paperclipai/db"; +import { asc, eq } from "drizzle-orm"; +import { afterAll, beforeAll, describe, expect, it, vi } from "vitest"; +import { startAgentLifecycle } from "../index.js"; +import { createAgentLifecycleEffects } from "../../../services/agent-lifecycle.js"; +import { getEmbeddedPostgresTestSupport, startEmbeddedPostgresTestDatabase } from "../../../__tests__/helpers/embedded-postgres.js"; + +const support = await getEmbeddedPostgresTestSupport(); +(support.supported ? describe : describe.skip)("lifecycle policy sweep", () => { + let database: Awaited>; + let db: Db; + beforeAll(async () => { + database = await startEmbeddedPostgresTestDatabase("paperclip-lifecycle-policy-"); + db = createDb(database.connectionString); + }, 90_000); + afterAll(async () => { await database?.cleanup(); }); + + it("caps each policy page, skips ineligible agents, and returns to the first page", async () => { + const [company] = await db.insert(companies).values({ name: "Policy pages", issuePrefix: "POL" }).returning(); + const eligible = await db.insert(agents).values(Array.from({ length: 101 }, (_, index) => ({ + id: `00000000-0000-4000-8000-${String(index + 1).padStart(12, "0")}`, + companyId: company.id, name: `Agent ${index}`, status: "idle", lifecycleState: "ready" as const, + lifecycleHolds: ["company_paused"], pauseReason: "company_paused", + }))).returning(); + const excluded = await db.insert(agents).values((["pending_approval", "terminating", "cleaning_up", "terminated", "rejected"] as const).map(lifecycleState => ({ + companyId: company.id, name: lifecycleState, status: "terminated", lifecycleState, + lifecycleHolds: ["company_paused"], pauseReason: "company_paused", + }))).returning(); + const effects = createAgentLifecycleEffects(); + const transaction = vi.spyOn(effects, "transaction"); + const now = Date.now(); + const clock = vi.spyOn(Date, "now").mockReturnValue(now); + const timer = vi.spyOn(globalThis, "setInterval").mockImplementation(() => ({ unref() {} }) as ReturnType); + const clearTimer = vi.spyOn(globalThis, "clearInterval").mockImplementation(() => {}); + const work = startAgentLifecycle(db, effects, { + requiredPluginIds: async () => [], runHost: async () => "pending", runPlugin: async () => "pending", + }, () => true); + const rows = () => db.select().from(agents).where(eq(agents.companyId, company.id)).orderBy(asc(agents.id)); + try { + await work.sweep(); + expect(transaction).toHaveBeenCalledTimes(100); + expect((await rows()).filter(row => row.lifecycleHolds.length === 0)).toHaveLength(100); + await work.sweep(); + expect(transaction).toHaveBeenCalledTimes(100); + clock.mockReturnValue(now + 60_001); + await work.sweep(); + expect(transaction).toHaveBeenCalledTimes(101); + expect((await rows()).filter(row => row.lifecycleHolds.length > 0).map(row => row.id).sort()) + .toEqual(excluded.map(row => row.id).sort()); + await db.update(agents).set({ lifecycleHolds: ["company_paused"] }).where(eq(agents.id, eligible[0].id)); + clock.mockReturnValue(now + 120_002); + await work.sweep(); + expect(transaction).toHaveBeenCalledTimes(201); + expect((await rows())[0].lifecycleHolds).toEqual([]); + } finally { + await work.stop(); + transaction.mockRestore(); + clock.mockRestore(); + timer.mockRestore(); + clearTimer.mockRestore(); + } + }); +}); diff --git a/server/src/modules/agent-lifecycle/adapters/approvals.ts b/server/src/modules/agent-lifecycle/adapters/approvals.ts new file mode 100644 index 00000000000..e1c21fe195a --- /dev/null +++ b/server/src/modules/agent-lifecycle/adapters/approvals.ts @@ -0,0 +1,96 @@ +import { agentAppearanceSchema } from "@paperclipai/shared"; +import { approvals, type Db } from "@paperclipai/db"; +import { and, desc, eq, inArray, sql } from "drizzle-orm"; +import { unprocessable } from "../../../errors.js"; +import { approvalResolutionRecords, resolvableApprovalStatuses } from "../../../lib/approval-records.js"; +import { agentRecords } from "./records.js"; +import { createLifecycleStore } from "./postgres.js"; +import type { LifecycleEffects } from "./effects.js"; + +export type HireDecisionTarget = string | { approvalId: string }; +type HireDecisionResult = { + approval: typeof approvals.$inferSelect | null; + agent: Awaited["getById"]>>; + applied: boolean; + activated: boolean; + hireApprovedAgentId: string | null; +}; + +export function hireApprovalService(db: Db, effects: LifecycleEffects) { + const { getExistingApproval, resolveApproval } = approvalResolutionRecords(db); + async function decide(target: HireDecisionTarget, status: "approved" | "rejected", userId: string, note?: string | null): Promise { + const initial = typeof target === "string" + ? await agentRecords(db, effects).getById(target) + : await getExistingApproval(target.approvalId); + if (!initial) return null; + if (typeof target !== "string" && (!("type" in initial) || initial.type !== "hire_agent")) throw unprocessable("Expected a hire approval"); + const companyId = initial.companyId; + // Hire decisions acquire the company lock before changing an approval or agent. + return effects.transaction(db, companyId, async (tx, publications) => { + const records = agentRecords(tx, effects); + let approvalId = typeof target === "string" ? null : target.approvalId; + if (typeof target === "string") { + const [open] = await tx.select({ id: approvals.id }).from(approvals).where(and( + eq(approvals.companyId, companyId), eq(approvals.type, "hire_agent"), + inArray(approvals.status, resolvableApprovalStatuses), + sql`${approvals.payload}->>'agentId' = ${target}`, + )).orderBy(desc(approvals.createdAt)).limit(1); + approvalId = open?.id ?? null; + } + let approval: typeof approvals.$inferSelect | null = null; + let applied = true; + if (approvalId) { + const result = await resolveApproval(approvalId, status, userId, note, tx); + approval = result.approval; + applied = result.applied; + } + const payload = approval?.payload ?? {}; + let agentId = typeof target === "string" ? target : typeof payload.agentId === "string" ? payload.agentId : null; + if (applied && status === "approved") { + if (agentId) { + const activated = await records.activatePendingApproval(agentId, approval ? payload : null, approval ? approval.requestedByUserId : userId); + if (!approval) applied = activated?.activated ?? false; + } else { + const created = await records.create(companyId, { + name: String(payload.name ?? "New Agent"), + appearance: payload.appearance == null ? undefined : agentAppearanceSchema.parse(payload.appearance), + role: String(payload.role ?? "general"), + title: typeof payload.title === "string" ? payload.title : null, + reportsTo: typeof payload.reportsTo === "string" ? payload.reportsTo : null, + capabilities: typeof payload.capabilities === "string" ? payload.capabilities : null, + adapterType: String(payload.adapterType ?? "process"), + adapterConfig: + typeof payload.adapterConfig === "object" && payload.adapterConfig !== null + ? (payload.adapterConfig as Record) + : {}, + budgetMonthlyCents: + typeof payload.budgetMonthlyCents === "number" ? payload.budgetMonthlyCents : 0, + metadata: + typeof payload.metadata === "object" && payload.metadata !== null + ? (payload.metadata as Record) + : null, + status: "idle", + spentMonthlyCents: 0, + permissions: undefined, + lastHeartbeatAt: null, + }, { createdByUserId: approval!.requestedByAgentId ? null : approval!.requestedByUserId, responsibleUserId: approval!.requestedByUserId }); + agentId = created.id; + } + if (approval && agentId && typeof payload.budgetMonthlyCents === "number" && payload.budgetMonthlyCents > 0) { + await effects.setAgentBudget(tx, publications, companyId, agentId, payload.budgetMonthlyCents, userId); + } + } else if (applied && agentId) { + if (approval) await records.rejectPendingHire(agentId); + else { + const before = await records.getById(agentId); + await createLifecycleStore(tx, effects).change(agentId, "reject"); + applied = before?.lifecycleState !== "rejected"; + } + } + return { approval, agent: agentId ? await records.getById(agentId) : null, applied, + activated: status === "approved" && applied, + hireApprovedAgentId: status === "approved" && applied ? agentId : null }; + }); + } + return { decide }; +} diff --git a/server/src/modules/agent-lifecycle/adapters/company-deletion.ts b/server/src/modules/agent-lifecycle/adapters/company-deletion.ts new file mode 100644 index 00000000000..5d27552b391 --- /dev/null +++ b/server/src/modules/agent-lifecycle/adapters/company-deletion.ts @@ -0,0 +1,19 @@ +import { agents } from "@paperclipai/db"; +import { and, eq, inArray } from "drizzle-orm"; +import type { CompanyDeletionParticipant } from "../../../lib/company-deletion.js"; +import { AgentLifecycleConflict, assertAgentPurgeAllowed } from "../domain/policy.js"; + +export const agentLifecycleCompanyDeletion: CompanyDeletionParticipant = { + async deleteCompanyData(tx, companyId) { + if (!("nestedIndex" in tx)) { + throw new AgentLifecycleConflict("Company deletion requires a database transaction"); + } + const rows = await tx.select({ lifecycleState: agents.lifecycleState }).from(agents) + .where(eq(agents.companyId, companyId)).for("update"); + for (const agent of rows) assertAgentPurgeAllowed(agent); + await tx.delete(agents).where(and( + eq(agents.companyId, companyId), + inArray(agents.lifecycleState, ["terminated", "rejected"]), + )); + }, +}; diff --git a/server/src/modules/agent-lifecycle/adapters/configuration.ts b/server/src/modules/agent-lifecycle/adapters/configuration.ts new file mode 100644 index 00000000000..70a8e44d5d8 --- /dev/null +++ b/server/src/modules/agent-lifecycle/adapters/configuration.ts @@ -0,0 +1,32 @@ +import { randomUUID } from "node:crypto"; +import { eq } from "drizzle-orm"; +import { agents, type Db } from "@paperclipai/db"; +import { agentRecordQueries, AGENT_CONFIGURATION_FIELDS, jsonEqual, type AgentConfigurationPatch, type UpdateAgentOptions } from "../../../lib/agent-records.js"; +import type { ActivityPublication } from "../../../types/activity-publication.js"; +import { AgentLifecycleConflict } from "../domain/policy.js"; +import type { LifecycleEffects } from "./effects.js"; + +export async function updateAgentConfiguration(tx: Db, effects: LifecycleEffects, id: string, data: AgentConfigurationPatch, options?: UpdateAgentOptions, publications: ActivityPublication[] = []) { + if (!("nestedIndex" in tx)) throw new AgentLifecycleConflict("Configuration integration requires a database transaction"); + assertConfigurationFields(data); + const [current] = await tx.select().from(agents).where(eq(agents.id, id)).for("update"); + if (!current) return null; + const patch = await effects.prepareConfiguration(tx, current, data, options); + assertConfigurationFields(patch); + const changed = ["adapterType", "adapterConfig", "runtimeConfig", "defaultEnvironmentId"].some(key => + Object.prototype.hasOwnProperty.call(patch, key) && !jsonEqual(patch[key as keyof typeof patch], current[key as keyof typeof current])); + const invalidate = changed && ["preparing", "verifying", "resuming"].includes(current.lifecycleState); + const [updated] = await tx.update(agents).set({ ...patch, updatedAt: new Date(), ...(invalidate ? { + lifecycleVersion: current.lifecycleVersion + 1, lifecycleError: null, + lifecycleOperation: { ...current.lifecycleOperation!, id: randomUUID(), hostComplete: false, + completedPluginIds: [], leaseOwner: undefined, leaseUntil: undefined, retryAt: undefined }, + } : {}) }).where(eq(agents.id, id)).returning(); + await effects.completeConfiguration(tx, current, updated, patch, options, publications); + return agentRecordQueries(tx).getById(id); +} + +function assertConfigurationFields(data: AgentConfigurationPatch) { + if (Object.keys(data).some(field => !AGENT_CONFIGURATION_FIELDS.some(allowed => allowed === field))) { + throw new AgentLifecycleConflict("Unsupported configuration field; use the command that owns this field, such as a lifecycle command"); + } +} diff --git a/server/src/modules/agent-lifecycle/adapters/deletion.ts b/server/src/modules/agent-lifecycle/adapters/deletion.ts new file mode 100644 index 00000000000..e198181a4d5 --- /dev/null +++ b/server/src/modules/agent-lifecycle/adapters/deletion.ts @@ -0,0 +1,27 @@ +import { agents, type Db } from "@paperclipai/db"; +import { and, eq, inArray } from "drizzle-orm"; +import { conflict } from "../../../errors.js"; +import { agentRecordQueries } from "../../../lib/agent-records.js"; +import { readBuiltInAgentMarker } from "../../../lib/built-in-agent-metadata.js"; +import { assertAgentPurgeAllowed } from "../domain/policy.js"; +import type { LifecycleEffects } from "./effects.js"; + +export async function purgeAgent(db: Db, effects: LifecycleEffects, id: string) { + const { getById, normalizeAgentRow } = agentRecordQueries(db); + const existing = await getById(id); + if (!existing) return null; + return effects.transaction(db, existing.companyId, async tx => { + const [agent] = await tx.select().from(agents).where(eq(agents.id, id)).for("update"); + if (!agent) return null; + const marker = readBuiltInAgentMarker(agent.metadata); + if (marker) throw conflict("Built-in agents cannot be deleted; pause them instead", { + code: "built_in_agent_undeletable", key: marker.key, featureKeys: marker.featureKeys, + }); + assertAgentPurgeAllowed(agent); + await effects.deleteDependencies(tx, agent.companyId, id); + const [deleted] = await tx.delete(agents).where(and( + eq(agents.id, id), inArray(agents.lifecycleState, ["terminated", "rejected"]), + )).returning(); + return deleted ? normalizeAgentRow(deleted) : null; + }); +} diff --git a/server/src/modules/agent-lifecycle/adapters/effects.ts b/server/src/modules/agent-lifecycle/adapters/effects.ts new file mode 100644 index 00000000000..3df05e49b24 --- /dev/null +++ b/server/src/modules/agent-lifecycle/adapters/effects.ts @@ -0,0 +1,24 @@ +import type { LifecycleFailure } from "../application/ports.js"; +import type { Db } from "@paperclipai/db"; +import type { budgetPolicies } from "@paperclipai/db"; +import type { CreateAgentData, CreateAgentOptions, AgentConfigurationPatch, AgentConfigurationRecord, AgentHireRecord, UpdateAgentOptions } from "../../../lib/agent-records.js"; +import type { ActivityPublication } from "../../../types/activity-publication.js"; + +/** Services supply integrations; lifecycle owns the transaction and state writes. */ +export interface LifecycleEffects { + reportFailure(context: LifecycleFailure, error: unknown): void; + deleteDependencies(db: Db, companyId: string, agentId: string): Promise; + prepareConfiguration(db: Db, current: AgentConfigurationRecord, data: AgentConfigurationPatch, options?: UpdateAgentOptions): Promise; + completeConfiguration(db: Db, before: AgentConfigurationRecord, after: AgentConfigurationRecord, patch: AgentConfigurationPatch, options: UpdateAgentOptions | undefined, publications: ActivityPublication[]): Promise; + transaction(db: Db, companyId: string, work: (tx: Db, publications: ActivityPublication[]) => Promise): Promise; + policyBlocks(db: Db, policy: typeof budgetPolicies.$inferSelect): Promise; + setAgentBudget(db: Db, publications: ActivityPublication[], companyId: string, agentId: string, amount: number, userId: string | null, isActive?: boolean): Promise; + enforceBudget(db: Db, companyId: string, agentId: string): Promise; + recordCreation(db: Db, companyId: string, agentId: string): Promise; + recordStatus(db: Db, companyId: string, agentId: string, before: string, after: string): Promise; + clearPrimary(db: Db, companyId: string, agentId: string): Promise; + prepareHire(db: Db, companyId: string, data: CreateAgentData, options?: CreateAgentOptions): Promise; + initializeHire(db: Db, agent: AgentHireRecord, options?: CreateAgentOptions): Promise; + prepareHireApproval(db: Db, agent: AgentHireRecord, payload?: Record | null): Promise; + completeHireApproval(db: Db, agent: AgentHireRecord, previous: AgentHireRecord): Promise; +} diff --git a/server/src/modules/agent-lifecycle/adapters/postgres.ts b/server/src/modules/agent-lifecycle/adapters/postgres.ts new file mode 100644 index 00000000000..a5cde41e748 --- /dev/null +++ b/server/src/modules/agent-lifecycle/adapters/postgres.ts @@ -0,0 +1,151 @@ +import { randomUUID } from "node:crypto"; +import { and, asc, eq, inArray, sql } from "drizzle-orm"; +import { agents, agentApiKeys, companies, budgetPolicies, type Db } from "@paperclipai/db"; +import type { AgentLifecycleOperation } from "@paperclipai/shared"; +import { AgentLifecycleConflict, compatibilityStatus, transition } from "../domain/policy.js"; +import type { LifecycleEffects } from "./effects.js"; +import type { LifecycleStore } from "../application/ports.js"; + +export function assertRootDatabase(db: Db) { + if ("nestedIndex" in db) throw new AgentLifecycleConflict("Lifecycle commands require the root database connection"); +} + +export function createLifecycleStore(db: Db, effects: LifecycleEffects): LifecycleStore { + const get = (id: string) => db.select().from(agents).where(eq(agents.id, id)).then(rows => rows[0] ?? null); + return { + get, + async change(id, command, options = {}) { + const existing = await get(id); + if (!existing) return null; + return effects.transaction(db, existing.companyId, async tx => { + const [agent] = await tx.select().from(agents).where(eq(agents.id, id)).for("update", command === "reconcile" ? { skipLocked: true } : undefined); + if (!agent) return null; + if (options.version !== undefined && options.version !== agent.lifecycleVersion) return null; + if (command === "complete" && (!options.owner || !agent.lifecycleOperation?.leaseUntil || agent.lifecycleOperation?.leaseOwner !== options.owner || + Date.parse(agent.lifecycleOperation?.leaseUntil ?? "") <= Date.now() || + !agent.lifecycleOperation.hostComplete || agent.lifecycleRequiredPluginIds === null || + agent.lifecycleRequiredPluginIds.some(id => !agent.lifecycleOperation!.completedPluginIds.includes(id)))) return null; + if (command === "retry") { + transition(agent.lifecycleState, command); + if (agent.lifecycleOperation?.leaseUntil && Date.parse(agent.lifecycleOperation.leaseUntil) > Date.now()) return agent; + const [updated] = await tx.update(agents).set({ lifecycleError: null, + lifecycleOperation: sql`${agents.lifecycleOperation} - 'retryAt' - 'leaseOwner' - 'leaseUntil'`, updatedAt: new Date() }).where(eq(agents.id, id)).returning(); + return updated; + } + if (command === "resume" && !["ready", "paused", "pausing", "resuming"].includes(agent.lifecycleState)) transition(agent.lifecycleState, command); + let holds = agent.lifecycleHolds; + const reason = options.reason ?? "manual"; + if (command === "reconcile") { + if (["pending_approval", "terminating", "cleaning_up", "terminated", "rejected"].includes(agent.lifecycleState)) return agent; + const [company] = await tx.select().from(companies).where(eq(companies.id, agent.companyId)); + const policies = await tx.select().from(budgetPolicies).where(and(eq(budgetPolicies.companyId, agent.companyId), + eq(budgetPolicies.scopeType, "agent"), eq(budgetPolicies.scopeId, id))); + let budgetBlocked = false; + for (const policy of policies) if (await effects.policyBlocks(tx, policy)) budgetBlocked = true; + holds = holds.filter(hold => hold !== "budget" && hold !== "company_archived" && hold !== "company_paused"); + if (budgetBlocked) holds.push("budget"); + if (company.status === "archived") holds.push("company_archived"); + if (company.status === "paused") holds.push("company_paused"); + } + if (command === "pause") holds = [...new Set([...holds, reason])]; + if (command === "resume") holds = holds.filter(hold => reason === "user" ? ["budget", "company_archived", "company_paused"].includes(hold) : hold !== reason); + let next = command === "reconcile" + ? holds.length && !["pausing", "paused"].includes(agent.lifecycleState) ? "pausing" as const + : !holds.length && agent.lifecycleState === "paused" ? "resuming" as const : agent.lifecycleState + : command === "resume" && (holds.length || agent.lifecycleState === "pausing") ? agent.lifecycleState + : transition(agent.lifecycleState, command, agent.lifecycleOperation?.resumeState); + if (command === "complete" && next === "ready" && holds.length) next = "pausing"; + if (command === "complete" && next === "paused" && !holds.length) next = "resuming"; + if (next === agent.lifecycleState) { + if (JSON.stringify(holds) !== JSON.stringify(agent.lifecycleHolds) || agent.pauseReason !== (holds[0] ?? null)) { + await tx.update(agents).set({ lifecycleHolds: holds, pauseReason: holds[0] ?? null }).where(eq(agents.id, id)); + } + return agent; + } + const operation: AgentLifecycleOperation = { + responsibleUserId: agent.lifecycleOperation?.responsibleUserId, + id: randomUUID(), hostComplete: false, completedPluginIds: [], attempts: 0, + resumeState: next === "pausing" + ? agent.lifecycleState === "preparing" || agent.lifecycleState === "verifying" ? agent.lifecycleState : agent.lifecycleOperation?.resumeState ?? "ready" + : agent.lifecycleOperation?.resumeState, + }; + if (next === "ready") operation.resumeState = "ready"; + const status = compatibilityStatus(next, agent.status); + const [updated] = await tx.update(agents).set({ + lifecycleHolds: holds, lifecycleState: next, lifecycleVersion: agent.lifecycleVersion + 1, lifecycleError: null, + lifecycleOperation: operation, status, + pauseReason: holds[0] ?? null, + pausedAt: next === "pausing" ? new Date() : next === "ready" ? null : agent.pausedAt, + updatedAt: new Date(), + }).where(eq(agents.id, id)).returning(); + if (next === "terminating" || next === "rejected") { + await tx.update(agentApiKeys).set({ revokedAt: new Date() }).where(eq(agentApiKeys.agentId, id)); + await effects.clearPrimary(tx, agent.companyId, id); + } + if (command === "approve") await effects.recordCreation(tx, agent.companyId, id); + if (next === "pausing" || next === "resuming" || next === "terminating" || next === "rejected") { + await effects.recordStatus(tx, agent.companyId, id, + next === "resuming" ? "paused" : "idle", + next === "resuming" ? "idle" : next === "pausing" ? "paused" : "terminated"); + } + return updated; + }); + }, + async claim(id, owner, now) { + const [agent] = await db.update(agents).set({ + lifecycleOperation: sql`coalesce(${agents.lifecycleOperation}, '{"id":"", "hostComplete":false, "completedPluginIds":[], "attempts":0}'::jsonb) + || jsonb_build_object('leaseOwner', ${owner}::text, 'leaseUntil', ${(new Date(now.getTime() + 120_000)).toISOString()}::text, + 'attempts', coalesce((${agents.lifecycleOperation}->>'attempts')::integer, 0) + 1)`, + }).where(and(eq(agents.id, id), inArray(agents.lifecycleState, ["preparing", "verifying", "pausing", "resuming", "terminating", "cleaning_up"]), + sql`coalesce((${agents.lifecycleOperation}->>'leaseUntil')::timestamptz, '-infinity') <= ${now.toISOString()}::timestamptz`, + sql`coalesce((${agents.lifecycleOperation}->>'retryAt')::timestamptz, '-infinity') <= ${now.toISOString()}::timestamptz`, + )).returning(); + return agent ?? null; + }, + async renew(agent, owner, now) { + const rows = await db.update(agents).set({ lifecycleOperation: sql`jsonb_set(${agents.lifecycleOperation}, '{leaseUntil}', ${JSON.stringify(new Date(now.getTime() + 120_000).toISOString())}::jsonb)` }) + .where(and(eq(agents.id, agent.id), eq(agents.lifecycleVersion, agent.lifecycleVersion), sql`${agents.lifecycleOperation}->>'leaseOwner' = ${owner}`)).returning({ id: agents.id }); + return rows.length > 0; + }, + async setRequiredPlugins(agent, owner, pluginIds) { + const rows = await db.update(agents).set({ lifecycleRequiredPluginIds: pluginIds }) + .where(and(eq(agents.id, agent.id), eq(agents.lifecycleVersion, agent.lifecycleVersion), + sql`${agents.lifecycleRequiredPluginIds} is null`, + sql`${agents.lifecycleOperation}->>'leaseOwner' = ${owner}`)).returning({ id: agents.id }); + return rows.length > 0; + }, + async completeHost(agent, owner) { + const rows = await db.update(agents).set({ + lifecycleOperation: sql`jsonb_set(${agents.lifecycleOperation}, '{hostComplete}', 'true'::jsonb)`, + }).where(and(eq(agents.id, agent.id), eq(agents.lifecycleVersion, agent.lifecycleVersion), + sql`${agents.lifecycleOperation}->>'leaseOwner' = ${owner}`)).returning({ id: agents.id }); + return rows.length > 0; + }, + async completePlugin(agent, owner, pluginId) { + const rows = await db.update(agents).set({ + lifecycleOperation: sql`jsonb_set(${agents.lifecycleOperation}, '{completedPluginIds}', + coalesce(${agents.lifecycleOperation}->'completedPluginIds', '[]'::jsonb) || ${JSON.stringify([pluginId])}::jsonb)`, + }).where(and(eq(agents.id, agent.id), eq(agents.lifecycleVersion, agent.lifecycleVersion), + sql`${agents.lifecycleRequiredPluginIds} @> ${JSON.stringify([pluginId])}::jsonb`, + sql`${agents.lifecycleOperation}->>'leaseOwner' = ${owner}`)).returning({ id: agents.id }); + return rows.length > 0; + }, + async defer(agent, owner, error, now) { + const rows = await db.update(agents).set({ + lifecycleError: error, + lifecycleOperation: sql`(${agents.lifecycleOperation} - 'leaseOwner' - 'leaseUntil') + || jsonb_build_object('retryAt', ${new Date(now.getTime() + (error ? 60_000 : 2_000)).toISOString()}::text)`, + updatedAt: now, + }).where(and(eq(agents.id, agent.id), eq(agents.lifecycleVersion, agent.lifecycleVersion), + sql`${agents.lifecycleOperation}->>'leaseOwner' = ${owner}`)).returning({ id: agents.id }); + return rows.length > 0; + }, + async pending(limit, now) { + return db.select({ id: agents.id }).from(agents).where(and( + inArray(agents.lifecycleState, ["preparing", "verifying", "pausing", "resuming", "terminating", "cleaning_up"]), + sql`coalesce((${agents.lifecycleOperation}->>'leaseUntil')::timestamptz, '-infinity') <= ${now.toISOString()}::timestamptz`, + sql`coalesce((${agents.lifecycleOperation}->>'retryAt')::timestamptz, '-infinity') <= ${now.toISOString()}::timestamptz`, + )).orderBy(asc(agents.updatedAt), asc(agents.id)).limit(limit).then(rows => rows.map(row => row.id)); + }, + }; +} diff --git a/server/src/modules/agent-lifecycle/adapters/records.ts b/server/src/modules/agent-lifecycle/adapters/records.ts new file mode 100644 index 00000000000..bf2ec0cd47f --- /dev/null +++ b/server/src/modules/agent-lifecycle/adapters/records.ts @@ -0,0 +1,118 @@ +import type { LifecycleEffects } from "./effects.js"; +import { randomUUID } from "node:crypto"; +import { and, eq, sql } from "drizzle-orm"; +import { agents, agentApiKeys, type Db } from "@paperclipai/db"; +import { conflict, notFound } from "../../../errors.js"; +import { agentRecordQueries, type CreateAgentOptions, type CreateAgentData } from "../../../lib/agent-records.js"; + +export function agentRecords(db: Db, effects: LifecycleEffects) { + const { getById } = agentRecordQueries(db); + + return { + getById, + create: async (companyId: string, data: CreateAgentData, options?: CreateAgentOptions) => { + if (Object.keys(data).some(key => key.startsWith("lifecycle"))) throw conflict("Lifecycle fields belong to the lifecycle module"); + return effects.transaction(db, companyId, async (txDb) => { + const tx = txDb; + const prepared = await effects.prepareHire(txDb, companyId, data, options); + const created = await tx + .insert(agents) + .values({ + ...prepared, + lifecycleState: data.status === "pending_approval" ? "pending_approval" : data.status === "terminated" ? "terminated" : data.status === "paused" ? "paused" : "preparing", + lifecycleVersion: 1, + lifecycleHolds: data.status === "paused" ? [data.pauseReason ?? "manual"] : [], + pauseReason: data.status === "paused" ? data.pauseReason ?? "manual" : null, + pausedAt: data.status === "paused" ? new Date() : null, + lifecycleOperation: { id: randomUUID(), hostComplete: false, completedPluginIds: [], attempts: 0, resumeState: "preparing", responsibleUserId: options?.responsibleUserId ?? options?.createdByUserId }, + status: data.status === "pending_approval" ? "pending_approval" : data.status === "terminated" ? "terminated" : "paused", + companyId, + }) + .returning() + .then((rows) => rows[0]); + await effects.initializeHire(txDb, created, options); + if (created.status !== "pending_approval" && created.status !== "terminated") { + await effects.recordCreation(txDb, companyId, created.id); + } + const normalizedCreated = await agentRecordQueries(txDb).getById(created.id); + if (!normalizedCreated) { + throw notFound("Agent not found"); + } + return normalizedCreated; + }); + }, + + clearError: async (id: string) => { + const existing = await getById(id); + if (!existing) return null; + if (existing.status === "terminated") throw conflict("Cannot clear error on terminated agent"); + if (existing.status === "pending_approval") { + throw conflict("Pending approval agents cannot have errors cleared"); + } + if (existing.status !== "error") { + throw conflict("Only agents in error status can have their error cleared"); + } + + const updated = await db + .update(agents) + .set({ + status: "idle", + pauseReason: null, + pausedAt: null, + errorReason: null, + updatedAt: new Date(), + }) + .where(and(eq(agents.id, id), eq(agents.status, "error"), eq(agents.lifecycleState, "ready"))) + .returning() + .then((rows) => rows[0] ?? null); + + if (!updated) { + throw conflict("Only agents in error status can have their error cleared"); + } + return getById(updated.id); + }, + + rejectPendingHire: async (id: string) => { + const rows = await db.update(agents).set({ status: "terminated", lifecycleState: "rejected", + lifecycleVersion: sql`${agents.lifecycleVersion} + 1`, lifecycleOperation: null, + updatedAt: new Date() }).where(and(eq(agents.id, id), eq(agents.lifecycleState, "pending_approval"))).returning(); + for (const row of rows) { + await effects.clearPrimary(db, row.companyId, id); + await db.update(agentApiKeys).set({ revokedAt: new Date() }).where(eq(agentApiKeys.agentId, id)); + await effects.recordStatus(db, row.companyId, id, "pending_approval", "terminated"); + } + return rows; + }, + + activatePendingApproval: async (id: string, approvedPayload?: Record | null, requestedByUserId?: string | null) => { + const activatedAgent = await db.transaction(async (tx) => { + const txDb = tx as unknown as Db; + const existing = await agentRecordQueries(txDb).getById(id); + if (!existing || existing.status !== "pending_approval") return null; + const patch = await effects.prepareHireApproval(txDb, existing, approvedPayload); + const updated = await tx + .update(agents) + .set({ ...patch, status: "paused", lifecycleState: "preparing", lifecycleVersion: existing.lifecycleVersion + 1, lifecycleError: null, lifecycleOperation: sql`jsonb_build_object('id', ${randomUUID()}::text, 'hostComplete', false, 'completedPluginIds', '[]'::jsonb, 'attempts', 0, 'responsibleUserId', coalesce(nullif(${agents.lifecycleOperation}->'responsibleUserId', 'null'::jsonb), to_jsonb(${requestedByUserId ?? null}::text)))`, updatedAt: new Date() }) + .where(and(eq(agents.id, id), eq(agents.status, "pending_approval"))) + .returning() + .then((rows) => rows[0] ?? null); + if (!updated) return null; + await effects.completeHireApproval(txDb, updated, existing); + await effects.recordCreation(txDb, existing.companyId, updated.id); + const agent = await agentRecordQueries(txDb).getById(updated.id); + if (!agent) { + throw notFound("Agent not found"); + } + return agent; + }); + + if (activatedAgent) { + return { agent: activatedAgent, activated: true }; + } + + const existing = await getById(id); + return existing ? { agent: existing, activated: false } : null; + }, + + }; +} diff --git a/server/src/modules/agent-lifecycle/application/ports.ts b/server/src/modules/agent-lifecycle/application/ports.ts new file mode 100644 index 00000000000..1845ad8b7d1 --- /dev/null +++ b/server/src/modules/agent-lifecycle/application/ports.ts @@ -0,0 +1,41 @@ +import type { AgentLifecycleOperation, AgentLifecycleState } from "@paperclipai/shared"; +import type { LifecycleCommand } from "../domain/policy.js"; + +export interface LifecycleAgent { + id: string; + companyId: string; + lifecycleState: AgentLifecycleState; + lifecycleVersion: number; + lifecycleRequiredPluginIds: string[] | null; + lifecycleError: string | null; + lifecycleOperation: AgentLifecycleOperation | null; +} + +export interface LifecycleStore { + get(id: string): Promise; + change(id: string, command: LifecycleCommand, options?: { version?: number; owner?: string; reason?: string }): Promise; + claim(id: string, owner: string, now: Date): Promise; + renew(agent: LifecycleAgent, owner: string, now: Date): Promise; + setRequiredPlugins(agent: LifecycleAgent, owner: string, pluginIds: string[]): Promise; + completeHost(agent: LifecycleAgent, owner: string): Promise; + completePlugin(agent: LifecycleAgent, owner: string, pluginId: string): Promise; + defer(agent: LifecycleAgent, owner: string, error: string | null, now: Date): Promise; + pending(limit: number, now: Date): Promise; +} + +export interface LifecycleDriver { + requiredPluginIds(agent: LifecycleAgent): Promise; + runHost(agent: LifecycleAgent): Promise<"complete" | "pending">; + runPlugin(agent: LifecycleAgent, pluginId: string): Promise<"complete" | "pending">; +} + +export interface LifecycleFailure { + stage: "claim" | "renew" | "select_plugins" | "save_plugins" | "host" | "plugin" + | "complete_host" | "complete_plugin" | "transition" | "defer" | "scan" | "policy_scan"; + agentId?: string; + companyId?: string; + phase?: AgentLifecycleState; + operationId?: string; + version?: number; + pluginId?: string; +} diff --git a/server/src/modules/agent-lifecycle/application/worker.ts b/server/src/modules/agent-lifecycle/application/worker.ts new file mode 100644 index 00000000000..ad1c143dd96 --- /dev/null +++ b/server/src/modules/agent-lifecycle/application/worker.ts @@ -0,0 +1,96 @@ +import { randomUUID } from "node:crypto"; +import type { LifecycleDriver, LifecycleStore, LifecycleFailure } from "./ports.js"; +import { isLifecycleWorkPending } from "../domain/policy.js"; + +/** Database leases protect each attempt across server processes. */ +export function createLifecycleWorker(store: LifecycleStore, driver: LifecycleDriver, reportFailure: (context: LifecycleFailure, error: unknown) => void, canRun = () => true) { + let stopped = false; + const active = new Map>(); + let running: Promise | undefined; + + async function attempt(context: LifecycleFailure, work: () => Promise): Promise { + try { return await work(); } + catch (error) { reportFailure(context, error); throw error; } + } + + async function process(id: string) { + phase: for (let step = 0; !stopped && canRun() && step < 8; step++) { + const owner = randomUUID(); + const agent = await attempt({ stage: "claim", agentId: id }, () => store.claim(id, owner, new Date())); + if (!agent || !isLifecycleWorkPending(agent.lifecycleState)) return; + const context = { agentId: agent.id, companyId: agent.companyId, phase: agent.lifecycleState, + operationId: agent.lifecycleOperation?.id, version: agent.lifecycleVersion }; + const runStep = (stage: LifecycleFailure["stage"], work: () => Promise, pluginId?: string) => + attempt({ ...context, stage, ...(pluginId ? { pluginId } : {}) }, work); + const renewal = setInterval(() => { + void runStep("renew", () => store.renew(agent, owner, new Date())).catch(() => {}); + }, 30_000); + renewal.unref?.(); + try { + const operation = agent.lifecycleOperation!; + const pluginIds = agent.lifecycleRequiredPluginIds ?? await runStep("select_plugins", () => driver.requiredPluginIds(agent)); + if (agent.lifecycleRequiredPluginIds === null && !await runStep("save_plugins", () => store.setRequiredPlugins(agent, owner, pluginIds))) continue; + if (!canRun()) { + await runStep("defer", () => store.defer(agent, owner, null, new Date())); + return; + } + if (!operation.hostComplete) { + if (!await runStep("renew", () => store.renew(agent, owner, new Date()))) continue; + if (await runStep("host", () => driver.runHost(agent)) === "pending") { + if (!await runStep("defer", () => store.defer(agent, owner, null, new Date()))) continue; + return; + } + if (!await runStep("complete_host", () => store.completeHost(agent, owner))) continue; + } + for (const pluginId of pluginIds) { + if (operation.completedPluginIds.includes(pluginId)) continue; + if (!canRun()) { + await runStep("defer", () => store.defer(agent, owner, null, new Date())); + return; + } + if (!await runStep("renew", () => store.renew(agent, owner, new Date()))) continue phase; + if (await runStep("plugin", () => driver.runPlugin(agent, pluginId), pluginId) === "pending") { + if (!await runStep("defer", () => store.defer(agent, owner, null, new Date()))) continue phase; + return; + } + if (!await runStep("complete_plugin", () => store.completePlugin(agent, owner, pluginId), pluginId)) continue phase; + } + const changed = await runStep("transition", () => store.change(id, "complete", { version: agent.lifecycleVersion, owner })); + if (changed && !isLifecycleWorkPending(changed.lifecycleState)) return; + } catch { + if (!await runStep("defer", () => store.defer(agent, owner, "The lifecycle step failed. Retry the operation.", new Date()))) continue; + return; + } finally { + clearInterval(renewal); + } + } + } + + async function sweep() { + const pending = await attempt({ stage: "scan" }, () => store.pending(100, new Date())); + const entries = pending.values(); + await Promise.all(Array.from({ length: Math.min(4, pending.length) }, async () => { + for (const id of entries) await start(id); + })); + } + + function start(id: string): Promise { + if (stopped || !canRun()) return Promise.resolve(); + const existing = active.get(id); + if (existing) return existing; + const work = process(id).finally(() => { active.delete(id); }); + active.set(id, work); + return work; + } + + return { + process: start, + async stop() { + stopped = true; + await Promise.allSettled([...active.values()]); + }, + sweep() { + return running ??= sweep().finally(() => { running = undefined; }); + }, + }; +} diff --git a/server/src/modules/agent-lifecycle/company-deletion.ts b/server/src/modules/agent-lifecycle/company-deletion.ts new file mode 100644 index 00000000000..6ec8a8bad68 --- /dev/null +++ b/server/src/modules/agent-lifecycle/company-deletion.ts @@ -0,0 +1 @@ +export { agentLifecycleCompanyDeletion } from "./adapters/company-deletion.js"; diff --git a/server/src/modules/agent-lifecycle/configuration.ts b/server/src/modules/agent-lifecycle/configuration.ts new file mode 100644 index 00000000000..c82463ec52e --- /dev/null +++ b/server/src/modules/agent-lifecycle/configuration.ts @@ -0,0 +1 @@ +export { updateAgentConfiguration } from "./adapters/configuration.js"; diff --git a/server/src/modules/agent-lifecycle/domain/policy.ts b/server/src/modules/agent-lifecycle/domain/policy.ts new file mode 100644 index 00000000000..520193ee6fc --- /dev/null +++ b/server/src/modules/agent-lifecycle/domain/policy.ts @@ -0,0 +1,63 @@ +import type { AgentLifecycleState } from "@paperclipai/shared"; + +export type LifecycleCommand = "reconcile" | "approve" | "reject" | "pause" | "resume" | "terminate" | "complete" | "retry"; +export class AgentLifecycleConflict extends Error { + constructor(message: string) { super(message); this.name = "AgentLifecycleConflict"; } +} + +export function canConfigureAgentConnection(agent: { lifecycleState: string; status: string }): boolean { + return agent.lifecycleState === "preparing" || agent.lifecycleState === "verifying" + || (agent.lifecycleState === "ready" && !["paused", "terminated", "pending_approval"].includes(agent.status)); +} + +export function isAgentAwaitingSetup(agent: { lifecycleState: string; lifecycleHolds: readonly string[] }): boolean { + return ["preparing", "verifying", "resuming"].includes(agent.lifecycleState) && agent.lifecycleHolds.length === 0; +} + +export function transition(state: AgentLifecycleState, command: LifecycleCommand, + resumeState: "preparing" | "verifying" | "ready" = "ready"): AgentLifecycleState { + if (command === "retry") { + if (["preparing", "verifying", "pausing", "resuming", "terminating", "cleaning_up"].includes(state)) return state; + } else if (command === "terminate") { + if (["terminated", "rejected", "terminating", "cleaning_up"].includes(state)) return state; + return "terminating"; + } else if (command === "approve") { + if (state === "pending_approval") return "preparing"; + } else if (command === "reject") { + if (state === "pending_approval") return "rejected"; + if (state === "rejected") return state; + } else if (command === "pause") { + if (state === "paused" || state === "pausing") return state; + if (["ready", "preparing", "verifying", "resuming"].includes(state)) return "pausing"; + } else if (command === "resume") { + if (state === "ready" || state === "resuming") return state; + if (state === "paused") return "resuming"; + } else if (command === "complete") { + switch (state) { + case "preparing": return "verifying"; + case "verifying": return "ready"; + case "pausing": return "paused"; + case "resuming": return resumeState; + case "terminating": return "cleaning_up"; + case "cleaning_up": return "terminated"; + } + } + throw new AgentLifecycleConflict(`Cannot ${command} an agent in state ${state}`); +} + +export function compatibilityStatus(state: AgentLifecycleState, executionStatus = "idle"): string { + if (state === "ready") return ["active", "idle", "running", "error"].includes(executionStatus) ? executionStatus : "idle"; + if (state === "pending_approval") return "pending_approval"; + if (["terminating", "cleaning_up", "terminated", "rejected"].includes(state)) return "terminated"; + return "paused"; +} + +export function isLifecycleWorkPending(state: AgentLifecycleState): boolean { + return ["preparing", "verifying", "pausing", "resuming", "terminating", "cleaning_up"].includes(state); +} + +export function assertAgentPurgeAllowed(agent: { lifecycleState: string }) { + if (!["terminated", "rejected"].includes(agent.lifecycleState)) { + throw new AgentLifecycleConflict("Complete termination before deleting the agent"); + } +} diff --git a/server/src/modules/agent-lifecycle/index.ts b/server/src/modules/agent-lifecycle/index.ts new file mode 100644 index 00000000000..ba8abce8c37 --- /dev/null +++ b/server/src/modules/agent-lifecycle/index.ts @@ -0,0 +1,144 @@ +import { hireApprovalService as approvalRecords, type HireDecisionTarget } from "./adapters/approvals.js"; +import { agents } from "@paperclipai/db"; +import { and, asc, eq, gt, inArray } from "drizzle-orm"; +import type { Db } from "@paperclipai/db"; +import type { LifecycleEffects } from "./adapters/effects.js"; +export type { LifecycleEffects } from "./adapters/effects.js"; +import { updateAgentConfiguration } from "./adapters/configuration.js"; +import type { AgentConfigurationPatch, UpdateAgentOptions } from "../../lib/agent-records.js"; +import { purgeAgent } from "./adapters/deletion.js"; +import { agentRecords } from "./adapters/records.js"; +import { assertRootDatabase, createLifecycleStore } from "./adapters/postgres.js"; +import { createLifecycleWorker } from "./application/worker.js"; +import type { LifecycleDriver } from "./application/ports.js"; + +export { AgentLifecycleConflict, canConfigureAgentConnection, isAgentAwaitingSetup } from "./domain/policy.js"; + +export type { HireDecisionTarget } from "./adapters/approvals.js"; +export type { LifecycleDriver, LifecycleAgent, LifecycleFailure } from "./application/ports.js"; + +const policyStates = ["preparing", "verifying", "ready", "pausing", "paused", "resuming"] as const; +const policyPageSize = 100; + +const workers = new WeakMap>(); +export function configureAgentLifecycle(db: Db, effects: LifecycleEffects, driver: LifecycleDriver, canRun = () => true) { + assertRootDatabase(db); + const worker = createLifecycleWorker(createLifecycleStore(db, effects), driver, effects.reportFailure, canRun); + workers.set(db, worker); + return worker; +} +export function scheduleAgentLifecycle(db: Db, id: string) { + // The periodic sweep retries work if the process stops before this call. + return workers.get(db)?.process(id).catch(() => {}); +} + +export function createAgentLifecycle(db: Db, effects: LifecycleEffects) { + assertRootDatabase(db); + const records = agentRecords(db, effects); + const store = createLifecycleStore(db, effects); + async function change(id: string, command: "pause" | "resume" | "terminate" | "retry", reason?: string) { + const result = await store.change(id, command, { reason }); + if (result) scheduleAgentLifecycle(db, id); + return result ? records.getById(id) : null; + } + async function decideHire(target: HireDecisionTarget, decision: "approved" | "rejected", userId: string, note?: string | null) { + const result = await approvalRecords(db, effects).decide(target, decision, userId, note); + if (result?.hireApprovedAgentId) scheduleAgentLifecycle(db, result.hireApprovedAgentId); + return result; + } + return { + async get(id: string) { + const agent = await store.get(id); + return agent ? { + id: agent.id, companyId: agent.companyId, lifecycleState: agent.lifecycleState, + lifecycleVersion: agent.lifecycleVersion, lifecycleError: agent.lifecycleError, + } : null; + }, + async requestHire(...args: Parameters) { + const agent = await records.create(...args); + scheduleAgentLifecycle(db, agent.id); + return agent; + }, + approveHire: (target: HireDecisionTarget, userId = "board", note?: string | null) => decideHire(target, "approved", userId, note), + rejectHire: (target: HireDecisionTarget, userId = "board", note?: string | null) => decideHire(target, "rejected", userId, note), + async updateConfiguration(id: string, data: AgentConfigurationPatch, options?: UpdateAgentOptions) { + const existing = await records.getById(id); + if (!existing) return null; + const agent = await effects.transaction(db, existing.companyId, (tx, publications) => + updateAgentConfiguration(tx, effects, id, data, options, publications)); + if (data.budgetMonthlyCents !== undefined) await effects.enforceBudget(db, existing.companyId, id); + scheduleAgentLifecycle(db, id); + return agent; + }, + async updateAndTransition(id: string, command: "pause" | "resume" | "terminate", data: AgentConfigurationPatch, options?: UpdateAgentOptions) { + const existing = await records.getById(id); + if (!existing) return null; + const agent = await effects.transaction(db, existing.companyId, async (tx, publications) => { + await updateAgentConfiguration(tx, effects, id, data, options, publications); + await createLifecycleStore(tx, effects).change(id, command, { reason: command === "resume" ? "user" : "manual" }); + return agentRecords(tx, effects).getById(id); + }); + if (data.budgetMonthlyCents !== undefined) await effects.enforceBudget(db, existing.companyId, id); + scheduleAgentLifecycle(db, id); + return agent; + }, + async reconcilePolicyHolds(companyId: string, agentId?: string | null) { + if (agentId === null) return; + const rows = await db.select({ id: agents.id }).from(agents).where(and( + eq(agents.companyId, companyId), agentId ? eq(agents.id, agentId) : undefined, + inArray(agents.lifecycleState, policyStates), + )); + for (const row of rows) { + await store.change(row.id, "reconcile"); + scheduleAgentLifecycle(db, row.id); + } + }, + pauseAgent: (id: string, reason = "manual") => change(id, "pause", reason), + resumeAgent: (id: string, reason = "user") => change(id, "resume", reason), + terminateAgent: (id: string) => change(id, "terminate"), + retry: (id: string) => change(id, "retry"), + clearError: records.clearError, + purgeAgent: (id: string) => purgeAgent(db, effects, id), + }; +} + +export function startAgentLifecycle(db: Db, effects: LifecycleEffects, driver: LifecycleDriver, canRun: () => boolean) { + const worker = configureAgentLifecycle(db, effects, driver, canRun); + let running: Promise | undefined; + let stopped = false; + let nextPolicySweep = 0; + let policyCursor: string | undefined; + const store = createLifecycleStore(db, effects); + function sweep() { + if (stopped || !canRun()) return Promise.resolve(); + return running ??= (async () => { + if (Date.now() >= nextPolicySweep) { + try { + const rows = await db.select({ id: agents.id }).from(agents).where(and( + inArray(agents.lifecycleState, policyStates), policyCursor ? gt(agents.id, policyCursor) : undefined, + )).orderBy(asc(agents.id)).limit(policyPageSize); + for (const row of rows) { + await store.change(row.id, "reconcile"); + scheduleAgentLifecycle(db, row.id); + policyCursor = row.id; + } + if (rows.length < policyPageSize) policyCursor = undefined; + } + catch (error) { effects.reportFailure({ stage: "policy_scan" }, error); throw error; } + nextPolicySweep = Date.now() + 60_000; + } + await worker.sweep(); + })().finally(() => { running = undefined; }); + } + const timer = setInterval(() => { void sweep().catch(() => {}); }, 5_000); + timer.unref?.(); + return { + sweep, + async stop() { + stopped = true; + clearInterval(timer); + workers.delete(db); + try { await running; } finally { await worker.stop(); } + }, + }; +} diff --git a/server/src/routes/access.ts b/server/src/routes/access.ts index 460cd3c3dd9..f22b25db30c 100644 --- a/server/src/routes/access.ts +++ b/server/src/routes/access.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "../services/agent-lifecycle.js"; import { createHash, generateKeyPairSync, @@ -2640,6 +2641,7 @@ export function accessRoutes( const access = accessService(db); const boardAuth = boardAuthService(db); const agents = agentService(db); + const agentsLifecycle = createAgentLifecycle(db); const routeInviteResolutionNetwork = opts.inviteResolutionNetwork ? { ...defaultInviteResolutionNetwork, ...opts.inviteResolutionNetwork } : inviteResolutionNetwork; @@ -4268,7 +4270,7 @@ export function accessRoutes( })) ); - const created = await agents.create(companyId, { + const created = await agentsLifecycle.requestHire(companyId, { name: agentName, role: "general", title: null, diff --git a/server/src/routes/agents.ts b/server/src/routes/agents.ts index 3c68a3d49df..0484bce3cae 100644 --- a/server/src/routes/agents.ts +++ b/server/src/routes/agents.ts @@ -1,5 +1,7 @@ import { cancellationRequestId } from "../services/native-runtime/native-cancellation-request.js"; -import { aiRoutingHarness } from "@paperclipai/shared"; +import { agentEnvironmentTestService } from "../services/agent-environment-test.js"; +import { createAgentLifecycle } from "../services/agent-lifecycle.js"; + import { agentIdentityService } from "../services/agent-identity.js"; import { aiConnectionRouterService, poolMemberRuntimeConfig } from "../services/ai-connection-router.js"; import { connectionIntentService } from "../services/connection-intents.js"; @@ -11,12 +13,17 @@ import { agentFileStore, agentFileTokenFromHash } from "../services/agent-file-s import { pipeline } from "node:stream/promises"; import { resolveAgentAppearance, agentAvatarUrl } from "@paperclipai/shared"; import { listOpenRouterModels } from "../services/openrouter-models.js"; -import { prepareManagedAiRuntime, withManagedAiProbe, assertManagedAiProjectAuth, stripAiAuthBindings } from "../services/ai-connection-runtime.js"; -import { ADAPTER_AUTH_MISSING_CHECK_CODE, AI_CONNECTION_CAPABILITIES, aiConnectionBindingSchema, type AiConnectionBinding, aiRuntimeConnectionBindingSchema, type AiRuntimeConnectionBinding } from "@paperclipai/shared"; +import { withManagedAiProbe, stripAiAuthBindings } from "../services/ai-connection-runtime.js"; +import { + ADAPTER_AUTH_MISSING_CHECK_CODE, + aiConnectionBindingSchema, + aiRuntimeConnectionBindingSchema, + type AiRuntimeConnectionBinding, +} from "@paperclipai/shared"; import { toolConnections } from "@paperclipai/db"; import { aiConnectionService } from "../services/ai-connections.js"; import { defaultAiConnectionForHire } from "../services/agent-ai-connection-default.js"; -import { assertAiConnectionCreateAccess, canInstallSharedAiConnectionForNewAgent, responsibleUserForAiRequest, validateAiApiKey } from "./ai-connections.js"; +import { assertAiConnectionCreateAccess, canInstallSharedAiConnectionForNewAgent, responsibleUserForAiRequest } from "./ai-connections.js"; import { isAiConnectionCompatible } from "@paperclipai/shared"; import { applyConnectorSkills, resolveConnectorAssignments, annotateConnectorSkills, isConnectorSkill } from "../services/connector-runtime.js"; import { getExecutionBlocker } from "../services/execution-blocker.js"; @@ -114,7 +121,7 @@ import { } from "./workspace-command-authz.js"; import type { PluginWorkerManager } from "../services/plugin-worker-manager.js"; import { environmentService } from "../services/environments.js"; -import { resolveEnvironmentExecutionTarget } from "../services/environment-execution-target.js"; + import { environmentRuntimeService } from "../services/environment-runtime.js"; import { resolvePluginSandboxProviderDriverByKey } from "../services/plugin-environment-driver.js"; import type { AdapterExecutionTarget } from "@paperclipai/adapter-utils/execution-target"; @@ -561,10 +568,12 @@ export function agentRoutes( const router = Router(); const svc = agentService(db, { cancelWorkForScope: scope => heartbeat.cancelBudgetScopeWork(scope) }); + const svcLifecycle = createAgentLifecycle(db, { cancelWorkForScope: scope => heartbeat.cancelBudgetScopeWork(scope) }); const access = accessService(db); const approvalsSvc = approvalService(db); const budgets = budgetService(db); const environmentsSvc = environmentService(db); + const { resolveAdapterTestEnvironmentId, resolveAdapterTestExecutionContext, assertAdapterTestEnvironmentForCompany, testManagedEnvironment } = agentEnvironmentTestService(db, options.pluginWorkerManager); const environmentRuntime = environmentRuntimeService(db, { pluginWorkerManager: options.pluginWorkerManager, }); @@ -1221,415 +1230,6 @@ export function agentRoutes( return rows.filter((_, index) => decisions[index]?.allowed); } - // A null agent override inherits the instance default, just like dispatch. - // Resolve this before secrets or probes so a default remote environment can - // never accidentally validate the account on the control-plane host. - async function resolveAdapterTestEnvironmentId(companyId: string, environmentId: string | null | undefined) { - if (environmentId) return environmentId; - const settings = await instanceSettings.get(); - if (settings.defaultEnvironmentId) return settings.defaultEnvironmentId; - if ((await instanceSettings.getExperimental()).enableManagedSandboxOnly === true) { - const managed = await environmentsSvc.findManagedSandboxEnvironment(companyId); - if (!managed) { - throw unprocessable("The managed sandbox is unavailable. Restore Paperclip Computer and retry.", { - code: "managed_sandbox_unavailable", - }); - } - return managed.id; - } - return null; - } - - /** - * Resolve the execution target the adapter should run its test probes against. - * - * - No environmentId / local environment → returns a local target so the - * adapter probes the Paperclip host (legacy behavior). - * - SSH environment → builds an SSH execution target from the environment - * config so the adapter probes the remote box. No lease is required: - * the SSH spec is fully derived from the saved environment config. - * - Sandbox / plugin environments → acquires an ad-hoc lease, realizes the - * workspace, and resolves a sandbox execution target wired to the runtime - * so the adapter probe runs inside the sandbox the same way a heartbeat - * would. The returned `release` callback rolls the lease back when the - * route is done. - * - * The caller MUST always invoke `release()` (typically in a `finally` block). - */ - async function resolveAdapterTestExecutionContext(input: { - companyId: string; - adapterType: string; - environmentId: string | null; - }): Promise<{ - executionTarget: AdapterExecutionTarget | null; - environmentName: string | null; - fallbackChecks: AdapterEnvironmentCheck[]; - sandboxIdentityCheck?: AdapterEnvironmentCheck | null; - release: (status?: "released" | "failed") => Promise; - }> { - const noopRelease = async () => {}; - - if (!input.environmentId) { - return { - executionTarget: null, - environmentName: null, - fallbackChecks: [], - release: noopRelease, - }; - } - - const requestedEnvironment = await environmentsSvc.getById(input.environmentId); - if (!requestedEnvironment) { - return { - executionTarget: null, - environmentName: null, - fallbackChecks: [ - { - code: "environment_not_found", - level: "warn", - message: "Selected environment was not found. The test did not run.", - }, - ], - release: noopRelease, - }; - } - - // Managed-sandbox-only policy: redirect a Test that would run on the local - // host onto the platform-managed sandbox, the same as a real run does - // (resolveExecutionWorkspaceEnvironmentId in heartbeat). Without this - // redirect the Test probes the local host while the run executes in the - // managed sandbox, so a passing Test validates the wrong execution target. - // With no active managed sandbox the Test fails closed — never local. - let environment = requestedEnvironment; - if (requestedEnvironment.driver === "local") { - const managedSandboxOnly = - (await instanceSettings.getExperimental()).enableManagedSandboxOnly === true; - if (managedSandboxOnly) { - const managedSandboxEnvironment = await environmentsSvc.findManagedSandboxEnvironment( - input.companyId, - ); - if (!managedSandboxEnvironment) { - return { - executionTarget: null, - environmentName: requestedEnvironment.name, - fallbackChecks: [ - { - code: "managed_sandbox_unavailable", - level: "error", - message: - "This instance runs agents only in its platform-managed sandbox, but no active managed sandbox environment exists. The test did not run.", - hint: "Restore the managed sandbox environment, then test again.", - }, - ], - release: noopRelease, - }; - } - environment = managedSandboxEnvironment; - } - } - - if (environment.driver === "local") { - return { - executionTarget: null, - environmentName: environment.name, - fallbackChecks: [], - release: noopRelease, - }; - } - - if (environment.driver === "ssh") { - try { - const target = await resolveEnvironmentExecutionTarget({ - db, - companyId: input.companyId, - adapterType: input.adapterType, - environment: { - id: environment.id, - driver: environment.driver, - config: environment.config ?? null, - }, - leaseMetadata: null, - }); - if (target) { - return { - executionTarget: target, - environmentName: environment.name, - fallbackChecks: [], - release: noopRelease, - }; - } - return { - executionTarget: null, - environmentName: environment.name, - fallbackChecks: [ - { - code: "environment_target_unavailable", - level: "warn", - message: - `Could not resolve an execution target for environment "${environment.name}". The test did not run.`, - }, - ], - release: noopRelease, - }; - } catch (err) { - return { - executionTarget: null, - environmentName: environment.name, - fallbackChecks: [ - { - code: "environment_target_failed", - level: "warn", - message: - `Could not connect to environment "${environment.name}" to run the test.`, - detail: err instanceof Error ? err.message : String(err), - }, - ], - release: noopRelease, - }; - } - } - - // sandbox / plugin / other remote drivers: spin up an ad-hoc lease, realize - // the workspace inside the box, and run the same probe SSH uses against - // a sandbox execution target wired to the environment runtime. - // - // We pass `heartbeatRunId: null` because there's no heartbeat run for an - // operator-initiated `Test` invocation — the leases table FKs heartbeat - // run id to heartbeat_runs.id, and we don't want to manufacture a fake - // run row. Cleanup goes through the driver's `releaseRunLease` directly - // (by lease record), since the batch helper queries by heartbeatRunId. - // - // Sandbox tests boot a fresh throwaway sandbox (never resume a retained - // agent lease) and archive it on release instead of deleting it, so the - // operator can inspect the exact sandbox from the provider dashboard while - // provider-side expiry reaps it later. - const testEnvironment = environment.driver === "sandbox" - ? { - ...environment, - config: { - ...(environment.config ?? {}), - reuseLease: false, - archiveOnRelease: true, - }, - } - : environment; - let leaseRecord: Awaited>; - try { - leaseRecord = await environmentRuntime.acquireRunLease({ - companyId: input.companyId, - environment: testEnvironment, - issueId: null, - heartbeatRunId: null, - persistedExecutionWorkspace: null, - // Re-check the company binding atomically at lease time. The route - // guard already rejected a foreign environment, but the binding could - // change between the guard check and the lease acquire. This closes - // that check-to-lease race so a foreign sandbox never gets a lease. - assertCompanyBinding: true, - // Apply the active custom-image template so the Test boots with the - // operator's captured sandbox customizations and prepared image state, - // matching what real agent runs use. Without this the test would - // silently fall back to the base image. - applyCustomImageTemplate: true, - }); - } catch (err) { - return { - executionTarget: null, - environmentName: environment.name, - fallbackChecks: [ - { - code: "environment_lease_acquire_failed", - level: "error", - message: `Could not acquire a lease for environment "${environment.name}".`, - detail: err instanceof Error ? err.message : String(err), - hint: "Check the environment's provider credentials and quota.", - }, - ], - release: noopRelease, - }; - } - - const driver = environmentRuntime.getDriver(environment.driver); - const releaseLease = async (status: "released" | "failed" = "released") => { - try { - if (driver) { - await driver.releaseRunLease({ - environment: testEnvironment, - lease: leaseRecord.lease, - status, - }); - } else { - await environmentsSvc.releaseLease(leaseRecord.lease.id, status); - } - } catch (err) { - // Cleanup failures must not mask the test result. - // eslint-disable-next-line no-console - console.warn( - `[adapter-test] Failed to release lease ${leaseRecord.lease.id}: ${err instanceof Error ? err.message : String(err)}`, - ); - } - }; - - let realizedCwd: string | null = null; - try { - const realized = await environmentRuntime.realizeWorkspace({ - environment: testEnvironment, - lease: leaseRecord.lease, - // No host workspace to copy for a Test invocation; sandbox/plugin - // realize implementations use the lease metadata's remoteCwd to - // create the working directory inside the box. - workspace: {}, - }); - realizedCwd = - typeof realized.cwd === "string" && realized.cwd.trim().length > 0 - ? realized.cwd.trim() - : null; - } catch (err) { - await releaseLease("failed"); - return { - executionTarget: null, - environmentName: environment.name, - fallbackChecks: [ - { - code: "environment_workspace_realize_failed", - level: "error", - message: `Could not realize a workspace inside "${environment.name}".`, - detail: err instanceof Error ? err.message : String(err), - }, - ], - release: noopRelease, - }; - } - - let target: AdapterExecutionTarget | null; - try { - // Prefer the cwd the realize step returned; fall back to lease metadata. - const leaseMetadataForTarget: Record | null = - realizedCwd - ? { ...(leaseRecord.lease.metadata ?? {}), remoteCwd: realizedCwd } - : (leaseRecord.lease.metadata as Record | null) ?? null; - - target = await resolveEnvironmentExecutionTarget({ - db, - companyId: input.companyId, - adapterType: input.adapterType, - environment: { - id: testEnvironment.id, - driver: testEnvironment.driver, - config: testEnvironment.config ?? null, - }, - leaseId: leaseRecord.lease.id, - leaseMetadata: leaseMetadataForTarget, - lease: leaseRecord.lease, - environmentRuntime, - }); - } catch (err) { - await releaseLease("failed"); - return { - executionTarget: null, - environmentName: environment.name, - fallbackChecks: [ - { - code: "environment_target_failed", - level: "error", - message: `Could not resolve an execution target for "${environment.name}".`, - detail: err instanceof Error ? err.message : String(err), - }, - ], - release: noopRelease, - }; - } - - if (!target) { - await releaseLease("failed"); - return { - executionTarget: null, - environmentName: environment.name, - fallbackChecks: [ - { - code: "environment_target_unsupported", - level: "warn", - message: - `Adapter "${input.adapterType}" is not allowed in "${environment.name}" environments.`, - }, - ], - release: noopRelease, - }; - } - - return { - executionTarget: target, - environmentName: environment.name, - fallbackChecks: [], - sandboxIdentityCheck: buildSandboxIdentityCheck({ - environmentName: environment.name, - lease: leaseRecord.lease, - }), - release: releaseLease, - }; - } - - function readMetadataString(metadata: Record, keys: string[]): string | null { - for (const key of keys) { - const value = metadata[key]; - if (typeof value === "string" && value.trim().length > 0) return value.trim(); - } - return null; - } - - function buildSandboxIdentityCheck(input: { - environmentName: string; - lease: { - id: string; - provider?: string | null; - providerLeaseId?: string | null; - metadata?: Record | null; - }; - }): AdapterEnvironmentCheck { - const metadata = input.lease.metadata ?? {}; - const provider = input.lease.provider ?? readMetadataString(metadata, ["provider"]); - const sandboxId = readMetadataString(metadata, ["sandboxId", "sandboxID", "sandbox_id", "id"]); - const sandboxName = readMetadataString(metadata, ["sandboxName", "sandbox_name", "name"]); - const snapshotRef = readMetadataString(metadata, [ - "snapshot", - "snapshotId", - "snapshotID", - "snapshotRef", - "snapshot_ref", - "templateRef", - "template_ref", - "templateId", - "templateID", - "image", - "imageId", - "imageID", - "imageRef", - "image_ref", - ]); - const templateKind = readMetadataString(metadata, [ - "templateKind", - "template_kind", - "templateRefKind", - "template_ref_kind", - ]); - const detailParts = [ - `paperclipLeaseId=${input.lease.id}`, - input.lease.providerLeaseId ? `providerLeaseId=${input.lease.providerLeaseId}` : null, - provider ? `provider=${provider}` : null, - sandboxId ? `sandboxId=${sandboxId}` : null, - sandboxName ? `sandboxName=${sandboxName}` : null, - snapshotRef ? `${templateKind ? `${templateKind}Ref` : "snapshotOrTemplateRef"}=${snapshotRef}` : null, - ].filter((part): part is string => Boolean(part)); - - return { - code: "sandbox_test_identity", - level: "info", - message: `Environment test identity for "${input.environmentName}".`, - detail: detailParts.join("; "), - hint: "Use these provider-neutral IDs when comparing model-test output with provider logs or refreshed environment snapshots.", - }; - } - async function getCurrentUserRedactionOptions() { return { enabled: (await instanceSettings.getGeneral()).censorUsernameInLogs, @@ -3416,103 +3016,6 @@ export function agentRoutes( res.json(detected); }); - // The environment drivers the adapter Test route accepts. A local, SSH, or - // sandbox environment can host a probe; a plugin environment cannot. - const ADAPTER_TEST_ALLOWED_ENVIRONMENT_DRIVERS = ["local", "ssh", "sandbox"]; - - // The fail-closed tenant-binding guard for the adapter Test route. A caller - // may name any instance environment by id, so the route must reject an - // environment that binds to another company before it resolves secrets, - // merges env, resolves the target, leases a sandbox, or runs the adapter - // test. The guard checks the company binding BEFORE it validates the status - // or the driver, so it never reveals the status or the driver of a foreign - // environment. A same-company or an instance-global environment then gets the - // shared driver and status validation. - async function assertAdapterTestEnvironmentForCompany( - companyId: string, - environmentId: string, - ): Promise { - const environment = await environmentsSvc.getById(environmentId); - if (!environment) { - // A missing environment leaks no tenant state. The execution-context - // resolver surfaces the existing environment_not_found check. - return; - } - const boundCompanyIds = await environmentsSvc.listBoundCompanyIds(environmentId); - if (boundCompanyIds.length > 0 && !boundCompanyIds.includes(companyId)) { - throw forbidden("The selected environment belongs to another company.", { - code: "environment_company_mismatch", - }); - } - await assertEnvironmentSelectionForCompany(environmentsSvc, companyId, environmentId, { - allowedDrivers: ADAPTER_TEST_ALLOWED_ENVIRONMENT_DRIVERS, - }); - } - - async function testManagedEnvironment(adapterType: string, context: Parameters["testEnvironment"]>[0], binding: AiConnectionBinding, managed: Awaited>, agentId?: string) { - const startedAt = new Date(); - const result = await probeManagedEnvironment(adapterType, context, binding); - // A provider rejection invalidates the tested credential generation. A - // missing CLI, unavailable environment, or other runtime error does not. - if (result.status === "fail" && result.checks.some(check => - check.code === ADAPTER_AUTH_MISSING_CHECK_CODE || /_hello_probe_auth_required$/.test(check.code) - || check.code === "ai_connection_api_key_rejected", - )) { - await aiConnectionService(db).markAuthenticationFailed({ - companyId: context.companyId, agentId, runStartedAt: startedAt, - attribution: { ...managed.attribution, identity: managed.identity }, - }); - } - return result; - } - - async function probeManagedEnvironment(adapterType: string, context: Parameters["testEnvironment"]>[0], binding: AiConnectionBinding) { - await assertManagedAiProjectAuth(context.config, binding.provider, context.executionTarget); - const result = await requireServerAdapter(adapterType).testEnvironment(context); - if (result.status === "fail") return result; - // The resolved method, not binding.method — on a responsible_user binding - // that field is wire-compat only and the default connection decides. - const resolvedMethod = (context.config as { managedAiConnection?: { method?: string } }).managedAiConnection?.method; - // An api_key account does not take the CLI hello probe below: a key - // travels as an env var any engine understands, and the engine's own test - // above judged whether this runtime can execute with it — the ACP lane - // deliberately runs no hello probe when a key is configured. Demanding one - // anyway forced the CLI lane, whose probe needs a provider CLI on PATH, - // and a clean install has none: that walled off onboarding's API-key path - // on exactly the machines the release smoke exists to guard. The account - // is still verified live here — the same provider-endpoint check the save - // performed — so a key revoked since its save fails adoption rather than - // producing an agent that cannot authenticate at runtime. The hello-probe - // requirement stays for subscriptions: a stored login is a file layout - // only a provider CLI reads, so proving the runtime lane can consume it - // takes a real hello turn. - if (resolvedMethod === "api_key" && !context.config.managedAiRouting) { - const envKey = AI_CONNECTION_CAPABILITIES[binding.provider].methods.api_key?.envKey; - const key = envKey ? parseObject(context.config.env)[envKey] : undefined; - try { - if (typeof key !== "string" || !key) throw unprocessable("The selected account's API key was not available to verify."); - await validateAiApiKey(binding.provider, key); - result.checks.push({ code: "ai_connection_api_key_reverified", level: "info", message: "The provider verified this API key for adoption." }); - } catch (error) { - result.status = "fail"; - const rejected = error instanceof HttpError && asRecord(error.details)?.code === "ai_connection_api_key_rejected"; - result.checks.push({ code: rejected ? "ai_connection_api_key_rejected" : "ai_connection_verification_failed", level: "error", message: error instanceof HttpError ? error.message : "Could not verify the account. Try again." }); - } - return result; - } - if (!result.checks.some(check => check.code.includes("hello_probe"))) { - const providerAdapter = context.config.managedAiRouting ? aiRoutingHarness(adapterType, context.config.provider, context.config.acpxAgent) : { anthropic: "claude_local", openai: "codex_local", openrouter: "opencode_local", xai: "grok_local", google: "gemini_local" }[binding.provider]; - const probe = await requireServerAdapter(providerAdapter).testEnvironment({ ...context, adapterType: providerAdapter, config: { ...context.config, engine: "cli" } }); - result.checks.push(...probe.checks); - result.status = probe.status === "fail" ? "fail" : result.status === "warn" || probe.status === "warn" ? "warn" : "pass"; - } - if (!result.checks.some(check => /hello_probe_(passed|succeeded)$/.test(check.code))) { - result.status = "fail"; - result.checks.push({ code: "ai_connection_validation_incomplete", level: "error", message: "The selected account has not completed a provider hello test. Retry before adopting it." }); - } - return result; - } - async function validateManagedAgentBinding(req: Request, companyId: string, agentId: string, adapterType: string, config: Record, binding: AiRuntimeConnectionBinding, environmentId: string | null | undefined, test: boolean, newAgent = false) { if (binding.mode === "router") { const settings = await import("../services/instance-settings.js"); @@ -4834,7 +4337,7 @@ export function agentRoutes( const status = requiresApproval ? "pending_approval" : "idle"; const managedHireBinding = normalizedHireInput.runtimeConfig?.aiConnection ? aiRuntimeConnectionBindingSchema.parse(normalizedHireInput.runtimeConfig.aiConnection) : undefined; const managedHireConnection = managedHireBinding ? await validateManagedAgentBinding(req, companyId, hiredAgentId, normalizedHireInput.adapterType, normalizedHireInput.adapterConfig, managedHireBinding, normalizedHireInput.defaultEnvironmentId, false, true) : undefined; - const createdAgent = await svc.create( + const createdAgent = await svcLifecycle.requestHire( companyId, { id: hiredAgentId, @@ -4845,6 +4348,7 @@ export function agentRoutes( }, { createdByUserId: req.actor.type === "board" ? req.actor.userId : null, + responsibleUserId: responsibleUserForAiRequest(req), aiConnectionInstall: managedHireConnection ? { ...managedHireConnection, createdByUserId: responsibleUserForAiRequest(req) } : undefined, claudeLogin: { storedSessionId: hireStoredSessionId ?? null, @@ -5088,7 +4592,7 @@ export function agentRoutes( const managedBinding = normalizedRuntimeConfig.aiConnection ? aiRuntimeConnectionBindingSchema.parse(normalizedRuntimeConfig.aiConnection) : undefined; const managedConnection = managedBinding ? await validateManagedAgentBinding(req, companyId, agentId, createInput.adapterType, normalizedAdapterConfig, managedBinding, createInput.defaultEnvironmentId, false, true) : undefined; - const createdAgent = await svc.create( + const createdAgent = await svcLifecycle.requestHire( companyId, { id: agentId, @@ -5101,6 +4605,7 @@ export function agentRoutes( }, { createdByUserId: req.actor.type === "board" ? req.actor.userId : null, + responsibleUserId: responsibleUserForAiRequest(req), aiConnectionInstall: managedConnection ? { ...managedConnection, createdByUserId: responsibleUserForAiRequest(req) } : undefined, claudeLogin: { storedSessionId: createStoredSessionId ?? null, @@ -5643,6 +5148,9 @@ export function agentRoutes( } const patchData = { ...(req.body as Record) }; + const requestedStatus = patchData.status; + delete patchData.status; + if (requestedStatus !== undefined && !["paused", "idle", "terminated"].includes(String(requestedStatus))) throw badRequest("Use an agent lifecycle command to change status"); const replaceAdapterConfig = patchData.replaceAdapterConfig === true; delete patchData.replaceAdapterConfig; // The apply-existing flag is not an agent column. The server binds the fixed @@ -5825,7 +5333,7 @@ export function agentRoutes( } const actor = getActorInfo(req); - const agent = await svc.update(id, patchData, { + const updateOptions = { recordRevision: { createdByAgentId: actor.agentId, createdByUserId: actor.actorType === "user" ? actor.actorId : null, @@ -5838,7 +5346,11 @@ export function agentRoutes( applyExistingWithoutClaim: req.actor.type !== "agent" && applyStoredClaudeLogin, }, - }); + }; + const command = requestedStatus === "paused" ? "pause" : requestedStatus === "idle" ? "resume" : requestedStatus === "terminated" ? "terminate" : null; + const agent = command + ? await svcLifecycle.updateAndTransition(id, command, patchData, updateOptions) + : await svc.update(id, patchData, updateOptions); if (!agent) { res.status(404).json({ error: "Agent not found" }); return; @@ -5860,13 +5372,28 @@ export function agentRoutes( res.json(redactAgentRowForResponse(agent)); }); + router.post("/agents/:id/lifecycle/retry", async (req, res) => { + assertBoard(req); + const id = req.params.id as string; + const existing = await getAccessibleAgent(req, res, id); + if (!existing) return; + await assertCanUpdateAgent(req, existing); + const agent = await svcLifecycle.retry(id); + if (!agent) { res.status(404).json({ error: "Agent not found" }); return; } + const actor = getActorInfo(req); + await logActivity(db, { companyId: agent.companyId, actorType: actor.actorType, actorId: actor.actorId, + agentId: actor.agentId, runId: actor.runId, agentApiKeyId: actor.agentApiKeyId, + action: "agent.lifecycle_retried", entityType: "agent", entityId: agent.id }); + res.json(redactAgentRowForResponse(agent)); + }); + router.post("/agents/:id/pause", async (req, res) => { assertBoard(req); const id = req.params.id as string; if (!(await getAccessibleAgent(req, res, id))) { return; } - const agent = await svc.pause(id); + const agent = await svcLifecycle.pauseAgent(id); if (!agent) { res.status(404).json({ error: "Agent not found" }); return; @@ -5899,7 +5426,7 @@ export function agentRoutes( }); return; } - const agent = await svc.resume(id); + const agent = await svcLifecycle.resumeAgent(id); if (!agent) { res.status(404).json({ error: "Agent not found" }); return; @@ -5965,34 +5492,16 @@ export function agentRoutes( return; } - // Resolve the linked hire approval (clears it from the inbox) and run the - // shared approval side effects: agent activation, budget policy, and the - // hire-approved notification. Fall back to direct activation if no open - // approval record exists (e.g. agents created before approvals were tracked). - const decidedByUserId = req.actor.userId ?? "board"; - const openApproval = await approvalsSvc.findOpenHireApprovalForAgent(existing.companyId, id); - - let agent: Awaited> | null = null; - if (openApproval) { - await approvalsSvc.approve(openApproval.id, decidedByUserId); - agent = await svc.getById(id); - } else { - const approval = await svc.activatePendingApproval(id); - if (!approval) { - res.status(404).json({ error: "Agent not found" }); - return; - } - if (!approval.activated) { - res.status(409).json({ error: "Only pending approval agents can be approved" }); - return; - } - agent = approval.agent; - } - + const decision = await approvalsSvc.approveHire(id, req.actor.userId ?? "board"); + const agent = decision?.agent; if (!agent) { res.status(404).json({ error: "Agent not found" }); return; } + if (!decision.applied) { + res.status(409).json({ error: "Only pending approval agents can be approved" }); + return; + } await logActivity(db, { companyId: agent.companyId, @@ -6001,7 +5510,7 @@ export function agentRoutes( action: "agent.approved", entityType: "agent", entityId: agent.id, - details: { source: "agent_detail", approvalId: openApproval?.id ?? null }, + details: { source: "agent_detail", approvalId: decision.approval?.id ?? null }, }); res.json(redactAgentRowForResponse(agent)); @@ -6015,23 +5524,9 @@ export function agentRoutes( return; } - // Terminating an agent that is still awaiting approval is the agent-detail - // equivalent of rejecting the hire. When a linked hire approval is still - // open, delegate to approvalsSvc.reject(), which both resolves the approval - // (clearing the inbox "Approve/Reject" card) and terminates the agent. - // Mirror the approve path's branch-or-fallback so we never terminate twice: - // reject() already calls agentsSvc.terminate() internally. - let agent: Awaited> = null; - if (existing.status === "pending_approval") { - const openApproval = await approvalsSvc.findOpenHireApprovalForAgent(existing.companyId, id); - if (openApproval) { - await approvalsSvc.reject(openApproval.id, req.actor.userId ?? "board"); - agent = await svc.getById(id); - } - } - if (!agent) { - agent = await svc.terminate(id); - } + const agent = existing.status === "pending_approval" + ? (await approvalsSvc.rejectHire(id, req.actor.userId ?? "board"))?.agent + : await svcLifecycle.terminateAgent(id); if (!agent) { res.status(404).json({ error: "Agent not found" }); return; diff --git a/server/src/routes/ai-connections.ts b/server/src/routes/ai-connections.ts index ba40020e46a..ef0498b6106 100644 --- a/server/src/routes/ai-connections.ts +++ b/server/src/routes/ai-connections.ts @@ -1,3 +1,5 @@ +import { validateAiApiKey } from "../services/ai-api-key-test.js"; +export { validateAiApiKey } from "../services/ai-api-key-test.js"; import { supportsLocalAiLogin } from "../services/local-ai-login-policy.js"; import { localAiLoginService } from "../services/local-ai-login.js"; import { z } from "zod"; @@ -133,41 +135,6 @@ export async function canInstallSharedAiConnectionForNewAgent( connection.creator === userId || await accessService(db).hasPermission(companyId, "user", userId, "tools:manage_connections"); } -/** Fixed provider endpoints; credentials are never sent to a caller-supplied URL or through a redirect. */ -export async function validateAiApiKey( - provider: AiProvider, - key: string, - request: typeof fetch = fetch, -) { - const endpoints = { - anthropic: "https://api.anthropic.com/v1/models?limit=1", - openai: "https://api.openai.com/v1/models", - openrouter: "https://openrouter.ai/api/v1/key", - xai: "https://api.x.ai/v1/models", - google: "https://generativelanguage.googleapis.com/v1beta/models?pageSize=1", - }; - let response: Response; - try { - response = await request(endpoints[provider], { - redirect: "error", - signal: AbortSignal.timeout(15000), - headers: - provider === "google" ? { "x-goog-api-key": key } : provider === "anthropic" - ? { "x-api-key": key, "anthropic-version": "2023-06-01" } - : { Authorization: `Bearer ${key}` }, - }); - } catch { - throw unprocessable("Could not verify the account. Try again.", { code: "ai_connection_verification_failed" }); - } - await response.body?.cancel(); - if (!response.ok) - throw unprocessable( - response.status === 401 || response.status === 403 - ? "The provider rejected this API key." - : "The provider could not verify this account. Try again.", - { code: response.status === 401 || response.status === 403 ? "ai_connection_api_key_rejected" : "ai_connection_verification_failed" }, - ); -} export function aiConnectionRoutes(db: Db, options: Parameters[0] = {}) { function assertLocalLoginAvailable() { diff --git a/server/src/routes/environment-selection.ts b/server/src/routes/environment-selection.ts index eba3d8772c3..6718be5624a 100644 --- a/server/src/routes/environment-selection.ts +++ b/server/src/routes/environment-selection.ts @@ -1,52 +1 @@ -import { unprocessable } from "../errors.js"; - -export async function assertEnvironmentSelectionForCompany( - environmentsSvc: { - getById(environmentId: string): Promise<{ - id: string; - driver: string; - status?: string | null; - config: Record | null; - } | null>; - }, - _companyId: string, - environmentId: string | null | undefined, - options?: { - allowedDrivers?: string[]; - allowedSandboxProviders?: string[]; - }, -) { - if (environmentId === undefined || environmentId === null) return; - const environment = await environmentsSvc.getById(environmentId); - if (!environment) { - throw unprocessable("Environment not found."); - } - if (environment.status === "archived") { - throw unprocessable("Environment is archived."); - } - if (options?.allowedDrivers && !options.allowedDrivers.includes(environment.driver)) { - throw unprocessable( - `Environment driver "${environment.driver}" is not allowed here. Allowed drivers: ${options.allowedDrivers.join(", ")}`, - ); - } - if (environment.driver === "sandbox") { - const config = environment.config && typeof environment.config === "object" - ? environment.config as Record - : {}; - const provider = typeof config.provider === "string" ? config.provider : ""; - if (provider === "fake") { - throw unprocessable( - `Environment sandbox provider "${provider}" is not allowed here. The built-in fake provider is probe-only and cannot execute runs.`, - ); - } - if ( - options?.allowedSandboxProviders - && options.allowedSandboxProviders.length > 0 - && !options.allowedSandboxProviders.includes(provider) - ) { - throw unprocessable( - `Environment sandbox provider "${provider || "unknown"}" is not allowed here. Allowed providers: ${options.allowedSandboxProviders.join(", ")}`, - ); - } - } -} +export { assertEnvironmentSelectionForCompany } from "../services/environment-selection.js"; diff --git a/server/src/routes/openapi.ts b/server/src/routes/openapi.ts index 915e28ce507..b9fe16afccd 100644 --- a/server/src/routes/openapi.ts +++ b/server/src/routes/openapi.ts @@ -3578,7 +3578,7 @@ registry.registerPath({ summary: "Update an agent", request: { params: z.object({ id: z.string() }), - body: jsonBody(updateAgentSchema.omit({ permissions: true })), + body: jsonBody(updateAgentSchema.omit({ permissions: true, spentMonthlyCents: true })), }, responses: { 200: r.ok(), @@ -3850,6 +3850,15 @@ registry.registerPath({ }, }); +registry.registerPath({ + method: "post", + path: "/api/agents/{id}/lifecycle/retry", + tags: ["agents"], + summary: "Retry an incomplete agent lifecycle step", + request: { params: z.object({ id: z.string() }) }, + responses: { 200: r.ok(), 401: r.unauthorized, 403: r.forbidden, 404: r.notFound, 409: r.conflict }, +}); + registry.registerPath({ method: "post", path: "/api/agents/{id}/pause", diff --git a/server/src/services/activity-log.ts b/server/src/services/activity-log.ts index 7021b3e3825..a7e4376dbdb 100644 --- a/server/src/services/activity-log.ts +++ b/server/src/services/activity-log.ts @@ -1,3 +1,5 @@ +import type { ActivityPublication } from "../types/activity-publication.js"; +export type { ActivityPublication } from "../types/activity-publication.js"; import { randomUUID } from "node:crypto"; import { and, eq } from "drizzle-orm"; import type { Db } from "@paperclipai/db"; @@ -66,11 +68,6 @@ export interface LogActivityInput { responsibleUserIdOverride?: string | null; } -export interface ActivityPublication { - companyId: string; - payload: Record; - pluginEvent: PluginEvent | null; -} export async function createActivityDetailsRedactor(db: Db) { const currentUserRedactionOptions = { diff --git a/server/src/services/agent-configuration-transaction.ts b/server/src/services/agent-configuration-transaction.ts new file mode 100644 index 00000000000..24bcdea897c --- /dev/null +++ b/server/src/services/agent-configuration-transaction.ts @@ -0,0 +1,12 @@ +import type { Db } from "@paperclipai/db"; +import type { AgentConfigurationPatch, UpdateAgentOptions } from "../lib/agent-records.js"; +import { conflict } from "../errors.js"; +import { updateAgentConfiguration } from "../modules/agent-lifecycle/configuration.js"; +import { createAgentLifecycleEffects } from "./agent-lifecycle.js"; + +export function updateAgentConfigurationInTransaction(tx: Db, id: string, data: Omit, options?: UpdateAgentOptions) { + if (Object.prototype.hasOwnProperty.call(data, "budgetMonthlyCents")) { + throw conflict("Budget changes require a root lifecycle command"); + } + return updateAgentConfiguration(tx, createAgentLifecycleEffects(), id, data, options); +} diff --git a/server/src/services/agent-configuration.ts b/server/src/services/agent-configuration.ts new file mode 100644 index 00000000000..8037f150d0d --- /dev/null +++ b/server/src/services/agent-configuration.ts @@ -0,0 +1,150 @@ +import { and, eq } from "drizzle-orm"; +import { assets, agentConfigRevisions, agentTaskSessions, agentRuntimeState, type Db } from "@paperclipai/db"; +import { normalizeAgentUrlKey } from "@paperclipai/shared"; +import { normalizePaperclipRunnerAdapterConfig } from "@paperclipai/adapter-utils/server-utils"; +import { conflict, notFound, unprocessable } from "../errors.js"; +import { agentRecordQueries, type UpdateAgentOptions, type AgentConfigurationPatch, type AgentConfigurationRecord, isPlainRecord, buildConfigSnapshot, + hasConfigPatchFields, changedPendingApprovalConfigFields, diffConfigSnapshot } from "../lib/agent-records.js"; +import { normalizeAgentPermissions } from "../lib/agent-permissions.js"; +import type { ActivityPublication } from "../types/activity-publication.js"; +import { secretService, assertClaudeOAuthBindingInvariant } from "./secrets.js"; +import { agentCredentialService } from "./agent-credentials.js"; +import { clearPrimaryAgent } from "./primary-agent.js"; +import { budgetServiceInTransaction } from "./budgets.js"; + +export async function prepareAgentConfiguration(db: Db, existing: AgentConfigurationRecord, data: AgentConfigurationPatch, options?: UpdateAgentOptions): Promise { + const id = existing.id; + const { ensureManager, assertNoCycle, assertCompanyShortnameAvailable, assertBuiltInAgentMetadataMutationAllowed } = agentRecordQueries(db); + if (existing.status === "pending_approval" && !options?.allowPendingApprovalConfigUpdate) { + const changedFields = changedPendingApprovalConfigFields(agentRecordQueries(db).normalizeAgentRow(existing), data); + if (changedFields.length > 0) { + throw conflict("Pending approval agent configuration cannot be changed before board approval", { + code: "pending_approval_agent_config_frozen", + agentId: id, + fields: changedFields, + }); + } + } + + if (data.reportsTo !== undefined) { + if (data.reportsTo) { + await ensureManager(existing.companyId, data.reportsTo); + } + await assertNoCycle(id, data.reportsTo); + } + + if (data.name !== undefined) { + const previousShortname = normalizeAgentUrlKey(existing.name); + const nextShortname = normalizeAgentUrlKey(data.name); + if (previousShortname !== nextShortname) { + await assertCompanyShortnameAvailable(existing.companyId, data.name, { excludeAgentId: id }); + } + } + + if (Object.prototype.hasOwnProperty.call(data, "metadata")) { + assertBuiltInAgentMetadataMutationAllowed(existing.metadata, data.metadata, options); + } + + if (data.appearance?.customAvatarAssetId) { + const [asset] = await db.select().from(assets).where(and( + eq(assets.id, data.appearance.customAvatarAssetId), eq(assets.companyId, existing.companyId), + eq(assets.createdByAgentId, id), + )); + if (!asset || asset.contentType !== "image/png" || !asset.objectKey.startsWith(`${existing.companyId}/agent-avatars/${id}/`)) { + throw unprocessable("Use the avatar upload endpoint to set this agent's image"); + } + } + const normalizedPatch = { ...data } as AgentConfigurationPatch; + if (data.permissions !== undefined) { + normalizedPatch.permissions = normalizeAgentPermissions(data.permissions); + } + if ( + Object.prototype.hasOwnProperty.call(normalizedPatch, "adapterConfig") && + isPlainRecord(normalizedPatch.adapterConfig) + ) { + const normalizedAdapterConfig = await secretService(db).normalizeAdapterConfigForPersistence( + existing.companyId, + normalizedPatch.adapterConfig, + { adapterType: (normalizedPatch.adapterType ?? existing.adapterType) as string }, + ); + normalizedPatch.adapterConfig = normalizePaperclipRunnerAdapterConfig( + (normalizedPatch.adapterType ?? existing.adapterType) as string, + normalizedAdapterConfig, + ); + } else if ( + Object.prototype.hasOwnProperty.call(normalizedPatch, "adapterType") + && isPlainRecord(existing.adapterConfig) + ) { + normalizedPatch.adapterConfig = normalizePaperclipRunnerAdapterConfig( + normalizedPatch.adapterType as string, + existing.adapterConfig, + ); + } + return normalizedPatch; +} + +export async function completeAgentConfiguration(txDb: Db, existing: AgentConfigurationRecord, updated: AgentConfigurationRecord, normalizedPatch: AgentConfigurationPatch, options: UpdateAgentOptions | undefined, publications: ActivityPublication[]) { + const id = updated.id; + const shouldRecordRevision = Boolean(options?.recordRevision) && hasConfigPatchFields(normalizedPatch); + const beforeConfig = shouldRecordRevision + ? buildConfigSnapshot(agentRecordQueries(txDb).normalizeAgentRow(existing)) + : null; + if (updated.status === "terminated") { + await clearPrimaryAgent(txDb, updated.companyId, id); + } + + const priorAdapterConfig = isPlainRecord(existing.adapterConfig) ? existing.adapterConfig : {}; + const afterConfig = isPlainRecord(updated.adapterConfig) ? updated.adapterConfig : {}; + const changedExecution = updated.adapterType !== existing.adapterType + || (updated.adapterType === "paperclip_runner" && ["provider", "acpxAgent", "model"].some( + (key) => priorAdapterConfig[key] !== afterConfig[key], + )); + if (changedExecution) { + await txDb.delete(agentTaskSessions).where(and(eq(agentTaskSessions.companyId, existing.companyId), eq(agentTaskSessions.agentId, id))); + await txDb.update(agentRuntimeState).set({ adapterType: updated.adapterType, sessionId: null, stateJson: {}, updatedAt: new Date() }) + .where(and(eq(agentRuntimeState.companyId, existing.companyId), eq(agentRuntimeState.agentId, id))); + } + + if (Object.prototype.hasOwnProperty.call(normalizedPatch, "adapterConfig")) { + await agentCredentialService(txDb).enforceClaudeOAuthBindingClaim(txDb, { + companyId: existing.companyId, consume: false, environmentId: null, + childAdapterConfig: updated.adapterConfig, claudeLogin: options?.claudeLogin, + decision: assertClaudeOAuthBindingInvariant({ adapterType: updated.adapterType, + nextConfig: updated.adapterConfig, priorConfig: existing.adapterConfig }), + }); + await agentCredentialService(txDb).syncAgentSecretBindings( + updated, txDb, + existing.adapterConfig, + options?.recordRevision, + ); + } + + if (normalizedPatch.budgetMonthlyCents !== undefined) { + await budgetServiceInTransaction(txDb, publications).upsertPolicy(existing.companyId, { + scopeType: "agent", scopeId: id, amount: normalizedPatch.budgetMonthlyCents, + isActive: normalizedPatch.budgetMonthlyCents > 0, windowKind: "calendar_month_utc", + }, options?.recordRevision?.createdByUserId ?? null); + } + const normalizedUpdated = await agentRecordQueries(txDb).getById(updated.id); + if (!normalizedUpdated) { + throw notFound("Agent not found"); + } + + if (shouldRecordRevision && beforeConfig) { + const afterConfig = buildConfigSnapshot(normalizedUpdated); + const changedKeys = diffConfigSnapshot(beforeConfig, afterConfig); + if (changedKeys.length > 0) { + await txDb.insert(agentConfigRevisions).values({ + companyId: normalizedUpdated.companyId, + agentId: normalizedUpdated.id, + createdByAgentId: options?.recordRevision?.createdByAgentId ?? null, + createdByUserId: options?.recordRevision?.createdByUserId ?? null, + source: options?.recordRevision?.source ?? "patch", + rolledBackFromRevisionId: options?.recordRevision?.rolledBackFromRevisionId ?? null, + changedKeys, + beforeConfig: beforeConfig as unknown as Record, + afterConfig: afterConfig as unknown as Record, + }); + } + } +} diff --git a/server/src/services/agent-credentials.ts b/server/src/services/agent-credentials.ts new file mode 100644 index 00000000000..656fc18d3bf --- /dev/null +++ b/server/src/services/agent-credentials.ts @@ -0,0 +1,197 @@ +import { eq } from "drizzle-orm"; +import { agents, type Db } from "@paperclipai/db"; +import { collectSecretRefs, collectUserSecretRefs, syncAgentAdapterEnvBindings } from "./agent-secret-bindings.js"; +import { logActivity } from "./activity-log.js"; +import { claudeOAuthBindingsMatchExactly, claudeOAuthClaimRejectedError, + CLAUDE_LOCAL_ADAPTER_TYPE, readClaudeOAuthBinding, secretService, type ClaudeOAuthBindingInvariantDecision } from "./secrets.js"; +import { createDbSetupTokenCleanupStore } from "./setup-token-session.js"; +import type { ClaudeLoginContext, RevisionMetadata } from "../lib/agent-records.js"; + +export function agentCredentialService(db: Db) { + const secretsSvc = secretService(db); + async function syncAgentSecretBindings( + agent: { id: string; companyId: string; adapterConfig: unknown }, + dbClient: Db = db, + previousAdapterConfig: unknown = null, + actor: RevisionMetadata = {}, + ) { + const scopedSecretsSvc = dbClient === db ? secretsSvc : secretService(dbClient); + await syncAgentAdapterEnvBindings({ + secretsSvc: scopedSecretsSvc, + companyId: agent.companyId, + agentId: agent.id, + adapterConfig: agent.adapterConfig, + }); + const previousRefs = new Set([ + ...collectSecretRefs(previousAdapterConfig).map((ref) => `secret:${ref.secretId}:${ref.configPath}`), + ...collectUserSecretRefs(previousAdapterConfig).map((ref) => `user:${ref.definitionKey}:${ref.configPath}`), + ]); + const createdRefs = [ + ...collectSecretRefs(agent.adapterConfig).map((ref) => ({ + key: `secret:${ref.secretId}:${ref.configPath}`, + configPath: ref.configPath, + bindingType: "secret_ref", + secretId: ref.secretId, + definitionKey: null, + })), + ...collectUserSecretRefs(agent.adapterConfig).map((ref) => ({ + key: `user:${ref.definitionKey}:${ref.configPath}`, + configPath: ref.configPath, + bindingType: "user_secret_ref", + secretId: null, + definitionKey: ref.definitionKey, + })), + ].filter((ref) => !previousRefs.has(ref.key)); + const actorType = actor.createdByUserId ? "user" as const : actor.createdByAgentId ? "agent" as const : "system" as const; + const actorId = actor.createdByUserId ?? actor.createdByAgentId ?? "system"; + for (const ref of createdRefs) { + await logActivity(dbClient, { + companyId: agent.companyId, + actorType, + actorId, + agentId: actor.createdByAgentId ?? null, + action: "secret.binding.created", + entityType: "agent", + entityId: agent.id, + details: { + targetType: "agent", + targetId: agent.id, + configPath: ref.configPath, + bindingType: ref.bindingType, + secretId: ref.secretId, + definitionKey: ref.definitionKey, + }, + }); + } + } + + /** + * Enforces the Claude OAuth binding claim inside a write transaction. It runs + * after {@link assertClaudeOAuthBindingInvariant} decided that the write + * introduces or keeps the fixed binding. + * + * When the write introduces the fixed binding: + * * A create or hire path (`consume: true`) consumes a stored-session claim + * with one conditional write. It builds the claim scope from the company, + * the owner user, the fixed adapter, the environment, and the + * `storedSessionId`. It inserts the binding only when the write returns one + * row; otherwise it raises the fixed claim error, which rolls back the + * whole transaction and inserts no binding. + * * An update, approval, or rollback path (`consume: false`) carries no + * claim, so it raises the same fixed claim error at once. + * + * The user-actor apply-existing path (`applyExistingWithoutClaim`) binds the + * fixed reference with no login round trip. The route sets the flag only for + * an authenticated user actor and derives the owner from that actor. The gate + * permits the no-claim bind only when the owner already has a stored value for + * the company. It reads the owner value status; it reads no token. A missing + * owner or a missing stored value raises the same fixed claim error, so the + * caller cannot tell the reasons apart. + * + * The hire-inheritance path (`inheritedFromAgentId`) binds the fixed + * reference with no login round trip and no stored owner value, because the + * owning user resolves per run, not from a value stored against this agent. + * The route copies the parent's reference onto the child before this + * transaction starts, so a concurrent version change on the parent can + * leave the child holding a stale version. The gate re-reads the named + * parent agent inside this transaction and permits the bind only when the + * parent exists, is in the same company, is a `claude_local` agent, and its + * current reference matches the child's copied reference exactly, including + * the version selector. The gate locks the parent row with `SELECT ... + * FOR UPDATE` before it reads the reference. The lock blocks a concurrent + * credential rotation on the same parent row until this transaction + * commits or rolls back, so the compare-and-bind check stays atomic with + * the parent's current state. The route derives the parent identifier + * from the authenticated agent actor, never from the request body, so the + * gate treats it as a claim to verify, not a trusted value. + * + * A controlled internal override skips the claim for a migration or an + * administrator repair. The function creates the fixed user-secret definition + * before the caller runs the declaration synchronization, so the synchronized + * declaration always references an existing definition. + */ + async function enforceClaudeOAuthBindingClaim( + txDb: Db, + input: { + companyId: string; + decision: ClaudeOAuthBindingInvariantDecision; + consume: boolean; + environmentId: string | null; + claudeLogin?: ClaudeLoginContext; + /** + * The adapter config the write is about to persist. The + * `inheritedFromAgentId` path reads the child's copied + * `CLAUDE_CODE_OAUTH_TOKEN` reference from it, to compare against the + * parent's current reference. + */ + childAdapterConfig?: unknown; + }, + ): Promise { + const ownerUserId = input.claudeLogin?.ownerUserId ?? null; + if (input.decision.introducesBinding && !input.claudeLogin?.allowInternalBindingOverride) { + if (input.claudeLogin?.applyExistingWithoutClaim) { + // The user-actor apply-existing path. The route derived the owner from + // the authenticated user actor. The gate binds the fixed reference only + // when that owner already has a stored value. It reads no token. + if (!ownerUserId) { + throw claudeOAuthClaimRejectedError(); + } + const stored = await secretService(txDb).readClaudeOAuthUserSecretStatus( + input.companyId, + ownerUserId, + ); + if (!stored) { + throw claudeOAuthClaimRejectedError(); + } + } else if (input.claudeLogin?.inheritedFromAgentId) { + // The hire-inheritance path. Re-read the named parent inside this + // transaction; a caller-supplied identifier never binds on its own. + // Compare the parent's current reference against the reference + // already copied onto the child, including the version selector, so + // a concurrent version change on the parent cannot leave the child + // bound to a stale version. + const parentId = input.claudeLogin.inheritedFromAgentId; + const parent = await txDb + .select({ + companyId: agents.companyId, + adapterType: agents.adapterType, + adapterConfig: agents.adapterConfig, + }) + .from(agents) + .where(eq(agents.id, parentId)) + .for("update") + .then((rows) => rows[0] ?? null); + const parentBinding = readClaudeOAuthBinding(parent?.adapterConfig ?? null); + const childBinding = readClaudeOAuthBinding(input.childAdapterConfig ?? null); + if ( + !parent || + parent.companyId !== input.companyId || + parent.adapterType !== CLAUDE_LOCAL_ADAPTER_TYPE || + !claudeOAuthBindingsMatchExactly(parentBinding, childBinding) + ) { + throw claudeOAuthClaimRejectedError(); + } + } else if (!input.consume) { + throw claudeOAuthClaimRejectedError(); + } else { + const consumed = await createDbSetupTokenCleanupStore(txDb).consumeStoredClaim({ + sessionId: input.claudeLogin?.storedSessionId ?? "", + companyId: input.companyId, + ownerUserId: ownerUserId ?? "", + adapterType: CLAUDE_LOCAL_ADAPTER_TYPE, + }); + if (!consumed) { + throw claudeOAuthClaimRejectedError(); + } + } + } + if (input.decision.introducesBinding || input.decision.keepsBinding) { + // Create the fixed definition before declaration synchronization. + await secretService(txDb).ensureClaudeOAuthUserSecretDefinition(input.companyId, { + userId: ownerUserId, + }); + } + } + + return { syncAgentSecretBindings, enforceClaudeOAuthBindingClaim }; +} diff --git a/server/src/services/agent-deletion.ts b/server/src/services/agent-deletion.ts new file mode 100644 index 00000000000..7819af773e2 --- /dev/null +++ b/server/src/services/agent-deletion.ts @@ -0,0 +1,41 @@ +import { and, eq, or, sql } from "drizzle-orm"; +import { agents, agentApiKeys, agentRuntimeState, agentTaskSessions, agentWakeupRequests, activityLog, + budgetReservations, heartbeatRunEvents, heartbeatRuns, issueExecutionDecisions, issues, issueComments, + principalPermissionGrants, type Db } from "@paperclipai/db"; +import { conflict } from "../errors.js"; +import { issueThreadInteractionService } from "./issue-thread-interactions.js"; + +export async function deleteAgentDependencies(tx: Db, companyId: string, id: string) { + const [decisionHold] = await tx.select({ id: budgetReservations.id }).from(budgetReservations).where(and( + eq(budgetReservations.companyId, companyId), eq(budgetReservations.agentId, id), + eq(budgetReservations.state, "held"), sql`${budgetReservations.decisionInvocationId} is not null`, + )).limit(1); + if (decisionHold) throw conflict("Wait for active decisions or resolve their unknown charges in Costs before deleting this agent", { + code: "agent_decision_accounting_pending", + }); + await issueThreadInteractionService(tx).cancelPendingForDeletedAddressee(companyId, id); + await tx.update(agents).set({ reportsTo: null }).where(eq(agents.reportsTo, id)); + await tx + .update(issues) + .set({ assigneeAgentId: null, createdByAgentId: null }) + .where(or(eq(issues.assigneeAgentId, id), eq(issues.createdByAgentId, id))); + await tx.delete(heartbeatRunEvents).where(eq(heartbeatRunEvents.agentId, id)); + await tx.delete(agentTaskSessions).where(eq(agentTaskSessions.agentId, id)); + await tx.delete(activityLog).where( + or( + eq(activityLog.agentId, id), + sql`${activityLog.runId} in (select ${heartbeatRuns.id} from ${heartbeatRuns} where ${heartbeatRuns.agentId} = ${id})`, + ), + ); + await tx.delete(issueExecutionDecisions).where(eq(issueExecutionDecisions.actorAgentId, id)); + await tx.delete(issueComments).where(eq(issueComments.authorAgentId, id)); + await tx.delete(heartbeatRuns).where(eq(heartbeatRuns.agentId, id)); + await tx.delete(agentWakeupRequests).where(eq(agentWakeupRequests.agentId, id)); + await tx.delete(agentApiKeys).where(eq(agentApiKeys.agentId, id)); + await tx.delete(agentRuntimeState).where(eq(agentRuntimeState.agentId, id)); + await tx.delete(principalPermissionGrants).where(and( + eq(principalPermissionGrants.companyId, companyId), + eq(principalPermissionGrants.principalType, "agent"), + eq(principalPermissionGrants.principalId, id), + )); +} diff --git a/server/src/services/agent-environment-test.ts b/server/src/services/agent-environment-test.ts new file mode 100644 index 00000000000..ae26b719ba7 --- /dev/null +++ b/server/src/services/agent-environment-test.ts @@ -0,0 +1,533 @@ +import type { Db } from "@paperclipai/db"; +import type { AdapterExecutionTarget } from "@paperclipai/adapter-utils/execution-target"; +import type { AdapterEnvironmentCheck } from "@paperclipai/adapter-utils"; +import { parseObject } from "@paperclipai/adapter-utils/server-utils"; +import { aiRoutingHarness, ADAPTER_AUTH_MISSING_CHECK_CODE, AI_CONNECTION_CAPABILITIES, type AiConnectionBinding } from "@paperclipai/shared"; +import { requireServerAdapter } from "../adapters/index.js"; +import { forbidden, HttpError, unprocessable } from "../errors.js"; +import { instanceSettingsService } from "./instance-settings.js"; +import { environmentService } from "./environments.js"; +import { environmentRuntimeService } from "./environment-runtime.js"; +import { resolveEnvironmentExecutionTarget } from "./environment-execution-target.js"; +import { prepareManagedAiRuntime, assertManagedAiProjectAuth } from "./ai-connection-runtime.js"; +import { aiConnectionService } from "./ai-connections.js"; +import { validateAiApiKey } from "./ai-api-key-test.js"; +import type { PluginWorkerManager } from "./plugin-worker-manager.js"; +import { assertEnvironmentSelectionForCompany } from "./environment-selection.js"; +const asRecord = (value: unknown): Record | null => value && typeof value === "object" && !Array.isArray(value) ? value as Record : null; +export function agentEnvironmentTestService(db: Db, pluginWorkerManager?: PluginWorkerManager) { + const instanceSettings = instanceSettingsService(db); + const environmentsSvc = environmentService(db); + const environmentRuntime = environmentRuntimeService(db, { pluginWorkerManager }); + // A null agent override inherits the instance default, just like dispatch. + // Resolve this before secrets or probes so a default remote environment can + // never accidentally validate the account on the control-plane host. + async function resolveAdapterTestEnvironmentId(companyId: string, environmentId: string | null | undefined) { + if (environmentId) return environmentId; + const settings = await instanceSettings.get(); + if (settings.defaultEnvironmentId) return settings.defaultEnvironmentId; + if ((await instanceSettings.getExperimental()).enableManagedSandboxOnly === true) { + const managed = await environmentsSvc.findManagedSandboxEnvironment(companyId); + if (!managed) { + throw unprocessable("The managed sandbox is unavailable. Restore Paperclip Computer and retry.", { + code: "managed_sandbox_unavailable", + }); + } + return managed.id; + } + return null; + } + + /** + * Resolve the execution target the adapter should run its test probes against. + * + * - No environmentId / local environment → returns a local target so the + * adapter probes the Paperclip host (legacy behavior). + * - SSH environment → builds an SSH execution target from the environment + * config so the adapter probes the remote box. No lease is required: + * the SSH spec is fully derived from the saved environment config. + * - Sandbox / plugin environments → acquires an ad-hoc lease, realizes the + * workspace, and resolves a sandbox execution target wired to the runtime + * so the adapter probe runs inside the sandbox the same way a heartbeat + * would. The returned `release` callback rolls the lease back when the + * route is done. + * + * The caller MUST always invoke `release()` (typically in a `finally` block). + */ + async function resolveAdapterTestExecutionContext(input: { + agentId?: string; + companyId: string; + adapterType: string; + environmentId: string | null; + }): Promise<{ + executionTarget: AdapterExecutionTarget | null; + environmentName: string | null; + fallbackChecks: AdapterEnvironmentCheck[]; + sandboxIdentityCheck?: AdapterEnvironmentCheck | null; + release: (status?: "released" | "failed") => Promise; + }> { + const noopRelease = async () => {}; + + if (!input.environmentId) { + return { + executionTarget: null, + environmentName: null, + fallbackChecks: [], + release: noopRelease, + }; + } + + const requestedEnvironment = await environmentsSvc.getById(input.environmentId); + if (!requestedEnvironment) { + return { + executionTarget: null, + environmentName: null, + fallbackChecks: [ + { + code: "environment_not_found", + level: "warn", + message: "Selected environment was not found. The test did not run.", + }, + ], + release: noopRelease, + }; + } + + // Managed-sandbox-only policy: redirect a Test that would run on the local + // host onto the platform-managed sandbox, the same as a real run does + // (resolveExecutionWorkspaceEnvironmentId in heartbeat). Without this + // redirect the Test probes the local host while the run executes in the + // managed sandbox, so a passing Test validates the wrong execution target. + // With no active managed sandbox the Test fails closed — never local. + let environment = requestedEnvironment; + if (requestedEnvironment.driver === "local") { + const managedSandboxOnly = + (await instanceSettings.getExperimental()).enableManagedSandboxOnly === true; + if (managedSandboxOnly) { + const managedSandboxEnvironment = await environmentsSvc.findManagedSandboxEnvironment( + input.companyId, + ); + if (!managedSandboxEnvironment) { + return { + executionTarget: null, + environmentName: requestedEnvironment.name, + fallbackChecks: [ + { + code: "managed_sandbox_unavailable", + level: "error", + message: + "This instance runs agents only in its platform-managed sandbox, but no active managed sandbox environment exists. The test did not run.", + hint: "Restore the managed sandbox environment, then test again.", + }, + ], + release: noopRelease, + }; + } + environment = managedSandboxEnvironment; + } + } + + if (environment.driver === "local") { + return { + executionTarget: null, + environmentName: environment.name, + fallbackChecks: [], + release: noopRelease, + }; + } + + if (environment.driver === "ssh") { + try { + const target = await resolveEnvironmentExecutionTarget({ + db, + companyId: input.companyId, + adapterType: input.adapterType, + environment: { + id: environment.id, + driver: environment.driver, + config: environment.config ?? null, + }, + leaseMetadata: null, + }); + if (target) { + return { + executionTarget: target, + environmentName: environment.name, + fallbackChecks: [], + release: noopRelease, + }; + } + return { + executionTarget: null, + environmentName: environment.name, + fallbackChecks: [ + { + code: "environment_target_unavailable", + level: "warn", + message: + `Could not resolve an execution target for environment "${environment.name}". The test did not run.`, + }, + ], + release: noopRelease, + }; + } catch (err) { + return { + executionTarget: null, + environmentName: environment.name, + fallbackChecks: [ + { + code: "environment_target_failed", + level: "warn", + message: + `Could not connect to environment "${environment.name}" to run the test.`, + detail: err instanceof Error ? err.message : String(err), + }, + ], + release: noopRelease, + }; + } + } + + // sandbox / plugin / other remote drivers: spin up an ad-hoc lease, realize + // the workspace inside the box, and run the same probe SSH uses against + // a sandbox execution target wired to the environment runtime. + // + // We pass `heartbeatRunId: null` because there's no heartbeat run for an + // operator-initiated `Test` invocation — the leases table FKs heartbeat + // run id to heartbeat_runs.id, and we don't want to manufacture a fake + // run row. Cleanup goes through the driver's `releaseRunLease` directly + // (by lease record), since the batch helper queries by heartbeatRunId. + // + // Sandbox tests boot a fresh throwaway sandbox (never resume a retained + // agent lease) and archive it on release instead of deleting it, so the + // operator can inspect the exact sandbox from the provider dashboard while + // provider-side expiry reaps it later. + const testEnvironment = environment.driver === "sandbox" + ? { + ...environment, + config: { + ...(environment.config ?? {}), + reuseLease: false, + archiveOnRelease: true, + }, + } + : environment; + let leaseRecord: Awaited>; + try { + leaseRecord = await environmentRuntime.acquireRunLease({ + companyId: input.companyId, + agentId: input.agentId, + environment: testEnvironment, + issueId: null, + heartbeatRunId: null, + persistedExecutionWorkspace: null, + // Re-check the company binding atomically at lease time. The route + // guard already rejected a foreign environment, but the binding could + // change between the guard check and the lease acquire. This closes + // that check-to-lease race so a foreign sandbox never gets a lease. + assertCompanyBinding: true, + // Apply the active custom-image template so the Test boots with the + // operator's captured sandbox customizations and prepared image state, + // matching what real agent runs use. Without this the test would + // silently fall back to the base image. + applyCustomImageTemplate: true, + }); + } catch (err) { + return { + executionTarget: null, + environmentName: environment.name, + fallbackChecks: [ + { + code: "environment_lease_acquire_failed", + level: "error", + message: `Could not acquire a lease for environment "${environment.name}".`, + detail: err instanceof Error ? err.message : String(err), + hint: "Check the environment's provider credentials and quota.", + }, + ], + release: noopRelease, + }; + } + + const driver = environmentRuntime.getDriver(environment.driver); + const releaseLease = async (status: "released" | "failed" = "released") => { + try { + if (driver) { + await driver.releaseRunLease({ + environment: testEnvironment, + lease: leaseRecord.lease, + status, + }); + } else { + await environmentsSvc.releaseLease(leaseRecord.lease.id, status); + } + } catch (err) { + // Cleanup failures must not mask the test result. + // eslint-disable-next-line no-console + console.warn( + `[adapter-test] Failed to release lease ${leaseRecord.lease.id}: ${err instanceof Error ? err.message : String(err)}`, + ); + } + }; + + let realizedCwd: string | null = null; + try { + const realized = await environmentRuntime.realizeWorkspace({ + environment: testEnvironment, + lease: leaseRecord.lease, + // No host workspace to copy for a Test invocation; sandbox/plugin + // realize implementations use the lease metadata's remoteCwd to + // create the working directory inside the box. + workspace: {}, + }); + realizedCwd = + typeof realized.cwd === "string" && realized.cwd.trim().length > 0 + ? realized.cwd.trim() + : null; + } catch (err) { + await releaseLease("failed"); + return { + executionTarget: null, + environmentName: environment.name, + fallbackChecks: [ + { + code: "environment_workspace_realize_failed", + level: "error", + message: `Could not realize a workspace inside "${environment.name}".`, + detail: err instanceof Error ? err.message : String(err), + }, + ], + release: noopRelease, + }; + } + + let target: AdapterExecutionTarget | null; + try { + // Prefer the cwd the realize step returned; fall back to lease metadata. + const leaseMetadataForTarget: Record | null = + realizedCwd + ? { ...(leaseRecord.lease.metadata ?? {}), remoteCwd: realizedCwd } + : (leaseRecord.lease.metadata as Record | null) ?? null; + + target = await resolveEnvironmentExecutionTarget({ + db, + companyId: input.companyId, + adapterType: input.adapterType, + environment: { + id: testEnvironment.id, + driver: testEnvironment.driver, + config: testEnvironment.config ?? null, + }, + leaseId: leaseRecord.lease.id, + leaseMetadata: leaseMetadataForTarget, + lease: leaseRecord.lease, + environmentRuntime, + }); + } catch (err) { + await releaseLease("failed"); + return { + executionTarget: null, + environmentName: environment.name, + fallbackChecks: [ + { + code: "environment_target_failed", + level: "error", + message: `Could not resolve an execution target for "${environment.name}".`, + detail: err instanceof Error ? err.message : String(err), + }, + ], + release: noopRelease, + }; + } + + if (!target) { + await releaseLease("failed"); + return { + executionTarget: null, + environmentName: environment.name, + fallbackChecks: [ + { + code: "environment_target_unsupported", + level: "warn", + message: + `Adapter "${input.adapterType}" is not allowed in "${environment.name}" environments.`, + }, + ], + release: noopRelease, + }; + } + + return { + executionTarget: target, + environmentName: environment.name, + fallbackChecks: [], + sandboxIdentityCheck: buildSandboxIdentityCheck({ + environmentName: environment.name, + lease: leaseRecord.lease, + }), + release: releaseLease, + }; + } + + function readMetadataString(metadata: Record, keys: string[]): string | null { + for (const key of keys) { + const value = metadata[key]; + if (typeof value === "string" && value.trim().length > 0) return value.trim(); + } + return null; + } + + function buildSandboxIdentityCheck(input: { + environmentName: string; + lease: { + id: string; + provider?: string | null; + providerLeaseId?: string | null; + metadata?: Record | null; + }; + }): AdapterEnvironmentCheck { + const metadata = input.lease.metadata ?? {}; + const provider = input.lease.provider ?? readMetadataString(metadata, ["provider"]); + const sandboxId = readMetadataString(metadata, ["sandboxId", "sandboxID", "sandbox_id", "id"]); + const sandboxName = readMetadataString(metadata, ["sandboxName", "sandbox_name", "name"]); + const snapshotRef = readMetadataString(metadata, [ + "snapshot", + "snapshotId", + "snapshotID", + "snapshotRef", + "snapshot_ref", + "templateRef", + "template_ref", + "templateId", + "templateID", + "image", + "imageId", + "imageID", + "imageRef", + "image_ref", + ]); + const templateKind = readMetadataString(metadata, [ + "templateKind", + "template_kind", + "templateRefKind", + "template_ref_kind", + ]); + const detailParts = [ + `paperclipLeaseId=${input.lease.id}`, + input.lease.providerLeaseId ? `providerLeaseId=${input.lease.providerLeaseId}` : null, + provider ? `provider=${provider}` : null, + sandboxId ? `sandboxId=${sandboxId}` : null, + sandboxName ? `sandboxName=${sandboxName}` : null, + snapshotRef ? `${templateKind ? `${templateKind}Ref` : "snapshotOrTemplateRef"}=${snapshotRef}` : null, + ].filter((part): part is string => Boolean(part)); + + return { + code: "sandbox_test_identity", + level: "info", + message: `Environment test identity for "${input.environmentName}".`, + detail: detailParts.join("; "), + hint: "Use these provider-neutral IDs when comparing model-test output with provider logs or refreshed environment snapshots.", + }; + } + + + // The environment drivers the adapter Test route accepts. A local, SSH, or + // sandbox environment can host a probe; a plugin environment cannot. + const ADAPTER_TEST_ALLOWED_ENVIRONMENT_DRIVERS = ["local", "ssh", "sandbox"]; + + // The fail-closed tenant-binding guard for the adapter Test route. A caller + // may name any instance environment by id, so the route must reject an + // environment that binds to another company before it resolves secrets, + // merges env, resolves the target, leases a sandbox, or runs the adapter + // test. The guard checks the company binding BEFORE it validates the status + // or the driver, so it never reveals the status or the driver of a foreign + // environment. A same-company or an instance-global environment then gets the + // shared driver and status validation. + async function assertAdapterTestEnvironmentForCompany( + companyId: string, + environmentId: string, + ): Promise { + const environment = await environmentsSvc.getById(environmentId); + if (!environment) { + // A missing environment leaks no tenant state. The execution-context + // resolver surfaces the existing environment_not_found check. + return; + } + const boundCompanyIds = await environmentsSvc.listBoundCompanyIds(environmentId); + if (boundCompanyIds.length > 0 && !boundCompanyIds.includes(companyId)) { + throw forbidden("The selected environment belongs to another company.", { + code: "environment_company_mismatch", + }); + } + await assertEnvironmentSelectionForCompany(environmentsSvc, companyId, environmentId, { + allowedDrivers: ADAPTER_TEST_ALLOWED_ENVIRONMENT_DRIVERS, + }); + } + + async function testManagedEnvironment(adapterType: string, context: Parameters["testEnvironment"]>[0], binding: AiConnectionBinding, managed: Awaited>, agentId?: string) { + const startedAt = new Date(); + const result = await probeManagedEnvironment(adapterType, context, binding); + // A provider rejection invalidates the tested credential generation. A + // missing CLI, unavailable environment, or other runtime error does not. + if (result.status === "fail" && result.checks.some(check => + check.code === ADAPTER_AUTH_MISSING_CHECK_CODE || /_hello_probe_auth_required$/.test(check.code) + || check.code === "ai_connection_api_key_rejected", + )) { + await aiConnectionService(db).markAuthenticationFailed({ + companyId: context.companyId, agentId, runStartedAt: startedAt, + attribution: { ...managed.attribution, identity: managed.identity }, + }); + } + return result; + } + + async function probeManagedEnvironment(adapterType: string, context: Parameters["testEnvironment"]>[0], binding: AiConnectionBinding) { + await assertManagedAiProjectAuth(context.config, binding.provider, context.executionTarget); + const result = await requireServerAdapter(adapterType).testEnvironment(context); + if (result.status === "fail") return result; + // The resolved method, not binding.method — on a responsible_user binding + // that field is wire-compat only and the default connection decides. + const resolvedMethod = (context.config as { managedAiConnection?: { method?: string } }).managedAiConnection?.method; + // An api_key account does not take the CLI hello probe below: a key + // travels as an env var any engine understands, and the engine's own test + // above judged whether this runtime can execute with it — the ACP lane + // deliberately runs no hello probe when a key is configured. Demanding one + // anyway forced the CLI lane, whose probe needs a provider CLI on PATH, + // and a clean install has none: that walled off onboarding's API-key path + // on exactly the machines the release smoke exists to guard. The account + // is still verified live here — the same provider-endpoint check the save + // performed — so a key revoked since its save fails adoption rather than + // producing an agent that cannot authenticate at runtime. The hello-probe + // requirement stays for subscriptions: a stored login is a file layout + // only a provider CLI reads, so proving the runtime lane can consume it + // takes a real hello turn. + if (resolvedMethod === "api_key" && !context.config.managedAiRouting) { + const envKey = AI_CONNECTION_CAPABILITIES[binding.provider].methods.api_key?.envKey; + const key = envKey ? parseObject(context.config.env)[envKey] : undefined; + try { + if (typeof key !== "string" || !key) throw unprocessable("The selected account's API key was not available to verify."); + await validateAiApiKey(binding.provider, key); + result.checks.push({ code: "ai_connection_api_key_reverified", level: "info", message: "The provider verified this API key for adoption." }); + } catch (error) { + result.status = "fail"; + const rejected = error instanceof HttpError && asRecord(error.details)?.code === "ai_connection_api_key_rejected"; + result.checks.push({ code: rejected ? "ai_connection_api_key_rejected" : "ai_connection_verification_failed", level: "error", message: error instanceof HttpError ? error.message : "Could not verify the account. Try again." }); + } + return result; + } + if (!result.checks.some(check => check.code.includes("hello_probe"))) { + const providerAdapter = context.config.managedAiRouting ? aiRoutingHarness(adapterType, context.config.provider, context.config.acpxAgent) : { anthropic: "claude_local", openai: "codex_local", openrouter: "opencode_local", xai: "grok_local", google: "gemini_local" }[binding.provider]; + const probe = await requireServerAdapter(providerAdapter).testEnvironment({ ...context, adapterType: providerAdapter, config: { ...context.config, engine: "cli" } }); + result.checks.push(...probe.checks); + result.status = probe.status === "fail" ? "fail" : result.status === "warn" || probe.status === "warn" ? "warn" : "pass"; + } + if (!result.checks.some(check => /hello_probe_(passed|succeeded)$/.test(check.code))) { + result.status = "fail"; + result.checks.push({ code: "ai_connection_validation_incomplete", level: "error", message: "The selected account has not completed a provider hello test. Retry before adopting it." }); + } + return result; + } + + + return { resolveAdapterTestEnvironmentId, resolveAdapterTestExecutionContext, assertAdapterTestEnvironmentForCompany, testManagedEnvironment }; +} diff --git a/server/src/services/agent-execution-stop.ts b/server/src/services/agent-execution-stop.ts new file mode 100644 index 00000000000..3fad14e89b1 --- /dev/null +++ b/server/src/services/agent-execution-stop.ts @@ -0,0 +1,74 @@ +import { readProcessStartedAt } from "./hot-restart.js"; +import { runUsedConversationAdapter } from "./conversation-continuation.js"; +import { and, eq, inArray, isNull, or, sql } from "drizzle-orm"; +import { environmentLeases, heartbeatRuns, nativeRunFinalizations, type Db } from "@paperclipai/db"; +import { hasNativeLocalProcessStop } from "./native-local-process-stop.js"; +import { hasRemoteTerminationReceipt } from "./remote-execution-termination.js"; +import { isCancelledNativeStartup } from "./cancelled-native-startup.js"; + +/** Cancellation changes admission. Process and lease evidence controls cleanup. */ +export async function agentExecutionsHaveStopped(db: Db, agentIds: string[]) { + if (!agentIds.length) return true; + const runs = await db.select().from(heartbeatRuns).where(inArray(heartbeatRuns.agentId, agentIds)); + const runIds = db.select({ id: heartbeatRuns.id }).from(heartbeatRuns).where(inArray(heartbeatRuns.agentId, agentIds)); + const leases = await db.select().from(environmentLeases).where(or( + inArray(environmentLeases.heartbeatRunId, runIds), + inArray(sql`${environmentLeases.metadata}->>'agentId'`, agentIds), + )); + if (leases.some(lease => (!lease.releasedAt && !(lease.status === "retained" && lease.cleanupStatus === "success")) || lease.status === "pending_cleanup" || lease.cleanupStatus === "failed")) return false; + const coordinators = await db.select().from(nativeRunFinalizations) + .where(inArray(nativeRunFinalizations.runId, runIds)); + const now = new Date(); + const abandoned = coordinators.filter(row => row.leaseOwner); + if (abandoned.some(row => !row.leaseExpiresAt || row.leaseExpiresAt > now || row.resultId || + runs.find(run => run.id === row.runId)?.status !== "cancelled")) return false; + const absent = (pid: number) => { + try { process.kill(pid, 0); return false; } + catch (error) { return (error as NodeJS.ErrnoException).code === "ESRCH"; } + }; + for (const coordinator of abandoned) { + if (!coordinator.controllerPid || absent(coordinator.controllerPid)) continue; + const observed = await readProcessStartedAt(coordinator.controllerPid).catch(() => null); + if (!observed || !coordinator.controllerProcessStartedAt || + new Date(observed).getTime() === coordinator.controllerProcessStartedAt.getTime()) return false; + } + for (const run of runs) { + if (!["succeeded", "failed", "cancelled", "timed_out", "interrupted"].includes(run.status)) return false; + if (run.controllerLeaseExpiresAt && run.controllerLeaseExpiresAt > new Date()) return false; + const runLeases = leases.filter(lease => lease.heartbeatRunId === run.id); + if (runLeases.some(lease => lease.provider && lease.provider !== "local")) { + if (run.status === "cancelled" && !runLeases.every(hasRemoteTerminationReceipt)) return false; + continue; + } + let processAlive = Boolean(run.processPid && !absent(run.processPid)); + let groupAlive = Boolean(run.processGroupId && !absent(-run.processGroupId)); + if (processAlive && run.processStartedAt) { + const observed = await readProcessStartedAt(run.processPid!).catch(() => null); + if (observed && new Date(observed).getTime() !== run.processStartedAt.getTime()) { + processAlive = false; + if (run.processGroupId === run.processPid) groupAlive = false; + } + } + if (processAlive || groupAlive) return false; + if (run.status !== "cancelled" || !run.startedAt) continue; + if (run.runtimeMode === "native" && !run.processPid && !run.processGroupId && + !await hasNativeLocalProcessStop(db, run.companyId, run.id) && + !await isCancelledNativeStartup(db, run, coordinators.find(row => row.runId === run.id))) return false; + if (run.runtimeMode === "legacy" && !run.processPid && !run.processGroupId && + (run.resultJson?.executionCancellation as Record | undefined)?.state !== "acknowledged" && + !(run.executionStage === "settled" && !await runUsedConversationAdapter(db, run)) && + !await isCancelledNativeStartup(db, run, coordinators.find(row => row.runId === run.id))) return false; + } + // Release an expired owner only after its cancelled execution has stop proof. + for (const coordinator of abandoned) { + const [cleared] = await db.update(nativeRunFinalizations).set({ leaseOwner: null, leaseExpiresAt: null, updatedAt: now }) + .where(and(eq(nativeRunFinalizations.runId, coordinator.runId), + eq(nativeRunFinalizations.leaseOwner, coordinator.leaseOwner!), + eq(nativeRunFinalizations.leaseExpiresAt, coordinator.leaseExpiresAt!), + eq(nativeRunFinalizations.controllerGeneration, coordinator.controllerGeneration), + eq(nativeRunFinalizations.phase, coordinator.phase), isNull(nativeRunFinalizations.resultId))) + .returning({ runId: nativeRunFinalizations.runId }); + if (!cleared) return false; + } + return true; +} diff --git a/server/src/services/agent-harness-verification.ts b/server/src/services/agent-harness-verification.ts new file mode 100644 index 00000000000..b7133488f9e --- /dev/null +++ b/server/src/services/agent-harness-verification.ts @@ -0,0 +1,76 @@ +import { and, eq } from "drizzle-orm"; +import { agents, companies, type Db } from "@paperclipai/db"; +import type { AdapterEnvironmentTestResult } from "@paperclipai/adapter-utils"; +import { ADAPTER_AUTH_MISSING_CHECK_CODE, aiRuntimeConnectionBindingSchema } from "@paperclipai/shared"; +import { isForbiddenConfigEnvKey, parseObject } from "@paperclipai/adapter-utils/server-utils"; +import { requireServerAdapter } from "../adapters/index.js"; +import { agentEnvironmentTestService } from "./agent-environment-test.js"; +import { aiConnectionRouterService } from "./ai-connection-router.js"; +import { withManagedAiProbe, stripAiAuthBindings } from "./ai-connection-runtime.js"; +import { environmentService } from "./environments.js"; +import { secretService } from "./secrets.js"; +import { dotRunnerBroker } from "./dot-runner-broker.js"; +import type { PluginWorkerManager } from "./plugin-worker-manager.js"; +import type { LifecycleAgent } from "../modules/agent-lifecycle/index.js"; + +export function assertHarnessTestPassed(result: AdapterEnvironmentTestResult) { + const verified = result.checks.some(check => check.level === "info" && + (/hello_probe_(passed|succeeded)$/.test(check.code) || check.code === "ai_connection_api_key_reverified")); + const authenticationFailed = result.checks.some(check => + check.code === ADAPTER_AUTH_MISSING_CHECK_CODE || /_hello_probe_auth_required$/.test(check.code)); + const incomplete = !verified && (result.status === "warn" || result.checks.some(check => check.code.includes("hello_probe"))); + if (result.status === "fail" || authenticationFailed || incomplete) throw Object.assign(new Error("The harness test failed"), { code: "harness_test_failed" }); +} + +export function agentHarnessVerificationService(db: Db, manager: PluginWorkerManager) { + const tests = agentEnvironmentTestService(db, manager); + const secrets = secretService(db); + const environments = environmentService(db); + async function verify(snapshot: LifecycleAgent): Promise<"complete" | "pending"> { + const [agent] = await db.select().from(agents).where(and(eq(agents.id, snapshot.id), eq(agents.lifecycleVersion, snapshot.lifecycleVersion))); + if (!agent) return "pending"; + if (agent.adapterType === "paperclip_runner" && agent.adapterConfig.provider === "openai_dot") { + const binding = await dotRunnerBroker(db).bindingForAgent(agent.companyId, agent.id); + return binding?.status === "ready" && binding.subscriptionVerified && binding.id === agent.adapterConfig.dotBindingId ? "complete" : "pending"; + } + const [company] = await db.select().from(companies).where(eq(companies.id, agent.companyId)); + const responsibleUserId = agent.lifecycleOperation?.responsibleUserId ?? company.defaultResponsibleUserId; + const context = { consumerType: "agent" as const, consumerId: agent.id, actorType: "system" as const, + actorId: "agent-lifecycle", responsibleUserId }; + let binding = agent.runtimeConfig.aiConnection ? aiRuntimeConnectionBindingSchema.parse(agent.runtimeConfig.aiConnection) : undefined; + let config = agent.adapterConfig; + if (binding?.mode === "router") { + const selected = await aiConnectionRouterService(db, manager).resolve({ companyId: agent.companyId, + poolId: binding.connectionId, agentId: agent.id, userId: responsibleUserId, + adapterType: agent.adapterType, taskKey: `lifecycle:${agent.lifecycleOperation!.id}` }); + binding = selected.binding; + config = { ...config, ...selected.runtimeConfig }; + } + if (binding) config = { ...config, env: stripAiAuthBindings(config.env) }; + config = (await secrets.resolveAdapterConfigForRuntime(agent.companyId, config, context, { adapterType: agent.adapterType })).config; + const environmentId = await tests.resolveAdapterTestEnvironmentId(agent.companyId, agent.defaultEnvironmentId); + if (environmentId) { + await tests.assertAdapterTestEnvironmentForCompany(agent.companyId, environmentId); + const environment = await environments.getById(environmentId); + const env = Object.fromEntries(Object.entries(binding ? stripAiAuthBindings(environment?.envVars) : parseObject(environment?.envVars)) + .filter(([key]) => !isForbiddenConfigEnvKey(key))); + const resolved = await secrets.resolveEnvBindings(agent.companyId, env, + { ...context, consumerType: "environment", consumerId: environmentId }); + config = { ...config, env: { ...resolved.env, ...parseObject(config.env) } }; + } + const target = await tests.resolveAdapterTestExecutionContext({ agentId: agent.id, companyId: agent.companyId, adapterType: agent.adapterType, environmentId }); + let status: "released" | "failed" = "failed"; + try { + if (target.fallbackChecks.length) throw Object.assign(new Error("The test environment is unavailable"), { code: "test_environment_unavailable" }); + const input = { companyId: agent.companyId, adapterType: agent.adapterType, config, + executionTarget: target.executionTarget, environmentName: target.environmentName }; + const result = binding ? await withManagedAiProbe(db, { ...input, agentId: agent.id, responsibleUserId, binding }, + managed => tests.testManagedEnvironment(agent.adapterType, { ...input, config: managed.config }, binding!, managed, agent.id)) + : await requireServerAdapter(agent.adapterType).testEnvironment(input); + assertHarnessTestPassed(result); + status = "released"; + return "complete"; + } finally { await target.release(status); } + } + return { verify }; +} diff --git a/server/src/services/agent-hiring.ts b/server/src/services/agent-hiring.ts new file mode 100644 index 00000000000..c35299352ee --- /dev/null +++ b/server/src/services/agent-hiring.ts @@ -0,0 +1,135 @@ +import { agentAppearanceSchema, randomAgentAppearance } from "@paperclipai/shared"; +import { normalizePaperclipRunnerAdapterConfig } from "@paperclipai/adapter-utils/server-utils"; +import { agents, toolConnectionInstalls, principalPermissionGrants, type Db } from "@paperclipai/db"; +import { eq } from "drizzle-orm"; +import { unprocessable } from "../errors.js"; +import { agentRecordQueries, isPlainRecord, configPatchFromApprovalPayload, normalizeRuntimeConfigForNewAgent, + deduplicateAgentName, type CreateAgentData, type CreateAgentOptions, type AgentConfigurationPatch, type AgentHireRecord } from "../lib/agent-records.js"; +import { normalizeAgentPermissions, permissionsImplyLowTrust, NEW_STANDARD_AGENT_DEFAULT_GRANT_KEYS, + newStandardAgentGrantScope } from "../lib/agent-permissions.js"; +import { readBuiltInAgentMarker } from "../lib/built-in-agent-metadata.js"; +import { secretService, assertClaudeOAuthBindingInvariant } from "./secrets.js"; +import { agentCredentialService } from "./agent-credentials.js"; +import { agentIdentityService } from "./agent-identity.js"; +import { initializePrimaryAgent } from "./primary-agent.js"; + +export async function prepareAgentHire(db: Db, companyId: string, data: CreateAgentData, options?: CreateAgentOptions): Promise { + const { ensureManager, assertBuiltInAgentMetadataMutationAllowed } = agentRecordQueries(db); + if (data.appearance?.customAvatarAssetId) throw unprocessable("Create the agent before uploading its avatar"); + assertBuiltInAgentMetadataMutationAllowed(null, data.metadata, options); + if (data.reportsTo) { + await ensureManager(companyId, data.reportsTo); + } + + const existingAgents = await db + .select({ id: agents.id, name: agents.name, status: agents.status }) + .from(agents) + .where(eq(agents.companyId, companyId)); + const uniqueName = deduplicateAgentName(data.name, existingAgents); + + const role = data.role ?? "general"; + const normalizedPermissions = normalizeAgentPermissions(data.permissions, { context: "create" }); + const runtimeConfig = normalizeRuntimeConfigForNewAgent(data.runtimeConfig); + const adapterType = data.adapterType ?? "process"; + const rawAdapterConfig = isPlainRecord(data.adapterConfig) + ? await secretService(db).normalizeAdapterConfigForPersistence(companyId, data.adapterConfig, { adapterType }) + : {}; + const adapterConfig = normalizePaperclipRunnerAdapterConfig(adapterType, rawAdapterConfig); + await agentCredentialService(db).enforceClaudeOAuthBindingClaim(db, { + companyId, consume: true, environmentId: data.defaultEnvironmentId ?? null, + childAdapterConfig: adapterConfig, claudeLogin: options?.claudeLogin, + decision: assertClaudeOAuthBindingInvariant({ adapterType, nextConfig: adapterConfig }), + }); + return { ...data, name: uniqueName, + appearance: data.appearance == null ? randomAgentAppearance() : agentAppearanceSchema.parse(data.appearance), + role, adapterType, adapterConfig, permissions: normalizedPermissions, runtimeConfig }; +} + +export async function initializeAgentHire(txDb: Db, created: AgentHireRecord, options?: CreateAgentOptions) { + const tx = txDb; + const companyId = created.companyId; + await agentIdentityService(txDb).ensureAgentIdentity(companyId, created.id); + // New standard agents receive the standard direct grants at activation. + // Low-trust and bundled agents keep their explicit, narrower grants. + if (created.status !== "pending_approval" && !permissionsImplyLowTrust(created.permissions) && + !readBuiltInAgentMarker(created.metadata)) { + await tx.insert(principalPermissionGrants).values( + NEW_STANDARD_AGENT_DEFAULT_GRANT_KEYS.map((permissionKey) => ({ + companyId, + principalType: "agent" as const, + principalId: created.id, + permissionKey, + scope: newStandardAgentGrantScope(permissionKey, created.id), + })), + ).onConflictDoNothing(); + } + if (options?.aiConnectionInstall) { + const install = options.aiConnectionInstall; + const connectionIds = [...new Set([install.connectionId, ...(install.memberConnectionIds ?? [])])]; + await tx.insert(toolConnectionInstalls).values(connectionIds.map(connectionId => ({ + companyId, connectionId, + targetType: "agent" as const, targetId: created.id, + createdByUserId: install.createdByUserId, + }))).onConflictDoNothing(); + } + await agentCredentialService(txDb).syncAgentSecretBindings(created, txDb); + if (options?.createdByUserId && !readBuiltInAgentMarker(created.metadata)) { + await initializePrimaryAgent(txDb, companyId, options.createdByUserId, created.id); + } +} + +export async function prepareAgentHireApproval(txDb: Db, existing: AgentHireRecord, approvedPayload?: Record | null): Promise { + const approvedPatch = approvedPayload ? configPatchFromApprovalPayload(approvedPayload) : {}; + const patch = { ...approvedPatch } as AgentConfigurationPatch; + const hasApprovedAdapterConfig = Object.prototype.hasOwnProperty.call(patch, "adapterConfig") && isPlainRecord(patch.adapterConfig); + if ( + Object.prototype.hasOwnProperty.call(patch, "adapterConfig") && + isPlainRecord(patch.adapterConfig) + ) { + const normalizedAdapterConfig = await secretService(txDb).normalizeAdapterConfigForPersistence( + existing.companyId, patch.adapterConfig, { adapterType: (patch.adapterType ?? existing.adapterType) as string }, + ); + patch.adapterConfig = normalizePaperclipRunnerAdapterConfig( + (patch.adapterType ?? existing.adapterType) as string, + normalizedAdapterConfig, + ); + } else if ( + Object.prototype.hasOwnProperty.call(patch, "adapterType") + && isPlainRecord(existing.adapterConfig) + ) { + patch.adapterConfig = normalizePaperclipRunnerAdapterConfig( + patch.adapterType as string, + existing.adapterConfig, + ); + } + if (patch.permissions !== undefined) { + // The pending-approval activation replays the original hire + // request, so the new-agent creation default applies. + patch.permissions = normalizeAgentPermissions(patch.permissions, { context: "create" }); + } + if (hasApprovedAdapterConfig) { + await agentCredentialService(txDb).enforceClaudeOAuthBindingClaim(txDb, { + companyId: existing.companyId, consume: false, environmentId: null, + childAdapterConfig: patch.adapterConfig, + decision: assertClaudeOAuthBindingInvariant({ adapterType: patch.adapterType ?? existing.adapterType, + nextConfig: patch.adapterConfig, priorConfig: existing.adapterConfig }), + }); + } + return patch; +} + +export async function completeAgentHireApproval(txDb: Db, updated: AgentHireRecord, existing: AgentHireRecord) { + const tx = txDb; + await agentCredentialService(txDb).syncAgentSecretBindings(updated, txDb, existing.adapterConfig); + if (!permissionsImplyLowTrust(updated.permissions) && !readBuiltInAgentMarker(updated.metadata)) { + await tx.insert(principalPermissionGrants).values( + NEW_STANDARD_AGENT_DEFAULT_GRANT_KEYS.map((permissionKey) => ({ + companyId: updated.companyId, + principalType: "agent" as const, + principalId: updated.id, + permissionKey, + scope: newStandardAgentGrantScope(permissionKey, updated.id), + })), + ).onConflictDoNothing(); + } +} diff --git a/server/src/services/agent-instruction-revisions.ts b/server/src/services/agent-instruction-revisions.ts index 6c07b0d08f8..8a60208e31d 100644 --- a/server/src/services/agent-instruction-revisions.ts +++ b/server/src/services/agent-instruction-revisions.ts @@ -1,3 +1,4 @@ +import { updateAgentConfigurationInTransaction } from "./agent-configuration-transaction.js"; import { createHash } from "node:crypto"; import { adoptAgentFiles, agentFileToken } from "./agent-file-store.js"; import { and, desc, eq, getTableColumns, lt, or, sql } from "drizzle-orm"; @@ -252,19 +253,15 @@ export function agentInstructionRevisionService(db: Db) { !state.agent.adapterConfig.instructionsBundleMode || (bound.type === "plugin" && configuredEntryFile !== input.entryFile) ) { - await tx - .update(agents) - .set({ - adapterConfig: { - ...state.agent.adapterConfig, - instructionsBundleMode: "managed", - instructionsRootPath: state.root, - instructionsEntryFile: state.entryFile, - instructionsFilePath: `${state.root}/${state.entryFile}`, - }, - updatedAt: new Date(), - }) - .where(eq(agents.id, state.agent.id)); + await updateAgentConfigurationInTransaction(tx as unknown as Db, state.agent.id, { + adapterConfig: { + ...state.agent.adapterConfig, + instructionsBundleMode: "managed", + instructionsRootPath: state.root, + instructionsEntryFile: state.entryFile, + instructionsFilePath: `${state.root}/${state.entryFile}`, + }, + }, { allowPendingApprovalConfigUpdate: true }); } }; // An exact replay can safely return the durable receipt even after its base diff --git a/server/src/services/agent-lifecycle-driver.ts b/server/src/services/agent-lifecycle-driver.ts new file mode 100644 index 00000000000..68cbea29999 --- /dev/null +++ b/server/src/services/agent-lifecycle-driver.ts @@ -0,0 +1,47 @@ +import { and, eq, inArray } from "drizzle-orm"; +import { agents, plugins, pluginCompanySettings, type Db } from "@paperclipai/db"; +import { heartbeatService } from "./heartbeat.js"; +import { listInvalidOrgChainDescendantIds } from "./agent-invokability.js"; +import type { PluginWorkerManager } from "./plugin-worker-manager.js"; +import type { LifecycleDriver } from "../modules/agent-lifecycle/index.js"; +import { agentHarnessVerificationService } from "./agent-harness-verification.js"; + +export function createLifecycleDriver(db: Db, manager: PluginWorkerManager): LifecycleDriver { + const { verify } = agentHarnessVerificationService(db, manager); + const heartbeat = heartbeatService(db, { pluginWorkerManager: manager }); + return { + async requiredPluginIds(agent) { + if (agent.lifecycleRequiredPluginIds !== null) return agent.lifecycleRequiredPluginIds; + const installed = await db.select().from(plugins).where(inArray(plugins.status, ["ready", "error", "installed", "upgrade_pending"])); + const disabled = await db.select({ pluginId: pluginCompanySettings.pluginId }).from(pluginCompanySettings) + .where(and(eq(pluginCompanySettings.companyId, agent.companyId), eq(pluginCompanySettings.enabled, false))); + return installed.filter(plugin => !disabled.some(row => row.pluginId === plugin.id) && + plugin.manifestJson.agentLifecycle && plugin.manifestJson.capabilities.includes("agents.lifecycle.manage")).map(plugin => plugin.id); + }, + async runPlugin(agent, pluginId) { + const [plugin] = await db.select().from(plugins).where(eq(plugins.id, pluginId)); + const [settings] = await db.select().from(pluginCompanySettings).where(and( + eq(pluginCompanySettings.pluginId, pluginId), eq(pluginCompanySettings.companyId, agent.companyId))); + if (settings?.enabled === false || !plugin || plugin.status !== "ready" || !plugin.manifestJson.agentLifecycle || !plugin.manifestJson.capabilities.includes("agents.lifecycle.manage")) { + throw Object.assign(new Error("A required lifecycle plugin is unavailable"), { code: "required_plugin_unavailable" }); + } + const operationId = agent.lifecycleOperation!.id; + const result = await manager.call(plugin.id, "agentLifecycle", { companyId: agent.companyId, + agentId: agent.id, operationId, version: agent.lifecycleVersion, phase: agent.lifecycleState }, 30_000); + if (!result || result.operationId !== operationId || result.version !== agent.lifecycleVersion || !["complete", "pending"].includes(result.status)) { + throw Object.assign(new Error("Invalid lifecycle result"), { code: "invalid_lifecycle_result" }); + } + return result.status; + }, + async runHost(agent) { + if (agent.lifecycleState === "verifying") return verify(agent); + if (["pausing", "terminating", "cleaning_up"].includes(agent.lifecycleState)) { + const companyAgents = await db.select().from(agents).where(eq(agents.companyId, agent.companyId)); + const ids = agent.lifecycleState === "pausing" ? [agent.id] + : [agent.id, ...listInvalidOrgChainDescendantIds(agent.id, companyAgents)]; + if (!await heartbeat.stopInvocationsForAgents(ids, "Agent lifecycle stop requested")) return "pending"; + } + return "complete"; + }, + }; +} diff --git a/server/src/services/agent-lifecycle.ts b/server/src/services/agent-lifecycle.ts new file mode 100644 index 00000000000..25ef5e58738 --- /dev/null +++ b/server/src/services/agent-lifecycle.ts @@ -0,0 +1,61 @@ +import { logger } from "../middleware/logger.js"; +import type { Db } from "@paperclipai/db"; +import * as lifecycle from "../modules/agent-lifecycle/index.js"; +import { withAccountingTransaction } from "./accounting-transaction.js"; +import { budgetServiceInTransaction, deliverBudgetEnforcement, policyBlocks, type BudgetServiceHooks } from "./budgets.js"; +import { recordAgentStatusEvent, recordResourceCreationEvent } from "./resource-lifecycle-events.js"; +import { clearPrimaryAgent } from "./primary-agent.js"; +import { deleteAgentDependencies } from "./agent-deletion.js"; +import { prepareAgentConfiguration, completeAgentConfiguration } from "./agent-configuration.js"; +import { prepareAgentHire, initializeAgentHire, prepareAgentHireApproval, completeAgentHireApproval } from "./agent-hiring.js"; +import { trackIdleWork } from "./task-admission.js"; + +export { scheduleAgentLifecycle } from "../modules/agent-lifecycle/index.js"; +export type { LifecycleDriver, LifecycleAgent } from "../modules/agent-lifecycle/index.js"; + +export function createAgentLifecycleEffects(hooks: BudgetServiceHooks = {}): lifecycle.LifecycleEffects { + return { + reportFailure(context, error) { + // Only known codes are safe; provider errors can contain credentials or private data. + const allowedCodes = new Set(["required_plugin_unavailable", "invalid_lifecycle_result", "harness_test_failed", + "test_environment_unavailable", "ECONNREFUSED", "ECONNRESET", "ETIMEDOUT", "40001", "40P01", "53300", "57P01"]); + const candidate = error as { code?: unknown; cause?: { code?: unknown } } | null; + const code = [candidate?.code, candidate?.cause?.code].find(value => typeof value === "string" && allowedCodes.has(value)); + logger.warn({ ...context, failureCode: code ?? "unclassified" }, "Agent lifecycle operation failed"); + }, + transaction: withAccountingTransaction, + deleteDependencies: deleteAgentDependencies, + policyBlocks, + setAgentBudget: (db, publications, companyId, agentId, amount, userId, isActive) => + budgetServiceInTransaction(db, publications).upsertPolicy(companyId, { + scopeType: "agent", scopeId: agentId, amount, isActive, windowKind: "calendar_month_utc", + }, userId), + enforceBudget: (db, companyId, agentId) => deliverBudgetEnforcement(db, hooks, companyId, agentId), + recordCreation: (db, companyId, agentId) => recordResourceCreationEvent(db, companyId, "agent", agentId), + recordStatus: recordAgentStatusEvent, + clearPrimary: clearPrimaryAgent, + prepareConfiguration: prepareAgentConfiguration, + completeConfiguration: completeAgentConfiguration, + prepareHire: prepareAgentHire, + initializeHire: initializeAgentHire, + prepareHireApproval: prepareAgentHireApproval, + completeHireApproval: completeAgentHireApproval, + }; +} + +export function createAgentLifecycle(db: Db, hooks: BudgetServiceHooks = {}) { + return lifecycle.createAgentLifecycle(db, createAgentLifecycleEffects(hooks)); +} + +function trackedDriver(driver: lifecycle.LifecycleDriver): lifecycle.LifecycleDriver { + return { ...driver, runHost: agent => trackIdleWork(driver.runHost(agent)), + runPlugin: (agent, pluginId) => trackIdleWork(driver.runPlugin(agent, pluginId)) }; +} + +export function configureAgentLifecycle(db: Db, driver: lifecycle.LifecycleDriver, canRun = () => true) { + return lifecycle.configureAgentLifecycle(db, createAgentLifecycleEffects(), trackedDriver(driver), canRun); +} + +export function startAgentLifecycle(db: Db, driver: lifecycle.LifecycleDriver, canRun: () => boolean) { + return lifecycle.startAgentLifecycle(db, createAgentLifecycleEffects(), trackedDriver(driver), canRun); +} diff --git a/server/src/services/agent-profile-avatar.ts b/server/src/services/agent-profile-avatar.ts index 64d0b7d3d9c..24b5f68c7d3 100644 --- a/server/src/services/agent-profile-avatar.ts +++ b/server/src/services/agent-profile-avatar.ts @@ -1,3 +1,4 @@ +import { updateAgentConfigurationInTransaction } from "./agent-configuration-transaction.js"; import { createHash } from "node:crypto"; import { and, eq } from "drizzle-orm"; import sharp from "sharp"; @@ -5,7 +6,6 @@ import { agents, assets, companies, type Db } from "@paperclipai/db"; import { MAX_AGENT_AVATAR_BYTES, resolveAgentAppearance, agentAvatarUrl, setAgentAvatarSchema, type SetAgentAvatarInput } from "@paperclipai/shared"; import { conflict, notFound, unprocessable } from "../errors.js"; import type { StorageService } from "../storage/types.js"; -import { agentService } from "./agents.js"; import { logActivity, publishActivity, type ActivityPublication, type LogActivityInput } from "./activity-log.js"; /** Decode and re-encode: exclude SVG, animation, metadata and unbounded pixel counts. No URL fetching. */ @@ -60,7 +60,7 @@ export async function setAgentProfileAvatar(db: Db, storage: StorageService, com createdByUserId: actor.actorType === "user" ? actor.actorId : null }).returning(); appearance.customAvatarAssetId = asset!.id; } - await agentService(txDb).update(agentId, { appearance }, { recordRevision: { + await updateAgentConfigurationInTransaction(txDb, agentId, { appearance }, { recordRevision: { createdByAgentId: actor.agentId, createdByUserId: actor.actorType === "user" ? actor.actorId : null, source: "avatar-upload", } }); await logActivity(txDb, { ...actor, companyId, action: "agent.avatar_updated", entityType: "agent", entityId: agentId, diff --git a/server/src/services/agents.ts b/server/src/services/agents.ts index 59e3a905123..d3bcaca2b11 100644 --- a/server/src/services/agents.ts +++ b/server/src/services/agents.ts @@ -1,911 +1,34 @@ -import { budgetServiceInTransaction, deliverBudgetEnforcement, type BudgetServiceHooks } from "./budgets.js"; -import { withAccountingTransaction } from "./accounting-transaction.js"; -import type { ActivityPublication } from "./activity-log.js"; -import { agentAppearanceSchema, randomAgentAppearance, resolveAgentAppearance, agentAvatarUrl } from "@paperclipai/shared"; -import { createHash, randomBytes } from "node:crypto"; -import { and, desc, eq, gte, inArray, lt, ne, or, sql } from "drizzle-orm"; +import { type BudgetServiceHooks } from "./budgets.js"; + +import { and, desc, eq, inArray, ne } from "drizzle-orm"; import type { Db } from "@paperclipai/db"; -import { - agents, - assets, - toolConnectionInstalls, - agentConfigRevisions, - agentApiKeys, - agentRuntimeState, - agentTaskSessions, - agentWakeupRequests, - activityLog, - costEvents, - budgetReservations, - heartbeatRunEvents, - heartbeatRuns, - issueExecutionDecisions, - issues, - issueComments, - principalPermissionGrants, -} from "@paperclipai/db"; -import { - AGENT_DEFAULT_MAX_CONCURRENT_RUNS, - agentRuntimeConfigSchema, - getAgentWorkEligibility, - isUuidLike, - normalizeAgentApiKeyScope, - normalizeAgentUrlKey, - type AgentEligibilityAgent, - type AgentApiKeyScope, -} from "@paperclipai/shared"; -import { - normalizePaperclipRunnerAdapterConfig, -} from "@paperclipai/adapter-utils/server-utils"; +import { agents, agentConfigRevisions, agentApiKeys, heartbeatRuns } from "@paperclipai/db"; +import { isUuidLike, normalizeAgentApiKeyScope, normalizeAgentUrlKey, type AgentApiKeyScope } from "@paperclipai/shared"; + import { conflict, notFound, unprocessable } from "../errors.js"; + +import { normalizeAgentPermissions } from "../lib/agent-permissions.js"; + import { - collectSecretRefs, - collectUserSecretRefs, - syncAgentAdapterEnvBindings, -} from "./agent-secret-bindings.js"; -import { logActivity } from "./activity-log.js"; -import { NEW_STANDARD_AGENT_DEFAULT_GRANT_KEYS, newStandardAgentGrantScope, normalizeAgentPermissions, permissionsImplyLowTrust } from "./agent-permissions.js"; -import { recordAgentStatusEvent, recordResourceCreationEvent } from "./resource-lifecycle-events.js"; -import { REDACTED_EVENT_VALUE, sanitizeRecord } from "../redaction.js"; -import { - assertClaudeOAuthBindingInvariant, - claudeOAuthBindingsMatchExactly, - claudeOAuthClaimRejectedError, - CLAUDE_LOCAL_ADAPTER_TYPE, - readClaudeOAuthBinding, - secretService, - type ClaudeOAuthBindingInvariantDecision, -} from "./secrets.js"; -import { createDbSetupTokenCleanupStore } from "./setup-token-session.js"; -import { - builtInAgentMarkersEqual, - readBuiltInAgentMarker, -} from "./built-in-agent-metadata.js"; -import { issueThreadInteractionService } from "./issue-thread-interactions.js"; + agentRecordQueries, + hashToken, + createToken, + containsRedactedMarker, + configPatchFromSnapshot, +} from "../lib/agent-records.js"; +import { createAgentLifecycle } from "./agent-lifecycle.js"; -import { clearPrimaryAgent, initializePrimaryAgent } from "./primary-agent.js"; -import { agentIdentityService } from "./agent-identity.js"; - -function hashToken(token: string) { - return createHash("sha256").update(token).digest("hex"); -} - -function createToken() { - return `pcp_${randomBytes(24).toString("hex")}`; -} - -const CONFIG_REVISION_FIELDS = [ - "name", - "role", - "title", - "icon", - "appearance", - "reportsTo", - "capabilities", - "adapterType", - "adapterConfig", - "runtimeConfig", - "defaultEnvironmentId", - "budgetMonthlyCents", - "metadata", -] as const; - -type ConfigRevisionField = (typeof CONFIG_REVISION_FIELDS)[number]; -type AgentConfigSnapshot = Pick; - -interface RevisionMetadata { - createdByAgentId?: string | null; - createdByUserId?: string | null; - source?: string; - rolledBackFromRevisionId?: string | null; -} - -/** - * The Claude login context for an agent write. The route derives the owner user - * from the authenticated actor, not from the request body, and forwards the - * non-secret `storedSessionId` claim from a completed Claude login session. A - * controlled internal override permits a migration or an administrator repair to - * bind or unbind the fixed OAuth token without a claim. - * - * The `applyExistingWithoutClaim` field is the user-actor apply-existing path. - * The route sets it only for an authenticated user actor and derives the owner - * from that actor. The path binds the fixed reference to the owner stored value - * with no login round trip. It is distinct from `allowInternalBindingOverride`, - * which does no ownership check. - * - * The `inheritedFromAgentId` field is the hire-inheritance path. The route - * sets it only for an authenticated agent actor whose hire request inherited - * the fixed reference from that named parent. The service re-reads the parent - * agent inside the write transaction and binds the fixed reference only when - * the parent exists, is in the same company, is a `claude_local` agent, and - * already holds the exact fixed binding. - */ -interface ClaudeLoginContext { - storedSessionId?: string | null; - ownerUserId?: string | null; - allowInternalBindingOverride?: boolean; - applyExistingWithoutClaim?: boolean; - inheritedFromAgentId?: string | null; -} - -interface UpdateAgentOptions { - recordRevision?: RevisionMetadata; - allowBuiltInAgentMetadata?: boolean; - allowPendingApprovalConfigUpdate?: boolean; - claudeLogin?: ClaudeLoginContext; -} - -interface CreateAgentOptions { - createdByUserId?: string | null; - aiConnectionInstall?: { connectionId: string; memberConnectionIds?: string[]; createdByUserId: string | null }; - allowBuiltInAgentMetadata?: boolean; - claudeLogin?: ClaudeLoginContext; -} - -interface AgentShortnameRow { - id: string; - name: string; - status: string; -} - -interface AgentShortnameCollisionOptions { - excludeAgentId?: string | null; -} - -function isPlainRecord(value: unknown): value is Record { - return typeof value === "object" && value !== null && !Array.isArray(value); -} - -function jsonEqual(left: unknown, right: unknown): boolean { - return JSON.stringify(left) === JSON.stringify(right); -} - -function buildConfigSnapshot( - row: Pick, -): AgentConfigSnapshot { - const adapterConfig = - typeof row.adapterConfig === "object" && row.adapterConfig !== null && !Array.isArray(row.adapterConfig) - ? sanitizeRecord(row.adapterConfig as Record) - : {}; - const runtimeConfig = - typeof row.runtimeConfig === "object" && row.runtimeConfig !== null && !Array.isArray(row.runtimeConfig) - ? sanitizeRecord(row.runtimeConfig as Record) - : {}; - const metadata = - typeof row.metadata === "object" && row.metadata !== null && !Array.isArray(row.metadata) - ? sanitizeRecord(row.metadata as Record) - : row.metadata ?? null; - return { - name: row.name, - role: row.role, - title: row.title, - icon: row.icon, - appearance: row.appearance, - reportsTo: row.reportsTo, - capabilities: row.capabilities, - adapterType: row.adapterType, - adapterConfig, - runtimeConfig, - defaultEnvironmentId: row.defaultEnvironmentId, - budgetMonthlyCents: row.budgetMonthlyCents, - metadata, - }; -} - -function containsRedactedMarker(value: unknown): boolean { - if (value === REDACTED_EVENT_VALUE) return true; - if (Array.isArray(value)) return value.some((item) => containsRedactedMarker(item)); - if (typeof value !== "object" || value === null) return false; - return Object.values(value as Record).some((entry) => containsRedactedMarker(entry)); -} - -function hasConfigPatchFields(data: Partial) { - return CONFIG_REVISION_FIELDS.some((field) => Object.prototype.hasOwnProperty.call(data, field)); -} - -function changedPendingApprovalConfigFields( - existing: typeof agents.$inferSelect, - data: Partial, -) { - return CONFIG_REVISION_FIELDS.filter((field) => - Object.prototype.hasOwnProperty.call(data, field) && !jsonEqual(data[field], existing[field]), - ); -} - -function configPatchFromApprovalPayload(payload: Record) { - const patch: Partial = {}; - if (typeof payload.name === "string") patch.name = payload.name; - if (typeof payload.role === "string") patch.role = payload.role; - if (payload.appearance != null) patch.appearance = agentAppearanceSchema.parse(payload.appearance); - if (Object.prototype.hasOwnProperty.call(payload, "title")) { - patch.title = typeof payload.title === "string" ? payload.title : null; - } - if (Object.prototype.hasOwnProperty.call(payload, "icon")) { - patch.icon = typeof payload.icon === "string" ? payload.icon : null; - } - if (Object.prototype.hasOwnProperty.call(payload, "reportsTo")) { - patch.reportsTo = typeof payload.reportsTo === "string" ? payload.reportsTo : null; - } - if (Object.prototype.hasOwnProperty.call(payload, "capabilities")) { - patch.capabilities = typeof payload.capabilities === "string" ? payload.capabilities : null; - } - if (typeof payload.adapterType === "string") patch.adapterType = payload.adapterType; - if (isPlainRecord(payload.adapterConfig)) patch.adapterConfig = payload.adapterConfig; - if (isPlainRecord(payload.runtimeConfig)) patch.runtimeConfig = payload.runtimeConfig; - if (Object.prototype.hasOwnProperty.call(payload, "defaultEnvironmentId")) { - patch.defaultEnvironmentId = - typeof payload.defaultEnvironmentId === "string" ? payload.defaultEnvironmentId : null; - } - if (typeof payload.budgetMonthlyCents === "number") { - patch.budgetMonthlyCents = payload.budgetMonthlyCents; - } - if (Object.prototype.hasOwnProperty.call(payload, "metadata")) { - patch.metadata = isPlainRecord(payload.metadata) ? payload.metadata : null; - } - if (isPlainRecord(payload.permissions)) { - patch.permissions = payload.permissions; - } - return patch; -} - -function parseFiniteNumberLike(value: unknown): number | null { - if (typeof value === "number" && Number.isFinite(value)) return value; - if (typeof value !== "string") return null; - const parsed = Number(value.trim()); - return Number.isFinite(parsed) ? parsed : null; -} - -function normalizeRuntimeConfigForNewAgent(runtimeConfig: unknown): Record { - const normalizedRuntimeConfig = isPlainRecord(runtimeConfig) ? { ...runtimeConfig } : {}; - const heartbeat = isPlainRecord(normalizedRuntimeConfig.heartbeat) - ? { ...normalizedRuntimeConfig.heartbeat } - : {}; - if (parseFiniteNumberLike(heartbeat.maxConcurrentRuns) == null) { - heartbeat.maxConcurrentRuns = AGENT_DEFAULT_MAX_CONCURRENT_RUNS; - } - normalizedRuntimeConfig.heartbeat = heartbeat; - return normalizedRuntimeConfig; -} - -function diffConfigSnapshot( - before: AgentConfigSnapshot, - after: AgentConfigSnapshot, -): string[] { - return CONFIG_REVISION_FIELDS.filter((field) => !jsonEqual(before[field], after[field])); -} - -function configPatchFromSnapshot(snapshot: unknown): Partial { - if (!isPlainRecord(snapshot)) throw unprocessable("Invalid revision snapshot"); - - if (typeof snapshot.name !== "string" || snapshot.name.length === 0) { - throw unprocessable("Invalid revision snapshot: name"); - } - if (typeof snapshot.role !== "string" || snapshot.role.length === 0) { - throw unprocessable("Invalid revision snapshot: role"); - } - if (typeof snapshot.adapterType !== "string" || snapshot.adapterType.length === 0) { - throw unprocessable("Invalid revision snapshot: adapterType"); - } - if (typeof snapshot.budgetMonthlyCents !== "number" || !Number.isFinite(snapshot.budgetMonthlyCents)) { - throw unprocessable("Invalid revision snapshot: budgetMonthlyCents"); - } - const runtimeConfig = agentRuntimeConfigSchema.safeParse( - isPlainRecord(snapshot.runtimeConfig) ? snapshot.runtimeConfig : {}, - ); - if (!runtimeConfig.success) { - throw unprocessable("Invalid revision snapshot: runtimeConfig"); - } - - return { - name: snapshot.name, - role: snapshot.role, - title: typeof snapshot.title === "string" || snapshot.title === null ? snapshot.title : null, - reportsTo: - typeof snapshot.reportsTo === "string" || snapshot.reportsTo === null ? snapshot.reportsTo : null, - capabilities: - typeof snapshot.capabilities === "string" || snapshot.capabilities === null - ? snapshot.capabilities - : null, - adapterType: snapshot.adapterType, - adapterConfig: isPlainRecord(snapshot.adapterConfig) ? snapshot.adapterConfig : {}, - runtimeConfig: runtimeConfig.data, - defaultEnvironmentId: - typeof snapshot.defaultEnvironmentId === "string" || snapshot.defaultEnvironmentId === null - ? snapshot.defaultEnvironmentId - : null, - budgetMonthlyCents: Math.max(0, Math.floor(snapshot.budgetMonthlyCents)), - metadata: isPlainRecord(snapshot.metadata) || snapshot.metadata === null ? snapshot.metadata : null, - }; -} - -export function hasAgentShortnameCollision( - candidateName: string, - existingAgents: AgentShortnameRow[], - options?: AgentShortnameCollisionOptions, -): boolean { - const candidateShortname = normalizeAgentUrlKey(candidateName); - if (!candidateShortname) return false; - - return existingAgents.some((agent) => { - if (agent.status === "terminated") return false; - if (options?.excludeAgentId && agent.id === options.excludeAgentId) return false; - return normalizeAgentUrlKey(agent.name) === candidateShortname; - }); -} - -export function deduplicateAgentName( - candidateName: string, - existingAgents: AgentShortnameRow[], -): string { - if (!hasAgentShortnameCollision(candidateName, existingAgents)) { - return candidateName; - } - for (let i = 2; i <= 100; i++) { - const suffixed = `${candidateName} ${i}`; - if (!hasAgentShortnameCollision(suffixed, existingAgents)) { - return suffixed; - } - } - return `${candidateName} ${Date.now()}`; -} +export { hasAgentShortnameCollision, deduplicateAgentName } from "../lib/agent-records.js"; export function agentService(db: Db, budgetHooks: BudgetServiceHooks = {}) { - const secretsSvc = secretService(db); - - function currentUtcMonthWindow(now = new Date()) { - const year = now.getUTCFullYear(); - const month = now.getUTCMonth(); - return { - start: new Date(Date.UTC(year, month, 1, 0, 0, 0, 0)), - end: new Date(Date.UTC(year, month + 1, 1, 0, 0, 0, 0)), - }; - } - - function withUrlKey(row: T) { - return { - ...row, - urlKey: normalizeAgentUrlKey(row.name) ?? row.id, - }; - } - - function normalizeAgentBaseRow(row: typeof agents.$inferSelect) { - return withUrlKey({ - ...row, - permissions: normalizeAgentPermissions(row.permissions), - }); - } - - function toEligibilityAgent(row: Pick): AgentEligibilityAgent { - return { - id: row.id, - companyId: row.companyId, - name: row.name, - status: row.status, - reportsTo: row.reportsTo, - }; - } - - function normalizeAgentRows(rows: (typeof agents.$inferSelect)[], allCompanyRows = rows) { - const eligibilityAgents = allCompanyRows.map(toEligibilityAgent); - return rows.map((row) => { - const base = normalizeAgentBaseRow(row); - const appearance = resolveAgentAppearance(row.appearance, row.id); - return { - ...base, - appearance, - avatarUrl: agentAvatarUrl(appearance), - orgChainHealth: getAgentWorkEligibility({ - agent: toEligibilityAgent(row), - agents: eligibilityAgents, - }).orgChainHealth, - }; - }); - } - - function normalizeAgentRow(row: typeof agents.$inferSelect, allCompanyRows?: (typeof agents.$inferSelect)[]) { - return normalizeAgentRows([row], allCompanyRows)[0]!; - } - - async function listCompanyAgentRows(companyId: string) { - return db.select().from(agents).where(eq(agents.companyId, companyId)); - } - - async function getMonthlySpendByAgentIds(companyId: string, agentIds: string[]) { - if (agentIds.length === 0) return new Map(); - const { start, end } = currentUtcMonthWindow(); - const rows = await db - .select({ - agentId: costEvents.agentId, - spentMonthlyCents: sql`coalesce(sum(${costEvents.costCents}), 0)::double precision`, - }) - .from(costEvents) - .where( - and( - eq(costEvents.companyId, companyId), - inArray(costEvents.agentId, agentIds), - gte(costEvents.occurredAt, start), - lt(costEvents.occurredAt, end), - ), - ) - .groupBy(costEvents.agentId); - return new Map(rows.map((row) => [row.agentId, Number(row.spentMonthlyCents ?? 0)])); - } - - async function hydrateAgentSpend(rows: T[]) { - const agentIds = rows.map((row) => row.id); - const companyId = rows[0]?.companyId; - if (!companyId || agentIds.length === 0) return rows; - const spendByAgentId = await getMonthlySpendByAgentIds(companyId, agentIds); - return rows.map((row) => ({ - ...row, - spentMonthlyCents: spendByAgentId.get(row.id) ?? 0, - })); - } - - async function getById(id: string) { - const row = await db - .select() - .from(agents) - .where(eq(agents.id, id)) - .then((rows) => rows[0] ?? null); - if (!row) return null; - const [companyRows, hydrated] = await Promise.all([ - listCompanyAgentRows(row.companyId), - hydrateAgentSpend([row]).then((rows) => rows[0]!), - ]); - return normalizeAgentRow(hydrated, companyRows); - } - - async function requireGetById(id: string) { - const agent = await getById(id); - if (!agent) throw notFound("Agent not found"); - return agent; - } - - async function ensureManager(companyId: string, managerId: string) { - const manager = await getById(managerId); - if (!manager) throw notFound("Manager not found"); - if (manager.companyId !== companyId) { - throw unprocessable("Manager must belong to same company"); - } - return manager; - } - - async function assertNoCycle(agentId: string, reportsTo: string | null | undefined) { - if (!reportsTo) return; - if (reportsTo === agentId) throw unprocessable("Agent cannot report to itself"); - - let cursor: string | null = reportsTo; - while (cursor) { - if (cursor === agentId) throw unprocessable("Reporting relationship would create cycle"); - const next = await getById(cursor); - cursor = next?.reportsTo ?? null; - } - } - - async function assertCompanyShortnameAvailable( - companyId: string, - candidateName: string, - options?: AgentShortnameCollisionOptions, - ) { - const candidateShortname = normalizeAgentUrlKey(candidateName); - if (!candidateShortname) return; - - const existingAgents = await db - .select({ - id: agents.id, - name: agents.name, - status: agents.status, - }) - .from(agents) - .where(eq(agents.companyId, companyId)); - - const hasCollision = hasAgentShortnameCollision(candidateName, existingAgents, options); - if (hasCollision) { - throw conflict( - `Agent shortname '${candidateShortname}' is already in use in this company`, - ); - } - } - - async function syncAgentSecretBindings( - agent: { id: string; companyId: string; adapterConfig: unknown }, - dbClient: Db = db, - previousAdapterConfig: unknown = null, - actor: RevisionMetadata = {}, - ) { - const scopedSecretsSvc = dbClient === db ? secretsSvc : secretService(dbClient); - await syncAgentAdapterEnvBindings({ - secretsSvc: scopedSecretsSvc, - companyId: agent.companyId, - agentId: agent.id, - adapterConfig: agent.adapterConfig, - }); - const previousRefs = new Set([ - ...collectSecretRefs(previousAdapterConfig).map((ref) => `secret:${ref.secretId}:${ref.configPath}`), - ...collectUserSecretRefs(previousAdapterConfig).map((ref) => `user:${ref.definitionKey}:${ref.configPath}`), - ]); - const createdRefs = [ - ...collectSecretRefs(agent.adapterConfig).map((ref) => ({ - key: `secret:${ref.secretId}:${ref.configPath}`, - configPath: ref.configPath, - bindingType: "secret_ref", - secretId: ref.secretId, - definitionKey: null, - })), - ...collectUserSecretRefs(agent.adapterConfig).map((ref) => ({ - key: `user:${ref.definitionKey}:${ref.configPath}`, - configPath: ref.configPath, - bindingType: "user_secret_ref", - secretId: null, - definitionKey: ref.definitionKey, - })), - ].filter((ref) => !previousRefs.has(ref.key)); - const actorType = actor.createdByUserId ? "user" as const : actor.createdByAgentId ? "agent" as const : "system" as const; - const actorId = actor.createdByUserId ?? actor.createdByAgentId ?? "system"; - for (const ref of createdRefs) { - await logActivity(dbClient, { - companyId: agent.companyId, - actorType, - actorId, - agentId: actor.createdByAgentId ?? null, - action: "secret.binding.created", - entityType: "agent", - entityId: agent.id, - details: { - targetType: "agent", - targetId: agent.id, - configPath: ref.configPath, - bindingType: ref.bindingType, - secretId: ref.secretId, - definitionKey: ref.definitionKey, - }, - }); - } - } - - /** - * Enforces the Claude OAuth binding claim inside a write transaction. It runs - * after {@link assertClaudeOAuthBindingInvariant} decided that the write - * introduces or keeps the fixed binding. - * - * When the write introduces the fixed binding: - * * A create or hire path (`consume: true`) consumes a stored-session claim - * with one conditional write. It builds the claim scope from the company, - * the owner user, the fixed adapter, the environment, and the - * `storedSessionId`. It inserts the binding only when the write returns one - * row; otherwise it raises the fixed claim error, which rolls back the - * whole transaction and inserts no binding. - * * An update, approval, or rollback path (`consume: false`) carries no - * claim, so it raises the same fixed claim error at once. - * - * The user-actor apply-existing path (`applyExistingWithoutClaim`) binds the - * fixed reference with no login round trip. The route sets the flag only for - * an authenticated user actor and derives the owner from that actor. The gate - * permits the no-claim bind only when the owner already has a stored value for - * the company. It reads the owner value status; it reads no token. A missing - * owner or a missing stored value raises the same fixed claim error, so the - * caller cannot tell the reasons apart. - * - * The hire-inheritance path (`inheritedFromAgentId`) binds the fixed - * reference with no login round trip and no stored owner value, because the - * owning user resolves per run, not from a value stored against this agent. - * The route copies the parent's reference onto the child before this - * transaction starts, so a concurrent version change on the parent can - * leave the child holding a stale version. The gate re-reads the named - * parent agent inside this transaction and permits the bind only when the - * parent exists, is in the same company, is a `claude_local` agent, and its - * current reference matches the child's copied reference exactly, including - * the version selector. The gate locks the parent row with `SELECT ... - * FOR UPDATE` before it reads the reference. The lock blocks a concurrent - * credential rotation on the same parent row until this transaction - * commits or rolls back, so the compare-and-bind check stays atomic with - * the parent's current state. The route derives the parent identifier - * from the authenticated agent actor, never from the request body, so the - * gate treats it as a claim to verify, not a trusted value. - * - * A controlled internal override skips the claim for a migration or an - * administrator repair. The function creates the fixed user-secret definition - * before the caller runs the declaration synchronization, so the synchronized - * declaration always references an existing definition. - */ - async function enforceClaudeOAuthBindingClaim( - txDb: Db, - input: { - companyId: string; - decision: ClaudeOAuthBindingInvariantDecision; - consume: boolean; - environmentId: string | null; - claudeLogin?: ClaudeLoginContext; - /** - * The adapter config the write is about to persist. The - * `inheritedFromAgentId` path reads the child's copied - * `CLAUDE_CODE_OAUTH_TOKEN` reference from it, to compare against the - * parent's current reference. - */ - childAdapterConfig?: unknown; - }, - ): Promise { - const ownerUserId = input.claudeLogin?.ownerUserId ?? null; - if (input.decision.introducesBinding && !input.claudeLogin?.allowInternalBindingOverride) { - if (input.claudeLogin?.applyExistingWithoutClaim) { - // The user-actor apply-existing path. The route derived the owner from - // the authenticated user actor. The gate binds the fixed reference only - // when that owner already has a stored value. It reads no token. - if (!ownerUserId) { - throw claudeOAuthClaimRejectedError(); - } - const stored = await secretService(txDb).readClaudeOAuthUserSecretStatus( - input.companyId, - ownerUserId, - ); - if (!stored) { - throw claudeOAuthClaimRejectedError(); - } - } else if (input.claudeLogin?.inheritedFromAgentId) { - // The hire-inheritance path. Re-read the named parent inside this - // transaction; a caller-supplied identifier never binds on its own. - // Compare the parent's current reference against the reference - // already copied onto the child, including the version selector, so - // a concurrent version change on the parent cannot leave the child - // bound to a stale version. - const parentId = input.claudeLogin.inheritedFromAgentId; - const parent = await txDb - .select({ - companyId: agents.companyId, - adapterType: agents.adapterType, - adapterConfig: agents.adapterConfig, - }) - .from(agents) - .where(eq(agents.id, parentId)) - .for("update") - .then((rows) => rows[0] ?? null); - const parentBinding = readClaudeOAuthBinding(parent?.adapterConfig ?? null); - const childBinding = readClaudeOAuthBinding(input.childAdapterConfig ?? null); - if ( - !parent || - parent.companyId !== input.companyId || - parent.adapterType !== CLAUDE_LOCAL_ADAPTER_TYPE || - !claudeOAuthBindingsMatchExactly(parentBinding, childBinding) - ) { - throw claudeOAuthClaimRejectedError(); - } - } else if (!input.consume) { - throw claudeOAuthClaimRejectedError(); - } else { - const consumed = await createDbSetupTokenCleanupStore(txDb).consumeStoredClaim({ - sessionId: input.claudeLogin?.storedSessionId ?? "", - companyId: input.companyId, - ownerUserId: ownerUserId ?? "", - adapterType: CLAUDE_LOCAL_ADAPTER_TYPE, - }); - if (!consumed) { - throw claudeOAuthClaimRejectedError(); - } - } - } - if (input.decision.introducesBinding || input.decision.keepsBinding) { - // Create the fixed definition before declaration synchronization. - await secretService(txDb).ensureClaudeOAuthUserSecretDefinition(input.companyId, { - userId: ownerUserId, - }); - } - } - - function assertBuiltInAgentMetadataMutationAllowed( - beforeMetadata: unknown, - afterMetadata: unknown, - options?: { allowBuiltInAgentMetadata?: boolean }, - ) { - if (options?.allowBuiltInAgentMetadata) return; - const beforeMarker = readBuiltInAgentMarker(beforeMetadata); - const afterMarker = readBuiltInAgentMarker(afterMetadata); - if (builtInAgentMarkersEqual(beforeMarker, afterMarker)) return; - throw conflict("Built-in agent marker is managed by Paperclip and cannot be edited directly", { - code: "built_in_agent_marker_readonly", - key: beforeMarker?.key ?? afterMarker?.key ?? null, - }); - } - - async function updateAgent( - id: string, - data: Partial, - options?: UpdateAgentOptions, - ) { - const existing = await getById(id); - if (!existing) return null; - - if (existing.status === "terminated" && data.status && data.status !== "terminated") { - throw conflict("Terminated agents cannot be resumed"); - } - if ( - existing.status === "pending_approval" && - data.status && - data.status !== "pending_approval" && - data.status !== "terminated" - ) { - throw conflict("Pending approval agents cannot be activated directly"); - } - if (existing.status === "pending_approval" && !options?.allowPendingApprovalConfigUpdate) { - const changedFields = changedPendingApprovalConfigFields(existing as typeof agents.$inferSelect, data); - if (changedFields.length > 0) { - throw conflict("Pending approval agent configuration cannot be changed before board approval", { - code: "pending_approval_agent_config_frozen", - agentId: id, - fields: changedFields, - }); - } - } - - if (data.reportsTo !== undefined) { - if (data.reportsTo) { - await ensureManager(existing.companyId, data.reportsTo); - } - await assertNoCycle(id, data.reportsTo); - } - - if (data.name !== undefined) { - const previousShortname = normalizeAgentUrlKey(existing.name); - const nextShortname = normalizeAgentUrlKey(data.name); - if (previousShortname !== nextShortname) { - await assertCompanyShortnameAvailable(existing.companyId, data.name, { excludeAgentId: id }); - } - } - - if (Object.prototype.hasOwnProperty.call(data, "metadata")) { - assertBuiltInAgentMetadataMutationAllowed(existing.metadata, data.metadata, options); - } - - if (data.appearance?.customAvatarAssetId) { - const [asset] = await db.select().from(assets).where(and( - eq(assets.id, data.appearance.customAvatarAssetId), eq(assets.companyId, existing.companyId), - eq(assets.createdByAgentId, id), - )); - if (!asset || asset.contentType !== "image/png" || !asset.objectKey.startsWith(`${existing.companyId}/agent-avatars/${id}/`)) { - throw unprocessable("Use the avatar upload endpoint to set this agent's image"); - } - } - const normalizedPatch = { ...data } as Partial; - if (data.permissions !== undefined) { - normalizedPatch.permissions = normalizeAgentPermissions(data.permissions); - } - if ( - Object.prototype.hasOwnProperty.call(normalizedPatch, "adapterConfig") && - isPlainRecord(normalizedPatch.adapterConfig) - ) { - const normalizedAdapterConfig = await secretsSvc.normalizeAdapterConfigForPersistence( - existing.companyId, - normalizedPatch.adapterConfig, - { adapterType: (normalizedPatch.adapterType ?? existing.adapterType) as string }, - ); - normalizedPatch.adapterConfig = normalizePaperclipRunnerAdapterConfig( - (normalizedPatch.adapterType ?? existing.adapterType) as string, - normalizedAdapterConfig, - ); - } else if ( - Object.prototype.hasOwnProperty.call(normalizedPatch, "adapterType") - && isPlainRecord(existing.adapterConfig) - ) { - normalizedPatch.adapterConfig = normalizePaperclipRunnerAdapterConfig( - normalizedPatch.adapterType as string, - existing.adapterConfig, - ); - } - // Run the server-enforced binding invariant when the patch touches the - // adapter config. The update, approval, and rollback paths keep an existing - // fixed binding but reject a newly introduced binding, because they carry no - // stored-session claim. - const bindingDecision = Object.prototype.hasOwnProperty.call(normalizedPatch, "adapterConfig") - ? assertClaudeOAuthBindingInvariant({ - adapterType: (normalizedPatch.adapterType ?? existing.adapterType) as string, - nextConfig: normalizedPatch.adapterConfig, - priorConfig: existing.adapterConfig, - }) - : null; - - const shouldRecordRevision = Boolean(options?.recordRevision) && hasConfigPatchFields(normalizedPatch); - const beforeConfig = shouldRecordRevision ? buildConfigSnapshot(existing) : null; - - type AgentUpdateResult = Awaited>; - const applyUpdate = async (txDb: Db, publications: ActivityPublication[] = []): Promise => { - const current = data.status !== undefined - ? await txDb.select().from(agents).where(eq(agents.id, id)).for("update").then(rows => rows[0] ?? null) - : existing; - if (!current) return null; - if (current.status === "terminated" && data.status && data.status !== "terminated") { - throw conflict("Terminated agents cannot be resumed"); - } - if (current.status === "pending_approval" && data.status && data.status !== "pending_approval" && data.status !== "terminated") { - throw conflict("Pending approval agents cannot be activated directly"); - } - const updated = await txDb - .update(agents) - .set({ ...normalizedPatch, updatedAt: new Date() }) - .where(eq(agents.id, id)) - .returning() - .then((rows) => rows[0] ?? null); - if (!updated) return null; - if (updated.status === "terminated") { - await clearPrimaryAgent(txDb, updated.companyId, id); - } - if (data.status !== undefined) { - await recordAgentStatusEvent(txDb, updated.companyId, id, current.status, updated.status); - } - - const priorAdapterConfig = isPlainRecord(existing.adapterConfig) ? existing.adapterConfig : {}; - const afterConfig = isPlainRecord(updated.adapterConfig) ? updated.adapterConfig : {}; - const changedExecution = updated.adapterType !== existing.adapterType - || (updated.adapterType === "paperclip_runner" && ["provider", "acpxAgent", "model"].some( - (key) => priorAdapterConfig[key] !== afterConfig[key], - )); - if (changedExecution) { - await txDb.delete(agentTaskSessions).where(and(eq(agentTaskSessions.companyId, existing.companyId), eq(agentTaskSessions.agentId, id))); - await txDb.update(agentRuntimeState).set({ adapterType: updated.adapterType, sessionId: null, stateJson: {}, updatedAt: new Date() }) - .where(and(eq(agentRuntimeState.companyId, existing.companyId), eq(agentRuntimeState.agentId, id))); - } - - if (Object.prototype.hasOwnProperty.call(normalizedPatch, "adapterConfig")) { - if (bindingDecision) { - await enforceClaudeOAuthBindingClaim(txDb, { - companyId: existing.companyId, - decision: bindingDecision, - consume: false, - environmentId: null, - claudeLogin: options?.claudeLogin, - }); - } - await syncAgentSecretBindings( - updated, - txDb, - existing.adapterConfig, - options?.recordRevision, - ); - } - - if (normalizedPatch.budgetMonthlyCents !== undefined) { - await budgetServiceInTransaction(txDb, publications).upsertPolicy(existing.companyId, { - scopeType: "agent", scopeId: id, amount: normalizedPatch.budgetMonthlyCents, isActive: normalizedPatch.budgetMonthlyCents > 0, windowKind: "calendar_month_utc", - }, options?.recordRevision?.createdByUserId ?? null); - } - const normalizedUpdated = await agentService(txDb).getById(updated.id); - if (!normalizedUpdated) { - throw notFound("Agent not found"); - } - - if (shouldRecordRevision && beforeConfig) { - const afterConfig = buildConfigSnapshot(normalizedUpdated); - const changedKeys = diffConfigSnapshot(beforeConfig, afterConfig); - if (changedKeys.length > 0) { - await txDb.insert(agentConfigRevisions).values({ - companyId: normalizedUpdated.companyId, - agentId: normalizedUpdated.id, - createdByAgentId: options?.recordRevision?.createdByAgentId ?? null, - createdByUserId: options?.recordRevision?.createdByUserId ?? null, - source: options?.recordRevision?.source ?? "patch", - rolledBackFromRevisionId: options?.recordRevision?.rolledBackFromRevisionId ?? null, - changedKeys, - beforeConfig: beforeConfig as unknown as Record, - afterConfig: afterConfig as unknown as Record, - }); - } - } - - return normalizedUpdated; - }; - - if (normalizedPatch.budgetMonthlyCents !== undefined) { - const result = await withAccountingTransaction(db, existing.companyId, applyUpdate); - await deliverBudgetEnforcement(db, budgetHooks, existing.companyId); - return result; - } - - const transaction = (db as unknown as { - transaction?: (callback: (tx: unknown) => Promise) => Promise; - }).transaction; - if (typeof transaction !== "function") return applyUpdate(db); - return transaction.call(db, async (tx) => applyUpdate(tx as unknown as Db)); - } - + const { + normalizeAgentRows, + listCompanyAgentRows, + hydrateAgentSpend, + getById + } = agentRecordQueries(db); + const updateAgent = (...args: Parameters["updateConfiguration"]>) => + createAgentLifecycle(db, budgetHooks).updateConfiguration(...args); return { list: async (companyId: string, options?: { includeTerminated?: boolean }) => { const conditions = [eq(agents.companyId, companyId)]; @@ -922,326 +45,6 @@ export function agentService(db: Db, budgetHooks: BudgetServiceHooks = {}) { getById, - create: async (companyId: string, data: Omit, options?: CreateAgentOptions) => { - if (data.appearance?.customAvatarAssetId) throw unprocessable("Create the agent before uploading its avatar"); - assertBuiltInAgentMetadataMutationAllowed(null, data.metadata, options); - if (data.reportsTo) { - await ensureManager(companyId, data.reportsTo); - } - - const existingAgents = await db - .select({ id: agents.id, name: agents.name, status: agents.status }) - .from(agents) - .where(eq(agents.companyId, companyId)); - const uniqueName = deduplicateAgentName(data.name, existingAgents); - - const role = data.role ?? "general"; - const normalizedPermissions = normalizeAgentPermissions(data.permissions, { context: "create" }); - const runtimeConfig = normalizeRuntimeConfigForNewAgent(data.runtimeConfig); - const adapterType = data.adapterType ?? "process"; - const rawAdapterConfig = isPlainRecord(data.adapterConfig) - ? await secretsSvc.normalizeAdapterConfigForPersistence(companyId, data.adapterConfig, { adapterType }) - : {}; - const adapterConfig = normalizePaperclipRunnerAdapterConfig(adapterType, rawAdapterConfig); - // Run the server-enforced binding invariant after generic normalization - // and before any database write. A create has no prior config. - const bindingDecision = assertClaudeOAuthBindingInvariant({ - adapterType, - nextConfig: adapterConfig, - priorConfig: null, - }); - return db.transaction(async (tx) => { - const txDb = tx as unknown as Db; - // Consume the stored-session claim and create the fixed definition inside - // the same transaction that inserts the binding. A rejected claim rolls - // back the whole transaction and inserts no binding. - await enforceClaudeOAuthBindingClaim(txDb, { - companyId, - decision: bindingDecision, - consume: true, - environmentId: (data.defaultEnvironmentId as string | null | undefined) ?? null, - claudeLogin: options?.claudeLogin, - childAdapterConfig: adapterConfig, - }); - const created = await tx - .insert(agents) - .values({ - ...data, - name: uniqueName, - appearance: data.appearance == null ? randomAgentAppearance() : agentAppearanceSchema.parse(data.appearance), - companyId, - role, - adapterType, - adapterConfig, - permissions: normalizedPermissions, - runtimeConfig, - }) - .returning() - .then((rows) => rows[0]); - await agentIdentityService(txDb).ensureAgentIdentity(companyId, created.id); - // New standard agents receive the standard direct grants at activation. - // Low-trust and bundled agents keep their explicit, narrower grants. - if (created.status !== "pending_approval" && !permissionsImplyLowTrust(normalizedPermissions) && - !readBuiltInAgentMarker(created.metadata)) { - await tx.insert(principalPermissionGrants).values( - NEW_STANDARD_AGENT_DEFAULT_GRANT_KEYS.map((permissionKey) => ({ - companyId, - principalType: "agent" as const, - principalId: created.id, - permissionKey, - scope: newStandardAgentGrantScope(permissionKey, created.id), - })), - ).onConflictDoNothing(); - } - if (options?.aiConnectionInstall) { - const install = options.aiConnectionInstall; - const connectionIds = [...new Set([install.connectionId, ...(install.memberConnectionIds ?? [])])]; - await tx.insert(toolConnectionInstalls).values(connectionIds.map(connectionId => ({ - companyId, connectionId, - targetType: "agent" as const, targetId: created.id, - createdByUserId: install.createdByUserId, - }))).onConflictDoNothing(); - } - await syncAgentSecretBindings(created, txDb); - if (options?.createdByUserId && !readBuiltInAgentMarker(created.metadata)) { - await initializePrimaryAgent(txDb, companyId, options.createdByUserId, created.id); - } - if (created.status !== "pending_approval" && created.status !== "terminated") { - await recordResourceCreationEvent(txDb, companyId, "agent", created.id); - } - const normalizedCreated = await agentService(txDb).getById(created.id); - if (!normalizedCreated) { - throw notFound("Agent not found"); - } - return normalizedCreated; - }); - }, - - update: updateAgent, - - pause: async (id: string, reason: "manual" | "budget" | "system" = "manual") => { - const existing = await getById(id); - if (!existing) return null; - if (existing.status === "terminated") throw conflict("Cannot pause terminated agent"); - - return updateAgent(id, { - status: "paused", - pauseReason: reason, - pausedAt: new Date(), - errorReason: null, - }); - }, - - resume: async (id: string) => { - const existing = await getById(id); - if (!existing) return null; - if (existing.status === "terminated") throw conflict("Cannot resume terminated agent"); - if (existing.status === "pending_approval") { - throw conflict("Pending approval agents cannot be resumed"); - } - - return updateAgent(id, { - status: "idle", - pauseReason: null, - pausedAt: null, - errorReason: null, - }); - }, - - clearError: async (id: string) => { - const existing = await getById(id); - if (!existing) return null; - if (existing.status === "terminated") throw conflict("Cannot clear error on terminated agent"); - if (existing.status === "pending_approval") { - throw conflict("Pending approval agents cannot have errors cleared"); - } - if (existing.status !== "error") { - throw conflict("Only agents in error status can have their error cleared"); - } - - const updated = await db - .update(agents) - .set({ - status: "idle", - pauseReason: null, - pausedAt: null, - errorReason: null, - updatedAt: new Date(), - }) - .where(and(eq(agents.id, id), eq(agents.status, "error"))) - .returning() - .then((rows) => rows[0] ?? null); - - if (!updated) { - throw conflict("Only agents in error status can have their error cleared"); - } - return getById(updated.id); - }, - - terminate: async (id: string) => { - const existing = await getById(id); - if (!existing) return null; - - return db.transaction(async tx => { - const txDb = tx as unknown as Db; - const updated = await agentService(txDb).update(id, { - status: "terminated", - pauseReason: null, - pausedAt: null, - errorReason: null, - updatedAt: new Date(), - }); - if (!updated) return null; - await tx.update(agentApiKeys).set({ revokedAt: new Date() }).where(eq(agentApiKeys.agentId, id)); - return updated; - }); - }, - - remove: async (id: string) => { - const existing = await getById(id); - if (!existing) return null; - const builtInMarker = readBuiltInAgentMarker(existing.metadata); - if (builtInMarker) { - throw conflict("Built-in agents cannot be deleted; pause them instead", { - code: "built_in_agent_undeletable", - key: builtInMarker.key, - featureKeys: builtInMarker.featureKeys, - }); - } - - return withAccountingTransaction(db, existing.companyId, async (tx) => { - const [decisionHold] = await tx.select({ id: budgetReservations.id }).from(budgetReservations).where(and( - eq(budgetReservations.companyId, existing.companyId), eq(budgetReservations.agentId, id), - eq(budgetReservations.state, "held"), sql`${budgetReservations.decisionInvocationId} is not null`, - )).limit(1); - if (decisionHold) throw conflict("Wait for active decisions or resolve their unknown charges in Costs before deleting this agent", { - code: "agent_decision_accounting_pending", - }); - await tx - .select({ id: agents.id }) - .from(agents) - .where(eq(agents.id, id)) - .for("update"); - await issueThreadInteractionService(tx as unknown as Db) - .cancelPendingForDeletedAddressee(existing.companyId, id); - await tx.update(agents).set({ reportsTo: null }).where(eq(agents.reportsTo, id)); - await tx - .update(issues) - .set({ assigneeAgentId: null, createdByAgentId: null }) - .where(or(eq(issues.assigneeAgentId, id), eq(issues.createdByAgentId, id))); - await tx.delete(heartbeatRunEvents).where(eq(heartbeatRunEvents.agentId, id)); - await tx.delete(agentTaskSessions).where(eq(agentTaskSessions.agentId, id)); - await tx.delete(activityLog).where( - or( - eq(activityLog.agentId, id), - sql`${activityLog.runId} in (select ${heartbeatRuns.id} from ${heartbeatRuns} where ${heartbeatRuns.agentId} = ${id})`, - ), - ); - await tx.delete(issueExecutionDecisions).where(eq(issueExecutionDecisions.actorAgentId, id)); - await tx.delete(issueComments).where(eq(issueComments.authorAgentId, id)); - await tx.delete(heartbeatRuns).where(eq(heartbeatRuns.agentId, id)); - await tx.delete(agentWakeupRequests).where(eq(agentWakeupRequests.agentId, id)); - await tx.delete(agentApiKeys).where(eq(agentApiKeys.agentId, id)); - await tx.delete(agentRuntimeState).where(eq(agentRuntimeState.agentId, id)); - await tx.delete(principalPermissionGrants).where(and( - eq(principalPermissionGrants.companyId, existing.companyId), - eq(principalPermissionGrants.principalType, "agent"), - eq(principalPermissionGrants.principalId, id), - )); - const deleted = await tx - .delete(agents) - .where(eq(agents.id, id)) - .returning() - .then((rows) => rows[0] ?? null); - return deleted ? normalizeAgentRow(deleted) : null; - }); - }, - - activatePendingApproval: async (id: string, approvedPayload?: Record | null) => { - const activatedAgent = await db.transaction(async (tx) => { - const txDb = tx as unknown as Db; - const existing = await agentService(txDb).getById(id); - if (!existing || existing.status !== "pending_approval") return null; - const approvedPatch = approvedPayload ? configPatchFromApprovalPayload(approvedPayload) : {}; - let patch = { ...approvedPatch } as Partial; - let approvalBindingDecision: ClaudeOAuthBindingInvariantDecision | null = null; - if ( - Object.prototype.hasOwnProperty.call(patch, "adapterConfig") && - isPlainRecord(patch.adapterConfig) - ) { - const normalizedAdapterConfig = await secretService(txDb).normalizeAdapterConfigForPersistence( - existing.companyId, - patch.adapterConfig, - { adapterType: (patch.adapterType ?? existing.adapterType) as string }, - ); - patch.adapterConfig = normalizePaperclipRunnerAdapterConfig( - (patch.adapterType ?? existing.adapterType) as string, - normalizedAdapterConfig, - ); - // The approval activation keeps an existing fixed binding but rejects a - // newly introduced binding, because it carries no stored-session claim. - approvalBindingDecision = assertClaudeOAuthBindingInvariant({ - adapterType: (patch.adapterType ?? existing.adapterType) as string, - nextConfig: patch.adapterConfig, - priorConfig: existing.adapterConfig, - }); - } else if ( - Object.prototype.hasOwnProperty.call(patch, "adapterType") - && isPlainRecord(existing.adapterConfig) - ) { - patch.adapterConfig = normalizePaperclipRunnerAdapterConfig( - patch.adapterType as string, - existing.adapterConfig, - ); - } - if (patch.permissions !== undefined) { - // The pending-approval activation replays the original hire - // request, so the new-agent creation default applies. - patch.permissions = normalizeAgentPermissions(patch.permissions, { context: "create" }); - } - const updated = await tx - .update(agents) - .set({ ...patch, status: "idle", updatedAt: new Date() }) - .where(and(eq(agents.id, id), eq(agents.status, "pending_approval"))) - .returning() - .then((rows) => rows[0] ?? null); - if (!updated) return null; - if (approvalBindingDecision) { - await enforceClaudeOAuthBindingClaim(txDb, { - companyId: existing.companyId, - decision: approvalBindingDecision, - consume: false, - environmentId: null, - }); - } - await syncAgentSecretBindings(updated, txDb, existing.adapterConfig); - if (!permissionsImplyLowTrust(updated.permissions) && !readBuiltInAgentMarker(updated.metadata)) { - await tx.insert(principalPermissionGrants).values( - NEW_STANDARD_AGENT_DEFAULT_GRANT_KEYS.map((permissionKey) => ({ - companyId: updated.companyId, - principalType: "agent" as const, - principalId: updated.id, - permissionKey, - scope: newStandardAgentGrantScope(permissionKey, updated.id), - })), - ).onConflictDoNothing(); - } - await recordResourceCreationEvent(txDb, existing.companyId, "agent", updated.id); - const agent = await agentService(txDb).getById(updated.id); - if (!agent) { - throw notFound("Agent not found"); - } - return agent; - }); - - if (activatedAgent) { - return { agent: activatedAgent, activated: true }; - } - - const existing = await getById(id); - return existing ? { agent: existing, activated: false } : null; - }, - updatePermissions: async (id: string, permissions: Record & { canCreateAgents: boolean }) => { const existing = await getById(id); if (!existing) return null; @@ -1474,5 +277,8 @@ export function agentService(db: Db, budgetHooks: BudgetServiceHooks = {}) { } return { agent: null, ambiguous: false } as const; }, + update: updateAgent, + remove: (id: string) => createAgentLifecycle(db, budgetHooks).purgeAgent(id), + clearError: (id: string) => createAgentLifecycle(db, budgetHooks).clearError(id), }; } diff --git a/server/src/services/ai-api-key-test.ts b/server/src/services/ai-api-key-test.ts new file mode 100644 index 00000000000..1e5405d7086 --- /dev/null +++ b/server/src/services/ai-api-key-test.ts @@ -0,0 +1,38 @@ +import type { AiProvider } from "@paperclipai/shared"; +import { unprocessable } from "../errors.js"; + +/** Fixed provider endpoints; credentials are never sent to a caller-supplied URL or through a redirect. */ +export async function validateAiApiKey( + provider: AiProvider, + key: string, + request: typeof fetch = fetch, +) { + const endpoints = { + anthropic: "https://api.anthropic.com/v1/models?limit=1", + openai: "https://api.openai.com/v1/models", + openrouter: "https://openrouter.ai/api/v1/key", + xai: "https://api.x.ai/v1/models", + google: "https://generativelanguage.googleapis.com/v1beta/models?pageSize=1", + }; + let response: Response; + try { + response = await request(endpoints[provider], { + redirect: "error", + signal: AbortSignal.timeout(15000), + headers: + provider === "google" ? { "x-goog-api-key": key } : provider === "anthropic" + ? { "x-api-key": key, "anthropic-version": "2023-06-01" } + : { Authorization: `Bearer ${key}` }, + }); + } catch { + throw unprocessable("Could not verify the account. Try again.", { code: "ai_connection_verification_failed" }); + } + await response.body?.cancel(); + if (!response.ok) + throw unprocessable( + response.status === 401 || response.status === 403 + ? "The provider rejected this API key." + : "The provider could not verify this account. Try again.", + { code: response.status === 401 || response.status === 403 ? "ai_connection_api_key_rejected" : "ai_connection_verification_failed" }, + ); +} diff --git a/server/src/services/approvals.ts b/server/src/services/approvals.ts index f90542846c9..dffd11b72e5 100644 --- a/server/src/services/approvals.ts +++ b/server/src/services/approvals.ts @@ -1,21 +1,19 @@ -import { agentAppearanceSchema } from "@paperclipai/shared"; +import { approvalResolutionRecords, resolvableApprovalStatuses as resolvableStatuses } from "../lib/approval-records.js"; +import { budgetService } from "./budgets.js"; +import { notifyHireApproved } from "./hire-hook.js"; + import { and, asc, eq, inArray, sql, type SQL } from "drizzle-orm"; import type { Db } from "@paperclipai/db"; import { approvalComments, approvals } from "@paperclipai/db"; -import { notFound, unprocessable } from "../errors.js"; +import { unprocessable } from "../errors.js"; import { redactCurrentUserText } from "../log-redaction.js"; -import { agentService } from "./agents.js"; -import { budgetService, budgetServiceInTransaction } from "./budgets.js"; -import { withAccountingTransaction } from "./accounting-transaction.js"; -import { notifyHireApproved } from "./hire-hook.js"; +import { createAgentLifecycle } from "./agent-lifecycle.js"; + import { instanceSettingsService } from "./instance-settings.js"; -export function approvalService(db: Db) { +export function approvalRecords(db: Db) { const instanceSettings = instanceSettingsService(db); - const canResolveStatuses = new Set(["pending", "revision_requested"]); - const resolvableStatuses = Array.from(canResolveStatuses); - type ApprovalRecord = typeof approvals.$inferSelect; - type ResolutionResult = { approval: ApprovalRecord; applied: boolean }; + const { getExistingApproval, resolveApproval } = approvalResolutionRecords(db); function redactApprovalComment(comment: T, censorUsernameInLogs: boolean): T { return { @@ -24,69 +22,8 @@ export function approvalService(db: Db) { }; } - async function reconcileApprovedBuiltInAgent(companyId: string, payload: Record, database: Db) { - const sourceBuiltInAgentKey = typeof payload.sourceBuiltInAgentKey === "string" ? payload.sourceBuiltInAgentKey : null; - if (!sourceBuiltInAgentKey) return; - const { builtInAgentService } = await import("./built-in-agents.js"); - await builtInAgentService(database).ensure(companyId, sourceBuiltInAgentKey); - } - - async function getExistingApproval(id: string, database: Db = db) { - const existing = await database - .select() - .from(approvals) - .where(eq(approvals.id, id)) - .then((rows) => rows[0] ?? null); - if (!existing) throw notFound("Approval not found"); - return existing; - } - - async function resolveApproval( - id: string, - targetStatus: "approved" | "rejected", - decidedByUserId: string, - decisionNote: string | null | undefined, - database: Db = db, - ): Promise { - const existing = await getExistingApproval(id, database); - if (!canResolveStatuses.has(existing.status)) { - if (existing.status === targetStatus) { - return { approval: existing, applied: false }; - } - throw unprocessable( - `Only pending or revision requested approvals can be ${targetStatus === "approved" ? "approved" : "rejected"}`, - ); - } - - const now = new Date(); - const updated = await database - .update(approvals) - .set({ - status: targetStatus, - decidedByUserId, - decisionNote: decisionNote ?? null, - decidedAt: now, - updatedAt: now, - }) - .where(and(eq(approvals.id, id), inArray(approvals.status, resolvableStatuses))) - .returning() - .then((rows) => rows[0] ?? null); - - if (updated) { - return { approval: updated, applied: true }; - } - - const latest = await getExistingApproval(id, database); - if (latest.status === targetStatus) { - return { approval: latest, applied: false }; - } - - throw unprocessable( - `Only pending or revision requested approvals can be ${targetStatus === "approved" ? "approved" : "rejected"}`, - ); - } - return { + getExistingApproval, resolveApproval, list: (companyId: string, status?: string, readCondition?: SQL) => { const conditions = [eq(approvals.companyId, companyId)]; if (status) conditions.push(eq(approvals.status, status)); @@ -142,113 +79,6 @@ export function approvalService(db: Db) { return updated; }, - approve: async (id: string, decidedByUserId: string, decisionNote?: string | null) => { - const now = new Date(); - const existing = await getExistingApproval(id); - // Receipt writers lock company before agent. Hire approval must use that - // order too, including activation of an existing pending agent. - const result = await withAccountingTransaction(db, existing.companyId, async (txDb, publications) => { - const agentsSvc = agentService(txDb); - const budgets = budgetServiceInTransaction(txDb, publications); - const { approval: updated, applied } = await resolveApproval( - id, - "approved", - decidedByUserId, - decisionNote, - txDb, - ); - - let hireApprovedAgentId: string | null = null; - if (applied && updated.type === "hire_agent") { - const payload = updated.payload as Record; - const payloadAgentId = typeof payload.agentId === "string" ? payload.agentId : null; - if (payloadAgentId) { - await agentsSvc.activatePendingApproval(payloadAgentId, payload); - await reconcileApprovedBuiltInAgent(updated.companyId, payload, txDb); - hireApprovedAgentId = payloadAgentId; - } else { - const created = await agentsSvc.create(updated.companyId, { - name: String(payload.name ?? "New Agent"), - appearance: payload.appearance == null ? undefined : agentAppearanceSchema.parse(payload.appearance), - role: String(payload.role ?? "general"), - title: typeof payload.title === "string" ? payload.title : null, - reportsTo: typeof payload.reportsTo === "string" ? payload.reportsTo : null, - capabilities: typeof payload.capabilities === "string" ? payload.capabilities : null, - adapterType: String(payload.adapterType ?? "process"), - adapterConfig: - typeof payload.adapterConfig === "object" && payload.adapterConfig !== null - ? (payload.adapterConfig as Record) - : {}, - budgetMonthlyCents: - typeof payload.budgetMonthlyCents === "number" ? payload.budgetMonthlyCents : 0, - metadata: - typeof payload.metadata === "object" && payload.metadata !== null - ? (payload.metadata as Record) - : null, - status: "idle", - spentMonthlyCents: 0, - permissions: undefined, - lastHeartbeatAt: null, - }, { createdByUserId: updated.requestedByAgentId ? null : updated.requestedByUserId }); - hireApprovedAgentId = created?.id ?? null; - } - if (hireApprovedAgentId) { - const budgetMonthlyCents = - typeof payload.budgetMonthlyCents === "number" ? payload.budgetMonthlyCents : 0; - if (budgetMonthlyCents > 0) { - await budgets.upsertPolicy( - updated.companyId, - { - scopeType: "agent", - scopeId: hireApprovedAgentId, - amount: budgetMonthlyCents, - windowKind: "calendar_month_utc", - }, - decidedByUserId, - ); - } - - } - } - - return { approval: updated, applied, hireApprovedAgentId }; - }); - if (result.hireApprovedAgentId) { - await budgetService(db).deliverPendingEnforcement(result.approval.companyId); - void notifyHireApproved(db, { - companyId: result.approval.companyId, - agentId: result.hireApprovedAgentId, - source: "approval", - sourceId: id, - approvedAt: now, - }).catch(() => {}); - } - return { approval: result.approval, applied: result.applied }; - }, - - reject: async (id: string, decidedByUserId: string, decisionNote?: string | null) => { - return db.transaction(async tx => { - const txDb = tx as unknown as Db; - const { approval: updated, applied } = await resolveApproval( - id, - "rejected", - decidedByUserId, - decisionNote, - txDb, - ); - - if (applied && updated.type === "hire_agent") { - const payload = updated.payload as Record; - const payloadAgentId = typeof payload.agentId === "string" ? payload.agentId : null; - if (payloadAgentId) { - await agentService(txDb).terminate(payloadAgentId); - } - } - - return { approval: updated, applied }; - }); - }, - requestRevision: async (id: string, decidedByUserId: string, decisionNote?: string | null) => { const existing = await getExistingApproval(id); if (existing.status !== "pending") { @@ -332,3 +162,40 @@ export function approvalService(db: Db) { }, }; } + +export function approvalService(db: Db) { + const { getExistingApproval, resolveApproval, ...records } = approvalRecords(db); + async function reconcileApprovedBuiltInAgent(companyId: string, payload: Record, database: Db) { + const sourceBuiltInAgentKey = typeof payload.sourceBuiltInAgentKey === "string" ? payload.sourceBuiltInAgentKey : null; + if (!sourceBuiltInAgentKey) return; + const { builtInAgentService } = await import("./built-in-agents.js"); + await builtInAgentService(database).ensure(companyId, sourceBuiltInAgentKey); + } + + async function decideHire(target: string | { approvalId: string }, status: "approved" | "rejected", userId: string, note?: string | null) { + const lifecycle = createAgentLifecycle(db); + const result = await (status === "approved" ? lifecycle.approveHire : lifecycle.rejectHire)(target, userId, note); + if (result?.hireApprovedAgentId && result.approval) { + await reconcileApprovedBuiltInAgent(result.approval.companyId, result.approval.payload, db); + await budgetService(db).deliverPendingEnforcement(result.approval.companyId); + void notifyHireApproved(db, { companyId: result.approval.companyId, agentId: result.hireApprovedAgentId, + source: "approval", sourceId: result.approval.id, approvedAt: result.approval.decidedAt ?? new Date() }).catch(() => {}); + } + return result; + } + + async function decide(id: string, status: "approved" | "rejected", userId: string, note?: string | null) { + const approval = await getExistingApproval(id); + if (approval.type === "hire_agent") { + const result = await decideHire({ approvalId: id }, status, userId, note); + return { approval: result!.approval!, applied: result!.applied }; + } + return resolveApproval(id, status, userId, note); + } + return { ...records, + approveHire: (agentId: string, userId: string, note?: string | null) => decideHire(agentId, "approved", userId, note), + rejectHire: (agentId: string, userId: string, note?: string | null) => decideHire(agentId, "rejected", userId, note), + approve: (id: string, userId: string, note?: string | null) => decide(id, "approved", userId, note), + reject: (id: string, userId: string, note?: string | null) => decide(id, "rejected", userId, note), + }; +} diff --git a/server/src/services/authorization.ts b/server/src/services/authorization.ts index 47732acf76e..533cf186f5d 100644 --- a/server/src/services/authorization.ts +++ b/server/src/services/authorization.ts @@ -45,7 +45,7 @@ import { type TrustPresetResolution, } from "./trust-preset-resolver.js"; import { logger } from "../middleware/logger.js"; -import { normalizeAgentPermissions } from "./agent-permissions.js"; +import { normalizeAgentPermissions } from "../lib/agent-permissions.js"; import { grantsForHumanRole, normalizeHumanRole } from "./company-member-roles.js"; export type AuthorizationActor = diff --git a/server/src/services/budgets.ts b/server/src/services/budgets.ts index 9de0a2dd090..f938b168ee3 100644 --- a/server/src/services/budgets.ts +++ b/server/src/services/budgets.ts @@ -1,7 +1,7 @@ import { compareCents, normalizeCents } from "@paperclipai/shared"; import { and, desc, eq, gte, inArray, lt, ne, sql, or, isNull, type SQL } from "drizzle-orm"; import type { Db } from "@paperclipai/db"; -import { recordAgentStatusEvent } from "./resource-lifecycle-events.js"; + import { agents, approvals, @@ -225,7 +225,7 @@ function observedBlocks(policy: PolicyRow, observed: Awaited= 0 || (observed.pendingRunCount - observed.recoveringRunCount) > 0 || (policy.unpricedUsagePolicy !== "allow" && observed.unpricedEventCount > 0); } -async function policyBlocks(db: Db, policy: PolicyRow) { +export async function policyBlocks(db: Db, policy: PolicyRow) { if (!policy.isActive || !policy.hardStopEnabled || policy.amount <= 0) return false; return observedBlocks(policy, await computeObservedSpend(db, policy)); } @@ -282,18 +282,7 @@ export function budgetServiceInTransaction(db: Db, publications: ActivityPublica const recordActivity = (input: LogActivityInput) => logActivity(db, input, publications); async function pauseScopeForBudget(policy: PolicyRow) { const now = new Date(); - if (policy.scopeType === "agent") { - await db.transaction(async tx => { - const [agent] = await tx.select().from(agents) - .where(and(eq(agents.id, policy.scopeId), eq(agents.companyId, policy.companyId))).for("update"); - if (agent && ["active", "idle", "running", "error"].includes(agent.status)) { - await tx.update(agents).set({ status: "paused", pauseReason: "budget", pausedAt: now, updatedAt: now }) - .where(eq(agents.id, agent.id)); - await recordAgentStatusEvent(tx as unknown as Db, agent.companyId, agent.id, agent.status, "paused"); - } - }); - return; - } + if (policy.scopeType === "agent") return; if (policy.scopeType === "project") { await db @@ -334,18 +323,7 @@ export function budgetServiceInTransaction(db: Db, publications: ActivityPublica if (await policyBlocks(db, candidate)) return; } const now = new Date(); - if (policy.scopeType === "agent") { - await db.transaction(async tx => { - const [agent] = await tx.select().from(agents) - .where(and(eq(agents.id, policy.scopeId), eq(agents.companyId, policy.companyId))).for("update"); - if (agent?.status === "paused" && agent.pauseReason === "budget") { - await tx.update(agents).set({ status: "idle", pauseReason: null, pausedAt: null, updatedAt: now }) - .where(eq(agents.id, agent.id)); - await recordAgentStatusEvent(tx as unknown as Db, agent.companyId, agent.id, agent.status, "idle"); - } - }); - return; - } + if (policy.scopeType === "agent") return; if (policy.scopeType === "project") { await db @@ -993,7 +971,10 @@ export async function withCurrentBudgetEnforcement(db: Db, scope: BudgetEnfor /** Cancellation is an at-least-once external effect. A failed delivery never * rolls back committed spend, and its version remains pending for recovery. */ -export async function deliverBudgetEnforcement(db: Db, hooks: BudgetServiceHooks, companyId?: string) { +export async function deliverBudgetEnforcement(db: Db, hooks: BudgetServiceHooks, companyId?: string, agentId?: string | null) { + const { createAgentLifecycle } = await import("./agent-lifecycle.js"); + // Global recovery uses the bounded lifecycle sweep for policy holds. + if (companyId) await createAgentLifecycle(db).reconcilePolicyHolds(companyId, agentId); if (!hooks.cancelWorkForScope) return; const pending = await db.select().from(budgetPolicies).where(and( sql`${budgetPolicies.enforcementVersion} > ${budgetPolicies.enforcementDeliveredVersion}`, @@ -1017,9 +998,9 @@ export async function deliverBudgetEnforcement(db: Db, hooks: BudgetServiceHooks export function budgetService(db: Db, hooks: BudgetServiceHooks = {}) { const reads = budgetServiceInTransaction(db); - async function mutate(companyId: string, work: (service: ReturnType) => Promise) { + async function mutate(companyId: string, work: (service: ReturnType) => Promise, agentId?: string | null) { const result = await withAccountingTransaction(db, companyId, (tx, publications) => work(budgetServiceInTransaction(tx, publications))); - await deliverBudgetEnforcement(db, hooks, companyId); + await deliverBudgetEnforcement(db, hooks, companyId, agentId); return result; } return { @@ -1044,7 +1025,7 @@ export function budgetService(db: Db, hooks: BudgetServiceHooks = {}) { evaluateCostEvent: (event: typeof costEvents.$inferSelect) => mutate(event.companyId, (service) => service.evaluateCostEvent(event)), getInvocationBlock: (companyId: string, agentId: string | null, context?: { issueId?: string | null; projectId?: string | null }) => - mutate(companyId, (service) => service.getInvocationBlock(companyId, agentId, context)), + mutate(companyId, (service) => service.getInvocationBlock(companyId, agentId, context), agentId), resolveIncident: (companyId: string, incidentId: string, input: BudgetIncidentResolutionInput, actorUserId: string) => mutate(companyId, (service) => service.resolveIncident(companyId, incidentId, input, actorUserId)), }; diff --git a/server/src/services/built-in-agents.ts b/server/src/services/built-in-agents.ts index 1b5f70308d0..989f7b93b3d 100644 --- a/server/src/services/built-in-agents.ts +++ b/server/src/services/built-in-agents.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "./agent-lifecycle.js"; import fs from "node:fs/promises"; import { readFileSync } from "node:fs"; import { createRequire } from "node:module"; @@ -21,7 +22,7 @@ import { approvalService } from "./approvals.js"; import { readBuiltInAgentMarker, withBuiltInAgentMarker, -} from "./built-in-agent-metadata.js"; +} from "../lib/built-in-agent-metadata.js"; import { companySkillService } from "./company-skills.js"; import { routineService } from "./routines.js"; import { accessService } from "./access.js"; @@ -805,6 +806,7 @@ function isBuiltInAgentMarkerConflict(error: unknown): boolean { export function builtInAgentService(db: Db) { const agentSvc = agentService(db); + const agentSvcLifecycle = createAgentLifecycle(db); const accessSvc = accessService(db); const approvalSvc = approvalService(db); const instructionsSvc = agentInstructionsService(db); @@ -1403,8 +1405,8 @@ export function builtInAgentService(db: Db) { } async function ensureBuiltInAgentAssignable(agent: Agent) { - if (agent.status !== "paused") return agent; - const resumed = await agentSvc.resume(agent.id); + if (agent.status !== "paused" || ["preparing", "verifying", "resuming"].includes(agent.lifecycleState ?? "")) return agent; + const resumed = await agentSvcLifecycle.resumeAgent(agent.id); if (!resumed) throw notFound("Built-in agent not found"); return resumed as Agent; } @@ -1664,7 +1666,7 @@ export function builtInAgentService(db: Db) { const [keep, ...duplicates] = markedRows; for (const duplicate of duplicates) { const openApproval = await approvalSvc.findOpenHireApprovalForAgent(companyId, duplicate.id); - await agentSvc.terminate(duplicate.id); + await agentSvcLifecycle.terminateAgent(duplicate.id); if (openApproval) { await approvalSvc.cancel( openApproval.id, @@ -1785,7 +1787,7 @@ export function builtInAgentService(db: Db) { : null; let created: Agent; try { - created = await agentSvc.create(companyId, { + created = await agentSvcLifecycle.requestHire(companyId, { ...definitionPatch(definition, resolvedInput), status: definition.defaultStatus ?? "idle", pauseReason: definition.defaultStatus === "paused" @@ -1890,7 +1892,7 @@ export function builtInAgentService(db: Db) { : null; let pending: Agent; try { - pending = await agentSvc.create(companyId, { + pending = await agentSvcLifecycle.requestHire(companyId, { ...definitionPatch(definition, input), status: "pending_approval", reportsTo, diff --git a/server/src/services/companies.ts b/server/src/services/companies.ts index 94c058e71ef..149b30b4fe9 100644 --- a/server/src/services/companies.ts +++ b/server/src/services/companies.ts @@ -1,3 +1,5 @@ +import { deleteCompany } from "./company-deletion.js"; +import { createAgentLifecycle } from "./agent-lifecycle.js"; import { publishAccountingActivities } from "./accounting-transaction.js"; import { budgetServiceInTransaction, deliverBudgetEnforcement, type BudgetServiceHooks } from "./budgets.js"; import { and, count, eq, gte, inArray, isNull, lt, notInArray, sql } from "drizzle-orm"; @@ -7,37 +9,10 @@ import { companyLogos, assets, agents, - agentApiKeys, - agentRuntimeState, - agentTaskSessions, agentWakeupRequests, issues, - issueComments, - projects, - goals, heartbeatRuns, - runIdentityContexts, - heartbeatRunEvents, costEvents, - decisionInvocations, - financeEvents, - budgetPolicies, - budgetIncidents, - issueReadStates, - approvalComments, - approvals, - activityLog, - companySecrets, - joinRequests, - invites, - principalPermissionGrants, - companyMemberships, - companySkills, - documents, - routineRuns, - routineTriggers, - routineRevisions, - routines, } from "@paperclipai/db"; import { notFound, unprocessable } from "../errors.js"; import { isCloudManagedInstance } from "./cloud-instance.js"; @@ -79,19 +54,7 @@ export function companyService(db: Db, budgetHooks: BudgetServiceHooks = {}) { type CompanyTx = Parameters[0]>[0]; async function applyArchiveCascadeInTx(tx: CompanyTx, id: string) { - const pausedAgentRows = await tx - .update(agents) - .set({ - status: "paused", - pauseReason: "company_archived", - pausedAt: new Date(), - updatedAt: new Date(), - }) - .where(and( - eq(agents.companyId, id), - notInArray(agents.status, ["paused", "terminated", "pending_approval"]), - )) - .returning({ id: agents.id }); + const pausedAgentRows = await tx.select({ id: agents.id }).from(agents).where(and(eq(agents.companyId, id), notInArray(agents.status, ["paused", "terminated", "pending_approval"]))); const activeRunIds = await tx .select({ id: heartbeatRuns.id }) @@ -399,20 +362,7 @@ export function companyService(db: Db, budgetHooks: BudgetServiceHooks = {}) { let agentsRestored = 0; if (willReactivate) { - const restoredRows = await tx - .update(agents) - .set({ - status: "idle", - pauseReason: null, - pausedAt: null, - updatedAt: new Date(), - }) - .where(and( - eq(agents.companyId, id), - eq(agents.status, "paused"), - eq(agents.pauseReason, "company_archived"), - )) - .returning({ id: agents.id }); + const restoredRows = await tx.select({ id: agents.id }).from(agents).where(and(eq(agents.companyId, id), eq(agents.pauseReason, "company_archived"))); agentsRestored = restoredRows.length; } @@ -464,6 +414,7 @@ export function companyService(db: Db, budgetHooks: BudgetServiceHooks = {}) { }; }); if (!result) return null; + await createAgentLifecycle(db).reconcilePolicyHolds(id); publishAccountingActivities(id, budgetPublications); if (data.budgetMonthlyCents !== undefined) await deliverBudgetEnforcement(db, budgetHooks, id); // Post-commit, fire-and-forget, and BEFORE any finalization that @@ -542,6 +493,7 @@ export function companyService(db: Db, budgetHooks: BudgetServiceHooks = {}) { }; }); if (!result) return null; + await createAgentLifecycle(db).reconcilePolicyHolds(id); // Same doorbell rule as update(): the archive is committed, so ring // before finalization, which can throw without undoing it. @@ -553,67 +505,7 @@ export function companyService(db: Db, budgetHooks: BudgetServiceHooks = {}) { return result.company; }, - remove: (id: string) => - db.transaction(async (tx) => { - // Exclude accounting writers before taking child locks. KEY SHARE must - // remain compatible: native writers can already hold a child row while - // saving a company-scoped result. FOR UPDATE would deadlock that save. - const [existing] = await tx.select({ id: companies.id }).from(companies) - .where(eq(companies.id, id)).for("no key update"); - if (!existing) return null; - // Finance can reference costs and both can reference runs. Incidents - // reference policies and approvals; delete these dependents first. - await tx.delete(financeEvents).where(eq(financeEvents.companyId, id)); - await tx.delete(decisionInvocations).where(eq(decisionInvocations.companyId, id)); - await tx.delete(costEvents).where(eq(costEvents.companyId, id)); - await tx.delete(budgetIncidents).where(eq(budgetIncidents.companyId, id)); - await tx.delete(budgetPolicies).where(eq(budgetPolicies.companyId, id)); - // Delete from child tables in dependency order - const companyRunIds = await tx - .select({ id: heartbeatRuns.id }) - .from(heartbeatRuns) - .where(eq(heartbeatRuns.companyId, id)); - - await tx.delete(heartbeatRunEvents).where(eq(heartbeatRunEvents.companyId, id)); - if (companyRunIds.length > 0) { - await tx - .delete(heartbeatRunEvents) - .where(inArray(heartbeatRunEvents.runId, companyRunIds.map((run) => run.id))); - } - await tx.delete(agentTaskSessions).where(eq(agentTaskSessions.companyId, id)); - await tx.delete(activityLog).where(eq(activityLog.companyId, id)); - await tx.delete(runIdentityContexts).where(eq(runIdentityContexts.companyId, id)); - await tx.delete(heartbeatRuns).where(eq(heartbeatRuns.companyId, id)); - await tx.delete(agentWakeupRequests).where(eq(agentWakeupRequests.companyId, id)); - await tx.delete(agentApiKeys).where(eq(agentApiKeys.companyId, id)); - await tx.delete(agentRuntimeState).where(eq(agentRuntimeState.companyId, id)); - await tx.delete(issueComments).where(eq(issueComments.companyId, id)); - await tx.delete(approvalComments).where(eq(approvalComments.companyId, id)); - await tx.delete(approvals).where(eq(approvals.companyId, id)); - await tx.delete(companySecrets).where(eq(companySecrets.companyId, id)); - await tx.delete(joinRequests).where(eq(joinRequests.companyId, id)); - await tx.delete(invites).where(eq(invites.companyId, id)); - await tx.delete(principalPermissionGrants).where(eq(principalPermissionGrants.companyId, id)); - await tx.delete(companyMemberships).where(eq(companyMemberships.companyId, id)); - await tx.delete(companySkills).where(eq(companySkills.companyId, id)); - await tx.delete(routineRuns).where(eq(routineRuns.companyId, id)); - await tx.delete(routineTriggers).where(eq(routineTriggers.companyId, id)); - await tx.delete(routineRevisions).where(eq(routineRevisions.companyId, id)); - await tx.delete(routines).where(eq(routines.companyId, id)); - await tx.delete(issueReadStates).where(eq(issueReadStates.companyId, id)); - await tx.delete(documents).where(eq(documents.companyId, id)); - await tx.delete(issues).where(eq(issues.companyId, id)); - await tx.delete(companyLogos).where(eq(companyLogos.companyId, id)); - await tx.delete(assets).where(eq(assets.companyId, id)); - await tx.delete(goals).where(eq(goals.companyId, id)); - await tx.delete(projects).where(eq(projects.companyId, id)); - await tx.delete(agents).where(eq(agents.companyId, id)); - const rows = await tx - .delete(companies) - .where(eq(companies.id, id)) - .returning(); - return rows[0] ?? null; - }), + remove: (id: string) => deleteCompany(db, id), stats: () => Promise.all([ diff --git a/server/src/services/company-deletion.ts b/server/src/services/company-deletion.ts new file mode 100644 index 00000000000..4ab40f03e69 --- /dev/null +++ b/server/src/services/company-deletion.ts @@ -0,0 +1,110 @@ +import type { Db } from "@paperclipai/db"; +import { eq, inArray } from "drizzle-orm"; +import { createAgentLifecycle, scheduleAgentLifecycle } from "./agent-lifecycle.js"; +import { agentLifecycleCompanyDeletion } from "../modules/agent-lifecycle/company-deletion.js"; +import { + companies, + agents, + companyLogos, + assets, + agentApiKeys, + agentRuntimeState, + agentTaskSessions, + agentWakeupRequests, + issues, + issueComments, + projects, + goals, + heartbeatRuns, + runIdentityContexts, + heartbeatRunEvents, + costEvents, + decisionInvocations, + financeEvents, + budgetPolicies, + budgetIncidents, + issueReadStates, + approvalComments, + approvals, + activityLog, + companySecrets, + joinRequests, + invites, + principalPermissionGrants, + companyMemberships, + companySkills, + documents, + routineRuns, + routineTriggers, + routineRevisions, + routines, +} from "@paperclipai/db"; + +export async function deleteCompany(db: Db, id: string) { + const lifecycle = createAgentLifecycle(db); + const companyAgents = await db.select({ id: agents.id }).from(agents).where(eq(agents.companyId, id)); + for (const agent of companyAgents) { + await lifecycle.terminateAgent(agent.id); + await scheduleAgentLifecycle(db, agent.id); + } + return db.transaction(async (tx) => { + // Exclude accounting writers before taking child locks. KEY SHARE must + // remain compatible: native writers can already hold a child row while + // saving a company-scoped result. FOR UPDATE would deadlock that save. + const [existing] = await tx.select({ id: companies.id }).from(companies) + .where(eq(companies.id, id)).for("no key update"); + if (!existing) return null; + // Finance can reference costs and both can reference runs. Incidents + // reference policies and approvals; delete these dependents first. + await tx.delete(financeEvents).where(eq(financeEvents.companyId, id)); + await tx.delete(decisionInvocations).where(eq(decisionInvocations.companyId, id)); + await tx.delete(costEvents).where(eq(costEvents.companyId, id)); + await tx.delete(budgetIncidents).where(eq(budgetIncidents.companyId, id)); + await tx.delete(budgetPolicies).where(eq(budgetPolicies.companyId, id)); + // Delete from child tables in dependency order + const companyRunIds = await tx + .select({ id: heartbeatRuns.id }) + .from(heartbeatRuns) + .where(eq(heartbeatRuns.companyId, id)); + + await tx.delete(heartbeatRunEvents).where(eq(heartbeatRunEvents.companyId, id)); + if (companyRunIds.length > 0) { + await tx + .delete(heartbeatRunEvents) + .where(inArray(heartbeatRunEvents.runId, companyRunIds.map((run) => run.id))); + } + await tx.delete(agentTaskSessions).where(eq(agentTaskSessions.companyId, id)); + await tx.delete(activityLog).where(eq(activityLog.companyId, id)); + await tx.delete(runIdentityContexts).where(eq(runIdentityContexts.companyId, id)); + await tx.delete(heartbeatRuns).where(eq(heartbeatRuns.companyId, id)); + await tx.delete(agentWakeupRequests).where(eq(agentWakeupRequests.companyId, id)); + await tx.delete(agentApiKeys).where(eq(agentApiKeys.companyId, id)); + await tx.delete(agentRuntimeState).where(eq(agentRuntimeState.companyId, id)); + await tx.delete(issueComments).where(eq(issueComments.companyId, id)); + await tx.delete(approvalComments).where(eq(approvalComments.companyId, id)); + await tx.delete(approvals).where(eq(approvals.companyId, id)); + await tx.delete(companySecrets).where(eq(companySecrets.companyId, id)); + await tx.delete(joinRequests).where(eq(joinRequests.companyId, id)); + await tx.delete(invites).where(eq(invites.companyId, id)); + await tx.delete(principalPermissionGrants).where(eq(principalPermissionGrants.companyId, id)); + await tx.delete(companyMemberships).where(eq(companyMemberships.companyId, id)); + await tx.delete(companySkills).where(eq(companySkills.companyId, id)); + await tx.delete(routineRuns).where(eq(routineRuns.companyId, id)); + await tx.delete(routineTriggers).where(eq(routineTriggers.companyId, id)); + await tx.delete(routineRevisions).where(eq(routineRevisions.companyId, id)); + await tx.delete(routines).where(eq(routines.companyId, id)); + await tx.delete(issueReadStates).where(eq(issueReadStates.companyId, id)); + await tx.delete(documents).where(eq(documents.companyId, id)); + await tx.delete(issues).where(eq(issues.companyId, id)); + await tx.delete(companyLogos).where(eq(companyLogos.companyId, id)); + await tx.delete(assets).where(eq(assets.companyId, id)); + await tx.delete(goals).where(eq(goals.companyId, id)); + await tx.delete(projects).where(eq(projects.companyId, id)); + await agentLifecycleCompanyDeletion.deleteCompanyData(tx, id); + const rows = await tx + .delete(companies) + .where(eq(companies.id, id)) + .returning(); + return rows[0] ?? null; + }); +} diff --git a/server/src/services/company-portability-agent-selection.ts b/server/src/services/company-portability-agent-selection.ts index e258eb81e70..4f3110edfb3 100644 --- a/server/src/services/company-portability-agent-selection.ts +++ b/server/src/services/company-portability-agent-selection.ts @@ -1,5 +1,5 @@ import { normalizeAgentUrlKey } from "@paperclipai/shared"; -import { readBuiltInAgentMarker } from "./built-in-agent-metadata.js"; +import { readBuiltInAgentMarker } from "../lib/built-in-agent-metadata.js"; interface ExportAgentCandidate { id: string; diff --git a/server/src/services/company-portability.ts b/server/src/services/company-portability.ts index ad438f88298..1d7b983f347 100644 --- a/server/src/services/company-portability.ts +++ b/server/src/services/company-portability.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "./agent-lifecycle.js"; import { agentAppearanceSchema } from "@paperclipai/shared"; import { createHash, randomUUID } from "node:crypto"; import { promises as fs } from "node:fs"; @@ -3559,6 +3560,7 @@ export function parseGitHubSourceUrl(rawUrl: string) { export function companyPortabilityService(db: Db, storage?: StorageService) { const companies = companyService(db); const agents = agentService(db); + const agentsLifecycle = createAgentLifecycle(db); const assetRecords = assetService(db); const instructions = agentInstructionsService(db); const access = accessService(db); @@ -5642,9 +5644,9 @@ export function companyPortabilityService(db: Db, storage?: StorageService) { : {}; if (planAgent.action === "update" && planAgent.existingAgentId) { + if (pauseAutomations) await agentsLifecycle.pauseAgent(planAgent.existingAgentId, "import"); let updated = await agents.update(planAgent.existingAgentId, { ...patch, - ...automationPausePatch, }); if (!updated) { warnings.push(`Skipped update for missing agent ${planAgent.existingAgentId}.`); @@ -5690,7 +5692,7 @@ export function companyPortabilityService(db: Db, storage?: StorageService) { continue; } - let created = await agents.create(targetCompany.id, { + let created = await agentsLifecycle.requestHire(targetCompany.id, { ...patch, ...automationPausePatch, status: pauseAutomations ? "paused" : "idle", diff --git a/server/src/services/company-skills.ts b/server/src/services/company-skills.ts index 0db8d650ffc..fc07bf1ebea 100644 --- a/server/src/services/company-skills.ts +++ b/server/src/services/company-skills.ts @@ -1,3 +1,4 @@ +import { updateAgentConfigurationInTransaction } from "./agent-configuration-transaction.js"; import { logger } from "../middleware/logger.js"; import { removeRuntimeSkillCache, resolveRuntimeSkillCache, runtimeSkillCacheSpec } from "./runtime-skill-cache.js"; import { createHash, randomUUID } from "node:crypto"; @@ -3925,15 +3926,9 @@ export function companySkillService(db: Db) { ? { key: forkKey, versionId: null } : entry ); - const updated = await tx - .update(agentsTable) - .set({ - adapterConfig: writePaperclipSkillSyncPreference(adapterConfig, nextEntries), - updatedAt: new Date(), - }) - .where(and(eq(agentsTable.companyId, companyId), eq(agentsTable.id, item.agentId))) - .returning({ id: agentsTable.id }) - .then((rows) => rows[0] ?? null); + const updated = await updateAgentConfigurationInTransaction(tx as unknown as Db, item.agentId, { + adapterConfig: writePaperclipSkillSyncPreference(adapterConfig, nextEntries), + }, { allowPendingApprovalConfigUpdate: true }); if (!updated) throw notFound(`Agent not found for skill reassignment: ${item.agentId}`); } }); @@ -4196,13 +4191,9 @@ export function companySkillService(db: Db) { entry.key === previousKey ? { key: newKey, versionId: entry.versionId ?? null } : entry); - await tx - .update(agentsTable) - .set({ - adapterConfig: writePaperclipSkillSyncPreference(adapterConfig, nextEntries), - updatedAt: new Date(), - }) - .where(and(eq(agentsTable.companyId, companyId), eq(agentsTable.id, item.agentId))); + await updateAgentConfigurationInTransaction(tx as unknown as Db, item.agentId, { + adapterConfig: writePaperclipSkillSyncPreference(adapterConfig, nextEntries), + }, { allowPendingApprovalConfigUpdate: true }); } } catch (error) { // Restore while the name locks are still held. diff --git a/server/src/services/connection-intents.ts b/server/src/services/connection-intents.ts index 68005f19f4c..d75743e50d4 100644 --- a/server/src/services/connection-intents.ts +++ b/server/src/services/connection-intents.ts @@ -1,3 +1,4 @@ +import { updateAgentConfigurationInTransaction } from "./agent-configuration-transaction.js"; import { emailChannelService } from "./email-channels.js"; import { emailConnectionService } from "./email-connections.js"; import { grantConnectionAgentTools } from "./connection-agent-access.js"; @@ -1035,7 +1036,7 @@ export function connectionIntentService(db: Db) { } const binding = options.validatedAdoption.binding; if (binding.provider !== payload.serviceSlug || binding.mode !== "responsible_user") throw conflict("Invalid legacy adoption binding"); - const updated = await agentService(txDb).update(agent.id, { + const updated = await updateAgentConfigurationInTransaction(txDb, agent.id, { runtimeConfig: { ...agent.runtimeConfig, aiConnection: binding }, }, { recordRevision: { createdByUserId: userId, source: "patch" } }); if (!updated) throw notFound("Agent not found"); diff --git a/server/src/services/dot-invitations.ts b/server/src/services/dot-invitations.ts index 975e7b0bc40..735b9e669fe 100644 --- a/server/src/services/dot-invitations.ts +++ b/server/src/services/dot-invitations.ts @@ -1,6 +1,8 @@ import { and, desc, eq, isNull, ne, sql } from "drizzle-orm"; import { activityLog, agents, companies, dotAgentBindings, type Db } from "@paperclipai/db"; import { agentService } from "./agents.js"; +import { createAgentLifecycle, scheduleAgentLifecycle } from "./agent-lifecycle.js"; +import { withDedicatedDbConnection } from "@paperclipai/db"; import { approvalService } from "./approvals.js"; import { accessService } from "./access.js"; import { agentInstructionsService } from "./agent-instructions.js"; @@ -11,21 +13,22 @@ import { notFound, unprocessable } from "../errors.js"; /** One unfinished invitation per operator/company. Only non-secret references are persisted. */ export function dotInvitationService(db: Db) { - async function pending(database: Db, companyId: string, operatorId: string) { + async function pending(database: Db, companyId: string, operatorId: string, recoverIncomplete = false) { const rows = await database.select({ agent: agents, binding: dotAgentBindings }) .from(agents).leftJoin(dotAgentBindings, and(eq(dotAgentBindings.agentId, agents.id), isNull(dotAgentBindings.revokedAt))) .where(and(eq(agents.companyId, companyId), ne(agents.status, "terminated"), eq(agents.adapterType, "paperclip_runner"), sql`${agents.adapterConfig}->>'provider' = 'openai_dot'`, - sql`exists (select 1 from ${activityLog} where ${activityLog.companyId} = ${agents.companyId} + sql`((${recoverIncomplete} and ${agents.metadata}->'dotInvitation'->>'operatorId' = ${operatorId} + and ${agents.lifecycleOperation}->>'responsibleUserId' = ${operatorId}) or exists (select 1 from ${activityLog} where ${activityLog.companyId} = ${agents.companyId} and ${activityLog.entityId} = ${agents.id}::text and ${activityLog.entityType} = 'agent' and ${activityLog.actorType} = 'user' and ${activityLog.actorId} = ${operatorId} - and ${activityLog.action} = 'agent.hire_created' and ${activityLog.details}->>'source' = 'dot-invitation')`)).orderBy(desc(agents.createdAt)); + and ${activityLog.action} = 'agent.hire_created' and ${activityLog.details}->>'source' = 'dot-invitation'))`)).orderBy(desc(agents.createdAt)); return rows.find(row => row.binding?.status !== "ready")?.agent ?? null; } - async function describe(agent: typeof agents.$inferSelect) { - const approval = await approvalService(db).findOpenHireApprovalForAgent(agent.companyId, agent.id); + async function describe(agent: Pick, database: Db = db) { + const approval = await approvalService(database).findOpenHireApprovalForAgent(agent.companyId, agent.id); return { agent: { id: agent.id, name: agent.name, status: agent.status }, approvalId: approval?.id ?? null, - binding: await dotRunnerBroker(db).bindingForAgent(agent.companyId, agent.id) }; + binding: await dotRunnerBroker(database).bindingForAgent(agent.companyId, agent.id) }; } return { async resume(companyId: string, operatorId: string) { @@ -34,16 +37,24 @@ export function dotInvitationService(db: Db) { }, async create(companyId: string, operatorId: string) { if (!await dotRunnerBroker(db).enabled()) throw unprocessable("Enable OpenAI Dot and Assistant connections (MCP) in experimental settings."); - const agent = await db.transaction(async tx => { - const database = tx as unknown as Db; + const database = db; + const lockKey = `paperclip:dot-invitation:${companyId}:${operatorId}`; + return withDedicatedDbConnection(db, lockDb => lockDb.transaction(async lock => { + await lock.execute(sql`select pg_advisory_xact_lock(hashtextextended(${lockKey}, 0))`); // SQL locking also serializes retries on different control-plane replicas. - const [company] = await tx.select().from(companies).where(eq(companies.id, companyId)).for("update"); + const [company] = await database.select().from(companies).where(eq(companies.id, companyId)); if (!company) throw notFound("Company not found"); if (company.status !== "active") throw unprocessable("Activate this company before inviting Dot."); - const existing = await pending(database, companyId, operatorId); - if (existing) return existing; + const existing = await pending(database, companyId, operatorId, true); + if (existing) { + const [completed] = await database.select({ id: activityLog.id }).from(activityLog).where(and( + eq(activityLog.companyId, companyId), eq(activityLog.entityId, existing.id), + eq(activityLog.action, "agent.hire_created"), eq(activityLog.actorId, operatorId), + sql`${activityLog.details}->>'source' = 'dot-invitation'`)).limit(1); + if (completed) return describe(existing, database); + } const svc = agentService(database); - let created = await svc.create(companyId, { + let created = existing ?? await createAgentLifecycle(database).requestHire(companyId, { name: "Dot", role: "general", adapterType: "paperclip_runner", adapterConfig: { provider: "openai_dot", lifecycleMode: "per_turn", allowUnmeteredProvider: true, dotWorkspaceAccess: false, dotAttachmentAccess: false }, @@ -54,25 +65,28 @@ export function dotInvitationService(db: Db) { const bundle = await agentInstructionsService(database).materializeManagedBundle(created, await loadDefaultAgentInstructionsBundle("default"), { entryFile: "AGENTS.md", replaceExisting: false }); created = (await svc.update(created.id, { adapterConfig: bundle.adapterConfig }, { allowPendingApprovalConfigUpdate: true }))!; - const access = accessService(database); - await access.ensureMembership(companyId, "agent", created.id, "member", "active"); - await access.setPrincipalPermission(companyId, "agent", created.id, "tasks:assign", true, operatorId); - const approval = company.requireBoardApprovalForNewAgents ? await approvalService(database).create(companyId, { - type: "hire_agent", status: "pending", requestedByUserId: operatorId, - payload: { agentId: created.id, name: created.name, role: created.role, adapterType: created.adapterType, - adapterConfig: created.adapterConfig, runtimeConfig: created.runtimeConfig, metadata: created.metadata, - budgetMonthlyCents: created.budgetMonthlyCents, requestedConfigurationSnapshot: { - adapterType: created.adapterType, runtimeConfig: created.runtimeConfig, adapterConfig: created.adapterConfig, - } }, - }) : null; - await logActivity(database, { companyId, actorType: "user", actorId: operatorId, action: "agent.hire_created", - entityType: "agent", entityId: created.id, details: { name: created.name, role: created.role, - requiresApproval: !!approval, approvalId: approval?.id ?? null, source: "dot-invitation" } }); - if (approval) await logActivity(database, { companyId, actorType: "user", actorId: operatorId, action: "approval.created", - entityType: "approval", entityId: approval.id, details: { type: "hire_agent", agentId: created.id } }); - return created; - }); - return describe(agent); + await database.transaction(async tx => { + const txDb = tx as unknown as Db; + const access = accessService(txDb); + await access.ensureMembership(companyId, "agent", created.id, "member", "active"); + await access.setPrincipalPermission(companyId, "agent", created.id, "tasks:assign", true, operatorId); + const approval = await approvalService(txDb).findOpenHireApprovalForAgent(companyId, created.id) ?? (company.requireBoardApprovalForNewAgents ? await approvalService(txDb).create(companyId, { + type: "hire_agent", status: "pending", requestedByUserId: operatorId, + payload: { agentId: created.id, name: created.name, role: created.role, adapterType: created.adapterType, + adapterConfig: created.adapterConfig, runtimeConfig: created.runtimeConfig, metadata: created.metadata, + budgetMonthlyCents: created.budgetMonthlyCents, requestedConfigurationSnapshot: { + adapterType: created.adapterType, runtimeConfig: created.runtimeConfig, adapterConfig: created.adapterConfig, + } }, + }) : null); + await logActivity(txDb, { companyId, actorType: "user", actorId: operatorId, action: "agent.hire_created", + entityType: "agent", entityId: created.id, details: { name: created.name, role: created.role, + requiresApproval: !!approval, approvalId: approval?.id ?? null, source: "dot-invitation" } }); + if (approval) await logActivity(txDb, { companyId, actorType: "user", actorId: operatorId, action: "approval.created", + entityType: "approval", entityId: approval.id, details: { type: "hire_agent", agentId: created.id } }); + }); + scheduleAgentLifecycle(db, created.id); + return describe(created, database); + })); }, }; } diff --git a/server/src/services/dot-runner-broker.ts b/server/src/services/dot-runner-broker.ts index a65107e51d5..9650cf3caf4 100644 --- a/server/src/services/dot-runner-broker.ts +++ b/server/src/services/dot-runner-broker.ts @@ -1,3 +1,4 @@ +import { updateAgentConfigurationInTransaction } from "./agent-configuration-transaction.js"; import { createHash, randomBytes, randomUUID } from "node:crypto"; import { and, asc, eq, gt, inArray, isNull, sql } from "drizzle-orm"; import { z } from "zod"; @@ -13,7 +14,7 @@ import type { PublicMcpToolExtension } from "./public-mcp/dot-runner.js"; import { boardAuthService } from "./board-auth.js"; import { logActivity } from "./activity-log.js"; import { authorizationService } from "./authorization.js"; -import { agentService } from "./agents.js"; +import { canConfigureAgentConnection } from "../modules/agent-lifecycle/index.js"; import { issueService } from "./issues.js"; import { instanceSettingsService } from "./instance-settings.js"; import { getNativeReviewAssignment, readNativeReviewAssignmentContext } from "./native-runtime/native-review-participant.js"; @@ -43,7 +44,9 @@ function createBroker(db: Db) { const [agent] = await db.select().from(agents).where(and(eq(agents.id, binding.agentId), eq(agents.companyId, binding.companyId))); const access = grant ? await boardAuthService(db).resolveBoardAccess(grant.userId) : null; const membership = access?.memberships.find(m => m.companyId === binding.companyId && m.status === "active"); - if (!access?.user || !membership || membership.membershipRole === "viewer" || !grant || grant.agentId !== binding.agentId || !agent || ["terminated", "pending_approval", ...(allowPaused ? [] : ["paused"])].includes(agent.status)) throw fail("Agent connection authority is unavailable."); + if (!access?.user || !membership || membership.membershipRole === "viewer" || !grant || grant.agentId !== binding.agentId || !agent + || ["terminated", "pending_approval"].includes(agent.status) + || (!allowPaused && (requireReady ? agent.status === "paused" : !canConfigureAgentConnection(agent)))) throw fail("Agent connection authority is unavailable."); return binding; } @@ -115,7 +118,7 @@ function createBroker(db: Db) { const code = randomBytes(24).toString("base64url"); const binding = await db.transaction(async tx => { const [agent] = await tx.select().from(agents).where(and(eq(agents.id, input.agentId), eq(agents.companyId, input.companyId))).for("update"); - if (!agent || agent.adapterType !== "paperclip_runner" || agent.adapterConfig.provider !== "openai_dot" || ["pending_approval", "terminated", "paused"].includes(agent.status)) throw fail("Choose an approved Paperclip Runner agent."); + if (!agent || agent.adapterType !== "paperclip_runner" || agent.adapterConfig.provider !== "openai_dot" || !canConfigureAgentConnection(agent)) throw fail("Choose an approved Paperclip Runner agent."); const [existing] = await tx.select().from(bindings).where(and(eq(bindings.companyId, input.companyId), eq(bindings.agentId, input.agentId), isNull(bindings.revokedAt))); if (existing) { if (existing.id !== input.replaceBindingId || existing.status !== "pairing" || existing.operatorId !== input.operatorId) { @@ -143,10 +146,10 @@ function createBroker(db: Db) { if (!b || b.status !== "pairing" || !b.pairingExpiresAt || b.pairingExpiresAt <= new Date()) throw fail("Pairing code expired or was consumed."); const [agent] = await tx.select().from(agents).where(and(eq(agents.id, b.agentId), eq(agents.companyId, b.companyId))).for("update"); const [grant] = await tx.select().from(mcpOauthGrants).where(and(eq(mcpOauthGrants.id, principal.grant.id), isNull(mcpOauthGrants.revokedAt))).for("update"); - if (!grant || grant.agentId || !agent || ["paused", "terminated", "pending_approval"].includes(agent.status)) throw fail("Pairing authority is unavailable."); + if (!grant || grant.agentId || !agent || !canConfigureAgentConnection(agent)) throw fail("Pairing authority is unavailable."); await tx.update(bindings).set({ grantId: grant.id, status: "connected", pairingCodeHash: null, pairingExpiresAt: null, updatedAt: new Date() }).where(eq(bindings.id, b.id)); await tx.update(mcpOauthGrants).set({ agentId: b.agentId }).where(eq(mcpOauthGrants.id, grant.id)); - await agentService(tx as unknown as Db).update(agent.id, { adapterConfig: { ...agent.adapterConfig, dotBindingId: b.id } }, + await updateAgentConfigurationInTransaction(tx as unknown as Db, agent.id, { adapterConfig: { ...agent.adapterConfig, dotBindingId: b.id } }, { recordRevision: { createdByUserId: b.operatorId, source: "dot-pairing" } }); await logActivity(tx as unknown as Db, { companyId: b.companyId, actorType: "user", actorId: b.operatorId, action: "dot.paired", entityType: "agent", entityId: b.agentId, details: { bindingId: b.id, generation: b.generation } }); @@ -197,9 +200,10 @@ function createBroker(db: Db) { const [agent] = await tx.select().from(agents).where(eq(agents.id, b.agentId)); if (!agent || ["terminated", "pending_approval"].includes(agent.status)) throw fail("Agent connection authority is unavailable."); const paused = agent.status === "paused"; + const visibleKinds: Array = canConfigureAgentConnection(agent) ? ["authority_revoked", "readiness_challenge"] : ["authority_revoked"]; const items = await tx.select().from(mailbox).where(and(eq(mailbox.companyId, b.companyId), eq(mailbox.bindingId, b.id), - eq(mailbox.bindingGeneration, b.generation), gt(mailbox.id, after), paused ? eq(mailbox.kind, "authority_revoked") : undefined)).orderBy(asc(mailbox.id)).limit(50); - // Paused reads expose fences only and never consume hidden task items. + eq(mailbox.bindingGeneration, b.generation), gt(mailbox.id, after), paused ? inArray(mailbox.kind, visibleKinds) : undefined)).orderBy(asc(mailbox.id)).limit(50); + // Setup reads expose challenges and fences without consuming hidden work. return { bindingId: b.id, generation: b.generation, items, nextCursor: paused ? after : items.at(-1)?.id ?? after }; }); }, @@ -256,7 +260,7 @@ function createBroker(db: Db) { const access = await boardAuthService(db).resolveBoardAccess(b.operatorId); return { companyId: b.companyId, agentId: b.agentId, agentName: agent!.name, responsibleUser: access.user ? { id: access.user.id, name: access.user.name } : null, - permissions: agent!.permissions, ready: state?.status === "ready" && state.subscriptionVerified, + permissions: agent!.permissions, ready: agent!.lifecycleState === "ready" && state?.status === "ready" && state.subscriptionVerified, assignment: state?.assignment ?? null, idle: { read: ["paperclip_dot_capabilities", "paperclip_dot_tasks", "paperclip_dot_inbox"], profile: "paperclip_dot_set_avatar", @@ -429,7 +433,7 @@ function createBroker(db: Db) { const [agent] = await tx.select().from(agents).where(and(eq(agents.id, agentId), eq(agents.companyId, companyId))).for("update"); if (agent?.adapterConfig.dotBindingId === b.id) { const { dotBindingId: _removed, ...adapterConfig } = agent.adapterConfig; - await agentService(tx as unknown as Db).update(agentId, { adapterConfig }, + await updateAgentConfigurationInTransaction(tx as unknown as Db, agentId, { adapterConfig }, { recordRevision: { createdByUserId: operatorId, source: "dot-revoke" } }); } await tx.update(assignments).set({ status: "fenced" }).where(and(eq(assignments.bindingId, b.id), inArray(assignments.status, ["offered", "accepted"]))); diff --git a/server/src/services/environment-runtime.ts b/server/src/services/environment-runtime.ts index e0cd734df47..06816cbd2c9 100644 --- a/server/src/services/environment-runtime.ts +++ b/server/src/services/environment-runtime.ts @@ -4043,7 +4043,10 @@ export function environmentRuntimeService( and( eq(environmentLeases.heartbeatRunId, heartbeatRunId), or(eq(environmentLeases.status, "active"), and(eq(environmentLeases.status, "pending_cleanup"), - sql`(${environmentLeases.metadata} ? 'nativeWorkspaceExportResume' or ${environmentLeases.metadata} ? 'sandboxStopAndRetain')`)), + sql`(${environmentLeases.metadata} ? 'nativeWorkspaceExportResume' or ${environmentLeases.metadata} ? 'sandboxStopAndRetain')`), + providerResourceDisposition === "destroy" + ? and(eq(environmentLeases.status, "retained"), eq(environmentLeases.cleanupStatus, "failed")) + : undefined), ), ); if (leaseRows.length === 0) { diff --git a/server/src/services/environment-selection.ts b/server/src/services/environment-selection.ts new file mode 100644 index 00000000000..eba3d8772c3 --- /dev/null +++ b/server/src/services/environment-selection.ts @@ -0,0 +1,52 @@ +import { unprocessable } from "../errors.js"; + +export async function assertEnvironmentSelectionForCompany( + environmentsSvc: { + getById(environmentId: string): Promise<{ + id: string; + driver: string; + status?: string | null; + config: Record | null; + } | null>; + }, + _companyId: string, + environmentId: string | null | undefined, + options?: { + allowedDrivers?: string[]; + allowedSandboxProviders?: string[]; + }, +) { + if (environmentId === undefined || environmentId === null) return; + const environment = await environmentsSvc.getById(environmentId); + if (!environment) { + throw unprocessable("Environment not found."); + } + if (environment.status === "archived") { + throw unprocessable("Environment is archived."); + } + if (options?.allowedDrivers && !options.allowedDrivers.includes(environment.driver)) { + throw unprocessable( + `Environment driver "${environment.driver}" is not allowed here. Allowed drivers: ${options.allowedDrivers.join(", ")}`, + ); + } + if (environment.driver === "sandbox") { + const config = environment.config && typeof environment.config === "object" + ? environment.config as Record + : {}; + const provider = typeof config.provider === "string" ? config.provider : ""; + if (provider === "fake") { + throw unprocessable( + `Environment sandbox provider "${provider}" is not allowed here. The built-in fake provider is probe-only and cannot execute runs.`, + ); + } + if ( + options?.allowedSandboxProviders + && options.allowedSandboxProviders.length > 0 + && !options.allowedSandboxProviders.includes(provider) + ) { + throw unprocessable( + `Environment sandbox provider "${provider || "unknown"}" is not allowed here. Allowed providers: ${options.allowedSandboxProviders.join(", ")}`, + ); + } + } +} diff --git a/server/src/services/execution-control-reconciliation.ts b/server/src/services/execution-control-reconciliation.ts index c278f8408b5..b2a0d488dca 100644 --- a/server/src/services/execution-control-reconciliation.ts +++ b/server/src/services/execution-control-reconciliation.ts @@ -200,6 +200,7 @@ export async function reconcileAbandonedExecutionControl( eq(agents.id, run.agentId), eq(agents.companyId, run.companyId), eq(agents.status, "running"), + eq(agents.lifecycleState, "ready"), sql`not exists (select 1 from ${heartbeatRuns} where ${heartbeatRuns.agentId} = ${run.agentId} and ${heartbeatRuns.status} = 'running')`, ), ); diff --git a/server/src/services/heartbeat.ts b/server/src/services/heartbeat.ts index 616cdcdeabf..7a0c1436c8d 100644 --- a/server/src/services/heartbeat.ts +++ b/server/src/services/heartbeat.ts @@ -1,3 +1,4 @@ +import { agentExecutionsHaveStopped } from "./agent-execution-stop.js"; import { cancelHeartbeatNativeRun, terminateHeartbeatRunProcess, @@ -412,6 +413,7 @@ import { completionContracts, heartbeatRunEvents, heartbeatRuns, + environmentLeases, issueComments, issues, nativeRunFinalizations, @@ -3047,7 +3049,7 @@ export function heartbeatService( lastHeartbeatAt: new Date(), updatedAt: new Date(), }) - .where(eq(agents.id, agentId)) + .where(and(eq(agents.id, agentId), eq(agents.lifecycleState, "ready"))) .returning() .then((rows) => rows[0] ?? null); @@ -6514,6 +6516,7 @@ export function heartbeatService( and( eq(agents.id, agent.id), notInArray(agents.status, [...DIRECT_NON_INVOKABLE_STATUSES]), + eq(agents.lifecycleState, "ready"), ), ) .returning() @@ -10125,6 +10128,13 @@ export function heartbeatService( ${JSON.stringify({ startupPreparationSettledAt: new Date().toISOString() })}::jsonb`, }).where(and(eq(heartbeatRuns.id, run.id), eq(heartbeatRuns.status, "cancelled"))); } + await db.update(heartbeatRuns).set({ + executionStage: sql`case when ${heartbeatRuns.status} = 'cancelled' then 'settled' else ${heartbeatRuns.executionStage} end`, + controllerLeaseExpiresAt: null, + }).where(and(eq(heartbeatRuns.id, run.id), eq(heartbeatRuns.runtimeMode, "legacy"), + eq(heartbeatRuns.controllerBootId, legacyControllerBootId), + inArray(heartbeatRuns.status, ["succeeded", "failed", "cancelled", "timed_out", "interrupted"]))); + } finally { controllerLease.stop(); activeRunExecutions.delete(run.id); @@ -10180,7 +10190,30 @@ export function heartbeatService( } } + async function stopInvocationsForAgents(agentIds: string[], reason: string) { + await cancelInvocationsForAgentsInternal(agentIds, reason); + const runs = await db.select().from(heartbeatRuns).where(inArray(heartbeatRuns.agentId, agentIds)); + const leasesToRelease = await db.select({ runId: environmentLeases.heartbeatRunId }).from(environmentLeases) + .innerJoin(heartbeatRuns, eq(heartbeatRuns.id, environmentLeases.heartbeatRunId)) + .where(and(inArray(heartbeatRuns.agentId, agentIds), + or(and(eq(heartbeatRuns.status, "cancelled"), inArray(environmentLeases.status, ["active", "pending_cleanup"])), + and(eq(environmentLeases.status, "retained"), eq(environmentLeases.cleanupStatus, "failed"))))); + const needsRelease = new Set(leasesToRelease.map(lease => lease.runId)); + for (const run of runs) { + if (!isHeartbeatRunTerminalStatus(run.status) || liveRunExecutions.has(run.id) || + adapterExecutionControls.has(run.id) || processRunCancellationSettlements.has(run.id) || + (run.controllerLeaseExpiresAt && run.controllerLeaseExpiresAt > new Date())) return false; + if (needsRelease.has(run.id)) { + // Retry incomplete cleanup after a run becomes terminal. + await releaseEnvironmentLeasesForRun({ runId: run.id, companyId: run.companyId, + agentId: run.agentId, status: run.status, providerResourceDisposition: "destroy" }); + } + } + return agentExecutionsHaveStopped(db, agentIds); + } + return { + stopInvocationsForAgents, waitForRunExecutionDrain: async ( runId: string, options: { timeoutMs?: number; intervalMs?: number } = {}, diff --git a/server/src/services/heartbeat/queue.ts b/server/src/services/heartbeat/queue.ts index 04e51012bfe..9332de44376 100644 --- a/server/src/services/heartbeat/queue.ts +++ b/server/src/services/heartbeat/queue.ts @@ -1,3 +1,4 @@ +import { isAgentAwaitingSetup } from "../../modules/agent-lifecycle/index.js"; import { normalizeAgentNameKey } from "./retries.js"; import { type WakeupOptions, @@ -941,6 +942,8 @@ export function createHeartbeatQueue(db: Db, dependencies: HeartbeatQueueDepende ); return null; } + // Keep accepted work in the durable queue until setup completes. + if (isAgentAwaitingSetup(agent)) return null; const invokability = companyAgents ? evaluateAgentInvokability(toAgentOrgRow(agent), companyAgents) : await getAgentInvokability(agent); @@ -1862,6 +1865,7 @@ export function createHeartbeatQueue(db: Db, dependencies: HeartbeatQueueDepende // Cancelled after the start lock is released: cancelRunInternal promotes the // agent's next queued run, which takes this same lock. const rejectedClaims: Array<{ run: typeof heartbeatRuns.$inferSelect; err: HttpError }> = []; + let cancellationReason: string | undefined; return withAgentStartLock(agentId, async () => { const agent = await getAgent(agentId); @@ -1869,10 +1873,7 @@ export function createHeartbeatQueue(db: Db, dependencies: HeartbeatQueueDepende const invokability = await getAgentInvokability(agent); if (!invokability.invokable) { if (shouldCancelRunsForNonInvokableAgent(invokability)) { - await cancelActiveForAgentInternal( - agentId, - `Cancelled because the agent is not invokable: ${invokability.reason}`, - ); + cancellationReason = `Cancelled because the agent is not invokable: ${invokability.reason}`; } return []; } @@ -2011,7 +2012,10 @@ export function createHeartbeatQueue(db: Db, dependencies: HeartbeatQueueDepende }); } return claimedRuns; - }).finally(() => cancelRejectedQueuedRuns(rejectedClaims)); + }).finally(async () => { + if (cancellationReason) await cancelActiveForAgentInternal(agentId, cancellationReason); + await cancelRejectedQueuedRuns(rejectedClaims); + }); } // Public wakeup entry point. Callers dispatch it fire-and-forget, so register @@ -2501,7 +2505,8 @@ export function createHeartbeatQueue(db: Db, dependencies: HeartbeatQueueDepende }); } - const invokability = await getAgentInvokability(agent); + // Setup delays execution, but must not discard work accepted by a caller. + const invokability = await getAgentInvokability(isAgentAwaitingSetup(agent) ? { ...agent, status: "idle" } : agent); if (!invokability.invokable) { if (opts.requestedByActorType !== "user" || executionWaitRequestId) { await writeSkippedRequest("agent.not_invokable", { diff --git a/server/src/services/heartbeat/run-control.test.ts b/server/src/services/heartbeat/run-control.test.ts index 7af48aeee59..0234f326f48 100644 --- a/server/src/services/heartbeat/run-control.test.ts +++ b/server/src/services/heartbeat/run-control.test.ts @@ -271,7 +271,6 @@ describe.skipIf(!support.supported)("heartbeat run-control database wiring", () expect(await createHeartbeatRunControl(db, deps).cancelInvocationsForAgentsInternal([agent.id, "", agent.id], "pause")).toEqual({ agentIds: [agent.id], runsCancelled: 0, wakeupsCancelled: 2 }); const persisted = await db.select().from(agentWakeupRequests); expect(wakes.map(wake => persisted.find(row => row.id === wake.id)?.status)).toEqual(["cancelled", "cancelled", "claimed", "queued", "queued"]); - expect(deps.getAgent).toHaveBeenCalledTimes(1); }); it("rechecks stale budget enforcement before cancelling runs or queued wakes", async () => { diff --git a/server/src/services/heartbeat/run-control.ts b/server/src/services/heartbeat/run-control.ts index dd3f9d8dc3c..81a593a63dc 100644 --- a/server/src/services/heartbeat/run-control.ts +++ b/server/src/services/heartbeat/run-control.ts @@ -1195,7 +1195,6 @@ export function createHeartbeatRunControl(db: Db, dependencies: HeartbeatRunCont reason = "Cancelled due to agent pause", errorCode = "cancelled", ) { - const agent = await getAgent(agentId); const runs = await db .select() .from(heartbeatRuns) @@ -1206,65 +1205,7 @@ export function createHeartbeatRunControl(db: Db, dependencies: HeartbeatRunCont ), ); - for (const run of runs) { - const stopOwnership = - run.runtimeMode !== "native" - ? captureAdapterStopOwnership(run.id) - : undefined; - try { - if (stopOwnership?.control) { - await cancelRunInternal(run.id, reason, { errorCode }); - continue; - } - if (run.runtimeMode === "native") { - await db.update(heartbeatRuns).set({ resultJson: - sql`coalesce(${heartbeatRuns.resultJson}, '{}'::jsonb) || ${JSON.stringify({ cancellation: requestedRunCancellation({}, reason) })}::jsonb`, - }).where(and(eq(heartbeatRuns.id, run.id), eq(heartbeatRuns.status, run.status))); - await cancelHeartbeatNativeRun({ - db, - runId: run.id, - reason, - runtimeMode: run.runtimeMode, - }); - } - const persistedCancellationResult = - run.runtimeMode === "native" - ? await getRun(run.id).then((current) => - parseObject(current?.resultJson), - ) - : parseObject(run.resultJson); - await setRunStatus(run.id, "cancelled", { - finishedAt: new Date(), - error: reason, - errorCode, - resultJson: { - ...persistedCancellationResult, - ...(agent ? mergeRunStopMetadataForAgent(agent, "cancelled", { - resultJson: persistedCancellationResult, errorCode, errorMessage: reason, - }) : {}), - cancellation: readRunCancellation(persistedCancellationResult) ?? requestedRunCancellation({}, reason), - }, - }); - - await setWakeupStatus(run.wakeupRequestId, "cancelled", { - finishedAt: new Date(), - error: reason, - }); - - const running = runningProcesses.get(run.id); - if (running) { - await terminateHeartbeatRunProcess({ - pid: running.child.pid, - processGroupId: running.processGroupId, - graceMs: Math.max(1, running.graceSec) * 1000, - }); - } - runningProcesses.delete(run.id); - await releaseIssueExecutionAndPromote(run); - } finally { - stopOwnership?.release(); - } - } + for (const run of runs) await cancelRunInternal(run.id, reason, { errorCode }); return runs.length; } diff --git a/server/src/services/invite-grants.ts b/server/src/services/invite-grants.ts index b2141e09305..2f41ea9003b 100644 --- a/server/src/services/invite-grants.ts +++ b/server/src/services/invite-grants.ts @@ -1,6 +1,6 @@ import { PERMISSION_KEYS } from "@paperclipai/shared"; import type { HumanCompanyMembershipRole } from "@paperclipai/shared"; -import { NEW_STANDARD_AGENT_DEFAULT_GRANT_KEYS, newStandardAgentGrantScope } from "./agent-permissions.js"; +import { NEW_STANDARD_AGENT_DEFAULT_GRANT_KEYS, newStandardAgentGrantScope } from "../lib/agent-permissions.js"; import { grantsForHumanRole } from "./company-member-roles.js"; export function grantsFromDefaults( diff --git a/server/src/services/onboarding-seed.ts b/server/src/services/onboarding-seed.ts index 92399bef344..9aff67f47f9 100644 --- a/server/src/services/onboarding-seed.ts +++ b/server/src/services/onboarding-seed.ts @@ -5,11 +5,13 @@ import type { ApplyOnboardingSeed } from "@paperclipai/shared"; import { writePaperclipSkillSyncPreference } from "@paperclipai/adapter-utils/server-utils"; import { findActiveServerAdapter } from "../adapters/registry.js"; import { agentService } from "./agents.js"; +import { createAgentLifecycle, scheduleAgentLifecycle } from "./agent-lifecycle.js"; +import { withDedicatedDbConnection } from "@paperclipai/db"; import { PAPERCLIP_CORE_SKILL_KEYS } from "./company-skills.js"; import { goalService } from "./goals.js"; import { projectService } from "./projects.js"; import { issueService } from "./issues.js"; -import { readBuiltInAgentMarker } from "./built-in-agent-metadata.js"; +import { readBuiltInAgentMarker } from "../lib/built-in-agent-metadata.js"; import { logActivity, publishActivity, type ActivityPublication } from "./activity-log.js"; /** @@ -179,19 +181,45 @@ export function onboardingSeedService(db: Db) { return created.id; } - /** - * The seed application proper, run inside the per-company transaction the - * public `apply` opens. Every read and write goes through `dbx` — the locked - * transaction — so it is serialized against a concurrent push for the same - * company. Services are reconstructed on `dbx` for the same reason. - */ + async function prepareAgent(dbx: Db, companyId: string, seed: ApplyOnboardingSeed, audit?: OnboardingSeedAuditActor) { + const existing = await readRecord(dbx, companyId); + if (existing?.revision === seed.revision) return existing.agentId; + const agentSvc = agentService(dbx); + const agentName = seed.agent?.name.trim() || null; + const agentRole = seed.agent?.role?.trim() || null; + // 2. Agent → the customer's first hire, the lead the first task is + // assigned to. + let agentId = await resolveTargetAgentId(dbx, companyId, existing?.agentId ?? null); + if (agentName) { + if (agentId) { + await agentSvc.update(agentId, { name: agentName, title: agentRole }); + } else { + const adapterType = seededAgentAdapterType(); + const created = await createAgentLifecycle(dbx).requestHire(companyId, { + name: agentName, + role: SEEDED_AGENT_ROLE, + title: agentRole, + adapterType, + adapterConfig: seededAgentAdapterConfig(adapterType), + runtimeConfig: {}, + permissions: {}, + status: "idle", + spentMonthlyCents: 0, + lastHeartbeatAt: null, + }, { createdByUserId: audit?.actorType === "user" ? audit.actorId : null }); + agentId = created.id; + } + } + + return agentId; + } + async function applyWithin( dbx: Db, companyId: string, seed: ApplyOnboardingSeed, - audit?: OnboardingSeedAuditActor, + preparedAgentId: string | null, ): Promise { - const agentSvc = agentService(dbx); const goalSvc = goalService(dbx); const projectSvc = projectService(dbx); const issueSvc = issueService(dbx); @@ -237,48 +265,9 @@ export function onboardingSeedService(db: Db) { } } - // 2. Agent → the customer's first hire, the lead the first task is - // assigned to. - let agentId = await resolveTargetAgentId(dbx, companyId, existing?.agentId ?? null); - if (agentName) { - if (agentId) { - await agentSvc.update(agentId, { name: agentName, title: agentRole }); - } else { - const adapterType = seededAgentAdapterType(); - const created = await agentSvc.create(companyId, { - name: agentName, - role: SEEDED_AGENT_ROLE, - title: agentRole, - adapterType, - adapterConfig: seededAgentAdapterConfig(adapterType), - runtimeConfig: {}, - permissions: {}, - status: "idle", - spentMonthlyCents: 0, - lastHeartbeatAt: null, - }, { createdByUserId: audit?.actorType === "user" ? audit.actorId : null }); - agentId = created.id; - } - } + const agentId = preparedAgentId; - // 3. First task → an issue in the Onboarding project, assigned to the - // lead so the dashboard opens with work on it. - // - // No-first-task contract (PAP-67 r17.4): on the Cloud walk this branch - // never runs. The seed Cloud sends is mission-only — `agent` and - // `firstTask` are unpopulated by the signup wizard and a paperclip-cloud - // `node:test` in `src/onboarding/` pins that — so `firstTaskTitle` is - // null here and the first task stays owned by the tenant's own - // server-owned onboarding path (`POST /issues` with - // `onboardingFirstTask: true`). That path is the only one that stamps - // `ONBOARDING_FIRST_TASK_ORIGIN_KIND` and races safely on the partial - // unique index `issues_onboarding_first_task_uq`. If this receiver ever - // created the first task on the cloud walk it would produce a *second*, - // unstamped one: no agent-authored greeting, the brief rendered as a - // right-aligned user bubble, and two onboarding tasks — silently, - // because the uq index only guards origin-stamped rows. The branch is - // retained for the endpoint's documented body contract, but the - // mission-only seed is what keeps it inert on the cloud path. + // A mission-only seed leaves the first task to the onboarding route. let issueId = existing?.issueId ?? null; if (firstTaskTitle) { if (await issueStillExists(dbx, companyId, issueId)) { @@ -357,38 +346,8 @@ export function onboardingSeedService(db: Db) { return { revision: seed.revision, changed: true, goalId, agentId, issueId }; } - /** - * Apply an onboarding seed to a company. - * - * Idempotent per `revision`: a replay of the revision already stored is a - * no-op that still reports success, because Cloud reads any 2xx as "the - * tenant holds this content" and retries otherwise. A *different* revision - * (the customer edited their answers in Cloud) updates the goal, agent and - * task this seed previously created rather than creating a second set. - * - * Every write happens before the caller responds — Cloud records the applied - * revision only on a 2xx, and the redirect into the tenant dashboard is - * gated on it, so a partially-applied seed must surface as a failure rather - * than as an acknowledged one. - * - * Concurrency: Cloud's reconcile runs off portfolio fetches, which can - * overlap, so two pushes for the same company can arrive at once. Both would - * otherwise pass the revision check before either wrote the seed record and - * each create a company goal, a lead agent and an Onboarding project. A - * per-company advisory lock held for the transaction serializes them — the - * same idiom `folders` and `decision-queues` use — so the second push sees - * the first push's writes (the record, the reused goal/agent/project) and - * updates in place instead of duplicating. - * - * Auditing: when `audit` is supplied and the push changed anything, the - * `company.onboarding_seed_applied` entry is written *inside* this same - * transaction. That is the only arrangement in which the entry cannot go - * permanently missing. Logging after the commit forces a choice between two - * broken outcomes — answer 500 and the retry returns `changed: false` and - * never logs, or answer 200 and Cloud stops retrying while the entry stays - * absent. Writing it transactionally removes the choice: either both land, or - * neither does and the retry re-applies from a clean slate. - */ + // Hire first. If the content transaction fails, a retry reuses the committed agent. + // The dedicated transaction holds only the workflow lock, not the hire writes. async function apply( companyId: string, seed: ApplyOnboardingSeed, @@ -400,42 +359,46 @@ export function onboardingSeedService(db: Db) { // late. const publications: ActivityPublication[] = []; - const result = await db.transaction(async (tx) => { - await tx.execute( - sql`select pg_advisory_xact_lock(hashtextextended(${`paperclip:onboarding-seed:${companyId}`}, 0))`, - ); - const dbx = tx as unknown as Db; - const applied = await applyWithin(dbx, companyId, seed, audit); + const database = db; + const lockKey = `paperclip:onboarding-seed:${companyId}`; + return withDedicatedDbConnection(db, lockDb => lockDb.transaction(async lock => { + await lock.execute(sql`select pg_advisory_xact_lock(hashtextextended(${lockKey}, 0))`); + const preparedAgentId = await prepareAgent(database, companyId, seed, audit); + const result = await database.transaction(async (tx) => { + const dbx = tx as unknown as Db; + const applied = await applyWithin(dbx, companyId, seed, preparedAgentId); - if (applied.changed && audit) { - await logActivity( - dbx, - { - companyId, - actorType: audit.actorType, - actorId: audit.actorId, - agentId: audit.agentId, - runId: audit.runId, - agentApiKeyId: audit.agentApiKeyId, - action: "company.onboarding_seed_applied", - entityType: "company", - entityId: companyId, - details: { - revision: applied.revision, - goalId: applied.goalId, - agentId: applied.agentId, - issueId: applied.issueId, + if (applied.changed && audit) { + await logActivity( + dbx, + { + companyId, + actorType: audit.actorType, + actorId: audit.actorId, + agentId: audit.agentId, + runId: audit.runId, + agentApiKeyId: audit.agentApiKeyId, + action: "company.onboarding_seed_applied", + entityType: "company", + entityId: companyId, + details: { + revision: applied.revision, + goalId: applied.goalId, + agentId: applied.agentId, + issueId: applied.issueId, + }, }, - }, - publications, - ); - } + publications, + ); + } - return applied; - }); + return applied; + }); - for (const publication of publications) publishActivity(publication); - return result; + for (const publication of publications) publishActivity(publication); + if (result.agentId) scheduleAgentLifecycle(db, result.agentId); + return result; + })); } return { apply, get: (companyId: string) => readRecord(db, companyId) }; diff --git a/server/src/services/plugin-host-services.ts b/server/src/services/plugin-host-services.ts index d6213fb8b37..1c592fb4cb7 100644 --- a/server/src/services/plugin-host-services.ts +++ b/server/src/services/plugin-host-services.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "./agent-lifecycle.js"; import type { Db } from "@paperclipai/db"; import { activityLog, @@ -719,6 +720,7 @@ export function buildHostServices( const secretsHandler = createPluginSecretsHandler({ db, pluginId }); const companies = companyService(db); const agents = agentService(db); + const agentsLifecycle = createAgentLifecycle(db); const managedAgents = pluginManagedAgentService(db, { pluginId, pluginKey, @@ -3013,14 +3015,14 @@ export function buildHostServices( await ensurePluginAvailableForCompany(companyId); const agent = await agents.getById(params.agentId); requireInCompany("Agent", agent, companyId); - return (await agents.pause(params.agentId)) as Agent; + return (await agentsLifecycle.pauseAgent(params.agentId)) as Agent; }, async resume(params) { const companyId = ensureCompanyId(params.companyId); await ensurePluginAvailableForCompany(companyId); const agent = await agents.getById(params.agentId); requireInCompany("Agent", agent, companyId); - return (await agents.resume(params.agentId)) as Agent; + return (await agentsLifecycle.resumeAgent(params.agentId)) as Agent; }, async invoke(params) { const companyId = ensureCompanyId(params.companyId); diff --git a/server/src/services/plugin-managed-agents.ts b/server/src/services/plugin-managed-agents.ts index 4c4e2ee1aeb..39ca9fd3b09 100644 --- a/server/src/services/plugin-managed-agents.ts +++ b/server/src/services/plugin-managed-agents.ts @@ -1,3 +1,4 @@ +import { createAgentLifecycle } from "./agent-lifecycle.js"; import { and, eq, isNull, ne } from "drizzle-orm"; import type { Db } from "@paperclipai/db"; import { @@ -183,6 +184,7 @@ export function pluginManagedAgentService( options: PluginManagedAgentServiceOptions, ) { const agentSvc = agentService(db); + const agentSvcLifecycle = createAgentLifecycle(db); const approvalSvc = approvalService(db); const instructions = agentInstructionsService(db); @@ -486,7 +488,7 @@ export function pluginManagedAgentService( const requiresApproval = company.requireBoardApprovalForNewAgents; const adapterType = await resolveManagedAdapterType(companyId, declaration); const initialStatus = requiresApproval ? "pending_approval" : declaration.status ?? "idle"; - let created = await agentSvc.create(companyId, { + let created = await agentSvcLifecycle.requestHire(companyId, { ...declarationPatch(declaration, { adapterType }), status: initialStatus, pauseReason: initialStatus === "paused" ? managedAgentPauseReason(options.pluginKey) : null, @@ -569,26 +571,13 @@ export function pluginManagedAgentService( ) { if ( declaration.status !== "paused" - || agent.status !== "paused" + || agent.lifecycleState !== "paused" || agent.pauseReason !== null ) { return agent; } - const updated = await db - .update(agents) - .set({ - pauseReason: managedAgentPauseReason(options.pluginKey), - updatedAt: new Date(), - }) - .where(and( - eq(agents.id, agent.id), - eq(agents.companyId, companyId), - eq(agents.status, "paused"), - isNull(agents.pauseReason), - )) - .returning({ id: agents.id }) - .then((rows) => rows[0] ?? null); + const updated = await agentSvcLifecycle.pauseAgent(agent.id, managedAgentPauseReason(options.pluginKey)); if (!updated) { const current = await agentSvc.getById(agent.id) as Agent | null; diff --git a/server/src/services/public-mcp/oauth.ts b/server/src/services/public-mcp/oauth.ts index ec878f35a41..16d5e881813 100644 --- a/server/src/services/public-mcp/oauth.ts +++ b/server/src/services/public-mcp/oauth.ts @@ -1,5 +1,7 @@ +import { updateAgentConfigurationInTransaction } from "../agent-configuration-transaction.js"; import { instanceSettingsService } from "../instance-settings.js"; import { createHash, randomBytes } from "node:crypto"; +import { canConfigureAgentConnection } from "../../modules/agent-lifecycle/index.js"; import { and, eq, gt, inArray, isNull, lt, lte, notExists, sql } from "drizzle-orm"; import { z } from "zod"; import type { Request } from "express"; @@ -7,7 +9,6 @@ import { type Db, activityLog, agents, authUsers, companies, companyLogos, dotAgentBindings, mcpOauthClients, mcpOauthGrants, mcpOauthRequests, mcpOauthTokens, mcpOauthDeviceRequests, mcpOauthMetadataAdmissions, } from "@paperclipai/db"; import { DOT_RUNNER_MCP_PATH, DOT_RUNNER_MCP_SCOPES, PUBLIC_MCP_PATH, PUBLIC_MCP_SCOPES, type McpConnectionRequest, type McpDotPairingPreview } from "@paperclipai/shared"; -import { agentService } from "../agents.js"; import { boardAuthService } from "../board-auth.js"; import { logActivity } from "../activity-log.js"; import { createClientMetadataResolver, mcpRedirectMatches, validMcpRedirect as validRedirect, type MetadataFetch } from "./client-metadata.js"; @@ -274,7 +275,7 @@ export function createPublicMcpOAuth(db: Db, config: PublicMcpConfig, options: { if (!binding || binding.status !== "pairing" || binding.grantId || !binding.pairingExpiresAt || binding.pairingExpiresAt <= new Date()) throw invalidGrant(); if (request.requestedCompanyId && request.requestedCompanyId !== binding.companyId) throw invalidGrant(); const [agent] = await queryDb.select().from(agents).where(and(eq(agents.id, binding.agentId), eq(agents.companyId, binding.companyId))).for("update"); - if (!agent || agent.adapterType !== "paperclip_runner" || ["paused", "terminated", "pending_approval"].includes(agent.status)) throw invalidGrant(); + if (!agent || agent.adapterType !== "paperclip_runner" || !canConfigureAgentConnection(agent)) throw invalidGrant(); return { request, binding, agent }; } @@ -459,7 +460,7 @@ export function createPublicMcpOAuth(db: Db, config: PublicMcpConfig, options: { await tx.update(mcpOauthGrants).set({ agentId: binding.agentId }).where(eq(mcpOauthGrants.id, grant.id)); await tx.update(dotAgentBindings).set({ grantId: grant.id, status: "connected", pairingCodeHash: null, pairingExpiresAt: null, updatedAt: new Date() }).where(eq(dotAgentBindings.id, binding.id)); - await agentService(tx as unknown as Db).update(agent.id, { adapterConfig: { ...agent.adapterConfig, dotBindingId: binding.id } }, + await updateAgentConfigurationInTransaction(tx as unknown as Db, agent.id, { adapterConfig: { ...agent.adapterConfig, dotBindingId: binding.id } }, { recordRevision: { createdByUserId: binding.operatorId, source: "dot-pairing" } }); await logActivity(tx as unknown as Db, { companyId: binding.companyId, actorType: "user", actorId: binding.operatorId, action: "dot.paired", entityType: "agent", entityId: binding.agentId, diff --git a/server/src/services/recovery/service.ts b/server/src/services/recovery/service.ts index ff2de0c3362..d27f3e27175 100644 --- a/server/src/services/recovery/service.ts +++ b/server/src/services/recovery/service.ts @@ -1,3 +1,4 @@ +import { isAgentAwaitingSetup } from "../../modules/agent-lifecycle/index.js"; import { isAiAuthenticationBlocked } from "../ai-auth-failure.js"; import { hasCommittedNativePlanWait } from "../native-runtime/native-plan-wait.js"; import { isNativeWorkspaceExportRepairCause } from "@paperclipai/shared"; @@ -4494,6 +4495,10 @@ export function recoveryService( } const agent = await getAgent(agentId); + if (agent?.companyId === issue.companyId && isAgentAwaitingSetup(agent)) { + result.skipped += 1; + continue; + } const agentInvokable = agent && agent.companyId === issue.companyId ? await isAgentInvokable(agent) diff --git a/server/src/services/secret-proposals.ts b/server/src/services/secret-proposals.ts index f3b29ae862c..fbefd53d5fd 100644 --- a/server/src/services/secret-proposals.ts +++ b/server/src/services/secret-proposals.ts @@ -1,3 +1,4 @@ +import { updateAgentConfigurationInTransaction } from "./agent-configuration-transaction.js"; import { withAgentAppearance } from "@paperclipai/shared"; import { and, count, desc, eq, gte, inArray, lte, or, sql } from "drizzle-orm"; import type { Db } from "@paperclipai/db"; @@ -699,7 +700,7 @@ export function createSecretProposalsService(db: Db) { } adapterConfig[proposal.configPath] = binding; } - const updated = await agentSvc.update(target.id, { adapterConfig }, { + const updated = await updateAgentConfigurationInTransaction(txDb, target.id, { adapterConfig }, { recordRevision: { createdByUserId: resolvedByUserId, source: "patch" }, }); if (!updated) throw notFound("Target agent not found"); @@ -720,18 +721,22 @@ export function createSecretProposalsService(db: Db) { overrides?: { name?: string; description?: string | null; providerConfigId?: string | null }; assertCanResolve?: (proposal: Proposal, txDb: Db) => Promise; }) { - return db.transaction(async (tx) => { - const txDb = tx as unknown as Db; + const loadForApproval = async (txDb: Db) => { const proposal = await requirePending(companyId, proposalId, txDb, true); assertNotExpired(proposal); await input.assertCanResolve?.(proposal, txDb); await assertBindingSnapshotCurrent(proposal, txDb, true); + return proposal; + }; + const saved = await db.transaction(async (tx) => { + const txDb = tx as unknown as Db; + const proposal = await loadForApproval(txDb); if (proposal.kind === "secret") { const created = await applySecretApproval(txDb, proposal, input); - return markApproved(txDb, proposal, { + return { kind: "secret" as const, proposal: await markApproved(txDb, proposal, { resolvedByUserId: input.resolvedByUserId, createdSecretId: created.id, - }); + }) }; } let secretId = proposal.secretId; @@ -757,7 +762,15 @@ export function createSecretProposalsService(db: Db) { } } if (!secretId) throw conflict("Binding proposal has no approved secret"); - const liveSecret = await secretService(txDb).getById(secretId); + return { kind: "binding" as const, secretId }; + }); + if (saved.kind === "secret") return saved.proposal; + + // Keep the approved secret if applying its reference fails. + return db.transaction(async tx => { + const txDb = tx as unknown as Db; + const proposal = await loadForApproval(txDb); + const liveSecret = await secretService(txDb).getById(saved.secretId); if (!liveSecret || liveSecret.companyId !== companyId || liveSecret.status !== "active") { throw conflict("Binding proposal secret is not active"); } diff --git a/server/src/services/status-cards.ts b/server/src/services/status-cards.ts index 5a4c8ae6c19..4a7439b6aa5 100644 --- a/server/src/services/status-cards.ts +++ b/server/src/services/status-cards.ts @@ -21,7 +21,7 @@ import type { import { companySearchQuerySchema, STATUS_CARD_AGENT_MAX_CARDS } from "@paperclipai/shared"; import { conflict, forbidden, notFound, unprocessable } from "../errors.js"; import { logger } from "../middleware/logger.js"; -import { readBuiltInAgentMarker } from "./built-in-agent-metadata.js"; +import { readBuiltInAgentMarker } from "../lib/built-in-agent-metadata.js"; import { builtInAgentService } from "./built-in-agents.js"; import { companySearchService } from "./company-search.js"; import { issueService } from "./issues.js"; diff --git a/server/src/services/summary-slots.ts b/server/src/services/summary-slots.ts index 6f07b83872c..bb4ca9e9521 100644 --- a/server/src/services/summary-slots.ts +++ b/server/src/services/summary-slots.ts @@ -24,7 +24,7 @@ import { type WriteSummarySlotResponse, } from "@paperclipai/shared"; import { conflict, forbidden, notFound, unprocessable } from "../errors.js"; -import { readBuiltInAgentMarker } from "./built-in-agent-metadata.js"; +import { readBuiltInAgentMarker } from "../lib/built-in-agent-metadata.js"; import { builtInAgentService } from "./built-in-agents.js"; import { agentService } from "./agents.js"; import { issueService } from "./issues.js"; diff --git a/server/src/types/activity-publication.ts b/server/src/types/activity-publication.ts new file mode 100644 index 00000000000..611a167afa6 --- /dev/null +++ b/server/src/types/activity-publication.ts @@ -0,0 +1,7 @@ +import type { PluginEvent } from "@paperclipai/plugin-sdk"; + +export interface ActivityPublication { + companyId: string; + payload: Record; + pluginEvent: PluginEvent | null; +} diff --git a/tests/e2e/acp-stop-continuation.spec.ts b/tests/e2e/acp-stop-continuation.spec.ts index 318ddf65f66..8e03550841f 100644 --- a/tests/e2e/acp-stop-continuation.spec.ts +++ b/tests/e2e/acp-stop-continuation.spec.ts @@ -21,9 +21,12 @@ for (const { unfinishedWrite, stopResponse } of [{ unfinishedWrite: false, stopR name: "ACP Stop fixture", role: "engineer", adapterType: "claude_local", adapterConfig: { engine: "acp", cwd: root, stateDir: path.join(root, "state"), agentCommand: `${JSON.stringify(process.execPath)} ${JSON.stringify(path.resolve("scripts/mcp-fixtures/servers/acp-stop-agent.mjs"))}`, - env: { PAPERCLIP_STOP_FIXTURE_ROOT: root, PAPERCLIP_STOP_FIXTURE_FINISH_TASK: "1", ...(unfinishedWrite ? { PAPERCLIP_STOP_FIXTURE_TOOL: "write" } : {}) }, + // The ACP fixture has no provider login. Use a fixture key to keep setup offline. + env: { ANTHROPIC_API_KEY: "acp-stop-fixture-key", PAPERCLIP_STOP_FIXTURE_ROOT: root, PAPERCLIP_STOP_FIXTURE_FINISH_TASK: "1", ...(unfinishedWrite ? { PAPERCLIP_STOP_FIXTURE_TOOL: "write" } : {}) }, }, runtimeConfig: { heartbeat: { enabled: false, wakeOnDemand: true } }, } })); + await expect.poll(async () => (await json(await request.get(`/api/agents/${owner.id}`))).lifecycleState, + { timeout: 45_000 }).toBe("ready"); const issue = await json(await request.post(`/api/companies/${company.id}/issues`, { data: { title: "ACP Stop continuation", status: "backlog", assigneeAgentId: owner.id, } })); diff --git a/tests/e2e/ai-personal-connection-recovery.spec.ts b/tests/e2e/ai-personal-connection-recovery.spec.ts index 3da4fb68ba9..22f9cacd427 100644 --- a/tests/e2e/ai-personal-connection-recovery.spec.ts +++ b/tests/e2e/ai-personal-connection-recovery.spec.ts @@ -4,7 +4,7 @@ import path from "node:path"; import { expect, test } from "@playwright/test"; import { json } from "./agent-chat.shared"; -test("missing onboarding key offers personal Claude setup in chat and resumes once", async ({ page, request }) => { +test("a ready agent with a missing personal key offers Claude setup in chat and resumes once", async ({ page, request }) => { test.setTimeout(120_000); const root = await mkdtemp(path.join(os.tmpdir(), "personal-ai-recovery-")); const original = await json(await request.get("/api/instance/settings/experimental")); @@ -16,12 +16,17 @@ test("missing onboarding key offers personal Claude setup in chat and resumes on })); await writeFile(path.join(root, "continued"), "ready"); const agent = await json(await request.post(`/api/companies/${company.id}/agents`, { data: { - name: "Chief of Staff", role: "general", adapterType: "claude_local", + name: "Chief of Staff", role: "general", adapterType: "process", + adapterConfig: { command: process.execPath }, + runtimeConfig: { heartbeat: { enabled: false, wakeOnDemand: true } }, + } })); + await expect.poll(async () => (await json(await request.get(`/api/agents/${agent.id}`))).lifecycleState).toBe("ready"); + await json(await request.patch(`/api/agents/${agent.id}`, { data: { + adapterType: "claude_local", adapterConfig: { engine: "acp", cwd: root, stateDir: path.join(root, "state"), agentCommand: `${JSON.stringify(process.execPath)} ${JSON.stringify(path.resolve("scripts/mcp-fixtures/servers/acp-stop-agent.mjs"))}`, env: { ANTHROPIC_API_KEY: { type: "user_secret_ref", key: definition.key, version: "latest", required: true }, PAPERCLIP_STOP_FIXTURE_ROOT: root } }, - runtimeConfig: { heartbeat: { enabled: false, wakeOnDemand: true } }, } })); const chatPath = `/api/companies/${company.id}/chats/${agent.id}`; await page.goto(`/${company.issuePrefix}/chats/${agent.id}`); diff --git a/tests/e2e/legacy-failure-continuation.spec.ts b/tests/e2e/legacy-failure-continuation.spec.ts index e57369bf241..dc7875e862b 100644 --- a/tests/e2e/legacy-failure-continuation.spec.ts +++ b/tests/e2e/legacy-failure-continuation.spec.ts @@ -27,9 +27,12 @@ for (const action of ["task_retry", "thread_retry", "inbox_retry", "message", "q name: "Recovery fixture", role: "engineer", adapterType: "claude_local", adapterConfig: { engine: "acp", cwd: root, stateDir: path.join(root, "state"), agentCommand: `${JSON.stringify(process.execPath)} ${JSON.stringify(path.resolve("scripts/mcp-fixtures/servers/acp-stop-agent.mjs"))}`, - env: { PAPERCLIP_STOP_FIXTURE_ROOT: root, PAPERCLIP_STOP_FIXTURE_FINISH_TASK: "1" } }, + // The ACP fixture has no provider login. Use a fixture key to keep setup offline. + env: { ANTHROPIC_API_KEY: "acp-stop-fixture-key", PAPERCLIP_STOP_FIXTURE_ROOT: root, PAPERCLIP_STOP_FIXTURE_FINISH_TASK: "1" } }, runtimeConfig: { heartbeat: { enabled: false, wakeOnDemand: true } }, } })); + await expect.poll(async () => (await json(await request.get(`/api/agents/${agent.id}`))).lifecycleState, + { timeout: 45_000 }).toBe("ready"); const issue = await json(await request.post(`/api/companies/${company.id}/issues`, { data: { title: "Continue after startup failure", description: "Answer the pending follow-up once.", status: "backlog", assigneeAgentId: agent.id,