Address Greptile review feedback for decomposition PR

This commit is contained in:
Devin Foley committed 2026-05-27 23:32:59 -07:00
1 parent 32dbcc1da4
commit ac4dee8579
8 files changed
+174 -3

No files matched your search

@@ -3740,6 +3740,7 @@ describeEmbeddedPostgres("accepted plan decomposition", () => {
expect(record?.childIssues.map((child) => child.id).sort()).toEqual(
[...result.childIssueIds].sort(),
);
expect(record).not.toHaveProperty("requestedChildren");
expect(record?.childIssues.every((child) => typeof child.title === "string")).toBe(true);
});
});
+17 -2
View File
@@ -4414,9 +4414,24 @@ export function issueService(db: Db) {
const childIssueMap = new Map(childIssueRows.map((row) => [row.id, row]));
return rows.map((row) => {
const childIds = normalizeIssuePlanDecompositionChildIds(row.decomposition.childIssueIds);
const decomposition = row.decomposition;
const childIds = normalizeIssuePlanDecompositionChildIds(decomposition.childIssueIds);
return {
...row.decomposition,
id: decomposition.id,
companyId: decomposition.companyId,
sourceIssueId: decomposition.sourceIssueId,
acceptedPlanRevisionId: decomposition.acceptedPlanRevisionId,
acceptedInteractionId: decomposition.acceptedInteractionId,
status: decomposition.status,
requestFingerprint: decomposition.requestFingerprint,
requestedChildCount: decomposition.requestedChildCount,
childIssueIds: childIds,
ownerAgentId: decomposition.ownerAgentId,
ownerUserId: decomposition.ownerUserId,
ownerRunId: decomposition.ownerRunId,
completedAt: decomposition.completedAt,
createdAt: decomposition.createdAt,
updatedAt: decomposition.updatedAt,
acceptedPlanRevisionNumber: row.revisionNumber ?? null,
childIssues: childIds
.map((childId) => childIssueMap.get(childId) ?? null)