From a3ceec0897f75c5e20d65cbfe8d4d46a03c306ec Mon Sep 17 00:00:00 2001 From: Dotta Date: Tue, 28 Apr 2026 15:35:11 -0500 Subject: [PATCH] Address Greptile backend slice feedback Co-Authored-By: Paperclip --- cli/src/__tests__/company-delete.test.ts | 1 + packages/db/src/migrations/0074_striped_genesis.sql | 2 +- packages/shared/src/types/company.ts | 2 +- server/src/services/productivity-review.ts | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/cli/src/__tests__/company-delete.test.ts b/cli/src/__tests__/company-delete.test.ts index d6fc399f0b2..8865585e751 100644 --- a/cli/src/__tests__/company-delete.test.ts +++ b/cli/src/__tests__/company-delete.test.ts @@ -14,6 +14,7 @@ function makeCompany(overrides: Partial): Company { issueCounter: 1, budgetMonthlyCents: 0, spentMonthlyCents: 0, + attachmentMaxBytes: 10 * 1024 * 1024, requireBoardApprovalForNewAgents: false, feedbackDataSharingEnabled: false, feedbackDataSharingConsentAt: null, diff --git a/packages/db/src/migrations/0074_striped_genesis.sql b/packages/db/src/migrations/0074_striped_genesis.sql index fa01eff7d3e..73bcdaede07 100644 --- a/packages/db/src/migrations/0074_striped_genesis.sql +++ b/packages/db/src/migrations/0074_striped_genesis.sql @@ -1,4 +1,4 @@ CREATE UNIQUE INDEX "issues_active_productivity_review_uq" ON "issues" USING btree ("company_id","origin_kind","origin_id") WHERE "issues"."origin_kind" = 'issue_productivity_review' and "issues"."origin_id" is not null and "issues"."hidden_at" is null - and "issues"."status" not in ('done', 'cancelled'); \ No newline at end of file + and "issues"."status" not in ('done', 'cancelled'); diff --git a/packages/shared/src/types/company.ts b/packages/shared/src/types/company.ts index 739cccaff3e..50c7c5179db 100644 --- a/packages/shared/src/types/company.ts +++ b/packages/shared/src/types/company.ts @@ -11,7 +11,7 @@ export interface Company { issueCounter: number; budgetMonthlyCents: number; spentMonthlyCents: number; - attachmentMaxBytes?: number; + attachmentMaxBytes: number; requireBoardApprovalForNewAgents: boolean; feedbackDataSharingEnabled: boolean; feedbackDataSharingConsentAt: Date | null; diff --git a/server/src/services/productivity-review.ts b/server/src/services/productivity-review.ts index 739483d90ab..e04ec6fd4da 100644 --- a/server/src/services/productivity-review.ts +++ b/server/src/services/productivity-review.ts @@ -579,7 +579,7 @@ export function productivityReviewService(db: Db, deps?: { enqueueWakeup?: Enque originKind: PRODUCTIVITY_REVIEW_ORIGIN_KIND, originId: evidence.sourceIssue.id, originFingerprint: productivityReviewFingerprint(evidence.sourceIssue.id), - requestDepth: clampIssueRequestDepth(clampIssueRequestDepth(evidence.sourceIssue.requestDepth) + 1), + requestDepth: clampIssueRequestDepth(evidence.sourceIssue.requestDepth + 1), }); } catch (error) { const maybe = error as { code?: string; constraint?: string; message?: string };