diff --git a/packages/paperclip-runner/runner/DURABLE_TRANSPORT.md b/packages/paperclip-runner/runner/DURABLE_TRANSPORT.md index 45f65c6dc0a..141c897c29b 100644 --- a/packages/paperclip-runner/runner/DURABLE_TRANSPORT.md +++ b/packages/paperclip-runner/runner/DURABLE_TRANSPORT.md @@ -14,6 +14,12 @@ checks for an incoming connection every 10 ms (or sooner, when that delay is smaller). It never redials, so a connection does not wait out the reconnect delay after a disconnect or an authority rotation. +A listening Runner accepts one controller at a time. Core pings the Runner +every 20 seconds. When the current controller sends no frame, ping included, +for 90 seconds, the Runner closes that connection and accepts the next one +within its reconnect grace. A path that broke without a close therefore cannot +block a replacement controller. + In both modes, Runner enables `TCP_NODELAY` before the WebSocket handshake when the connected peer is on loopback. diff --git a/packages/paperclip-runner/runner/crates/runner-core/examples/recovery-fixture.rs b/packages/paperclip-runner/runner/crates/runner-core/examples/recovery-fixture.rs index 54b545c40a4..6a22983d765 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/examples/recovery-fixture.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/examples/recovery-fixture.rs @@ -274,6 +274,7 @@ fn main() -> Result<(), Box> { )), max_runtime: Duration::ZERO, turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, }; run_durable_runner( config, diff --git a/packages/paperclip-runner/runner/crates/runner-core/src/acpx_provider_backend.rs b/packages/paperclip-runner/runner/crates/runner-core/src/acpx_provider_backend.rs index 8f9bb560e22..9f876068164 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/src/acpx_provider_backend.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/src/acpx_provider_backend.rs @@ -3626,6 +3626,7 @@ mod tests { reconnect_grace: None, max_runtime: Duration::from_secs(60), turn_scoped: false, + controller_silence: crate::durable::DEFAULT_CONTROLLER_SILENCE, } } diff --git a/packages/paperclip-runner/runner/crates/runner-core/src/bin/paperclip-runnerd.rs b/packages/paperclip-runner/runner/crates/runner-core/src/bin/paperclip-runnerd.rs index 2b9984486d5..d68cce10104 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/src/bin/paperclip-runnerd.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/src/bin/paperclip-runnerd.rs @@ -527,6 +527,7 @@ fn run_durable(args: &[String]) -> Result<(), LocalRunnerError> { reconnect_grace: optional_u64(args, "--reconnect-grace-ms")?.map(Duration::from_millis), max_runtime: duration("--max-runtime-ms", 0)?, turn_scoped: turn_scoped(args)?, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, }; if host_control.is_some() && !config.connect_url.starts_with("listen://") { return Err(LocalRunnerError::invalid( diff --git a/packages/paperclip-runner/runner/crates/runner-core/src/durable/mod.rs b/packages/paperclip-runner/runner/crates/runner-core/src/durable/mod.rs index adaca2067c3..156495ff974 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/src/durable/mod.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/src/durable/mod.rs @@ -29,6 +29,7 @@ pub const PROTOCOL: &str = "paperclip.runner"; pub const PROTOCOL_MIN_VERSION: u64 = 1; pub const PROTOCOL_VERSION: u64 = 3; pub const BOOTSTRAP_TICKET_ENV: &str = "PAPERCLIP_RUNNER_BOOTSTRAP_TICKET"; +pub const DEFAULT_CONTROLLER_SILENCE: Duration = Duration::from_secs(90); const MAX_OUTBOX_BYTES: usize = 512 * 1024 * 1024; const MAX_FRAME_BYTES: usize = 16 * 1024 * 1024; @@ -259,6 +260,7 @@ pub struct DurableRunnerConfig { /// per_turn`): the process exits with its run, so nothing reuses a provider /// generation prepared after its turn settles. pub turn_scoped: bool, + pub controller_silence: Duration, } impl DurableRunnerConfig { @@ -314,6 +316,13 @@ impl DurableRunnerConfig { "reconnect delay must be between one millisecond and 60 seconds", )); } + if self.controller_silence < Duration::from_millis(100) + || self.controller_silence > Duration::from_secs(3600) + { + return Err(DurableRunnerError::invalid( + "controller silence must be between 100 milliseconds and one hour", + )); + } if self.reconnect_grace.is_some_and(|grace| grace.is_zero()) { return Err(DurableRunnerError::invalid( "reconnect grace must be non-zero when configured", @@ -440,6 +449,7 @@ mod tests { reconnect_grace: None, max_runtime: Duration::from_secs(60), turn_scoped: false, + controller_silence: crate::durable::DEFAULT_CONTROLLER_SILENCE, } } diff --git a/packages/paperclip-runner/runner/crates/runner-core/src/durable/runner.rs b/packages/paperclip-runner/runner/crates/runner-core/src/durable/runner.rs index 53326fb8a64..949aaf5e5eb 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/src/durable/runner.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/src/durable/runner.rs @@ -3133,6 +3133,7 @@ mod tests { reconnect_grace: None, max_runtime: Duration::from_secs(1), turn_scoped: false, + controller_silence: crate::durable::DEFAULT_CONTROLLER_SILENCE, } } diff --git a/packages/paperclip-runner/runner/crates/runner-core/src/durable/state.rs b/packages/paperclip-runner/runner/crates/runner-core/src/durable/state.rs index 9543e09b6d2..a2abf7246c6 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/src/durable/state.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/src/durable/state.rs @@ -2882,6 +2882,7 @@ mod tests { reconnect_grace: None, max_runtime: Duration::from_secs(1), turn_scoped: false, + controller_silence: crate::durable::DEFAULT_CONTROLLER_SILENCE, } } diff --git a/packages/paperclip-runner/runner/crates/runner-core/src/durable/tests/listener_silent_controller.rs b/packages/paperclip-runner/runner/crates/runner-core/src/durable/tests/listener_silent_controller.rs new file mode 100644 index 00000000000..9fc29a3d105 --- /dev/null +++ b/packages/paperclip-runner/runner/crates/runner-core/src/durable/tests/listener_silent_controller.rs @@ -0,0 +1,296 @@ +#[test] +fn listener_accepts_a_new_controller_after_the_current_one_goes_silent() { + struct ShutdownOnly(Arc>>); + + impl super::super::CommandExecutor for ShutdownOnly { + fn execute( + &mut self, + command: &Command, + ) -> Result { + self.0.lock().unwrap().push(command.command_type.clone()); + Ok(super::super::CommandExecution::result( + json!({"status": "completed"}), + )) + } + } + + let reservation = TcpListener::bind("127.0.0.1:0").unwrap(); + let address = reservation.local_addr().unwrap(); + drop(reservation); + let path = "/api/runner/v1/connect/run_1"; + let mut config = config(address.port()); + config.connect_url = format!("listen://0.0.0.0:{}{path}", address.port()); + config.max_runtime = Duration::from_secs(10); + config.controller_silence = Duration::from_millis(500); + let directory = std::env::temp_dir().join(format!( + "paperclip-runner-listener-silent-controller-{}", + std::process::id() + )); + let _ = std::fs::remove_dir_all(&directory); + config.state_dir = directory.clone(); + let state = test_state(&config); + let expires = current_unix_ms().unwrap() + 60_000; + let server_config = config.clone(); + let server_state = state.clone(); + let (outcome, received) = mpsc::channel(); + let server = thread::spawn(move || { + let open = |deadline: Instant| loop { + match TcpStream::connect(address) { + Ok(stream) => break stream, + Err(_) if Instant::now() < deadline => thread::sleep(Duration::from_millis(10)), + Err(error) => panic!("Runner never listened: {error}"), + } + }; + let stream = open(Instant::now() + Duration::from_secs(5)); + let (mut silent, _) = client(format!("ws://{address}{path}"), stream).unwrap(); + let mut silent_secure = server_authenticate( + &mut silent, + &server_config, + &server_state, + ServerCredential { + token: "bootstrap-secret", + kind: "bootstrap", + lease_id: None, + expires_at_unix_ms: expires, + revocation_epoch: 0, + }, + ); + send_secure( + &mut silent, + &mut silent_secure, + &server_config, + &welcome(&server_state, "connection_1", Some("lease-secret"), expires, 0, vec![]), + ); + let replacement = open(Instant::now() + Duration::from_secs(5)); + replacement + .set_read_timeout(Some(Duration::from_secs(3))) + .unwrap(); + let (mut socket, _) = match client(format!("ws://{address}{path}"), replacement) { + Ok(connected) => connected, + Err(error) => { + outcome.send(format!("replacement was not accepted: {error}")).unwrap(); + return; + } + }; + let mut secure = server_authenticate( + &mut socket, + &server_config, + &server_state, + ServerCredential { + token: "lease-secret", + kind: "lease", + lease_id: Some("lease_1"), + expires_at_unix_ms: expires, + revocation_epoch: 1, + }, + ); + send_secure( + &mut socket, + &mut secure, + &server_config, + &welcome(&server_state, "connection_2", None, expires, 0, vec![]), + ); + send_secure( + &mut socket, + &mut secure, + &server_config, + &control( + &server_state, + "connection_2", + "command", + json!({ + "schema": "paperclip.prp.command.v1", + "commandId": "command_1", + "controllerSeq": 1, + "type": "runner.shutdown", + "issuedAt": "2026-11-17T19:52:17.000Z", + "payload": {}, + }), + ), + ); + let result = receive_secure(&mut socket, &mut secure, &server_config); + assert_eq!(result["kind"], "command_result"); + send_secure( + &mut socket, + &mut secure, + &server_config, + &control( + &server_state, + "connection_2", + "command_result_ack", + json!({ + "commandId": "command_1", + "commandType": "runner.shutdown", + "controllerSeq": 1, + "status": "completed", + }), + ), + ); + outcome.send("accepted".to_owned()).unwrap(); + drop(silent); + }); + + let log = Arc::new(std::sync::Mutex::new(Vec::new())); + let run = super::super::run_durable_runner( + config, + BootstrapTicket::new("bootstrap-secret".to_owned()).unwrap(), + ShutdownOnly(log.clone()), + ); + let outcome = received.recv_timeout(Duration::from_secs(10)).unwrap(); + server.join().unwrap(); + assert_eq!(outcome, "accepted"); + run.unwrap(); + assert_eq!(*log.lock().unwrap(), ["runner.shutdown"]); + std::fs::remove_dir_all(directory).unwrap(); +} + +#[test] +fn listener_controller_pings_keep_an_idle_connection() { + let listener = TcpListener::bind("127.0.0.1:0").unwrap(); + listener.set_nonblocking(true).unwrap(); + let address = listener.local_addr().unwrap(); + let path = "/api/runner/v1/connect/run_1".to_owned(); + let endpoint = RunnerTransportEndpoint::Listen { + listener, + path: path.clone(), + }; + let mut config = config(address.port()); + config.controller_silence = Duration::from_millis(1_000); + let state = test_state(&config); + let ticket = BootstrapTicket::new("bootstrap-secret".to_owned()).unwrap(); + let (ready, connected) = mpsc::channel(); + let (stop, stopped) = mpsc::channel::<()>(); + let peer_config = config.clone(); + let peer_state = state.clone(); + let peer = thread::spawn(move || { + let stream = TcpStream::connect(address).unwrap(); + ready.send(()).unwrap(); + let (mut socket, _) = client(format!("ws://{address}{path}"), stream).unwrap(); + let expires = current_unix_ms().unwrap() + 60_000; + let mut secure = server_authenticate( + &mut socket, + &peer_config, + &peer_state, + ServerCredential { + token: "bootstrap-secret", + kind: "bootstrap", + lease_id: None, + expires_at_unix_ms: expires, + revocation_epoch: 0, + }, + ); + send_secure( + &mut socket, + &mut secure, + &peer_config, + &welcome(&peer_state, "connection_1", Some("lease-secret"), expires, 0, vec![]), + ); + while stopped.recv_timeout(Duration::from_millis(400)).is_err() { + socket.send(Message::Ping(Vec::new().into())).unwrap(); + } + }); + connected.recv().unwrap(); + let (mut transport, _) = AuthenticatedTransport::connect( + &endpoint, + &config, + &state, + Some(&ticket), + None, + Instant::now() + config.max_runtime, + ) + .unwrap() + .unwrap(); + let pinged_until = Instant::now() + Duration::from_millis(2_500); + while Instant::now() < pinged_until { + assert!(transport.receive_json().unwrap().is_none()); + } + stop.send(()).unwrap(); + peer.join().unwrap(); +} + +#[test] +fn listener_welcome_timeout_is_not_reported_as_controller_silence() { + let listener = TcpListener::bind("127.0.0.1:0").unwrap(); + listener.set_nonblocking(true).unwrap(); + let address = listener.local_addr().unwrap(); + let path = "/api/runner/v1/connect/run_1".to_owned(); + let endpoint = RunnerTransportEndpoint::Listen { + listener, + path: path.clone(), + }; + let mut config = config(address.port()); + config.controller_silence = Duration::from_millis(100); + let state = test_state(&config); + let expires = current_unix_ms().unwrap() + 60_000; + let lease = LeaseCredential { + lease_id: "lease_1".to_owned(), + expires_at_unix_ms: expires, + revocation_epoch: 1, + token: super::super::Secret::new("lease-secret".to_owned()), + renewal_requested: false, + }; + let (ready, connected) = mpsc::channel(); + let (done, finished) = mpsc::channel::<()>(); + let peer_config = config.clone(); + let peer_state = state.clone(); + let peer = thread::spawn(move || { + let stream = TcpStream::connect(address).unwrap(); + ready.send(()).unwrap(); + let (mut socket, _) = client(format!("ws://{address}{path}"), stream).unwrap(); + server_authenticate( + &mut socket, + &peer_config, + &peer_state, + ServerCredential { + token: "lease-secret", + kind: "lease", + lease_id: Some("lease_1"), + expires_at_unix_ms: expires, + revocation_epoch: 1, + }, + ); + finished.recv_timeout(Duration::from_secs(10)).unwrap(); + }); + connected.recv().unwrap(); + let failure = match AuthenticatedTransport::connect( + &endpoint, + &config, + &state, + None, + Some(&lease), + Instant::now() + Duration::from_millis(800), + ) { + Err(failure) => failure, + Ok(_) => panic!("connection without welcome unexpectedly authenticated"), + }; + done.send(()).unwrap(); + peer.join().unwrap(); + let message = failure.to_string(); + assert!(!message.contains("liveness window"), "{message}"); + assert!( + message.contains("welcome timed out") || message.contains("message deadline elapsed"), + "{message}" + ); + assert!(!failure.bootstrap_maybe_consumed); +} + +#[test] +fn controller_silence_must_be_a_plausible_window() { + let mut config = config(43127); + for silence in [ + Duration::ZERO, + Duration::from_millis(99), + Duration::from_secs(3601), + ] { + config.controller_silence = silence; + assert!(config.validate().is_err(), "{silence:?}"); + } + for silence in [ + Duration::from_millis(100), + crate::durable::DEFAULT_CONTROLLER_SILENCE, + Duration::from_secs(3600), + ] { + config.controller_silence = silence; + config.validate().unwrap(); + } +} diff --git a/packages/paperclip-runner/runner/crates/runner-core/src/durable/transport.rs b/packages/paperclip-runner/runner/crates/runner-core/src/durable/transport.rs index d777483b000..ff94d7c22d6 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/src/durable/transport.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/src/durable/transport.rs @@ -943,6 +943,8 @@ pub(crate) struct AuthenticatedTransport { socket: RunnerSocket, secure_channel: SecureChannel, max_frame_bytes: usize, + last_inbound: Instant, + controller_silence: Duration, } #[derive(Debug)] @@ -1121,6 +1123,8 @@ impl AuthenticatedTransport { socket, secure_channel, max_frame_bytes: config.max_frame_bytes, + last_inbound: Instant::now(), + controller_silence: config.controller_silence, }; // Ticket validation and lease persistence happen before the server // emits welcome. Give that durable admission the connection setup @@ -1147,6 +1151,7 @@ impl AuthenticatedTransport { expected_lease, challenge.selected_version, )?; + transport.last_inbound = Instant::now(); // Authentication can wait longer for control-plane validation, but // the steady-state runner loop must return to provider polling // promptly when no control message is available. @@ -1176,12 +1181,17 @@ impl AuthenticatedTransport { } pub(crate) fn receive_json(&mut self) -> Result, DurableRunnerError> { - self.receive_json_until(None) + match self.receive_json_until(None)? { + None if self.listener_controller_silent() => Err(DurableRunnerError::invalid( + "controller sent no frame within the liveness window; listening for a new connection", + )), + message => Ok(message), + } } pub(crate) fn receive_queued_json(&mut self) -> Result, DurableRunnerError> { self.set_runtime_read_timeout(QUEUED_CONTROL_READ_TIMEOUT)?; - let message = self.receive_json_until(None); + let message = self.receive_json(); self.set_runtime_read_timeout(RUNTIME_READ_TIMEOUT)?; message } @@ -1196,13 +1206,22 @@ impl AuthenticatedTransport { &mut self, deadline: Option, ) -> Result, DurableRunnerError> { - let frame = - match receive_plain_optional_until(&mut self.socket, self.max_frame_bytes, deadline)? { - Some(frame) => frame, - None => return Ok(None), - }; + let frame = match receive_plain_optional_until_observed( + &mut self.socket, + self.max_frame_bytes, + deadline, + Some(&mut self.last_inbound), + )? { + Some(frame) => frame, + None => return Ok(None), + }; self.secure_channel.decrypt(&frame, false).map(Some) } + + fn listener_controller_silent(&self) -> bool { + matches!(self.socket, RunnerSocket::Listen(_)) + && self.last_inbound.elapsed() >= self.controller_silence + } } #[derive(Clone, Debug, Deserialize)] @@ -1629,6 +1648,15 @@ fn receive_plain_optional_until( socket: &mut (impl WebSocketMessages + ?Sized), max_frame_bytes: usize, deadline: Option, +) -> Result, DurableRunnerError> { + receive_plain_optional_until_observed(socket, max_frame_bytes, deadline, None) +} + +fn receive_plain_optional_until_observed( + socket: &mut (impl WebSocketMessages + ?Sized), + max_frame_bytes: usize, + deadline: Option, + mut last_inbound: Option<&mut Instant>, ) -> Result, DurableRunnerError> { loop { if deadline.is_some_and(|deadline| Instant::now() >= deadline) { @@ -1642,6 +1670,9 @@ fn receive_plain_optional_until( "WebSocket authentication message deadline elapsed", )); } + if let (Ok(_), Some(last_inbound)) = (&message, last_inbound.as_deref_mut()) { + *last_inbound = Instant::now(); + } match message { Ok(Message::Text(text)) => { if text.len() > max_frame_bytes { @@ -1782,6 +1813,7 @@ mod tests { include!("tests/acpx_park_relaunch.rs"); include!("tests/ack_release_poll.rs"); include!("tests/indeterminate_terminal_ack.rs"); + include!("tests/listener_silent_controller.rs"); include!("tests/loopback_nodelay.rs"); use std::net::{IpAddr, Ipv4Addr, TcpListener}; @@ -1818,6 +1850,7 @@ mod tests { reconnect_grace: None, max_runtime: Duration::from_secs(1), turn_scoped: false, + controller_silence: crate::durable::DEFAULT_CONTROLLER_SILENCE, } } diff --git a/packages/paperclip-runner/runner/crates/runner-core/src/external_provider_backend.rs b/packages/paperclip-runner/runner/crates/runner-core/src/external_provider_backend.rs index 789fa40fc7e..77dd1d2860c 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/src/external_provider_backend.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/src/external_provider_backend.rs @@ -1085,6 +1085,7 @@ mod tests { reconnect_grace: None, max_runtime: Duration::from_secs(60), turn_scoped: false, + controller_silence: crate::durable::DEFAULT_CONTROLLER_SILENCE, } } fn command(kind: &str, payload: Value) -> Command { diff --git a/packages/paperclip-runner/runner/crates/runner-core/src/managed_provider_backend.rs b/packages/paperclip-runner/runner/crates/runner-core/src/managed_provider_backend.rs index 29543fb17f5..32c2d09cb3b 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/src/managed_provider_backend.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/src/managed_provider_backend.rs @@ -2618,6 +2618,7 @@ mod tests { reconnect_grace: None, max_runtime: Duration::from_secs(60), turn_scoped: false, + controller_silence: crate::durable::DEFAULT_CONTROLLER_SILENCE, } } diff --git a/packages/paperclip-runner/runner/crates/runner-core/src/runtime_notifications.rs b/packages/paperclip-runner/runner/crates/runner-core/src/runtime_notifications.rs index 9bc82b0bd35..cac2265fb0b 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/src/runtime_notifications.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/src/runtime_notifications.rs @@ -413,6 +413,7 @@ mod tests { reconnect_grace: None, max_runtime: Duration::ZERO, turn_scoped: false, + controller_silence: crate::durable::DEFAULT_CONTROLLER_SILENCE, } } diff --git a/packages/paperclip-runner/runner/crates/runner-core/src/task_memory.rs b/packages/paperclip-runner/runner/crates/runner-core/src/task_memory.rs index 6bdefbd7dda..343251543bf 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/src/task_memory.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/src/task_memory.rs @@ -269,6 +269,7 @@ mod tests { reconnect_grace: None, max_runtime: Duration::ZERO, turn_scoped: false, + controller_silence: crate::durable::DEFAULT_CONTROLLER_SILENCE, } } diff --git a/packages/paperclip-runner/runner/crates/runner-core/tests/acpx_park_preparation.rs b/packages/paperclip-runner/runner/crates/runner-core/tests/acpx_park_preparation.rs index ed0b6031535..d89ce97a55c 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/tests/acpx_park_preparation.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/tests/acpx_park_preparation.rs @@ -130,6 +130,7 @@ impl Harness { reconnect_grace: None, max_runtime: Duration::from_secs(30), turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, }; let descriptor = json!({ "kind": "acpx", "provider": "acpx", "driver": "acpx_runtime", diff --git a/packages/paperclip-runner/runner/crates/runner-core/tests/acpx_park_readiness.rs b/packages/paperclip-runner/runner/crates/runner-core/tests/acpx_park_readiness.rs index 5f00bdaef59..7ef6147d049 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/tests/acpx_park_readiness.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/tests/acpx_park_readiness.rs @@ -86,6 +86,7 @@ fn fixture( reconnect_grace: None, max_runtime: Duration::from_secs(30), turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, }; let descriptor = json!({ "kind": "acpx", "provider": "acpx", "driver": "acpx_runtime", diff --git a/packages/paperclip-runner/runner/crates/runner-core/tests/acpx_warm_attachment.rs b/packages/paperclip-runner/runner/crates/runner-core/tests/acpx_warm_attachment.rs index ced2ac6e4d7..b3b7673677c 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/tests/acpx_warm_attachment.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/tests/acpx_warm_attachment.rs @@ -81,6 +81,7 @@ fn checkpoints_the_sidecar_and_rebinds_consecutive_warm_runs_before_accepting_wo reconnect_grace: None, max_runtime: Duration::from_secs(30), turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, }; let mut descriptor = json!({ "kind": "acpx", "provider": "acpx", "driver": "acpx_runtime", @@ -241,6 +242,7 @@ fn reopens_the_conversation_for_a_turn_after_a_suspension_stop() { reconnect_grace: None, max_runtime: Duration::from_secs(30), turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, }; let descriptor = json!({ "kind": "acpx", "provider": "acpx", "driver": "acpx_runtime", @@ -359,6 +361,7 @@ fn only_a_restored_session_with_an_active_turn_polls_as_live() { reconnect_grace: None, max_runtime: Duration::from_secs(30), turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, }; let descriptor = json!({ "kind": "acpx", "provider": "acpx", "driver": "acpx_runtime", @@ -444,6 +447,7 @@ fn restores_the_conversation_after_losing_an_active_turn_to_a_runner_restart() { reconnect_grace: None, max_runtime: Duration::from_secs(30), turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, }; let descriptor = json!({ "kind": "acpx", "provider": "acpx", "driver": "acpx_runtime", @@ -587,6 +591,7 @@ fn restores_a_turn_lost_to_a_runner_upgrade_under_the_new_launch_profile() { reconnect_grace: None, max_runtime: Duration::from_secs(30), turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, }; let descriptor = json!({ "kind": "acpx", "provider": "acpx", "driver": "acpx_runtime", @@ -714,6 +719,7 @@ fn continues_a_settled_conversation_in_the_next_run_after_a_runner_upgrade() { reconnect_grace: None, max_runtime: Duration::from_secs(30), turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, }; let mut descriptor = json!({ "kind": "acpx", "provider": "acpx", "driver": "acpx_runtime", @@ -845,6 +851,7 @@ fn a_lost_cancellation_reply_still_settles_the_turn_and_suspends_the_runner() { reconnect_grace: None, max_runtime: Duration::from_secs(60), turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, }; let descriptor = json!({ "kind": "acpx", "provider": "acpx", "driver": "acpx_runtime", diff --git a/packages/paperclip-runner/runner/crates/runner-core/tests/codex_provider.rs b/packages/paperclip-runner/runner/crates/runner-core/tests/codex_provider.rs index 225108ceba3..d08a7a06399 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/tests/codex_provider.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/tests/codex_provider.rs @@ -781,6 +781,7 @@ fn durable_config(directory: &Path) -> DurableRunnerConfig { reconnect_grace: None, max_runtime: std::time::Duration::from_secs(5), turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, } } diff --git a/packages/paperclip-runner/runner/crates/runner-core/tests/durable_recovery.rs b/packages/paperclip-runner/runner/crates/runner-core/tests/durable_recovery.rs index 32c63e148e4..3443604d48a 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/tests/durable_recovery.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/tests/durable_recovery.rs @@ -33,6 +33,7 @@ fn config(state_dir: PathBuf) -> DurableRunnerConfig { reconnect_grace: None, max_runtime: Duration::from_secs(1), turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, } } diff --git a/packages/paperclip-runner/runner/crates/runner-core/tests/native_provider_backend.rs b/packages/paperclip-runner/runner/crates/runner-core/tests/native_provider_backend.rs index 1f4c9c48d57..71272154c17 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/tests/native_provider_backend.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/tests/native_provider_backend.rs @@ -153,6 +153,7 @@ fn config(state_dir: &Path) -> DurableRunnerConfig { reconnect_grace: None, max_runtime: Duration::from_secs(60), turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, } } diff --git a/packages/paperclip-runner/runner/crates/runner-core/tests/runtime_notifications.rs b/packages/paperclip-runner/runner/crates/runner-core/tests/runtime_notifications.rs index 6165bb59c06..c7ed9ff9dc5 100644 --- a/packages/paperclip-runner/runner/crates/runner-core/tests/runtime_notifications.rs +++ b/packages/paperclip-runner/runner/crates/runner-core/tests/runtime_notifications.rs @@ -57,6 +57,7 @@ fn real_cli_uses_relative_state_from_another_directory_and_never_process_run_ide reconnect_grace: None, max_runtime: Duration::ZERO, turn_scoped: false, + controller_silence: paperclip_runner_core::durable::DEFAULT_CONTROLLER_SILENCE, }; let store = DurableStateStore::new(&path).unwrap(); let (mut state, _) = store.load_or_create(&config).unwrap();