Jannik/PaperClipAI
1
0 Fork 0
mirror of https://github.com/paperclipai/paperclip.git synced 2026-10-24 10:13:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: resume pending repository work with an empty work list

Browse Source 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
DottaandPaperclip committed 2026-10-21 09:05:47 -05:00
1 parent 6df51567e7
commit 9dcccc9e46
2 files changed
+7 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

server/src/services/native-runtime/native-completion-feedback.test.ts
+4
View File
@@ -251,6 +251,10 @@ describe("native final-response feedback", () => {
scope: "current_track", unblockAction: "Start the next normal admission" },
};
await expect(nativeCompletionFeedback(db, value.runId, report)).rejects.toThrow('paperclip_finish with reportedWorkDisposition="yielded"');
await expect(nativeCompletionFeedback(db, value.runId, { ...report, completionClaim: { ...report.completionClaim, remainingWork: [] } }))
.rejects.toThrow('paperclip_finish with reportedWorkDisposition="yielded"');
await expect(nativeCompletionFeedback(db, value.runId, { ...report, completionClaim: { ...report.completionClaim, objectiveSatisfied: true } }))
.rejects.toThrow('paperclip_finish with reportedWorkDisposition="yielded"');
await expect(nativeCompletionFeedback(db, value.runId, { ...report, evidence: [{ ref: `repository-preparation:${randomUUID()}` }] }))
.resolves.toContain("Blocker report accepted");
await expect(nativeCompletionFeedback(db, value.runId, { ...report, blocker: { ...report.blocker!, reasonCode: "missing_access" } }))
server/src/services/native-runtime/native-completion-feedback.ts
+3 -2
View File
@@ -239,9 +239,10 @@ export async function nativeCompletionFeedback(
if (readiness.unresolvedBlockerCount > 0) {
return `Completion report accepted; this task still has unresolved dependencies. Explain the blockers on [this task](/issues/${issue.identifier ?? issue.id}); do not say the task is done.`;
}
const unfinishedWork = !result.completionClaim.objectiveSatisfied || result.completionClaim.remainingWork.some(work => work.blocksCompletion);
if (result.reportedWorkDisposition === "blocked" && result.blocker?.owner.kind === "system" &&
result.blocker.scope === "current_track" && result.blocker.reasonCode === "repository_checkout_pending" &&
!result.completionClaim.objectiveSatisfied && result.completionClaim.remainingWork.some(work => work.blocksCompletion) &&
unfinishedWork &&
signals.actionableAttentionRequests.length === 0 && issue.workMode === "standard" &&
issue.executionRunId === run.id && run.status === "running") {
const repositoryIds = result.evidence.flatMap(evidence => {
@@ -262,7 +263,7 @@ export async function nativeCompletionFeedback(
!isConversation(issue) &&
result.reportedWorkDisposition === "yielded" &&
result.continuation?.kind === "response_wake" &&
(!result.completionClaim.objectiveSatisfied || result.completionClaim.remainingWork.some((entry) => entry.blocksCompletion)) &&
unfinishedWork &&
signals.actionableAttentionRequests.length === 0
) {
const pause = await issueTreeControlService(db).getActivePauseHoldGate(