mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-22 11:54:35 +01:00
ci: retire recurring public cloud image builds (#13827)
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Core publishes standard images and source verification for downstream services. > - Managed services can now compose private images from the signed standard image. > - Core still builds a second public cloud image on every master push and release. > - That duplicate producer consumes build capacity and retains an obsolete readiness contract. > - This pull request retires recurring cloud publication while preserving the standard producer and rollback artifacts. ## Linked Issues or Issue Description Refs #13797 and #13789. Related: #12856 changes image dependency packaging; it does not retire this producer. **What existing behavior does this improve?** Core's recurring Docker publication and Cloud readiness workflow. **Current behavior** Master pushes call the legacy cloud publisher from Cloud readiness. Release tags and manual Docker runs call it too. Canary promotion also requires the legacy image. **Proposed behavior** Publish standard Core images and retain `Cloud source verified v1`. Let downstream services build their managed image. Keep explicit commit previews and existing images available. ## What Changed - Remove `docker-cloud.yml`, its master and release callers, and its unused cache selector. - Remove the legacy image/migrator wait and `Cloud deployable v1` job. Keep the full source verification workflow and exact source-proof name. - Make canary promotion inspect and promote the standard image only. - Preserve signed standard-image publication, direct migrator publication, and explicit `release.yml` previews. The preview path still uses the Dockerfile `cloud` target. - Update workflow, preview, build-stamp, and packaging tests. Exercise the promotion shell with mocked registry commands, including missing-image and missing-tag cases. - Document frozen legacy aliases, consumer requirements, preview compatibility, and rollback retention. ## Verification - All 377 workflow tests pass: `node --test .github/scripts/tests/*.test.mjs`. - All 129 release-registry tests pass: `pnpm test:release-registry`. - Focused source-proof, standard-image, preview, and workflow tests pass: 256 tests. - Focused image packaging/build-stamp tests pass: 16 tests. - Actionlint passes on all three changed workflow files. `git diff --check` passes. - Full local `pnpm build` and `pnpm -r typecheck` pass. - The policy follow-up updates an old assertion that required the removed readiness job. All 37 source-proof/release-workflow tests pass locally. - Full local `pnpm test:run` did not complete successfully while the Mac ran out of disk space. No full-suite pass is claimed. Removed 1.2 GiB of generated Cargo output from this isolated worktree with `cargo clean`. GitHub CI passed on the final head: 52 successful checks and 2 optional skips. - Fresh Greptile review for `4f5fe1951f0bd7f7739cf6655d395ff78f1ed944`: **5/5**, successful current-head check, zero review threads. - September 23 refresh: the unchanged PR head merges cleanly with current master `db8f8fe5b73a2697684a30261b0d306a9c631aba`. In an isolated temporary worktree, all 377 workflow tests and 29 release/preview tests pass on the combined tree. `git diff --cached --check` passes. - Refreshed Actionlint workflow validation passes with ShellCheck disabled. Full Actionlint reports the same 10 existing ShellCheck diagnostics as master, with no added diagnostics. No source changes or new PR commits were needed. - The full local build/typecheck and current-head Linux CI results above remain the verification for the unchanged PR head. They were not rerun for this metadata-only refresh. No image publication or tenant deployment was initiated for this refresh. ## Risks **Deployment prerequisite satisfied (September 23):** The combined cleanup release is deployed to staging and production, and production Support is verified. Active managed-fleet automation uses standard-image composition. Explicit immutable previews remain supported by the retained preview publisher. This PR is ready for maintainer review; keep auto-merge disabled and wait for explicit merge authorization. - A consumer still selecting `Cloud deployable v1` will stop advancing at the last legacy-ready commit. Confirm active automatic consumers use the standard-image composition contract before merge. - Legacy cloud release-channel aliases stop advancing. Standard self-hosted aliases continue. - This PR deletes no registry images, cache tags, migrators, credentials, or runner infrastructure. Existing immutable releases remain usable for rollback. - Explicit legacy previews remain for commit-specific operator deployments. Retiring that compatibility path requires a separate consumer migration. - These changes affect CI publication, not database schema or application behavior. ## Model Used OpenAI Codex, GPT-6. The runtime does not expose a more specific model identifier or context-window size. Used repository inspection, reasoning, code editing, shell tools, and test execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
1 parent
db8f8fe5b7
commit
8ee8f1fd6e
23 files changed
+197
-1187
No files matched your search
@@ -5,22 +5,18 @@ import { describe, expect, it } from "vitest";
|
||||
import { BUNDLED_PLUGIN_CATALOG } from "../services/bundled-plugins.js";
|
||||
|
||||
/**
|
||||
* Drift guard for the cloud image variant (Dockerfile `cloud` target).
|
||||
* Drift guard for the explicit preview image (Dockerfile `cloud` target).
|
||||
*
|
||||
* The cloud image builds the sandbox-provider plugins named in the
|
||||
* The preview image builds the sandbox-provider plugins named in the
|
||||
* CLOUD_BUNDLED_PLUGINS build arg so managed instances can auto-install
|
||||
* them from the bundled catalog at boot. That contract spans three places
|
||||
* that nothing else ties together: the Dockerfile ARG default, the docker
|
||||
* workflow's build-arg, and BUNDLED_PLUGIN_CATALOG. A rename or removal in
|
||||
* any one of them would otherwise surface only when the image build fails
|
||||
* on master — or worse, as a silent "bundle not present" skip at instance
|
||||
* boot.
|
||||
* them from the bundled catalog at boot. The Dockerfile default and
|
||||
* BUNDLED_PLUGIN_CATALOG must agree even after the recurring public cloud
|
||||
* publisher is retired. Explicit previews still use this build target.
|
||||
*/
|
||||
|
||||
const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..", "..", "..");
|
||||
const dockerfile = readFileSync(path.join(repoRoot, "Dockerfile"), "utf8");
|
||||
const workflow = readFileSync(path.join(repoRoot, ".github", "workflows", "docker.yml"), "utf8");
|
||||
const cloudWorkflow = readFileSync(path.join(repoRoot, ".github", "workflows", "docker-cloud.yml"), "utf8");
|
||||
|
||||
function parseList(source: string, pattern: RegExp, label: string): string[] {
|
||||
const match = source.match(pattern);
|
||||
@@ -35,18 +31,9 @@ const dockerfileDefault = parseList(
|
||||
/^ARG CLOUD_BUNDLED_PLUGINS="([^"]*)"/m,
|
||||
"Dockerfile",
|
||||
);
|
||||
const workflowArg = parseList(
|
||||
cloudWorkflow,
|
||||
/^\s*CLOUD_BUNDLED_PLUGINS=(.*)$/m,
|
||||
"docker workflow",
|
||||
);
|
||||
|
||||
describe("cloud image bundled plugins", () => {
|
||||
it("keeps the Dockerfile default and the workflow build-arg in sync", () => {
|
||||
expect(workflowArg).toEqual(dockerfileDefault);
|
||||
});
|
||||
|
||||
it.each([...new Set([...dockerfileDefault, ...workflowArg])])(
|
||||
it.each(dockerfileDefault)(
|
||||
"plugin %s is buildable and resolvable by the auto-installer",
|
||||
(name) => {
|
||||
const dir = path.join(repoRoot, "packages", "plugins", "sandbox-providers", name);
|
||||
@@ -77,37 +64,6 @@ describe("cloud image bundled plugins", () => {
|
||||
expect(workflow).toMatch(/^\s*target: production$/m);
|
||||
});
|
||||
|
||||
it("publishes the cloud image in its own job with no needs coupling", () => {
|
||||
const caller = workflow.split(" build-and-push-cloud:")[1]?.split(" promote_canary_channel:")[0];
|
||||
expect(caller, "tag and manual builds must call the cloud workflow").toContain("uses: ./.github/workflows/docker-cloud.yml");
|
||||
expect(caller, "the reusable caller must also remain independent of production").not.toMatch(/^\s*needs:/m);
|
||||
// The reusable cloud workflow owns its job and SHA concurrency group.
|
||||
// Production publication must not gate, delay, or skip the cloud build.
|
||||
const jobsSection = cloudWorkflow.slice(cloudWorkflow.indexOf("\njobs:\n"));
|
||||
const headers = [...jobsSection.matchAll(/^ {2}([\w-]+):[^\n]*$/gm)];
|
||||
expect(
|
||||
headers.length,
|
||||
"docker-cloud.yml must declare a cloud build job under jobs:",
|
||||
).toBeGreaterThanOrEqual(1);
|
||||
|
||||
// Locate the job block that carries the cloud build (target: cloud) and
|
||||
// assert it declares no `needs:` — coupling it to another job would
|
||||
// reintroduce the shared failure the split job exists to remove.
|
||||
const cloudHeaderIdx = headers.findIndex((header, i) => {
|
||||
const start = header.index ?? 0;
|
||||
const end = headers[i + 1]?.index ?? jobsSection.length;
|
||||
return jobsSection.slice(start, end).includes("target: cloud");
|
||||
});
|
||||
expect(cloudHeaderIdx, "one job must build the cloud target").toBeGreaterThanOrEqual(0);
|
||||
const start = headers[cloudHeaderIdx].index ?? 0;
|
||||
const end = headers[cloudHeaderIdx + 1]?.index ?? jobsSection.length;
|
||||
const cloudJobBlock = jobsSection.slice(start, end);
|
||||
expect(
|
||||
cloudJobBlock,
|
||||
"the cloud job must not couple to another job via needs:",
|
||||
).not.toMatch(/^\s*needs:/m);
|
||||
});
|
||||
|
||||
it("throttles the docker workflow with cancel-in-progress: false", () => {
|
||||
// Concurrency is declared at the workflow (top) level so a single group
|
||||
// spans the whole run, and cancel-in-progress is false so an in-flight
|
||||
|
||||
@@ -14,12 +14,12 @@ import { fileURLToPath } from "node:url";
|
||||
import { describe, expect, it } from "vitest";
|
||||
|
||||
/**
|
||||
* Drift guard for the cloud image variant's bundled Sentry server package
|
||||
* Drift guard for the explicit preview image's bundled Sentry server package
|
||||
* (Dockerfile `cloud` target).
|
||||
*
|
||||
* The self-hosted image, built from the `production` target, keeps
|
||||
* `@sentry/node` as a true optional peer dependency: the operator installs
|
||||
* it themselves. The hosted (cloud) image installs the packages the
|
||||
* it themselves. The explicit preview image installs the packages the
|
||||
* `CLOUD_BUNDLED_SERVER_DEPS` build argument names, so a managed tenant
|
||||
* gets server error reports with no separate install step. The stage
|
||||
* reads each package's version from the `peerDependencies` block of
|
||||
@@ -30,14 +30,13 @@ import { describe, expect, it } from "vitest";
|
||||
* workflow carry no literal version pin (they read the version from
|
||||
* `server/package.json` at build time instead); the `cloud-server-deps`
|
||||
* stage declares the `CLOUD_BUNDLED_SERVER_DEPS` build argument with a
|
||||
* default that names `@sentry/node`; the docker workflow passes that same
|
||||
* argument to the cloud build; and no committed manifest re-declares the
|
||||
* default that names `@sentry/node`; and no committed manifest re-declares the
|
||||
* version.
|
||||
*/
|
||||
|
||||
const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..", "..", "..");
|
||||
const dockerfile = readFileSync(path.join(repoRoot, "Dockerfile"), "utf8");
|
||||
const workflow = readFileSync(path.join(repoRoot, ".github", "workflows", "docker-cloud.yml"), "utf8");
|
||||
const workflow = readFileSync(path.join(repoRoot, ".github", "workflows", "release.yml"), "utf8");
|
||||
const serverPackageJson = JSON.parse(
|
||||
readFileSync(path.join(repoRoot, "server", "package.json"), "utf8"),
|
||||
) as { peerDependencies?: Record<string, string> };
|
||||
@@ -164,10 +163,6 @@ describe("cloud image Sentry install", () => {
|
||||
).toContain("@sentry/node");
|
||||
});
|
||||
|
||||
it("passes CLOUD_BUNDLED_SERVER_DEPS to the cloud build in the docker workflow", () => {
|
||||
expect(workflow).toMatch(/^\s*CLOUD_BUNDLED_SERVER_DEPS=@sentry\/node\s*$/m);
|
||||
});
|
||||
|
||||
it("declares no committed manifest that re-states the version", () => {
|
||||
expect(
|
||||
existsSync(path.join(repoRoot, "docker", "cloud-server-deps")),
|
||||
|
||||
@@ -21,7 +21,7 @@ import { describe, expect, it } from "vitest";
|
||||
const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..", "..", "..");
|
||||
const dockerfile = readFileSync(path.join(repoRoot, "Dockerfile"), "utf8");
|
||||
const workflow = readFileSync(path.join(repoRoot, ".github", "workflows", "docker.yml"), "utf8");
|
||||
const cloudWorkflow = readFileSync(path.join(repoRoot, ".github", "workflows", "docker-cloud.yml"), "utf8");
|
||||
const previewWorkflow = readFileSync(path.join(repoRoot, ".github", "workflows", "release.yml"), "utf8");
|
||||
|
||||
/**
|
||||
* Return the text of the Dockerfile stage that starts at the named target.
|
||||
@@ -68,12 +68,11 @@ describe("docker build-stamp wiring", () => {
|
||||
).toBeLessThan(serverBuildIdx);
|
||||
});
|
||||
|
||||
it("passes PAPERCLIP_BUILD_COMMIT as a build-arg for both image targets", () => {
|
||||
const argLines = [...`${workflow}\n${cloudWorkflow}`.matchAll(/^\s*PAPERCLIP_BUILD_COMMIT=.*$/gm)];
|
||||
expect(
|
||||
argLines.length,
|
||||
"the docker workflow must pass PAPERCLIP_BUILD_COMMIT for the production and cloud builds",
|
||||
).toBeGreaterThanOrEqual(2);
|
||||
it("passes PAPERCLIP_BUILD_COMMIT as a build-arg for standard and explicit preview builds", () => {
|
||||
for (const [name, source] of [["standard", workflow], ["preview", previewWorkflow]]) {
|
||||
expect(source, `${name} must pass the source commit into the image build`)
|
||||
.toMatch(/^\s*PAPERCLIP_BUILD_COMMIT=\$\{\{ (?:github.sha|inputs.source_ref) \}\}$/m);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
Reference in new issue
Block a user