fix(server): release settled receiver work during drain

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
DottaandPaperclip committed 2026-10-25 10:03:39 -05:00
1 parent f2338a2d2e
commit 8815dfad38
3 files changed
+25 -2

No files matched your search

@@ -43,3 +43,19 @@ followed by registration on resume without another producer. Production server
typecheck passes in /tmp/sleep19-drain-typecheck.log. These tests use the migrated typecheck passes in /tmp/sleep19-drain-typecheck.log. These tests use the migrated
paperclip_sleep19_drain_20261025_test database. Remote CI/review must run on the paperclip_sleep19_drain_20261025_test database. Remote CI/review must run on the
new head; this is not evidence of provider suspension. new head; this is not evidence of provider suspension.
## Receiver discovery — slice 20 / #17572
The strengthened first-receiver drain case fails with active=1 after commit in
/tmp/sleep20-drain-before.log. Apply the same owner-level pending predicate while
retaining all dirty scopes and lease/retry deadlines. All 19 receiver lifecycle
cases pass in /tmp/sleep20-drain-tests.log, including no SQL and an unchanged idle
snapshot for a minute after settlement, then receiver acquisition on resume.
Production server typecheck passes in /tmp/sleep20-drain-typecheck.log. The fresh
migrated database is paperclip_sleep20_drain_20261025_test.
The three configuration owners now have measured drain activity as well as traffic
checks. Their retained timers remain memory-only while paused; they do not provide
external wake coverage. Fresh remote CI/review and downstream propagation remain
required. Origin/master was refreshed to e335265568; the latest change removes
idle task-run UI polling and does not replace these worker repairs.
@@ -96,7 +96,12 @@ const support = external ? { supported: true } : await getEmbeddedPostgresTestSu
}); });
it("preserves the first receiver written during drain without passive SQL", async () => { it("preserves the first receiver written during drain without passive SQL", async () => {
await start(); await settled(); enabled = false; const row = await endpoint(); await start(); await settled(); enabled = false; const row = await endpoint();
await quiet(60_000); expect(reconcile).not.toHaveBeenCalled(); await vi.waitFor(async () => {
await vi.advanceTimersByTimeAsync(1000);
expect(idleWorkSnapshot().active).toBe(0);
});
const drained = idleWorkSnapshot();
await quiet(60_000); expect(idleWorkSnapshot()).toEqual(drained); expect(reconcile).not.toHaveBeenCalled();
enabled = true; await settled(); expect(reconcile).toHaveBeenCalledWith(row.id); enabled = true; await settled(); expect(reconcile).toHaveBeenCalledWith(row.id);
}); });
it("reconstructs after standby becomes primary without restarting the worker", async () => { it("reconstructs after standby becomes primary without restarting the worker", async () => {
@@ -79,7 +79,9 @@ export function registerChatReceiverWork(
} }
if (errors.length) throw new AggregateError(errors, "Chat receiver discovery could not settle"); if (errors.length) throw new AggregateError(errors, "Chat receiver discovery could not settle");
}, },
hasPending: async () => dirty.size > 0, // Preserve hints/deadlines for resume without holding settled intent during drain.
// The coordinator independently fences unresolved database transactions.
hasPending: async () => canRun() && dirty.size > 0,
nextRunAt: next, nextRunAt: next,
}); });
return { ready: worker.ready, changed(id: string) { return { ready: worker.ready, changed(id: string) {