From 7e2b1149616fe5184d69c92749df72c3a6e41e22 Mon Sep 17 00:00:00 2001
From: Nicky Leach <nicky@paperclip.ing>
Date: Fri, 19 Jun 2026 23:24:35 +0000
Subject: [PATCH] chore(qa): address headless Chromium script review

Adds explicit prerequisite checks, documents Playwright dependency-list drift, and replaces the cached .deb ls check with compgen.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
---
 scripts/qa/provision-headless-chromium.sh | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/scripts/qa/provision-headless-chromium.sh b/scripts/qa/provision-headless-chromium.sh
index e11bae361d5..1fe6f89a869 100755
--- a/scripts/qa/provision-headless-chromium.sh
+++ b/scripts/qa/provision-headless-chromium.sh
@@ -34,10 +34,20 @@ ENV_FILE="$PREFIX/pw-chromium-env.sh"
 
 log() { printf '\033[36m[provision]\033[0m %s\n' "$*" >&2; }
 
+for cmd in apt-cache apt-get dpkg-deb find grep sort paste; do
+  if ! command -v "$cmd" >/dev/null 2>&1; then
+    echo "ERROR: required command not found: $cmd" >&2
+    exit 1
+  fi
+done
+
 # Playwright 1.58 documented Chromium runtime packages for ubuntu24.04
 # (playwright-core/lib/server/registry/nativeDeps.js -> ubuntu24.04 chromium + a
 # few font packages so text actually paints). apt-cache --recurse expands the
 # full transitive closure from these roots.
+# NOTE: when bumping @playwright/test, re-derive this list from
+# node_modules/playwright-core/lib/server/registry/nativeDeps.js (ubuntu24.04
+# chromium entry) and update the version comment above.
 ROOTS=(
   libasound2t64 libatk-bridge2.0-0t64 libatk1.0-0t64 libatspi2.0-0t64
   libcairo2 libcups2t64 libdbus-1-3 libdrm2 libgbm1 libglib2.0-0t64
@@ -63,7 +73,7 @@ log "Downloading .debs into $DEBS (no root required)..."
   cd "$DEBS"
   dl=0; skip=0
   for p in "${CLOSURE[@]}"; do
-    if [ -n "$(ls "${p}_"*.deb 2>/dev/null)" ]; then dl=$((dl+1)); continue; fi
+    if compgen -G "${p}_*.deb" >/dev/null 2>&1; then dl=$((dl+1)); continue; fi
     if clean apt-get download "$p" >/dev/null 2>&1; then dl=$((dl+1)); else skip=$((skip+1)); fi
   done
   log "Downloaded/cached $dl, skipped $skip (virtual/unavailable)."