diff --git a/tests/runner-e2e/product-journeys/task-dependency-resume-evidence.test.ts b/tests/runner-e2e/product-journeys/task-dependency-resume-evidence.test.ts index c10c27f6896..4f9274544c1 100644 --- a/tests/runner-e2e/product-journeys/task-dependency-resume-evidence.test.ts +++ b/tests/runner-e2e/product-journeys/task-dependency-resume-evidence.test.ts @@ -76,6 +76,11 @@ describe("task dependency resume evidence", () => { const f = dependencyEvidenceFixture(); mutate(f); expect(gradeTaskDependencyResume(f).some(check => !check.passed)).toBe(true); }); + it.each(["issue_graph_liveness.backstop", "workspace.finalize"])("accepts the same automatic resume when the %s dependency wake recorded its source", source => { + const f = dependencyEvidenceFixture(); + for (const p of [f.finished, f.reopened]) for (const r of [...p.dependentRuns, ...p.agentRuns]) r.contextSnapshot.source = source; + expect(gradeTaskDependencyResume(f)).toEqual(TASK_DEPENDENCY_RESUME_CHECKS.map(id => ({ id, passed: true }))); + }); it("missing input never becomes a pass", () => { expect(gradeTaskDependencyResume(undefined).every(c => !c.passed)).toBe(true); }); it.each([null, {}, { summary: "Compacted result" }])("accepts the public run projection without duplicate finalization metadata: %j", resultJson => { const f = dependencyEvidenceFixture(); diff --git a/tests/runner-e2e/product-journeys/task-dependency-resume-evidence.ts b/tests/runner-e2e/product-journeys/task-dependency-resume-evidence.ts index d212a1f3ce2..4a9fc619ec7 100644 --- a/tests/runner-e2e/product-journeys/task-dependency-resume-evidence.ts +++ b/tests/runner-e2e/product-journeys/task-dependency-resume-evidence.ts @@ -7,6 +7,8 @@ export const TASK_DEPENDENCY_RESUME_CHECKS = [ "dependency-history-preserved", "configured-model-and-environment", ] as const; +const DEPENDENCY_WAKE_SOURCES: ReadonlySet = new Set(["issue.blockers_resolved", "issue_graph_liveness.backstop", "workspace.finalize"]); + export interface DependencyScope { companyId: string; userId: string; agentId: string; environmentId: string; provider: string; model: string; blockerId: string; blockerIdentifier: string; blockerTitle: string; blockerDescription: string; @@ -101,7 +103,7 @@ export function gradeTaskDependencyResume(value: DependencyEvidence | undefined) && nonempty(run?.id) && [reopened.dependentRuns[0], newRuns(finished)[0], newRuns(reopened)[0]].every(row => runFacts(row) === runFacts(run)) && run.companyId === s.companyId && run.agentId === s.agentId && dependencyRunIssueId(run) === s.dependentId && run.status === "succeeded" && run.invocationSource === "automation" && run.triggerDetail === "system" - && run.contextSnapshot?.wakeReason === "issue_blockers_resolved" && run.contextSnapshot?.source === "issue.blockers_resolved" + && run.contextSnapshot?.wakeReason === "issue_blockers_resolved" && DEPENDENCY_WAKE_SOURCES.has(run.contextSnapshot?.source) && run.contextSnapshot?.resolvedBlockerIssueId === s.blockerId && exactId(run.contextSnapshot?.blockerIssueIds, s.blockerId) && Number.isFinite(date(run.startedAt)) && date(run.startedAt) >= date(released.blocker.completedAt); const boundRun = scoped && [run, reopened.dependentRuns[0], newRuns(finished)[0], newRuns(reopened)[0]].every(row =>