From 7bf9fde51045c5a4c6060af8b1d7f99ae7de5f9e Mon Sep 17 00:00:00 2001 From: Dotta Date: Thu, 30 Apr 2026 09:49:21 -0500 Subject: [PATCH] Allow workflow-controlled review handoff Co-Authored-By: Paperclip --- server/src/routes/issues.ts | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/server/src/routes/issues.ts b/server/src/routes/issues.ts index 41e548c69aa..4942aa70533 100644 --- a/server/src/routes/issues.ts +++ b/server/src/routes/issues.ts @@ -2100,21 +2100,6 @@ export function issueRoutes( }); return; } - if ( - req.actor.type === "agent" && - req.body.assigneeUserId !== undefined && - req.body.assigneeUserId !== existing.assigneeUserId - ) { - res.status(403).json({ - error: "Agents cannot assign issues to users", - details: { - issueId: existing.id, - assigneeUserId: req.body.assigneeUserId ?? null, - securityPrinciples: ["Least Privilege", "Complete Mediation", "Fail Securely"], - }, - }); - return; - } if (normalizedAssigneeAgentId !== undefined) { updateFields.assigneeAgentId = normalizedAssigneeAgentId; } @@ -2147,6 +2132,22 @@ export function issueRoutes( }; } Object.assign(updateFields, transition.patch); + if ( + req.actor.type === "agent" && + req.body.assigneeUserId !== undefined && + req.body.assigneeUserId !== existing.assigneeUserId && + !transition.workflowControlledAssignment + ) { + res.status(403).json({ + error: "Agents cannot assign issues to users", + details: { + issueId: existing.id, + assigneeUserId: req.body.assigneeUserId ?? null, + securityPrinciples: ["Least Privilege", "Complete Mediation", "Fail Securely"], + }, + }); + return; + } if (reviewRequest !== undefined && transition.patch.executionState === undefined) { const existingExecutionState = parseIssueExecutionState(existing.executionState); if (!existingExecutionState || existingExecutionState.status !== "pending") {